Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- Leon Romanovsky | Independent Linux Consultant

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

On Wed, Dec 12, 2012 at 8:50 AM, Fubo Chen fubo.c...@gmail.com wrote: On Wed, Dec 12, 2012 at 5:12 PM, Leon Romanovsky l...@leon.nu wrote: On Wed, Dec 12, 2012 at 7:05 AM, Fubo Chen fubo.c...@gmail.com wrote: On Wed, Dec 12, 2012 at 3:37 PM, Namjae Jeon linkinj...@gmail.com wrote

Re: [PATCH] drivers: mfd: sec-code: Fix sizeof argument

On Fri, May 17, 2013 at 1:13 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Leon, On Wed, May 15, 2013 at 01:53:56PM +0300, Leon Romanovsky wrote: Signed-off-by: Leon Romanovsky l...@leon.nu --- drivers/mfd/sec-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] drivers: mfd: tps65912: Convert to use devm_kzalloc

Hi Samuel, On Wed, May 15, 2013 at 12:19 PM, Leon Romanovsky l...@leon.nu wrote: There is no need to call kfree while using devm_kzalloc, remove it from *_device_init function. Signed-off-by: Leon Romanovsky l...@leon.nu --- drivers/mfd/tps65912-core.c | 5 ++--- 1 file changed, 2

Re: [PATCH] drivers: mfd: sec-code: Fix sizeof argument

On Fri, May 17, 2013 at 8:58 PM, Joe Perches j...@perches.com wrote: On Fri, 2013-05-17 at 20:50 +0300, Leon Romanovsky wrote: On Fri, May 17, 2013 at 1:13 AM, Samuel Ortiz sa...@linux.intel.com wrote: On Wed, May 15, 2013 at 01:53:56PM +0300, Leon Romanovsky wrote: diff --git a/drivers/mfd

Re: [PATCH] drivers: mfd: tps65912: Convert to use devm_kzalloc

On Tue, May 28, 2013 at 7:24 PM, Andy Shevchenko andy.shevche...@gmail.com wrote: On Tue, May 28, 2013 at 12:02 PM, Lee Jones lee.jo...@linaro.org wrote: On Mon, 27 May 2013, Leon Romanovsky wrote: + init_data = devm_kzalloc(tps65912-dev, There is an obvious typo: no need of here if I

[PATCH] drivers: mfd: tps65912: Convert to use devm_kzalloc

There is no need to call kfree while using devm_kzalloc, remove it from *_device_init function. Signed-off-by: Leon Romanovsky l...@leon.nu --- drivers/mfd/tps65912-core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/tps65912-core.c b/drivers/mfd/tps65912

[PATCH] drivers: mfd: sec-code: Fix sizeof argument

Signed-off-by: Leon Romanovsky l...@leon.nu --- drivers/mfd/sec-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c index 77ee26ef..5b740a3 100644 --- a/drivers/mfd/sec-core.c +++ b/drivers/mfd/sec-core.c @@ -121,7 +121,7

[PATCH] drivers: mfd: sec-core: Remove explicit call to mfd_remove_devices

In case mfd_add_devices will fail, it will call to mfd_remove_devices by itself and return non-zero value. Signed-off-by: Leon Romanovsky l...@leon.nu --- drivers/mfd/sec-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c

Re: [PATCH] mm: page_alloc: Fix setting of ZONE_FAIR_DEPLETED on UP

#ifdef CONFIG_SMP 135 if (x 0) 136 x = 0; 137 #endif 138 return x; 139 } [1] https://git.kernel.org/cgit/linux/kernel/git/mhocko/mm.git/tree/include/linux/vmstat.h#n130 -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | l...@leon.nu

Re: [patch resend] mm: page_alloc: fix zone allocation fairness on UP

On Thu, Sep 11, 2014 at 3:36 PM, Johannes Weiner han...@cmpxchg.org wrote: On Wed, Sep 10, 2014 at 07:32:20AM +0300, Leon Romanovsky wrote: Hi Johaness, On Tue, Sep 9, 2014 at 4:15 PM, Johannes Weiner han...@cmpxchg.org wrote: The zone allocation batches can easily underflow due to higher

Re: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim

Hi Jaegeuk, + /* for batched trimming */ + int trim_sections; /* # of sections to trim */ I would like to suggest to declare trim_sections variable as an unsigned int and not int, since it can't be negative by definition. What do you think about it? -- To

[RFC] Refactor kenter/kleave/kdebug macros

/mn10300/mm/misalignment.c * fs/cachefiles/internal.h * fs/afs/internal.h * fs/fscache/internal.h * fs/binfmt_elf_fdpic.c * kernel/cred.c * mm/nommu.c * net/rxrpc/ar-internal.h * security/keys/internal.h Thank you. -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | l...@leon.nu

Re: [RFC] Refactor kenter/kleave/kdebug macros

On Sat, May 16, 2015 at 8:09 PM, Joe Perches j...@perches.com wrote: On Sat, 2015-05-16 at 20:01 +0300, Leon Romanovsky wrote: [] My question is how we should handle such duplicated debug print code? As possible solutions, I see five options: 1. Leave it as is. 2. Move it to general include

Re: [RFC] Refactor kenter/kleave/kdebug macros

implementation, it replaced by empty functions which is thrown by compiler. Additionally, It looks like the output of these macros can be viewed by ftrace mechanism. Maybe we should delete them from mm/nommu.c as was pointed by Joe? David -- Leon Romanovsky | Independent Linux

Re: [RFC] Refactor kenter/kleave/kdebug macros

On Mon, May 18, 2015 at 4:29 PM, David Howells dhowe...@redhat.com wrote: Leon Romanovsky l...@leon.nu wrote: Blind conversion to pr_debug will blow the code because it will be always compiled in. No, it won't. Sorry, you are right. Additionally, It looks like the output of these macros

[PATCH] mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel()

in if #define DEBUG is not declared prior to that macros. Signed-off-by: Leon Romanovsky l...@leon.nu --- mm/nommu.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/mm/nommu.c b/mm/nommu.c index e544508..7e5986b6 100644 --- a/mm/nommu.c +++ b/mm/nommu.c @@ -42,21

Re: [RFC] Refactor kenter/kleave/kdebug macros

On Mon, May 18, 2015 at 6:20 PM, David Howells dhowe...@redhat.com wrote: Leon Romanovsky l...@leon.nu wrote: Additionally, It looks like the output of these macros can be viewed by ftrace mechanism. *blink* It can? I was under strong impression that function and function_graph tracers

Re: [PATCH] mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel()

Sorry for this multiple resend, my mail client hid from me part of subject line :( On Mon, May 18, 2015 at 9:42 PM, Leon Romanovsky l...@leon.nu wrote: kenter/kleave/kdebug are wrapper macros to print functions flow and debug information. This set was written before pr_devel() was introduced

mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel()

in if #define DEBUG is not declared prior to that macros. Signed-off-by: Leon Romanovsky l...@leon.nu --- mm/nommu.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/mm/nommu.c b/mm/nommu.c index e544508..7e5986b6 100644 --- a/mm/nommu.c +++ b/mm/nommu.c @@ -42,21

mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel()

in if #define DEBUG is not declared prior to that macros. Signed-off-by: Leon Romanovsky l...@leon.nu --- mm/nommu.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/mm/nommu.c b/mm/nommu.c index e544508..7e5986b6 100644 --- a/mm/nommu.c +++ b/mm/nommu.c @@ -42,21

[PATCH] mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel()

in if #define DEBUG is not declared prior to that macros. Signed-off-by: Leon Romanovsky l...@leon.nu --- mm/nommu.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/mm/nommu.c b/mm/nommu.c index e544508..7e5986b6 100644 --- a/mm/nommu.c +++ b/mm/nommu.c @@ -42,21

Re: [PATCH] mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel()

On Tue, May 19, 2015 at 1:27 AM, Andrew Morton a...@linux-foundation.org wrote: On Mon, 18 May 2015 21:42:06 +0300 Leon Romanovsky l...@leon.nu wrote: kenter/kleave/kdebug are wrapper macros to print functions flow and debug information. This set was written before pr_devel() was introduced

Re: [PATCH RESEND] block:bounce: fix call inc_|dec_zone_page_state on different pages confuse value of NR_BOUNCE

/ . Don't email: a href=mailto:d...@kvack.org; em...@kvack.org /a -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | l...@leon.nu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [RFC PATCH 01/12] mm: add a new config to manage the code

...@kvack.org /a -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | l...@leon.nu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [RFC PATCH 01/12] mm: add a new config to manage the code

on 'x86_64_defconfig' # # configuration written to .config # ➜ linux-mm git:(dev) ✗ grep CONFIG_MEMORY_MIRROR .config CONFIG_MEMORY_MIRROR=y -Tony -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | l...@leon.nu -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] net, swap: Remove a warning and clarify why sk_mem_reclaim is required when deactivating swap

/ . Don't email: a href=mailto:d...@kvack.org; em...@kvack.org /a -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | l...@leon.nu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [RFC 2/3] mm: make optimistic check for swapin readahead

On Mon, Jun 15, 2015 at 5:05 PM, Rik van Riel r...@redhat.com wrote: On 06/14/2015 11:04 AM, Ebru Akagunduz wrote: This patch makes optimistic check for swapin readahead to increase thp collapse rate. Before getting swapped out pages to memory, checks them and allows up to a certain

Re: [RFC v3 4/4] shmem: Add support for generic FS events

} - if (error == -ENOSPC !once++) { + if (error == -ENOSPC) { + if (!once++) { info = SHMEM_I(inode); spin_lock(info-lock); shmem_recalc_inode(inode); spin_unlock(info-lock);

Re: [RFC v3 3/4] ext4: Add support for generic FS events

a message with 'unsubscribe linux-mm' in the body to majord...@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: a href=mailto:d...@kvack.org; em...@kvack.org /a -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | l...@leon.nu

Re: [RFC 2/3] mm: make optimistic check for swapin readahead

...@kvack.org /a -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | l...@leon.nu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [RFC 2/3] mm: make optimistic check for swapin readahead

On Mon, Jun 15, 2015 at 8:43 AM, Rik van Riel r...@redhat.com wrote: On 06/15/2015 01:40 AM, Leon Romanovsky wrote: On Sun, Jun 14, 2015 at 6:04 PM, Ebru Akagunduz ebru.akagun...@gmail.com wrote: This patch makes optimistic check for swapin readahead to increase thp collapse rate. Before

[PATCH v2] mm: nommu: refactor debug and warning prints

code * Change title to reflect new changes. It was [PATCH] mm: nommu: convert kenter/kleave/kdebug macros to use pr_devel() [3]. [1] https://lkml.org/lkml/2015/5/16/279 [2] https://lkml.org/lkml/2015/5/18/903 [3] https://lkml.org/lkml/2015/5/18/682 Signed-off-by: Leon Romanovsky l...@leon.nu

Re: [PATCH 2/5] x86, mpx: do not set -vm_ops on mpx VMAs

On Mon, Jul 13, 2015 at 3:29 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Leon Romanovsky wrote: Hi Kirill, On Mon, Jul 13, 2015 at 1:54 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: MPX setups private anonymous mapping, but uses vma-vm_ops too. This can

Re: [PATCH 2/5] x86, mpx: do not set -vm_ops on mpx VMAs

-- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majord...@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: a href=mailto:d...@kvack.org; em...@kvack.org /a -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | l

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani wrote: Please follow standard naming convention for the patches. It should be [PATCH v2 1/4] and not [PATCH 1/4 v2]. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On Tue, Oct 27, 2015 at 11:19 AM, Dan Carpenter <dan.carpen...@oracle.com> wrote: > On Sun, Oct 25, 2015 at 01:21:11PM +0200, Leon Romanovsky wrote: >> On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani >> <falakre...@gmail.com> wrote: >> Please

Re: [PATCH 1/1] staging: rdma: hfi1 : Prefer using the BIT macro

On Thu, Nov 05, 2015 at 05:28:03PM +0530, Sunny Kumar wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro > > Signed-off-by: Sunny Kumar > --- > drivers/staging/rdma/hfi1/user_sdma.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > /*

Re: [PATCH] fix return value error

On Wed, Oct 14, 2015 at 5:17 PM, Marciniszyn, Mike wrote: >> > Subject: [PATCH] fix return value error >> > >> >> I checked returns in configfs (-ENOMEM), proc (-ENOENT), proc-sys (- >> ENOMEM), ramfs (-ENOSPC), vfs (-ENOMEM). >> >> Not entirely consistent but this

Re: [PATCH] fix return value error

On Wed, Oct 14, 2015 at 11:17 AM, Heloise NH wrote: > Signed-off-by: Heloise NH The patch is a correct one, however can you update the subject and description to be more informative? Please add that new_inode() function can fail for allocation only. > --- >

Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON()

On Sun, Oct 04, 2015 at 07:04:06PM -0700, Davidlohr Bueso wrote: > On Sun, 04 Oct 2015, Leon Romanovsky wrote: > > >On Sun, Oct 4, 2015 at 9:18 AM, Geliang Tang <geliangt...@163.com> wrote: > >>BUG_ON() already contain an unlikely compiler flag. Drop it. > >

Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON()

lt; region->vm_end); > + BUG_ON(region->vm_start < last->vm_top); > > lastp = p; > } > -- > 2.5.0 > > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majord...@kvack.org. For mor

Re: [PATCH] IB/mlx4: use list_for_each_entry_safe in search_relocate_mgid0_group

group, mgid0_list); > + list_for_each_entry_safe(group, n, >mcg_mgid0_list, mgid0_list) { > mutex_lock(>lock); > if (group->last_req_tid == tid) { > if (memcmp(new_mgid, , sizeof mgid0)) { Thanks, Reviewed-by: Leon Romanovsky <leo

Re: [RFC PATCH v0] Add tw5864 driver

On Sun, Jan 03, 2016 at 03:41:42AM +0200, Andrey Utkin wrote: > +/* > + * TW5864 driver - Exp-Golomb code functions > + * > + * Copyright (C) 2015 Bluecherry, LLC > + * Copyright (C) 2015 Andrey Utkin I doubt that you have

Re: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function implementations

On Sun, Dec 27, 2015 at 01:36:30PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 27 Dec 2015 13:12:10 +0100 > Subject: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function > implementations Just a note for the future submissions (no need

Re: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function implementations

return directly instead of using the jump label "err" > in two functions (which are working without clean-up there). > > Markus Elfring (2): > One jump label less in iser_reg_sig_mr() > One jump label less in isert_reg_sig_mr() Looks good, Reviewed-by: Leon Romanovsky <leo

Re: [PATCH v2] IB/core: remove dead code

On Mon, Jun 06, 2016 at 10:15:06PM +0100, Sudip Mukherjee wrote: > prot_sg_cnt has been assigned with the value of ret which we have > already checked to be non-zero so prot_sg_cnt can never be zero at this > point of the code and hence the else part can never execute. > And since we know

Re: [PATCH v9 08/22] IB/hns: Add icm support

On Wed, Jun 01, 2016 at 11:37:50PM +0800, Lijun Ou wrote: > This patch mainly added icm support for RoCE. It initializes icm > which managers the relative memory blocks for RoCE. The data > structures of RoCE will be located in it. For example, CQ table, > QP table and MTPT table so on. I wonder

Re: [PATCH v9 05/22] IB/hns: Add initial profile resource

On Wed, Jun 01, 2016 at 11:37:47PM +0800, Lijun Ou wrote: > This patch mainly configured some profile resoure. For example, > vendor_id, hardware version, and some data structure sizes so on. > > Signed-off-by: Wei Hu > Signed-off-by: Nenglong Zhao

Re: [PATCH v9 09/22] IB/hns: Add hca support

On Wed, Jun 01, 2016 at 11:37:51PM +0800, Lijun Ou wrote: > This patch mainly setup hca for RoCE. It will do a series of > initial works, as follows: > 1. init uar table, allocate uar resource > 2. init pd table > 3. init cq table > 4. init mr table > 5. init qp table > >

Re: [PATCH] IB/core: remove dead code

On Sun, Jun 05, 2016 at 09:45:52PM +0100, Sudip Mukherjee wrote: > prot_sg_cnt has been assigned with the value of ret which we have > already checked to be non-zero so prot_sg_cnt can never be zero at this > point of the code and hence the else part can never execute. > > Signed-off-by: Sudip

Re: [PATCH 2/2] IB/sysfs: fix memory leak

On Mon, Jun 06, 2016 at 09:34:54AM +0300, Leon Romanovsky wrote: > On Sun, Jun 05, 2016 at 09:13:56PM +0100, Sudip Mukherjee wrote: > > If the allocation of hsag fails we were just returning but stats was > > not released. > > > > Signed-off-by: Sudip Mukherjee <s

Re: [PATCH v8 10/22] IB/hns: Add process flow to init RoCE engine

On Wed, May 25, 2016 at 11:05:13PM +0800, Lijun Ou wrote: > This patch mainly initialized the RoCE engine. It is absolutely > necessary to run RoCE. It mainly includes that configure DMAE > user, initialize doorbell and raq operations, enable port. > > Signed-off-by: Wei Hu

Re: [PATCH v9 11/22] IB/hns: Add IB device registration

On Sun, Jun 12, 2016 at 05:41:06PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/9 14:26, Leon Romanovsky wrote: > >On Wed, Jun 01, 2016 at 11:37:53PM +0800, Lijun Ou wrote: > >>This patch registered IB device when loaded, and unregistered > >>IB device when rem

Re: [PATCH 1/3] infiniband: rxe: avoid 64-bit division

On Mon, Jun 13, 2016 at 02:54:53PM +0200, Arnd Bergmann wrote: > The rxe driver fails to build on 32-bit because of a 64-bit division: > > In function `rxe_qp_from_attr': > :(.text+0x53158): undefined reference to `__aeabi_uldivmod' > > We can easily avoid this division by converting the

Re: [patch] IB/rxe: fix error code in rxe_srq_from_init()

On Mon, Jun 13, 2016 at 09:53:41AM +0300, Dan Carpenter wrote: > If copy_to_user() fails then it returns the number of bytes not copied. > It would be between 1-4 here. Later the callers dereference it leading > to an Oops. > > It was sort of hard to fix this without making the code confusing so

Re: [PATCH 1/2] IB/sysfs: fix NULL dereference

ll execute > once trying to free hsag->attrs[0]. But hsag is NULL still now leading > to a NULL pointer dereference. > > Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> > --- > drivers/infi

Re: [PATCH 2/2] IB/sysfs: fix memory leak

On Sun, Jun 05, 2016 at 09:13:56PM +0100, Sudip Mukherjee wrote: > If the allocation of hsag fails we were just returning but stats was > not released. > > Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> Thanks, Reviewed-by: Leon Romanovsky &l

Re: [PATCH v9 11/22] IB/hns: Add IB device registration

On Wed, Jun 01, 2016 at 11:37:53PM +0800, Lijun Ou wrote: > This patch registered IB device when loaded, and unregistered > IB device when removed. > > Signed-off-by: Wei Hu > Signed-off-by: Nenglong Zhao > Signed-off-by: Lijun Ou

Re: [PATCH v9 03/22] IB/hns: Add initial main frame driver and get cfg info

On Wed, Jun 01, 2016 at 11:37:45PM +0800, Lijun Ou wrote: > This patch mainly added the initial bare main driver. It > could get the relative configure information of net node. > > Signed-off-by: Wei Hu > Signed-off-by: Nenglong Zhao >

Re: [PATCH v10 06/22] IB/hns: Add initial cmd operation

On Tue, Jun 21, 2016 at 06:50:51PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/20 21:33, Leon Romanovsky wrote: > >On Thu, Jun 16, 2016 at 10:35:14PM +0800, Lijun Ou wrote: > >>This patch added the operation for cmd, and added some functions > >>for initializin

Re: [PATCH v10 08/22] IB/hns: Add icm support

On Tue, Jun 21, 2016 at 12:37:39PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/20 21:04, Leon Romanovsky wrote: > >On Mon, Jun 20, 2016 at 05:48:15PM +0800, Wei Hu (Xavier) wrote: > >> > >>On 2016/6/20 17:27, Leon Romanovsky wrote: > >>>On Mon, Jun

Re: [PATCH v10 06/22] IB/hns: Add initial cmd operation

On Tue, Jun 21, 2016 at 09:01:57PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/21 19:28, Leon Romanovsky wrote: > >On Tue, Jun 21, 2016 at 06:50:51PM +0800, Wei Hu (Xavier) wrote: > >> > >>On 2016/6/20 21:33, Leon Romanovsky wrote: > >>>On Thu, Jun

Re: [PATCH v10 08/22] IB/hns: Add icm support

On Thu, Jun 16, 2016 at 10:35:16PM +0800, Lijun Ou wrote: > This patch mainly added icm support for RoCE. It initializes icm > which managers the relative memory blocks for RoCE. The data > structures of RoCE will be located in it. For example, CQ table, > QP table and MTPT table so on. > >

Re: [PATCH v10 08/22] IB/hns: Add icm support

On Mon, Jun 20, 2016 at 12:37:40PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/17 17:58, Leon Romanovsky wrote: > >On Thu, Jun 16, 2016 at 10:35:16PM +0800, Lijun Ou wrote: > >>This patch mainly added icm support for RoCE. It initializes icm > >>which ma

Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%

ges now do not include line #, > but do include the function offset. > > Signed-off-by: Joe Perches <j...@perches.com> As far as I see all these functions are used in error paths, so no implication on performance is expected. And I'm fine with function offsets. Saeed, What do you thi

Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%

On Thu, Jun 23, 2016 at 08:27:01AM +0300, Leon Romanovsky wrote: > On Wed, Jun 22, 2016 at 11:23:59AM -0700, Joe Perches wrote: > > The logging macros create a bit of duplicated code/text. > > > > Use specialized functions to reduce the duplication. > > > > (def

Re: [PATCH v10 08/22] IB/hns: Add icm support

On Mon, Jun 20, 2016 at 05:48:15PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/20 17:27, Leon Romanovsky wrote: > >On Mon, Jun 20, 2016 at 03:49:24PM +0800, Wei Hu (Xavier) wrote: > >> > >>On 2016/6/20 14:06, Leon Romanovsky wrote: > >>>On Mon, Jun

Re: [PATCH v10 06/22] IB/hns: Add initial cmd operation

On Thu, Jun 16, 2016 at 10:35:14PM +0800, Lijun Ou wrote: > This patch added the operation for cmd, and added some functions > for initializing eq table and selecting cmd mode. > > Signed-off-by: Wei Hu > Signed-off-by: Nenglong Zhao >

Re: [PATCH v10 08/22] IB/hns: Add icm support

On Mon, Jun 20, 2016 at 03:49:24PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/20 14:06, Leon Romanovsky wrote: > >On Mon, Jun 20, 2016 at 12:37:40PM +0800, Wei Hu (Xavier) wrote: > >> > >>On 2016/6/17 17:58, Leon Romanovsky wrote: > >>>On Thu, Jun

Re: [PATCH v10 01/22] net: hns: Add reset function support for RoCE driver

> --- > PATCH v9/v8/v7: > - No change over PATCH v6 > > PATCH v6: > This fixes the comments given by Leon Romanovsky over the PATCH v5: > Link: https://lkml.org/lkml/2016/5/3/733 > > PATCH v5/v4/v3: > - No change over PATCH v2 > > PATCH v2: > This fixes the comment

Re: [PATCH v10 03/22] IB/hns: Add initial main frame driver and get cfg info

@hisilicon.com> > Signed-off-by: Lijun Ou <ouli...@huawei.com> > --- > PATCH v9: > This fixes comments given by Leon Romanovsky over the PATCH v8: > Link: https://lkml.org/lkml/2016/6/9/56 > > PATCH v8/v7/v6: > - No change over the PATCH v5 > > PATCH v5:

Re: [PATCH v10 00/22] Add HiSilicon RoCE driver

On Thu, Jun 16, 2016 at 10:35:08PM +0800, Lijun Ou wrote: > The HiSilicon Network Substem is a long term evolution IP which is > supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network > Sybsystem) also has a hardware support of performing RDMA with > RoCEE. > The driver for HiSilicon

Re: [PATCH v10 05/22] IB/hns: Add initial profile resource

@hisilicon.com> > Signed-off-by: Lijun Ou <ouli...@huawei.com> > --- > PATCH v9: > This fixes the comments given by Leon Romanovsky over the PATCH v8: > Link: https://lkml.org/lkml/2016/6/9/65 > > PATCH v8/v7/v6: > - No change over the PATCH v5 >

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

@hisilicon.com> > Signed-off-by: Lijun Ou <ouli...@huawei.com> > --- > PATCH v9/v8: > - No change over the PATCH v7 > > PATCH v7: > This fixes the comments given by Leon Romanovsky over the PATCH v6: > Link: https://lkml.org/lkml/2016/5/3/733 > > PATCH v6:

Re: [PATCH v10 09/22] IB/hns: Add hca support

5. init qp table > > Signed-off-by: Wei Hu <xavier.hu...@huawei.com> > Signed-off-by: Nenglong Zhao <zhaonengl...@hisilicon.com> > Signed-off-by: Lijun Ou <ouli...@huawei.com> > --- > PATCH v9: > This fixes the comments given by Leon Romanovsky over the PATCH v8

Re: [PATCH v10 07/22] IB/hns: Add event queue support

On Thu, Jun 16, 2016 at 10:35:15PM +0800, Lijun Ou wrote: > This patch added event queue support for RoCE driver. It is used > for RoCE interrupt. RoCE includes 32 synchronous event irqs, 1 > asynchronous event irq and 1 common overflow irq. > > Signed-off-by: Wei Hu >

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

On Fri, Jun 17, 2016 at 05:02:33PM +0200, Arnd Bergmann wrote: > On Friday, June 17, 2016 5:50:14 PM CEST Saeed Mahameed wrote: > > On Wed, Jun 15, 2016 at 11:50 PM, Arnd Bergmann wrote: > > > On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > > > Ok, I see. It

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

On Tue, Jun 28, 2016 at 02:31:41PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/27 16:31, oulijun wrote: > >Hi, Leon > >在 2016/6/27 16:01, Leon Romanovsky 写道: > >>On Sat, Jun 25, 2016 at 06:25:37PM +0800, Wei Hu (Xavier) wrote: > >>> > >>>O

Re: [PATCH v10 03/22] IB/hns: Add initial main frame driver and get cfg info

On Sat, Jun 25, 2016 at 06:29:31PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/24 19:48, Leon Romanovsky wrote: > >On Thu, Jun 16, 2016 at 10:35:11PM +0800, Lijun Ou wrote: > >>This patch mainly added the initial bare main driver. It > >>could get the relative

Re: [PATCH] nes: handling failed allocation when creating workqueue

Please see my minor comments below. Reviewed-by: Leon Romanovsky <l...@leon.nu> On Wed, Feb 17, 2016 at 01:06:33PM -0500, Insu Yun wrote: > Since create_singlethread_workqueue uses kzalloc internally, > it can be failed in memory pressure, so need to handle it. s/can be fai

Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller

On Sun, Feb 21, 2016 at 07:41:08PM +0530, Parav Pandit wrote: > CONFIG_CGROUP_RDMA > > On Sun, Feb 21, 2016 at 7:15 PM, Leon Romanovsky <l...@leon.nu> wrote: > > On Sun, Feb 21, 2016 at 05:03:05PM +0530, Parav Pandit wrote: > >> On Sun, Feb 21, 2016 at 1:13 PM,

Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller

On Sun, Feb 21, 2016 at 05:03:05PM +0530, Parav Pandit wrote: > On Sun, Feb 21, 2016 at 1:13 PM, Leon Romanovsky <l...@leon.nu> wrote: > > On Sat, Feb 20, 2016 at 04:30:04PM +0530, Parav Pandit wrote: > > Can you place this ifdef before declaring struct rdma_cgroup

Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller

On Sat, Feb 20, 2016 at 04:30:04PM +0530, Parav Pandit wrote: > Added rdma cgroup controller that does accounting, limit enforcement > on rdma/IB verbs and hw resources. > > Added rdma cgroup header file which defines its APIs to perform > charing/uncharing functionality and device registration

Re: [PATCH 2/3] net: hns: add Hisilicon RoCE support

On Mon, Mar 14, 2016 at 09:12:28AM +0800, Yankejian (Hackim Yim) wrote: > > > On 2016/3/12 18:43, Leon Romanovsky wrote: > > On Fri, Mar 11, 2016 at 06:37:10PM +0800, Lijun Ou wrote: > >> It added hns_dsaf_roce_reset routine for roce driver. > >> RoCE is a

Re: [PATCH 1/5] mlx4: add missing braces in verify_qp_parameters

m the > start, as the update_gid() function in the same patch correctly does. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: 54679e148287 ("mlx4: Implement QP paravirtualization and maintain > phys_pkey_cache for smp_snoop") Thanks, looks good. Reviewed-

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

On Fri, Mar 11, 2016 at 06:37:09PM +0800, Lijun Ou wrote: > The driver for Hisilicon RoCE is a platform driver. > The driver will support mulitple versions of hardware. Currently only "v1" > for hip06 SOC is supported. > The driver includes two parts: common driver and hardware-specific >

Re: [PATCH 2/3] net: hns: add Hisilicon RoCE support

On Fri, Mar 11, 2016 at 06:37:10PM +0800, Lijun Ou wrote: > It added hns_dsaf_roce_reset routine for roce driver. > RoCE is a feature of hns. > In hip06 SOC, in roce reset process, it's needed to configure > dsaf channel reset,port and sl map info. > > Signed-off-by: Lijun Ou

Re: [PATCH 0/3] infiniband: IB/hns: Hisilicon RoCE support

On Fri, Mar 11, 2016 at 06:37:08PM +0800, Lijun Ou wrote: 1) It is redundant to write "infiniband" and "IB" in one title to mention relevant subsystem, since it is the same. Please take a look on the other submissions here on the list and use similar construction. 2) Please use version number

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

On Wed, Mar 16, 2016 at 11:36:38AM +0100, Jiri Pirko wrote: > >so, I continue to have it. > > I will continue to bash on your odd codingstyle. Please fix it! Jiri, Checkpatch errors is an easiest issue with this patch. It is full of functions without use, unconnected macros and if you replace

Re: [PATCHv10 1/3] rdmacg: Added rdma cgroup controller

On Tue, Apr 05, 2016 at 05:55:26AM -0700, Parav Pandit wrote: > Hi Christoph, > > On Tue, Apr 5, 2016 at 5:42 AM, Christoph Hellwig wrote: > > On Tue, Apr 05, 2016 at 05:39:21AM -0700, Parav Pandit wrote: > >> I am not really trying to address OFED issues here. I am sure you

Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support

On Tue, Apr 05, 2016 at 03:32:53PM +0800, oulijun wrote: > >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c | 2832 > >> > >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.h | 985 +++ > > ^^ > > Do you support v1 of

Re: [PATCH] drivers/infiniband/hw/nes/nes_verbs.c: Deinline nes_free_qp_mem, save 1072 bytes

And after that feel free to add my RB tag. Reviewed-By: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: Digital signature

Re: [PATCH] Add tw5864 driver

On Mon, Mar 14, 2016 at 03:55:14AM +0200, Andrey Utkin wrote: > From: Andrey Utkin > > Support for boards based on Techwell TW5864 chip which provides > multichannel video & audio grabbing and encoding (H.264, MJPEG, > ADPCM G.726). > > Signed-off-by: Andrey

Re: [PATCH v3 2/3] IB/hns: Add HiSilicon RoCE driver support

On Sat, Mar 19, 2016 at 06:50:57PM +0800, Lijun Ou wrote: > The driver for HiSilicon RoCE is a platform driver. > The driver will support multiple versions of hardware. Currently only "v1" > for hip06 SoC is supported. > The driver includes two parts: common driver and hardware-specific >

Re: linux-next: Tree for Mar 23 (infiniband: mlx5)

On Wed, Mar 23, 2016 at 10:26:35AM -0700, Randy Dunlap wrote: > On 03/22/16 19:22, Stephen Rothwell wrote: > > Hi all, > > > > Please do not add any v4.7 related material to your linux-next included > > trees until after v4.6-rc1 is released. > > > > Changes since 20160322: > > > > on i386 or

Re: [PATCH] IB/mlx5: fix VFs callback function prototypes

off-by: Arnd Bergmann <a...@arndb.de> > Fixes: eff901d30e6c ("IB/mlx5: Implement callbacks for manipulating VFs") Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com>

Re: call attention to review

On Thu, Mar 24, 2016 at 01:50:30PM +0800, oulijun wrote: > Hi, >I am Lijun Ou. I have sent the PATCH v4 of HiSilicon RoCE driver at March > 22, 2016. > if you are convenient, please help to review. Welcome to give your reviewing. Hi Lijun, Please read whole document which describes how to

Re: [PATCH 4/4] infiniband: hns: add Hisilicon RoCE support(Kconfig)

On Fri, Mar 04, 2016 at 04:41:17PM +0800, Wei Hu(Xavier) wrote: > This submit add Kconfig. It needs be part of previous patch. > > Signed-off-by: Wei Hu(Xavier) > Signed-off-by: oulijun ^^^.. -- Is this first name or second

Re: [PATCH 0/4] infiniband: hns: Hisilicon RoCE support

On Fri, Mar 04, 2016 at 04:41:13PM +0800, Wei Hu(Xavier) wrote: > The Hisilicon Network Substem(hns) is a long term evolution IP which is > supposed to be used in Hisilicon ICT SoC. RoCE is a feature of hns. > The driver for Hisilicon RoCE engine is a platform driver. > The driver will support

  1   2   3   4   5   6   7   8   9   10   >