Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-30 Thread Linus Walleij
On Tue, Oct 30, 2012 at 12:34 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Sun, Oct 28, 2012 at 09:12:52PM +0100, Linus Walleij wrote: Moving this handling to bus code or anywhere else invariably implies that resource acquisition/release order does not matter, and my point

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-30 Thread Linus Walleij
this is enough, and pushing all handles into central code creates a problem elsewhere. (But I'm not so certain ... so I might just change opinion one of those days depending on what arguments will be made.) Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-30 Thread Linus Walleij
all affected systems to implement power domains, and effectively moving code from drivers/* to arch/arm/* in our case atleast. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-10-30 Thread Linus Walleij
maintainers in here. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[GIT PULL] GPIO fixes for v3.7

2012-10-30 Thread Linus Walleij
Hi Linus, here is a set of GPIO fixes accumulated since -rc1 that have been trickling in. Condensed description of the contents is in the tag. Please pull them in! Yours, Linus Walleij The following changes since commit ddffeb8c4d0331609ef2581d84de4d763607bd37: Linux 3.7-rc1 (2012-10-14 14

Re: [PATCH RESEND 1/5 v6] gpio: Add a block GPIO API to gpiolib

2012-10-31 Thread Linus Walleij
confused of this partitioning between using dynamic arrays and lists. Just use a list please. This part looks good. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip

2012-10-31 Thread Linus Walleij
/irq-versatile-fpga.h. Signed-off-by: Linus Walleij linus.wall...@linaro.org --- arch/arm/Kconfig | 4 +- arch/arm/mach-integrator/integrator_ap.c | 3 +- arch/arm/mach-integrator/integrator_cp.c | 2 +- arch/arm/mach-versatile/core.c

Fwd: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-11-01 Thread Linus Walleij
On Wed, Oct 31, 2012 at 9:10 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Linus Walleij linus.wall...@linaro.org writes: piece of hardware, this would be the right thing to do, and I think the in-kernel examples are all simple, e.g. arch/arm/mach-omap2/powerdomain* is all about

Re: [PATCH] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip

2012-11-01 Thread Linus Walleij
On Thu, Nov 1, 2012 at 2:02 AM, Rob Herring robherri...@gmail.com wrote: On 10/31/2012 04:31 PM, Linus Walleij wrote: rename arch/arm/plat-versatile/include/plat/fpga-irq.h = include/linux/platform_data/irq-versatile-fpga.h (100%) I think include/linux/irqchip/ is the right place. OK I'll

Re: Fwd: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-11-01 Thread Linus Walleij
? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCHv2] Input: omap4-keypad: Add pinctrl support

2012-11-01 Thread Linus Walleij
On Thu, Nov 1, 2012 at 1:07 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Nov 01, 2012 at 09:54:00AM +0100, Linus Walleij wrote: For the pin hogging I'd actually been thinking separately that we should just have the device core do a devm_pinctrl_get_set_default() prior

Re: [PATCH] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip

2012-11-01 Thread Linus Walleij
On Thu, Nov 1, 2012 at 10:12 AM, Thomas Petazzoni thomas.petazz...@free-electrons.com wrote: On Thu, 1 Nov 2012 10:00:19 +0100, Linus Walleij wrote: Sounds like a separate patch but surely we can do this. Is Thomas' stuff on a branch somewhere that I can then rebase upon to get it upstream? I

[PATCH v2] ARM: plat-versatile: move FPGA irq driver to drivers/irqchip

2012-11-01 Thread Linus Walleij
/irq-versatile-fpga.h. Signed-off-by: Linus Walleij linus.wall...@linaro.org --- ChangeLog v1-v2: - Moved include to linux/irqchip/versatile-fpga.h - Deleted merge/moval artifact --- arch/arm/Kconfig| 4 +- arch/arm/mach-integrator/integrator_ap.c| 3

Re: [PATCH] gpio-lpc32xx: Fix value handling of gpio_direction_output()

2012-09-24 Thread Linus Walleij
with Alexandre's ACK, should go into stable right? So tagging this with Cc: stable and sending for the -rc:s. Thanks, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/1] mfd: Provide the PRCMU with its own IRQ domain

2012-09-24 Thread Linus Walleij
Ortiz sa...@linux.intel.com Signed-off-by: Lee Jones lee.jo...@linaro.org This is good stuff. Acked-by: Linus Walleij linus.wall...@linaro.org Sam, please pick this up, IRQdomains are a pathway to many good things. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe

[PATCH] ARM: ux500: 8500: update I2C sleep states pinctrl

2012-09-25 Thread Linus Walleij
From: Patrice Chotard patrice.chot...@stericsson.com This defines the proper sleep states for all the I2C pins of the MOP500 DB8500 ASIC setting. Signed-off-by: Patrice Chotard patrice.chot...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- Requesting ARM SoC ACKs

Re: [PATCH] ARM: ux500: Move regulator-name properties out to board DTS files

2012-09-25 Thread Linus Walleij
; HREF and Snowball. Requested-by: Mark Brown broo...@opensource.wolfsonmicro.com Signed-off-by: Lee Jones lee.jo...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Thanks, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH RESEND] gpio-lpc32xx: Fix value handling of gpio_direction_output()

2012-09-26 Thread Linus Walleij
-by: Alexandre Pereira da Silva aletes@gmail.com --- Applies to v3.6-rc7 I will attempt to funnel this to Torvalds today. Thanks, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v1 01/12] clk: davinci - add Main PLL clock driver

2012-09-26 Thread Linus Walleij
instead. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] pinctrl: Fix potential memory leak in pinctrl_register_one_pin()

2012-09-26 Thread Linus Walleij
On Tue, Sep 25, 2012 at 9:11 AM, Sachin Kamat sachin.ka...@linaro.org wrote: 'pindesc' was not freed when returning from an error induced exit path. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Thanks, patch applied! Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH] ARM: ux500: Fix initialisation order for UIBs

2012-09-26 Thread Linus Walleij
. Here we ensure UIBs are only setup after all required infrastructure is already in place. Signed-off-by: Lee Jones lee.jo...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [RFC PATCH 2/17] input: RMI4 core bus and sensor drivers.

2012-09-26 Thread Linus Walleij
to be ideal for large configuration chunks, I haven't really used it. sysfs has this concept of one value per file, and that turns into the above serialization/marshalling code if followed, so it doesn't look good. Maybe configfs is the silver bullet. Yours, Linus Walleij -- To unsubscribe from

[PATCH] pinctrl: clarify idle vs sleep states

2012-09-26 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This pure documentation fix tries to align the idle and sleep pin states to the idle and suspend states from runtime PM. Signed-off-by: Linus Walleij linus.wall...@linaro.org --- include/linux/pinctrl/pinctrl-state.h | 8 +--- 1 file changed, 5

Re: replacement for /sys/kernel/debug/omap_mux in DT/pinctrl land ?

2012-09-26 Thread Linus Walleij
pinctrl-single driver, so Tony is the one to ask. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[PATCH] pinctrl/nomadik: allocate IRQ descriptors dynamically

2012-09-26 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This allocates the IRQ descriptors for the Nomadik pin controller dynamically so that we don't have to rely on some other mechanism doing it, and moving a step closer to a linear IRQ domain. Cc: Rob Herring rob.herr...@calxeda.com Signed-off-by: Linus

[GIT PULL] late gpio fix for v3.6

2012-09-26 Thread Linus Walleij
Hi Linus, here is a late fix for the GPIO subsystem from Roland Stigge. This one is going into the stable series so no point in holding it back. Please pull it in! Yours, Linus Walleij The following changes since commit 979570e02981d4a8fc20b3cc8fd651856c98ee9d: Linux 3.6-rc7 (2012-09-23 18

Re: [PATCH] pinctrl: pinctrl-single: add debugfs pin h/w state info

2012-09-27 Thread Linus Walleij
On Wed, Sep 26, 2012 at 9:07 PM, Matt Porter mpor...@ti.com wrote: Adds support for displaying the individual pin h/w config state. Signed-off-by: Matt Porter mpor...@ti.com Acked-by: Tony Lindgren t...@atomide.com Thanks, patch applied. Linus Walleij -- To unsubscribe from this list: send

Re: [PATCH] pinctrl/nomadik: allocate IRQ descriptors dynamically

2012-09-27 Thread Linus Walleij
On Thu, Sep 27, 2012 at 7:13 AM, Stephen Warren swar...@nvidia.com wrote: On 09/26/2012 11:18 AM, Linus Walleij wrote: + irq_start = NOMADIK_GPIO_TO_IRQ(pdata-first_gpio); Presumably that's a 1:1 mapping... Yep, albeit on a legacy domain to be able to keep the start irq. + irq_base

Re: [PATCH] pinctrl/nomadik: allocate IRQ descriptors dynamically

2012-09-27 Thread Linus Walleij
in the legacy case. It may need to be conditioned on SPARSE_IRQ. There's currently no callers, so it wouldn't break anything. OK get ready to ACK, I'll fix. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

[PATCH 2/4] irqdomain: augment add_simple() to allocate descs

2012-09-27 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org Currently we rely on all IRQ chip instances to dynamically allocate their IRQ descriptors unless they use the linear IRQ domain. So for irqdomain_add_legacy() and irqdomain_add_simple() the caller need to make sure that descriptors are allocated

[PATCH 4/4] ARM: nomadik/ux500: convert to SPARSE_IRQ

2012-09-27 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This converts the Nomadik and Ux500 over to using sparse IRQ, including some pokes around the pinctrl driver. To avoid referencing unnecessary header files, the plat-nomadik timer driver is augmented to pass an irq number at init time, and the change

[PATCH 1/4] pinctrl/nomadik: use irq_find_mapping()

2012-09-27 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org The code was using a homegrown method of looking up the offset from the irq domain, not to be encouraged. Use the proper irq_find_mapping() call instead. Cc: Lee Jones lee.jo...@linaro.org Cc: Rob Herring rob.herr...@calxeda.com Signed-off-by: Linus

[PATCH 3/4] pinctrl/nomadik: use simple or linear IRQ domain

2012-09-27 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This alters the Nomadik pinctrl driver to: - Call irqdomain_add_linear() for the DT case so we get all independent from IRQ numbers in this case. - Call irqdomain_add_simple() for the legacy case, which allocates the IRQ descriptors

Re: [PATCH 01/13] clk: davinci - add Main PLL clock driver

2012-09-27 Thread Linus Walleij
by platform code * phy_prediv: ... (...) */ struct clk_davinci_pll_data { u32 phy_pllm; u32 phy_prediv; (...) }; Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH v2] pinctrl: clarify idle vs sleep states

2012-09-28 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This pure documentation fix tries to align the idle and sleep pin states to the idle and suspend states from runtime PM. Cc: Patrice Chotard patrice.chot...@st.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- ChangeLog v1-v2: - I changed

Re: [PATCH 17/17] ARM: soc: dependency warnings for errata

2012-10-03 Thread Linus Walleij
PL310_ERRATA_753970 which has unmet direct dependencies (CACHE_PL310) warning: (ARCH_TEGRA_2x_SOC ARCH_TEGRA_3x_SOC UX500_SOC_COMMON) selects ARM_ERRATA_764369 which has unmet direct dependencies (CPU_V7 SMP) Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Linus Walleij linus.wall...@linaro.org Cc

Re: [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib

2012-10-03 Thread Linus Walleij
() parameters in the kernel. In this case it has the upside that it will be 32bit on 32bit systems and 64bit on 64bit systems if I'm not mistaken. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH RFC 1/2] gpio: Add a block GPIO API to gpiolib

2012-10-03 Thread Linus Walleij
it mainline. We, including you and Stijn *are* the mainline ... ;-) The only reason I really dislike it is that the GPIO sysfs interface is scary as it is, so I don't want to add to it if we can instead push to reform it into something more sane. Linus Walleij -- To unsubscribe from this list: send

Re: [PATCH 1/3] mfd: dbx500: Export prmcu_request_ape_opp_100_voltage

2012-10-05 Thread Linus Walleij
...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH][GPIO] Add IRQ edge setter to gpiolib

2012-10-05 Thread Linus Walleij
it if this is some lab board with GPIO or so, if it's some embedded GPIO controller within a laptop or something it surely should be in kernelspace. So please detail your usecase a bit... what is the code daemon etc in userspace poking around at these pins? What is is doing and why? Yours, Linus

Re: [PATCH 6/6] gpio: gpio-da9052: Convert to the new da9052 interrupt functions

2012-10-08 Thread Linus Walleij
On Thu, Oct 4, 2012 at 5:15 AM, Fabio Estevam feste...@gmail.com wrote: From: Fabio Estevam fabio.este...@freescale.com Convert to the new da9052 interrupt functions, so that we can get rid of irq_base references. Cc: Grant Likely grant.lik...@secretlab.ca Cc: Linus Walleij linus.wall

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-08 Thread Linus Walleij
On Fri, Oct 5, 2012 at 1:18 AM, Vivien Didelot vivien.dide...@gmail.com wrote: Grant, Linus, any feedback? On the entire driver or on the config fragment? The latter looks OK, I'll look at the driver per se now. (I was busy with the merge window you know...) Yours, Linus Walleij

Re: [PATCH] gpio: add TS-5500 DIO headers support

2012-10-08 Thread Linus Walleij
like how this hardcodes IRQ 1, 7, 6 to be used for this purpose, it's better to pass that in as resources from the platform. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 2/2] gpio: do not call __gpio_xxx under !CONFIG_GPIOLIB

2012-11-04 Thread Linus Walleij
value) { - might_sleep(); - __gpio_set_value(gpio, value); + WARN_ON(1); } Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] gpio: em: Fix build errors

2012-11-04 Thread Linus Walleij
On Wed, Oct 31, 2012 at 10:03 AM, Axel Lin axel@ingics.com wrote: Fix below build errors: Thanks for fixing my screwups! Patch applied to my devel branch where the patch causing the problems was. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: How about a gpio_get(device *, char *) function?

2012-11-04 Thread Linus Walleij
will have different opinions though so this is not the final word on this issue... Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] gpio: adnp: Depend on OF_GPIO instead of OF

2012-11-04 Thread Linus Walleij
this field. Signed-off-by: Thierry Reding thierry.red...@avionic-design.de Thanks! Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 1/2] Input: nomadik-ske-keypad - fixup use of clk

2012-11-04 Thread Linus Walleij
-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH 2/2] Input: nomadik-ske-keypad - start using the apb_pclk

2012-11-04 Thread Linus Walleij
this device actually has primecell registers. Then the bus will take care of the pclk for starters. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] gpio-mcp23s08: Build I2C support even when CONFIG_I2C=m

2012-11-04 Thread Linus Walleij
/kconfig.h if in doubt... Looking forward to v2! Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH] gpio-pch: Set parent dev for gpio chip

2012-11-04 Thread Linus Walleij
On Fri, Nov 2, 2012 at 4:02 PM, Alexander Stein alexander.st...@systec-electronic.com wrote: This will show the gpio chip as a child node under /sys/bus/pci/devices/:xx:xx.x/ Signed-off-by: Alexander Stein alexander.st...@systec-electronic.com Thanks, patch applied! Yours, Linus Walleij

Re: [PATCH 0/3] ACPI 5 support for GPIO, SPI and I2C

2012-11-04 Thread Linus Walleij
of GpioIO and GpioInt resources. This series adds support for these new resources. I would very much like Grant to review and merge these patches, since he is way more familiar with these concepts than me, but I'll have a quick glance for syntax and semantics... Yours, Linus Walleij -- To unsubscribe

Re: [PATCH] pinctrl: exynos: Add terminating entry for of_device_id table

2012-11-05 Thread Linus Walleij
On Fri, Nov 2, 2012 at 2:46 PM, Axel Lin axel@ingics.com wrote: The of_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin axel@ingics.com Thanks Axel, patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] pinctrl: nomadik: Add terminating entry for platform_device_id table

2012-11-05 Thread Linus Walleij
On Sun, Nov 4, 2012 at 4:30 PM, Axel Lin axel@ingics.com wrote: The platform_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin axel@ingics.com Thanks Axel, patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 1/3] gpio / ACPI: add ACPI support

2012-11-05 Thread Linus Walleij
be preferred. Can you please contribute to the parallel discussion on how to get rid of the global GPIO numberspace, thread named: How about a gpio_get(device *, char *) function? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: How about a gpio_get(device *, char *) function?

2012-11-05 Thread Linus Walleij
on top of the existing scheme to address my immediate needs - what you are talking about is much more scary. :) Could you elaborate on your motivations for such a radical direction? See above. I suspect Grant have similar thoughts, but let's see... Yours, Linus Walleij -- To unsubscribe from

Re: [PATCH 2/2] Input: nomadik-ske-keypad - start using the apb_pclk

2012-11-05 Thread Linus Walleij
On Mon, Nov 5, 2012 at 1:25 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 4 November 2012 19:12, Linus Walleij linus.wall...@linaro.org wrote: If I understand correctly, the only real solution is to implement the PM domains and have these enable the clocks. Agree. Although, since

Re: [PATCH 1/3] gpio / ACPI: add ACPI support

2012-11-05 Thread Linus Walleij
I just need to do it right now? ;-) I suggest to take it easy and prolong the deadline, but none of my business primarily, you will have to go through Grant who is probably way more reasonable than me. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Linus Walleij
device? If the addresses are not consecutive I guess you need to have one device driver bind to several devices and return -EPROBE_DEFER until the driver has been probed for all of them or something like that, this is what multi-block GPIO drivers sometimes do. Yours, Linus Walleij -- To unsubscribe

Re: [PATCH 1/3] gpio / ACPI: add ACPI support

2012-11-05 Thread Linus Walleij
On Mon, Nov 5, 2012 at 2:19 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Monday, November 05, 2012 02:11:03 PM Linus Walleij wrote: Do you think they will change their mind and give me green light if I tell them I just need to do it right now? ;-) Well, it's just a matter of fairness to me

Re: [PATCH] pinctrl: at91: Staticize non-exported symbols

2012-11-05 Thread Linus Walleij
On Mon, Nov 5, 2012 at 2:23 PM, Axel Lin axel@ingics.com wrote: Signed-off-by: Axel Lin axel@ingics.com Merged to my AT91 branch, unless Jean-Christophe says something... Thanks! Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 1/3] gpio / ACPI: add ACPI support

2012-11-05 Thread Linus Walleij
On Mon, Nov 5, 2012 at 2:50 PM, Rafael J. Wysocki r...@sisk.pl wrote: On Monday, November 05, 2012 02:28:45 PM Linus Walleij wrote: But since Grant merged the gpiolib-of.c thing and is still the main maintainer I can atleast chicken out by referring to him this time ... hit me back if he

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Linus Walleij
or register contents accessible from the main address. This has always been the case so far. You're right. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] pinctrl: u300: Staticize non-exported symbols

2012-11-06 Thread Linus Walleij
On Mon, Nov 5, 2012 at 2:42 PM, Axel Lin axel@ingics.com wrote: Staticize u300_pin_config_get() and u300_pin_config_set() functions. Signed-off-by: Axel Lin axel@ingics.com OK it still builds after this, patch applied! Thanks! Linus Walleij -- To unsubscribe from this list: send

Re: [PATCH v3 3/5] gpio: add viperboard gpio driver

2012-11-06 Thread Linus Walleij
maintain this. Reviewed-by: Linus Walleij linus.wall...@linaro.org Please get Sam to merge this through his MFD tree. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] pinctrl: sirf: Staticize non-exported symbol

2012-11-06 Thread Linus Walleij
On Mon, Nov 5, 2012 at 2:44 PM, Axel Lin axel@ingics.com wrote: Staticize sirfsoc_gpio_irq_map() function. Signed-off-by: Axel Lin axel@ingics.com Applied with Barry's ACK, thanks! Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH v2 1/2] mailbox: OMAP: introduce mailbox framework

2012-11-06 Thread Linus Walleij
On Tue, Nov 6, 2012 at 4:40 AM, Stephen Warren swar...@wwwdotorg.org wrote: Is this a public interface to the driver? If so, shouldn't the header be in include/linux somewhere? I think the split out of the public header is done in patch 2/2. Yours, Linus Walleij -- To unsubscribe from

Re: [PATCH v2] pinctrl: samsung: Add ifdef CONFIG_OF_GPIO guard for gc-of_node

2012-11-06 Thread Linus Walleij
platforms. So instead of adding the above #if, would it not be better to add 'select OF_GPIO' for Samsung pinctrl driver in drivers/pinctrl/Kconfig. ? Or edit the Samsung driver to depend on OF_GPIO, this is probably better. Yours, Linus Walleij -- To unsubscribe from this list: send the line

Re: [PATCH] pinctrl: PINCTRL_SAMSUNG and PINCTRL_EXYNOS4 need to depend on OF GPIOLIB

2012-11-06 Thread Linus Walleij
select PINCTRL_SAMSUNG, thus also make PINCTRL_EXYNOS4 depend on OF GPIOLIB. Signed-off-by: Axel Lin axel@ingics.com This looks good (maybe it should depend on OF_GPIO but who cares). Patch applied to my fixes branch after som patch -p1 foo.patch mockery. Yours, Linus Walleij

Re: [PATCH 1/3] gpio / ACPI: add ACPI support

2012-11-06 Thread Linus Walleij
On Tue, Nov 6, 2012 at 10:39 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Mon, Nov 05, 2012 at 03:40:14PM +0100, Linus Walleij wrote: I forgot to mention that we want to hook up _existing_ drivers to those things, and they already use the global GPIO numbers, don't

Re: [PATCH] ARM: dts: add missing ux500 device trees

2012-11-06 Thread Linus Walleij
On Tue, Nov 6, 2012 at 2:51 PM, Fabio Baltieri fabio.balti...@linaro.org wrote: This adds hrefprev60, hrefv60plus and ccu9540 to device trees compiled during build. Cc: Linus Walleij linus.wall...@linaro.org Acked-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Fabio Baltieri fabio.balti

[PATCH 1/5] gpiolib: fix up function prototypes etc

2012-11-06 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org Commit 69e1601bca88809dc118abd1becb02c15a02ec71 gpiolib: provide provision to register pin ranges Got most of it's function prototypes wrong, so fix this up by: - Moving the void declarations into static inlines in linux/gpio.h (previously

[PATCH 2/5] gpiolib-of: staticize the pin range calls

2012-11-06 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org Commit 69e1601bca88809dc118abd1becb02c15a02ec71 gpiolib: provide provision to register pin ranges Declared the of_gpiochip_[add|remove]_pin_range() global while they should be static as they are only ever used in this file. Let's convert them

[PATCH 3/5] gpiolib: remove duplicate pin range code

2012-11-06 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org Commit 69e1601bca88809dc118abd1becb02c15a02ec71 gpiolib: provide provision to register pin ranges Introduced both of_gpiochip_remove_pin_range() and gpiochip_remove_pin_ranges(). But the contents are exactly the same so remove the OF one and rely

[PATCH 4/5] gpiolib: call pin removal in chip removal function

2012-11-06 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This makes us call gpiochio_remove_pin_ranges() in the gpiochip_remove() function, so we get rid of ranges when freeing the chip. Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/gpio/gpiolib.c | 1 + 1 file changed, 1 insertion

[PATCH 5/5] gpiolib: separation of pin concerns

2012-11-06 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org The fact that of_gpiochip_add_pin_range() and gpiochip_add_pin_range() share too much code is fragile and will invariably mean that bugs need to be fixed in two places instead of one. So separate the concerns of gpiolib.c and gpiolib-of.c and have

[PATCH] gpiolib: iron out include ladder mistakes

2012-11-06 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org The */gpio.h includes are updated again: now we need to account for the problem introduced by commit: 595679a8038584df7b9398bf34f61db3c038bfea gpiolib: fix up function prototypes etc Actually we need static inlines in include/asm-generic/gpio.h

Re: How about a gpio_get(device *, char *) function?

2012-11-07 Thread Linus Walleij
) { return gpio_get_value(g-gpio); } (...) Then we can work from there. I think it adds the proper opaqueness factor. I don't really like the gpioh_* prefix instead of just gpio_* but I guess there is not polymorphism to exploit as transition path here :-P Yours, Linus Walleij -- To unsubscribe from

Re: How about a gpio_get(device *, char *) function?

2012-11-07 Thread Linus Walleij
day 1, so just a little, little bit more to shield us. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[GIT PULL] pinctrl fixes for v3.7 rc:s

2012-11-08 Thread Linus Walleij
Hi Linus, here is a set of pinctrl fixes for the current -rc series. Details in the signed tag. Please pull it in! Yours, Linus Walleij The following changes since commit 8f0d8163b50e01f398b14bcd4dc039ac5ab18d64: Linux 3.7-rc3 (2012-10-28 12:24:48 -0700) are available in the git repository

[PATCH 1/2] ARM: ux500: add PRCM register base for pinctrl

2012-11-08 Thread Linus Walleij
Signed-off-by: Linus Walleij linus.wall...@linaro.org --- ARM SoC guys: this patch is better contained in the pinctrl tree, can I have your ACK to push it through pinctrl? Thanks. --- arch/arm/mach-ux500/cpu-db8500.c | 2 +- arch/arm/mach-ux500/devices-common.h | 8 +++- 2 files changed, 8

[PATCH 2/2] pinctrl/nomadik: make independent of prcmu driver

2012-11-08 Thread Linus Walleij
and skip a layer of indirection. Cc: Loic Pallardy loic.palla...@st.com Signed-off-by: Jonas Aaberg jonas.ab...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/pinctrl/pinctrl-nomadik-db8500.c | 4 +-- drivers/pinctrl/pinctrl-nomadik-db8540.c | 4 +-- drivers

Re: [PATCH 1/5] gpiolib: fix up function prototypes etc

2012-11-08 Thread Linus Walleij
On Wed, Nov 7, 2012 at 6:09 AM, Viresh Kumar viresh.ku...@linaro.org wrote: On 6 November 2012 20:46, Linus Walleij linus.wall...@stericsson.com -void gpiochip_add_pin_range(struct gpio_chip *chip, const char *pinctl_name, - unsigned int pin_base, unsigned int npins); -void

Re: [PATCH 3/5] gpiolib: remove duplicate pin range code

2012-11-08 Thread Linus Walleij
On Wed, Nov 7, 2012 at 6:14 AM, viresh kumar viresh.ku...@linaro.org wrote: On Tue, Nov 6, 2012 at 8:46 PM, Linus Walleij linus.wall...@stericsson.com wrote: From: Linus Walleij linus.wall...@linaro.org Commit 69e1601bca88809dc118abd1becb02c15a02ec71 gpiolib: provide provision to register

Re: [PATCH] gpiolib: iron out include ladder mistakes

2012-11-08 Thread Linus Walleij
On Tue, Nov 6, 2012 at 10:40 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 11/06/2012 09:21 AM, Linus Walleij wrote: And we need to keep the static inlines in linux/gpio.h but here for the !CONFIG_GENERIC_GPIO case, and then we may as well throw in a few warnings like the other

Re: linux-next: build failure after merge of the final tree (pinctrl tree related)

2012-11-08 Thread Linus Walleij
of struct gpio_chip :-P Fixing up and respinning the patch, I've added the compulsory return value as well. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH v2] gpiolib: iron out include ladder mistakes

2012-11-08 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org The */gpio.h includes are updated again: now we need to account for the problem introduced by commit: 595679a8038584df7b9398bf34f61db3c038bfea gpiolib: fix up function prototypes etc Actually we need static inlines in include/asm-generic/gpio.h

Re: [PATCHv2] gpio-mcp23s08: Build I2C support even when CONFIG_I2C=m

2012-11-08 Thread Linus Walleij
checks for either since building both this driver and I2C as modules is possible. Signed-off-by: Daniel M. Weeks d...@danweeks.net Thanks, patch merged to my fixes branch. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH 2/2] gpio: tegra: fix suspend/resume apis

2012-11-08 Thread Linus Walleij
Dewangan ldewan...@nvidia.com OK patch applied to my devel branch, with Stephens ACK and I also fixed the whitespace issue he pointed out. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH V2] gpio: tegra: fix suspend/resume apis

2012-11-08 Thread Linus Walleij
On Thu, Nov 8, 2012 at 5:22 AM, Laxman Dewangan ldewan...@nvidia.com wrote: Changes from V1: - It was 2/2/ for prev patch and dropping 1/2. - nit cleanup in change. - Added ack from Stephen as it is acked in 2/2. Oh I didn't see you respun it yourself. Anyway it's applied now. Yours, Linus

Re: [PATCH 1/2] gpio: tegra: Staticize non-exported symbols

2012-11-08 Thread Linus Walleij
On Thu, Nov 8, 2012 at 3:45 AM, Axel Lin axel@ingics.com wrote: Both tegra_gpio_request() and tegra_gpio_free() are not referenced outside of this file, make them static. Signed-off-by: Axel Lin axel@ingics.com Applied with Stephen's ACK. Yours, Linus Walleij -- To unsubscribe from

Re: [PATCH 2/2] gpio: tegra: Drop exporting static functions

2012-11-08 Thread Linus Walleij
On Thu, Nov 8, 2012 at 3:47 AM, Axel Lin axel@ingics.com wrote: Both tegra_gpio_enable() and tegra_gpio_disable() are static functions, it does not make sense to export them. Signed-off-by: Axel Lin axel@ingics.com Applied with Stephen's ACK. Yours, Linus Walleij -- To unsubscribe

Re: [PATCH] gpio: mvebu: Set free callback for gpio_chip

2012-11-08 Thread Linus Walleij
. Signed-off-by: Axel Lin axel@ingics.com Applied with Thomas' ACK, thanks! Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [RFC PATCH] gpiolib: Refactor gpio_export

2012-10-19 Thread Linus Walleij
)) { + status = PTR_ERR(dev); + goto fail_unlock; Since this involves clean-up in the form of unlocking the mutex this goto is fine however. Same for unregister_device:. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH V3] gpio: samsung: use pr_* instead of printk

2012-10-19 Thread Linus Walleij
On Wed, Oct 17, 2012 at 3:52 AM, Jingoo Han jg1@samsung.com wrote: This patch uses pr_* instead of printk. Also, gpio_dbg is replaced with pr_debug. Signed-off-by: Jingoo Han jg1@samsung.com Reviewed-by: Linus Walleij linus.wall...@linaro.org - NAK Please consult Documentation

Re: [PATCH 6/7] gpio/langwell: find the irq domain mapping

2012-10-19 Thread Linus Walleij
On Wed, Oct 17, 2012 at 9:26 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Tue, Oct 16, 2012 at 09:23:23PM +0200, Linus Walleij wrote: Switch from creating the IRQ domain mapping to finding it. In this case we know very well that the driver has created the apropriate mapping

Re: [PATCH 7/7] gpio/tegra: convert to use linear irqdomain

2012-10-19 Thread Linus Walleij
On Wed, Oct 17, 2012 at 8:32 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 10/16/2012 04:33 PM, Stephen Warren wrote: On 10/16/2012 01:23 PM, Linus Walleij wrote: The MXS driver tries to do the work of irq_domain_add_linear() by reserving a bunch of descriptors somewhere and keeping track

Re: [PATCH 4/7] gpio/mxs: convert to use linear irqdomain

2012-10-19 Thread Linus Walleij
generic-irq will have to use irq_domain_add_legacy. Bah, I'm dropping this and a lot of the other patches as well. I obviously do not understand the inner transcendental meaning of irqdomains yet. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH RFC 2/6 v3] gpio: Add sysfs support to block GPIO API

2012-10-19 Thread Linus Walleij
On Thu, Oct 18, 2012 at 6:38 AM, Daniel Glöckner daniel...@gmx.net wrote: On Mon, Oct 15, 2012 at 10:30:15PM +0200, Linus Walleij wrote: Another patch that is circulating concerns edge triggers and similar, and it appear that some parts of the GPIO sysfs is for example redefining

Re: [PATCH RFC 02/15 v5] gpio: Add sysfs support to block GPIO API

2012-10-19 Thread Linus Walleij
The block GPIO stuff is just following that design pattern. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

  1   2   3   4   5   6   7   8   9   10   >