Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

2017-10-24 Thread Manivannan Sadhasivam
On 19 October 2017 at 02:27, Amit Kucheria <amit.kuche...@linaro.org> wrote: > Enable panic and disk activity triggers to tie to LED activity > > Signed-off-by: Amit Kucheria <amit.kuche...@linaro.org> Acked-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org>

[PATCH v2 3/3] clk: actions: Add clock driver for Actions S900 SoC

2017-11-06 Thread Manivannan Sadhasivam
Add clock driver for Actions Semi OWL series S900 SoC Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- Changes in v2: 1. Changed the directory structure to actions/ and used owl- prefix for sources. 2. Fixed MAINTAINERS and added Andreas as Designated Revie

[PATCH v2 0/3] Add clock driver for Actions S900 SoC

2017-11-06 Thread Manivannan Sadhasivam
-96 board. Thanks, Mani Manivannan Sadhasivam (3): dt-bindings: clock: Add Actions S900 clock bindings arm64: dts: actions: Add S900 clock management unit nodes clk: actions: Add clock driver for Actions S900 SoC .../devicetree/bindings/clock/actions,s900-cmu.txt | 47 ++ MAINTAINERS

[PATCH v2 2/3] arm64: dts: actions: Add S900 clock management unit nodes

2017-11-06 Thread Manivannan Sadhasivam
Add Actions Semi S900 Clock Management Unit (CMU) nodes Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- Changes in v2: 1. Fixed commit message 2. Changed "diff_24M" to "diff24M" 3. Changed clock-controller node name to "cmu" 4.

[PATCH v2 1/3] dt-bindings: clock: Add Actions S900 clock bindings

2017-11-06 Thread Manivannan Sadhasivam
Add Actions Semi S900 clock bindings. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- Changes in v2: 1. Added binding header to this patch 2. Changed clock-controller node name to cmu 3. Added clocks property to cmu node 4. Changed compatible property

Re: [PATCH 1/3] arm64: dts: actions: add s900 clock controller nodes

2017-11-02 Thread Manivannan Sadhasivam
Hi Rob, On 2 November 2017 at 05:36, Rob Herring <r...@kernel.org> wrote: > On Wed, Nov 01, 2017 at 01:24:21AM +0530, Manivannan Sadhasivam wrote: >> This patch adds clock controller nodes for Actions Semi s900 SoC >> >> Signed-off-by: Manivannan Sadhasivam <ma

Re: [PATCH 1/3] arm64: dts: actions: add s900 clock controller nodes

2017-11-04 Thread Manivannan Sadhasivam
Hi Rob, On Wed, Nov 01, 2017 at 07:06:16PM -0500, Rob Herring wrote: > On Wed, Nov 01, 2017 at 01:24:21AM +0530, Manivannan Sadhasivam wrote: > > This patch adds clock controller nodes for Actions Semi s900 SoC > > > > Signed-off-by: Manivannan Sadhasivam <manivann

Re: [PATCH 2/3] clk: owl: add clock driver for Actions S900 SoC

2017-11-04 Thread Manivannan Sadhasivam
11.2017 um 03:54 schrieb Manivannan Sadhasivam: > > This patch adds clock driver for Actions Semi OWL > > series S900 SoC. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> > > --- > > MAINTAINERS

Re: [PATCH 3/3] Documentation: add Actions S900 clock bindings

2017-11-04 Thread Manivannan Sadhasivam
On Wed, Nov 01, 2017 at 07:04:48PM -0500, Rob Herring wrote: > On Wed, Nov 01, 2017 at 01:24:23AM +0530, Manivannan Sadhasivam wrote: > > This patch adds clock bindings for Actions Semi S900 SoC. > > "dt-bindings: clock: " for the subject. > > This patch should

Re: [PATCH 3/3] Documentation: add Actions S900 clock bindings

2017-11-04 Thread Manivannan Sadhasivam
Hi Andreas, On Sat, Nov 04, 2017 at 04:55:04PM +0800, Andreas Färber wrote: > Am 01.11.2017 um 03:54 schrieb Manivannan Sadhasivam: > > This patch adds clock bindings for Actions Semi S900 SoC. > > "This patch" > Ack. > > > > Signed-off-by: M

Re: [PATCH 1/3] arm64: dts: actions: add s900 clock controller nodes

2017-11-04 Thread Manivannan Sadhasivam
Hi Andreas, On Sat, Nov 04, 2017 at 04:43:31PM +0800, Andreas Färber wrote: > Am 01.11.2017 um 03:54 schrieb Manivannan Sadhasivam: > > This patch adds clock controller nodes for Actions Semi s900 SoC > > Please avoid "This patch". Once applied, it's a commit. :) &g

Re: [PATCH 2/3] clk: owl: add clock driver for Actions S900 SoC

2017-11-04 Thread Manivannan Sadhasivam
On Sat, Nov 04, 2017 at 05:30:36PM +0800, Andreas Färber wrote: > Hi, > > Am 04.11.2017 um 17:19 schrieb Manivannan Sadhasivam: > >>> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile > >>> index c99f363..821c1e1 100644 > >>> --- a/drivers/

Re: [PATCH 0/3] Add clock driver for Actions S900 SoC

2017-11-04 Thread Manivannan Sadhasivam
On Sat, Nov 04, 2017 at 05:05:31PM +0800, Andreas Färber wrote: > Hi Mani, > > Am 01.11.2017 um 03:54 schrieb Manivannan Sadhasivam: > > This series adds clock driver for Actions Semi OWL series > > S900 SoC with relevant clock bindings and device tree data. > > >

Re: [PATCH 2/3] clk: owl: add clock driver for Actions S900 SoC

2017-11-06 Thread Manivannan Sadhasivam
On Wed, Nov 01, 2017 at 07:02:46PM -0500, Rob Herring wrote: > On Wed, Nov 01, 2017 at 01:24:22AM +0530, Manivannan Sadhasivam wrote: > > This patch adds clock driver for Actions Semi OWL > > series S900 SoC. > > > > Signed-off-by: Manivannan Sadhasivam <ma

Re: [PATCH 3/3] Documentation: add Actions S900 clock bindings

2017-11-06 Thread Manivannan Sadhasivam
On Wed, Nov 01, 2017 at 07:04:48PM -0500, Rob Herring wrote: > On Wed, Nov 01, 2017 at 01:24:23AM +0530, Manivannan Sadhasivam wrote: > > This patch adds clock bindings for Actions Semi S900 SoC. > > "dt-bindings: clock: " for the subject. > > This patch should

[PATCH 1/3] arm64: dts: actions: add s900 clock controller nodes

2017-10-31 Thread Manivannan Sadhasivam
This patch adds clock controller nodes for Actions Semi s900 SoC Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- arch/arm64/boot/dts/actions/s900.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900.d

[PATCH 2/3] clk: owl: add clock driver for Actions S900 SoC

2017-10-31 Thread Manivannan Sadhasivam
This patch adds clock driver for Actions Semi OWL series S900 SoC. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- MAINTAINERS| 5 + drivers/clk/Makefile | 1 + drivers/clk/owl/Ma

[PATCH 0/3] Add clock driver for Actions S900 SoC

2017-10-31 Thread Manivannan Sadhasivam
board. Thanks, Mani Manivannan Sadhasivam (3): arm64: dts: actions: add s900 clock controller nodes clk: owl: add clock driver for Actions S900 SoC Documentation: add Actions S900 clock bindings .../bindings/clock/actions,s900-clock.txt | 47 ++ MAINTAINERS

[PATCH 3/3] Documentation: add Actions S900 clock bindings

2017-10-31 Thread Manivannan Sadhasivam
This patch adds clock bindings for Actions Semi S900 SoC. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- .../bindings/clock/actions,s900-clock.txt | 47 ++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devi

[PATCH 4/5] pinctrl: actions: Add gpio support for Actions S900 SoC

2018-05-17 Thread Manivannan Sadhasivam
Add gpio support to pinctrl driver for Actions Semi S900 SoC. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- drivers/pinctrl/actions/Kconfig| 1 + drivers/pinctrl/actions/pinctrl-owl.c | 206 + drivers/pinctrl/a

[PATCH 3/5] arm64: dts: actions: Add gpio line names to Bubblegum-96 board

2018-05-17 Thread Manivannan Sadhasivam
Add gpio line names to Actions Semi S900 based Bubblegum-96 board. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- arch/arm64/boot/dts/actions/s900-bubblegum-96.dts | 175 ++ 1 file changed, 175 insertions(+) diff --git a/arch/arm64/bo

[PATCH 1/5] dt-bindings: pinctrl: Add gpio bindings for Actions S900 SoC

2018-05-17 Thread Manivannan Sadhasivam
Add gpio bindings for Actions Semi S900 SoC. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- .../devicetree/bindings/pinctrl/actions,s900-pinctrl.txt| 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/p

[PATCH 5/5] MAINTAINERS: Add Actions Semi S900 pinctrl entries

2018-05-17 Thread Manivannan Sadhasivam
Add S900 pinctrl entries under ARCH_ACTIONS Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 640dabc4c311..9e1a17c9b4a7 100644 --- a/MAINTAINERS +++ b/MAINT

[PATCH 0/5] Add gpio support for Action Semi S900 SoC

2018-05-17 Thread Manivannan Sadhasivam
and gpio support, excluding the dropped patches mentioned above. Thanks, Mani Manivannan Sadhasivam (5): dt-bindings: pinctrl: Add gpio bindings for Actions S900 SoC arm64: dts: actions: Add gpio properties to pinctrl node for S900 arm64: dts: actions: Add gpio line names to Bubblegum-96 board

[PATCH 2/5] arm64: dts: actions: Add gpio properties to pinctrl node for S900

2018-05-17 Thread Manivannan Sadhasivam
Add gpio properties to pinctrl node for Actions Semi S900 SoC. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- arch/arm64/boot/dts/actions/s900.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900.dtsi b/arch/arm64/bo

Re: [PATCH 4/5] pinctrl: actions: Add gpio support for Actions S900 SoC

2018-05-19 Thread Manivannan Sadhasivam
Hi Christian, On Sat, May 19, 2018 at 11:18:53AM +0200, Christian Lamparter wrote: > On Friday, May 18, 2018 4:30:55 AM CEST Manivannan Sadhasivam wrote: > > Add gpio support to pinctrl driver for Actions Semi S900 SoC. > > > > Signed-off-by: Manivannan Sadhasiva

[PATCH v2 0/5] Add gpio support for Action Semi S900 SoC

2018-05-19 Thread Manivannan Sadhasivam
and gpio support, excluding the dropped patches mentioned above. Thanks, Mani Changes in v2: * Removed gpiochip_add_pin_range() function and added gpio-ranges property in DT. * Added Reviewed-by tag from Andy. Manivannan Sadhasivam (5): dt-bindings: pinctrl: Add gpio bindings for Actions S900 SoC

[PATCH v2 4/5] pinctrl: actions: Add gpio support for Actions S900 SoC

2018-05-19 Thread Manivannan Sadhasivam
Add gpio support to pinctrl driver for Actions Semi S900 SoC. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> --- drivers/pinctrl/actions/Kconfig| 1 + drivers/pinctrl/actions/pinctrl-

[PATCH v2 1/5] dt-bindings: pinctrl: Add gpio bindings for Actions S900 SoC

2018-05-19 Thread Manivannan Sadhasivam
Add gpio bindings for Actions Semi S900 SoC. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- .../devicetree/bindings/pinctrl/actions,s900-pinctrl.txt | 16 1 file changed, 16 insertions(+) diff --git a/Documentation/devicetree/bindings/p

[PATCH v2 3/5] arm64: dts: actions: Add gpio line names to Bubblegum-96 board

2018-05-19 Thread Manivannan Sadhasivam
Add gpio line names to Actions Semi S900 based Bubblegum-96 board. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- arch/arm64/boot/dts/actions/s900-bubblegum-96.dts | 175 ++ 1 file changed, 175 insertions(+) diff --git a/arch/arm64/bo

[PATCH v2 2/5] arm64: dts: actions: Add gpio properties to pinctrl node for S900

2018-05-19 Thread Manivannan Sadhasivam
Add gpio properties to pinctrl node for Actions Semi S900 SoC. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- arch/arm64/boot/dts/actions/s900.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900.dtsi b/arch/arm64/bo

[PATCH v2 5/5] MAINTAINERS: Add Actions Semi S900 pinctrl entries

2018-05-19 Thread Manivannan Sadhasivam
Add S900 pinctrl entries under ARCH_ACTIONS Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 640dabc4c311..9e1a17c9b4a7 100644 --- a/MAINTAINERS +++ b/MAINT

Re: [PATCH v2 5/5] MAINTAINERS: Add Actions Semi S900 pinctrl entries

2018-05-25 Thread Manivannan Sadhasivam
On Fri, May 25, 2018 at 02:12:06PM +0200, Linus Walleij wrote: > On Fri, May 25, 2018 at 7:01 AM, Manivannan Sadhasivam > <manivannan.sadhasi...@linaro.org> wrote: > > > FYI, I have ordered S700 based Cubieboard and will work on adding support > > for > > that

Re: [PATCH v2 5/5] MAINTAINERS: Add Actions Semi S900 pinctrl entries

2018-05-24 Thread Manivannan Sadhasivam
Hi Andreas, On Fri, May 25, 2018 at 06:12:00AM +0200, Andreas Färber wrote: > Am 23.05.2018 um 10:40 schrieb Linus Walleij: > > On Sun, May 20, 2018 at 7:17 AM, Manivannan Sadhasivam > > <manivannan.sadhasi...@linaro.org> wrote: > > > >> Add S90

Re: [PATCH] pinctrl: actions: Fix uninitialized error in owl_pin_config_set()

2018-06-08 Thread Manivannan Sadhasivam
ion > > Indeed, if num_configs is zero, the uninitialized value will be returned > as an error code. > > Fix this by preinitializing it to zero. > > Fixes: 2242ddfbf4d699b5 ("pinctrl: actions: Add Actions S900 pinctrl driver") > Signed-off-by: Geert Uytterhoeven

[PATCH 0/2] Add Mediatek X20 Development Board support

2018-05-28 Thread Manivannan Sadhasivam
in 96Boards product page: https://www.96boards.org/product/mediatek-x20/ Manivannan Sadhasivam (2): dt-bindings: Add vendor prefix for ArcherMind arm64: dts: Add Mediatek X20 Development Board support .../devicetree/bindings/vendor-prefixes.txt | 1 + arch/arm64/boot/dts/mediatek/Makefile

[PATCH 1/2] dt-bindings: Add vendor prefix for ArcherMind

2018-05-28 Thread Manivannan Sadhasivam
Add vendor prefix for ArcherMind Technology (Nanjing) Co., Ltd. Signed-off-by: Manivannan Sadhasivam --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree

[PATCH 2/2] arm64: dts: Add Mediatek X20 Development Board support

2018-05-28 Thread Manivannan Sadhasivam
Add initial device tree support for Mediatek X20 Development Board based on MT6797 Deca core SoC. This board is one of the 96Boards Consumer Edition platform. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/mediatek/Makefile | 1 + .../boot/dts/mediatek/mt6797-x20-dev.dts

Re: [PATCH 0/2] Add Mediatek X20 Development Board support

2018-05-29 Thread Manivannan Sadhasivam
ubblegum-96 board in parallel. At most I can guarentee that this board's functionality will be added gradually in upcoming days. Thanks, Mani > Regards, > Matthias > > On 29/05/18 06:52, Manivannan Sadhasivam wrote: > > Add devicetree support for Mediatek X20 Development Boar

[PULL REQUEST] arm: Actions DT for v4.18

2018-05-31 Thread Manivannan Sadhasivam
to fetch changes up to b2a2e190e41c92e10aec8440c4207efc8abd0643: MAINTAINERS: Add Actions Semi S900 clk entries (2018-05-31 15:17:34 +0530) Manivannan Sadhasivam (8): arm64: dts: actions: Add S900 clock management unit nodes

Re: [PATCH 3/3] pinctrl: actions: Add interrupt support for OWL S900 SoC

2018-06-03 Thread Manivannan Sadhasivam
Hi Andy, On Sun, Jun 03, 2018 at 11:37:53AM +0300, Andy Shevchenko wrote: > On Sat, Jun 2, 2018 at 7:54 PM, Manivannan Sadhasivam > wrote: > > Add interrupt support for Actions Semi OWL S900 SoC. > > > + port = owl_gpio_get_port(pctrl, ); > > +

[PATCH 2/3] arm64: dts: actions: Add interrupt properties to pinctrl node for S900

2018-06-02 Thread Manivannan Sadhasivam
Add interrupt properties to pinctrl node for Actions Semi S900 SoC. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/actions/s900.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900.dtsi b/arch/arm64/boot/dts/actions/s900.dtsi index

[PATCH 3/3] pinctrl: actions: Add interrupt support for OWL S900 SoC

2018-06-02 Thread Manivannan Sadhasivam
Add interrupt support for Actions Semi OWL S900 SoC. Signed-off-by: Manivannan Sadhasivam --- drivers/pinctrl/actions/Kconfig| 1 + drivers/pinctrl/actions/pinctrl-owl.c | 231 - drivers/pinctrl/actions/pinctrl-owl.h | 22 ++- drivers/pinctrl/actions/pinctrl

[PATCH 1/3] dt-bindings: pinctrl: Add gpio interrupt bindings for Actions S900 SoC

2018-06-02 Thread Manivannan Sadhasivam
Add gpio interrupt bindings for Actions Semi S900 SoC. Signed-off-by: Manivannan Sadhasivam --- .../bindings/pinctrl/actions,s900-pinctrl.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/actions,s900-pinctrl.txt b

[PATCH 0/3] Add gpio interrupt support for Actions Semi S900 SoC

2018-06-02 Thread Manivannan Sadhasivam
This patchset adds interrupt support for Actions Semi S900 GPIO's. Each port has individual register sets for configuring the below interrupt types: 1. Rising Edge Interrupt 2. Falling Edge Interrupt 3. High Level Interrupt 4. Low Level Interrupt Thanks, Mani Manivannan Sadhasivam (3): dt

[PATCH v2 2/2] arm64: dts: Add Mediatek X20 Development Board support

2018-06-05 Thread Manivannan Sadhasivam
Add initial device tree support for Mediatek X20 Development Board based on MT6797 Deca core SoC. This board is one of the 96Boards Consumer Edition platform. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/mediatek/Makefile | 1 + .../boot/dts/mediatek/mt6797-x20-dev.dts

[PATCH v2 1/2] dt-bindings: arm: mediatek: Document Mediatek X20 Development Board

2018-06-05 Thread Manivannan Sadhasivam
Document Mediatek X20 Development Board which is a 96Boards Consumer Edition platform based on MT6797 SoC. Signed-off-by: Manivannan Sadhasivam --- Documentation/devicetree/bindings/arm/mediatek.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/arm

[PATCH v2 0/2] Add Mediatek X20 Development Board support

2018-06-05 Thread Manivannan Sadhasivam
in 96Boards product page: https://www.96boards.org/product/mediatek-x20/ Thanks, Mani Changes in v2: * Added documentation for board compatible * Dropped vendor documetation patch since it got applied Manivannan Sadhasivam (2): dt-bindings: arm: mediatek: Document Mediatek X20 Development

[PATCH] MAINTAINERS: Add Actions Semi S900 clk entries

2018-05-31 Thread Manivannan Sadhasivam
Add S900 clk entries under ARCH_ACTIONS Signed-off-by: Manivannan Sadhasivam --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 48bfffe..964cd28 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1143,12 +1143,14 @@ N: owl F: arch/arm

Re: [PATCH v2 1/3] arm64: dts: actions: Enable clock controller for S700

2018-06-30 Thread Manivannan Sadhasivam
On Thu, Jun 28, 2018 at 09:18:03PM +0200, Saravanan Sekar wrote: > Added clock management controller for S700 > > Signed-off-by: Parthiban Nallathambi > Signed-off-by: Saravanan Sekar > --- > .../boot/dts/actions/s700-cubieboard7.dts | 7 - > arch/arm64/boot/dts/actions/s700.dtsi

Re: [PATCH v2 5/6] i2c: Add Actions Semi OWL family S900 I2C driver

2018-06-30 Thread Manivannan Sadhasivam
Hi Andy, On Sat, Jun 30, 2018 at 03:14:37PM +0300, Andy Shevchenko wrote: > On Thu, Jun 28, 2018 at 9:10 PM, Manivannan Sadhasivam > wrote: > > Add Actions Semi OWL family S900 I2C driver. > > > +#include > > +#include > > +#include > >

Re: [PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-07-01 Thread Manivannan Sadhasivam
Hi Peter, On Sun, Jul 01, 2018 at 06:57:54AM +0200, Peter Rosin wrote: > On June 30, 2018 3:33:29 PM GMT+02:00, Manivannan Sadhasivam > wrote: > >Add Actions Semiconductor Owl family S900 I2C driver. > > > >Signed-off-by: Manivannan Sadhasivam > >--- > >

Re: [PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-07-01 Thread Manivannan Sadhasivam
Hi Andy, On Sun, Jul 01, 2018 at 12:11:00AM +0300, Andy Shevchenko wrote: > On Sat, Jun 30, 2018 at 4:33 PM, Manivannan Sadhasivam > wrote: > > Add Actions Semiconductor Owl family S900 I2C driver. > > Thanks for an update. Few left comments and it would LGTM. > Thank

Re: [PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-07-01 Thread Manivannan Sadhasivam
On Sun, Jul 01, 2018 at 01:43:33PM +0530, Manivannan Sadhasivam wrote: > Hi Andy, > > On Sun, Jul 01, 2018 at 12:11:00AM +0300, Andy Shevchenko wrote: > > On Sat, Jun 30, 2018 at 4:33 PM, Manivannan Sadhasivam > > wrote: > > > Add Actions Semiconductor Owl family S9

Re: [PATCH v2 3/3] dt-bindings: clock: Modify Actions Soc clock bindings

2018-07-01 Thread Manivannan Sadhasivam
Hi Andreas, On Sun, Jul 01, 2018 at 07:58:15PM +0200, Andreas Färber wrote: > Hi, > > Am 01.07.2018 um 19:37 schrieb Manivannan Sadhasivam: > > On Sun, Jul 01, 2018 at 07:26:20PM +0200, Saravanan Sekar wrote: > >> Hi Mani > >> > >> > >> On 06

Re: [PATCH v2 1/3] arm64: dts: actions: Enable clock controller for S700

2018-07-01 Thread Manivannan Sadhasivam
Hi, On Sun, Jul 01, 2018 at 07:50:01PM +0200, Saravanan Sekar wrote: > Hi Mani, > > > On 06/30/18 11:42, Manivannan Sadhasivam wrote: > > On Thu, Jun 28, 2018 at 09:18:03PM +0200, Saravanan Sekar wrote: > > > Added clock management controller for S700 > >

Re: [PATCH][next] pinctrl: actions: fix unsigned less than zero comparison

2018-07-02 Thread Manivannan Sadhasivam
Hi Colin, On Mon, Jul 02, 2018 at 01:15:04PM +0100, Colin King wrote: > From: Colin Ian King > > The check to see if platform_get_irq failed is performed on the > unsigned value of pctrl->irq[i] and the check is never true because > an unsigned cannot be less than zero. Fix this by assinging

Re: [PATCH][V2] pinctrl: actions: fix unsigned less than zero comparison

2018-07-02 Thread Manivannan Sadhasivam
Signed-off-by: Colin Ian King Thanks! Acked-by: Manivannan Sadhasivam Regards, Mani > --- > > V2: move pctrl->irq[i] = ret assignment below the check on ret, thanks > to Manivannan Sadhasivam for suggesting this change. > > --- > drivers/pinctrl/actions/pinctr

Re: [PATCH 5/5] i2c: Add Actions Semi OWL family S900 I2C driver

2018-06-26 Thread Manivannan Sadhasivam
Hi Andy, Thanks for the review! On Mon, Jun 25, 2018 at 12:38:50PM +0300, Andy Shevchenko wrote: > On Sat, Jun 23, 2018 at 7:11 PM, Manivannan Sadhasivam > wrote: > > Add Actions Semi OWL family S900 I2C driver. > > > > Signed-off-by: Manivannan Sadhasivam > &g

Re: [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS

2018-06-26 Thread Manivannan Sadhasivam
Hi Andreas, On Sun, Jun 24, 2018 at 03:04:21PM +0200, Andreas Färber wrote: > Hi Mani, > > Am 11.04.2018 um 18:40 schrieb Manivannan Sadhasivam: > > Define power domains for Actions Semi S900 SoC Smart Power System (SPS). > > > > Signed-off-by: Manivannan Sadhasivam

Re: [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS

2018-06-27 Thread Manivannan Sadhasivam
On Wed, Jun 27, 2018 at 03:57:13PM +0100, Daniel Thompson wrote: > On Tue, Jun 26, 2018 at 10:11:17PM +0530, Manivannan Sadhasivam wrote: > > > > diff --git a/include/dt-bindings/power/owl-s900-powergate.h > > > > b/include/dt-bindings/power/owl-s900-powergate.h &

[PATCH v2 2/3] arm64: dts: actions: Add interrupt properties to pinctrl node for S900

2018-06-22 Thread Manivannan Sadhasivam
Add interrupt properties to pinctrl node for Actions Semi S900 SoC. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/actions/s900.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900.dtsi b/arch/arm64/boot/dts/actions/s900.dtsi index

[PATCH v2 0/3] Add gpio interrupt support for Actions Semi S900 SoC

2018-06-22 Thread Manivannan Sadhasivam
Changes in v2: * Removed custom IRQ domain implementation and used GPIO_IRQCHIP with multi parents based on gpio-tegra186.c * Added support for emulating interrupt on both edges * Added parentheses to the expression as spotted by Linus * Added Rob's Reviewed-by tag for bindings patch Manivannan

[PATCH v2 1/3] dt-bindings: pinctrl: Add gpio interrupt bindings for Actions S900 SoC

2018-06-22 Thread Manivannan Sadhasivam
Add gpio interrupt bindings for Actions Semi S900 SoC. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Rob Herring --- .../bindings/pinctrl/actions,s900-pinctrl.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/actions,s900

[PATCH v2 3/3] pinctrl: actions: Add interrupt support for OWL S900 SoC

2018-06-22 Thread Manivannan Sadhasivam
Add interrupt support for Actions Semi OWL S900 SoC. Signed-off-by: Manivannan Sadhasivam --- drivers/pinctrl/actions/Kconfig| 1 + drivers/pinctrl/actions/pinctrl-owl.c | 271 - drivers/pinctrl/actions/pinctrl-owl.h | 22 +- drivers/pinctrl/actions/pinctrl

[PATCH 5/5] i2c: Add Actions Semi OWL family S900 I2C driver

2018-06-23 Thread Manivannan Sadhasivam
Add Actions Semi OWL family S900 I2C driver. Signed-off-by: Manivannan Sadhasivam --- drivers/i2c/busses/Kconfig | 7 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-owl.c | 459 +++ 3 files changed, 467 insertions(+) create mode 100644

[PATCH 4/5] arm64: dts: actions: Enable I2C1 and I2C2 in Bubblegum-96 board

2018-06-23 Thread Manivannan Sadhasivam
Enable I2C1 and I2C2 exposed on the low speed expansion connector in Bubblegum-96 board. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/actions/s900-bubblegum-96.dts | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900-bubblegum-96.dts

[PATCH 2/5] arm64: dts: actions: Add Actions Semi S900 I2C controller nodes

2018-06-23 Thread Manivannan Sadhasivam
Add I2C controller nodes for Actions Semi S900 SoC. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/actions/s900.dtsi | 60 +++ 1 file changed, 60 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900.dtsi b/arch/arm64/boot/dts/actions/s900.dtsi

[PATCH 1/5] dt-bindings: i2c: Add binding for Actions Semi OWL I2C controller

2018-06-23 Thread Manivannan Sadhasivam
Add devicetree binding for Actions Semi OWL I2C controller Signed-off-by: Manivannan Sadhasivam --- .../devicetree/bindings/i2c/i2c-owl.txt | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt diff --git

[PATCH 3/5] arm64: dts: actions: Add pinctrl definition for S900 I2C controller

2018-06-23 Thread Manivannan Sadhasivam
Add pinctrl definition for Actions Semi S900 I2C controller. Pinctrl definitions are only available for I2C0, I2C1, and I2C2. Signed-off-by: Manivannan Sadhasivam --- .../dts/actions/s900-bubblegum-96-pins.dtsi | 29 +++ 1 file changed, 29 insertions(+) create mode 100644

[PATCH 0/5] Add Actions Semi S900 I2C support

2018-06-23 Thread Manivannan Sadhasivam
-96 board utilizing the S900 SoC, only I2C1 and I2C2 which are exposed on the Low speed expansion connector are enabled. Thanks, Mani Manivannan Sadhasivam (5): dt-bindings: i2c: Add binding for Actions Semi OWL I2C controller arm64: dts: actions: Add Actions Semi S900 I2C controller nodes

Re: [PATCH v2 5/6] i2c: Add Actions Semi OWL family S900 I2C driver

2018-06-30 Thread Manivannan Sadhasivam
Hi Peter, Thanks for the review! On Fri, Jun 29, 2018 at 06:45:19AM +0200, Peter Rosin wrote: > On June 28, 2018 8:10:41 PM GMT+02:00, Manivannan Sadhasivam > wrote: > >Add Actions Semi OWL family S900 I2C driver. > > > >Signed-off-by: Manivannan Sadhasivam >

Re: [PATCH v2 5/6] i2c: Add Actions Semi OWL family S900 I2C driver

2018-06-30 Thread Manivannan Sadhasivam
Hi Andy, On Sat, Jun 30, 2018 at 04:04:20PM +0300, Andy Shevchenko wrote: > On Sat, Jun 30, 2018 at 3:44 PM, Manivannan Sadhasivam > wrote: > > On Sat, Jun 30, 2018 at 03:14:37PM +0300, Andy Shevchenko wrote: > >> On Thu, Jun 28, 2018 at 9:10 PM, Manivannan S

[PATCH v3 2/6] arm64: dts: actions: Add Actions Semiconductor S900 I2C controller nodes

2018-06-30 Thread Manivannan Sadhasivam
Add I2C controller nodes for Actions Semiconductor S900 SoC. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/actions/s900.dtsi | 60 +++ 1 file changed, 60 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900.dtsi b/arch/arm64/boot/dts/actions/s900

[PATCH v3 3/6] arm64: dts: actions: Add pinctrl definition for S900 I2C controller

2018-06-30 Thread Manivannan Sadhasivam
Add pinctrl definition for Actions Semiconductor S900 I2C controller. Pinctrl definitions are only available for I2C0, I2C1, and I2C2. Signed-off-by: Manivannan Sadhasivam --- .../dts/actions/s900-bubblegum-96-pins.dtsi | 29 +++ 1 file changed, 29 insertions(+) create mode

[PATCH v3 4/6] arm64: dts: actions: Enable I2C1 and I2C2 in Bubblegum-96 board

2018-06-30 Thread Manivannan Sadhasivam
Enable I2C1 and I2C2 exposed on the low speed expansion connector in Bubblegum-96 board. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/actions/s900-bubblegum-96.dts | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900-bubblegum-96.dts

[PATCH v3 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-06-30 Thread Manivannan Sadhasivam
Add Actions Semiconductor Owl family S900 I2C driver. Signed-off-by: Manivannan Sadhasivam --- drivers/i2c/busses/Kconfig | 7 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-owl.c | 477 +++ 3 files changed, 485 insertions(+) create mode

[PATCH v3 0/6] Add Actions Semiconductor Owl S900 I2C support

2018-06-30 Thread Manivannan Sadhasivam
ied certain dev_warn to dev_dbg * Modified the error handling to more generic pattern * Fixed the return value in owl_i2c_master_xfer * Added MAINTAINERS patch for I2C driver and its binding Manivannan Sadhasivam (6): dt-bindings: i2c: Add binding for Actions Semiconductor Owl I2C controller

[PATCH v3 1/6] dt-bindings: i2c: Add binding for Actions Semiconductor Owl I2C controller

2018-06-30 Thread Manivannan Sadhasivam
Add devicetree binding for Actions Semiconductor Owl I2C controller Signed-off-by: Manivannan Sadhasivam --- .../devicetree/bindings/i2c/i2c-owl.txt | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt diff --git

[PATCH v3 6/6] MAINTAINERS: Add entry for Actions Semiconductor Owl I2C driver

2018-06-30 Thread Manivannan Sadhasivam
Add entry for Actions Semiconductor Owl I2C driver under ARM/ACTIONS Signed-off-by: Manivannan Sadhasivam --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 09b54e9ebc6f..5084c62712fa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1145,12

Re: [PATCH v2 2/3] clk: actions: Add S700 SoC clock support

2018-06-30 Thread Manivannan Sadhasivam
Hi Saravanan, On Thu, Jun 28, 2018 at 09:18:04PM +0200, Saravanan Sekar wrote: > Add Actions Semi S700 SoC clock support > > Signed-off-by: Parthiban Nallathambi > Signed-off-by: Saravanan Sekar > --- > drivers/clk/actions/Kconfig| 7 + > drivers/clk/actions/Makefile | 1 + >

Re: [PATCH v2 3/3] dt-bindings: clock: Modify Actions Soc clock bindings

2018-06-30 Thread Manivannan Sadhasivam
Hi Saravanan, I agree with modifying the existing binding to accomodate other SoC's of the same family. But the binding should be "actions,owl-cmu.txt" since it reflects the family name. Andreas, what do you think? On Thu, Jun 28, 2018 at 09:18:05PM +0200, Saravanan Sekar wrote: > Modify clock

Re: [PATCH v2 1/6] dt-bindings: i2c: Add binding for Actions Semi OWL I2C controller

2018-06-30 Thread Manivannan Sadhasivam
Hi Andreas, On Sat, Jun 30, 2018 at 02:23:30PM +0200, Andreas Färber wrote: > Am 28.06.2018 um 20:10 schrieb Manivannan Sadhasivam: > > Add devicetree binding for Actions Semi OWL I2C controller > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > .../de

Re: [PATCH v2 2/3] clk: actions: Add S700 SoC clock support

2018-07-01 Thread Manivannan Sadhasivam
On Sun, Jul 01, 2018 at 07:23:58PM +0200, Saravanan Sekar wrote: > > > On 06/30/18 11:22, Manivannan Sadhasivam wrote: > > Hi Saravanan, > > > > On Thu, Jun 28, 2018 at 09:18:04PM +0200, Saravanan Sekar wrote: > > > Add Actions Semi S700 SoC clock support &

[PATCH v4 2/6] arm64: dts: actions: Add pinctrl definition for S900 I2C controller

2018-07-01 Thread Manivannan Sadhasivam
Add pinctrl definition for Actions Semiconductor S900 I2C controller. Pinctrl definitions are only available for I2C0, I2C1, and I2C2. Signed-off-by: Manivannan Sadhasivam --- .../dts/actions/s900-bubblegum-96-pins.dtsi | 29 +++ 1 file changed, 29 insertions(+) create mode

[PATCH v4 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-07-01 Thread Manivannan Sadhasivam
Add Actions Semiconductor Owl family S900 I2C driver. Signed-off-by: Manivannan Sadhasivam --- drivers/i2c/busses/Kconfig | 7 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-owl.c | 504 +++ 3 files changed, 512 insertions(+) create mode

[PATCH v4 6/6] MAINTAINERS: Add entry for Actions Semiconductor Owl I2C driver

2018-07-01 Thread Manivannan Sadhasivam
Add entry for Actions Semiconductor Owl I2C driver under ARM/ACTIONS Signed-off-by: Manivannan Sadhasivam --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 09b54e9ebc6f..5084c62712fa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1145,12

[PATCH v4 1/6] dt-bindings: i2c: Add binding for Actions Semiconductor Owl I2C controller

2018-07-01 Thread Manivannan Sadhasivam
Add devicetree binding for Actions Semiconductor Owl I2C controller Signed-off-by: Manivannan Sadhasivam --- .../devicetree/bindings/i2c/i2c-owl.txt | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt diff --git

[PATCH v4 3/6] arm64: dts: actions: Add Actions Semiconductor S900 I2C controller nodes

2018-07-01 Thread Manivannan Sadhasivam
Add I2C controller nodes for Actions Semiconductor S900 SoC. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/actions/s900.dtsi | 60 +++ 1 file changed, 60 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900.dtsi b/arch/arm64/boot/dts/actions/s900

[PATCH v4 4/6] arm64: dts: actions: Enable I2C1 and I2C2 in Bubblegum-96 board

2018-07-01 Thread Manivannan Sadhasivam
Enable I2C1 and I2C2 exposed on the low speed expansion connector in Bubblegum-96 board. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/actions/s900-bubblegum-96.dts | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900-bubblegum-96.dts

[PATCH v4 0/6] Add Actions Semiconductor Owl S900 I2C support

2018-07-01 Thread Manivannan Sadhasivam
owl_i2c_master_xfer * Added MAINTAINERS patch for I2C driver and its binding Manivannan Sadhasivam (6): dt-bindings: i2c: Add binding for Actions Semiconductor Owl I2C controller arm64: dts: actions: Add pinctrl definition for S900 I2C controller arm64: dts: actions: Add Actions Se

Re: [PATCH v2 3/3] dt-bindings: clock: Modify Actions Soc clock bindings

2018-07-01 Thread Manivannan Sadhasivam
On Sun, Jul 01, 2018 at 07:26:20PM +0200, Saravanan Sekar wrote: > Hi Mani > > > On 06/30/18 11:32, Manivannan Sadhasivam wrote: > > Hi Saravanan, > > > > I agree with modifying the existing binding to accomodate other > > SoC's of the same family. But th

[PATCH][next] pinctrl: actions: Fix Kconfig dependency and help text

2018-04-30 Thread Manivannan Sadhasivam
] && PINCTRL [=y] 2. Add help text for OWL pinctrl driver Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- drivers/pinctrl/actions/Kconfig | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/actions/Kconfig b/drivers

Re: [PATCH][next][V2] pinctrl: actions: fix missing break in PIN_CONFIG_DRIVE_STRENGTH case.

2018-04-30 Thread Manivannan Sadhasivam
ed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> Thanks, Mani > --- > drivers/pinctrl/actions/pinctrl-owl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pinctrl/actions/pinct

Re: [PATCH][next] pinctrl: actions: fix missing break in PIN_CONFIG_DRIVE_STRENGTH case.

2018-04-30 Thread Manivannan Sadhasivam
ctions S900 pinctrl driver") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> Thanks, Mani > --- > drivers/pinctrl/actions/pinctrl-owl.c | 1 + > 1 file changed, 1 insertion(+) > > d

Re: [PATCH][next] pinctrl: actions: make s900_functions, s900_padinfo and s900_pads static

2018-04-30 Thread Manivannan Sadhasivam
/pinctrl-s900.c:207:31: warning: symbol > 's900_pads' was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Looks good. Acked-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> Thanks, Mani > --- > drivers/pinctrl/actio

[PATCH v3 11/11] clk: actions: Add S900 SoC clock support

2018-02-09 Thread Manivannan Sadhasivam
Add Actions Semi S900 SoC clock support. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- drivers/clk/actions/Kconfig| 10 + drivers/clk/actions/Makefile | 3 + drivers/clk/actions/owl-s900.c | 666 + drivers/clk/a

[PATCH v3 00/11] Add clock driver for Actions S900 SoC

2018-02-09 Thread Manivannan Sadhasivam
on * Fixed tab vs space issue Changes in V1: (https://lkml.org/lkml/2017/10/31/808) * Addressed last year's review comments from Stephen - https://patchwork.kernel.org/patch/9254471/ Manivannan Sadhasivam (11): dt-bindings: clock: Add Actions S900 clock bindings arm64: dts: actions: Add

[PATCH v3 05/11] clk: actions: Add gate clock support

2018-02-09 Thread Manivannan Sadhasivam
Add support for Actions Semi gate clock together with helper functions to be used in composite clock. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- drivers/clk/actions/Makefile | 1 + drivers/clk/actions/owl-gate.

[PATCH v3 02/11] arm64: dts: actions: Add S900 clock management unit nodes

2018-02-09 Thread Manivannan Sadhasivam
Add Actions Semi S900 Clock Management Unit (CMU) nodes Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> --- arch/arm64/boot/dts/actions/s900.dtsi | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900.dtsi b/arch

  1   2   3   4   5   6   >