Kepplinger mart...@posteo.de
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
sound/pci/hda/patch_realtek.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index d9693ca..0f5af34 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b
Am 2014-02-12 17:45, schrieb Takashi Iwai:
At Wed, 12 Feb 2014 17:20:21 +0100,
Takashi Iwai wrote:
At Wed, 12 Feb 2014 17:09:23 +0100,
Martin Kepplinger wrote:
This reverts commit d3c56568f43807135f2c2a09582a69f809f0d8b7.
The reverted commit breaks audio through headphone line out
For obvious error messages, use dev_err() in order to provide userspace
with more useful information and use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
this applies to v3.15-rc4
greetings from Linuxdays Vienna, Austria
drivers/staging/winbond
Fix the sparse error: cast removes address space of expression.
---
Is that even correct? I haven't signed-off on it yet.
ethtool_ioctl() takes a (void *) as user data, dereferenced and assigend to u32.
applies to next-20140611
drivers/staging/vt6655/device_main.c |2 +-
1 file changed, 1
Remove a totally unnecessary typedef. This is more readable now.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
applies to next-20140611
drivers/staging/vt6655/card.c |2 +-
drivers/staging/vt6655/device.h |6 +++---
drivers/staging/vt6655/wmgr.c |2 +-
3 files changed
don't reinvent dev_dbg(). use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
this applies to next-20140516.
drivers/staging/media/as102/as102_drv.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media
don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
this applies to next-20140516. any more suggestions?
more cleanup can be done when dprintk() is completely gone.
drivers/staging/media/as102
Am 2014-05-17 19:21, schrieb Antti Palosaari:
On 05/17/2014 07:05 PM, Martin Kepplinger wrote:
don't reinvent dev_dbg(). remove dprintk() in as102_drv.c.
use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
Reviewed-by: Antti Palosaari cr...@iki.fi
For obvious error messages, use dev_err() in order to provide userspace
with more useful information and use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
i just waited a week or so. this applies to next-20140516.
greetings from Linuxdays Vienna, Austria
The one-bit bitfield has no negative values and thus becomes an
unsigned int.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
No idea if you take such small changes. Please ignore if not.
This applies to next-20140613 and fixes a sparse error.
drivers/block/drbd/drbd_interval.h |4
Fix a sparse warning: ttm_bo_reserve()'s last argument is a
pointer to a struct, so use NULL as nullpointer.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
this applies to next-20140613. Please ignore if annoyingly irrelevant.
drivers/gpu/drm/ttm/ttm_bo.c | 14 +++---
1 file
The one-bit bitfield has no negative values and thus becomes an
unsigned int.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
Sorry for the visually ugly first patch. Take this one, if any.
thanks,
martin
drivers/block/drbd/drbd_interval.h |4 ++--
1 file
Remove a totally unnecessary typedef and rename it to lowercase.
This is more readable now.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
so in that way, one could change the more heavily used typedefs as well.
thanks for your review.
drivers/staging/vt6655/card.c |2 +-
drivers
The one-bit bitfields are assigned true (1) or false (0) and checked
for them respectively. While it should work either way and -1 is true
as well it is more clear to see what's going on when using an unsigned int
because 1 doesn't silently become -1 behind the label true.
Signed-off-by: Martin
Fix the sparse error: cast removes address space of expression and
add __user annotation to the driver's ethtool_ioctl().
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
Beyond that, how would you include socket.c's ethtool_ioctl() here?
thanks for looking at these tiny changes.
drivers
Fix the sparse error: cast removes address space of expression and
add __user annotation to the driver's ethtool_ioctl().
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
I think I forgot to change the declaration on top.
drivers/staging/vt6655/device_main.c |6 +++---
1 file changed
Am 2014-06-17 21:46, schrieb David Rientjes:
On Tue, 17 Jun 2014, Martin Kepplinger wrote:
The one-bit bitfields are assigned true (1) or false (0) and checked
for them respectively. While it should work either way and -1 is true
as well it is more clear to see what's going on when using
Use dev_err() insted of printk() in order to provice userspace with
more useful information and use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/staging/dgnc/dgnc_sysfs.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Use dev_err() insted of printk() and remove dgnc: from the message.
This should provide userspace with more useful information and use
the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
This makes probably more sense than the previous one.
drivers/staging
Don't require FIRMWAREbDownload() to, first off, unlock a held lock.
Thus do all locking in main_usb.c and hold it for a insignificantly
shorter period of time. This makes the affected area significantly more
readable though.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/staging
pci_iounmap is used that way in drivers/net/wireless/rtlwifi and this
fixes sparse warnings.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/staging/rtl8821ae/pci.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/pci.c b/drivers
Shared addresses can be marked as such.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
I guess that's what you meant. Thanks for your feedback!
drivers/staging/rtl8821ae/wifi.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/wifi.h b
Use dev_err() instead of printk() and remove dgnc: from the message.
This should provide userspace with more useful information and use
the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/staging/dgnc/dgnc_sysfs.c |2 +-
1 file changed, 1 insertion
Am 2014-05-05 13:35, schrieb Dan Carpenter:
On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote:
Use dev_err() instead of printk() and remove dgnc: from the message.
This should provide userspace with more useful information and use
the common kernel coding style.
Whenever I
Am 2014-05-05 14:36, schrieb Dan Carpenter:
On Mon, May 05, 2014 at 01:59:25PM +0200, Martin Kepplinger wrote:
Am 2014-05-05 13:35, schrieb Dan Carpenter:
On Mon, May 05, 2014 at 12:29:39PM +0200, Martin Kepplinger wrote:
Use dev_err() instead of printk() and remove dgnc: from the message
Don't require FIRMWAREbDownload() to, first off, unlock a held lock.
Thus do all locking in main_usb.c and hold it for a insignificantly
shorter period of time. This makes the affected area significantly more
readable though.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
I resend https
Don't list elements to initialize. Remaining elements of a partly
initialized array are set to zero. Sparse complained here.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
fix following warning by dynamically allocating memory:
dgnc_tty.c:583:1: warning: the frame size of 1060 bytes is larger than 1024
bytes [-Wframe-larger-than=]
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
This is more of a question. Is this a desired solution to fixing such a
frame
Am 2014-05-06 15:33, schrieb Dan Carpenter:
On Tue, May 06, 2014 at 02:41:37PM +0200, Martin Kepplinger wrote:
fix following warning by dynamically allocating memory:
dgnc_tty.c:583:1: warning: the frame size of 1060 bytes is larger than 1024
bytes [-Wframe-larger-than=]
Signed-off
Use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
noise from the eudyptula challenge. applies to next-20140408 as well as
linus' current tree.
drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions
Am 2014-06-23 15:14, schrieb Zhang Rui:
On Mon, 2014-06-23 at 14:22 +0200, Martin Kepplinger wrote:
Am 2014-06-23 03:10, schrieb Zhang, Rui:
-Original Message-
From: Martin Kepplinger [mailto:mart...@posteo.de]
Sent: Sunday, June 22, 2014 10:25 PM
To: Zhang, Rui
Cc: r
work as well.
Signed-off-by: Martin Kepplinger mart...@posteo.de
Tested-by: Martin Kepplinger mart...@posteo.de
---
drivers/acpi/video.c |8
1 file changed, 8 insertions(+)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index f8bc5a7..acb0670 100644
--- a/drivers/acpi/video.c
.
martin
--
Martin Kepplinger
e-mailmartink AT posteo DOT at
chat (XMPP) martink AT jabber DOT at
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
Am 2014-06-23 03:10, schrieb Zhang, Rui:
-Original Message-
From: Martin Kepplinger [mailto:mart...@posteo.de]
Sent: Sunday, June 22, 2014 10:25 PM
To: Zhang, Rui
Cc: r...@rjwysocki.net; l...@kernel.org; linux-a...@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: [BUG] rc1
Am 2014-06-27 17:14, schrieb Zhang Rui:
On Mon, 2014-06-23 at 16:46 +0200, Martin Kepplinger wrote:
Am 2014-06-23 15:14, schrieb Zhang Rui:
On Mon, 2014-06-23 at 14:22 +0200, Martin Kepplinger wrote:
Am 2014-06-23 03:10, schrieb Zhang, Rui:
-Original Message-
From: Martin
Am 2014-06-27 20:09, schrieb Martin Kepplinger:
Am 2014-06-27 17:14, schrieb Zhang Rui:
On Mon, 2014-06-23 at 16:46 +0200, Martin Kepplinger wrote:
Am 2014-06-23 15:14, schrieb Zhang Rui:
On Mon, 2014-06-23 at 14:22 +0200, Martin Kepplinger wrote:
Am 2014-06-23 03:10, schrieb Zhang, Rui
Am 2014-06-27 21:51, schrieb Martin Kepplinger:
Am 2014-06-27 20:09, schrieb Martin Kepplinger:
Am 2014-06-27 17:14, schrieb Zhang Rui:
On Mon, 2014-06-23 at 16:46 +0200, Martin Kepplinger wrote:
Am 2014-06-23 15:14, schrieb Zhang Rui:
On Mon, 2014-06-23 at 14:22 +0200, Martin Kepplinger
Am 2014-06-23 22:30, schrieb Martin Kepplinger:
Fix backlight control for Acer TravelMate B113 Laptop by adding
it to the video_dmi_table.
A workaround before that was to use acpi_osi=Linux or
acpi_backlight=vendor on boot but even then, only the function-
keys worked.
With this change
I now booted 3.16-rc3 and suddenly see an oops during boot:
the oops during boot: http://tny.cz/2301e393
also below
lshw if interesting: http://tny.cz/3c9a7609
the full boot log: http://tny.cz/88260b19
does anyone have an idea?
thanks
the oops:
Jun 30
Am 2014-06-30 03:29, schrieb Aaron Lu:
On 06/29/2014 04:42 PM, Martin Kepplinger wrote:
Am 2014-06-23 22:30, schrieb Martin Kepplinger:
Fix backlight control for Acer TravelMate B113 Laptop by adding
it to the video_dmi_table.
A workaround before that was to use acpi_osi=Linux
Am 2014-06-30 10:20, schrieb Zhang Rui:
On Mon, 2014-06-30 at 16:18 +0800, Zhang Rui wrote:
On Mon, 2014-06-30 at 09:52 +0200, Martin Kepplinger wrote:
I now booted 3.16-rc3 and suddenly see an oops during boot:
the oops during boot: http://tny.cz/2301e393
also below
lshw
back to aaeb2554337217dfa4eac2fcc90da7be540b9a73 as the first bad
commit. why is this not revertable exactly? how can I show a complete
list of commits this merge introduces?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
Use NULL instead of 0 when returning an address. This fixes a
sparse warning.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
Sorry if this is only noise, I stumbled upon it and why not send it.
applies to next-20140731
drivers/mtd/maps/pcmciamtd.c |2 +-
1 file changed, 1 insertion
remove dprintk() and replace it with dev_dbg() in order to
use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
I don't have the device but this builds.
I think this is ok when it gets reviewed.
applies to -next20140801
drivers/staging/media/as102
Use tabs for code indent and use the kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
applies to -next20140801
drivers/staging/rtl8192ee/regd.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192ee/regd.c b/drivers/staging
Am 2014-08-03 18:27, schrieb Joe Perches:
On Sun, 2014-08-03 at 18:06 +0200, Martin Kepplinger wrote:
Use tabs for code indent and use the kernel coding style.
[]
diff --git a/drivers/staging/rtl8192ee/regd.c
b/drivers/staging/rtl8192ee/regd.c
[]
@@ -363,8 +363,7 @@ static const struct
-by: Martin Kepplinger mart...@posteo.de
---
This changes only a part of rtl8192u's comments. When this is desired,
one can go about and change the rest of the driver.
build-tested. applies to -next20140801
drivers/staging/rtl8192u/r8180_93cx6.c | 12 +-
drivers/staging/rtl8192u/r8192U_core.c | 757
This fixes sparse errors where 0 is used for non-integers.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
applies to -next20140802
drivers/staging/lustre/lnet/lnet/api-ni.c |4 +-
drivers/staging/lustre/lustre/fld/fld_request.c|2 +-
drivers/staging/lustre/lustre
Use %llu for u64 and %u for int. Not the other way round.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
applies to -next20140801
drivers/scsi/u14-34f.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/u14-34f.c b/drivers/scsi/u14-34f.c
index
remove dprintk() and replace it with dev_dbg() in order to
use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
Thanks Dan. And since it continues to succeed if (dev == NULL),
differntiate if (dev) or not.
drivers/staging/media/as102/as102_drv.c | 15
remove dprintk() and replace it with dev_dbg() or pr_debug()
in order to use the common kernel coding style.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
Thanks for looking at it. So this doesn't add anything and actually does
what it says. If I haven't understood what you meant
Am 2014-06-30 12:39, schrieb Martin Kepplinger:
back to aaeb2554337217dfa4eac2fcc90da7be540b9a73 as the first bad
commit. why is this not revertable exactly? how can I show a complete
list of commits this merge introduces?
It seems that _nobody_ is running a simple 32 bit i915 (acer) laptop
Am 2014-07-25 01:20, schrieb Hugh Dickins:
On Thu, 24 Jul 2014, Martin Kepplinger wrote:
Am 2014-06-30 12:39, schrieb Martin Kepplinger:
back to aaeb2554337217dfa4eac2fcc90da7be540b9a73 as the first bad
commit. why is this not revertable exactly? how can I show a complete
list of commits
If this is going away, it won't be in 2012.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
This just looked a little odd in the logs. Feel free to ignore or act
upon it differently. This applies to -next as well.
drivers/platform/x86/acer-wmi.c |6 +++---
1 file changed, 3
at it.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
Yes, there were changes in the meantime. This applies to -next20140808
and builds. thanks.
drivers/staging/rtl8192u/r8192U_core.c | 757 +---
1 file changed, 408 insertions(+), 349 deletions(-)
diff --git a/drivers
Am 2014-10-09 17:50, schrieb Greg KH:
On Thu, Oct 09, 2014 at 03:10:21PM +0200, Martin Kepplinger wrote:
Am 2014-10-08 15:43, schrieb Greg KH:
On Wed, Oct 08, 2014 at 10:47:54AM +0200, Martin Kepplinger wrote:
As of now, a miscdevice driver has to provide an implementation of
the open() file
Am 2014-10-09 17:50, schrieb Greg KH:
On Thu, Oct 09, 2014 at 03:10:21PM +0200, Martin Kepplinger wrote:
Am 2014-10-08 15:43, schrieb Greg KH:
On Wed, Oct 08, 2014 at 10:47:54AM +0200, Martin Kepplinger wrote:
As of now, a miscdevice driver has to provide an implementation of
the open() file
hi
Just a question for understanding: open() is not implemented in
lguest_user.c's miscdevice. The miscdevice core, in this case, does
_not_ set file-private_data on a user's open() call. Is open() called
by the user here? and do you here _depend_ on file-private_data being
NULL after open()?
if we depend on private_data being NULL in write() before initialize()
make sure it is NULL after open().
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
I'm not completely sure if this patch is needed and am still investigating.
What do you think? open() could be called by the user I
() fop would,
of course, just overwrite it, when using private_data itself.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
The mentioned warning is appearently unrelated here, and happens on mainline
v3.17 awell -.- sorry for the confusion.
This applies to 3.17 and is a call for review
the miscdevice core now does the work in any case.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/video/fbdev/pxa3xx-gcu.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
index 4df3657..7678a94
Am 2014-10-19 02:31, schrieb Martin Kepplinger:
if we depend on private_data being NULL in write() before initialize()
make sure it is NULL after open().
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
I'm not completely sure if this patch is needed and am still investigating
remove a typedef that is not even really used.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
builds in next-20140905.
drivers/staging/rtl8192u/r8192U_core.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers
() fop would,
of course, just overwrite it, when using private_data itself.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
This is really only a question: Do I understand this correctly, and,
could this change then hurt any existing driver?
As a driver developer it took me a while to figure
Am 2014-10-08 15:43, schrieb Greg KH:
On Wed, Oct 08, 2014 at 10:47:54AM +0200, Martin Kepplinger wrote:
As of now, a miscdevice driver has to provide an implementation of
the open() file operation if it wants to have misc_open() assign a
pointer to struct miscdevice to file-private_data
This might prevent code duplication in the future.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
This is a suggestion for a place to put this information. I think this
makes sense but there might be a more appropriate place elsewhere.
drivers/char/misc.c |4
1 file changed, 4
() fop would,
of course, just overwrite it, when using private_data itself.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/char/misc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index ffa97d2..205ad4c 100644
=2
Bonus: one could look for drivers that _do_ implement open()
and do the (in any case) redundant work themselves.
Martin Kepplinger (3):
misc: always assign miscdevice to file-private_data in open()
fbdev: pxa3xx-gcu: remove redundant implementation of open()
char: misc: document behaviour
the miscdevice core now does the work in any case.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/video/fbdev/pxa3xx-gcu.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
index 4df3657..7678a94
an open syscall now assignes file-private_data to a pointer to the
miscdevice structure. This reminds driver developers not to duplicate
code if they need this.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/char/misc.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion
The miscdevice core now sets file-private_data to the struct miscdevice
so don't fail when this is not NULL.
Reported-by: Thierry Reding thierry.red...@gmail.com
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
This is a question: what does this check provide and does overwriting
file
The miscdevice core now sets file-private_data to the struct miscdevice
so don't fail when this is not NULL.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
This is a question: what does this check provide and does overwriting
file-private_data make any difference?
Is miscdevice's open
Am 2014-11-12 um 17:31 schrieb Martin Kepplinger:
The miscdevice core now sets file-private_data to the struct miscdevice
so don't fail when this is not NULL.
Reported-by: Thierry Reding thierry.red...@gmail.com
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
This is a question
Am 2014-11-12 um 18:59 schrieb Chris Mason:
On Wed, Nov 12, 2014 at 11:38 AM, Martin Kepplinger mart...@posteo.de
wrote:
The miscdevice core now sets file-private_data to the struct miscdevice
so don't fail when this is not NULL.
Signed-off-by: Martin Kepplinger mart...@posteo.de
The miscdevice core now sets file-private_data to the struct miscdevice
so don't fail when this is not NULL.
Reported-by: Giedrius Statkevicius giedriusw...@gmail.com
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
sorry, I can't read ;) Is this a fix for your problem (instead of the first
Am 13. November 2014 10:40:38 MEZ, schrieb Miklos Szeredi mik...@szeredi.hu:
On Wed, Nov 12, 2014 at 5:31 PM, Martin Kepplinger mart...@posteo.de
wrote:
The miscdevice core now sets file-private_data to the struct
miscdevice
so don't fail when this is not NULL.
Does it? Look:
static int
Am 13. November 2014 11:53:29 MEZ, schrieb Miklos Szeredi mik...@szeredi.hu:
On Thu, Nov 13, 2014 at 11:05 AM, Martin Kepplinger mart...@posteo.de
wrote:
In this week's -next this should have changed. My SSD broke down so i
have to delay further work for a few days, i'm sorry.
Please be more
This adds sign_exten16 to sign extend any signed value shorter than 16 bits
to a s16.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
include/linux/bitops.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/linux/bitops.h b/include/linux/bitops.h
index 3c2a539
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/media/dvb-frontends/stb0899_algo.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/dvb-frontends/stb0899_algo.c
b/drivers/media/dvb-frontends/stb0899_algo.c
index 93596e0..7bbcfde 100644
In short: If you want the first 2 changes, please merge them and notify
me.
This adds sign_extend8() and sign_extend16() for the quite many cases
where this is needed, like sign_extend32().
Sign-extending is done in a few different ways throughout the kernel
and most of them look not very
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/input/tablet/gtco.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c
index 8580456..25b3834 100644
--- a/drivers/input/tablet/gtco.c
+++ b
---
drivers/hwmon/jc42.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
index 388f8bc..335a2de 100644
--- a/drivers/hwmon/jc42.c
+++ b/drivers/hwmon/jc42.c
@@ -31,6 +31,7 @@
#include linux/hwmon-sysfs.h
#include linux/err.h
This adds a helper function that extends any signed value smaller than
8 bits to a s8.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
include/linux/bitops.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/linux/bitops.h b/include/linux/bitops.h
index 5d858e0
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/rtc/rtc-x1205.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-x1205.c b/drivers/rtc/rtc-x1205.c
index b1de58e..3ec0b95 100644
--- a/drivers/rtc/rtc-x1205.c
+++ b/drivers/rtc/rtc-x1205.c
This adds sign_exten64 to sign extend any signed value shorter than 64 bits
to a s64.
Signed-off-by: Martin Kepplinger mart...@posteo.de
Suggested-by: Christoph Muellner christoph.muell...@theobroma-systems.com
---
Without looking for it's users yet: This applies on top of it's 8 and 16 bit
Am 2014-12-15 um 17:18 schrieb Martin Kepplinger:
This adds sign_exten16 to sign extend any signed value shorter than 16 bits
to a s16.
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
if you feel motivated, you can add this to the commit message:
Suggested-by: Christoph Muellner
Am 2014-12-15 um 18:54 schrieb Martin Kepplinger:
This adds sign_exten64 to sign extend any signed value shorter than 64 bits
to a s64.
I'm sorry for this typo: sign_extend64()
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
Am 2014-12-15 um 22:29 schrieb Guenter Roeck:
On Mon, Dec 15, 2014 at 05:18:34PM +0100, Martin Kepplinger wrote:
---
Some description would be nice. Also, please consider adding
relevant subsystem mailing lists and maintainers to your patches.
I shouldn't have added the Signed-off-by line
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
include/linux/bitops.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/bitops.h b/include/linux/bitops.h
index 5d858e0..336f22b 100644
--- a/include/linux/bitops.h
+++ b/include/linux/bitops.h
@@ -164,6 +164,8 @@ static
Thanks for reviewing. I propose the following additions instead.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
Add sign_extend64() for sign extending any (hardware-)given signed value
greater than 32 bits to s64.
Suggested-by: Christoph Muellner christoph.muell...@theobroma-systems.com
Suggested-by: Peter Zijlstra pet...@infradead.org
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
include/linux
These are 4 of probably many examples of what could be changed if the proposed
sign_extend8, 16 and 64 are added to bitops.h, now as real patches.
Again, keep in mind, only take them if PATCH v2 add sign_exted8, 16 and 64
is included first.
--
To unsubscribe from this list: send the line
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/rtc/rtc-x1205.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-x1205.c b/drivers/rtc/rtc-x1205.c
index b1de58e..3ec0b95 100644
--- a/drivers/rtc/rtc-x1205.c
+++ b/drivers/rtc/rtc-x1205.c
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/input/tablet/gtco.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c
index 8580456..25b3834 100644
--- a/drivers/input/tablet/gtco.c
+++ b
Signed-off-by: Martin Kepplinger mart...@posteo.de
Reviewed-by: Guenter Roeck li...@roeck-us.net
---
drivers/hwmon/jc42.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/hwmon/jc42.c b/drivers/hwmon/jc42.c
index 388f8bc..d0582a3 100644
--- a/drivers/hwmon/jc42.c
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
drivers/media/dvb-frontends/stb0899_algo.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/dvb-frontends/stb0899_algo.c
b/drivers/media/dvb-frontends/stb0899_algo.c
index 93596e0..7bbcfde 100644
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
arch/sh/kernel/traps_64.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/sh/kernel/traps_64.c b/arch/sh/kernel/traps_64.c
index 112ea11..4e04261 100644
--- a/arch/sh/kernel/traps_64.c
+++ b/arch/sh/kernel/traps_64
From a first look, there are quite some places in arch where sign extension
is done. I append one example for review although I didn't even build this.
Don't use it unreviewed!
I guess the doc-addition to sign_extend32() would be valuable for it to be
used more often in long term.
--
To
I didn't build the following change. It should be correct though. If you can
add it to a tree and build or even run it before offering it for-linus, feel
free to do so. Otherwise please ignore.
thanks,
martin
--
To unsubscribe from this list: send the line unsubscribe
From: Martin Kepplinger martin.kepplin...@theobroma-systems.com
Signed-off-by: Martin Kepplinger mart...@posteo.de
---
arch/arm/mach-imx/clk-pllv2.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-imx/clk-pllv2.c b/arch/arm/mach-imx/clk-pllv2.c
index
1 - 100 of 1178 matches
Mail list logo
