[Question] Why CONFIG_SHELL

2014-06-08 Thread Masahiro Yamada
Hi experts. I think all the macros with CONFIG_ prefix are supposed to be defined in Kconfig. But I've been long wondering why there exists one exception: CONFIG_SHELL. Is there any historical, or special reason? Is it good to rename it to KBUILD_SHELL or something else? Best Regards Masahiro

Re: [Question] Why CONFIG_SHELL

2014-06-09 Thread Masahiro Yamada
Hi Sam, On Mon, 9 Jun 2014 09:49:35 +0200 Sam Ravnborg s...@ravnborg.org wrote: On Mon, Jun 09, 2014 at 02:04:12PM +0900, Masahiro Yamada wrote: Hi experts. I think all the macros with CONFIG_ prefix are supposed to be defined in Kconfig. But I've been long wondering why

[PATCH 3/7] scripts: objdiff: remove unnecessary code

2014-05-30 Thread Masahiro Yamada
The directories for objdump is created by the code a few lines below: [ ! -d $OBJDIFFD/$dn ] mkdir -p $OBJDIFFD/$dn Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Cc: Jason Cooper ja...@lakedaemon.net --- scripts/objdiff | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts

[PATCH] Kbuild: move extra gcc check flags to the top Makefile

2014-04-06 Thread Masahiro Yamada
-by: Masahiro Yamada yamad...@jp.panasonic.com --- Makefile | 51 ++ scripts/Makefile.build | 51 -- 2 files changed, 51 insertions(+), 51 deletions(-) diff --git a/Makefile b/Makefile

[PATCH v2] kbuild: move extra gcc checks to scripts/Makefile.extrawarn

2014-04-08 Thread Masahiro Yamada
, this commit moves all of extra gcc check stuff to a new file scripts/Makefile.extrawarn, which is included from the top Makefile. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Cc: Michal Marek mma...@suse.cz CC: Sam Ravnborg s...@ravnborg.org --- Changes in v2: - Move the code to a new file

[PATCH] kbuild: support simultaneous make %config and make all

2014-04-09 Thread Masahiro Yamada
'. This commits allows make %config all and makes sure mixed targets are built one by one in the given order. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Cc: Michal Marek mma...@suse.cz CC: Sam Ravnborg s...@ravnborg.org --- Makefile | 12 ++-- scripts/mkmakefile | 15

[PATCH] x86: suppress Nothing to be done for ... messages

2014-04-09 Thread Masahiro Yamada
to be done for `relocs'. - CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- arch/x86/syscalls/Makefile | 1 + arch/x86/tools/Makefile| 1 + 2 files changed, 2 insertions(+) diff

[PATCH v2] x86: suppress Nothing to be done for ... messages

2014-04-09 Thread Masahiro Yamada
to be done for `relocs'. - CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h Besides those fixes, all and relocs should be added to PHONY. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Acked-by: Peter Foley pefol...@pefoley.com Acked

[PATCH v3] kbuild: move extra gcc checks to scripts/Makefile.extrawarn

2014-04-14 Thread Masahiro Yamada
, this commit moves all of extra gcc check stuff to a new file scripts/Makefile.extrawarn, which is included from the top Makefile. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Cc: Michal Marek mma...@suse.cz CC: Sam Ravnborg s...@ravnborg.org --- Changes in v3: - Rebase on v3.15-rc1 (v2

[PATCH] kbuild: create a build directory automatically for out-of-tree build

2014-03-31 Thread Masahiro Yamada
Kbuild supports saving output files in a separate directory. But the build directory must be created beforehand. For example, $ mkdir -p dir/to/store/output/files $ make O=dir/to/store/output/files defconfig Creating a build directory automatically would be useful. Signed-off-by: Masahiro

Re: [PATCH] kbuild: Use symbolic link to the source tree for out-of-tree build

2014-07-09 Thread Masahiro Yamada
Hi Michal, On Wed, 09 Jul 2014 10:59:59 +0200 Michal Marek mma...@suse.cz wrote: On 2014-07-09 08:27, Masahiro Yamada wrote: Since commit 9da0763bd, the variable 'srctree' is set as follows: [1] Building in the source tree = srctree is set to '.' [2] Building in a subdir right

[PATCH] mtd: denali: avoid using a magic number

2014-07-10 Thread Masahiro Yamada
MAP10 command with '0x2000' data sets up a read-ahead/write access. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- drivers/mtd/nand/denali.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index 9f2012a

Re: [U-Boot] [RFC] kbuild.h: workaround for llvm IAS

2014-06-27 Thread Masahiro Yamada
in other projects, for example, in llvmlinux ? http://llvm.linuxfoundation.org/index.php/Main_Page Linux folks merged Clang support into the top Makefile, but not into ./Kbuild. I don't know why. Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH] kbuild: Use symbolic link to the source tree for out-of-tree build

2014-07-09 Thread Masahiro Yamada
than 'source') Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Cc: Michal Marek mma...@suse.cz Cc: Sam Ravnborg s...@ravnborg.org --- Makefile | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/Makefile b/Makefile index 4d75b4b..0089618 100644 --- a/Makefile

Re: [PATCH 3/6] samples: use uapiprogs support for seccomp

2014-07-16 Thread Masahiro Yamada
. Forgive me if I am asking a stupid question.. How can I build hostprogs for the same host as the kernel? (I mean, how can I override $(HOSTCC) for cross-compiling ?) Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH 3/6] samples: use uapiprogs support for seccomp

2014-07-16 Thread Masahiro Yamada
in handy. Only caveat here is that you will be using the exported kernel headers. Thanks for explaining this. It is clearer to me now. At first I thought this patch was a clean-up, but it is indeed a big improvement. Thanks! Best Regards Masahiro Yamada -- To unsubscribe from this list: send

[PATCH] kbuild: allow to override Python command name

2014-07-17 Thread Masahiro Yamada
possibly be Python 3 on some systems. For that case, it is reasonable to allow to override the command name by giving 'PYTHON=python2' from the command line. The 'python' in arch/ia64/Makefile should be replaced with '$(PYTHON)'. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Cc: linux

[PATCH] list: include linux/kernel.h

2014-08-25 Thread Masahiro Yamada
linux/list.h uses container_of, therefore it depends on linux/kernel.h. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- I am sending this patch to LKML because I could not find the subsystem it should belong to. I hope I am not doing wrong. include/linux/list.h | 1 + 1 file

[RFC] ARM: Refactoring of Low-level debug

2014-08-25 Thread Masahiro Yamada
) addruart_phys r1, r3 waituart r3, r1 senduart r0, r1 busyuart r3, r1 mov pc, lr ENDPROC(putc) If the basic idea is OK, I will take a close look. Comments are welcome. Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] kbuild: Make scripts executable

2014-08-20 Thread Masahiro Yamada
/@ $realfile !~ /\.(py|pl|awk|sh)$/) { ERROR(EXECUTE_PERMISSIONS, do not set execute permissions for source files\n . $permhere); } } Best Regards Masahiro Yamada -- To unsubscribe from

Re: [PATCH] kbuild: Make scripts executable

2014-08-21 Thread Masahiro Yamada
Hi Michal, On Thu, 21 Aug 2014 11:32:56 +0200 Michal Marek mma...@suse.cz wrote: On 2014-08-21 05:25, Masahiro Yamada wrote: Hi Michal, On Wed, 20 Aug 2014 16:10:48 +0200 Michal Marek mma...@suse.cz wrote: The Makefiles call the respective interpreter explicitly, but this makes

[PATCH] kbuild: trivial - fix the help doc of CONFIG_CC_OPTIMIZE_FOR_SIZE

2014-08-04 Thread Masahiro Yamada
Other than GCC, we have another choice, Clang for building the kernel these days. It seems better to say compiler rather than gcc. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- init/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/init/Kconfig b

[PATCH 0/4] kbuild: Fix the dependency handling of multi-objs targets

2014-08-19 Thread Masahiro Yamada
1/4 and 2/4 fix the core scripts. 3/4 and 4/4 refactors scripts/kconfig/Makefile based on 2/4. Masahiro Yamada (4): kbuild: handle multi-objs dependency appropriately kbuild: handle the dependency of multi-objs hostprogs appropriately kbuild: refactor script/kconfig/Makefile kbuild

[PATCH 3/4] kbuild: refactor script/kconfig/Makefile

2014-08-19 Thread Masahiro Yamada
Now it is harmless to add all host programs to hostprogs-y. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- scripts/kconfig/Makefile | 34 +++--- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/scripts/kconfig/Makefile b/scripts/kconfig

[PATCH 4/4] kbuild: remove redundant clean-files from scripts/kconfig/Makefile

2014-08-19 Thread Masahiro Yamada
Now mconf, qconf, gconf, nconf are always added to hostprogs-y. Files added to hostprogs-y are removed by make clean. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- scripts/kconfig/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/kconfig/Makefile b/scripts

[PATCH 1/4] kbuild: handle multi-objs dependency appropriately

2014-08-19 Thread Masahiro Yamada
-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- scripts/Makefile.build | 10 -- scripts/Makefile.lib | 9 + 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/scripts/Makefile.build b/scripts/Makefile.build index bf3e677..5b09d36 100644 --- a/scripts

[PATCH 2/4] kbuild: handle the dependency of multi-objs hostprogs appropriately

2014-08-19 Thread Masahiro Yamada
-by: Masahiro Yamada yamad...@jp.panasonic.com --- scripts/Makefile.host | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/Makefile.host b/scripts/Makefile.host index ab5980f..133edfa 100644 --- a/scripts/Makefile.host +++ b/scripts/Makefile.host @@ -96,8 +96,9

[PATCH 5/7] mtd: denali: remove a set-but-unused variable

2014-09-08 Thread Masahiro Yamada
The variable retry in wait_for_irq() is set, but not referenced. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- drivers/mtd/nand/denali.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index 259ca0ba..d37c2e1 100644

[PATCH 2/7] mtd: denali: remove unnecessary variable initializations

2014-09-08 Thread Masahiro Yamada
All of these variables are initialized to zero and then set to a different value below. Zero-initializing is redundant. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- drivers/mtd/nand/denali.c | 59 ++- 1 file changed, 27 insertions

[PATCH 1/7] mtd: denali: fix the format of comment blocks

2014-09-08 Thread Masahiro Yamada
We should use /* * Blah Blah ... * ... */ for multi-line comment blocks. In addition, refactor some comments where it seems reasonable and remove some comments where the code is clear enough such as: /* clear interrupts */ clear_interrupts(denali); Signed-off-by: Masahiro Yamada

[PATCH 4/7] mtd: denali: change the type of iterators to int

2014-09-08 Thread Masahiro Yamada
We should rathar use int type for loop iterators. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- drivers/mtd/nand/denali.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index dcd6771..259ca0ba

[PATCH 6/7] mtd: denali: remove unnecessary parentheses

2014-09-08 Thread Masahiro Yamada
We should use parentheses only when they are necessary or they really improve the readability. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- drivers/mtd/nand/denali.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/nand/denali.c b

[PATCH 7/7] mtd: denali: fix indentations and other trivial things

2014-09-08 Thread Masahiro Yamada
- WARNING: Missing a blank line after declarations - WARNING: Avoid line continuations in quoted strings Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- drivers/mtd/nand/denali.c | 113 -- 1 file changed, 50 insertions(+), 63 deletions

[PATCH 0/7] mtd: denali: A collection of trivial coding style fixes

2014-09-08 Thread Masahiro Yamada
Masahiro Yamada (7): mtd: denali: fix the format of comment blocks mtd: denali: remove unnecessary variable initializations mtd: denali: remove unnecessary casts mtd: denali: change the type of i to int mtd: denali: remove a set-but-unused variable mtd: denali: remove unnecessary

[PATCH 3/7] mtd: denali: remove unnecessary casts

2014-09-08 Thread Masahiro Yamada
Useless casts result in unreadable source code. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- drivers/mtd/nand/denali.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c

Re: [PATCH 7/7] mtd: denali: fix indentations and other trivial things

2014-09-08 Thread Masahiro Yamada
Hi Josh, On Mon, 8 Sep 2014 01:39:20 -0700 Josh Triplett j...@joshtriplett.org wrote: On Mon, Sep 08, 2014 at 05:10:13PM +0900, Masahiro Yamada wrote: @@ -406,9 +404,9 @@ static void get_hynix_nand_para(struct denali_nand_info *denali, break; default

[PATCH v2 0/7] mtd: denali: A collection of trivial coding style fixes

2014-09-08 Thread Masahiro Yamada
Changes in v2: - Join quotes strings into a single line Masahiro Yamada (7): mtd: denali: fix the format of comment blocks mtd: denali: remove unnecessary variable initializations mtd: denali: remove unnecessary casts mtd: denali: change the type of iterators to int mtd: denali

[PATCH v2 3/7] mtd: denali: remove unnecessary casts

2014-09-08 Thread Masahiro Yamada
Useless casts result in unreadable source code. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Changes in v2: None drivers/mtd/nand/denali.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/mtd/nand/denali.c b

[PATCH v2 2/7] mtd: denali: remove unnecessary variable initializations

2014-09-08 Thread Masahiro Yamada
All of these variables are initialized to zero and then set to a different value below. Zero-initializing is redundant. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Changes in v2: None drivers/mtd/nand/denali.c | 59 ++- 1 file

[PATCH v2 7/7] mtd: denali: fix indents and other trivial things

2014-09-08 Thread Masahiro Yamada
split across lines - WARNING: else is not generally useful after a break or return - WARNING: Missing a blank line after declarations - WARNING: Avoid line continuations in quoted strings Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Changes in v2: - Join quotes strings

[PATCH v2 5/7] mtd: denali: remove a set-but-unused variable

2014-09-08 Thread Masahiro Yamada
The variable retry in wait_for_irq() is set, but not used. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Reviewed-by: Josh Triplett j...@joshtriplett.org --- Changes in v2: None drivers/mtd/nand/denali.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mtd/nand/denali.c

[PATCH v2 1/7] mtd: denali: fix the format of comment blocks

2014-09-08 Thread Masahiro Yamada
We should use /* * Blah Blah ... * ... */ for multi-line comment blocks. In addition, refactor some comments where it seems reasonable and remove some comments where the code is clear enough such as: /* clear interrupts */ clear_interrupts(denali); Signed-off-by: Masahiro Yamada

[PATCH v2 6/7] mtd: denali: remove unnecessary parentheses

2014-09-08 Thread Masahiro Yamada
We should use parentheses only when they are necessary or they really improve the readability. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Reviewed-by: Josh Triplett j...@joshtriplett.org --- Changes in v2: None drivers/mtd/nand/denali.c | 16 1 file changed, 8

[PATCH v2 4/7] mtd: denali: change the type of iterators to int

2014-09-08 Thread Masahiro Yamada
We should rathar use int type for loop iterators. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Changes in v2: None drivers/mtd/nand/denali.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c

[PATCH 3/3] kbuild: remove obj-n and lib-n handling

2014-09-09 Thread Masahiro Yamada
Kconfig never defines CONFIG_* as 'n'. Now obj-n is only used in firmware/Makefile and it can be replaced with obj-. No makefile uses lib-n. Let's rip off obj-n and lib-n. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- firmware/Makefile | 2 +- scripts/Makefile.build | 4

[PATCH 1/3] kbuild: remove unnecessary obj- := dummy.o trick

2014-09-09 Thread Masahiro Yamada
In these Makefiles, at least one of obj-y and obj- is non-empty, hence built-in.o is always created without such a trick. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- arch/arm/plat-samsung/Makefile | 1 - drivers/clk/shmobile/Makefile | 2 -- drivers/net/wimax/Makefile | 4

[PATCH 2/3] kbuild: remove unnecessary variable initializaions

2014-09-09 Thread Masahiro Yamada
-by: Masahiro Yamada yamad...@jp.panasonic.com --- arch/arm/mach-at91/Makefile | 3 --- arch/arm/mach-ebsa110/Makefile| 3 --- arch/arm/mach-ep93xx/Makefile | 3 --- arch/arm/mach-exynos/Makefile | 5 - arch/arm/mach-footbridge/Makefile | 3 --- arch/arm/mach-iop13xx/Makefile| 5

[PATCH 0/3] kbuild: Clean up makefiles and then drop obj-n an obj-n

2014-09-09 Thread Masahiro Yamada
Masahiro Yamada (3): kbuild: remove unnecessary obj- := dummy.o trick kbuild: remove unnecessary variable initializaions kbuild: remove obj-n and lib-n handling arch/arm/mach-at91/Makefile | 3 --- arch/arm/mach-ebsa110/Makefile| 3 --- arch/arm/mach-ep93xx/Makefile | 3

[PATCH 2/3] kbuild: use $(Q) for sub-make target

2014-09-09 Thread Masahiro Yamada
Since commit 066b7ed9558087a7957a1128f27d7a3462ff117f (kbuild: Do not print the build directory with make -s), Q is defined above the sub-make target. This commit takes advantage of that and replaces $(if $(KBUILD_VERBOSE:1=),@) with $(Q). Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com

[PATCH 3/3] kbuild: handle C=... and M=... after entering into build directory

2014-09-09 Thread Masahiro Yamada
This commit avoids processing C=... and M=... twice when O=... is also given. Besides, we can also remove KBUILD_EXTMOD=$(KBUILD_EXTMOD) in the sub-make target. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Makefile | 60

[PATCH 1/3] kbuild: fake the Entering directory ... message more simply

2014-09-09 Thread Masahiro Yamada
-by: Masahiro Yamada yamad...@jp.panasonic.com --- Makefile | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/Makefile b/Makefile index f7b9174..c1bd5a4 100644 --- a/Makefile +++ b/Makefile @@ -10,11 +10,9 @@ NAME = Shuffling Zombie Juror # Comments in this file

[PATCH] kbuild: simplify build, clean, modbuiltin shorthands

2014-09-09 Thread Masahiro Yamada
not be annoying to add $(srctree)/ all the time. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Makefile | 2 +- scripts/Kbuild.include | 4 ++-- scripts/Makefile.clean | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 1a60bdd

[PATCH 0/3] kbuild: better implementation to display Entering directory ...

2014-09-09 Thread Masahiro Yamada
Masahiro Yamada (3): kbuild: fake the Entering directory ... message more simply kbuild: use $(Q) for sub-make target kbuild: handle C=... and M=... after entering into build directory Makefile | 82 ++-- 1 file changed, 38

[PATCH] mtd: denali: fix include guard and license block of denali.h

2014-08-29 Thread Masahiro Yamada
It looks like this header file is a concatenation of two headers. Anyway, the include guard should be renamed and placed at the correct postion and the license block in the middle should be deleted. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- drivers/mtd/nand/denali.h | 27

Re: [PATCH 3/3] kbuild: remove obj-n and lib-n handling

2014-10-02 Thread Masahiro Yamada
Hi Michal, On Thu, 02 Oct 2014 15:04:44 +0200 Michal Marek mma...@suse.cz wrote: On 2014-09-09 12:26, Masahiro Yamada wrote: Kconfig never defines CONFIG_* as 'n'. Now obj-n is only used in firmware/Makefile and it can be replaced with obj-. No makefile uses lib-n. BTW

Re: [PATCH] kbuild: Do not reference *-n variables in the Makefile

2014-10-02 Thread Masahiro Yamada
the directories are hardcoded in {init,code,drivers,net,libs}-y; there are currently no Kconfig variables involved. But let's keep this generic and handle *-m and *- just in case. Agreed and thank you! Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line unsubscribe

[PATCH] kbuild: collect shorthands into the top Makefile

2014-10-29 Thread Masahiro Yamada
and export them in the top Makefile because $(srctree) is constant during the build process. For consistency, build and modbuiltin should be also moved. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Makefile | 13 ++--- scripts/Kbuild.include

Re: [PATCH] kbuild: collect shorthands into the top Makefile

2014-10-30 Thread Masahiro Yamada
Hi Sam, On Wed, 29 Oct 2014 19:59:07 +0100 Sam Ravnborg s...@ravnborg.org wrote: On Wed, Oct 29, 2014 at 04:27:31PM +0900, Masahiro Yamada wrote: The motivation of this commit is to avoid duplicated definitions of clean and hdr-inst shorthands. The shorthand clean is defined in both

How to build the kernel with Clang?

2014-09-18 Thread Masahiro Yamada
. make[1]: *** [kernel/bounds.s] Error 1 make: *** [prepare0] Error 2 Is DEFINE() macro working? Do we need a patch like follows? http://patchwork.ozlabs.org/patch/375026/ Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH v3 0/7] mtd: denali: A collection of trivial coding style fixes

2014-09-21 Thread Masahiro Yamada
Hi Brian, On Fri, 19 Sep 2014 10:00:20 -0700 Brian Norris computersforpe...@gmail.com wrote: On Tue, Sep 16, 2014 at 08:04:18PM +0900, Masahiro Yamada wrote: Masahiro Yamada (7): mtd: denali: fix the format of comment blocks mtd: denali: remove unnecessary variable

Re: [PATCH v2 0/7] mtd: denali: A collection of trivial coding style fixes

2014-09-15 Thread Masahiro Yamada
Hi Brian, On Mon, 15 Sep 2014 17:36:20 -0700 Brian Norris computersforpe...@gmail.com wrote: On Tue, Sep 09, 2014 at 11:01:50AM +0900, Masahiro Yamada wrote: Changes in v2: - Join quotes strings into a single line Masahiro Yamada (7): mtd: denali: fix the format of comment

[PATCH v3 6/7] mtd: denali: remove unnecessary parentheses

2014-09-16 Thread Masahiro Yamada
We should use parentheses only when they are necessary or they really improve the readability. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Reviewed-by: Josh Triplett j...@joshtriplett.org --- Changes in v3: - Rebase on l2-mtd.git Changes in v2: None drivers/mtd/nand/denali.c

[PATCH v3 0/7] mtd: denali: A collection of trivial coding style fixes

2014-09-16 Thread Masahiro Yamada
Masahiro Yamada (7): mtd: denali: fix the format of comment blocks mtd: denali: remove unnecessary variable initializations mtd: denali: remove unnecessary casts mtd: denali: change the type of iterators to int mtd: denali: remove a set-but-unused variable mtd: denali: remove

[PATCH v3 7/7] mtd: denali: fix indents and other trivial things

2014-09-16 Thread Masahiro Yamada
split across lines - WARNING: else is not generally useful after a break or return - WARNING: Missing a blank line after declarations - WARNING: Avoid line continuations in quoted strings Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Changes in v3: - Rebase on l2-mtd.git Changes

[PATCH v3 5/7] mtd: denali: remove a set-but-unused variable

2014-09-16 Thread Masahiro Yamada
The variable retry in wait_for_irq() is set, but not used. Likewise, for irq_status in denali_read_page_raw(). Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Reviewed-by: Josh Triplett j...@joshtriplett.org --- Changes in v3: - Remove also set-but-unused irq_status Changes in v2

Re: [PATCH v2 0/7] mtd: denali: A collection of trivial coding style fixes

2014-09-16 Thread Masahiro Yamada
Hi Brian, On Mon, 15 Sep 2014 22:07:32 -0700 Brian Norris computersforpe...@gmail.com wrote: Hi Masahiro, On Tue, Sep 16, 2014 at 11:11:58AM +0900, Masahiro Yamada wrote: On Mon, 15 Sep 2014 17:36:20 -0700 Brian Norris computersforpe...@gmail.com wrote: On Tue, Sep 09, 2014 at 11

Re: [PATCH v3 0/7] mtd: denali: A collection of trivial coding style fixes

2014-09-17 Thread Masahiro Yamada
Hi Brian, On Wed, 17 Sep 2014 10:13:08 -0700 Brian Norris computersforpe...@gmail.com wrote: On Tue, Sep 16, 2014 at 08:04:18PM +0900, Masahiro Yamada wrote: Masahiro Yamada (7): mtd: denali: fix the format of comment blocks mtd: denali: remove unnecessary variable

Re: [PATCH 2/2] merge_config.sh: add -? for help

2014-12-23 Thread Masahiro Yamada
Hi, Olof Not that I care, but what does this patch improve? On Thu, 11 Dec 2014 12:55:04 -0800 Olof Johansson o...@lixom.net wrote: It's usual enough for help text that it makes sense to support it. Signed-off-by: Olof Johansson o...@lixom.net --- scripts/kconfig/merge_config.sh |

[PATCH] linux/kernel.h: merge ARRAY_AND_SIZE defines

2014-12-23 Thread Masahiro Yamada
ARRAY_AND_SIZE is a useful macro. Its definition is already duplicated in some headers. Move it to include/linux/kernel.h. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- arch/arm/mach-mmp/common.h| 1 - arch/arm/mach-pxa/generic.h | 2 -- arch/arm/mach-ux500/db8500

[PATCH 0/2] kbuild: Refactor ./Kbuild

2014-12-23 Thread Masahiro Yamada
Masahiro Yamada (2): kbuild: merge bounds.h and asm-offsets.h rules kbuild: remove redundant line from bounds.h/asm-offsets.h Kbuild | 60 +--- 1 file changed, 21 insertions(+), 39 deletions(-) -- 1.9.1 -- To unsubscribe from

[PATCH 2/2] kbuild: remove redundant line from bounds.h/asm-offsets.h

2014-12-23 Thread Masahiro Yamada
This line produces an extra comment line for bounds.h and asm-offsets.h. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Kbuild | 1 - 1 file changed, 1 deletion(-) diff --git a/Kbuild b/Kbuild index 55a639f..5ac6d06 100644 --- a/Kbuild +++ b/Kbuild @@ -23,7 +23,6 @@ define

[PATCH 1/2] kbuild: merge bounds.h and asm-offsets.h rules

2014-12-23 Thread Masahiro Yamada
The rules cmd_bounds and cmd_offsets are almost the same. (The difference is only the include guards.) They can be merged. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Kbuild | 59 +-- 1 file changed, 21 insertions(+), 38

[PATCH 4/6] kbuild,gcov: simplify kernel/gcov/Makefile

2014-12-24 Thread Masahiro Yamada
Kbuild descends into kernel/gcov/ directory only when CONFIG_GCOV_KERNEL is enabled. (See kernel/Makefile) CONFIG_GCOV_KERNEL check can be omitted in kernel/gcov/Makefile. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Cc: Peter Oberparleiter ober...@linux.vnet.ibm.com --- kernel

[PATCH 1/6] kbuild: fix cc-ifversion macro

2014-12-24 Thread Masahiro Yamada
The macro cc-version takes no argument. Drop $(CC) from the cc-ifversion definition. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- scripts/Kbuild.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include index

[PATCH 3/6] kbuild,gcov: remove unnecessary workaround

2014-12-24 Thread Masahiro Yamada
Since commit 371fdc77af44 (kbuild: collect shorthands into scripts/Kbuild.include), scripts/Makefile.clean includes scripts/Kbuild.include. The workaround and the comment block in kernel/gcov/Makefile are no longer necessary. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Cc: Peter

[PATCH 6/6] kbuild,gcov: simplify kernel/gcov/Makefile more

2014-12-24 Thread Masahiro Yamada
CONFIG_GCOV_FORMAT_3_4 / _4_7 / _AUTODETECT are exclusive. Compare the CC version only when _AUTODETECT is enabled. This change should have no impact. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Cc: Peter Oberparleiter ober...@linux.vnet.ibm.com --- kernel/gcov/Makefile | 23

[PATCH 2/6] kbuild: do not add $(call ...) to invoke cc-version or cc-fullversion

2014-12-24 Thread Masahiro Yamada
The macros cc-version, cc-fullversion and ld-version take no argument. It is not necessary to add $(call ...) to invoke them. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Documentation/kbuild/makefiles.txt | 4 ++-- arch/parisc/Makefile | 2 +- arch/powerpc

[PATCH 5/6] kbuild: allow cc-ifversion to have the argument for false condition

2014-12-24 Thread Masahiro Yamada
The macro try-run can have an argument for each of true and false cases. Having an argument for the false case of cc-ifversion (and ld-ifversion) would be useful too. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Documentation/kbuild/makefiles.txt | 5 +++-- scripts

[PATCH 0/6] kbuild: refactor Makefiles related with cc-version

2014-12-24 Thread Masahiro Yamada
Masahiro Yamada (6): kbuild: fix cc-ifversion macro kbuild: do not add $(call ...) to invoke cc-version or cc-fullversion kbuild,gcov: remove unnecessary workaround kbuild,gcov: simplify kernel/gcov/Makefile kbuild: allow cc-ifversion to have the argument for false condition kbuild

[PATCH] kbuild: collect shorthands into scripts/Kbuild.include

2014-11-26 Thread Masahiro Yamada
shorthands. It requires scripts/Makefile.clean to include scripts/Kbuild.include, but its impact on the performance of make clean should be negligible. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Marek, please decide if this patch should be applied or not. I am not so sure if 10

[PATCH] kbuild: use mixed-targets when two or more config targets are given

2014-12-11 Thread Masahiro Yamada
. This commit turns on mixed-targets when $(MAKECMDGOALS) includes at least one config target and also includes another target. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index d9af2be

[PATCH] kbuild: remove old information in headers_install.txt document

2014-12-01 Thread Masahiro Yamada
The arch header directories include/asm-* were moved long before. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Documentation/kbuild/headers_install.txt | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Documentation/kbuild/headers_install.txt b

[PATCH] kbuild: remove redundant -rR flag of hdr-inst

2014-12-01 Thread Masahiro Yamada
Passing -rR for make headers_install is redundant because the top Makefile has already set -rR to MAKEFLAGS. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- scripts/Kbuild.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/Kbuild.include b

[PATCH] kbuild: update headers_install.txt document

2014-12-02 Thread Masahiro Yamada
The arch header directories include/asm-* were moved long ago. Now we should check the existence of arch/*/include/uapi/asm/Kbuild to see if an architecture supports the headers installation. (Actually, um is the only architecture that does not have it.) Signed-off-by: Masahiro Yamada yamad

[PATCH] kbuild: fix scripts/headers.sh to see the correct Kbuild path

2014-12-02 Thread Masahiro Yamada
The exported headers were moved to uapi directories. We should check the existence of arch/*/include/uapi/asm/Kbuild. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- scripts/headers.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/headers.sh b/scripts

[PATCH] kconfig: fix a misspelling in scripts/kconfig/merge_config.sh

2014-12-02 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- scripts/kconfig/merge_config.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh index 81b0c61..efa4733 100755 --- a/scripts/kconfig/merge_config.sh

[PATCH v2] ARM: mm: fix size rounding-down of arm_add_memory() function

2014-12-21 Thread Masahiro Yamada
The current rounding of size is wrong: - If start is sufficiently near the next page boundary, size is decremented by more than enough and the last page is lost. - If size is sufficiently small, it is wrapped around and gets a bogus value. Signed-off-by: Masahiro Yamada yamad

[Question] How to print size_t type variable?

2014-12-15 Thread Masahiro Yamada
: warning: format '%zd' expects argument of type 'signed size_t', but argument 2 has type 'ssize_t' [-Wformat] Any advice? How to fix this issue? Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [Question] How to print size_t type variable?

2014-12-15 Thread Masahiro Yamada
Hi Geert, On Mon, 15 Dec 2014 10:38:23 +0100 Geert Uytterhoeven ge...@linux-m68k.org wrote: Hi Yamada-san, On Mon, Dec 15, 2014 at 10:32 AM, Masahiro Yamada yamad...@jp.panasonic.com wrote: I read through Documentation/printk-formats.txt It clearly says to use %zu or %zx to print

Re: [Question] How to print size_t type variable?

2014-12-15 Thread Masahiro Yamada
Hi Geert, On Mon, 15 Dec 2014 12:00:25 +0100 Geert Uytterhoeven ge...@linux-m68k.org wrote: Hi Yamada-san, On Mon, Dec 15, 2014 at 11:51 AM, Masahiro Yamada yamad...@jp.panasonic.com wrote: Geert Uytterhoeven ge...@linux-m68k.org wrote: On Mon, Dec 15, 2014 at 10:32 AM, Masahiro Yamada

[PATCH] ARM: replace magic number with PAGE_SHIFT macro in fixup_pv code

2014-11-27 Thread Masahiro Yamada
This line converts PHYS_OFFSET into PHYS_PFN_OFFSET. It is better to use PAGE_SHIFT rather than the magic number 12. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- arch/arm/kernel/head.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kernel/head.S b

[PATCH] ARM: decompressor: fix a wrong comment

2014-11-27 Thread Masahiro Yamada
This comment does not correspond to the actual code. When zImage is loaded at a lower *OR* higher address of the destination of Image, it won't overwrite itself. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- arch/arm/boot/compressed/head.S | 2 +- 1 file changed, 1 insertion

[PATCH] uapi: fix to export linux/vm_sockets.h

2014-11-30 Thread Masahiro Yamada
A typo header=y was introduced by commit 7071cf7fc435 (uapi: add missing network related headers to kbuild). Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com Cc: Stephen Hemminger step...@networkplumber.org --- include/uapi/linux/Kbuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] uapi: fix to export linux/vm_sockets.h

2014-12-04 Thread Masahiro Yamada
Hi. Is there a chance to fix this by the Linux 3.18 release? Thanks. On Mon, 1 Dec 2014 10:16:17 +0900 Masahiro Yamada yamad...@jp.panasonic.com wrote: A typo header=y was introduced by commit 7071cf7fc435 (uapi: add missing network related headers to kbuild). Signed-off-by: Masahiro

Re: [PATCH] clk: remove unnecessary substitution

2014-12-04 Thread Masahiro Yamada
Hi, Mike Turquette I posted this trivial fix about 10 months ago. Is it applicable? On Tue, 28 Jan 2014 15:09:47 +0900 Masahiro Yamada yamad...@jp.panasonic.com wrote: Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- drivers/clk/clk.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH] kbuild: fix scripts/headers.sh to see the correct Kbuild path

2014-12-10 Thread Masahiro Yamada
Hi Paul, On Mon, 08 Dec 2014 22:58:33 +0100 Paul Bolle pebo...@tiscali.nl wrote: Masahiro, On Wed, 2014-12-03 at 15:52 +0900, Masahiro Yamada wrote: The exported headers were moved to uapi directories. We should check the existence of arch/*/include/uapi/asm/Kbuild. Signed-off

Re: [PATCH] kbuild: remove old information in headers_install.txt document

2014-12-10 Thread Masahiro Yamada
Hi Yann, On Fri, 05 Dec 2014 15:23:48 +0100 Yann Droneaud ydrone...@opteya.com wrote: Hi, Le mardi 02 decembre 2014 a 13:28 +0900, Masahiro Yamada a ecrit : The arch header directories include/asm-* were moved long before. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com

Re: [PATCH] kbuild: trivial - fix the help doc of CONFIG_CC_OPTIMIZE_FOR_SIZE

2014-12-10 Thread Masahiro Yamada
Hi Michal, Does this seem OK? On Tue, 5 Aug 2014 14:43:07 +0900 Masahiro Yamada yamad...@jp.panasonic.com wrote: Other than GCC, we have another choice, Clang for building the kernel these days. It seems better to say compiler rather than gcc. Signed-off-by: Masahiro Yamada yamad

[PATCH] kbuild: remove warning about make depend

2015-02-03 Thread Masahiro Yamada
Enough time has passed since make depend was deprecated. Nobody would be in trouble without this hint. Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com --- Makefile | 6 -- 1 file changed, 6 deletions(-) diff --git a/Makefile b/Makefile index 109c173..7aeba7a 100644 --- a/Makefile

[PATCH] ARM: decompressor: remove unused cache flush code

2015-01-21 Thread Masahiro Yamada
As ARM ARM says, the bit 19-16 of ID_MMFR1 is always 0b because ARMv7 requires a hierarchical cache implementation. The line mcrp15, 0, r10, c7, c14, 0 is not reachable. Moreover, the v7_flush_dcache_all in arch/arm/mm/cache-v7.S does not check the ID_MMFR1. Signed-off-by: Masahiro

  1   2   3   4   5   6   7   8   9   10   >