Re: [PATCH 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw

2018-10-26 Thread Matheus Tavares Bernardino
On Fri, Oct 26, 2018 at 7:04 AM Dan Carpenter wrote: > > On Thu, Oct 25, 2018 at 09:45:11PM -0300, Matheus Tavares wrote: > > From: Victor Colombo > > > > This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and > > implements the relative read behavior at ad2s90_read_raw. > > > >

Re: [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling

2018-10-30 Thread Matheus Tavares Bernardino
On Sun, Oct 28, 2018 at 1:52 PM Jonathan Cameron wrote: > > On Fri, 26 Oct 2018 22:59:59 -0300 > Matheus Tavares wrote: > > > This patch set adds scale info to ad2s90's single channel, improve > > error handling in it's functions and fix a possible race condition > > issue. > > > > The goal with

Re: [PATCH v2 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw

2018-11-03 Thread Matheus Tavares Bernardino
On Sun, Oct 28, 2018 at 1:50 PM Jonathan Cameron wrote: > > On Fri, 26 Oct 2018 23:00:04 -0300 > Matheus Tavares wrote: > > > This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and > > implements the relative read behavior at ad2s90_read_raw. > > > > Signed-off-by: Victor Colombo > >

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

2018-11-09 Thread Matheus Tavares Bernardino
On Fri, Nov 9, 2018 at 8:13 PM Fabio Estevam wrote: > > Hi Matheus, > Hi, Fabio > On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares > wrote: > > > > This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c, > > which solves the checkpatch.pl warning: > > "WARNING: Missing or malformed

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

2018-11-09 Thread Matheus Tavares Bernardino
On Fri, Nov 9, 2018 at 10:20 PM Greg Kroah-Hartman wrote: > > On Fri, Nov 09, 2018 at 09:19:52PM -0200, Matheus Tavares Bernardino wrote: > > On Fri, Nov 9, 2018 at 8:13 PM Fabio Estevam wrote: > > > > > > Hi Matheus, > > > > > > > Hi, Fab

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

2018-11-10 Thread Matheus Tavares Bernardino
On Sat, Nov 10, 2018 at 11:23 AM Fabio Estevam wrote:> > Hi Matheus, > > On Fri, Nov 9, 2018 at 10:27 PM Matheus Tavares Bernardino > wrote: > > > Got it, thanks for the explanation! I'll correct this in v2. > > One more suggestion: in v2 you could also consi

Re: [PATCH 2/6] staging:iio:ad2s90: Remove spi setup that should be done via dt

2018-11-15 Thread Matheus Tavares Bernardino
On Sun, Nov 11, 2018 at 9:42 AM Jonathan Cameron wrote: > > On Fri, 9 Nov 2018 20:00:40 -0200 > Matheus Tavares wrote: > > > The ad2s90 driver currently sets some spi settings (max_speed_hz and > > mode) at ad2s90_probe. This should, instead, be handled via device tree. > > This patch removes

[PATCH] staging: iio: ad2s1210: fix 'assignment operator' style checks

2018-10-05 Thread Matheus Tavares Bernardino
This patch fixes all "Assignment operator '=' should be on the previous line" checks found in ad2s1210.c by checkpatch.pl. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s1210.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] iio: adc: Replace license text w/ SPDX identifier

2018-12-01 Thread Matheus Tavares Bernardino
On Wed, Nov 28, 2018 at 4:54 PM Scott Branden wrote: >> >> >> On 2018-11-28 9:53 a.m., Matheus Tavares wrote: >> >> From: Lucas Santos >> >> This patch removes all license boilerplate texts from the .c and .h >> > I know other people don't follow the patch guidelines, > > but more info on proper

Re: [PATCH] iio: adc: Replace license text w/ SPDX identifier

2018-12-01 Thread Matheus Tavares Bernardino
On Thu, Nov 29, 2018 at 5:37 AM Krzysztof Kozlowski wrote: > > On Wed, 28 Nov 2018 at 18:53, Matheus Tavares > wrote: > > > > From: Lucas Santos > > > > This patch removes all license boilerplate texts from the .c and .h > > files at drivers/iio/adc/ and, instead, adds the proper SPDX license

Re: [PATCH] iio: adc: Replace license text w/ SPDX identifier

2018-12-01 Thread Matheus Tavares Bernardino
Thanks for the review! I will fix those places. Matheus On Wed, Nov 28, 2018 at 5:29 PM Alexandre Belloni wrote: > > Hello, > > On 28/11/2018 15:53:12-0200, Matheus Tavares wrote: > > diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c > > index f10443f92e4c..9f9c186e2135

Re: [PATCH v2 4/7] dt-bindings:iio:resolver: Add docs for ad2s90

2018-11-20 Thread Matheus Tavares Bernardino
On Mon, Nov 19, 2018 at 6:22 AM Ardelean, Alexandru wrote: > > On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote: > > This patch adds the device tree binding documentation for the ad2s90 > > resolver-to-digital converter. > > > > One minor comment inline. > > > Signed-off-by: Matheus

Re: [PATCH v2 1/7] staging:iio:ad2s90: Add device tree support

2018-11-20 Thread Matheus Tavares Bernardino
On Mon, Nov 19, 2018 at 6:09 AM Ardelean, Alexandru wrote: > > On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote: > > This patch adds device tree support to ad2s90 with standard > > device tree id table. > > > > Hey, > > Comment inline > > > Signed-off-by: Matheus Tavares > > --- > >

Re: [PATCH 4/6] dt-bindings:iio:resolver: Add docs for ad2s90

2018-11-16 Thread Matheus Tavares Bernardino
On Sun, Nov 11, 2018 at 9:48 AM Jonathan Cameron wrote: > > On Fri, 9 Nov 2018 20:00:42 -0200 > Matheus Tavares wrote: > > > This patch adds the device tree binding documentation for the ad2s90 > > resolver-to-digital converter. > > > > Signed-off-by: Matheus Tavares > > --- > >

Re: [PATCH] staging:iio:adc:ad7280a: add of_match_table entry

2019-07-26 Thread Matheus Tavares Bernardino
On Fri, Jul 26, 2019 at 2:30 AM Ardelean, Alexandru wrote: > > On Fri, 2019-07-26 at 01:38 +0530, Kartik Kulkarni wrote: > > Add the of_device_id struct and the respective > > of_match_device entry to complete device tree support. > > > > This would be a [V2] I suppose. > > This change also does

Re: [PATCH v2 4/7] dt-bindings:iio:resolver: Add docs for ad2s90

2018-11-20 Thread Matheus Tavares Bernardino
On Mon, Nov 19, 2018 at 6:22 AM Ardelean, Alexandru wrote: > > On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote: > > This patch adds the device tree binding documentation for the ad2s90 > > resolver-to-digital converter. > > > > One minor comment inline. > > > Signed-off-by: Matheus

Re: [PATCH v2 1/7] staging:iio:ad2s90: Add device tree support

2018-11-20 Thread Matheus Tavares Bernardino
On Mon, Nov 19, 2018 at 6:09 AM Ardelean, Alexandru wrote: > > On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote: > > This patch adds device tree support to ad2s90 with standard > > device tree id table. > > > > Hey, > > Comment inline > > > Signed-off-by: Matheus Tavares > > --- > >

Re: [PATCH 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw

2018-10-26 Thread Matheus Tavares Bernardino
On Fri, Oct 26, 2018 at 7:04 AM Dan Carpenter wrote: > > On Thu, Oct 25, 2018 at 09:45:11PM -0300, Matheus Tavares wrote: > > From: Victor Colombo > > > > This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and > > implements the relative read behavior at ad2s90_read_raw. > > > >

Re: [PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling

2018-10-30 Thread Matheus Tavares Bernardino
On Sun, Oct 28, 2018 at 1:52 PM Jonathan Cameron wrote: > > On Fri, 26 Oct 2018 22:59:59 -0300 > Matheus Tavares wrote: > > > This patch set adds scale info to ad2s90's single channel, improve > > error handling in it's functions and fix a possible race condition > > issue. > > > > The goal with

Re: [PATCH] iio: adc: Replace license text w/ SPDX identifier

2018-12-01 Thread Matheus Tavares Bernardino
On Wed, Nov 28, 2018 at 4:54 PM Scott Branden wrote: >> >> >> On 2018-11-28 9:53 a.m., Matheus Tavares wrote: >> >> From: Lucas Santos >> >> This patch removes all license boilerplate texts from the .c and .h >> > I know other people don't follow the patch guidelines, > > but more info on proper

Re: [PATCH] iio: adc: Replace license text w/ SPDX identifier

2018-12-01 Thread Matheus Tavares Bernardino
Thanks for the review! I will fix those places. Matheus On Wed, Nov 28, 2018 at 5:29 PM Alexandre Belloni wrote: > > Hello, > > On 28/11/2018 15:53:12-0200, Matheus Tavares wrote: > > diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c > > index f10443f92e4c..9f9c186e2135

Re: [PATCH] iio: adc: Replace license text w/ SPDX identifier

2018-12-01 Thread Matheus Tavares Bernardino
On Thu, Nov 29, 2018 at 5:37 AM Krzysztof Kozlowski wrote: > > On Wed, 28 Nov 2018 at 18:53, Matheus Tavares > wrote: > > > > From: Lucas Santos > > > > This patch removes all license boilerplate texts from the .c and .h > > files at drivers/iio/adc/ and, instead, adds the proper SPDX license

Re: [PATCH 2/6] staging:iio:ad2s90: Remove spi setup that should be done via dt

2018-11-15 Thread Matheus Tavares Bernardino
On Sun, Nov 11, 2018 at 9:42 AM Jonathan Cameron wrote: > > On Fri, 9 Nov 2018 20:00:40 -0200 > Matheus Tavares wrote: > > > The ad2s90 driver currently sets some spi settings (max_speed_hz and > > mode) at ad2s90_probe. This should, instead, be handled via device tree. > > This patch removes

Re: [PATCH 4/6] dt-bindings:iio:resolver: Add docs for ad2s90

2018-11-16 Thread Matheus Tavares Bernardino
On Sun, Nov 11, 2018 at 9:48 AM Jonathan Cameron wrote: > > On Fri, 9 Nov 2018 20:00:42 -0200 > Matheus Tavares wrote: > > > This patch adds the device tree binding documentation for the ad2s90 > > resolver-to-digital converter. > > > > Signed-off-by: Matheus Tavares > > --- > >

Re: [PATCH v2 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw

2018-11-03 Thread Matheus Tavares Bernardino
On Sun, Oct 28, 2018 at 1:50 PM Jonathan Cameron wrote: > > On Fri, 26 Oct 2018 23:00:04 -0300 > Matheus Tavares wrote: > > > This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and > > implements the relative read behavior at ad2s90_read_raw. > > > > Signed-off-by: Victor Colombo > >

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

2018-11-09 Thread Matheus Tavares Bernardino
On Fri, Nov 9, 2018 at 8:13 PM Fabio Estevam wrote: > > Hi Matheus, > Hi, Fabio > On Fri, Nov 9, 2018 at 8:01 PM Matheus Tavares > wrote: > > > > This patch adds the SPDX GPL-2.0-only license identifier to ad2s90.c, > > which solves the checkpatch.pl warning: > > "WARNING: Missing or malformed

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

2018-11-09 Thread Matheus Tavares Bernardino
On Fri, Nov 9, 2018 at 10:20 PM Greg Kroah-Hartman wrote: > > On Fri, Nov 09, 2018 at 09:19:52PM -0200, Matheus Tavares Bernardino wrote: > > On Fri, Nov 9, 2018 at 8:13 PM Fabio Estevam wrote: > > > > > > Hi Matheus, > > > > > > > Hi, Fab

Re: [PATCH 5/6] staging:iio:ad2s90: Add SPDX license identifier

2018-11-10 Thread Matheus Tavares Bernardino
On Sat, Nov 10, 2018 at 11:23 AM Fabio Estevam wrote:> > Hi Matheus, > > On Fri, Nov 9, 2018 at 10:27 PM Matheus Tavares Bernardino > wrote: > > > Got it, thanks for the explanation! I'll correct this in v2. > > One more suggestion: in v2 you could also consi

[PATCH] staging: iio: ad2s1210: fix 'assignment operator' style checks

2018-10-05 Thread Matheus Tavares Bernardino
This patch fixes all "Assignment operator '=' should be on the previous line" checks found in ad2s1210.c by checkpatch.pl. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s1210.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git