Hi,
> this makes me think something is wrong with the data structure.
> We should have a be32 there, it seems to me.
You mean something like :
struct ti_write_data_bytes {
u8 bAddrType;
u8 bDataType;
u8 bDataCounter;
__be32 wBaseAddr;
u8
USB to Serial Hub with Isolation.
This driver is based on GPL MOXA driver written by Hen Huang and available
on MOXA website. The original driver was based on io_ti serial driver.
Signed-off-by: Mathieu OTHACEHE
---
Hi,
Sorry for late reply, here is the third version of the driver.
Thank you
USB to Serial Hub with Isolation.
This driver is based on GPL MOXA driver written by Hen Huang and available
on MOXA website. The original driver was based on io_ti serial driver.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/Kconfig | 16 +
drivers/usb/serial/Makefile |1
t
declared. Should it be static?
drivers/staging/rtl8821ae/pci.c:2105:21: warning: symbol 'hw_export' was not
declared. Should it be static?
Signed-off-by: Mathieu OTHACEHE
---
This patch is part of task 16 of the eudyptula challenge
drivers/staging/rtl8821ae/pci.c | 18 +
This patch fixes the following checkpatch.pl warning in lnet/lnet/lib-eq.c:
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Mathieu OTHACEHE
---
This patch is part of task 10 of the eudyptula challenge
drivers/staging/lustre/lnet/lnet/lib
Hi Johan,
Thanks for your review.
> Looks like this code could use a few vid/pid temporaries.
> I'm not sure it makes sense to try to load a "ti_usb-v110a-p1150.fw"
> firmware before requesting the moxa firmware. Avoids a confusing:
> usb 1-2.2: Direct firmware load for ti_usb-v110a-p1150.fw fa
> No, I was trying to say that the we should not attempt to load a
> firmware on the "ti_usb-v%04x-p%04x.fw" format before loading the moxa
> firmware.
For MTS devices (mts_*.fw) and for devices using generic firmware (ti_3410.fw
and ti_5052.fw), ti_usb-v%04x-p%04x.fw loading is already failing.
Hub with Isolation.
These devices are based on TI 3410 chip.
Signed-off-by: Mathieu OTHACEHE
---
Hi,
Here is the second version of the patch.
Thank you,
Mathieu
Changelog:
v2:
* Add a rs485_only flag to device structure.
* Try to load moxa firmware without fallback.
drivers/usb/serial
Remove lines commenting the obvious.
Remove vi related comment.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 23 ++-
1 file changed, 2 insertions(+), 21 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial
Fix some minor indentation problems.
Also correct a multi-line comment.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers
The generic driver doesn't call tty_wakeup in
usb_serial_generic_msr_changed so this tty_wakeup seems useless.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/dr
Add myself in the copyright section and as an author of the driver.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
callback because it is the
initial call to set_termios.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index
Add CMSPAR support in set_termios callback.
Move TI_UART_ENABLE_PARITY_CHECKING setting in the upper
block to avoid doing it twice.
Delete useless TI_UART_ENABLE_PARITY_CHECKING unsetting.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 19 ++-
1 file
Use usb_serial_generic_open in open callback to start read urb.
Also remove useless usb_device pointer.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 21 -
1 file changed, 4 insertions(+), 17 deletions(-)
diff --git a/drivers/usb/serial
Declare functions in a the right order to avoid prototyping.
There is no functional change here.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 1112 -
1 file changed, 544 insertions(+), 568 deletions(-)
diff --git a/drivers/usb
to do any padding.
This patch also move firmware buffer manipulation to ti_do_download
function.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 62 +++
1 file changed, 33 insertions(+), 29 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_
Use variables for vendor and product in download_firmware to improve
readability.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb
Save msr before testing the delta and waking up any waiters.
Also use port directly instead of tport->tp_port.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/ser
Use the format "error text: error value\n" when possible.
Drop redundant function names from error messages.
Also move a couple err messages to dbg messages.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 83 +--
1 file c
In ti_port structure, remove useless tp_tdev backpointer.
Also remove pointer to usb_serial_port.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 44 ---
1 file changed, 20 insertions(+), 24 deletions(-)
diff --git a/drivers/usb
Remove prefixes from ti_port and ti_device structures.
Also change type of is_3410 from int to bool.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 114 +-
1 file changed, 57 insertions(+), 57 deletions(-)
diff --git a/drivers/usb
Only shadow msr is accessed from interrupt context. So use the ti_port
spinlock to protect only shadow msr.
Add a mutex in ti_port to protect mcr from concurrent access.
Also move shadow mcr setting out of ti_set_mcr function.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial
It is sufficient to pass usb_serial_port structure to ti_get_serial_info
and ti_set_serial_info.
Also move functions above ioctl to avoid function prototyping
and use unsigned int instead of unsigned for cwait variable.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c
Use usb_serial_generic_close in close callback.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index
Setting DTR/RTS is handled using dtr_rts in tty_core.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index 2a993a2..d8bed30 100644
--- a
There is no need to keep a pointer to usb_serial in ti_port
structure.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial
mmand
sending.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 156 +++---
1 file changed, 88 insertions(+), 68 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index 91ea1b5..eb4df1e 1
Use kzalloc instead of kmalloc to avoid field initialisation to 0.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
It is useless to pass a specific context (ti_device) to the interrupt
callback.
So use the default context (usb_serial_port).
Remove useless variables in ti_interrupt_callback.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 55
Remove useless ti_device pointer, and change addr to u32.
Move function upper to avoid function prototyping.
Also change size variable in function from int to size_t.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 76 ---
1 file
It is useless to check the return of usb_get_serial_port_data.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 34 +-
1 file changed, 1 insertion(+), 33 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb
Use bulk_out_size instead of recalculate it with kfifo_size
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index eb4df1e
Remove read_bulk_callback, write_bulk_callback, write, write_room,
chars_in_buffer, throttle and unthrottle callbacks who uselessly
reimplements generic functions.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 315 --
1 file changed
Remove variables affected but never read.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index 58df42d..00ae52e 100644
--- a
Use C_X tty.h macros to avoid direct manipulation of termios
c_cflag variable.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb
Remove useless or redundant dev_dbg messages.
Fix debug-message typos.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 28 +---
1 file changed, 9 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb
Use macros to define 3410 and 5052 baud bases and remove useless casting.
Use macro to define usb download timeout.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/usb
Closing wait delay is configurable per device using TIOCSSERIAL.
Also initialise tty_port closing_wait in port_probe with default value.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a
Inline functions are preferable to macros resembling functions.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial
Hi,
The now reverted mxu11x0 turned out to be a copy of ti_usb_3410_5052 driver.
This aim of this serie is to apply all of the cleanups we did in mxu11x0 to
ti_usb_3410_5052.
Thank you,
Mathieu
Mathieu OTHACEHE (36):
usb: serial: ti_usb_3410_5052: Remove useless comments
usb: serial
__uX types should only be used for user-space interactions.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 66 ++-
1 file changed, 34 insertions(+), 32 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb
ti_read_data_request, ti_read_data_bytes and ti_interrupt are unused.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 21 -
1 file changed, 21 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052
The definitions in ti_usb_3410_5052.h are only used in
ti_usb_3410_5052.c.
The content of the header is copied in ti_usb_3410_5052.c.
Also correct a typo in macro TI_PIPE_MODE_CONTINOUS.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 237
__packed is preferred over __attribute__((packed)) for portability.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.h
b/drivers/usb/serial
se if the firmware was downloaded.
It avoids port_probe to fail since the device is reset.
Thanks,
Mathieu
On Wed, Nov 11, 2015 at 10:40:04AM +0100, Johan Hovold wrote:
> On Wed, Nov 11, 2015 at 10:35:47AM +0100, Mathieu OTHACEHE wrote:
> > Add a driver which supports :
> >
> &
USB to Serial Hub with Isolation.
This driver is based on GPL MOXA driver written by Hen Huang and available
on MOXA website. The original driver was based on io_ti serial driver.
Signed-off-by: Mathieu OTHACEHE
---
Hi Johan,
Thanks for your patience, here is v5,
Mathieu
Changes in v2:
* Use
Thinkpad X240 laptop has a working acpi_video backlight control but
using the default native backlight control, brightness keys does not work.
This patch force acpi_video use for this laptop by adding an exception in
video_detect_dmi_table.
Signed-off-by: Mathieu OTHACEHE
---
drivers/acpi
Hi Johan,
Thanks for merging !
About the follow ups, I have tested the driver on uport 1110 without double
OPEN_PORT/START_PORT commands.
It is still working fine so, I guess it can be removed.
Plus, I sniffed the Windows USB driver for uport 1110 and the commands sent are
: OPEN_PORT, SET_CONF
Hi,
Here are the follow up commits proposed during last Johan review of the
new mxu11x0 driver. I also patched a memory leak on usb_serial private data.
Mathieu
Mathieu OTHACEHE (3):
USB: mxu11x0: fix memory leak on usb_serial private data
USB: mxu11x0: clean device control commands
USB
Sending OPEN and START commands twice is not necessary for this driver.
Also send STOP command at close.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/mxu11x0.c | 31 +++
1 file changed, 7 insertions(+), 24 deletions(-)
diff --git a/drivers/usb/serial
fails
by returning ENODEV.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/mxu11x0.c | 130 ++-
1 file changed, 78 insertions(+), 52 deletions(-)
diff --git a/drivers/usb/serial/mxu11x0.c b/drivers/usb/serial/mxu11x0.c
index 354fcb5..0392531 100644
On nominal execution, private data allocated on port_probe and attach
are never freed. Add port_remove and release callbacks to free them
respectively.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/mxu11x0.c | 20
1 file changed, 20 insertions(+)
diff --git a
Thanks,
Mathieu
Mathieu OTHACEHE (4):
USB: mxu11x0: fix memory leak on usb_serial private data
USB: mxu11x0: clean device control commands
USB: mxu11x0: remove duplicated set_termios call
USB: mxu11x0: move firmware download and endpoint testing to probe
callback
drivers/usb/serial/mxu11x0.c
The function mxu1_set_termios is called twice in open callback.
Only the first call is necessary.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/mxu11x0.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/serial/mxu11x0.c b/drivers/usb/serial/mxu11x0.c
index 7ad2727
Sending OPEN and START commands twice is not necessary for this driver.
Also send STOP command at close.
Signed-off-by: Mathieu OTHACEHE
---
Changes in v2:
* Only remove OPEN_PORT and START_PORT in open callback.
drivers/usb/serial/mxu11x0.c | 21 +++--
1 file changed, 7
fails
by returning ENODEV.
Signed-off-by: Mathieu OTHACEHE
---
Changes in v2:
* Remove useless paranthesis
* Fix multi-line comment
drivers/usb/serial/mxu11x0.c | 131 ++-
1 file changed, 79 insertions(+), 52 deletions(-)
diff --git a/drivers/usb/serial
On nominal execution, private data allocated on port_probe and attach
are never freed. Add port_remove and release callbacks to free them
respectively.
Signed-off-by: Mathieu OTHACEHE
---
Changes in v2:
* Move release callback after attach callback
drivers/usb/serial/mxu11x0.c | 20
> I'm sorry, but it looks like 8250 based driver if I'm not mistaken. In
> which case why not to use 8250_core.c / 8250_port.c and entire 8250/
> infrastructure?
Well, the vendor is providing two drivers for his serial pci cards : mxser and
mxupcie.
The mxser driver has been cleaned up and integr
On Sun, Feb 28, 2016 at 01:20:16PM +0100, Johan Hovold wrote:
> On Sat, Jan 30, 2016 at 06:40:30PM +0100, Mathieu OTHACEHE wrote:
> > On Mon, Jan 25, 2016 at 01:01:59PM +0100, Johan Hovold wrote:
> > > On Mon, Jan 04, 2016 at 07:49:36PM +0100, Mathieu OTHACEHE wrote:
> >
available on MOXA website.
I was able to test it on a CP-168EL-A on PC.
Signed-off-by: Mathieu OTHACEHE
---
Hi,
Here is v3 of the patch, it fixes problems pointed out by
last Andy review.
Thanks,
Mathieu
Changelog:
V3:
* Add supported boards to 8250_pci blacklist
* Use MOXA_DEVICE macro to simplify
Hi,
Sorry about late reply.
No I haven't planned to do it soon. Your board is supported by mxser driver
(drivers/tty/mxser.c).
I think it would be nice to move everything from mxser.c to 8250_moxa.c.
The problem is mxser supports ISA and PCI boards and I don't have the hardware
to test it.
Ma
USB to Serial Hub with Isolation.
This driver is based on GPL MOXA driver written by Hen Huang and available
on MOXA website. The original driver was based on io_ti serial driver.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/Kconfig | 16 +
drivers/usb/serial/Makefile |1
Add support for hi3559v100-shub-pwm and hisilicon,hi3559v100-pwm
platforms.
Signed-off-by: Mathieu Othacehe
---
Documentation/devicetree/bindings/pwm/pwm-hibvt.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-hibvt.txt
b/Documentation
Add support for hi3559v100-shub-pwm and hisilicon,hi3559v100-pwm
platforms. They require a special quirk: pwm has to be enabled again
to force duty_cycle refresh.
Signed-off-by: Mathieu Othacehe
---
drivers/pwm/pwm-hibvt.c | 26 +++---
1 file changed, 23 insertions(+), 3
Factorize data reading in vcnl4000_measure into a vcnl4000_read_data
function. Also add a vcnl4000_write_data function.
Signed-off-by: Mathieu Othacehe
---
drivers/iio/light/vcnl4000.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers/iio
The bytes returned by the i2c reading need to be swapped
unconditionally. Otherwise, on be16 platforms, an incorrect value will be
returned.
Fixes: 62a1efb9f868 ("iio: add vcnl4000 combined ALS and proximity sensor")
Signed-off-by: Mathieu Othacehe
---
drivers/iio/light/vcnl4000.c | 6
for now, and the sample frequencies of ambient light data are
very low, do add buffer support for them.
Signed-off-by: Mathieu Othacehe
---
drivers/iio/light/Kconfig| 2 +
drivers/iio/light/vcnl4000.c | 161 ++-
2 files changed, 161 insertions(+), 2 deletions
enable and predisable functions respect the common form.
* Do not set the trigger by default.
* Remove the devm_iio_triggered_buffer_setup top half.
Mathieu Othacehe (5):
iio: vcnl4000: Fix i2c swapped word reading.
iio: vcnl4000: Factorize data reading and writing.
iio: vcnl4000: Add event support fo
The VCNL4010 and VCNL4020 chips are able to raise interrupts on proximity
threshold events. Add support for threshold rising and falling events for
those two chips.
Signed-off-by: Mathieu Othacehe
---
drivers/iio/light/vcnl4000.c | 454 ++-
1 file changed, 392
Add sampling frequency support for proximity data on VCNL4010 and VCNL4020
chips.
Signed-off-by: Mathieu Othacehe
---
drivers/iio/light/vcnl4000.c | 118 ++-
1 file changed, 117 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio
Hi Jonathan,
> One odd bit of code structure. If you didn't need to respin to fix
> patch 1's missing sign off I'd just fix it, but pleased tidy it up for v7.
Ok, fixed that in v7!
Thanks,
Mathieu
Add support for hi3559v100-shub-pwm and hisilicon,hi3559v100-pwm
platforms.
Reviewed-by: Rob Herring
Signed-off-by: Mathieu Othacehe
---
Documentation/devicetree/bindings/pwm/pwm-hibvt.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-hibvt.txt
Split pwm-soc array in one struct per soc and point to the
corresponding on in of-data.
Signed-off-by: Mathieu Othacehe
---
drivers/pwm/pwm-hibvt.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/pwm/pwm-hibvt.c b/drivers/pwm/pwm-hibvt.c
index
Add support for hi3559v100-shub-pwm and hisilicon,hi3559v100-pwm
platforms. They require a special quirk: pwm has to be enabled again
to force duty_cycle refresh.
Signed-off-by: Mathieu Othacehe
---
drivers/pwm/pwm-hibvt.c | 27 ++-
1 file changed, 26 insertions(+), 1
If there are more trigger consumers than
CONFIG_IIO_CONSUMERS_PER_TRIGGER, iio_trigger_attach_poll_func will
silently fail. Add an error message to inform the user that
CONFIG_IIO_CONSUMERS_PER_TRIGGER limit might be exceeded.
Signed-off-by: Mathieu Othacehe
---
drivers/iio/industrialio
If there are more trigger consumers than
CONFIG_IIO_CONSUMERS_PER_TRIGGER, iio_trigger_attach_poll_func will
silently fail. Add an error message to inform the user that
CONFIG_IIO_CONSUMERS_PER_TRIGGER limit might be exceeded.
Signed-off-by: Mathieu Othacehe
---
drivers/iio/industrialio
Split pwm-soc array in one struct per soc and point to the
corresponding on in of-data.
Signed-off-by: Mathieu Othacehe
---
drivers/pwm/pwm-hibvt.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/pwm/pwm-hibvt.c b/drivers/pwm/pwm-hibvt.c
index
Add support for hi3559v100-shub-pwm and hisilicon,hi3559v100-pwm
platforms. They require a special quirk: pwm has to be enabled again
to force duty_cycle refresh.
Signed-off-by: Mathieu Othacehe
---
drivers/pwm/pwm-hibvt.c | 28 +++-
1 file changed, 27 insertions(+), 1
Add support for hi3559v100-shub-pwm and hisilicon,hi3559v100-pwm
platforms.
Signed-off-by: Mathieu Othacehe
---
Documentation/devicetree/bindings/pwm/pwm-hibvt.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-hibvt.txt
b/Documentation
Some contributions appears as Mathieu Othacehe and other as Mathieu
OTHACEHE.
Signed-off-by: Mathieu Othacehe
---
.mailmap | 1 +
1 file changed, 1 insertion(+)
diff --git a/.mailmap b/.mailmap
index ea98fcc197e4..37e1847c7988 100644
--- a/.mailmap
+++ b/.mailmap
@@ -123,6 +123,7 @@ Mark Brown
Hi Uwe,
> The patch looks fine now. (If you have to do another round:
> s/again/twice/ in the commit log and s/once more/twice/ in the comment
> below.)
Ok.
>
> I wonder if this behaviour is a bug or a feature of the hardware. Is
> this additional enable needed to apply changes to both period an
mmand
sending.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 157 +++---
1 file changed, 88 insertions(+), 69 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index b5f3328..e8515eb 1
If speed is non null anymore, we can raise DTR and RTS flags in
ti_set_termios.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index
Fix some minor indentation problems.
Also correct a multi-line comment.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 42 +++
1 file changed, 23 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b
Use variables for vendor and product in download_firmware to improve
readability.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb
Add CMSPAR support in set_termios callback.
Move TI_UART_ENABLE_PARITY_CHECKING setting in the upper
block to avoid doing it twice.
Delete useless TI_UART_ENABLE_PARITY_CHECKING unsetting.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 19 ++-
1 file
The old_termios parameter is never used in set_termios callback.
Add a check to old_termios to see if we can return right away because
there is nothing to change.
Also pass NULL for old_termios in open callback because it is the
initial call to set_termios.
Signed-off-by: Mathieu OTHACEHE
Setting DTR/RTS is handled using dtr_rts in tty_core.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index 3a88c2f..b5ea850 100644
--- a
Remove variables affected but never read.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index 29bb62c..2b7fe89 100644
--- a
Use kzalloc instead of kmalloc to avoid field initialisation to 0.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index
tty_wakeup is already called when blocked bulk-out transfers complete.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_5052.c
index
Remove useless or redundant dev_dbg messages.
Fix debug-message typos.
Signed-off-by: Mathieu OTHACEHE
---
Changelog:
v2:
* Keep some debug messages
drivers/usb/serial/ti_usb_3410_5052.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/drivers/usb
It is useless to pass a specific context (ti_device) to the interrupt
callback. So use the default context (usb_serial_port).
Remove useless variables in ti_interrupt_callback.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 58 ---
1
Remove useless ti_device pointer, and change addr to u32.
Change size variable in function from int to size_t.
Also fix minor style issue.
Signed-off-by: Mathieu OTHACEHE
---
Changelog:
v2:
* Do not delete prototype and move function declaration
drivers/usb/serial/ti_usb_3410_5052.c | 20
Use macros to define 3410 and 5052 baud bases.
Use macro to define usb download timeout.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b
It is useless to check the return of usb_get_serial_port_data.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 34 +-
1 file changed, 1 insertion(+), 33 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb
Save msr before testing the delta and waking up any waiters.
Also use port directly instead of tport->tp_port.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/ser
to do any padding.
This patch also move firmware buffer manipulation to ti_do_download
function.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/ti_usb_3410_5052.c | 61 +++
1 file changed, 33 insertions(+), 28 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_
It is sufficient to pass usb_serial_port structure to ti_get_serial_info
and ti_set_serial_info.
Also use unsigned int instead of unsigned for cwait variable.
Signed-off-by: Mathieu OTHACEHE
---
Changelog:
v2:
* Do not remove prototypes and move functions declarations.
drivers/usb/serial
1 - 100 of 140 matches
Mail list logo
