On Thu, Jul 30, 2015 at 7:14 AM, Michael Ira Krufky mkru...@linuxtv.org wrote:
On Thu, Jul 30, 2015 at 6:08 AM, Joe Perches j...@perches.com wrote:
On Thu, 2015-07-30 at 10:47 +0100, Peter Griffin wrote:
Hi Mauro / Joe,
On Wed, 22 Jul 2015, Mauro Carvalho Chehab wrote:
Em Wed, 24 Jun 2015
to my series.
Joe - Can I add your signed-off-by?
Signed-off-by: Joe Perches j...@perches.com
Reviewed-by: Michael Ira Krufky mkru...@samsung.com
Joe, nice optimization - thanks for that.
With regards to Peter's patch, is this a digital-only tuner, or is it
a hybrid tuner?
The 5th byte that you
On Thu, Jul 30, 2015 at 7:14 AM, Michael Ira Krufky mkru...@linuxtv.org wrote:
On Thu, Jul 30, 2015 at 6:08 AM, Joe Perches j...@perches.com wrote:
On Thu, 2015-07-30 at 10:47 +0100, Peter Griffin wrote:
Hi Mauro / Joe,
On Wed, 22 Jul 2015, Mauro Carvalho Chehab wrote:
Em Wed, 24 Jun 2015
Thanks for this!
Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org>
On Fri, Nov 13, 2015 at 7:24 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
> The mxl111sf_demod_config structure is never modified, so declare it
> as const.
>
> Done with the help of Coccinelle.
offending code.
My bad O:-)
Thank you for this patch. Mauro, please apply it.
Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org>
> ---
> drivers/media/usb/dvb-usb-v2/mxl111sf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb
t; Signed-off-by: Julia Lawall <julia.law...@lip6.fr>
Thank you for this, Julia
Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org>
>
> ---
> drivers/media/usb/dvb-usb-v2/mxl111sf-tuner.c |6 +++---
> drivers/media/usb/dvb-usb-v2/mxl111sf-tuner.h |8
&
le with the following semantic patch:
> @r depends on (org || report)@
> type T;
> T[] E;
> position p;
> @@
> (
> (sizeof(E)@p /sizeof(*E))
> |
> (sizeof(E)@p /sizeof(E[...]))
> |
> (sizeof(E)@p /sizeof(T))
> )
>
> Signed-off-by: Jérémy Lefaure <je
t; actually want both of them.
>
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
Thank you, Arnd.
Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org>
> ---
> drivers/media/tuners/tda8290.c | 76
> ++
> 1 file changed, 39 insertio
correct - they can be CONSTified. My bad -- a lot of the code I
wrote many years ago has this problem -- I wasn't so stack-conscious
back then.
The bytes in `enable` / `disable` don't get changed, but they may be
copied to another byte array that does get changed. If would be best
to make these `static const`
Best regards,
Michael Ira Krufky
of index to zero. Cleans up the clang
> warning:
>
> drivers/media/usb/dvb-usb-v2/mxl111sf-i2c.c:519:3: warning: Value
> stored to 'index' is never read
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org>
Sean,
Please pardon the late reply. See my responses inline below:
On Wed, Jul 24, 2019 at 1:36 AM Sean Young wrote:
>
> On Sat, Jul 20, 2019 at 11:43:02AM +0530, Vandana BN wrote:
> > Syzbot reported global-out-of-bounds Read in dvb_pll_attach, while
> > accessing id[dvb_pll_devcount],
Hey Florian,
Thank you for the time and effort that you put into this patch series.
I was excited to see this, when I first saw it posted a few weeks ago.
I have every intention of giving it a review, but just haven't found
the time yet. I'm sure that Mauro would say the same.
I'm sure that he
On Wed, Jun 17, 2020 at 12:39 AM Florian Fainelli wrote:
>
>
>
> On 6/11/2020 9:45 PM, Florian Fainelli wrote:
> >
> >
> > On 6/5/2020 9:24 AM, Florian Fainelli wrote:
> >> Hi all,
> >>
> >> This long patch series was motivated by backporting Jaedon's changes
> >> which add a proper ioctl
Kangjie,
On Wed, Dec 26, 2018 at 12:59 AM Kangjie Lu wrote:
>
> When mxl111sf_read_reg fails, we shouldn't use "mode". The fix checks
> its return value using mxl_fail
>
> Signed-off-by: Kangjie Lu
> ---
> drivers/media/usb/dvb-usb-v2/mxl111sf-phy.c | 3 ++-
> 1 file changed, 2 insertions(+),
e removed -- this is not a bug
anymore and the sanity check is built-in. That FIXME comment is a
remnant of an older version of this function :-P
If you want to send a patch that just removes the FIXME comment, that
would be accepted, but this patch should not be merged.
Cheers,
Michael Ira Krufky
--
To un
120 121922fa0
>> > > drivers/media/dvb-frontends/dvb-pll.o.new
>> > >5624 63632120 14107371b
>> > > drivers/media/dvb-frontends/dvb-pll.o.old
>> >
>> > Peter,
>> >
>> > Please add this patch on the next p
On Thu, Jul 30, 2015 at 7:14 AM, Michael Ira Krufky wrote:
> On Thu, Jul 30, 2015 at 6:08 AM, Joe Perches wrote:
>> On Thu, 2015-07-30 at 10:47 +0100, Peter Griffin wrote:
>>> Hi Mauro / Joe,
>>>
>>> On Wed, 22 Jul 2015, Mauro Carvalho Chehab wrote:
>>
On Thu, Jul 30, 2015 at 7:14 AM, Michael Ira Krufky wrote:
> On Thu, Jul 30, 2015 at 6:08 AM, Joe Perches wrote:
>> On Thu, 2015-07-30 at 10:47 +0100, Peter Griffin wrote:
>>> Hi Mauro / Joe,
>>>
>>> On Wed, 22 Jul 2015, Mauro Carvalho Chehab wrote:
>>
atch. Mauro, please apply it.
Reviewed-by: Michael Ira Krufky
> ---
> drivers/media/usb/dvb-usb-v2/mxl111sf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/mxl111sf.c
> b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
&
Thanks for this!
Reviewed-by: Michael Ira Krufky
On Fri, Nov 13, 2015 at 7:24 AM, Julia Lawall wrote:
> The mxl111sf_demod_config structure is never modified, so declare it
> as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall
>
> ---
>
Julia Lawall
Thank you for this, Julia
Reviewed-by: Michael Ira Krufky
>
> ---
> drivers/media/usb/dvb-usb-v2/mxl111sf-tuner.c |6 +++---
> drivers/media/usb/dvb-usb-v2/mxl111sf-tuner.h |8
> drivers/media/usb/dvb-usb-v2/mxl111sf.c |2 +-
> 3 files changed
of this function :-P
If you want to send a patch that just removes the FIXME comment, that
would be accepted, but this patch should not be merged.
Cheers,
Michael Ira Krufky
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
h:
> @r depends on (org || report)@
> type T;
> T[] E;
> position p;
> @@
> (
> (sizeof(E)@p /sizeof(*E))
> |
> (sizeof(E)@p /sizeof(E[...]))
> |
> (sizeof(E)@p /sizeof(T))
> )
>
> Signed-off-by: Jérémy Lefaure
Reviewed-by: Michael Ira Krufky
rivers/media/usb/dvb-usb-v2/mxl111sf-i2c.c:519:3: warning: Value
> stored to 'index' is never read
>
> Signed-off-by: Colin Ian King
Reviewed-by: Michael Ira Krufky
Thanks for the patch!
> ---
> drivers/media/usb/dvb-usb-v2/mxl111sf-i2c.c | 1 -
> 1 file changed, 1 deletion
them.
>
> Signed-off-by: Arnd Bergmann
Thank you, Arnd.
Reviewed-by: Michael Ira Krufky
> ---
> drivers/media/tuners/tda8290.c | 76
> ++
> 1 file changed, 39 insertions(+), 37 deletions(-)
>
> diff --git a/drivers/media/tun
My bad -- a lot of the code I
wrote many years ago has this problem -- I wasn't so stack-conscious
back then.
The bytes in `enable` / `disable` don't get changed, but they may be
copied to another byte array that does get changed. If would be best
to make these `static const`
Best regards,
Michael Ira Krufky
26 matches
Mail list logo
