Re: [PATCH] md: Convert timers to use timer_setup()

ecific one to apply to my tree. Reviewed-by: Michael Lyle > [snip]

Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

On Fri, Oct 27, 2017 at 12:05 PM, Eric Wheeler wrote: > Should this Cc: stable to avoid the register race (possible > crash?) described by Liang in other stable kernels? > > Reviewed-by: Eric Wheeler This seems like an unlikely failure; basically you must have built bcache for debug (which not m

Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

ained anomalies to send these to Jens for 4.15. Mike > > On Tue, Oct 10, 2017 at 11:44 PM, Michael Lyle wrote: >> On 10/10/2017 05:25 AM, Coly Li wrote: >>> On 2017/10/10 下午5:00, Liang Chen wrote: >>>> mutex_destroy does nothing most of time, but it's better

Re: [PATCH 4.14 095/140] bcache: fix crashes in duplicate cache device register

0 <8 >> b> b0 14 03 00 00 e9 73 ff ff ff 0f 1f 44 00 00 48 8b 47 40 39 >> [ 417.644302] RIP: bdevname+0x13/0x1e RSP: a3aa9138fd38 >> [ 417.644306] CR2: 0314 >> >> When registering duplicate cache device in register_cache(), after failure >>

Re: [PATCH] bcache: mark expected switch fall-throughs in STRTO_H

Reviewed-by: Michael Lyle Looks good to me. Thanks, Mike

Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

is ready to avoid that issue. >> >> Signed-off-by: Liang Chen > > Hi Liang, > > No more comment from me, it looks good. Thanks. > > Reviewed-by: Coly Li Looks good to me too. Reviewed-by: Michael Lyle

Re: [PATCH] bcache: safeguard a dangerous addressing in closure_queue

On 10/12/2017 07:37 AM, Liang Chen wrote: > The use of the union reduces the size of closure struct by taking advantage > of the current size of its members. The offset of func in work_struct equals > the size of the first three members, so that work.work_func will just > reference the forth member

Re: [PATCH v2] bcache: safeguard a dangerous addressing in closure_queue

t; the size of the first three members, so that work.work_func will just > reference the forth member - fn. > > This is smart but dangerous. It can be broken if work_struct or the other > structs get changed, and can be a bit difficult to debug. > > Signed-off-by: Liang Chen Reviewed-by: Michael Lyle -Mike

Re: [PATCH] bcache: Use PTR_ERR_OR_ZERO()

gt; Signed-off-by: Vasyl Gomonovych lgtm. Reviewed-by: Michael Lyle Will carry in my tree.

Re: [PATCH 1/4] bcache: convert cached_dev.count from atomic_t to refcount_t

ees Cook > Reviewed-by: David Windsor > Reviewed-by: Hans Liljestrand > Signed-off-by: Elena Reshetova Reviewed-by: Michael Lyle Thanks for this-- I'm including it in my tree for possible inclusion in 4.15 (I've already sent my main chunk of changes upwards). Mike