Re: [PATCH 1/2] ACPI, x86: export acpi_[un]register_gsi()

2012-10-30 Thread Mika Westerberg
On Mon, Oct 29, 2012 at 12:12:10PM +0100, Ingo Molnar wrote: * Mika Westerberg mika.westerb...@linux.intel.com wrote: From: Andy Shevchenko andriy.shevche...@linux.intel.com These functions might be called from modules as well so make sure they are exported. In addition we implement

Re: [PATCH 1/5] driver core / ACPI: Move ACPI support to core device and driver types

2012-10-31 Thread Mika Westerberg
On Wed, Oct 31, 2012 at 10:06:00PM +0100, Rafael J. Wysocki wrote: On Wednesday, October 31, 2012 08:33:53 PM Luck, Tony wrote: By tested I mean run with some new devices that use the ACPI enumeration provided here, on x86. Sorry for being too vague. Do you or Mika have access to

[PATCH 0/3] ACPI 5 support for GPIO, SPI and I2C

2012-11-03 Thread Mika Westerberg
branch assigns the ACPI handle to the master device. I2C slave devices can be enumerated by calling acpi_i2c_register_devices() in the adapter driver. Thanks, Mika Mathias Nyman (1): gpio / ACPI: add ACPI support Mika Westerberg (2): spi / ACPI: add ACPI enumeration support i2c / ACPI: add

[PATCH 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-03 Thread Mika Westerberg
() in order to get its slave devices enumerated, created and bound to the corresponding ACPI handle. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com --- drivers/acpi/Kconfig |6 ++ drivers/acpi/Makefile|1 + drivers/acpi

[PATCH 1/3] gpio / ACPI: add ACPI support

2012-11-03 Thread Mika Westerberg
-by: Mathias Nyman mathias.ny...@linux.intel.com Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com --- drivers/gpio/Kconfig|4 +++ drivers/gpio/Makefile |1 + drivers/gpio/gpiolib-acpi.c | 60

[PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-03 Thread Mika Westerberg
for further configuration. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com --- drivers/spi/spi.c | 231 - 1 file changed, 230 insertions(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-03 Thread Mika Westerberg
On Sat, Nov 03, 2012 at 01:42:02PM -0600, Bjorn Helgaas wrote: On Sat, Nov 3, 2012 at 1:46 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: ACPI 5 introduced SPISerialBus resource that allows us to enumerate and configure the SPI slave devices behind the SPI controller. This patch

Re: [PATCH 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-04 Thread Mika Westerberg
On Sat, Nov 03, 2012 at 10:52:46PM +0100, Jean Delvare wrote: On Sat, 3 Nov 2012 09:46:33 +0200, Mika Westerberg wrote: ACPI 5 introduced I2cSerialBus resource that makes it possible to enumerate and configure the I2C slave devices behind the I2C controller. This patch adds helper

Re: [PATCH 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-04 Thread Mika Westerberg
On Sun, Nov 04, 2012 at 09:50:31AM +0100, Jean Delvare wrote: On Sun, 4 Nov 2012 09:23:17 +0200, Mika Westerberg wrote: On Sat, Nov 03, 2012 at 10:52:46PM +0100, Jean Delvare wrote: On Sat, 3 Nov 2012 09:46:33 +0200, Mika Westerberg wrote: --- /dev/null +++ b/drivers/acpi/acpi_i2c.c

Re: [PATCH 0/3] ACPI 5 support for GPIO, SPI and I2C

2012-11-05 Thread Mika Westerberg
On Sun, Nov 04, 2012 at 07:29:10PM +0100, Linus Walleij wrote: On Sat, Nov 3, 2012 at 8:46 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: With ACPI 5 we can now describe how devices are connected to their bus using new resources: SPISerialBus and I2CSerialBus. Also it is now

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 11:31:19AM +0100, Rafael J. Wysocki wrote: The general idea is to move the _CRS parsing routine from acpi_platform.c to scan.c and make it attach resource objects to struct acpi_device. I'm thinking about adding a list head to struct acpi_device pointing to a list of

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 11:54:55AM +0100, Mark Brown wrote: On Sat, Nov 03, 2012 at 09:46:32AM +0200, Mika Westerberg wrote: + strlcpy(spi-modalias, acpi_device_hid(adev), sizeof(spi-modalias)); + if (info.gsi = 0) + spi-irq = acpi_register_gsi(adev-dev, info.gsi

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 11:56:39AM +0100, Mark Brown wrote: On Mon, Nov 05, 2012 at 12:56:02PM +0200, Mika Westerberg wrote: struct acpi_device { ... union acpi_resource_serial_bus *serial; ... }; It is also possible to have several serial bus connectors on a single

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 01:59:23PM +0100, Rafael J. Wysocki wrote: On Monday, November 05, 2012 01:23:50 PM Jean Delvare wrote: On Mon, 5 Nov 2012 14:02:19 +0200, Mika Westerberg wrote: On Mon, Nov 05, 2012 at 11:56:39AM +0100, Mark Brown wrote: I've got practical systems where

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 02:20:52PM +0100, Linus Walleij wrote: It looks like some PMICs for example have two I2C control interfaces, like TI's TWL6030 if I'm not mistaken. If both are put behind the same I2C controller with different address, you have the situation like above. This is

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 03:19:58PM +0100, Rafael J. Wysocki wrote: In the ACPI namespace we have device nodes and serial interfaces below them. In the above case we see that a single device node supports two different interfaces and in that case we probably should create two different struct

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 04:19:20PM +0100, Jean Delvare wrote: On Mon, 5 Nov 2012 16:53:15 +0200, Mika Westerberg wrote: On Mon, Nov 05, 2012 at 03:19:58PM +0100, Rafael J. Wysocki wrote: In the ACPI namespace we have device nodes and serial interfaces below them. In the above case

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-05 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 10:43:17AM -0700, Bjorn Helgaas wrote: It should already be unique in case of ACPI. We use ACPI _HID and _UID to achieve that. Using only _HID and _UID to guarantee uniqueness means you're relying on a property of the BIOS, so you're vulnerable to BIOS bugs. If

Re: [PATCH 1/3] gpio / ACPI: add ACPI support

2012-11-06 Thread Mika Westerberg
On Mon, Nov 05, 2012 at 03:40:14PM +0100, Linus Walleij wrote: I forgot to mention that we want to hook up _existing_ drivers to those things, and they already use the global GPIO numbers, don't they? Yes they do, usually this is either passed from the platform using platform data or

[PATCH] ACPI / platform: use ACPI device name instead of _HID._UID

2012-11-06 Thread Mika Westerberg
name instead of trusting that the BIOS sets the _UIDs correctly. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Cc: Bjorn Helgaas bhelg...@google.com --- This was suggested by Bjorn Helgaas in another thread. The patch applies on top of git://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH] gpiolib: iron out include ladder mistakes

2012-11-07 Thread Mika Westerberg
On Tue, Nov 06, 2012 at 05:21:03PM +0100, Linus Walleij wrote: +static inline int +gpiochip_add_pin_range(struct gpio_chip *chip, const char *pinctl_name, +unsigned int pin_base, unsigned int npins) +{ +} Should you return some value above? Like -ENOSYS? -- To unsubscribe

Re: [PATCH 1/3] gpio / ACPI: add ACPI support

2012-11-07 Thread Mika Westerberg
On Tue, Nov 06, 2012 at 11:15:21AM +0100, Linus Walleij wrote: On Tue, Nov 6, 2012 at 10:39 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Mon, Nov 05, 2012 at 03:40:14PM +0100, Linus Walleij wrote: I forgot to mention that we want to hook up _existing_ drivers to those

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-07 Thread Mika Westerberg
On Tue, Nov 06, 2012 at 11:18:11PM +0100, Rafael J. Wysocki wrote: How is the SPI controller different than this? Is there some logical difference that requires a different framework? Or are you proposing that we get rid of acpi_bus_register_driver() and migrate everything to this new

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-07 Thread Mika Westerberg
On Tue, Nov 06, 2012 at 11:36:08PM +0100, Rafael J. Wysocki wrote: OK, but then we need to pass the information obtained from _CRS (presumably after some adjustments through _SRS) to drivers, or rather to things like the SPI core, I2C core etc. so that they can create device objects for

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-07 Thread Mika Westerberg
On Wed, Nov 07, 2012 at 12:14:31PM +0100, Rafael J. Wysocki wrote: So is the idea now that the ACPI core parses the resources and passes them forward via struct acpi_device? I'm just wondering how to proceed with these I2C and SPI enumeration patches. Well, we definitely don't want to

Re: [PATCH 1/3] gpio / ACPI: add ACPI support

2012-11-08 Thread Mika Westerberg
On Thu, Nov 08, 2012 at 03:55:18PM +, Grant Likely wrote: Hi Mika, On Sat, Nov 3, 2012 at 7:46 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: From: Mathias Nyman mathias.ny...@linux.intel.com Add support for translating ACPI GPIO pin numbers to Linux GPIO API pins

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-08 Thread Mika Westerberg
On Thu, Nov 08, 2012 at 12:32:25PM -0700, Bjorn Helgaas wrote: Struct device_driver is a generic structure, so it seems strange to have to include non-generic things like of_device_id and now acpi_match_table there. Yes, but in a sense the DT and ACPI are generic. So that they are used to

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-08 Thread Mika Westerberg
On Thu, Nov 08, 2012 at 01:46:24AM +0100, Rafael J. Wysocki wrote: On Wednesday, November 07, 2012 03:05:48 PM Mika Westerberg wrote: On Wed, Nov 07, 2012 at 12:14:31PM +0100, Rafael J. Wysocki wrote: So is the idea now that the ACPI core parses the resources and passes them

Re: [PATCH 1/4] dmaengine: dw_dmac: use helper macro module_platform_driver()

2012-10-10 Thread Mika Westerberg
On Wed, Oct 10, 2012 at 04:42:00PM +0300, Felipe Balbi wrote: Hi, On Wed, Oct 10, 2012 at 03:52:40PM +0300, Andy Shevchenko wrote: On Wed, Oct 10, 2012 at 3:40 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Oct 10, 2012 at 12:21:04PM +0300, Andy Shevchenko wrote: On Wed, Oct 10, 2012 at

[PATCH 2/2] ACPI, ia64: export acpi_[un]register_gsi()

2012-10-29 Thread Mika Westerberg
These functions might be called from modules as well so make sure they are exported. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- arch/ia64/kernel/acpi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/ia64/kernel/acpi.c b/arch/ia64/kernel/acpi.c index 44057885

[PATCH 1/2] ACPI, x86: export acpi_[un]register_gsi()

2012-10-29 Thread Mika Westerberg
...@linux.intel.com Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- Although there are no modules that use this currently, we are working on ACPI 5 device enumeration support that is going to use these functions and some of that code can be compiled as a module. arch/x86/kernel/acpi/boot.c

Re: [PATCH 2/3] spi / ACPI: add ACPI enumeration support

2012-11-08 Thread Mika Westerberg
On Thu, Nov 08, 2012 at 06:48:05PM +, Grant Likely wrote: On Sat, Nov 3, 2012 at 7:46 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: ACPI 5 introduced SPISerialBus resource that allows us to enumerate and configure the SPI slave devices behind the SPI controller. This patch

Re: [PATCH 3/3] i2c / ACPI: add ACPI enumeration support

2012-11-08 Thread Mika Westerberg
On Thu, Nov 08, 2012 at 06:58:47PM +, Grant Likely wrote: On Sat, Nov 3, 2012 at 7:46 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: ACPI 5 introduced I2cSerialBus resource that makes it possible to enumerate and configure the I2C slave devices behind the I2C controller

Re: [PATCH 1/3] gpio / ACPI: add ACPI support

2012-11-11 Thread Mika Westerberg
On Fri, Nov 09, 2012 at 03:46:58PM +, Grant Likely wrote: I guess It's possible to write a driver like that. The only acpi enumerated driver with the acpi_handle set (soon coming to upstream) is not done like that. Do you think this is a case that should be solved now? or just

Re: [PATCH 1/3] ACPI: Move device resources interpretation code from PNP to ACPI core

2012-11-12 Thread Mika Westerberg
On Mon, Nov 12, 2012 at 01:00:26PM +0100, Rafael J. Wysocki wrote: +/** + * acpi_dev_irq_flags - Determine IRQ resource flags. + * @triggering: Triggering type as provided by ACPI. + * @polarity: Interrupt polarity as provided by ACPI. + * @shareable: Whether or not the interrupt is

Re: [PATCH 3/3] ACPI: Evaluate _CRS while creating device node objects

2012-11-12 Thread Mika Westerberg
On Mon, Nov 12, 2012 at 01:02:11PM +0100, Rafael J. Wysocki wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com Currently, whoever wants to use ACPI device resources has to call acpi_walk_resources() to browse the buffer returned by the _CRS method for the given device and create

Re: [PATCH 3/3] ACPI: Evaluate _CRS while creating device node objects

2012-11-12 Thread Mika Westerberg
On Mon, Nov 12, 2012 at 10:03:56PM +0100, Rafael J. Wysocki wrote: +static acpi_status acpi_bus_add_resource(struct acpi_resource *res, + void *context) +{ + struct list_head *list = context; + struct acpi_resource_list_entry *entry; + + entry

Re: [Replacement][PATCH 3/3]

2012-11-13 Thread Mika Westerberg
On Tue, Nov 13, 2012 at 01:06:59PM +0100, Rafael J. Wysocki wrote: I don't know any better option. Well, a better option would be to convince ACPICA to provide us different interfaces. :-) Heh, indeed. We might actually try to do that in the future, but for now we still need _CRS to be

Re: [Replacement][PATCH 3/3]

2012-11-13 Thread Mika Westerberg
On Tue, Nov 13, 2012 at 04:15:51PM +0100, Rafael J. Wysocki wrote: Could we change this so that you can pass NULL list as well (provided that the preproc is given)? This is useful in case when we try to find the SPI/I2C device handle based on the ACPI serial bus resource address. In

Re: [Replacement][PATCH 3/3]

2012-11-13 Thread Mika Westerberg
On Tue, Nov 13, 2012 at 04:28:50PM +0100, Rafael J. Wysocki wrote: On Tuesday, November 13, 2012 05:18:13 PM Mika Westerberg wrote: On Tue, Nov 13, 2012 at 04:15:51PM +0100, Rafael J. Wysocki wrote: Could we change this so that you can pass NULL list as well (provided

Re: [PATCH 0/3 rev 2] Centralized parsing of ACPI device resources

2012-11-14 Thread Mika Westerberg
realize before. I've now tested this series on my ACPI 5 enabled test machine and everything works fine - I can see the platform devices and that they have the ACPI handle attached. For the whole series, Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com Tested-by: Mika Westerberg

Re: [PATCH 6/7] gpio/langwell: find the irq domain mapping

2012-10-17 Thread Mika Westerberg
On Tue, Oct 16, 2012 at 09:23:23PM +0200, Linus Walleij wrote: Switch from creating the IRQ domain mapping to finding it. In this case we know very well that the driver has created the apropriate mapping, we just need to locate it, no need to create any on-the-fly mappings. I may be missing

Re: [PATCH 00/12] ACPI: add module_acpi_driver() and convert drivers to it

2012-07-13 Thread Mika Westerberg
On Thu, Jun 28, 2012 at 01:59:19PM +0300, Mika Westerberg wrote: This is similar than what is done for other busses before (PCI, I2C, SPI, platform). It reduces a lot of unnecessary boilerplate code from modules. We also remove following redundant check on few drivers

Re: [PATCH] i2c-designware: fix RX FIFO overrun

2013-04-22 Thread Mika Westerberg
On Fri, Apr 19, 2013 at 07:05:30PM +0100, Josef Ahmad wrote: From a969728248c3b439dc97a69e7dac133b5efa34e7 Mon Sep 17 00:00:00 2001 From: Josef Ahmad josef.ah...@linux.intel.com Date: Fri, 19 Apr 2013 17:28:10 +0100 Subject: [PATCH] i2c-designware: fix RX FIFO overrun i2c_dw_xfer_msg()

Re: GPS driver for Linux - kernel or user-space driver?

2013-04-04 Thread Mika Westerberg
(Adding Lv, he has been working on this). On Wed, Apr 03, 2013 at 06:44:51PM -0700, Marcel Holtmann wrote: Hi Greg, I've been approached by a developer at Sony who wants to publish an open source driver for a Sony GPS receiver module. What does the device look like? USB device?

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Mika Westerberg
On Thu, Apr 04, 2013 at 11:19:53AM +0200, Benjamin Tissoires wrote: Hi Mika, On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: Instead of open-coding ACPI GPIO resource lookup in each driver, we provide a helper function analogous to Device Tree

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Mika Westerberg
On Thu, Apr 04, 2013 at 11:42:11AM +0200, Benjamin Tissoires wrote: On Thu, Apr 4, 2013 at 11:38 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Thu, Apr 04, 2013 at 11:19:53AM +0200, Benjamin Tissoires wrote: Hi Mika, On Wed, Apr 3, 2013 at 12:56 PM, Mika Westerberg

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-04 Thread Mika Westerberg
On Thu, Apr 04, 2013 at 12:01:23PM +0200, Benjamin Tissoires wrote: One option is to provide acpi_get_gpio_all() that returns all GPIOs and their corresponding types. That should allow clients like i2c-hid to find the right GPIO (I'm hoping that there will be only one GpioInt associated

Re: [PATCH 1/7] i2c-designware: move to managed functions (devm_*)

2013-04-08 Thread Mika Westerberg
Hi Wolfram, Any comments on this series? Could you consider merging these for 3.10? Thanks. On Thu, Mar 21, 2013 at 02:09:54PM +0200, Mika Westerberg wrote: From: Andy Shevchenko andriy.shevche...@linux.intel.com This makes the error handling much more simpler than open-coding everything

Re: [1/7] i2c-designware: move to managed functions (devm_*)

2013-04-09 Thread Mika Westerberg
On Tue, Apr 09, 2013 at 11:00:32AM +0200, Wolfram Sang wrote: @@ -108,32 +108,27 @@ static int dw_i2c_probe(struct platform_device *pdev) return irq; /* -ENXIO */ } - ioarea = request_mem_region(mem-start, resource_size(mem), - pdev-name); -

Re: [4/7] i2c-designware: use dynamic adapter numbering on Lynxpoint

2013-04-09 Thread Mika Westerberg
On Tue, Apr 09, 2013 at 11:06:05AM +0200, Wolfram Sang wrote: On Thu, Mar 21, 2013 at 02:09:57AM -, Mika Westerberg wrote: It is not good idea to mix static and dynamic I2C adapter numbering. In this particular case on Lynxpoint we had graphics I2C adapter which took the first numbers

Re: [5/7] i2c-designware: enable/disable the controller properly

2013-04-09 Thread Mika Westerberg
On Tue, Apr 09, 2013 at 11:09:14AM +0200, Wolfram Sang wrote: +static void __i2c_dw_enable(struct dw_i2c_dev *dev, bool enable) +{ + int timeout = 100; + + do { + dw_writel(dev, enable, DW_IC_ENABLE); + if ((dw_readl(dev, DW_IC_ENABLE_STATUS) 1) == enable)

Re: [4/7] i2c-designware: use dynamic adapter numbering on Lynxpoint

2013-04-09 Thread Mika Westerberg
On Tue, Apr 09, 2013 at 11:29:24AM +0200, Wolfram Sang wrote: On Tue, Apr 09, 2013 at 12:23:19PM +0300, Mika Westerberg wrote: On Tue, Apr 09, 2013 at 11:06:05AM +0200, Wolfram Sang wrote: On Thu, Mar 21, 2013 at 02:09:57AM -, Mika Westerberg wrote: It is not good idea to mix static

Re: [5/7] i2c-designware: enable/disable the controller properly

2013-04-09 Thread Mika Westerberg
On Tue, Apr 09, 2013 at 11:28:57AM +0200, Wolfram Sang wrote: On Tue, Apr 09, 2013 at 12:28:36PM +0300, Mika Westerberg wrote: On Tue, Apr 09, 2013 at 11:09:14AM +0200, Wolfram Sang wrote: +static void __i2c_dw_enable(struct dw_i2c_dev *dev, bool enable) +{ + int timeout

Re: [PATCH] gpio / ACPI: Handle ACPI events in accordance with the spec

2013-04-10 Thread Mika Westerberg
On Tue, Apr 09, 2013 at 03:57:25PM +0200, Rafael J. Wysocki wrote: +void acpi_gpiochip_free_interrupts(struct gpio_chip *chip) +{ + acpi_handle handle; + acpi_status status; + struct list_head *evt_pins; + struct acpi_gpio_evt_pin *evt_pin, *ep; + + if (!chip-dev ||

Re: [PATCH] gpio / ACPI: Handle ACPI events in accordance with the spec

2013-04-10 Thread Mika Westerberg
On Wed, Apr 10, 2013 at 11:17:57AM +0300, Mathias Nyman wrote: On 04/10/2013 10:53 AM, Mika Westerberg wrote: On Tue, Apr 09, 2013 at 03:57:25PM +0200, Rafael J. Wysocki wrote: +void acpi_gpiochip_free_interrupts(struct gpio_chip *chip) +{ + acpi_handle handle; + acpi_status status

[PATCH v2 6/7] i2c-designware: use usleep_range() in the busy-loop

2013-04-10 Thread Mika Westerberg
This is not an atomic context so there is no need to use mdelay() but instead use usleep_range(). Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/i2c/busses/i2c-designware-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses

[PATCH v2 7/7] i2c-designware: switch to use runtime PM autosuspend

2013-04-10 Thread Mika Westerberg
Using autosuspend helps to reduce the resume latency in situations where another I2C message is going to be started soon. For example with HID over I2C touch panels we get several messages in a short period of time while the touch panel is in use. Signed-off-by: Mika Westerberg mika.westerb

[PATCH v2 4/7] i2c-designware: use dynamic adapter numbering on Lynxpoint

2013-04-10 Thread Mika Westerberg
and there is no hardware available outside Intel we can fix this by switching to use dynamic adapter numbering instead of static. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- Changes to v1: - Updated commit message to mention that this change should not cause

[PATCH v2 3/7] i2c-designware-pci: use managed functions pcim_* and devm_*

2013-04-10 Thread Mika Westerberg
From: Andy Shevchenko andriy.shevche...@linux.intel.com This makes the error handling much more simpler than open-coding everything and in addition makes the probe function smaller an tidier. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Signed-off-by: Mika Westerberg

[PATCH v2 2/7] i2c-designware-pci: use dev_err() instead of printk()

2013-04-10 Thread Mika Westerberg
...@linux.intel.com Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/i2c/busses/i2c-designware-pcidrv.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c index

[PATCH v2 5/7] i2c-designware: enable/disable the controller properly

2013-04-10 Thread Mika Westerberg
the function returns. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- Changes to v1: - Added comment about why we sleep 25us after each iteration. - } while (timeout--); instead of } while (timeout-- 0); drivers/i2c/busses/i2c-designware-core.c | 34

[PATCH v2 1/7] i2c-designware: move to managed functions (devm_*)

2013-04-10 Thread Mika Westerberg
From: Andy Shevchenko andriy.shevche...@linux.intel.com This makes the error handling much more simpler than open-coding everything and in addition makes the probe function smaller and tidier. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Signed-off-by: Mika Westerberg

Re: [PATCH] gpio / ACPI: Handle ACPI events in accordance with the spec

2013-04-10 Thread Mika Westerberg
On Wed, Apr 10, 2013 at 12:39:21PM +0200, Rafael J. Wysocki wrote: On Wednesday, April 10, 2013 12:17:47 PM Mika Westerberg wrote: On Wed, Apr 10, 2013 at 11:17:57AM +0300, Mathias Nyman wrote: On 04/10/2013 10:53 AM, Mika Westerberg wrote: On Tue, Apr 09, 2013 at 03:57:25PM +0200, Rafael

Re: [PATCH v2 7/7] i2c-designware: switch to use runtime PM autosuspend

2013-04-10 Thread Mika Westerberg
On Wed, Apr 10, 2013 at 05:13:57PM +0530, Shubhrajyoti Datta wrote: Hi Mika, On Wed, Apr 10, 2013 at 4:06 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: Using autosuspend helps to reduce the resume latency in situations where another I2C message is going to be started

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-11 Thread Mika Westerberg
On Wed, Apr 03, 2013 at 01:04:26PM +0200, Rafael J. Wysocki wrote: On Wednesday, April 03, 2013 01:56:54 PM Mika Westerberg wrote: Instead of open-coding ACPI GPIO resource lookup in each driver, we provide a helper function analogous to Device Tree version that allows drivers to specify

Re: [PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-12 Thread Mika Westerberg
On Fri, Apr 12, 2013 at 12:35:05AM +0200, Linus Walleij wrote: On Thu, Apr 11, 2013 at 9:29 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: Grant and Linus W, Do you have any comments on this patch? Could it still be merged for 3.10? No and yes. Applied and pushed

Re: [PATCH 1/6] dma: acpi-dma: introduce ACPI DMA helpers

2013-03-30 Thread Mika Westerberg
On Sat, Mar 30, 2013 at 02:05:43AM +0530, Vinod Koul wrote: On Wed, Mar 27, 2013 at 10:57:57AM +0200, Andy Shevchenko wrote: + * @dev: struct device to get DMA request from + * @index: index of FixedDMA descriptor for @dev + * + * Returns pointer to appropriate dma channel on success or

Re: [PATCH 3/6] dma: acpi-dma: parse CSRT to extract additional resources

2013-03-30 Thread Mika Westerberg
-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com for such a patch git format-patch -M is your friend. It generates patch to show file movement. It helps review

Re: [PATCH] ACPI / SPI: Use parent's ACPI_HANDLE() in acpi_register_spi_devices()

2013-04-01 Thread Mika Westerberg
(which should be NULL). Make that happen and modify the spi-pxa2xx driver, which currently is the only driver for ACPI-enumerated SPI controller chips, not to set the ACPI handle for the struct spi_master it creates. Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com Acked-by: Mika

Re: [PATCH] ACPI / I2C: Use parent's ACPI_HANDLE() in acpi_i2c_register_devices()

2013-04-01 Thread Mika Westerberg
...@intel.com Acked-by: Mika Westerberg mika.westerb...@linux.intel.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

[PATCH] gpiolib-acpi: introduce acpi_get_gpio_by_index() helper

2013-04-03 Thread Mika Westerberg
the ACPI GPIO number to the corresponding Linux GPIO number and returns that. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- Documentation/acpi/enumeration.txt | 32 ++- drivers/gpio/gpiolib-acpi.c| 77 include/linux

[PATCH 3/7] i2c-designware-pci: use managed functions pcim_* and devm_*

2013-03-21 Thread Mika Westerberg
From: Andy Shevchenko andriy.shevche...@linux.intel.com This makes the error handling much more simpler than open-coding everything and in addition makes the probe function smaller an tidier. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Signed-off-by: Mika Westerberg

[PATCH 7/7] i2c-designware: switch to use runtime PM autosuspend

2013-03-21 Thread Mika Westerberg
Using autosuspend helps to reduce the resume latency in situations where another I2C message is going to be started soon. For example with HID over I2C touch panels we get several messages in a short period of time while the touch panel is in use. Signed-off-by: Mika Westerberg mika.westerb

[PATCH 2/7] i2c-designware-pci: use dev_err() instead of printk()

2013-03-21 Thread Mika Westerberg
...@linux.intel.com Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/i2c/busses/i2c-designware-pcidrv.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c index 7c5e383

[PATCH 4/7] i2c-designware: use dynamic adapter numbering on Lynxpoint

2013-03-21 Thread Mika Westerberg
numbering on Intel Lynxpoint. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/i2c/busses/i2c-designware-platdrv.c |9 - 1 file changed, 9 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index

[PATCH 5/7] i2c-designware: enable/disable the controller properly

2013-03-21 Thread Mika Westerberg
the function returns. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/i2c/busses/i2c-designware-core.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c

[PATCH 6/7] i2c-designware: use usleep_range() in the busy-loop

2013-03-21 Thread Mika Westerberg
This is not an atomic context so there is no need to use mdelay() but instead use usleep_range(). Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/i2c/busses/i2c-designware-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses

[PATCH 1/7] i2c-designware: move to managed functions (devm_*)

2013-03-21 Thread Mika Westerberg
From: Andy Shevchenko andriy.shevche...@linux.intel.com This makes the error handling much more simpler than open-coding everything and in addition makes the probe function smaller and tidier. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Signed-off-by: Mika Westerberg

Re: clk: x86: build failure

2013-03-24 Thread Mika Westerberg
On Sat, Mar 23, 2013 at 01:57:01PM -0400, Corey Richardson wrote: With the attached config, I get the following build failure: LD init/built-in.o drivers/built-in.o:clk-lpt.c:function v4l2_device_unregister: error: undefined reference to 'i2c_unregister_device' I get following with

Re: [PATCH] gpio-lynxpoint: Add X86 dependency and io-port handling header.

2013-03-08 Thread Mika Westerberg
On Fri, Mar 08, 2013 at 02:38:12PM +0200, Mathias Nyman wrote: Lynxpoint gpio driver uses X86 specific io-ports to control gpios Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com -- To unsubscribe from this list: send

[PATCH 1/2] spi/pxa2xx-pci: correct the return value check of pcim_iomap_regions()

2013-03-05 Thread Mika Westerberg
The function returns 0 on success and negative errno in case of failure. Fix this. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/spi/spi-pxa2xx-pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-pxa2xx-pci.c b/drivers/spi/spi

[PATCH 2/2] spi/pxa2xx: enable multiblock DMA transfers for LPSS devices

2013-03-05 Thread Mika Westerberg
Intel LPSS SPI controllers need to have bit 0 (disable_ssp_dma_finish) set in SSP_REG in order to properly perform DMA transfers spanning over multiple blocks. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/spi/spi-pxa2xx.c |5 + 1 file changed, 5 insertions

Re: [PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect

2013-03-06 Thread Mika Westerberg
On Thu, Mar 07, 2013 at 04:23:56AM +0100, Linus Walleij wrote: Hi Mika, On Wed, Feb 27, 2013 at 4:25 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: -static int ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr) +static bool ichx_gpio_check_available(struct

[PATCH] gpio/gpio-ich: make ichx_gpio_check_available() return a pure boolean value

2013-03-07 Thread Mika Westerberg
It is more readable for humans to use double-bang (!!) to convert the value to pure boolean before it is returned. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/gpio/gpio-ich.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio

Re: [PATCH] ACPI / PM: Fix header of acpi_dev_pm_detach() in acpi.h

2012-12-05 Thread Mika Westerberg
...@intel.com Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com --- include/linux/acpi.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/include/linux/acpi.h === --- linux.orig/include/linux

Re: [PATCH v3 00/10] spi/pxa2xx: add Intel Lynxpoint SPI controller support

2013-02-07 Thread Mika Westerberg
Hi Mark/Grant, On Mon, Feb 04, 2013 at 05:45:49PM +0800, Mark Brown wrote: On Fri, Feb 01, 2013 at 12:22:47PM +0200, Mika Westerberg wrote: Mark, thank you for applying patches 1-4/10. Is there anything you want me to do for the rest of the patches in order to get those merged? I

[PATCH] Documentation / acpi: refer to correct file for acpi_platform_device_ids[] table

2013-02-08 Thread Mika Westerberg
When the ACPI platform device code was converted to the new ACPI scan handler facility, the the acpi_platform_device_ids[] was moved to drivers/acpi/acpi_platform.c. Update the documentation accordingly. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- Documentation/acpi

Re: [PATCH v3 00/10] spi/pxa2xx: add Intel Lynxpoint SPI controller support

2013-02-08 Thread Mika Westerberg
On Fri, Feb 08, 2013 at 10:37:15PM +0100, Linus Walleij wrote: On Mon, Feb 4, 2013 at 10:52 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Mon, Feb 04, 2013 at 05:45:49PM +0800, Mark Brown wrote: On Fri, Feb 01, 2013 at 12:22:47PM +0200, Mika Westerberg wrote: Mark, thank

Re: [PATCH] Documentation / acpi: refer to correct file for acpi_platform_device_ids[] table

2013-02-08 Thread Mika Westerberg
On Sat, Feb 09, 2013 at 12:14:27AM +0100, Rafael J. Wysocki wrote: On Friday, February 08, 2013 04:07:01 PM Mika Westerberg wrote: When the ACPI platform device code was converted to the new ACPI scan handler facility, the the acpi_platform_device_ids[] was moved to drivers/acpi

Re: [PATCH 0/7] hid driver transport cleanup

2013-02-11 Thread Mika Westerberg
that there is a dependency to usbhid in many of the drivers, especially in sensor-hub which caused the system crash while the driver tried to transmit over USB even though it was behind I2C. Your series fixes that nicely :) You can add, Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com

[PATCH 3/3] HID: sensor-hub: don't limit the driver only to USB bus

2013-02-11 Thread Mika Westerberg
We now have two transport mediums: USB and I2C, where sensor hubs can exists. So instead of constraining the driver to only these two we let it to match any HID bus as long as the group is HID_GROUP_SENSOR_HUB. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/hid/hid

[PATCH 1/3] HID: extend autodetect to handle I2C sensors as well

2013-02-11 Thread Mika Westerberg
Since the advent of HID over I2C protocol, it is possible to have sensor hubs behind I2C bus as well. We can autodetect this in a same way than USB sensor hubs. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/hid/hid-core.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH 2/3] HID: sensor-hub: get rid of unused sensor_hub_grabbed_usages[] table

2013-02-11 Thread Mika Westerberg
This table is not used anywhere in the driver so kill it. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/hid/hid-sensor-hub.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c index c06e933..2643bce9

Re: [PATCH 0/7] hid driver transport cleanup

2013-02-11 Thread Mika Westerberg
On Mon, Feb 11, 2013 at 12:19:13PM +0100, Benjamin Tissoires wrote: On Mon, Feb 11, 2013 at 11:13 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: On Fri, Feb 08, 2013 at 03:37:29PM +0100, Benjamin Tissoires wrote: so, here is the hid drivers cleanup. The aim is to remove as much

Re: [PATCH 3/3] HID: sensor-hub: don't limit the driver only to USB bus

2013-02-12 Thread Mika Westerberg
On Mon, Feb 11, 2013 at 03:54:05PM +, Pandruvada, Srinivas wrote: So finally we can use HID sensor hub over I2C. Did you try with any I2C sensor hub? Yes, we have I2C HID sensor hub here and I tested with it. However, I'm not that familiar how it should be used except that I can see the

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-02-12 Thread Mika Westerberg
On Tue, Feb 12, 2013 at 07:53:34AM -0800, Vinod Koul wrote: On Tue, Jan 29, 2013 at 10:29:43AM +0530, Viresh Kumar wrote: Next time, please direct these mails to my Linaro id :) On Mon, Jan 28, 2013 at 4:34 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On some hardware

Re: [PATCH] dw_dmac: adjust slave_id accordingly to request line base

2013-02-12 Thread Mika Westerberg
On Tue, Feb 12, 2013 at 09:34:35AM -0800, Vinod Koul wrote: On Tue, Feb 12, 2013 at 06:43:51PM +0200, Mika Westerberg wrote: On Tue, Feb 12, 2013 at 07:53:34AM -0800, Vinod Koul wrote: On Tue, Jan 29, 2013 at 10:29:43AM +0530, Viresh Kumar wrote: Next time, please direct these mails

Re: [PATCH v3 00/10] spi/pxa2xx: add Intel Lynxpoint SPI controller support

2013-02-04 Thread Mika Westerberg
On Mon, Feb 04, 2013 at 05:45:49PM +0800, Mark Brown wrote: On Fri, Feb 01, 2013 at 12:22:47PM +0200, Mika Westerberg wrote: Mark, thank you for applying patches 1-4/10. Is there anything you want me to do for the rest of the patches in order to get those merged? I stopped at patch 4

Re: [PATCH v3 05/10] spi/pxa2xx: break out the private DMA API usage into a separate file

2013-02-04 Thread Mika Westerberg
On Mon, Feb 04, 2013 at 08:43:42PM +0100, Linus Walleij wrote: On Tue, Jan 22, 2013 at 11:26 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: The PXA SPI driver uses PXA platform specific private DMA implementation which does not work on non-PXA platforms. In order to use

  1   2   3   4   5   6   7   8   9   10   >