submit bio directly from userspace

2015-10-07 Thread Mike Krinkin
Hi, i'm developing block layer workload simulator/player and need to generate bios as close as possible to the ones in original workload. To play workload i employ aio + O_DIRECT, but all IOs end up as bios with SYNC flag set. So i wonder is there any way to control bios flags from userspace or, m

Use after free bug in null_blk driver

2015-07-18 Thread Mike Krinkin
Hi, i noticed that loading null_blk with queue_mode=1 and irqmode=2 parameters and slab poisoning enabled causes general protection fault: [ 20.671974] general protection fault: [#1] SMP [ 20.678050] Modules linked in: null_blk(+) usbhid hid psmouse floppy [ 20.688351] CPU: 0 PID: 147

Re: Use after free bug in null_blk driver

2015-07-18 Thread Mike Krinkin
On Sun, Jul 19, 2015 at 01:18:44AM +0900, Akinobu Mita wrote: > 2015-07-18 23:51 GMT+09:00 Mike Krinkin : > > Hi, > > > > i noticed that loading null_blk with queue_mode=1 and irqmode=2 parameters > > and slab poisoning enabled causes general protection fault: >

Re: [PATCH] block: add calls to split trace point

2015-12-02 Thread Mike Krinkin
Hi Jens, i would like to check status of the patch, will the patch be applied? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH] block: add calls to split trace point

2015-12-02 Thread Mike Krinkin
On Wed, Dec 02, 2015 at 10:06:09AM -0700, Jens Axboe wrote: > On 12/02/2015 01:25 AM, Mike Krinkin wrote: > >Hi Jens, > > > >i would like to check status of the patch, will the patch be applied? > > > > Why aren't you just putting the split trace call into

[PATCH] block: add call to split trace point

2015-12-03 Thread Mike Krinkin
plit right after split. Signed-off-by: Mike Krinkin --- block/blk-merge.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/blk-merge.c b/block/blk-merge.c index de5716d8..3bb4537 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c @@ -7,6 +7,8 @@ #include #include +#include +

[PATCH] null_blk: fix use-after-free error

2015-12-15 Thread Mike Krinkin
ed. Fixes: cf8ecc5a8455266f8d51 ("null_blk: guarantee device restart in all irq modes") Signed-off-by: Mike Krinkin --- drivers/block/null_blk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c in

[PATCH] null_blk: fix use-after-free problem

2015-07-18 Thread Mike Krinkin
ng on completion handler") Tested-by: Akinobu Mita Signed-off-by: Mike Krinkin --- drivers/block/null_blk.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c index 69de41a..3177b24 100644 --- a/dri

Re: [PATCH 01/12] KVM: MMU: Fix ubsan warnings

2016-02-24 Thread Mike Krinkin
iteration, without checking the bounds on level. > > Reported-by: Sasha Levin > Reported-by: Mike Krinkin > Signed-off-by: Paolo Bonzini > --- > arch/x86/kvm/mmu.c | 57 > +++--- > 1 file changed, 33 insertions(+), 24 deletions

[PATCH] KVM: x86: MMU: fix ubsan index-out-of-range warning

2016-02-24 Thread Mike Krinkin
168.792777] [] entry_SYSCALL_64_fastpath+0x23/0xc1 [ 168.792780] Signed-off-by: Mike Krinkin --- arch/x86/kvm/paging_tmpl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/paging_tmp

[PATCH] staging: rtl8712: remove unnecessary else after return

2014-12-02 Thread Mike Krinkin
Fixes checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by: Mike Krinkin --- drivers/staging/rtl8712/rtl8712_recv.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging

[PATCH] staging: rtl8712: remove unnecessary else after return

2014-12-02 Thread Mike Krinkin
Fixes checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by: Mike Krinkin --- drivers/staging/rtl8712/rtl8712_recv.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging

[PATCH] staging: vt6655: fix sparse warnings: incorrect argument type

2014-12-21 Thread Mike Krinkin
type in argument 2 (different address spaces) drivers/staging/vt6655/device_main.c:1505:25:expected void [noderef] * drivers/staging/vt6655/device_main.c:1505:25:got struct vnt_private * Signed-off-by: Mike Krinkin --- drivers/staging/vt6655/device_main.c | 6 -- 1 file changed, 4

[PATCH] staging: rtl8188eu: use %*ph specifier instead of passing direct values

2015-03-08 Thread Mike Krinkin
The %*ph specifier allows to pass a pointer and length instead of pushing each byte via stack. The patch converts code to use it. Signed-off-by: Mike Krinkin --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging

Re: [PATCH] staging: rtl8188eu: use %*ph specifier instead of passing direct values

2015-03-08 Thread Mike Krinkin
On Sun, Mar 08, 2015 at 11:23:05AM -0500, Larry Finger wrote: > On 03/08/2015 10:54 AM, Mike Krinkin wrote: > >The %*ph specifier allows to pass a pointer and length instead of > >pushing each byte via stack. The patch converts code to use it. > > > >Signed-off-by: Mik

[PATCH v2] staging: rtl8188eu: use %pM specifier instead of passing direct values

2015-03-08 Thread Mike Krinkin
The patch converts code to use %pM specifier instead of pushing each byte via stack. Signed-off-by: Mike Krinkin --- Changes in v2: - use %pM instead %*ph as suggested by Larry Finger. drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions

[PATCH v3] staging: rtl8188eu: use %pM specifier instead of passing direct values

2015-03-08 Thread Mike Krinkin
The patch converts code to use %pM specifier instead of pushing each byte via stack. Signed-off-by: Mike Krinkin --- Changes v2 -> v3: - actual use of %pM instead %*ph as suggested by Larry Finger. drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++ 1 file changed, 2 insertions(+)

Re: [PATCH v2] staging: rtl8188eu: use %pM specifier instead of passing direct values

2015-03-08 Thread Mike Krinkin
On Sun, Mar 08, 2015 at 10:00:52AM -0700, Joe Perches wrote: > On Sun, 2015-03-08 at 19:42 +0300, Mike Krinkin wrote: > > The patch converts code to use %pM specifier instead of pushing > > each byte via stack. > > Hello Mike. > > > diff --git a/drivers/staging/rtl8

gpio-sx150x.c build error

2015-01-21 Thread Mike Krinkin
Hello, i failed to build linux-next for 20 Jan, because of the following build error: drivers/gpio/gpio-sx150x.c:487:17: error: ‘struct gpio_chip’ has no member named ‘of_node’ chip->gpio_chip.of_node = client->dev.of_node; ^ drivers/gpio/gpio-sx150x.c:488:17: error:

[PATCH] block: add calls to split trace point

2015-11-17 Thread Mike Krinkin
ght before bio_split. Signed-off-by: Mike Krinkin --- block/blk-merge.c | 5 + 1 file changed, 5 insertions(+) diff --git a/block/blk-merge.c b/block/blk-merge.c index de5716d8..832ec49 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c @@ -7,6 +7,8 @@ #include #include +#include +

Commit "locking/drm: Kill mutex trickery" causes hangs

2016-10-30 Thread Mike Krinkin
Hello, i faced system hangs with recent linux-next versions, bisect points at the commit 3ab7c086d5ec72585ef0 ("locking/drm: Kill mutex trickery"), bisect log attached. System just hangs after few minutes when i compile kernel with -j4 and watch some video simultaneously. Here is bisect log: # g

Re: Commit "locking/drm: Kill mutex trickery" causes hangs

2016-10-31 Thread Mike Krinkin
On Sun, Oct 30, 2016 at 05:09:41PM -0700, Hugh Dickins wrote: > On Mon, 31 Oct 2016, Mike Krinkin wrote: > > > > i faced system hangs with recent linux-next versions, bisect points at the > > commit 3ab7c086d5ec72585ef0 ("locking/drm: Kill mutex trickery"), bisec

[PATCH v3] rfkill: Add rfkill-any LED trigger

2017-01-02 Thread Mike Krinkin
On Wed, Dec 21, 2016 at 09:45:33AM +0100, Michał Kępień wrote: > Add a new "global" (i.e. not per-rfkill device) LED trigger, rfkill-any, > which may be useful on laptops with a single "radio LED" and multiple > radio transmitters. The trigger is meant to turn a LED on whenever > there is at least

Re: [PATCH -mm] ubsan, x86: disable alignemnt checks for arch/x86/*

2016-02-01 Thread Mike Krinkin
Works well for me, thank you. Tested-by: Mike Krinkin On Mon, Feb 01, 2016 at 08:08:19PM +0300, Andrey Ryabinin wrote: > On 01/30/2016 03:36 AM, Mike Krinkin wrote: > > option CONFIG_UBSAN_ALIGNMENT breaks x86-64 kernel with lockdep enabled, > > i. e kernel with CONFIG_UBSAN_ALI

CONFIG_UBSAN_ALIGNMENT breaks x86-64 kernel with lockdep enabled

2016-01-29 Thread Mike Krinkin
Hi, option CONFIG_UBSAN_ALIGNMENT breaks x86-64 kernel with lockdep enabled, i. e kernel with CONFIG_UBSAN_ALIGNMENT fails to load without even any error message. The problem is that ubsan callbacks use spinlocks and might be called before lockdep is initialized. Particularly this line in the res

[PATCH] block: fix use-after-free in dio_bio_complete

2016-01-30 Thread Mike Krinkin
183] == The problem is that bio_check_pages_dirty calls bio_put, so we must not access bio fields after bio_check_pages_dirty. Fixes: 9b81c842355ac96097ba ("block: don't access bio->bi_error after bio_put()"). Signed-off-by: Mike Krinkin --- fs/

Cannot load linux after recent efi-related changes

2016-09-17 Thread Mike Krinkin
Hello, after commit 3dad6f7f6975 ("x86/efi: Defer efi_esrt_init until after memblock_x86_fill") kernel hits BUG_ON __efi_enter_virtual_mode because efi.systab is NULL. With older kernel versions i face the problem with efi_mem_reserve described in the commit. AFAICS, get_systab_virt_addr called f

Re: Cannot load linux after recent efi-related changes

2016-09-17 Thread Mike Krinkin
On Sat, Sep 17, 2016 at 07:23:57PM +0300, Mike Krinkin wrote: > Hello, > > after commit 3dad6f7f6975 ("x86/efi: Defer efi_esrt_init until after > memblock_x86_fill") kernel hits BUG_ON __efi_enter_virtual_mode because > efi.systab is NULL. With older kernel version

Re: Cannot load linux after recent efi-related changes

2016-09-19 Thread Mike Krinkin
On Mon, Sep 19, 2016 at 12:14:24PM +0100, Matt Fleming wrote: > On Sun, 18 Sep, at 04:14:45AM, Mike Krinkin wrote: > > > > diff --git a/drivers/firmware/efi/memmap.c b/drivers/firmware/efi/memmap.c > > index cd96086..34322d1 100644 > > --- a/drivers/firmware/efi