> On Thu, Nov 22, 2012 at 01:51:10PM +0900, MyungJoo Ham wrote:
> > Please pull extcon patches for Linux 3.8.
>
> This is not a signed-tag pull request, which I thought I asked for
> previously.
>
> Please create that, so that I can properly know I am getting the right
&g
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
> On Tue, Nov 27, 2012 at 12:54:30AM +0000, MyungJoo Ham wrote:
> > > On Thu, Nov 22, 2012 at 01:51:10PM +0900, MyungJoo Ham wrote:
> > > > Please pull extcon patches for Linux 3.8.
> > >
> > > This is not
> Hi,
>
> > Sorry for being late.
> >
> > One concern is that I cannot apply Patch 1/4 directly as the .dts file isn't
> > available to me.
> > Do you intend to apply that patch to another tree and apply the other three
> > to devfreq tree?
> I have been merging the devfreq tree into Kgene's tree
On Tue, Jan 15, 2013 at 8:46 PM, Rajagopal Venkat
wrote:
> On 14 January 2013 20:18, MyungJoo Ham wrote:
>> On Tue, Jan 8, 2013 at 2:50 PM, Rajagopal Venkat
>> wrote:
>>> devfreq stats is not taking device suspend and resume into
>>> account. Fix it.
>&g
On Tue, Jan 15, 2013 at 8:21 PM, Rajagopal Venkat
wrote:
> On 14 January 2013 20:06, MyungJoo Ham wrote:
>> On Tue, Jan 8, 2013 at 2:50 PM, Rajagopal Venkat
>> wrote:
>>> Set devfreq device min and max frequency limits when device
>>> is added to devfreq, pro
- Added missing ABI documents
- Added comments to clarify the objectives of functions
Signed-off-by: MyungJoo Ham
---
Documentation/ABI/testing/sysfs-class-devfreq | 20
drivers/devfreq/devfreq.c | 10 ++
include/linux/devfreq.h
polling function
> * Moved exynos5 PPMU access functions to the devfreq driver
> Changes since v4:
> * Fixed compilation errors due to presence of devinit/devexit
> * Moved exynos ppmu header to the drivers/devfreq/exynos directory
>
--
MyungJoo Ham, Ph.D.
Mobile Software Platform
> On 12:33-20130222, Wei Yongjun wrote:
> > From: Wei Yongjun
> >
> > Add the missing unlock before return from function
> > exynos4_busfreq_pm_notifier_event() in the error
> > handling case.
> >
> > This issue introduced by commit 8fa938
> > (PM / devfreq: exynos4_bus: honor RCU lock usage)
>
tree (at that time,
> v3.3, and currently) makes clear that this should have been dependencies
> on SOC_EXYNOS4212 and SOC_EXYNOS4412.
>
> Signed-off-by: Paul Bolle
Acked-by: MyungJoo Ham
> ---
> drivers/devfreq/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-
patchset is going to be shown at
http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/devfreq-for-next
within hours as well.
MyungJoo Ham (2):
PM / devfreq: add global PM QoS support
PM / devfreq: support per-dev PM-QoS in devfreq
drivers/devfreq/devfreq.c | 135
Added support of per-dev PM-QoS request handling in devfreq core.
Signed-off-by: MyungJoo Ham
---
drivers/devfreq/devfreq.c | 24
1 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index d74b382
to be positive,
min/max freq is now enforced regardless of governor implementation.
Tested on Exynos4412 machines with memory/bus frequencies and multimedia
H/W blocks. (camera, video decoding, and video encoding)
Signed-off-by: MyungJoo Ham
Signed-off-by: Kyungmin Park
---
Changed from V2
,
> }
>
> Signed-off-by: anish kumar
Looks good.
Signed-off-by: MyungJoo Ham
> ---
> drivers/extcon/extcon-class.c |4 +---
> include/linux/extcon.h|2 +-
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/extcon/extcon-
> From: anish kumar
>
> Rather than re-inventing the wheel we can use the hamming function
> to calculate the number of bits set to check for violation of
> exclusivity.
>
> Signed-off-by: anish kumar
Ah.. we've got such a convinient one. Thanks.
S
by: anish kumar
Ah.. yes.. I thought removing it could emit compiler errors.
But, we have it declared in the header file. Good.
Thanks.
Signed-off-by: MyungJoo Ham
> ---
> drivers/extcon/extcon-class.c |1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --
> any comments ?
>
Sorry for replying late.
It has been applied to the extcon-for-next tree at
http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next
, which will appear in hours.
> On Wed, Aug 15, 2012 at 12:19 PM, Devendra Naga
> wrote:
> > actually we can d
> On 27 September 2012 13:50, MyungJoo Ham wrote:
> >> Prepare devfreq core framework to support devices which
> >> can idle. When device idleness is detected perhaps through
> >> runtime-pm, need some mechanism to suspend devfreq load
> >> monitorin
> This patchset updates devfreq core to add support for devices
> which can idle. When device idleness is detected perhaps
> through runtime-pm, need some mechanism to suspend devfreq
> load monitoring and resume when device is back online.
>
> patch 1 introduce core design changes - per device wo
> On 4 October 2012 18:06, MyungJoo Ham wrote:
> >> This patchset updates devfreq core to add support for devices
> >> which can idle. When device idleness is detected perhaps
> >> through runtime-pm, need some mechanism to suspend devfreq
> >> load mo
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hello Greg,
Please pull:
The following changes since commit 6f0c0580b70c89094b3422ba81118c7b959c7556:
Linux 3.7-rc2 (2012-10-20 12:11:32 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mzx/extcon.gi
>
> > Subject: Re: [PATCH] extcon : callback function to read cable property
> >
> > On 10/19/2012 12:13 PM, Tc, Jenny wrote:
> > The rold of extcon inform only attached/detached state of extcon consumer
> > driver from extcon provider driver. After extcon consumer driver detect the
> > state of
expose the available frequencies as a snapshot over sysfs to
> allow informed decisions.
>
> This was inspired by cpufreq framework's equivalent for similar
> usage sysfs node: scaling_available_frequencies.
>
> Cc: Rajagopal Venkat
> Cc: MyungJoo Ham
> Cc: Kyungmin P
> I fixed the following check item (via checkpatch.pl --strict option):
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Sangho Yi
Acked-by: MyungJoo Ham
I'll apply the patch after setting up devfreq for next tree.
Thanks.
Cheers,
MyungJoo
> --
t;/dev/null
> >
> > Cc: Rajagopal Venkat
> > Cc: MyungJoo Ham
> > Cc: Kyungmin Park
> > Cc: "Rafael J. Wysocki"
> > Cc: Kevin Hilman
> > Cc: linux...@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> >
> > Signed-off-by:
> On Friday, October 26, 2012 06:16:36 AM MyungJoo Ham wrote:
> > > devfreq governors such as ondemand are controlled by a min and
> > > max frequency, while governors like userspace governor allow us
> > > to set a specific frequency.
> > > However, for the
> On Wed, Sep 05, 2012 at 11:28:03AM +0800, Mark Brown wrote:
> > On Tue, Sep 04, 2012 at 04:51:00PM -0700, Randy Dunlap wrote:
> >
> > > This build error still happens in linux-next of 20120904.
> >
> > > Can we get the patch merged for linux-next?
> >
> > Greg's the one managing extcon in -nex
> Add devfreq suspend/resume apis for devfreq users. This patch
> supports suspend and resume of devfreq load monitoring, required
> for devices which can idle.
>
> Signed-off-by: Rajagopal Venkat
Rather than letting device driver be responsible to call
devfreq_suspend_device() or devfreq_dev_s
vents to perform
> specific actions. These events include start/stop devfreq.
> This sets ground for adding suspend/resume events.
>
> The devfreq apis are not modified and are kept intact.
>
> Signed-off-by: Rajagopal Venkat
Thank you!
Reviewed and Tested (at Exynos421
>> for devices which can idle.
> >>
> >> Signed-off-by: Rajagopal Venkat
> >> Acked-by: MyungJoo Ham
> >
> > Well, I wonder if this may be tied in to the runtime PM framework, so that,
> > for example, pm_runtime_suspend() will automatically suspend
frequencies and multimedia
H/W blocks. (camera, video decoding, and video encoding)
Signed-off-by: MyungJoo Ham
Signed-off-by: Kyungmin Park
---
Changes from V3
- Corrected and added comments
- Code Clean
- Merged per-dev qos patch and global qos patch
Changed from V2-resend
- Removed dependencies on
gt; the devfreq device drivers only need to express the mappings of
> QoS value and frequency pairs with QoS class along with
> devfreq_add_device() call.
>
> Tested on Exynos4412 machines with memory/bus frequencies and multimedia
> H/W blocks. (camera, video decoding, and video enco
> There are some scnearios where a driver/framework needs to register
> interest for a particular cable without specifying the extcon device
> name. One such scenario is charger notifications. The platform will
> have charger cabel which will be bound to any extcon device. It's
> not mandatory for
> Myunjoo/Chanwoo
>
> Ping...
> Could you please review this patch?
>
> -jtc
>
> > > > Subject: Re: [PATCH] extcon : callback function to read cable
> > > > property
> > > >
> > > > I think the reason why we have extcon is in first place is to only
> > > > notify the clients of cable connection
q_floor(dev, freq);
> /* Will only be triggered if search logic fails: intended usage */
> if (opp == ERR_PTR(-ERANGE))
> opp = opp_find_freq_ceil(dev, freq);
>
> Cc: MyungJoo Ham
> Cc: Kyungmin Park
> Cc: "Rafael J. Wysocki"
> Cc: Kevin Hilman
> C
Sender : Greg KH
Date : 2012-10-19 02:24 (GMT+09:00)
> On Thu, Oct 11, 2012 at 10:31:19AM +0900, Chanwoo Choi wrote:
> > Hi Greg,
> >
> > Please pull extcon fixes for Linux 3.6 from:
> >
> > git://git.infradead.org/users/kmpark/linux-samsung extcon-for-next
> >
> > I've been creating "extcon
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hello Greg,
The following changes since commit 6f0c0580b70c89094b3422ba81118c7b959c7556:
Linux 3.7-rc2 (2012-10-20 12:11:32 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mzx/extcon.git for-next
Ax
> + bool poll;
> + unsigned long min;
> +};
It appears that "boost" is something may be handled by per-dev QoS.
It looks like that you are reimplementing the pm-qos infrastructure in
the driver.
Could you please implement this w/ per-dev QoS?
Or explain why this i
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -629,6 +629,44 @@ static ssize_t show_governor(struct device *dev,
> return sprintf(buf, "%s\n", to_devfreq(dev)->governor->name);
> }
>
> +static ssize_t store_governor(struct device *dev, struct device_attribute
>
> > >> I think that the role of extcon subsystem notify changed
> > >> state(attached/detached) of cable to notifiee, but if you want to
> > >> add property feature of cable, you should solve ambiguous issues.
> > >>
> > >> First,
> > >> This patch only support the propertie
Anton Vorontsov wrote:
> The idea of using union seemed good to me, what happened to it?
>
> I mean, MyungJoo Ham wrote:
>
> | We may have:
> |enum extcon_cable_type {
> |EXTCON_CT_REGULATOR,
> |EXTCON_CT_PSY,
> |
On Thu, Aug 15, 2013 at 4:55 PM, Dan Carpenter wrote:
>
> The create_freezable_workqueue() function returns a NULL on error and
> not an ERR_PTR.
>
> Signed-off-by: Dan Carpenter
Thanks. I'll apply this.
Signed-off-by: MyungJoo Ham
>
> diff --git a/drivers/devfreq/d
> On 24 May 2013 11:26, Lukasz Majewski wrote:
> >> > On 22 May 2013 15:57, Lukasz Majewski
> > As you wished, I've provided relevant data for overclocking.
> >
> > Would you be so kind and comment on them?
>
> I was about to reply ... was busy with some other backlog :)
>
> >> Test HW Exynos44
On Wed, Mar 27, 2013 at 10:52 PM, Rajagopal Venkat
wrote:
> Fix compiler warnings generated when devfreq is not enabled
> (CONFIG_PM_DEVFREQ is not set).
>
> Signed-off-by: Rajagopal Venkat
Thanks!
Acked-by: MyungJoo Ham
> ---
> include/linux/devfreq.h | 16
s.
>
> Signed-off-by: anish kumar
Signed-off-by: MyungJoo Ham
> ---
> drivers/extcon/Kconfig |5 +
> drivers/extcon/Makefile |1 +
> drivers/extcon/adc_jack.c | 183
> +++
> include/linux/extcon/adc_
s.
>
> Changes in this version:
> added Lars-Peter Clausen suggested changes:
> Using macros to get rid of boiler plate code such as devm_kzalloc
> and module_platform_driver.Other changes suggested are related to
> coding guidelines.
>
> Signed-off-by: anish kumar
> Sign
> extcon.h header file was included twice.
>
> Signed-off-by: Sachin Kamat
> Signed-off-by: Sachin Kamat
Signed-off-by: MyungJoo Ham
Thanks!
MyungJoo
hwa Lee
>
Signed-off-by: MyungJoo Ham
N떑꿩�r툤y鉉싕b쾊Ф푤v�^�)頻{.n�+돴쪐{콗喩zX㎍썳變}찠꼿쟺�&j:+v돣�쳭喩zZ+�+zf＂톒쉱�~넮녬i鎬z� 췿ⅱ�?솳鈺�&�)刪f뷌^j푹y쬶끷@A첺뛴
0띠h��뭝
> Devfreq framework don't have a frequency table, add it
> for easy use.
>
> Signed-off-by: Xiaoguang Chen
As we are going to have transition statistics (similar with trans_table
and time_in_state of CPUfreq), we are going to have a data structure
that your suggested code may use.
Could you ple
> This patch initializes freq_table and max_state of devfreq's profile.
> They will be used for creating transition table.
>
> Signed-off-by: Jonghwa Lee
Signed-off-by: MyungJoo Ham
> ---
> drivers/devfreq/exynos4_bus.c | 30 +-
> 1 fi
sfs node to expose
> governor predicted next target frequency.
>
> Signed-off-by: Rajagopal Venkat
Signed-off-by: MyungJoo Ham
> ---
> Documentation/ABI/testing/sysfs-class-devfreq | 11 ++-
> drivers/devfreq/devfreq.c | 14 +
Sender : Rafael J. Wysocki
Date : 2012-09-09 07:20 (GMT+09:00)
Title : Re: [PATCH v3 1/2] PM / devfreq: add global PM QoS support
> On Thursday, August 30, 2012, MyungJoo Ham wrote:
> > Even if the performance of a device is controlled properly with devfreq,
> > sometimes, we still
> On 10 September 2012 14:43, 함명주 wrote:
> >> Prepare devfreq core framework to support devices which
> >> can idle. When device idleness is detected perhaps through
> >> runtime-pm, need some mechanism to suspend devfreq load
> >> monitoring and resume back when device is online. Present
> >> cod
> Sender : Rajagopal Venkat
> Date : 2012-09-18 14:20 (GMT+09:00)
> Title : Re: Re: [PATCH 1/3] devfreq: core updates to support devices which
> can idle
> On 17 September 2012 17:46, MyungJoo Ham wrote:
> >> On 10 September 2012 14:43, 함명주 wrote:
> >> >> Pr
Replaced '_' with '-' in the extcon file names, which has been bogging
me since new drivers have been using the standard naming.
Signed-off-by: MyungJoo Ham
---
drivers/extcon/Makefile |4 +-
drivers/extcon/extcon-class.c | 832 ++
Replaced '_' with '-' in the extcon file names, which has been bogging
since new drivers have been using the standard naming.
Signed-off-by: MyungJoo Ham
---
drivers/extcon/Makefile |4 ++--
drivers/extcon/{extcon_class.c => extcon-class.c}
t; Changes in this version:
> Added the cancel_work_sync during removing of driver.
>
> Reviewed-by: Lars-Peter Clausen
> Signed-off-by: anish kumar
> Signed-off-by: MyungJoo Ham
> ---
> drivers/extcon/Kconfig |5 +
> drivers/e
tp://www.beagleboard.org/irclogs/index.php?date=2013-01-18#T14:14:07
>> [2]
>> https://github.com/nmenon/linux-2.6-playground/commits/post/pm/opp-fixes-v1
>>
>> Regards,
>> Nishanth Menon
>>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Op
fine?
>
>> I.e., allowing extcon_register_interest() to accept NULL extcon_name.
>>
>>
>> ps. anyway, usually, the "platforms" have the list of node paths, don't they?
>>
> My intention is to make it generic and less dependent on platform data. This
&g
> On Monday 08 of October 2012 10:48:24 MyungJoo Ham wrote:
> > > On 8 October 2012 03:31, Rafael J. Wysocki wrote:
> > > > On Thursday 04 of October 2012 14:58:33 Rajagopal Venkat wrote:
> > > >> Add devfreq suspend/resume apis for devfreq users. This pat
> Parameter documentation needs a ':' for scripts/kernel-doc
> to parse properly.
>
> Minor fixes for ones warned by:
> ./scripts/kernel-doc -text drivers/devfreq/devfreq.c>/dev/null
>
> Cc: "Rafael J. Wysocki"
> Cc: Kevin Hilman
> Cc: Myu
;
> This is done for min_freq, max_freq and polling_interval
>
> Cc: MyungJoo Ham
> Cc: Kyungmin Park
> Cc: "Rafael J. Wysocki"
> Cc: Kevin Hilman
> Cc: linux...@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
>
> Signed-off-by: Nishanth Menon
Acked-by: MyungJoo Ham
> Hi,
>
> It looks like find_device_opp() (called from opp_get_notifier()) needs
> to be under RCU read lock, but this doesn't seem to be happening in
> drivers/devfreq/devfreq.c. Doesn't this run the risk of referencing a
> freed variable?
>
> Thanks,
>
> -Kees
Yes, that's an issue requiring u
opp_get_notifier() uses find_device_opp(), which requires to
held rcu_read_lock. In order to keep the notifier-header
valid, we have added rcu_read_lock().
Reported-by: Kees Cook
Signed-off-by: MyungJoo Ham
---
drivers/devfreq/devfreq.c | 26 --
1 files changed, 20
> Use the value obtained from the function instead of -EINVAL.
>
> Signed-off-by: Sachin Kamat
Acked-by: MyungJoo Ham
Both patches applied as they are obvious bugfixes.
I'll send pull request with other bugfixes within days.
> ---
> drivers/devfreq/devfreq.c |2 +-
&
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
The following changes since commit f4a75d2eb7b1e2206094b901be09adb31ba63681:
Linux 3.7-rc6 (2012-11-16 17:42:40 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mzx/extcon.git for-gregkh
Alexey Khorosh
wise, you may get "unspecified" behavior from the BUCK1/2/5,
which may incur unstable system.
Cheers,
MyungJoo
--
MyungJoo Ham, Ph.D.
Mobile Software Platform Lab, DMC Business, Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
On Wed, Nov 21, 2012 at 11:35 PM, Greg KH wrote:
> On Wed, Nov 21, 2012 at 08:15:25PM +0900, MyungJoo Ham wrote:
>> The following changes since commit f4a75d2eb7b1e2206094b901be09adb31ba63681:
>>
>> Linux 3.7-rc6 (2012-11-16 17:42:40 -0800)
>>
>> are available i
opp_get_notifier() uses find_device_opp(), which requires to
held rcu_read_lock. In order to keep the notifier-header
valid, we have added rcu_read_lock().
Reported-by: Kees Cook
Signed-off-by: MyungJoo Ham
---
drivers/devfreq/devfreq.c | 26 --
1 files changed, 20
/pub/scm/linux/kernel/git/mzx/extcon.git for-next
Alexey Khoroshilov (1):
extcon: arizona: unlock mutex on error path in arizona_micdet()
Chanwoo Choi (1):
extcon: Add missing header file to extcon.h
MyungJoo Ham (1):
extcon: kernel_doc style fix
Sachin Kamat (9):
extcon
Merge branch 'pm-cpufreq-next' into linux-next (2012-11-22 00:23:28 +0100)
, which is HEAD of Rafael's linux-pm.git linux-next branch on 2012-11-22.
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git
tags/pull_req_20121122
M
static (2012-11-15 00:35:06 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mzx/devfreq.git
tags/pull_req_20121126
Jonghwa Lee (1):
PM / devfreq: Add sysfs node for representing frequency transition
information.
MyungJoo Ham (2):
PM
> On Monday, November 26, 2012 03:41:22 PM MyungJoo Ham wrote:
> > Dear Rafael,
> >
> > sorry for the inconviences; I forgot that I've updated the tag name
> > according to the date modified.
> >
> > Please use "pull_req_20121122" tag
On Wed, Jan 9, 2013 at 9:06 PM, Abhilash Kesavan wrote:
> PPMU is required by the devfreq driver. Add a device tree
> node for it.
>
> Signed-off-by: Abhilash Kesavan
> Cc: Jonghwan Choi
> Cc: Kukjin Kim
Acked-by: MyungJoo Ham
> ---
> .../bindings/arm
On Wed, Jan 9, 2013 at 9:06 PM, Abhilash Kesavan wrote:
> Setup the INT clock ops to control/vary INT frequency
>
> Signed-off-by: Abhilash Kesavan
> Cc: Jonghwan Choi
> Cc: Kukjin Kim
Acked-by: MyungJoo Ham
Is this part going to be merged at exynos-tree?
Anyways, as I don
GFP_KERNEL);
> devfreq->last_stat_updated = jiffies;
> + devfreq_set_freq_limits(devfreq);
>
> dev_set_name(&devfreq->dev, dev_name(dev));
> err = device_register(&devfreq->dev);
> --
> 1.7.10.4
>
> --
>
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
MyungJoo Ham, Ph.D.
Mobile Software Pl
err = devfreq_update_status(devfreq, devfreq->previous_freq);
> - if (err)
> + if (!devfreq->stop_polling &&
> + devfreq_update_status(devfreq,
> devfreq->previous_freq))
> return 0;
>
> len = sprintf(buf, "
onding devfreq object.
>
> -What:/sys/class/devfreq/.../central_polling
> -Date:September 2011
> -Contact: MyungJoo Ham
> -Description:
> - The /sys/class/devfreq/.../central_polling shows whether
> - the devfre
> Use tab rather than space to indent, and tab + two spaces to indent
> help message.
>
> Signed-off-by: Jisheng Zhang
> ---
> drivers/devfreq/Kconfig | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
Thanks!
Signed-off-by: MyungJoo Ham
Cheers,
MyungJoo
> on rk3399 platform, there is dfi conroller can monitor
> ddr load, base on this result, we can do ddr freqency
> scaling.
>
> Signed-off-by: Lin Huang
> Acked-by: Chanwoo Choi
LGTM
Signed-off-by: MyungJoo Ham
> Hi Jisheng,
>
> Looks good to me. But, you need to rebase it
> on latest devfreq.git because the related patch
> is already merged[1] for COMPILE_TEST.
> So, the merge conflict may happen.
>
> [1]
> https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=for-rc&id=c2f9bf4e49c12a
> base on dfi result, we do ddr frequency scaling, register
> dmc driver to devfreq framework, and use simple-ondemand
> policy.
>
> Signed-off-by: Lin Huang
> Reviewed-by: Chanwoo Choi
> ---
Thanks. LGTM.
Signed-off-by: MyungJoo Ham
Cheers,
MyungJoo.
_freq zero)
> + mutex_unlock(&devfreq->lock);
> + return -EINVAL;
> + }
> +
> ret = update_devfreq(devfreq);
> mutex_unlock(&devfreq->lock);
>
--
MyungJoo Ham, Ph.D.
S/W Center, Samsung Electronics
cription
> of function. Because the helper functions are only used by the devfreq.
>
> Signed-off-by: Chanwoo Choi
Acked-by: MyungJoo Ham
> ---
> drivers/devfreq/devfreq.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
[]
--
MyungJoo Ham, Ph.D.
S/W Center, Samsung Electronics
to show the all available frequencies.
> - If 'freq_table' is NULL, devfreq core initializes them by using OPP values.
> - If 'freq_table' is initialized, devfreq core just uses the 'freq_table'.
>
> And this patch adds some comment about the sort way of
On Fri, Oct 13, 2017 at 4:48 PM, Chanwoo Choi wrote:
> The freq_table array of each devfreq device is always not NULL.
> In result, it is unneeded to check whether profile->freq_table
> is NULL or not.
>
> Signed-off-by: Chanwoo Choi
Acked-by: MyungJoo Ham
> ---
> d
of using the string directly.
>
> Signed-off-by: Chanwoo Choi
> Cc: Kukjin Kim
> Cc: Krzysztof Kozlowski
> Cc: linux-samsung-...@vger.kernel.org
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
Acked-by: MyungJoo Ham
> ---
> driver
On Fri, Oct 13, 2017 at 4:48 PM, Chanwoo Choi wrote:
> This patch registers the Exynos Bus-Frequency scaling device
> as a cooling device of thermal management.
>
> Signed-off-by: Chanwoo Choi
> Cc: Kukjin Kim
> Cc: Krzysztof Kozlowski
> Cc: linux-samsung-...@vger.kernel.org
> Cc: linux-arm-ker
req/devfreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: MyungJoo Ham
> On Thu, Aug 27, 2015 at 11:58:39AM +0100, MyungJoo Ham wrote:
> > > The thermal infrastructure should use the devfreq cooling device, which
> > > uses the OPP library to disable OPPs as necessary.
> > >
> > > Fix a couple of typos in the same comm
>On Mon, Oct 19, 2015 at 8:49 PM, MyungJoo Ham wrote:
>
>>Since devm_kzalloc can be failed in memory pressure,
> >check return value and handle error.
> >
> >Signed-off-by: Insu Yun
> >---
>> drivers/devfreq/devfreq.c | 14 ++
> > 1 fi
>Since devm_kzalloc can be failed in memory pressure,
>check return value and handle error.
>
>Signed-off-by: Insu Yun
>---
> drivers/devfreq/devfreq.c | 14 ++
> 1 file changed, 14 insertions(+)
>
>diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
>index ca1b362..81408
> When device_register() fails, kfree(devfreq) is called already in
> devfreq_dev_release(), hence there is no need to call kfree(devfreq)
> in err_dev again.
>
> Signed-off-by: Geliang Tang
Thank you for pointing out that put_device() will eventually call kfree anyway.
Signed-o
on issues described below,
Signed-off-by: MyungJoo Ham
> ---
> This patch is based on following patch[1].
> [1] https://lkml.org/lkml/2015/10/3/304
>
> Changes from v1:
> - Create the include/dt-bindings/extcon/extcon.h including the identification
> of external conne
> Dear Rob,
>
> On 2018년 08월 28일 10:52, Rob Herring wrote:
> > In preparation to remove the node name pointer from struct device_node,
> > convert printf users to use the %pOFn format specifier.
> >
> > Cc: Chanwoo Choi
> > Cc: MyungJoo Ham
> >
>Many CPU architectures have caches that can scale independent of the CPUs.
>Frequency scaling of the caches is necessary to make sure the cache is not
>a performance bottleneck that leads to poor performance and power. The same
>idea applies for RAM/DDR.
>
>To achieve this, this patch adds a gener
>This driver registers itself as a devfreq device that allows devfreq
>governors to make bandwidth votes for an interconnect path. This allows
>applying various policies for different interconnect paths using devfreq
>governors.
>
First of all, the name, "devfreq_icbw", is not appropriate for a
de
>MyungJo, I am trying to understand the relationship of PM QOS with
>devfreq drivers. I don't see any relation of PM QOS api's with devfreq drivers
>directly as there are no QOS apis used in the devfreq framework.
>
>The only explanation I have is that PM QOS has direct relationship
>with CPUFREQ d
> kfree has taken the null pointer into account. hence it is safe
> to remove the redundant null pointer check before kfree.
>
> Signed-off-by: zhong jiang
Acked-by: MyungJoo Ham
> ---
> drivers/devfreq/devfreq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions
emand which is using the devfreq deferrable monitoring work. If it
> is not stopped before the resources are freed, it might lead to a use after
> free.
>
> Signed-off-by: Vincent Donnefort
> Reviewed-by: John Einar Reitan
> Reviewed-by: Chanwoo Choi
Acked-by: MyungJoo Ham
Cheers,
MyungJoo
1 - 100 of 347 matches
Mail list logo
