Re: [PATCH v5 0/8] fat: fix estale error on VFAT over NFS.

2012-11-27 Thread Namjae Jeon
2012/11/27, OGAWA Hirofumi : > Namjae Jeon writes: > >> From: Namjae Jeon >> >> This patch-set eliminates the client side ESTALE errors when a FAT >> partition >> exported over NFS has its dentries evicted from the cache. >> >> One of the reasons f

Re: [PATCH v2 3/7] f2fs: add tracepoint for tracing the page i/o operations

2013-03-17 Thread Namjae Jeon
2013/3/17, Steven Rostedt : > On Sun, 2013-03-17 at 17:40 +0900, Namjae Jeon wrote: >> From: Namjae Jeon >> >> Add tracepoints for page i/o operations and block allocation >> tracing during page read operation. >> >> Signed-off-by: Namjae Jeon >> Si

Re: [PATCH 5/5] f2fs: avoid BUG_ON from check_nid_range and update return path in do_read_inode

2013-03-17 Thread Namjae Jeon
2013/3/18, Jaegeuk Kim : > 2013-03-17 (일), 17:27 +0900, Namjae Jeon: >> From: Namjae Jeon >> >> In function check_nid_range, there is no need to trigger BUG_ON and make >> kernel stop. >> Instead it could just check and indicate the inode number to be EIN

Re: [PATCH] f2fs: fix not to allocate max_nid

2013-03-18 Thread Namjae Jeon
2013/3/18, Jaegeuk Kim : > The build_free_nid should not add free nids over nm_i->max_nid. > But, there was a hole that invalid free nid was added by the following > scenario. > > Let's suppose nm_i->max_nid = 150 and the last NAT page has 100 ~ 200 nids. > > build_free_nids > - get_current_nat_p

Re: [PATCH] f2fs: fix not to allocate max_nid

2013-03-18 Thread Namjae Jeon
2013/3/18, Jaegeuk Kim : > 2013-03-18 (월), 18:29 +0900, Namjae Jeon: >> 2013/3/18, Jaegeuk Kim : >> > The build_free_nid should not add free nids over nm_i->max_nid. >> > But, there was a hole that invalid free nid was added by the following >> > scenario

Re: [PATCH] f2fs: fix to call WRITE_FLUSH at the end of fsync

2013-03-18 Thread Namjae Jeon
2013/3/18, Jaegeuk Kim : > The fsync call should be ended after flushing the in-device caches. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Namjae Jeon Looks good! Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH] f2fs: fix to unlock node page when it was truncated

2013-03-18 Thread Namjae Jeon
de_page with zero. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Namjae Jeon Looks good to me~ Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majord

Re: [PATCH 13/19] f2fs: fix return value of releasepage for node and data

2013-03-18 Thread Namjae Jeon
2013/3/18, Jaegeuk Kim : > If the return value of releasepage is equal to zero, the page cannot be > reclaimed. > Instead, we should return 1 in order to reclaim clean pages. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/data.c | 4 +++- > fs/f2fs/node.c | 13 +++-- > 2 files changed, 6

Re: [PATCH] [SCSI]: print the msgbytes and statusbyte from scsi result

2013-03-18 Thread Namjae Jeon
2013/3/18, James Bottomley : > On Sun, 2013-03-17 at 17:29 +0900, Namjae Jeon wrote: >> From: Namjae Jeon >> >> Introduce msgbyte and statusbyte in the prints as part of the >> result which is returned by the lower layer driver in response to >> SCSI com

Re: [PATCH 4/5] f2fs: remove nid_free from f2fs_new_inode

2013-03-18 Thread Namjae Jeon
2013/3/18, Jaegeuk Kim : > 2013-03-17 (일), 17:27 +0900, Namjae Jeon: >> From: Namjae Jeon >> >> we can remove nid_free from new inode allocation part. >> Since, nid_free is used to check if we need to free alloced nid >> in case of failure. >> Instead we

Re: [PATCH 13/19] f2fs: fix return value of releasepage for node and data

2013-03-18 Thread Namjae Jeon
2013/3/18, Jaegeuk Kim : > 2013-03-18 (월), 20:39 +0900, Namjae Jeon: >> 2013/3/18, Jaegeuk Kim : >> > If the return value of releasepage is equal to zero, the page cannot be >> > reclaimed. >> > Instead, we should return 1 in order to reclaim clean pages.

Re: [PATCH] f2fs: reduce unncessary locking pages during read

2013-03-18 Thread Namjae Jeon
> > - err = f2fs_readpage(sbi, page, dn.data_blkaddr, READ_SYNC); > - if (err) { > - f2fs_put_page(page, 1); > - return ERR_PTR(err); > + if (PageUptodate(page)) { > + unlock_page(page); > + return page; > } > - unlock_page(page)

Re: [PATCH] f2fs: should check the node page was truncated first

2013-03-18 Thread Namjae Jeon
ned-off-by: Jaegeuk Kim Looks good to me. Reviewed-by: Namjae Jeon Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] f2fs: reduce unncessary locking pages during read

2013-03-19 Thread Namjae Jeon
2013/3/19, Jaegeuk Kim : > 2013-03-19 (화), 13:54 +0900, Namjae Jeon: >> > >> > - err = f2fs_readpage(sbi, page, dn.data_blkaddr, READ_SYNC); >> > - if (err) { >> > - f2fs_put_page(page, 1); >> > - re

Re: [PATCH] [trivial] f2fs: Fix typo in comments

2013-03-19 Thread Namjae Jeon
2013/3/19, Masanari Iida : > Correct spelling typo in comments > > Signed-off-by: Masanari Iida Acked-by: Namjae Jeon Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH 2/6] f2fs: move out f2fs_balance_fs from gc_thread_func

2013-02-03 Thread Namjae Jeon
on check and balance_fs > > 1. If f2fs is mounted with background_gc_off option, checking > BG_GC is not redundant. > 2. f2fs_balance_fs is checked in f2fs_gc, so this is also redundant. > > Signed-off-by: Changman Lee > Signed-off-by: Namjae Jeon > Signed-off-by: Ami

Re: [PATCH 1/6] f2fs: optimize get node page readahead part

2013-02-03 Thread Namjae Jeon
2013/2/4, Jaegeuk Kim : > Hi, > > 2013-02-02 (토), 23:51 +0900, Namjae Jeon: >> From: Namjae Jeon >> >> We can remove the call to find_get_page to get a page from the cache >> and check for up-to-date, instead we can make use of grab_cache_page >> part

Re: [PATCH] udf: add extent cache support in case of file reading

2013-02-04 Thread Namjae Jeon
2013/2/4, Jan Kara : > On Sat 02-02-13 15:21:09, Namjae Jeon wrote: >> Hi. Jan. >> >> Sorry for interrupt. >> Have you taken this patch to your tree ? I can not find it.. >> or Is there any issue regarding this patch ? > I had it in my tree but not in th

[PATCH] f2fs: add compat_ioctl to provide backward compatability

2013-02-04 Thread Namjae Jeon
From: Namjae Jeon adding compat_ioctl to provide support for backward comptability - 32bit binary execution on 64bit kernel. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/f2fs.h | 15 +++ fs/f2fs/file.c | 20 2 files changed, 35

[PATCH v2] fat: eliminate iterations in fat_search_long and __fat_readdir in case of EOD

2013-02-04 Thread Namjae Jeon
From: Namjae Jeon When doing lookups via fat_search_long(), we can stop checking for further entries if we detect End of Directory, i.e. if (de->name[0] == 0x00).The current code traverses the cluster chain of a directory until a hit is found or till the last cluster for that directory, ignor

Re: [PATCH] f2fs: add compat_ioctl to provide backward compatability

2013-02-04 Thread Namjae Jeon
Hi Jaegeuk. Oops!, I was missing include header. Sorry, I will send v2 patch again. Thanks. 2013/2/4, Namjae Jeon : > From: Namjae Jeon > > adding compat_ioctl to provide support for backward comptability - 32bit > binary > execution on 64bit kernel. > > Signed-off-by:

Re: [PATCH] f2fs: add compat_ioctl to provide backward compatability

2013-02-04 Thread Namjae Jeon
2013/2/5, Jaegeuk Kim : > Hi, > > 2013-02-05 (화), 14:28 +0900, Namjae Jeon: >> Hi Jaegeuk. >> >> Oops!, I was missing include header. >> Sorry, I will send v2 patch again. > > I got a build error, and simply added the following header file in your > p

Re: [PATCH] f2fs: add compat_ioctl to provide backward compatability

2013-02-04 Thread Namjae Jeon
2013/2/5, Namjae Jeon : > 2013/2/5, Jaegeuk Kim : >> Hi, >> >> 2013-02-05 (화), 14:28 +0900, Namjae Jeon: >>> Hi Jaegeuk. >>> >>> Oops!, I was missing include header. >>> Sorry, I will send v2 patch again. >> >> I got a bui

[PATCH] f2fs: fix to name f2fs GC task as per partition instead of per device

2013-02-05 Thread Namjae Jeon
From: Namjae Jeon After the commit 2184ad190a79ae2b40b5f5db1fbde5c22db6d310, it allowed for naming GC threads based on the device. i.e., if we have F2FS formatted partition in different devices - we will have their GC thread names after the device. But, when we have a case like 2 or more

Re: [PATCH] f2fs: fix to name f2fs GC task as per partition instead of per device

2013-02-05 Thread Namjae Jeon
2013/2/6, Jaegeuk Kim : > Hi, > > How about this? > > 2013-02-05 (화), 23:24 +0900, Namjae Jeon: >> From: Namjae Jeon >> >> After the commit 2184ad190a79ae2b40b5f5db1fbde5c22db6d310, it allowed >> for naming GC threads based on the device. >> i.e., if

[LSF/MM TOPIC] f2fs: Dynamic Control of GC Thread at User Level and Stabilizing sudden eject behavior for SD Cards.

2013-02-05 Thread Namjae Jeon
Hello. I am considering the following subjects on f2fs. I'm not sure if it is proper TOPIC. Let me know opinions :) 1. Dynamic Control of GC Thread at User Level. To cope with rapid increase in number of smart phone users and increasing demands for different media application with Quality Of Serv

Re: [PATCH v2] fat: eliminate iterations in fat_search_long and __fat_readdir in case of EOD

2013-02-07 Thread Namjae Jeon
2013/2/7, OGAWA Hirofumi : > Namjae Jeon writes: > >> From: Namjae Jeon >> >> When doing lookups via fat_search_long(), we can stop checking for >> further entries if we detect End of Directory, i.e. if (de->name[0] == >> 0x00).The current code traverses t

Re: [PATCH v2] fat: eliminate iterations in fat_search_long and __fat_readdir in case of EOD

2013-02-08 Thread Namjae Jeon
2013/2/8, OGAWA Hirofumi : > Namjae Jeon writes: > >>> And did this work correctly about f_pos for readdir? >> Yes, sure. f_pos is work correctly about each directory entry. because >> after name[0] == 0x00, there are no allocated directory entires. >>> >

[PATCH v6 0/7] fat (exportfs): support stale_rw and nostale_ro mount options.

2013-02-09 Thread Namjae Jeon
From: Namjae Jeon This patch set eliminates the client side ESTALE errors when a FAT partition exported over NFS has it's dentries evicted from the cache. The idea is to find the on-disk location_'i_pos' of the dirent of the inode that has been evicted and use it to rebuild the

[PATCH v6 1/7] fat: Introduce 2 new values for the -o nfs mount option

2013-02-09 Thread Namjae Jeon
From: Namjae Jeon Provide two possible values 'stale_rw' and 'nostale_ro' for the -o nfs mount option.The first one allows all file operations but does not reduce ESTALE errors on memory constrained systems. The second one eliminates ESTALE errors but mounts the filesyst

[PATCH v6 2/7] fat: move fat_i_pos_read to fat.h

2013-02-09 Thread Namjae Jeon
From: Namjae Jeon Move fat_i_pos_read to fat.h so that it can be called from nfs.c in the subsequent patches to encode the file handle. Signed-off-by: Namjae Jeon Signed-off-by: Ravishankar N Signed-off-by: Amit Sahrawat --- fs/fat/fat.h | 14 ++ fs/fat/inode.c | 14

[PATCH v6 3/7] fat: introduce a helper fat_get_blknr_offset()

2013-02-09 Thread Namjae Jeon
From: Namjae Jeon Introduce helper function to get the block number and offset for a given i_pos value. Use it in __fat_write_inode() now and later on in nfs.c Signed-off-by: Namjae Jeon Signed-off-by: Ravishankar N Signed-off-by: Amit Sahrawat --- fs/fat/fat.h |7 +++ fs/fat

[PATCH v6 4/7] fat: restructure export_operations

2013-02-09 Thread Namjae Jeon
From: Namjae Jeon Define two nfs export_operation structures,one for 'stale_rw' mounts and the other for 'nostale_ro'.The latter uses i_pos as a basis for encoding and decoding file handles. Also, assign i_pos to kstat->ino.The logic for rebuilding the inode is added in

[PATCH v6 5/7] fat (exportfs): rebuild inode if ilookup() fails

2013-02-09 Thread Namjae Jeon
From: Namjae Jeon If the cache lookups fail,use the i_pos value to find the directory entry of the inode and rebuild the inode.Since this involves accessing the FAT media, do this only if the nostale_ro nfs mount option is specified. Signed-off-by: Namjae Jeon Signed-off-by: Ravishankar N

[PATCH v6 6/7] fat (exportfs): rebuild directory-inode if fat_dget() fails

2013-02-09 Thread Namjae Jeon
From: Namjae Jeon This patch enables rebuilding of directory inodes which are not present in the cache.This is done by traversing the disk clusters to find the directory entry of the parent directory and using its i_pos to build the inode. The traversal is done by fat_scan_logstart() which is

[PATCH v6 7/7] Documentation: update nfs option in filesystem/vfat.txt

2013-02-09 Thread Namjae Jeon
From: Namjae Jeon Add descriptions about 'stale_rw' and 'nostale_ro' nfs options in filesystem/vfat.txt Signed-off-by: Namjae Jeon Signed-off-by: Ravishankar N Signed-off-by: Amit Sahrawat --- Documentation/filesystems/vfat.txt | 26 +-

[PATCH] fs: encode_fh: return FILEID_INVALID if invalid fid_type

2013-02-11 Thread Namjae Jeon
From: Namjae Jeon This patch is a follow up on below patch: [PATCH] exportfs: add FILEID_INVALID to indicate invalid fid_type commit: 216b6cbdcbd86b1db0754d58886b466ae31f5a63 Signed-off-by: Namjae Jeon Signed-off-by: Vivek Trivedi Acked-by: Steven Whitehouse --- fs/btrfs/export.c |4

Re: [PATCH] fs: encode_fh: return FILEID_INVALID if invalid fid_type

2013-02-11 Thread Namjae Jeon
2013/2/12, Dave Chinner : > On Mon, Feb 11, 2013 at 05:25:58PM +0900, Namjae Jeon wrote: >> From: Namjae Jeon >> >> This patch is a follow up on below patch: >> >> [PATCH] exportfs: add FILEID_INVALID to indicate invalid fid_type >> commit: 216b6cbdcbd86b1d

Re: [PATCH 9/9] f2fs: fix the bitmap consistency of dirty segments

2013-04-02 Thread Namjae Jeon
types. > > So, this patch eliminates this inconsistency. > > Signed-off-by: Jaegeuk Kim Looks good to me~ Reviewed-by: Namjae Jeon Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/9] f2fs: introduce TOTAL_SECS macro

2013-04-02 Thread Namjae Jeon
2013/4/1, Jaegeuk Kim : > Let's use a macro to get the total number of sections. > > Signed-off-by: Jaegeuk Kim Looks reasonable to me~ Reviewed-by: Namjae Jeon Thanks. > --- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH 1/9] f2fs: do not use duplicate names in a macro

2013-04-02 Thread Namjae Jeon
2013/4/1, Jaegeuk Kim : > A macro should not use duplicate parameter names. > > Signed-off-by: Jaegeuk Kim Looks reasonable to me ~ Reviewed-by: Namjae Jeon Thanks. > --- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH] To add NULL pointer check

2013-04-02 Thread Namjae Jeon
333f68127097c4fa1eda4b3913a22 > > This patch adds a NULL pointer check in f2fs_write_data_pages() to > avoid > a possible NULL pointer dereference, in case if - > mapping->a_ops->writepage - > is NULL. Yes, I agree. Looks better! Reviewed-by: Namjae Jeon Thanks. > >

Re: [PATCH 5/9] f2fs: change GC bitmaps to apply the section granularity

2013-04-02 Thread Namjae Jeon
2013/4/1, Jaegeuk Kim : > This patch removes a bitmap for victim segments selected by foreground GC, > and > modifies the other bitmap for victim segments selected by background GC. > > 1) foreground GC bitmap > : We don't need to manage this, since we just only one previous victim > section >

Re: [PATCH 8/9] f2fs: avoid race for summary information

2013-04-02 Thread Namjae Jeon
write_checkpoint(sbi, false); > - else > + mutex_unlock(&sbi->gc_mutex); > + } else { > f2fs_balance_fs(sbi); > + } We can remove { } of else because single line code is used. Reviewed-by: Namjae Jeon Thanks. > > r

Re: [PATCH 6/9] f2fs: check completion of foreground GC

2013-04-02 Thread Namjae Jeon
2013/4/1, Jaegeuk Kim : > The foreground GCs are triggered under not enough free sections. > So, we should not skip moving valid blocks in the victim segments. > > Signed-off-by: Jaegeuk Kim Looks good to me~ Reviewed-by: Namjae Jeon Thanks. -- To unsubscribe from this list: s

Re: [PATCH 3/9] f2fs: remove redundant lock_page calls

2013-04-02 Thread Namjae Jeon
2013/4/1, Jaegeuk Kim : > In get_node_page, we do not need to call lock_page all the time. > > If the node page is cached as uptodate, > > 1. grab_cache_page locks the page, > 2. read_node_page unlocks the page, and > 3. lock_page is called for further process. > > Let's avoid this. Instead of remo

Re: [PATCH 7/9] f2fs: allocate remained free segments in the LFS mode

2013-04-02 Thread Namjae Jeon
uk Kim Looks good! Reviewed-by: Namjae Jeon Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 4/9] f2fs: allocate new segment aligned with sections

2013-04-02 Thread Namjae Jeon
2013/4/1, Jaegeuk Kim : > When allocating a new segment under the LFS mode, we should keep the > section > boundary. > > Signed-off-by: Jaegeuk Kim You can add Reviewed-by: Namjae Jeon Thanks! > --- -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCH 5/9 v2] f2fs: change GC bitmaps to apply the section granularity

2013-04-03 Thread Namjae Jeon
addition, the victims are able to be selected by foreground GCs, > since >there is no need to read victim blocks during foreground GCs. > >By the fact that the foreground GC reclaims segments in a section > unit, it'd > be better to manage this bitmap based on the se

Re: [PATCH 3/9 v2] f2fs: remove redundant lock_page calls

2013-04-03 Thread Namjae Jeon
as uptodate, > > 1. grab_cache_page locks the page, > 2. read_node_page unlocks the page, and > 3. lock_page is called for further process. > > Let's avoid this. > > Signed-off-by: Jaegeuk Kim Yes, Looks good! Reviewed-by: Namjae Jeon Thanks. > --- -- To unsubscrib

Re: mkfs.f2fs gets stuck with "blk_update_request: bio idx 0 >= vcnt 0" on 3.8

2013-04-05 Thread Namjae Jeon
Hi. Max. I have a question. Your mmc host driver set to host->max_discard_to by some value instead of not zero ? Thanks. 2013/4/5, Max Filippov : > On Fri, Apr 5, 2013 at 5:53 AM, Shaohua Li wrote: >> On Thu, Apr 04, 2013 at 06:00:18AM +0400, Max Filippov wrote: > > [...] > >>> the commit 0cfbc

[PATCH] f2fs: fix typo mistakes

2013-04-05 Thread Namjae Jeon
From: Namjae Jeon Fix typo mistakes. 1. I think that it should be 'L' instead of 'V'. 2. and try to fix 'Front' instead of 'Frone' Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/data.c|2 +- fs/f2fs/segment.h |2

[PATCH v3 0/7] f2fs: add tracepoints support in f2fs filesystem

2013-04-05 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints in f2fs filesystem for tracing the filesystem operations for information/debugging purpose if needed. All the tracepoints are clubbed with respect to functionalities. Change Log: v3: Introduced TRACE_EVENT_CONDITION() macro for checking the condition page

[PATCH v3 1/7] f2fs: add tracepoints for sync & Inode operations

2013-04-05 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints in f2fs for tracing the syncing operations like filesystem sync, file sync enter/exit. It will helf to trace the code under debugging scenarios. Also add tracepoints for tracing the various inode operations like building inode, eviction of inode, link/unlink of

[PATCH v3 2/7] f2fs: add tracepoints for truncate operation

2013-04-05 Thread Namjae Jeon
From: Namjae Jeon add tracepoints for tracing the truncate operations like truncate node/data blocks, f2fs_truncate etc. Tracepoints are added at entry and exit of operation to trace the success & failure of operation. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/

[PATCH v3 3/7] f2fs: add tracepoint for tracing the page i/o operations

2013-04-05 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints for page i/o operations and block allocation tracing during page read operation. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/data.c |9 ++- include/trace/events/f2fs.h | 61

[PATCH v3 4/7] f2fs: add tracepoints for GC threads

2013-04-05 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints for tracing the garbage collector threads in f2fs with status of collection & type. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/gc.c|2 ++ include/trace/events/f2fs.h | 20 2 files changed

[PATCH v3 5/7] f2fs: add tracepoints to debug the block allocation & fallocate

2013-04-05 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints to debug the block allocation & fallocate. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/data.c |1 + fs/f2fs/file.c |3 ++ include/trace/events/f2fs.h |

[PATCH v3 6/7] f2fs: add tracepoints for write page operations

2013-04-05 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints to debug the various page write operation like data pages, meta pages. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/checkpoint.c|2 ++ fs/f2fs/data.c |2 ++ include/trace/events/f2fs.h | 62

[PATCH v3 7/7] f2fs: add tracepoints to debug checkpoint request

2013-04-05 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints to debug checkpoint request. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/checkpoint.c|1 + include/trace/events/f2fs.h | 18 ++ 2 files changed, 19 insertions(+) diff --git a/fs/f2fs/checkpoint.c b/fs

Re: [PATCH v5 7/8] fat (exportfs): rebuild directory-inode if fat_dget() fails

2013-01-28 Thread Namjae Jeon
2013/1/28, OGAWA Hirofumi : > Namjae Jeon writes: > >>>> Although checking several routines to check hang case you said, I >>>> didn't find anything. >>>> And There is no any race on test result also. Am I missing something ? >>>> Let

[PATCH 1/3] f2fs: avoid redundant call to has_not_enough_free_secs in f2fs_gc

2013-01-30 Thread Namjae Jeon
From: Namjae Jeon After doing a write_checkpoint from garbage collection path if there is still need to do more garbage collection, gc_more label is used to jump and start the process again. And in that process, first step before getting victim is to check if there are not enough free sections

[PATCH 2/3] f2fs: reorganize code for ra_node_page

2013-01-30 Thread Namjae Jeon
From: Namjae Jeon We can remove unneeded label unlock_out, avoid unnecessary jump and reorganize the returning conditions in this function. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/node.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

[PATCH 3/3] f2fs: fix typo mistake for data_version description

2013-01-30 Thread Namjae Jeon
From: Namjae Jeon In f2fs_inode_info structure, the description for data_version has a typo mistake. It should be latest instead of lastes. So, correcting that. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/f2fs.h |2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 1/3] f2fs: avoid redundant call to has_not_enough_free_secs in f2fs_gc

2013-01-30 Thread Namjae Jeon
2013/1/31, Jaegeuk Kim : > 2013-01-30 (수), 22:47 +0900, Namjae Jeon: >> From: Namjae Jeon >> >> After doing a write_checkpoint from garbage collection path if there is >> still >> need to do more garbage collection, gc_more label is used to jump and >>

Re: [PATCH] udf: add extent cache support in case of file reading

2013-02-01 Thread Namjae Jeon
Hi. Jan. Sorry for interrupt. Have you taken this patch to your tree ? I can not find it.. or Is there any issue regarding this patch ? Thanks! 2013/1/22, Namjae Jeon : > 2013/1/22, Jan Kara : >> On Tue 22-01-13 09:45:09, Namjae Jeon wrote: >>> 2013/1/21, Jan Kara : >&g

[PATCH 1/6] f2fs: optimize get node page readahead part

2013-02-02 Thread Namjae Jeon
From: Namjae Jeon We can remove the call to find_get_page to get a page from the cache and check for up-to-date, instead we can make use of grab_cache_page part itself to fetch the page from the cache. So, removing the call and moving the PageUptodate at proper place, also taken care of moving

[PATCH 2/6] f2fs: move out f2fs_balance_fs from gc_thread_func

2013-02-02 Thread Namjae Jeon
From: Namjae Jeon When GC thread is running continously there is no need to call f2fs_balance_fs unconditinally for garbage collection, instead the garbage collection will be taken via. calling f2fs_gc in the thread. So, we can move out the balance out of thread loop and make it run initially

[PATCH 3/6] f2fs: name gc task as per the block device

2013-02-02 Thread Namjae Jeon
From: Namjae Jeon Currently GC task is started for each f2fs formatted/mounted device. But, when we check the task list, using 'ps', there is no distinguishing factor between the tasks. So, name the task as per the block device just like the flusher threads. Also, remove the macro GC_T

[PATCH 4/6] f2fs: mark gc_thread as NULL when thread creation failed

2013-02-02 Thread Namjae Jeon
From: Namjae Jeon When gc thread creatio failed, mark gc_thread as NULL to avoid crash while trying to stop invalid thread in stop_gc_thread->kthread_stop. Instead make it return from: if (!gc_th) return; Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/g

[PATCH 5/6] f2fs: make accessor to get sections for particular block type

2013-02-02 Thread Namjae Jeon
From: Namjae Jeon Introduce accessor to get the sections based upon the block type (node,dents...) and modify the functions : should_do_checkpoint, has_not_enough_free_secs to use this accessor function to get the node sections and dent sections. Signed-off-by: Namjae Jeon Signed-off-by: Amit

[PATCH 6/6] f2fs: optimize the return condition for has_not_enough_free_secs

2013-02-02 Thread Namjae Jeon
From: Namjae Jeon Instead of evaluating the free_sections and then deciding to return true/false from that path. We can directly use the evaluation condition for returning proper value. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/segment.h |6 ++ 1 file

Re: [PATCH v5 7/8] fat (exportfs): rebuild directory-inode if fat_dget() fails

2013-01-27 Thread Namjae Jeon
2013/1/26, OGAWA Hirofumi : > Namjae Jeon writes: > >> 2013/1/20, OGAWA Hirofumi : >>> Namjae Jeon writes: >>> >>>> We rewrite patch as your suggestion using dummy inode. Would please >>>> you review below patch code ? >>> >>

Re: [PATCH 1/2] f2fs: read with READ_SYNC when getting dnode page

2013-02-26 Thread Namjae Jeon
2013/2/26, Jaegeuk Kim : > It must be set READ_SYNC not READA. Hi Jaegeuk. Could you please elaborate more? Why we need to change READA to READ_SYNC over here, when the purpose was to read the node page in READ ahead mode. Thanks. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/node.c | 2 +- > 1

Re: [PATCH 2/2] f2fs: introduce readahead mode of node pages

2013-02-26 Thread Namjae Jeon
> @@ -434,7 +434,7 @@ int get_dnode_of_data(struct dnode_of_data *dn, pgoff_t > index, int ro) > alloc_nid_done(sbi, nids[i]); > mutex_unlock_op(sbi, NODE_NEW); > done = true; > - } else if (ro && i == level && level > 1)

Re: [PATCH 1/2] f2fs: read with READ_SYNC when getting dnode page

2013-02-26 Thread Namjae Jeon
2013/2/27, Jaegeuk Kim : > Hi, > > 2013-02-26 (화), 18:35 +0900, Namjae Jeon: >> 2013/2/26, Jaegeuk Kim : >> > It must be set READ_SYNC not READA. >> Hi Jaegeuk. >> Could you please elaborate more? >> Why we need to change READA to READ_SYNC over here, whe

Re: [PATCH 2/2] f2fs: introduce readahead mode of node pages

2013-02-26 Thread Namjae Jeon
2013/2/27, Jaegeuk Kim : > 2013-02-26 (화), 20:52 +0900, Namjae Jeon: >> > @@ -434,7 +434,7 @@ int get_dnode_of_data(struct dnode_of_data *dn, >> > pgoff_t >> > index, int ro) >> >alloc_nid_done(sbi, nids[i]); >> >

[PATCH 0/8] f2fs: Add tracepoints support in f2fs filesystem

2013-02-18 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints in f2fs filesystem for tracing the filesystem operations for information/debugging purpose if needed. All the tracepoints are clubbed with respect to functionalities. Namjae Jeon(8): f2fs: add tracepoints for sync operations f2fs: add tracepoints for

[PATCH 1/8] f2fs: add tracepoints for sync operations

2013-02-18 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints in f2fs for tracing the syncing operations like filesystem sync, file sync enter/exit. It will helf to trace the code under debugging scenarios. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/file.c |3 ++ fs/f2fs/super.c

[PATCH 3/8] f2fs: add tracepoints for truncate operation

2013-02-18 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints for tracing the truncate operations like truncate node/data blocks, f2fs_truncate etc. Tracepoints are added at entry and exit of operation to trace the success & failure of operation. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/

[PATCH 2/8] f2fs: add tracepoints for inode operations

2013-02-18 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints for tracing the various inode operations like building inode, eviction of inode, link/unlike of inodes. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/inode.c |3 ++ fs/f2fs/namei.c |3 ++ include/trace

[PATCH 4/8] f2fs: add tracepoint for tracing the page i/o operations

2013-02-18 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints for page i/o operations and block allocation tracing during page read operation. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/data.c | 10 ++- include/trace/events/f2fs.h | 68

[PATCH 5/8] f2fs: add tracepoints for GC threads

2013-02-18 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints for tracing the garbage collector threads in f2fs. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/gc.c|2 ++ include/trace/events/f2fs.h | 20 2 files changed, 22 insertions(+) diff --git a/fs

[PATCH 6/8] f2fs: add tracepoints to debug the block allocation and fallocate

2013-02-18 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints to debug the block allocation and fallocate. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/data.c |1 + fs/f2fs/file.c |3 ++ include/trace/events/f2fs.h | 76

[PATCH 7/8] f2fs: add tracepoints for write page operations

2013-02-18 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints to debug the various page write operation like data pages, meta pages. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/checkpoint.c|2 ++ fs/f2fs/data.c |2 ++ include/trace/events/f2fs.h | 62

[PATCH 8/8] f2fs: add tracepoints to debug checkpoint request

2013-02-18 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints to debug checkpoint request. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/checkpoint.c|1 + include/trace/events/f2fs.h | 18 ++ 2 files changed, 19 insertions(+) diff --git a/fs/f2fs/checkpoint.c b/fs

Re: [PATCH 2/8] f2fs: add tracepoints for inode operations

2013-02-19 Thread Namjae Jeon
2013/2/19 Steven Rostedt : > On Tue, 2013-02-19 at 11:33 +0900, Namjae Jeon wrote: >> From: Namjae Jeon > >> +TRACE_EVENT(f2fs_unlink_exit, >> + TP_PROTO(struct dentry *dentry, int ret), >> + >> + TP_ARGS(dentry, ret), >> + >> + TP_STR

Re: [PATCH v2] wait while adding MMC host to ensure root mounts

2013-03-13 Thread Namjae Jeon
2013/3/14, Sergey Yanovich : > MMC hosts are added asynchronously. We need to wait until detect returns to > avoid failed root filesystem mounts. > ---8<--- > VFS: Cannot open root device "mmcblk0p1" or unknown-block(0,0): error -6 > Please append a correct "root=" boot option; here are the availab

[PATCH 1/5] f2fs: notify when discard is not supported

2013-03-17 Thread Namjae Jeon
From: Namjae Jeon Change f2fs so that a warning is emitted when an attempt is made to mount a filesystem with the unsupported discard option. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/super.c |9 + 1 file changed, 9 insertions(+) diff --git a/fs/f2fs

[PATCH 2/5] f2fs: reorganize f2fs_setxattr

2013-03-17 Thread Namjae Jeon
From: Namjae Jeon make use of F2FS_NAME_LEN for name length checking, change return conditions at few places, by assigning storing the errorvalue in 'error' and making a common exit path. Signed-off-by: Namjae Jeon Signed-off-by: Amit Sahrawat --- fs/f2fs/xattr.c | 18 ++-

[PATCH 3/5] f2fs: fix return values from validate superblock

2013-03-17 Thread Namjae Jeon
From: Namjae Jeon validate super block is not returning with proper values. When failure from sb_bread it should reflect there is an EIO otherwise it should return of EINVAL. Returning, '1' is not conveying proper message as the return type. Signed-off-by: Namjae Jeon Signed-of

[PATCH 4/5] f2fs: remove nid_free from f2fs_new_inode

2013-03-17 Thread Namjae Jeon
From: Namjae Jeon we can remove nid_free from new inode allocation part. Since, nid_free is used to check if we need to free alloced nid in case of failure. Instead we can directly call alloc_nid_failed from that point, as there is no dependency in that path. Signed-off-by: Namjae Jeon Signed

[PATCH 5/5] f2fs: avoid BUG_ON from check_nid_range and update return path in do_read_inode

2013-03-17 Thread Namjae Jeon
From: Namjae Jeon In function check_nid_range, there is no need to trigger BUG_ON and make kernel stop. Instead it could just check and indicate the inode number to be EINVAL. Update the return path in do_read_inode to use the return from check_nid_range. Signed-off-by: Namjae Jeon Signed-off

[PATCH] [SCSI]: print the msgbytes and statusbyte from scsi result

2013-03-17 Thread Namjae Jeon
From: Namjae Jeon Introduce msgbyte and statusbyte in the prints as part of the result which is returned by the lower layer driver in response to SCSI command issued, in case of any error conditions. Purpose of adding these prints is to convey, during any I/O error case, which condition exactly

[PATCH v2 0/7] f2fs: Add tracepoints support in f2fs filesystem

2013-03-17 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints in f2fs filesystem for tracing the filesystem operations for information/debugging purpose if needed. All the tracepoints are clubbed with respect to functionalities. Namjae Jeon(7): f2fs: add tracepoints for sync operations and inode operations f2fs: add

[PATCH v2 2/7] f2fs: add tracepoints for truncate operation

2013-03-17 Thread Namjae Jeon
From: Namjae Jeon add tracepoints for tracing the truncate operations like truncate node/data blocks, f2fs_truncate etc. Tracepoints are added at entry and exit of operation to trace the success & failure of operation. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/

[PATCH v2 3/7] f2fs: add tracepoint for tracing the page i/o operations

2013-03-17 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints for page i/o operations and block allocation tracing during page read operation. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/data.c | 11 ++-- include/trace/events/f2fs.h | 58

[PATCH v2 1/7] f2fs: add tracepoints for sync and inode operations

2013-03-17 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints in f2fs for tracing the syncing operations like filesystem sync, file sync enter/exit. It will helf to trace the code under debugging scenarios. Also add tracepoints for tracing the various inode operations like building inode, eviction of inode, link/unlike of

[PATCH v2 7/7] f2fs: add tracepoints to debug checkpoint request

2013-03-17 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints to debug checkpoint request. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/checkpoint.c|1 + include/trace/events/f2fs.h | 18 ++ 2 files changed, 19 insertions(+) diff --git a/fs/f2fs/checkpoint.c b/fs

[PATCH v2 4/7] f2fs: add tracepoints for GC threads

2013-03-17 Thread Namjae Jeon
From: Namjae Jeon Add tracepoints for tracing the garbage collector threads in f2fs with status of collection & type. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar --- fs/f2fs/gc.c|2 ++ include/trace/events/f2fs.h | 20 2 files changed

  1   2   3   4   5   6   7   8   9   10   >