Re: [PATCH 5/5] fat: add mutex lock to fat_build_inode

2012-10-29 Thread Namjae Jeon
2012/10/30, Andrew Morton a...@linux-foundation.org: On Sun, 28 Oct 2012 10:53:43 +0900 Namjae Jeon linkinj...@gmail.com wrote: From: Namjae Jeon namjae.j...@samsung.com fat_nfs_get_inode does not hold i_mutex of parent directory.So add lock to fat_build_inode. Hi. Andrew. Well.. why

Re: [PATCH 1/5] fat: remove parent_logstart check in fat_get_parent

2012-10-30 Thread Namjae Jeon
2012/10/31, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: From: Namjae Jeon namjae.j...@samsung.com The root directory inode is added to the directory hash table in fat_attach when mounted with nfs option. Since root dentry never expires until umount

[PATCH] fs: notify: Fix race condition between umount and inotify_rm_watch

2012-11-01 Thread Namjae Jeon
. Signed-off-by: Namjae Jeon linkinj...@gmail.com Signed-off-by: Pankaj Kumar jangra.pank...@gmail.com --- fs/notify/inotify/inotify_user.c | 21 - fs/notify/mark.c |8 ++-- 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/fs/notify/inotify

Re: [PATCH] fs: notify: Fix race condition between umount and inotify_rm_watch

2012-11-02 Thread Namjae Jeon
2012/11/2, Al Viro v...@zeniv.linux.org.uk: On Fri, Nov 02, 2012 at 12:51:36AM +0900, Namjae Jeon wrote: When a user is monitoring an FS_UMOUNT watch using the inotify framework, there can be a potential race condition between the umount path inotify_rm_watch. This scenario can be like

Re: [PATCH v3 1/5] fat: modify nfs mount option

2012-09-23 Thread Namjae Jeon
2012/9/22, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: +case Opt_nfs_full: +opts-nfs = FAT_NFS_FULL; +break; +case Opt_nfs_limited: +opts-nfs = FAT_NFS_LIMITED

Re: [PATCH v3 2/5] fat: allocate persistent inode numbers

2012-09-23 Thread Namjae Jeon
2012/9/22, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: -inode-i_ino = iunique(sb, MSDOS_ROOT_INO); +if (MSDOS_SB(sb)-options.nfs == FAT_NFS_LIMITED) +inode-i_ino = i_pos; +else +inode-i_ino = iunique(sb

Re: [PATCH v3 3/5] fat (exportfs): rebuild inode if ilookup() fails

2012-09-23 Thread Namjae Jeon
2012/9/22, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: +if (inode == NULL MSDOS_SB(sb)-options.nfs == FAT_NFS_LIMITED) { +struct buffer_head *bh = NULL; +struct msdos_dir_entry *de ; +loff_t i_pos = (loff_t)ino

Re: [PATCH v3 4/5] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-09-23 Thread Namjae Jeon
2012/9/22, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: From: Namjae Jeon namjae.j...@samsung.com This patch enables rebuilding of directory inodes which are not present in the cache.This is done by traversing the disk clusters to find the directory

Re: [PATCH v3 2/5] fat: allocate persistent inode numbers

2012-09-23 Thread Namjae Jeon
2012/9/24, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: I think we don't need this. Because FH and ino is not necessary to have relation. Can we re-introduce -encode_fh() handler, and export i_pos again? With this, I think we can get i_pos correctly

Re: [PATCH v3 2/5] fat: allocate persistent inode numbers

2012-09-24 Thread Namjae Jeon
2012/9/24, OGAWA Hirofumi hirof...@mail.parknet.co.jp: OGAWA Hirofumi hirof...@mail.parknet.co.jp writes: Namjae Jeon linkinj...@gmail.com writes: What is problem if i_ino + i_generation is not match? I think, even if those didn't match, i_pos in FH should resolve issue, no? No, It can

Re: [PATCH v3 2/5] fat: allocate persistent inode numbers

2012-09-24 Thread Namjae Jeon
2012/9/24, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: This means - which code returns error? Sorry, My explanation may be insufficient. nfs_update_inode()- on NFS client if ((fattr-valid NFS_ATTR_FATTR_FILEID) nfsi-fileid != fattr-fileid

Re: [PATCH v3 2/5] fat: allocate persistent inode numbers

2012-09-24 Thread Namjae Jeon
2012/9/24, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: I see. fileid seems to be stat.ino on nfsd4. inode-i_ino is actually just a hash key of inode hash (exception is only in audit, iirc). So, what happens if we set stat-ino = i_pos on fat_getattr

Re: [PATCH v3 2/5] fat: allocate persistent inode numbers

2012-09-24 Thread Namjae Jeon
2012/9/24, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: 2012/9/24, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: I see. fileid seems to be stat.ino on nfsd4. inode-i_ino is actually just a hash key of inode hash

Re: [PATCH v3 2/5] fat: allocate persistent inode numbers

2012-09-24 Thread Namjae Jeon
Hi OGAWA. It works fine. there is no estale error while memory reclaim. I will make patchset again as review comment and your suggestion (encode_fh, fat_getattr). Thanks! 2012/9/25, J. Bruce Fields bfie...@fieldses.org: On Tue, Sep 25, 2012 at 01:16:45AM +0900, OGAWA Hirofumi wrote: J. Bruce

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-25 Thread Namjae Jeon
. Thanks, Fengguang On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: From: Namjae Jeon namjae.j...@samsung.com This patch is based on suggestion by Wu Fengguang: https://lkml.org/lkml/2011/8/19/19 kernel has mechanism to do writeback as per dirty_ratio and dirty_background

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-25 Thread Namjae Jeon
2012/9/25, Jan Kara j...@suse.cz: On Thu 20-09-12 16:44:22, Wu Fengguang wrote: On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: From: Namjae Jeon namjae.j...@samsung.com This patch is based on suggestion by Wu Fengguang: https://lkml.org/lkml/2011/8/19/19 kernel has

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-25 Thread Namjae Jeon
2012/9/25, Namjae Jeon linkinj...@gmail.com: 2012/9/25, Dave Chinner da...@fromorbit.com: On Thu, Sep 20, 2012 at 04:44:22PM +0800, Fengguang Wu wrote: [ CC FS and MM lists ] Patch looks good to me, however we need to be careful because it's introducing a new interface. So it's desirable

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-27 Thread Namjae Jeon
2012/9/27, Jan Kara j...@suse.cz: On Thu 27-09-12 00:56:02, Wu Fengguang wrote: On Tue, Sep 25, 2012 at 12:23:06AM +0200, Jan Kara wrote: On Thu 20-09-12 16:44:22, Wu Fengguang wrote: On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: From: Namjae Jeon namjae.j...@samsung.com

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-27 Thread Namjae Jeon
2012/9/27, Jan Kara j...@suse.cz: On Thu 27-09-12 15:00:18, Namjae Jeon wrote: 2012/9/27, Jan Kara j...@suse.cz: On Thu 27-09-12 00:56:02, Wu Fengguang wrote: On Tue, Sep 25, 2012 at 12:23:06AM +0200, Jan Kara wrote: On Thu 20-09-12 16:44:22, Wu Fengguang wrote: On Sun, Sep 16, 2012

[PATCH v4 0/4] fat: fix estale error on VFAT over NFS.

2012-10-07 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com This patch-set eliminates the client side ESTALE errors when a FAT partition exported over NFS has its dentries evicted from the cache. One of the reasons for this error is lack of permanent inode numbers on FAT which makes it difficult to construct

[PATCH v4 1/4] fat: modify nfs mount option

2012-10-07 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Provide two possible values 'stale_rw' and 'nostale_ro' for the -o nfs mount option.The first one allows all file operations but does not reduce ESTALE errors on memory constrained systems. The second one eliminates ESTALE errors but mounts the filesystem

[PATCH v4 2/4] fat (exportfs): rebuild inode if ilookup() fails

2012-10-07 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Assign i_pos to kstat-ino and re-introduce fat_encode_fh() and include i_pos value in the file handle.Use the i_pos value to find the directory entry of the inode and subsequently rebuild the inode if the cache lookups fail. Since this involves accessing

[PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-07 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com This patch enables rebuilding of directory inodes which are not present in the cache.This is done by traversing the disk clusters to find the directory entry of the parent directory and using its i_pos to build the inode. Signed-off-by: Namjae Jeon

[PATCH v4 4/4] Documentation: update nfs option in filesystem/vfat.txt

2012-10-07 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com update nfs option in filesystem/vfat.txt Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Ravishankar N ravi...@samsung.com Signed-off-by: Amit Sahrawat a.sahra...@samsung.com --- Documentation/filesystems/vfat.txt | 23

[PATCH RESEND] writeback: change nr_pages_dirtied argument into local variable

2012-10-07 Thread Namjae Jeon
There is no reason nr_pages_dirtied is argument anymore. because nr_pages_dirtied value from caller is not used in balance_dirty_pages_ratelimited_nr function. Signed-off-by: Namjae Jeon linkinj...@gmail.com Signed-off-by: Vivek Trivedi vtrivedi...@gmail.com --- fs/btrfs/disk-io.c|8

Re: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-08 Thread Namjae Jeon
2012/10/8, Jaegeuk Kim jaegeuk@samsung.com: -Original Message- From: Vyacheslav Dubeyko [mailto:sl...@dubeyko.com] Sent: Sunday, October 07, 2012 9:09 PM To: Jaegeuk Kim Cc: 'Marco Stornelli'; 'Jaegeuk Kim'; 'Al Viro'; ty...@mit.edu; gre...@linuxfoundation.org; linux-

Re: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-08 Thread Namjae Jeon
2012/10/8, Jaegeuk Kim jaegeuk@samsung.com: -Original Message- From: Namjae Jeon [mailto:linkinj...@gmail.com] Sent: Monday, October 08, 2012 7:00 PM To: Jaegeuk Kim Cc: Vyacheslav Dubeyko; Marco Stornelli; Jaegeuk Kim; Al Viro; ty...@mit.edu; gre...@linuxfoundation.org; linux

[PATCH 1/3] fat: use s_blocksize_bits where SECTOR SIZE alignment is needed

2012-11-02 Thread Namjae Jeon
Currently there is hard-coding at various places in FAT for using the SECTOR size alignment. So, In order to remove the hard coding we need to change the usage of '9' in FAT code. Signed-off-by: Namjae Jeon linkinj...@gmail.com Signed-off-by: Amit Sahrawat amit.sahrawa...@gmail.com --- fs/fat

[PATCH 2/3] fat: notify when discard is not supported

2012-11-02 Thread Namjae Jeon
FAT also notify warning message about discard support as ext4(http://patchwork.ozlabs.org/patch/192668/) Signed-off-by: Namjae Jeon linkinj...@gmail.com Signed-off-by: Amit Sahrawat amit.sahrawa...@gmail.com --- fs/fat/inode.c |8 1 file changed, 8 insertions(+) diff --git a/fs/fat

[PATCH 3/3] fat: warn when discard request fails other than EOPNOTSUPP

2012-11-02 Thread Namjae Jeon
FAT also warn user then the discard request fails as ext4(http://patchwork.ozlabs.org/patch/192669/) Signed-off-by: Namjae Jeon linkinj...@gmail.com Signed-off-by: Amit Sahrawat amit.sahrawa...@gmail.com --- fs/fat/fatent.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions

[PATCH v2 1/3] fat: use s_blocksize_bits where SECTOR SIZE alignment is needed

2012-11-03 Thread Namjae Jeon
Currently there is hard-coding at various places in FAT for using the SECTOR size alignment. So, In order to remove the hard coding we need to change the usage of '9' in FAT code. Signed-off-by: Namjae Jeon linkinj...@gmail.com Signed-off-by: Amit Sahrawat amit.sahrawa...@gmail.com --- fs/fat

[PATCH v2 2/3] fat: notify when discard is not supported

2012-11-03 Thread Namjae Jeon
FAT also notify warning message about discard support as ext4(http://patchwork.ozlabs.org/patch/192668/) Signed-off-by: Namjae Jeon linkinj...@gmail.com Signed-off-by: Amit Sahrawat amit.sahrawa...@gmail.com --- fs/fat/inode.c |9 + 1 file changed, 9 insertions(+) diff --git a/fs

[PATCH v2 3/3] fat: warn when discard request fails other than EOPNOTSUPP

2012-11-03 Thread Namjae Jeon
FAT also warn user then the discard request fails as ext4(http://patchwork.ozlabs.org/patch/192669/) Signed-off-by: Namjae Jeon linkinj...@gmail.com Signed-off-by: Amit Sahrawat amit.sahrawa...@gmail.com --- fs/fat/fatent.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions

Re: [PATCH 1/5] fat: remove parent_logstart check in fat_get_parent

2012-11-05 Thread Namjae Jeon
2012/11/5, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: +blknr = fat_clus_to_blknr(sbi, parent_logstart); +parent_bh = sb_bread(sb, blknr); +if (!parent_bh) { +fat_msg(sb, KERN_ERR

Re: NULL pointer dereference at fat_detach

2012-11-05 Thread Namjae Jeon
2012/10/31, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Paul Bolle pebo...@tiscali.nl writes: On Wed, 2012-10-31 at 09:49 +0900, OGAWA Hirofumi wrote: This bug is known as the inotify bug. I recall I talked about this, maybe years ago. Would that be this thread:

Re: [PATCH 5/6] udf: implement extent caching while reading-writing to a file

2012-10-18 Thread Namjae Jeon
2012/10/19, Jan Kara j...@suse.cz: Hello, On Wed 10-10-12 00:10:01, Namjae Jeon wrote: From: Namjae Jeon namjae.j...@samsung.com This patch implements extent caching. Instead of reading metadata everytime from file's starting position, now we read from the cached extent. This speeds up

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-10-19 Thread Namjae Jeon
Hi Dave. Test Procedure: 1) Local USB disk WRITE speed on NFS server is ~25 MB/s 2) Run WRITE test(create 1 GB file) on NFS Client with default writeback settings on NFS Server. By default bdi-dirty_background_bytes = 0, that means no change in default writeback behaviour 3) Next we change

Re: [PATCH v2] fat: editions to support fat_fallocate()

2012-10-22 Thread Namjae Jeon
2012/10/22, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: The expectation of fallocate() is just for space reservation? If it was just for space reservation, I'm not sure, why TV applications can't reserve in userland without any kernel help (I wonder

Re: [PATCH v2] fat: editions to support fat_fallocate()

2012-10-23 Thread Namjae Jeon
2012/10/23, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: Does this break the linux fat driver doesn't know about this fallocate()? If so, it sounds like to be easy to break existent drivers. Yes, it will break linux drivers without fallocate support

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-23 Thread Namjae Jeon
2012/10/13, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: +if (!fat_get_dotdot_entry(child_dir-d_inode, dotdot_bh, de)) { +parent_logstart = fat_get_start(sbi, de); parent_inode = fat_dget(sb, parent_logstart

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-23 Thread Namjae Jeon
2012/10/23, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: And this is doing same thing with readdir, so we will have to clean this up as I said before. When I checked, I didn't understand about same thing readdir and this function yet. Because even

Re: [PATCH v4 4/4] Documentation: update nfs option in filesystem/vfat.txt

2012-10-08 Thread Namjae Jeon
2012/10/9, J. Bruce Fields bfie...@fieldses.org: On Sun, Oct 07, 2012 at 04:33:02AM -0400, Namjae Jeon wrote: From: Namjae Jeon namjae.j...@samsung.com update nfs option in filesystem/vfat.txt Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Ravishankar N ravi

Re: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-08 Thread Namjae Jeon
2012/10/8, Jaegeuk Kim jaegeuk@samsung.com: -Original Message- From: Namjae Jeon [mailto:linkinj...@gmail.com] Sent: Monday, October 08, 2012 8:22 PM To: Jaegeuk Kim Cc: Vyacheslav Dubeyko; Marco Stornelli; Jaegeuk Kim; Al Viro; ty...@mit.edu; gre...@linuxfoundation.org; linux

[PATCH 0/6] udf: Extent cache and bunch of cleanups and other patches

2012-10-09 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com This patchset implements extent caching in UDF. While reading/writing to a file, currently, UDF reads metadata serially which takes a lot of time depending on the number of extents present in the file. Caching last accessd extent improves metadata read

[PATCH 1/6] udf: fix memory leak while allocating blocks during write

2012-10-09 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Need to brelse the buffer_head stored in cur_epos and next_epos. Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Ashish Sangwan a.sang...@samsung.com --- fs/udf/inode.c |4 1 file changed, 4 insertions(+) diff --git a/fs/udf

[PATCH 2/6] udf: don't increment lenExtents while writing to a hole

2012-10-09 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Incrementing lenExtents even while writing to a hole is bad for performance as calls to udf_discard_prealloc and udf_truncate_tail_extent would not return from start if isize != lenExtents Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off

[PATCH 3/6] udf: update inode's iblock count when allocating new block

2012-10-09 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Currently, du will show wrong block count. This patch fix it. Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Ashish Sangwan a.sang...@samsung.com --- fs/udf/inode.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/udf

[PATCH 4/6] udf: remove un-needed variable from inode_getblk

2012-10-09 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com The variable last_block is not needed. Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Ashish Sangwan a.sang...@samsung.com --- fs/udf/inode.c |3 --- 1 file changed, 3 deletions(-) diff --git a/fs/udf/inode.c b/fs/udf/inode.c

[PATCH 5/6] udf: implement extent caching while reading-writing to a file

2012-10-09 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com This patch implements extent caching. Instead of reading metadata everytime from file's starting position, now we read from the cached extent. This speeds up the transformation of file logical offsets to corresponding on-disk blocks. Signed-off

[PATCH 6/6] udf: use extent cache when moving to last extent

2012-10-09 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Use extent cache when moving to last extent. Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Ashish Sangwan a.sang...@samsung.com --- fs/udf/truncate.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/udf

Re: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-10 Thread Namjae Jeon
2012/10/10 Jaegeuk Kim jaegeuk@samsung.com: I mean that every volume is placed inside any partition (MTD or GPT). Every partition begins from any physical sector. So, as I can understand, f2fs volume can begin from physical sector that is laid inside physical erase block. Thereby, in

Re: + fat-exportfs-rebuild-inode-if-ilookup-fails-fix.patch added to -mm tree

2012-10-12 Thread Namjae Jeon
: Namjae Jeon namjae.j...@samsung.com Cc: OGAWA Hirofumi hirof...@mail.parknet.co.jp Cc: Ravishankar N ravi...@samsung.com Signed-off-by: Andrew Morton a...@linux-foundation.org --- fs/fat/inode.c |3 ++- fs/fat/nfs.c |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff -puN

Re: [PATCH 3/6] udf: update inode's iblock count when allocating new block

2012-10-12 Thread Namjae Jeon
2012/10/12 Jan Kara j...@suse.cz: On Wed 10-10-12 00:09:28, Namjae Jeon wrote: From: Namjae Jeon namjae.j...@samsung.com Currently, du will show wrong block count. This patch fix it. This should be fixed by commit fd4287dbc07763595c1e74edbb6520092290185c. Have you tested with newish kernel

Re: [PATCH v4 2/4] fat (exportfs): rebuild inode if ilookup() fails

2012-10-13 Thread Namjae Jeon
Hi. OGAWA. 2012/10/13 OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: --- a/fs/fat/fat.h +++ b/fs/fat/fat.h @@ -214,6 +214,13 @@ static inline sector_t fat_clus_to_blknr(struct msdos_sb_info *sbi, int clus) + sbi-data_start; } +static

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-13 Thread Namjae Jeon
2012/10/13 OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: + if (!fat_get_dotdot_entry(child_dir-d_inode, dotdot_bh, de)) { + parent_logstart = fat_get_start(sbi, de); parent_inode = fat_dget(sb, parent_logstart

[PATCH v2] fat: editions to support fat_fallocate()

2012-10-13 Thread Namjae Jeon
for the partition which can be seen from the Volume properties. The windows chkdsk tool also does not report any errors on a disk containing files with preallocated space. Signed-off-by: Namjae Jeon linkinj...@gmail.com Signed-off-by: Ravishankar N cybera...@gmail.com Signed-off-by: Amit Sahrawat amit.sahrawa

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-13 Thread Namjae Jeon
2012/10/13 OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: 2012/10/13 OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: + if (!fat_get_dotdot_entry(child_dir-d_inode, dotdot_bh, de)) { + parent_logstart

Re: [PATCH, RFC] Ext4: Mount partition as read only if during orphan cleanup truncate fails to obtain journal handle.

2012-10-26 Thread Namjae Jeon
the partition is mounted as read only. Failure to obtain journal handle during mount may suggest that journal device is corrupted. Signed-off-by: Ashish Sangwan ashish.sangw...@gmail.com Signed-off-by: Namjae Jeon linkinj...@gmail.com --- fs/ext4/super.c | 16 +++- 1 file changed, 15

Re: [PATCH, RFC] Ext3: Mount partition as read only if during orphan cleanup truncate fails to obtain journal handle.

2012-10-26 Thread Namjae Jeon
the partition is mounted as read only. Failure to obtain journal handle during mount may suggest that journal device is corrupted. Signed-off-by: Ashish Sangwan ashish.sangw...@gmail.com Signed-off-by: Namjae Jeon linkinj...@gmail.com --- fs/ext3/super.c | 17 - 1 file changed

[PATCH 1/6] fat: remove parent_logstart check in fat_get_parent

2012-10-27 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com The root directory inode is added to the directory hash table in fat_attach when mounted with nfs option. Since root dentry never expires until umount, fat_dget never fails to return the root inode for subdirectories of root inode.i.e., parent_logstart

[PATCH 2/6] fat: restructure export operations

2012-10-27 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Define two nfs export_operation structures,one for 'stale_rw' mounts and the other for 'nostale_ro'.The former uses the generic export_encode_fh function to encode file handle, while the latter uses fat_encode_fh. Since inode number is not needed

[PATCH 3/6] fat: move fat_i_pos_read to fat.h

2012-10-27 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Originally, fat_i_pos_read was a static inline function in inode.c. The static keyword was removed so that it could be accessed from other files. However it is better to make it a static inline function in fat.h as suggested by Ogawa. Signed-off

[PATCH 4/6] fat: (exportfs) move code to rebuild directory-inode to separate function

2012-10-27 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Move the logic to rebuild directory inode (when mounted with nostale_ro) to new function fat_rebuild_parent Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Ravishankar N ravi...@samsung.com Signed-off-by: Amit Sahrawat a.sahra

[PATCH 5/6] fat: add mutex lock to fat_build_inode

2012-10-27 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com fat_nfs_get_inode does not hold i_mutex of parent directory.So add lock to fat_build_inode. Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Ravishankar N ravi...@samsung.com Signed-off-by: Amit Sahrawat a.sahra...@samsung.com --- fs

[PATCH 1/5] fat: remove parent_logstart check in fat_get_parent

2012-10-27 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com The root directory inode is added to the directory hash table in fat_attach when mounted with nfs option. Since root dentry never expires until umount, fat_dget never fails to return the root inode for subdirectories of root inode.i.e., parent_logstart

[PATCH 2/5] fat: restructure export operations

2012-10-27 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Define two nfs export_operation structures,one for 'stale_rw' mounts and the other for 'nostale_ro'.The former uses the generic export_encode_fh function to encode file handle, while the latter uses fat_encode_fh. Since inode number is not needed

[PATCH 3/5] fat: move fat_i_pos_read to fat.h

2012-10-27 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Originally, fat_i_pos_read was a static inline function in inode.c. The static keyword was removed so that it could be accessed from other files. However it is better to make it a static inline function in fat.h as suggested by Ogawa. Signed-off

[PATCH 4/5] fat: (exportfs) move code to rebuild directory-inode to separate function

2012-10-27 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Move the logic to rebuild directory inode (when mounted with nostale_ro) to new function fat_rebuild_parent Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Ravishankar N ravi...@samsung.com Signed-off-by: Amit Sahrawat a.sahra

[PATCH 5/5] fat: add mutex lock to fat_build_inode

2012-10-27 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com fat_nfs_get_inode does not hold i_mutex of parent directory.So add lock to fat_build_inode. Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Ravishankar N ravi...@samsung.com Signed-off-by: Amit Sahrawat a.sahra...@samsung.com --- fs

Re: [PATCH v2 1/3] fat: use s_blocksize_bits where SECTOR SIZE alignment is needed

2012-11-11 Thread Namjae Jeon
2012/11/5 OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: Currently there is hard-coding at various places in FAT for using the SECTOR size alignment. So, In order to remove the hard coding we need to change the usage of '9' in FAT code. NACK. 512

Re: [PATCH v2 3/3] fat: warn when discard request fails other than EOPNOTSUPP

2012-11-11 Thread Namjae Jeon
2012/11/5 OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: FAT also warn user then the discard request fails as ext4(http://patchwork.ozlabs.org/patch/192669/) Why don't we do this at block layer like normal bio? Yes, maybe it will be better than doing

[PATCH RESEND 1/3] fat: notify when discard is not supported

2012-11-11 Thread Namjae Jeon
FAT also notify warning message about discard support as ext4(http://patchwork.ozlabs.org/patch/192668/) Signed-off-by: Namjae Jeon linkinj...@gmail.com Signed-off-by: Amit Sahrawat amit.sahrawa...@gmail.com Acked-by: OGAWA Hirofumi hirof...@mail.parknet.co.jp --- fs/fat/inode.c |9

[PATCH 2/3] fat: fix time updates for create and delete

2012-11-11 Thread Namjae Jeon
Correctly update modification and status change time in case of file/directory removal and creation. Signed-off-by: Namjae Jeon linkinj...@gmail.com Signed-off-by: Amit Sahrawat amit.sahrawa...@gmail.com --- fs/fat/dir.c|2 +- fs/fat/namei_vfat.c |6 +++--- 2 files changed, 4

[PATCH 3/3] fat: remove unneeded compare condition for __fat_write_inode

2012-11-11 Thread Namjae Jeon
In calling of __fat_write_inode(inode, wbc-sync_mode == WB_SYNC_ALL), expression wbc-sync_mode == WB_SYNC_ALL will always be equivalent to value of wbc-sync_mode. So, remove this additional compare condition from function arguments. Signed-off-by: Namjae Jeon linkinj...@gmail.com Signed-off

Re: [PATCH 2/3] fat: fix time updates for create and delete

2012-11-11 Thread Namjae Jeon
2012/11/12, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: Correctly update modification and status change time in case of file/directory removal and creation. This changelog just explain what, and it doesn't explain why. Please explain why we need

Re: [PATCH 2/3] fat: fix time updates for create and delete

2012-11-12 Thread Namjae Jeon
2012/11/12, OGAWA Hirofumi hirof...@mail.parknet.co.jp: OGAWA Hirofumi hirof...@mail.parknet.co.jp writes: Namjae Jeon linkinj...@gmail.com writes: 2012/11/12, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: Correctly update modification and status

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-15 Thread Namjae Jeon
2012/10/14, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: + if (!fat_get_dotdot_entry(child_dir-d_inode, dotdot_bh, de)) { + parent_logstart = fat_get_start(sbi, de); parent_inode = fat_dget(sb, parent_logstart

Re: [PATCH v4 3/4] fat (exportfs): rebuild directory-inode if fat_dget() fails

2012-10-15 Thread Namjae Jeon
2012/10/15 OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: OK, I think I got where is wrong. If it is the subdir of rootdir, fat_dget() should get the inode of root? That is correct. Whenever fat_dget() is called for sub-directories which is in root

Re: [PATCH v2] fat: editions to support fat_fallocate()

2012-10-15 Thread Namjae Jeon
2012/10/15 OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: Implement preallocation via the fallocate syscall on VFAT partitions. This patch is based on an earlier patch of the same name which had some issues detailed below and did not get accepted. Refer

Re: Initial report on F2FS filesystem performance

2012-10-16 Thread Namjae Jeon
Hello. Would you share the result about random read ? Thanks. 2012/10/16, Sooman Jeong 77sm...@hanyang.ac.kr: This is a brief summary of our initial filesystem performance study of f2fs against existing two filesystems in linux: EXT4, NILFS2, and f2fs. * test platform  i) Desktop PC :

Re: [PATCH v2] fat: editions to support fat_fallocate()

2012-10-17 Thread Namjae Jeon
2012/10/16, OGAWA Hirofumi hirof...@mail.parknet.co.jp: Namjae Jeon linkinj...@gmail.com writes: What is real usage pattern of persistent across remounts on FAT? Yes, like a TORRENT FILE - it reserves space in advance even though the system can be rebooted/disk unmounted and remount

Re: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-17 Thread Namjae Jeon
2012/10/13, Jaegeuk Kim jaegeuk@gmail.com: 2012-10-13 (토), 13:26 +0900, Namjae Jeon: Is there high possibility that the storage device can be rapidly worn-out by cleaning process ? e.g. severe fragmentation situation by creating and removing small files. Yes, the cleaning process

Re: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-17 Thread Namjae Jeon
2012/10/11, Changman Lee cm224@gmail.com: 2012년 10월 11일 목요일에 Namjae Jeonlinkinj...@gmail.com님이 작성: 2012/10/10 Jaegeuk Kim jaegeuk@samsung.com: I mean that every volume is placed inside any partition (MTD or GPT). Every partition begins from any physical sector. So, as I can

Re: [PATCH V2 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-07-16 Thread Namjae Jeon
Hi Vinayak. + * ufshcd_pltfrm_remove - remove platform driver routine + * @pdev: pointer to platform device handle + * + * Returns 0 on success, non-zero value on failure + */ +static int __devexit ufshcd_pltfrm_remove(struct platform_device *pdev) +{ + struct resource *mem_res; +

Re: [PATCH V2 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd

2012-07-19 Thread Namjae Jeon
2012/7/17 vinayak holikatti vinholika...@gmail.com: On Mon, Jul 16, 2012 at 7:19 PM, Namjae Jeon linkinj...@gmail.com wrote: Hi Vinayak. + * ufshcd_pltfrm_remove - remove platform driver routine + * @pdev: pointer to platform device handle + * + * Returns 0 on success, non-zero value

Re: [PATCH 2/8] mmc: fix max_discard_sectors

2013-04-15 Thread Namjae Jeon
2013/4/15, Adrian Hunter adrian.hun...@intel.com: On 13/04/13 16:38, Namjae Jeon wrote: From: Namjae Jeon namjae.j...@samsung.com https://lkml.org/lkml/2013/4/1/292 As per above discussion, there is possibility that request's __data_len field may overflow when max_discard_sectors greater

[PATCH v5] fat: editions to support fat_fallocate

2013-04-18 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Implement preallocation via the fallocate syscall on VFAT partitions. Change Log: v5: change to avoid compilation warning: fs/fat/inode.c: In function 'fat_zero_falloc_area': fs/fat/inode.c:169:11: warning: comparison of distinct pointer types lacks

[PATCH 1/2] f2fs: make is_multimedia_file code align with its name

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com The code conditions put inside the function is_multimedia_file are reverse to the name i.e, we need to negate the return to actually check if the file is a multimedia file. So, change the code and usage path to align both the name and comparision

[PATCH 2/2] f2fs: add REQ_META about metadata requests for submit bio

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Adding REQ_META for all the metadata requests can help in improving the FS performance, if the underlying device supports TAGGING. So, when considering the submit_bio path for all the f2fs requests. We can add REQ_META for all the META requests

[PATCH v4 0/7] f2fs: Add tracepoints support in f2fs filesystem

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Add tracepoints in f2fs filesystem for tracing the filesystem operations for information/debugging purpose if needed. All the tracepoints are clubbed with respect to functionalities. Change Log: v4: Modified the tracepoints as per the review comments

[PATCH v4 1/7] f2fs: add tracepoints for sync Inode operations

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Add tracepoints in f2fs for tracing the syncing operations like filesystem sync, file sync enter/exit. It will helf to trace the code under debugging scenarios. Also add tracepoints for tracing the various inode operations like building inode, eviction

[PATCH v4 2/7] f2fs: add tracepoints for truncate operation

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com add tracepoints for tracing the truncate operations like truncate node/data blocks, f2fs_truncate etc. Tracepoints are added at entry and exit of operation to trace the success failure of operation. Signed-off-by: Namjae Jeon namjae.j...@samsung.com

[PATCH v4 3/7] f2fs: add tracepoint for tracing the page i/o operations

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Add tracepoints for page i/o operations and block allocation tracing during page read operation. Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Pankaj Kumar pankaj...@samsung.com Acked-by: Steven Rostedt rost...@goodmis.org --- fs

[PATCH v4 4/7] f2fs: add tracepoints for GC threads

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Add tracepoints for tracing the garbage collector threads in f2fs with status of collection type. Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Pankaj Kumar pankaj...@samsung.com Acked-by: Steven Rostedt rost...@goodmis.org --- fs

[PATCH v4 5/7] f2fs: add tracepoints to debug the block allocation fallocate

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Add tracepoints to debug the block allocation fallocate. Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Pankaj Kumar pankaj...@samsung.com Acked-by: Steven Rostedt rost...@goodmis.org --- fs/f2fs/data.c |1 + fs/f2fs

[PATCH v4 7/7] f2fs: add tracepoints to debug checkpoint request

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Add tracepoints to debug checkpoint request. Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Pankaj Kumar pankaj...@samsung.com Acked-by: Steven Rostedt rost...@goodmis.org --- fs/f2fs/checkpoint.c|4 include/trace

[PATCH v4 6/7] f2fs: add tracepoints for write page operations

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com Add tracepoints to debug the various page write operation like data pages, meta pages. Signed-off-by: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Pankaj Kumar pankaj...@samsung.com Acked-by: Steven Rostedt rost...@goodmis.org --- fs/f2fs

[PATCH v2 0/9] fix max discard sectors limit

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9 (block: add plug for blkdev_issue_discard ) For example, 1) DISCARD rq-1 with size size 4GB 2) DISCARD rq-2 with size size 1GB

[PATCH v2 1/9] block: fix max discard sectors limit

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com https://lkml.org/lkml/2013/4/1/292 As per above discussion, it has been oberved that few drivers are setting q-limits.max_discard_sectors to more than (UINT_MAX 9) If multiple discard requests get merged, merged discard request's size exceeds 4GB

[PATCH v2 2/9] mmc: fix max_discard_sectors

2013-04-19 Thread Namjae Jeon
From: Namjae Jeon namjae.j...@samsung.com https://lkml.org/lkml/2013/4/1/292 As per above discussion, there is possibility that request's __data_len field may overflow when max_discard_sectors greater than UINT_MAX 9 If multiple discard requests get merged, merged discard request's size exceeds

  1   2   3   4   5   6   7   8   9   >