Re: PROBLEM: IPv6 TCP-Connections resetting

2013-04-05 Thread Neal Cardwell
On Fri, Apr 5, 2013 at 11:48 AM, Tetja Rediske wrote: > I tracked it down with 'git bisect' to commit: > > 093d04d42fa094f6740bb188f0ad0c215ff61e2c ... Thanks for the detailed report! > 11:52:04.634656 IP6 fe80::92e2:baff:fe00:c120 > 2a00:1828:1000:1102::2: > ICMP6, redirect, 2a00:1828:0:1::1

Re: BUG: unable to handle kernel paging request at 00010016

2012-08-21 Thread Neal Cardwell
On Mon, Aug 20, 2012 at 8:05 PM, Dave Haywood wrote: > Bisected to: > > 5d299f3d3c8a2fbc732b1bf03af36333ccec3130 is the first bad commit > > commit 5d299f3d3c8a2fbc732b1bf03af36333ccec3130 > > Author: Eric Dumazet > > Date: Mon Aug 6 05:09:33 2012 + > > net: ipv6: fix TCP early demux Y

Re: [PATCH] tun: don't zeroize sock->file on detach

2012-08-21 Thread Neal Cardwell
On Tue, Aug 21, 2012 at 12:04 PM, Stanislav Kinsbursky wrote: > 10.08.2012 03:16, David Miller пишет: > >> From: Stanislav Kinsbursky >> Date: Thu, 09 Aug 2012 16:50:40 +0400 >> >>> This is a fix for bug, introduced in 3.4 kernel by commit >>> 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, amon

Re: [PATCH net-next] tcp: add ability to set a timestamp offset

2013-01-22 Thread Neal Cardwell
On Tue, Jan 22, 2013 at 3:52 PM, Andrey Vagin wrote: > If a TCP socket will get live-migrated from one box to another the > timestamps (which are typically ON) will get screwed up -- the new > kernel will generate TS values that has nothing to do with what they > were on dump. The solution is to y

Re: 3.8-rc2/rc3 write() blocked on CLOSE_WAIT TCP socket

2013-01-10 Thread Neal Cardwell
CK flag > set) added a regression on the handling of RST messages. > > RST should be allowed to come even without ACK bit set. We validate > the RST by checking the exact sequence, as requested by RFC 793 and > 5961 3.2, in tcp_validate_incoming() > > Reported-by: Eric Wong

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-10-26 Thread Neal Cardwell
On Fri, Oct 23, 2015 at 4:50 PM, Bendik Rønning Opstad wrote: >@@ -2409,6 +2412,15 @@ static int do_tcp_setsockopt(struct sock *sk, int level, ... > + case TCP_RDB: > + if (val < 0 || val > 1) { > + err = -EINVAL; > + } else { > +

Re: [tcp] 9d9b1ee0b2: packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4-mapped-v6.fail

2021-02-19 Thread Neal Cardwell
On Thu, Feb 18, 2021 at 8:33 PM kernel test robot wrote: > > > Greeting, > > FYI, we noticed the following commit (built with gcc-9): > > commit: 9d9b1ee0b2d1c9e02b2338c4a4b0a062d2d3edac ("tcp: fix TCP_USER_TIMEOUT > with zero window") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux

Re: [PATCH] Revert "tcp: simplify window probe aborting on USER_TIMEOUT"

2021-01-11 Thread Neal Cardwell
On Fri, Jan 8, 2021 at 11:38 PM Enke Chen wrote: > > From: Enke Chen > > This reverts commit 9721e709fa68ef9b860c322b474cfbd1f8285b0f. > > With the commit 9721e709fa68 ("tcp: simplify window probe aborting > on USER_TIMEOUT"), the TCP session does not terminate with > TCP_USER_TIMEOUT when data r

Re: [PATCH net] tcp: make TCP_USER_TIMEOUT accurate for zero window probes

2021-01-23 Thread Neal Cardwell
On Fri, Jan 22, 2021 at 9:45 PM Enke Chen wrote: > > Hi, Jakub: > > On Fri, Jan 22, 2021 at 06:34:24PM -0800, Jakub Kicinski wrote: > > On Fri, 22 Jan 2021 18:28:23 -0800 Enke Chen wrote: > > > Hi, Jakub: > > > > > > In terms of backporting, this patch should go together with: > > > > > > 9d9b

Re: [PATCH v2 3/4] net: make tcp_cleanup_rbuf private

2014-01-09 Thread Neal Cardwell
On Thu, Jan 9, 2014 at 3:16 PM, Dan Williams wrote: > net_dma was the only external user so this can become local to tcp.c > again. ... > -void tcp_cleanup_rbuf(struct sock *sk, int copied) > +static void cleanup_rbuf(struct sock *sk, int copied) I would vote to keep the tcp_ prefix. In the TCP c

Re: [PATCH] ipv4: Add option to get TCP_FASTOPEN to getsockopt()

2014-04-14 Thread Neal Cardwell
On Mon, Apr 14, 2014 at 1:39 PM, Kenjiro Nakayama wrote: > TCP_FASTOPEN option can be set via setsockopt(), but the value cannot be > gotten via getsockopt(). This patch adds the option to getsockopt(). > > Sighned-off-by: Kenjiro Nakayama > > Add option to get TCP_FASTOPEN to getsockopt(

Re: [PATCH v2] ipv4: Add option to get TCP_FASTOPEN to getsockopt()

2014-04-15 Thread Neal Cardwell
On Tue, Apr 15, 2014 at 8:35 AM, Kenjiro Nakayama wrote: > Hi, Please omit the "Hi," at the top of the patch description, so the top of the email can be used directly as a git commit description. > TCP_FASTOPEN option can be set via setsockopt(), but the value cannot be > gotten via getsockopt()

Re: [PATCH v3] tcp: Add a TCP_FASTOPEN socket option to get a max backlog on its listner

2014-04-18 Thread Neal Cardwell
On Wed, Apr 16, 2014 at 12:25 PM, Kenjiro Nakayama wrote: > This patch adds a TCP_FASTOPEN socket option to get a max backlog on its > listener to getsockopt(). > > Signed-off-by: Kenjiro Nakayama > --- > net/ipv4/tcp.c | 8 > 1 file changed, 8 insertions(+) Ac

Re: [PATCH] tcp: Restore RFC5961-compliant behavior for SYN packets

2014-11-21 Thread Neal Cardwell
. > > The challenge ACK is sent unconditionally and is rate-limited, so the > original vulnerability is not reintroduced by this patch. > > Signed-off-by: Calvin Owens Acked-by: Neal Cardwell neal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-03 Thread Neal Cardwell
On Wed, Jun 3, 2020 at 1:44 AM Eric Dumazet wrote: > > On Tue, Jun 2, 2020 at 10:05 PM Jason Xing wrote: > > > > Hi Eric, > > > > I'm still trying to understand what you're saying before. Would this > > be better as following: > > 1) discard the tcp_internal_pacing() function. > > 2) remove where

Re: [PATCH] tcp: fix TCP socks unreleased in BBR mode

2020-06-03 Thread Neal Cardwell
On Wed, Jun 3, 2020 at 9:55 AM Eric Dumazet wrote: > > On Wed, Jun 3, 2020 at 5:02 AM Neal Cardwell wrote: > > > > On Wed, Jun 3, 2020 at 1:44 AM Eric Dumazet wrote: > > > > > > On Tue, Jun 2, 2020 at 10:05 PM Jason Xing > > > wrote: > > &g

Re: Get amount of fast retransmissions from TCP info

2017-04-24 Thread Neal Cardwell
On Mon, Apr 24, 2017 at 3:11 PM, Lars Erik Storbukås wrote: > I'm trying to get amount of congestion events in TCP caused by > DUPACK's (fast retransmissions), and can't seem to find any variable > in the TCP info struct which hold that value. There are three > variables in the TCP info struct tha

Re: Get amount of fast retransmissions from TCP info

2017-04-24 Thread Neal Cardwell
" On Mon, Apr 24, 2017 at 4:20 PM, Lars Erik Storbukås wrote: > 2017-04-24 21:42 GMT+02:00 Neal Cardwell : >> On Mon, Apr 24, 2017 at 3:11 PM, Lars Erik Storbukås >> wrote: >>> I'm trying to get amount of congestion events in TCP caused by >>> DUPACK&

Re: [PATCH] ipv6: initialize treq->txhash in cookie_v6_check()

2017-07-14 Thread Neal Cardwell
On Fri, Jul 14, 2017 at 12:54 PM, Alexander Potapenko wrote: > KMSAN reported use of uninitialized memory in skb_set_hash_from_sk(), > which originated from the TCP request socket created in > cookie_v6_check(): ... > --- a/net/ipv6/syncookies.c > +++ b/net/ipv6/syncookies.c > @@ -216,6 +216,7 @@

Re: [PATCH] ipv6: initialize treq->txhash in cookie_v6_check()

2017-07-14 Thread Neal Cardwell
On Fri, Jul 14, 2017 at 1:35 PM, Alexander Potapenko wrote: > On Fri, Jul 14, 2017 at 7:04 PM, Neal Cardwell wrote: >> On Fri, Jul 14, 2017 at 12:54 PM, Alexander Potapenko >> wrote: >>> KMSAN reported use of uninitialized memory in skb_set_hash_from_sk(), >>&

Re: TCP and BBR: reproducibly low cwnd and bandwidth

2018-02-16 Thread Neal Cardwell
On Fri, Feb 16, 2018 at 11:26 AM, Holger Hoffstätte wrote: > > BBR in general will run with lower cwnd than e.g. Cubic or others. > That's a feature and necessary for WAN transfers. Please note that there's no general rule about whether BBR will run with a lower or higher cwnd than CUBIC, Reno, o

Re: [PATCH 4.9 00/75] 4.9.74-stable review

2018-01-02 Thread Neal Cardwell
On Mon, Jan 1, 2018 at 9:31 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.74 release. > There are 75 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Resp

Re: [PATCH 4.9 00/75] 4.9.74-stable review

2018-01-02 Thread Neal Cardwell
On Tue, Jan 2, 2018 at 1:32 PM, David Miller wrote: > From: Neal Cardwell > Date: Tue, 2 Jan 2018 11:57:59 -0500 > >> On Mon, Jan 1, 2018 at 9:31 AM, Greg Kroah-Hartman >> wrote: >>> This is the start of the stable review cycle for the 4.9.74 release. >>&

Re: [PATCH 4.9 00/75] 4.9.74-stable review

2018-01-02 Thread Neal Cardwell
On Tue, Jan 2, 2018 at 3:08 PM, Greg KH wrote: > On Tue, Jan 02, 2018 at 02:11:25PM -0500, Neal Cardwell wrote: ... >> Thanks, Greg and David. Looks like these 2 patches will cherry-pick >> cleanly if cherry-picked in the following sequence, on top of >> 4.9.74-rc1, which alr

Re: Get amount of fast retransmissions from TCP info

2017-05-03 Thread Neal Cardwell
On Wed, May 3, 2017 at 3:47 PM, Lars Erik Storbukås wrote: > I also want to count the amount of ECN signals received. Do anyone > have any input on where to place an ECN signal count? > > Is any of these locations a logical place to increase the ECN counter > (which I've created in tcp_sock)? Both

Re: linux-next: manual merge of the net-next tree with the net tree

2017-08-06 Thread Neal Cardwell
On Sun, Aug 6, 2017 at 10:01 PM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > net/ipv4/tcp_output.c > > between commit: > > a2815817ffa6 ("tcp: enable xmit timer fix by having TLP use time when RTO > should fire") > > from the net

Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile

2017-08-15 Thread Neal Cardwell
On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah wrote: > + > +/* Agile-SD Parameters */ > +struct agilesdtcp { > + u32 loss_cwnd; /* congestion window at last loss.*/ Please rebase your change on top of the latest net-next changes and update this module to use the latest app

Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile

2017-08-15 Thread Neal Cardwell
On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah wrote: > This commit implements a new TCP congestion control algorithm, namely > Agile-SD. Also, please use a summary line for your patch that is more in keeping with Linux style, using spaces rather than dashes, and leading with tcp: or tcp_agile_