Re: [PATCH] coccicheck: Allow for overriding spatch flags

Le 12/06/16 à 21:04, Deepa Dinamani a écrit : Documentation/coccinelle.txt suggests using the SPFLAGS make variable to pass additional options to spatch. Reorder the way SPFLAGS is added to FLAGS, to allow for options in the SPFLAGS to override the default --very-quiet option. Similarly,

Re: [PATCH v3 7/8] coccicheck: refer to coccicheck bottest wiki for documentation

Hi, Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit : Sprinkling *tons* of documentation on the script is not a good idea, instead refer to a wiki for further coccicheck documentation: https://bottest.wiki.kernel.org/coccicheck This page shall always refer to the linux-next iteration of

Re: [PATCH v3 6/8] coccicheck: add support for requring a coccinelle version

Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit : Enable Coccinelle SmPL patches to require a specific version of Coccinelle. In the event that the version does not match we just inform the user, if the user asked to go through all SmPL patches we just inform them of the need for a new version of

Re: [PATCH v3 8/8] scripts/coccinelle: require coccinelle >= 1.0.4 on device_node_continue.cocci

Le 21/06/16 à 22:36, Julia Lawall a écrit : On Tue, 21 Jun 2016, Luis R. Rodriguez wrote: Make use of the new Requires: tag to be able to specify coccinelle binary version requirements. The cocci file device_node_continue.cocci requires at least coccinelle 1.0.4. Signed-off-by: Luis R.

Re: [PATCH v3 1/8] coccicheck: move spatch binary check up

Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit : This has no functional changes. This is being done to enable us to later use spatch binary for some flag checking for certain features early on. Signed-off-by: Luis R. Rodriguez Acked-by: Nicolas Palix

Re: [PATCH v3 3/8] coccicheck: enable parmap support

Hi, Le 21/06/16 à 22:43, Julia Lawall a écrit : On Tue, 21 Jun 2016, Luis R. Rodriguez wrote: On Tue, Jun 21, 2016 at 10:17:38PM +0200, Julia Lawall wrote: On Tue, 21 Jun 2016, Luis R. Rodriguez wrote: Coccinelle has had parmap support since 1.0.2, this means it supports --jobs,

Re: [PATCH v3 5/8] scripts: add Linux .cocciconfig for coccinelle

Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit : Help Coccinelle when used against Linux with a set of sensible defaults options for Linux. This hints to coccinelle git can be used for 'git grep' queries over coccigrep. A timeout of 200 seconds should suffice for now. If you use idutils you can

Re: [PATCH v3 2/8] coccicheck: make SPFLAGS more useful

Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit : SPFLAGS is set early, it means that any heuristics done on coccicheck cannot be overridden currently. Move SPFLAGS after OPTIONS and set this at the end. This lets you override any heuristics as coccinelle treats conflicts by only listening to the

Re: [PATCH] coccicheck: Fix missing 0 index in kill loop

Le 16/05/16 14:55, Kees Cook a écrit : > By default, "seq" counts from 1, but processes were starting counting > from 0, so when interrupted, coccicheck would leave the 0th process > running. > > Signed-off-by: Kees Cook Acked-by: Nicolas Palix >

Re: [PATCH 02/10] docs: sphinxify coccinelle.txt and add it to dev-tools

Le 09/08/16 à 01:34, Jonathan Corbet a écrit : No textual changes have been made, but the formatting has obviously been tweaked. Cc: Michal Marek Cc: Gilles Muller Cc: Nicolas Palix Cc: Julia Lawall

Re: [PATCH] coccicheck: improve pattern for getting relative path

Le 10/08/17 à 19:40, Cihangir Akturk a écrit : When invoked with V=1, coccicheck script prints the information about which semantic patch (*.cocci file) used for this operation. Actually, it prints out the relative path of the related semantic patch. The script uses sed to remove the source

Re: [PATCH] coccinelle: fix verbose message about .cocci file being run

Le 26/10/17 à 06:55, Masahiro Yamada a écrit : If you run coccicheck with V=1 and COCCI=, you will see a strange path to the semantic patch file. For example, run the following: $ make V=1 COCCI=scripts/coccinelle/free/kfree.cocci coccicheck [ snip ] The semantic patch that makes this

Re: [PATCH] coccinelle: grep Options and Requires fields more precisely

Le 26/10/17 à 06:59, Julia Lawall a écrit : On Thu, 26 Oct 2017, Masahiro Yamada wrote: Currently, the required version for badzero.cocci is picked up from its "Comments:" line since it contains the word "Requires". Surprisingly, ld-version.sh can extract the version number from the string

Re: [PATCH] Coccinelle: memdup: Fix typo in warning messages

Le 01/03/2018 à 09:57, Dafna Hirschfeld a écrit : Replace 'kmemdep' with 'kmemdup' in warning messages. Signed-off-by: Dafna Hirschfeld Acked-by: Julia Lawall Acked-by: Nicolas Palix --- scripts/coccinelle/api/memdup.cocci |

Re: [PATCH] Coccinelle: memdup: Fix typo in warning messages

Le 01/03/2018 à 09:57, Dafna Hirschfeld a écrit : Replace 'kmemdep' with 'kmemdup' in warning messages. Signed-off-by: Dafna Hirschfeld Acked-by: Julia Lawall Acked-by: Nicolas Palix --- scripts/coccinelle/api/memdup.cocci | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH] coccicheck: improve pattern for getting relative path

Le 10/08/17 à 19:40, Cihangir Akturk a écrit : When invoked with V=1, coccicheck script prints the information about which semantic patch (*.cocci file) used for this operation. Actually, it prints out the relative path of the related semantic patch. The script uses sed to remove the source

Re: [PATCH] coccinelle: fix verbose message about .cocci file being run

Le 26/10/17 à 06:55, Masahiro Yamada a écrit : If you run coccicheck with V=1 and COCCI=, you will see a strange path to the semantic patch file. For example, run the following: $ make V=1 COCCI=scripts/coccinelle/free/kfree.cocci coccicheck [ snip ] The semantic patch that makes this

Re: [PATCH] coccinelle: grep Options and Requires fields more precisely

Le 26/10/17 à 06:59, Julia Lawall a écrit : On Thu, 26 Oct 2017, Masahiro Yamada wrote: Currently, the required version for badzero.cocci is picked up from its "Comments:" line since it contains the word "Requires". Surprisingly, ld-version.sh can extract the version number from the string

Re: [PATCH] coccicheck: Fix missing 0 index in kill loop

Le 16/05/16 14:55, Kees Cook a écrit : > By default, "seq" counts from 1, but processes were starting counting > from 0, so when interrupted, coccicheck would leave the 0th process > running. > > Signed-off-by: Kees Cook Acked-by: Nicolas Palix > --- > scripts/coccicheck | 2 +- > 1 file

Re: [PATCH 02/10] docs: sphinxify coccinelle.txt and add it to dev-tools

Le 09/08/16 à 01:34, Jonathan Corbet a écrit : No textual changes have been made, but the formatting has obviously been tweaked. Cc: Michal Marek Cc: Gilles Muller Cc: Nicolas Palix Cc: Julia Lawall Signed-off-by: Jonathan Corbet Acked-by: Nicolas Palix --- .../{coccinelle.txt =>

Re: [PATCH v3 1/8] coccicheck: move spatch binary check up

Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit : This has no functional changes. This is being done to enable us to later use spatch binary for some flag checking for certain features early on. Signed-off-by: Luis R. Rodriguez Acked-by: Nicolas Palix --- scripts/coccicheck | 10 +-

Re: [PATCH v3 3/8] coccicheck: enable parmap support

Hi, Le 21/06/16 à 22:43, Julia Lawall a écrit : On Tue, 21 Jun 2016, Luis R. Rodriguez wrote: On Tue, Jun 21, 2016 at 10:17:38PM +0200, Julia Lawall wrote: On Tue, 21 Jun 2016, Luis R. Rodriguez wrote: Coccinelle has had parmap support since 1.0.2, this means it supports --jobs,

Re: [PATCH v3 5/8] scripts: add Linux .cocciconfig for coccinelle

Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit : Help Coccinelle when used against Linux with a set of sensible defaults options for Linux. This hints to coccinelle git can be used for 'git grep' queries over coccigrep. A timeout of 200 seconds should suffice for now. If you use idutils you can

Re: [PATCH v3 7/8] coccicheck: refer to coccicheck bottest wiki for documentation

Hi, Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit : Sprinkling *tons* of documentation on the script is not a good idea, instead refer to a wiki for further coccicheck documentation: https://bottest.wiki.kernel.org/coccicheck This page shall always refer to the linux-next iteration of

Re: [PATCH v3 6/8] coccicheck: add support for requring a coccinelle version

Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit : Enable Coccinelle SmPL patches to require a specific version of Coccinelle. In the event that the version does not match we just inform the user, if the user asked to go through all SmPL patches we just inform them of the need for a new version of

Re: [PATCH v3 8/8] scripts/coccinelle: require coccinelle >= 1.0.4 on device_node_continue.cocci

Le 21/06/16 à 22:36, Julia Lawall a écrit : On Tue, 21 Jun 2016, Luis R. Rodriguez wrote: Make use of the new Requires: tag to be able to specify coccinelle binary version requirements. The cocci file device_node_continue.cocci requires at least coccinelle 1.0.4. Signed-off-by: Luis R.

Re: [PATCH v3 2/8] coccicheck: make SPFLAGS more useful

Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit : SPFLAGS is set early, it means that any heuristics done on coccicheck cannot be overridden currently. Move SPFLAGS after OPTIONS and set this at the end. This lets you override any heuristics as coccinelle treats conflicts by only listening to the

Re: [PATCH] coccicheck: Allow for overriding spatch flags

Le 12/06/16 à 21:04, Deepa Dinamani a écrit : Documentation/coccinelle.txt suggests using the SPFLAGS make variable to pass additional options to spatch. Reorder the way SPFLAGS is added to FLAGS, to allow for options in the SPFLAGS to override the default --very-quiet option. Similarly,