tg3: unable to handle null pointer dereference [Re: Linux 2.6.21-rc6]

2007-04-06 Thread Nishanth Aravamudan
the unused TG3_FLAG_SPLIT_MODE flag. [TG3]: Exit irq handler during chip reset. [TG3]: Update version and reldate. probably Exit irq handler during chip reset? Thanks, Nish -- Nishanth Aravamudan [EMAIL PROTECTED] IBM Linux Technology Center - To unsubscribe from this list: send

Re: tg3: unable to handle null pointer dereference

2007-04-06 Thread Nishanth Aravamudan
On 06.04.2007 [17:36:00 -0700], David Miller wrote: From: Michael Chan [EMAIL PROTECTED] Date: Fri, 06 Apr 2007 15:57:13 -0700 On Fri, 2007-04-06 at 14:40 -0700, Nishanth Aravamudan wrote: 2.6.21-rc5 is ok. 2.6.21-rc6 results in [ 14.241665] Unable to handle kernel NULL

Re: 2.6.21-rc6-mm1

2007-04-09 Thread Nishanth Aravamudan
-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- Only compile-tested so far (on x86_64). diff -urpN 2.6.21-rc6-mm1/fs/hugetlbfs/inode.c 2.6.21-rc6-mm1-dev/fs/hugetlbfs/inode.c --- 2.6.21-rc6-mm1/fs/hugetlbfs/inode.c 2007-04-09 17:17:16.0 -0700 +++ 2.6.21-rc6-mm1-dev/fs/hugetlbfs/inode.c

hugetlb: Unable to handle kernel NULL pointer dereference

2007-04-02 Thread Nishanth Aravamudan
] [8016ac54] _spin_unlock+0x14/0x40 [351419.047394] [8014df39] do_group_exit+0x89/0x90 [351419.047398] [80151ec2] sys_exit_group+0x12/0x20 [351419.047402] [801669e4] cstar_do_call+0x1b/0x65 [351419.047404] Thanks, Nish -- Nishanth Aravamudan [EMAIL PROTECTED

Re: hugetlb: Unable to handle kernel NULL pointer dereference

2007-04-02 Thread Nishanth Aravamudan
On 02.04.2007 [18:46:08 -0700], Nishanth Aravamudan wrote: Adam, David, Just got the following Oops and recursive fault running `make func` (apparently the `shared` test in particular) with kernel HEAD at efab03d998da03f67836ffc664b04e0400f85448 on my x86_64. Will pull latest Linus

Re: 2.6.24-git20 -- BUG: sleeping function called from invalid context at include/asm/uaccess_32.h:449

2008-02-10 Thread Nishanth Aravamudan
it be said? Hopefully this is often enough. PLEASE always test all code with all kernel deubg options enabled. Yep, 100% my error. Am testing a fix now, will post soon. Thanks, Nish -- Nishanth Aravamudan [EMAIL PROTECTED] IBM Linux Technology Center -- To unsubscribe from this list: send the line

Re: 2.6.24-git20 -- BUG: sleeping function called from invalid context at include/asm/uaccess_32.h:449

2008-02-10 Thread Nishanth Aravamudan
for this or not...) I would support such a CONFIG_ option. But in this case, it was plain oversight / poor engineering on my part. So, while it may have helped, doesn't make up for deficiencies on my end. Thanks, Nish -- Nishanth Aravamudan [EMAIL PROTECTED] IBM Linux Technology Center -- To unsubscribe

Re: 2.6.24-git20 -- BUG: sleeping function called from invalid context at include/asm/uaccess_32.h:449

2008-02-11 Thread Nishanth Aravamudan
On 10.02.2008 [13:25:28 -0800], Nishanth Aravamudan wrote: On 09.02.2008 [16:26:43 -0800], Andrew Morton wrote: On Sat, 9 Feb 2008 14:03:28 -0500 Miles Lane [EMAIL PROTECTED] wrote: Command run: find /proc | xargs tail [ 2710.028219] BUG: sleeping function called from

Re: [PATCH 2/6] fs/direct-io.c: Use DIV_ROUND_UP

2008-02-14 Thread Nishanth Aravamudan
].iov_len + PAGE_SIZE - 1)/PAGE_SIZE + user_addr/PAGE_SIZE - user_addr/PAGE_SIZE) = ((iov[seg].iov_len + PAGE_SIZE - 1)/PAGE_SIZE) = DIV_ROUND_UP(iov[seg].iov_len, PAGE_SIZE) CMIIW. Thanks, Nish -- Nishanth Aravamudan [EMAIL PROTECTED] IBM Linux Technology Center -- To unsubscribe

Re: [PATCH 2/6] fs/direct-io.c: Use DIV_ROUND_UP

2008-02-14 Thread Nishanth Aravamudan
the divisions truncate. Thus, while mathematically equivalent, the simplification is not computationally so. Thanks, Nish -- Nishanth Aravamudan [EMAIL PROTECTED] IBM Linux Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [PATCH 6/6] Use one zonelist that is filtered by nodemask

2007-10-08 Thread Nishanth Aravamudan
on THISNODE requests returning NULL if they go off-node. I'm not sure how this would be fixed, as __alloc_pages() no longer has the nid to set in the mask. Am I wrong in my analysis? Thanks, Nish -- Nishanth Aravamudan [EMAIL PROTECTED] IBM Linux Technology Center - To unsubscribe from this list

Re: [PATCH 6/6] Use one zonelist that is filtered by nodemask

2007-10-08 Thread Nishanth Aravamudan
On 08.10.2007 [18:56:05 -0700], Christoph Lameter wrote: On Mon, 8 Oct 2007, Nishanth Aravamudan wrote: struct page * fastcall __alloc_pages(gfp_t gfp_mask, unsigned int order, struct zonelist *zonelist) { + /* + * Use a temporary nodemask for __GFP_THISNODE

Re: [PATCH 6/6] Use one zonelist that is filtered by nodemask

2007-10-09 Thread Nishanth Aravamudan
and candidate fix to one zonelist are below. On (08/10/07 18:11), Nishanth Aravamudan didst pronounce: On 28.09.2007 [15:25:27 +0100], Mel Gorman wrote: Two zonelists exist so that GFP_THISNODE allocations will be guaranteed to use memory only from a node local to the CPU. As we can now

Re: [PATCH 6/6] Use one zonelist that is filtered by nodemask

2007-10-09 Thread Nishanth Aravamudan
and candidate fix to one zonelist are below. On (08/10/07 18:11), Nishanth Aravamudan didst pronounce: On 28.09.2007 [15:25:27 +0100], Mel Gorman wrote: Two zonelists exist so that GFP_THISNODE allocations will be guaranteed to use memory only from a node local to the CPU. As we can now

Re: [PATCH] hugetlbfs read() support

2007-07-23 Thread Nishanth Aravamudan
On 20.07.2007 [14:47:31 +1000], Nick Piggin wrote: Nishanth Aravamudan wrote: On 19.07.2007 [09:58:50 -0700], Andrew Morton wrote: On Thu, 19 Jul 2007 08:51:49 -0700 Badari Pulavarty [EMAIL PROTECTED] wrote: +} + +offset += ret

Re: [PATCH 6/6] Use one zonelist that is filtered by nodemask

2007-10-10 Thread Nishanth Aravamudan
__alloc_pages_nodemask(). -Nish -- Nishanth Aravamudan [EMAIL PROTECTED] IBM Linux Technology Center - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Add support for vector domain breaks boot on x355

2007-07-31 Thread Nishanth Aravamudan
NR_IRQ_VECTORS NR_IRQS +#define NR_VECTORS 256 + +#if (NR_VECTORS + 32 * NR_CPUS) 1024 +#define NR_IRQS (NR_VECTORS + 32 * NR_CPUS) +#else +#define NR_IRQS 1024 +#endif static __inline__ int irq_canonicalize (int irq) -- Nishanth Aravamudan [EMAIL PROTECTED] IBM Linux Technology Center

Re: Add support for vector domain breaks boot on x355

2007-07-31 Thread Nishanth Aravamudan
... |/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|/-\|done. [ 35.077274] VFS: Mounted root (cramfs filesystem) readonly. [ 35.132801] Freeing unused kernel memory: 1904kB freed ... -- Nishanth Aravamudan [EMAIL PROTECTED] IBM Linux Technology

Re: Add support for vector domain breaks boot on x355

2007-07-31 Thread Nishanth Aravamudan
On 01.08.2007 [10:43:43 +0900], Kenji Kaneshige wrote: 2007-07-31 (?$B2P) ?$B$N 15:13 -0700 ?$B$K Nishanth Aravamudan ?$B$5$s$O=q$-$^$7$?: The following commit (4994be1b3fe9120c88022ff5c0c33f6312b17adb) broke Linus' Tree between 2.6.22-git15 and 2.6.22-git16 on a 2-node 8-way x455

[RFC PATCH] add wait_event_*_lock() functions

2005-02-10 Thread Nishanth Aravamudan
usb/serial/gadget.c, which are basically the same as wait_event*() but with locks, globally available via wait.h. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- 2.6.11-rc3-v/include/linux/wait.h 2004-12-24 13:34:57.0 -0800 +++ 2.6.11-rc3/include/linux/wait.h 2005-02-09 11

Re: [RFC PATCH] add wait_event_*_lock() functions

2005-02-10 Thread Nishanth Aravamudan
On Thu, Feb 10, 2005 at 10:21:58AM -0800, David Brownell wrote: On Thursday 10 February 2005 9:39 am, Nishanth Aravamudan wrote: Hi David, LKML, It came up on IRC that the wait_cond*() functions from usb/serial/gadget.c could be useful in other parts of the kernel. Does the following

Re: [RFC PATCH] add wait_event_*_lock() functions

2005-02-11 Thread Nishanth Aravamudan
On Fri, Feb 11, 2005 at 01:07:08AM -0600, Al Borchers wrote: On Thursday 10 February 2005 9:39 am, Nishanth Aravamudan wrote: It came up on IRC that the wait_cond*() functions from usb/serial/gadget.c could be useful in other parts of the kernel. Does the following patch make sense

[RFC UPDATE PATCH] add wait_event_*_lock() functions and comments

2005-02-11 Thread Nishanth Aravamudan
On Fri, Feb 11, 2005 at 01:07:08AM -0600, Al Borchers wrote: On Thursday 10 February 2005 9:39 am, Nishanth Aravamudan wrote: It came up on IRC that the wait_cond*() functions from usb/serial/gadget.c could be useful in other parts of the kernel. Does the following patch make sense

Re: [RFC UPDATE PATCH] add wait_event_*_lock() functions and comments

2005-02-14 Thread Nishanth Aravamudan
On Sat, Feb 12, 2005 at 09:00:52PM -0800, Nish Aravamudan wrote: On Sun, 13 Feb 2005 03:41:01 +0100, Arnd Bergmann [EMAIL PROTECTED] wrote: On Sünnavend 12 Februar 2005 14:28, Sergey Vlasov wrote: On Sat, 12 Feb 2005 12:38:26 +0100 Arnd Bergmann wrote: #define __wait_event_lock(wq,

Re: [PATCH] i386: Selectable Frequency of the Timer Interrupt

2005-07-12 Thread Nishanth Aravamudan
On 12.07.2005 [10:50:23 -0700], john stultz wrote: On Tue, 2005-07-12 at 08:26 -0700, Martin J. Bligh wrote: The PIT crystal runs at 14.3181818 MHz (CGA dotclock, found on ISA, ...) and is divided by 12 to get PIT tick rate 14.3181818 MHz / 12 = 1193182 Hz

[PATCH] char/vt: fix compile failure (typo)

2005-07-14 Thread Nishanth Aravamudan
From: Nishanth Aravamudan [EMAIL PROTECTED] Description: The mod_timer() statement mistakenly has a comma at the end of the line instead of a semicolon. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- vt.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -urpN 2.6.13

[RFC][PATCH 1/4] add jiffies_to_nsecs() helper and fix up size of usecs

2005-07-14 Thread Nishanth Aravamudan
From: Nishanth Aravamudan [EMAIL PROTECTED] Description: Add a jiffies_to_nsecs() helper function. Make consistent the size of microseconds (unsigned long) throughout the conversion functions. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- jiffies.h | 15 +-- 1 files

[RFC][PATCH 2/4] human-time soft-timer core changes

2005-07-14 Thread Nishanth Aravamudan
From: Nishanth Aravamudan [EMAIL PROTECTED] Description: The core revision to the soft-timer subsystem to divorce it from the timer interrupt in software, i.e. jiffies. Instead, use getnstimeofday() (via do_monotonic_clock()) as the basis for addition and expiration of timers. Add a new unit

[RFC][PATCH 3/4] new human-time schedule_timeout() functions

2005-07-14 Thread Nishanth Aravamudan
From: Nishanth Aravamudan [EMAIL PROTECTED] Description: Add new human-time schedule_timeout() style functions, along with the appropriate constants/prototypes. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- include/linux/sched.h |7 ++ include/linux/time.h |4 + kernel

[RFC][PATCH 4/4] convert sys_nanosleep() to use set_timer_nsecs()

2005-07-14 Thread Nishanth Aravamudan
From: Nishanth Aravamudan [EMAIL PROTECTED] Description: Add timespec and timeval conversion functions for nanoseconds. Convert sys_nanosleep() to use schedule_timeout_nsecs(). Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- include/linux/time.h | 33

[RFC][PATCH 0/4] new human-time soft-timer subsystem

2005-07-14 Thread Nishanth Aravamudan
On 14.07.2005 [12:18:41 -0700], john stultz wrote: snip Nish has some code, which I hope he'll be sending out shortly that does just this, converting the soft-timer subsystem to use absolute time instead of ticks for expiration. I feel it both simplifies the code and makes it easier to

Re: [RFC][PATCH 1/4] add jiffies_to_nsecs() helper and fix up size of usecs

2005-07-14 Thread Nishanth Aravamudan
On 14.07.2005 [13:54:47 -0700], Dave Hansen wrote: On Thu, 2005-07-14 at 13:28 -0700, Nishanth Aravamudan wrote: +static inline u64 jiffies_to_nsecs(const unsigned long j) +{ +#if HZ = NSEC_PER_SEC !(NSEC_PER_SEC % HZ) + return (NSEC_PER_SEC / HZ) * (u64)j; +#elif HZ NSEC_PER_SEC

Re: [RFC][PATCH 1/6] new timeofday core subsystem

2005-07-16 Thread Nishanth Aravamudan
On 16.07.2005 [02:32:14 -0600], Frank Sorenson wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 +extern nsec_t do_monotonic_clock(void); This looks okay ... +/** + * do_monotonic_clock - Returns monotonically increasing nanoseconds + * + * Returns the monotonically

Re: [RFC][PATCH 1/4] add jiffies_to_nsecs() helper and fix up size of usecs

2005-07-16 Thread Nishanth Aravamudan
On 15.07.2005 [14:14:25 +0200], Pavel Machek wrote: Hi! +static inline u64 jiffies_to_nsecs(const unsigned long j) +{ +#if HZ = NSEC_PER_SEC !(NSEC_PER_SEC % HZ) + return (NSEC_PER_SEC / HZ) * (u64)j; +#elif HZ NSEC_PER_SEC !(HZ % NSEC_PER_SEC) + return

Re: [RFC][PATCH 0/4] new human-time soft-timer subsystem

2005-07-16 Thread Nishanth Aravamudan
On 15.07.2005 [00:28:44 +0200], Roman Zippel wrote: Hi, On Thu, 14 Jul 2005, Nishanth Aravamudan wrote: We no longer use jiffies (the variable) as the basis for determining what time a timer should expire or when it should be added. Instead, we use a new function, do_monotonic_clock

[RFC][UPDATE PATCH 2/4] human-time soft-timer core changes

2005-07-18 Thread Nishanth Aravamudan
On 14.07.2005 [13:40:11 -0700], Nishanth Aravamudan wrote: From: Nishanth Aravamudan [EMAIL PROTECTED] Description: The core revision to the soft-timer subsystem to divorce it from the timer interrupt in software, i.e. jiffies. Instead, use getnstimeofday() (via do_monotonic_clock

[PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces

2005-07-22 Thread Nishanth Aravamudan
equivalents. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- include/linux/sched.h | 11 kernel/timer.c| 125 ++ 2 files changed, 135 insertions(+), 1 deletion(-) diff -urpN 2.6.13-rc3/include/linux/sched.h 2.6.13-rc3

[UPDATE PATCH] Add schedule_timeout_{interruptible,uninterruptible}_msecs() interfaces

2005-07-22 Thread Nishanth Aravamudan
also noticed I typo'd the externs in sched.h. Fixed in the new patch. Description: Add schedule_timeout_msecs() and add wrappers for interruptible/uninterruptible schedule_timeout_msecs() callers. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- include/linux/sched.h |7 +++ kernel

[UPDATE PATCH] Add schedule_timeout_{interruptible,uninterruptible}_msecs() interfaces

2005-07-23 Thread Nishanth Aravamudan
On 23.07.2005 [12:30:00 +1000], Andrew Morton wrote: Nishanth Aravamudan [EMAIL PROTECTED] wrote: +/* + * schedule_timeout_msecs - sleep until timeout + * @timeout_msecs: timeout value in milliseconds + * + * A human-time (but otherwise identical) alternative

Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces

2005-07-23 Thread Nishanth Aravamudan
On 23.07.2005 [12:50:45 +0200], Roman Zippel wrote: Hi, On Fri, 22 Jul 2005, Arjan van de Ven wrote: Also I'd rather not add the non-msec ones... either you're raw and use HZ, or you are cooked and use the msec variant.. I dont' see the point of adding an in the middle one. (Yes this

Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces

2005-07-23 Thread Nishanth Aravamudan
On 23.07.2005 [13:55:58 +0200], Roman Zippel wrote: Hi, On Sat, 23 Jul 2005, Arjan van de Ven wrote: What's wrong with using jiffies? A lot of the (driver) users want a wallclock based timeout. For that, miliseconds is a more obvious API with less chance to get the jiffies/HZ

Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces

2005-07-23 Thread Nishanth Aravamudan
On 23.07.2005 [15:04:44 +0200], Roman Zippel wrote: Hi, On Sat, 23 Jul 2005, Arjan van de Ven wrote: What's wrong with using jiffies? A lot of the (driver) users want a wallclock based timeout. For that, miliseconds is a more obvious API with less chance to get the

Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces

2005-07-23 Thread Nishanth Aravamudan
On 23.07.2005 [15:29:42 +0200], Roman Zippel wrote: Hi, On Sat, 23 Jul 2005, Arjan van de Ven wrote: jiffies/HZ is the more powerful API. The msec one which also sets current to (un)interruptible is the simplified wrapper on top. So why do you want to hide it? Make the jiffies based

Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces

2005-07-23 Thread Nishanth Aravamudan
On 23.07.2005 [19:17:37 +0200], Roman Zippel wrote: Hi, On Sat, 23 Jul 2005, Nishanth Aravamudan wrote: Keep the thing as simple as possible and jiffies _are_ simple. Please show me the problem, that needs to be fixed. I am not sure why jiffies are any simpler than

Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces

2005-07-23 Thread Nishanth Aravamudan
On 23.07.2005 [19:01:57 +0200], Roman Zippel wrote: Hi, On Sat, 23 Jul 2005, Nishanth Aravamudan wrote: set_current_state(TASK_{,UN}INTERRUPTIBLE); schedule_timeout(msecs_to_jiffies(some_constant_msecs)); just have an interface that allows schedule_timeout_msecs_

Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces

2005-07-27 Thread Nishanth Aravamudan
On 23.07.2005 [22:12:30 +0200], Roman Zippel wrote: Hi, On Sat, 23 Jul 2005, Nishanth Aravamudan wrote: Jiffies are the basic time unit for kernel timers, hiding that fact gives users only wrong expectations about them. We already have msleep() and msleep_interruptible(), which

Re: [openib-general] Re: [PATCH 3/27] Add MAD helper functions

2005-07-11 Thread Nishanth Aravamudan
On 11.07.2005 [11:30:23 -0400], Hal Rosenstock wrote: On Mon, 2005-07-11 at 10:39, Alexey Dobriyan wrote: On Monday 11 July 2005 17:48, Hal Rosenstock wrote: Add new helper routines for allocating MADs for sending and formatting a send WR. --

Re: [patch 01/14] char/snsc: reorder set_current_state() and add_wait_queue()

2005-03-14 Thread Nishanth Aravamudan
On Mon, Mar 14, 2005 at 09:45:44AM -0800, Jesse Barnes wrote: On Sunday, March 6, 2005 2:36 pm, [EMAIL PROTECTED] wrote: Any comments would be, as always, appreciated. I don't have a problem with this change, but the maintainer probably should have been Cc'd. Greg, does this change look

[PATCH] kernel/timer: fix msleep_interruptible() comment

2005-03-03 Thread Nishanth Aravamudan
Hi, Please consider applying. Description: The comment for msleep_interruptible() is wrong, as it will ignore wait-queue events, but will wake up early for signals. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- 2.6.11-kj-v/kernel/timer.c 2005-03-01 23:38:25.0 -0800

[UPDATE PATCH] char/hvsi: use wait_event_timeout()

2005-03-07 Thread Nishanth Aravamudan
-queue code. The code is not changed in any way (I don't think), but is cleaned up quite a bit (will get expanded to almost identical code). Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- 2.6.11-v/drivers/char/hvsi.c2005-03-01 23:38:13.0 -0800 +++ 2.6.11/drivers/char/hvsi.c

[UPDATE PATCH 8/many] acrypto: crypto_dev.c

2005-03-07 Thread Nishanth Aravamudan
be nice to see your changes in the acrypto. If it will be commited... Well, here is an incremental patch, then: Description: Use ssleep() instead of schedule_timeout() to guarantee the task delays as expected. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- 2.6.11-v/acrypto/crypto_dev.c

[UPDATE PATCH 9/many] acrypto: crypto_lb.c

2005-03-08 Thread Nishanth Aravamudan
to a more human-understandable interface and allows for virtualized systems (jiffy-less) to function correctly (with appropriate extensions). Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- 2.6.11-v/acrypto/crypto_lb.c2005-03-08 09:58:56.0 -0800 +++ 2.6.11/acrypto

[PATCH] char/tpm: use msleep(), clean-up timers, fix typo

2005-03-10 Thread Nishanth Aravamudan
() to guarantee the task delays as expected. While compile-testing, I found a typo in the driver, using tpm_chp instead of tpm_chip. Remove the now unused timer callback function and change TPM_TIMEOUT's units to milliseconds. Patch is compile-tested. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED

[PATCH] char/tpm: use msleep(), clean-up timers, fix typo

2005-03-11 Thread Nishanth Aravamudan
is compile-tested. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] diff -urpN 2.6.11-v/drivers/char/tpm/tpm.c 2.6.11/drivers/char/tpm/tpm.c --- 2.6.11-v/drivers/char/tpm/tpm.c 2005-03-10 10:50:00.0 -0800 +++ 2.6.11/drivers/char/tpm/tpm.c 2005-03-10 11:00:50.0 -0800

[UPDATE PATCH] cdrom/mcdx: fix wait-queue compile-time breakage

2005-03-03 Thread Nishanth Aravamudan
. Patchset is at http://coderock.org/kj/2.6.11-kj/ snip int_sleep_on-drivers_cdrom_mcdx.patch From: Nishanth Aravamudan [EMAIL PROTECTED] Subject: [KJ] [PATCH 16/20] cdrom/mcdx: remove interruptible_sleep_on_timeout() usage Description: The original patch leads to compile-warnings from

[UPDATE PATCH] input/iforce-packets: use wait_event_interruptible_timeout()

2005-01-24 Thread Nishanth Aravamudan
On Sun, Jan 23, 2005 at 10:18:49AM +0100, Adrian Bunk wrote: On Sun, Jan 23, 2005 at 12:54:26AM +0100, Domen Puncer wrote: ... new in this release: ... wait_event_int_t-drivers_input_joystick_iforce_iforce.h.patch From: Nishanth Aravamudan [EMAIL PROTECTED

[PATCH 19/34]: include/jiffies: add usecs_to_jiffies() function

2005-01-26 Thread Nishanth Aravamudan
On Tue, Jan 25, 2005 at 06:51:00PM -0800, Andrew Morton wrote: Nishanth Aravamudan [EMAIL PROTECTED] wrote: Please consider applying. Description: Add a usecs_to_jiffies() function. Please cc linux-kernel on things which aren't utterly trivial? Sorry, Andrew, I actually meant

[UPDATE PATCH 19/34]: include/jiffies: add usecs_to_jiffies() function

2005-02-03 Thread Nishanth Aravamudan
On Thu, Feb 03, 2005 at 10:07:15AM -0600, Makhlis, Lev wrote: Nishanth Aravamudan [EMAIL PROTECTED] wrote: +static inline unsigned long usecs_to_jiffies(const unsigned int u) +{ + if (u jiffies_to_usecs(MAX_JIFFY_OFFSET)) + return MAX_JIFFY_OFFSET; +#if HZ = 1000 !(1000

[UPDATE PATCH]: include/jiffies: fix usecs_to_jiffies()/jiffies_to_usecs() math

2005-02-03 Thread Nishanth Aravamudan
On Thu, Feb 03, 2005 at 10:48:05AM -0800, Nishanth Aravamudan wrote: On Thu, Feb 03, 2005 at 10:07:15AM -0600, Makhlis, Lev wrote: Nishanth Aravamudan [EMAIL PROTECTED] wrote: +static inline unsigned long usecs_to_jiffies(const unsigned int u) +{ + if (u jiffies_to_usecs

tg3: possible irq lock inversion dependency detected

2013-04-19 Thread Nishanth Aravamudan
Running 3.9-rc7-ish, tripped the following (also being seen in FC19 alpha) on ppc64: [ 117.026196] = [ 117.026216] [ INFO: possible irq lock inversion dependency detected ] [ 117.026238] 3.9.0-rc7+ #8 Not tainted [ 117.026251]

Re: tg3: possible irq lock inversion dependency detected

2013-04-19 Thread Nishanth Aravamudan
Hi Rob, On 19.04.2013 [14:23:21 -0500], Rob Herring wrote: On 04/19/2013 02:01 PM, Nishanth Aravamudan wrote: Running 3.9-rc7-ish, tripped the following (also being seen in FC19 alpha) on ppc64: [ 117.026196] = [ 117.026216

[PATCH] powerpc: Add HWCAP2 aux entry

2013-04-02 Thread Nishanth Aravamudan
From: Michael Neuling michael.neul...@au1.ibm.com We are currently out of free bits in AT_HWCAP. With POWER8, we have several hardware features that we need to advertise. Tested on POWER and x86. Signed-off-by: Michael Neuling michael.neul...@au1.ibm.com Signed-off-by: Nishanth Aravamudan n

Re: [PATCH 0/3] Radeon acpi vgapost

2005-08-27 Thread Nishanth Aravamudan
On 27.08.2005 [18:25:44 -0700], Michael Marineau wrote: Thses patches resume ATI radeon cards from acpi S3 suspend when using radeonfb by reposting the video bios. This is needed to be able to use S3 when the framebuffer is enabled. Just wanted to report that these patches lead to progress on

Re: [PATCH 0/3] Radeon acpi vgapost

2005-08-28 Thread Nishanth Aravamudan
On 28.08.2005 [00:44:05 -0700], Michael Marineau wrote: Nishanth Aravamudan wrote: On 27.08.2005 [18:25:44 -0700], Michael Marineau wrote: Thses patches resume ATI radeon cards from acpi S3 suspend when using radeonfb by reposting the video bios. This is needed to be able to use S3 when

[PATCH][Bug 5132] fix sys_poll() large timeout handling

2005-08-31 Thread Nishanth Aravamudan
to MAX_SCHEDULE_TIMEOUT. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- fs/select.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff -urpN 2.6.13/fs/select.c 2.6.13-dev/fs/select.c --- 2.6.13/fs/select.c 2005-08-28 17:46:14.0 -0700 +++ 2.6.13-dev/fs

Re: [PATCH 1/3] dynticks - implement no idle hz for x86

2005-09-04 Thread Nishanth Aravamudan
On 03.09.2005 [18:14:48 +1000], Con Kolivas wrote: On Sat, 3 Sep 2005 18:06, Russell King wrote: On Sat, Sep 03, 2005 at 06:01:08PM +1000, Con Kolivas wrote: On Sat, 3 Sep 2005 17:58, Russell King wrote: On Sat, Sep 03, 2005 at 04:13:10PM +1000, Con Kolivas wrote: Noone's ignoring

Re: [PATCH 1/3] dynticks - implement no idle hz for x86

2005-09-04 Thread Nishanth Aravamudan
On 04.09.2005 [21:26:16 +0100], Russell King wrote: On Sun, Sep 04, 2005 at 01:10:54PM -0700, Nishanth Aravamudan wrote: I've got a few ideas that I think might help push Con's patch coalescing efforts in an arch-independent fashion. Note that ARM contains cleanups on top of Tony's

Re: [PATCH 1/3] dynticks - implement no idle hz for x86

2005-09-04 Thread Nishanth Aravamudan
On 04.09.2005 [21:26:16 +0100], Russell King wrote: On Sun, Sep 04, 2005 at 01:10:54PM -0700, Nishanth Aravamudan wrote: I've got a few ideas that I think might help push Con's patch coalescing efforts in an arch-independent fashion. Note that ARM contains cleanups on top of Tony's

Re: [PATCH 1/3] dynticks - implement no idle hz for x86

2005-09-04 Thread Nishanth Aravamudan
On 05.09.2005 [11:02:25 +0530], Srivatsa Vaddagiri wrote: On Sun, Sep 04, 2005 at 09:26:16PM +0100, Russell King wrote: I'd be really surprised if any architecture couldn't use what ARM has today - in other words, this is the only kernel-side interface: Russel, I went thr' the ARM

Re: [PATCH 1/3] dynticks - implement no idle hz for x86

2005-09-05 Thread Nishanth Aravamudan
On 05.09.2005 [12:02:29 +0530], Srivatsa Vaddagiri wrote: On Sun, Sep 04, 2005 at 10:48:13PM -0700, Nishanth Aravamudan wrote: Admittedly, I don't think SMP ARM has been around all that long? Maybe the existing code just has not been extended. Yeah, maybe ARM never cared for SMP. But we do

Re: [patch 14/16] net/tms380tr: replace direct assignment with set_current_state()

2005-08-10 Thread Nishanth Aravamudan
On 10.08.2005 [23:19:01 -0400], Jeff Garzik wrote: [EMAIL PROTECTED] wrote: From: Nishanth Aravamudan [EMAIL PROTECTED] Use set_current_state() instead of direct assignment of current-state. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] Signed-off-by: Maximilian Attems [EMAIL

[-mm PATCH 0/32] fix-up schedule_timeout() usage

2005-08-15 Thread Nishanth Aravamudan
Hello Andrew, Sorry for the lack of a combined To:/Cc: list, but it would have been excessive if I included everyone (I won't send all of the patches to LKML, unless there is no other list entry in MAINTAINERS - I think that is only 9 out of the 32 patches :) Andrew recently added

[-mm PATCH 1/32] include: update jiffies/{m,u}secs conversion functions

2005-08-15 Thread Nishanth Aravamudan
Description: Clarify the human-time units to jiffies conversion functions by using the constants in time.h. This makes many of the subsequent patches direct copies of the current code. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- include/linux/jiffies.h | 40

[-mm PATCH 3/32] kernel: fix-up schedule_timeout() usage

2005-08-15 Thread Nishanth Aravamudan
Description: Use schedule_timeout_{,un}interruptible() instead of set_current_state()/schedule_timeout() to reduce kernel size. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- kernel/compat.c |9 +++-- kernel/signal.c |3 +-- kernel/timer.c | 18 ++ 3

[-mm PATCH 4/32] mm: fix-up schedule_timeout() usage

2005-08-15 Thread Nishanth Aravamudan
Description: Use schedule_timeout_{,un}interruptible() instead of set_current_state()/schedule_timeout() to reduce kernel size. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- mm/oom_kill.c |3 +-- mm/swapfile.c |3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff

[-mm PATCH 17/32] drivers/cdrom: fix-up schedule_timeout() usage

2005-08-15 Thread Nishanth Aravamudan
Description: Use schedule_timeout_{un,}interruptible() instead of set_current_state()/schedule_timeout() to reduce kernel size. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- drivers/cdrom/sbpcd.c |3 +-- drivers/cdrom/sonycd535.c |3 +-- 2 files changed, 2 insertions

[-mm PATCH 19/32] drivers/dlm: fix-up schedule_timeout() usage

2005-08-15 Thread Nishanth Aravamudan
Description: Use schedule_timeout_interruptible() instead of set_current_state()/schedule_timeout() to reduce kernel size. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- drivers/dlm/lockspace.c |3 +-- 1 files changed, 1 insertion(+), 2 deletions(-) diff -urpN 2.6.13-rc5-mm1

[-mm PATCH 26/32] message: fix-up schedule_timeout() usage

2005-08-15 Thread Nishanth Aravamudan
Description: Use schedule_timeout_interruptible() instead of set_current_state()/schedule_timeout() to reduce kernel size. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- drivers/message/fusion/mptlan.c | 10 -- drivers/message/fusion/mptscsih.c |6 ++ drivers

[-mm PATCH 28/32] drivers/sbus: fix-up schedule_timeout() usage

2005-08-15 Thread Nishanth Aravamudan
Description: Use schedule_timeout_uninterruptible() instead of set_current_state()/schedule_timeout() to reduce kernel size. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- drivers/sbus/char/bpp.c |3 +-- drivers/sbus/char/vfc_i2c.c |3 +-- 2 files changed, 2 insertions

[-mm PATCH 31/32] telephony: fix-up schedule_timeout() usage

2005-08-15 Thread Nishanth Aravamudan
Description: Use schedule_timeout_uninterruptible() instead of set_current_state()/schedule_timeout() to reduce kernel size. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- drivers/telephony/ixj.c | 54 1 files changed, 18 insertions

[-mm PATCH 2/32] fs: fix-up schedule_timeout() usage

2005-08-15 Thread Nishanth Aravamudan
Description: Use schedule_timeout_{,un}interruptible() instead of set_current_state()/schedule_timeout() to reduce kernel size. Also use helper functions to convert between human time units and jiffies rather than constant HZ division to avoid rounding errors. Signed-off-by: Nishanth Aravamudan

Re: [xfs-masters] [-mm PATCH 2/32] fs: fix-up schedule_timeout() usage

2005-08-15 Thread Nishanth Aravamudan
On 15.08.2005 [20:17:52 +0200], Christoph Hellwig wrote: On Mon, Aug 15, 2005 at 11:08:04AM -0700, Nishanth Aravamudan wrote: Description: Use schedule_timeout_{,un}interruptible() instead of set_current_state()/schedule_timeout() to reduce kernel size. Also use helper functions to convert

Re: [UPDATE PATCH] push rounding up of relative request to schedule_timeout()

2005-08-16 Thread Nishanth Aravamudan
On 04.08.2005 [09:45:55 -0700], George Anzinger wrote: Uh... PLEASE tell me you are NOT changing timespec_to_jiffies() (and timeval_to_jiffies() to add 1. This is NOT the right thing to do. For repeating times (see setitimer code) we need the actual time as we KNOW where the jiffies edge

Re: [UPDATE PATCH] push rounding up of relative request to schedule_timeout()

2005-08-16 Thread Nishanth Aravamudan
On 16.08.2005 [17:39:11 -0700], George Anzinger wrote: Nishanth Aravamudan wrote: On 04.08.2005 [09:45:55 -0700], George Anzinger wrote: Uh... PLEASE tell me you are NOT changing timespec_to_jiffies() (and timeval_to_jiffies() to add 1. This is NOT the right thing to do. For repeating

Re: [UPDATE PATCH] push rounding up of relative request to schedule_timeout()

2005-08-17 Thread Nishanth Aravamudan
On 17.08.2005 [12:51:17 -0700], George Anzinger wrote: Nishanth Aravamudan wrote: ~ IMNSHO we should not get too parental with kernel only interfaces. Adding 1 is easy enough for the caller and even easier to explain in the instructions (i.e. this call sleeps for X jiffies edges

Re: [-mm PATCH 1/32] include: update jiffies/{m,u}secs conversion functions

2005-08-17 Thread Nishanth Aravamudan
On 17.08.2005 [16:35:06 -0700], Andrew Morton wrote: Nishanth Aravamudan [EMAIL PROTECTED] wrote: Description: Clarify the human-time units to jiffies conversion functions by using the constants in time.h. This makes many of the subsequent patches direct copies of the current code

Re: [PATCH] cpm_uart: Fix dpram allocation and non-console uarts

2005-08-22 Thread Nishanth Aravamudan
On 21.08.2005 [18:12:35 -0300], Marcelo Tosatti wrote: Hi, On Wed, Aug 17, 2005 at 10:42:36PM -0700, Nish Aravamudan wrote: On 8/8/05, Kumar Gala [EMAIL PROTECTED] wrote: (A believe Marcelo would like to see this in 2.6.13, but I'll let him fight over that ;) * Makes dpram

Re: [KJ] [PATCH] net/core/flow.c: compare data with memcmp

2006-12-31 Thread Nishanth Aravamudan
; + /* Compare all elements in key1 and key2. */ + return memcmp(key1, key2, n_elem * sizeof(flow_compare_t)); } Small nit, I don't think either of your comments make the code any clearer than the code on its own, so drop them both. Thanks, Nish -- Nishanth Aravamudan [EMAIL PROTECTED

[UPDATE PATCH] Add schedule_timeout_{intr,unintr}{,_msecs}() interfaces

2005-08-01 Thread Nishanth Aravamudan
On 31.07.2005 [01:35:35 +0200], Roman Zippel wrote: Hi, On Wed, 27 Jul 2005, Nishanth Aravamudan wrote: My goal is to distinguish between these cases in sleeping-logic: 1) tick-oriented use schedule_timeout(), add_timer(), etc. 2) time-oriented

[PATCH] net/sunrpc: fix time conversion error

2005-08-01 Thread Nishanth Aravamudan
is compile-tested. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- svcsock.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) --- 2.6.13-rc4/net/sunrpc/svcsock.c 2005-07-29 14:11:50.0 -0700 +++ 2.6.13-rc4-dev/net/sunrpc/svcsock.c 2005-08-01 15:51:11.0

Re: [PATCH] net/sunrpc: fix time conversion error

2005-08-01 Thread Nishanth Aravamudan
On 02.08.2005 [02:03:59 +0200], Patrick McHardy wrote: Nishanth Aravamudan wrote: On 01.08.2005 [15:11:48 -0600], Josip Loncaric wrote: Line 589 of linux-2.6.11.10/net/sunrpc/svcsock.c is obviously wrong: skb-stamp.tv_usec = xtime.tv_nsec * 1000; To convert nsec

[PATCH] push rounding up of relative request to schedule_timeout()

2005-08-03 Thread Nishanth Aravamudan
On 03.08.2005 [16:20:57 +0200], Roman Zippel wrote: Hi, On Mon, 1 Aug 2005, Nishanth Aravamudan wrote: +unsigned int __sched schedule_timeout_msecs(unsigned int timeout_msecs) +{ + unsigned long expire_jifs; + + if (timeout_msecs == MAX_SCHEDULE_TIMEOUT_MSECS

HZ==250 and rounding issues?

2005-08-03 Thread Nishanth Aravamudan
Hello all, While discussing milliseconds and jiffies and their inter-relations with Roman Zippel in a separate thread, I came across an interesting and perhaps problematic rounding issue with directly using HZ when HZ==250. Consider requesting a 10 millisecond sleep, in jiffies. This is

[UPDATE PATCH] push rounding up of relative request to schedule_timeout()

2005-08-03 Thread Nishanth Aravamudan
On 03.08.2005 [17:51:47 -0700], Nishanth Aravamudan wrote: On 03.08.2005 [16:20:57 +0200], Roman Zippel wrote: Hi, On Mon, 1 Aug 2005, Nishanth Aravamudan wrote: +unsigned int __sched schedule_timeout_msecs(unsigned int timeout_msecs) +{ + unsigned long expire_jifs

Re: [PATCH] push rounding up of relative request to schedule_timeout()

2005-08-04 Thread Nishanth Aravamudan
was simply trying to make the function do what it claims it does. On Wed, 3 Aug 2005, Nishanth Aravamudan wrote: The jiffies_to_msecs(msecs_to_jiffies(timeout_msecs) + 1) case (when the process is immediately woken up again) makes the caller suspectible to timeout manipulations

[PATCH] add schedule_timeout_{,un}intr() interfaces

2005-08-04 Thread Nishanth Aravamudan
about forgetting to add the set_current_state() call beforehand. Signed-off-by: Nishanth Aravamudan [EMAIL PROTECTED] --- include/linux/sched.h |2 ++ kernel/timer.c| 14 ++ 2 files changed, 16 insertions(+) diff -urpN 2.6.13-rc5/include/linux/sched.h 2.6.13-rc5-dev

Re: [PATCH] push rounding up of relative request to schedule_timeout()

2005-08-04 Thread Nishanth Aravamudan
On 04.08.2005 [20:59:50 +0200], Roman Zippel wrote: Hi, On Thu, 4 Aug 2005, Nishanth Aravamudan wrote: The comment for schedule_timeout() claims: * Make the current task sleep until @timeout jiffies have * elapsed. Currently, it does not do so. I was simply trying to make

Re: Patch of a new driver for kernel 2.4.x that need review

2005-08-09 Thread Nishanth Aravamudan
On 09.08.2005 [09:56:27 -0700], Mark Gross wrote: On Monday 08 August 2005 08:35, Mark Gross wrote: On Wednesday 06 July 2005 14:14, Mark Gross wrote: On Wednesday 22 June 2005 08:12, Bouchard, Sebastien wrote: Hi, Here is a driver (only for 2.4.x) I've done to provide support

Re: [PATCH 1/3] dynticks - implement no idle hz for x86

2005-09-05 Thread Nishanth Aravamudan
On 05.09.2005 [13:08:20 +1000], Con Kolivas wrote: On Mon, 5 Sep 2005 06:37 am, Nishanth Aravamudan wrote: On 04.09.2005 [21:26:16 +0100], Russell King wrote: On Sun, Sep 04, 2005 at 01:10:54PM -0700, Nishanth Aravamudan wrote: I've got a few ideas that I think might help push Con's

Re: [PATCH 1/3] dynticks - implement no idle hz for x86

2005-09-05 Thread Nishanth Aravamudan
On 05.09.2005 [09:00:28 +0100], Russell King wrote: On Mon, Sep 05, 2005 at 01:19:28PM +0530, Srivatsa Vaddagiri wrote: Despite that, the timers as implemented on the hardware are not suitable for dyntick use - attempting to use them, you lose long term precision of the timer interrupts.

  1   2   3   4   5   6   >