[PATCH 3/3] md/bitmap: fix list_entry_rcu usage.

Signed-off-by: Patrick Marlier patrick.marl...@gmail.com --- drivers/md/bitmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c index 3a57679..ed00e46 100644 --- a/drivers/md/bitmap.c +++ b/drivers/md/bitmap.c @@ -181,7 +181,7

[PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

Change to read effectively ptr with rcu_dereference_raw and not the __ptr variable on the stack. Signed-off-by: Patrick Marlier patrick.marl...@gmail.com --- include/linux/rculist.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/linux/rculist.h b/include/linux

[PATCH 2/3] netfilter: fix list_entry_rcu usage.

Signed-off-by: Patrick Marlier patrick.marl...@gmail.com --- net/netfilter/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/core.c b/net/netfilter/core.c index fea9ef5..05bd311 100644 --- a/net/netfilter/core.c +++ b/net/netfilter/core.c @@ -174,7 +174,7

[PATCH 0/3] rculist: Fix list_entry_rcu to read ptr with, rcu_dereference_raw

differently. Fixing this showed 2 problems in the usage of list_entry_rcu. Since it touches other parts of kernel, I guess it requires ack from other maintainers. Thanks. PS: I will Cc the others maintainers when somebody confirms the problem. Signed-off-by: Patrick Marlier patrick.marl

Re: [PATCH 2/3] netfilter: fix list_entry_rcu usage.

On 03/25/2015 03:36 PM, Paul E. McKenney wrote: On Tue, Mar 24, 2015 at 11:31:44AM +0100, Patrick Marlier wrote: Signed-off-by: Patrick Marlierpatrick.marl...@gmail.com --- net/netfilter/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/core.c b/net

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

On 03/25/2015 03:30 PM, Paul E. McKenney wrote: On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: Change to read effectively ptr with rcu_dereference_raw and not the __ptr variable on the stack. Signed-off-by: Patrick Marlier patrick.marl...@gmail.com Avoiding an extra load

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

On 05/13/2015 04:58 AM, NeilBrown wrote: On Tue, 12 May 2015 22:38:53 -0400 Steven Rostedt rost...@goodmis.org wrote: On Tue, 12 May 2015 15:46:26 -0700 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: From: Patrick Marlier patrick.marl...@gmail.com Signed-off-by: Patrick Marlier

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

On Mon, May 18, 2015 at 4:06 AM, NeilBrown ne...@suse.de wrote: On Sat, 16 May 2015 19:42:54 +0200 Patrick Marlier patrick.marl...@gmail.com wrote: On 05/13/2015 04:58 AM, NeilBrown wrote: On Tue, 12 May 2015 22:38:53 -0400 Steven Rostedt rost...@goodmis.org wrote: On Tue, 12 May 2015 15

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

On 05/18/2015 03:53 PM, Patrick Marlier wrote: On Mon, May 18, 2015 at 4:06 AM, NeilBrown ne...@suse.de wrote: On Sat, 16 May 2015 19:42:54 +0200 Patrick Marlier patrick.marl...@gmail.com wrote: On 05/13/2015 04:58 AM, NeilBrown wrote: On Tue, 12 May 2015 22:38:53 -0400 Steven Rostedt rost

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

at 04:01:24PM +0100, Patrick Marlier wrote: On 03/25/2015 03:30 PM, Paul E. McKenney wrote: On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: Change to read effectively ptr with rcu_dereference_raw and not the __ptr variable on the stack. Signed-off-by: Patrick Marlier

Re: [PATCH tip/core/rcu 11/13] rculist: Make list_entry_rcu() use lockless_dereference()

On 10/28/2015 09:33 AM, Ingo Molnar wrote: * Tejun Heo wrote: Subject: writeback: don't use list_entry_rcu() for pointer offsetting in bdi_split_work_to_wbs() bdi_split_work_to_wbs() uses list_for_each_entry_rcu_continue() to walk @bdi->wb_list. To set up the initial

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

On 09/12/2015 01:05 AM, Paul E. McKenney wrote: On Tue, May 19, 2015 at 03:07:25PM -0700, Paul E. McKenney wrote: On Mon, May 18, 2015 at 09:43:21AM -0400, Steven Rostedt wrote: On Mon, 18 May 2015 12:06:47 +1000 NeilBrown wrote: struct mddev { ... struct list_head

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

On 09/22/2015 10:50 PM, Paul E. McKenney wrote: On Sun, Sep 13, 2015 at 09:10:24AM -0700, Paul E. McKenney wrote: On Sun, Sep 13, 2015 at 12:06:33PM +0200, Patrick Marlier wrote: [ . . . ] Paul, This sounds good to me. It should fix the performance issue (will check with my benchmark

[PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

Change to read effectively ptr with rcu_dereference_raw and not the __ptr variable on the stack. Signed-off-by: Patrick Marlier --- include/linux/rculist.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/linux/rculist.h b/include/linux/rculist.h index a18b16f

[PATCH 2/3] netfilter: fix list_entry_rcu usage.

Signed-off-by: Patrick Marlier --- net/netfilter/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/core.c b/net/netfilter/core.c index fea9ef5..05bd311 100644 --- a/net/netfilter/core.c +++ b/net/netfilter/core.c @@ -174,7 +174,7 @@ int nf_hook_slow

[PATCH 0/3] rculist: Fix list_entry_rcu to read ptr with, rcu_dereference_raw

y this can be fixed differently. Fixing this showed 2 problems in the usage of list_entry_rcu. Since it touches other parts of kernel, I guess it requires ack from other maintainers. Thanks. PS: I will Cc the others maintainers when somebody confirms the problem. Signed-off-by: Patrick

[PATCH 3/3] md/bitmap: fix list_entry_rcu usage.

Signed-off-by: Patrick Marlier --- drivers/md/bitmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c index 3a57679..ed00e46 100644 --- a/drivers/md/bitmap.c +++ b/drivers/md/bitmap.c @@ -181,7 +181,7 @@ static struct md_rdev

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

On 03/25/2015 03:30 PM, Paul E. McKenney wrote: On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: Change to read effectively ptr with rcu_dereference_raw and not the __ptr variable on the stack. Signed-off-by: Patrick Marlier Avoiding an extra load could be worthwhile

Re: [PATCH 2/3] netfilter: fix list_entry_rcu usage.

On 03/25/2015 03:36 PM, Paul E. McKenney wrote: On Tue, Mar 24, 2015 at 11:31:44AM +0100, Patrick Marlier wrote: >Signed-off-by: Patrick Marlier >--- > net/netfilter/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/net/netfilter/core.c b/ne

Re: [PATCH 1/3] rculist: Fix list_entry_rcu to read ptr with rcu_dereference_raw

4PM +0100, Patrick Marlier wrote: >> > On 03/25/2015 03:30 PM, Paul E. McKenney wrote: >> > >On Tue, Mar 24, 2015 at 11:31:38AM +0100, Patrick Marlier wrote: >> > >>Change to read effectively ptr with rcu_dereference_raw and not the >> > >>__ptr

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

On 05/13/2015 04:58 AM, NeilBrown wrote: On Tue, 12 May 2015 22:38:53 -0400 Steven Rostedt wrote: On Tue, 12 May 2015 15:46:26 -0700 "Paul E. McKenney" wrote: From: Patrick Marlier Signed-off-by: Patrick Marlier Signed-off-by: Paul E. McKenney --- drivers/md/bitmap.c

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

On Mon, May 18, 2015 at 4:06 AM, NeilBrown wrote: > On Sat, 16 May 2015 19:42:54 +0200 Patrick Marlier > wrote: >> On 05/13/2015 04:58 AM, NeilBrown wrote: >> > On Tue, 12 May 2015 22:38:53 -0400 Steven Rostedt >> > wrote: >> >> On Tue, 12 May 2

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

On 05/18/2015 03:53 PM, Patrick Marlier wrote: On Mon, May 18, 2015 at 4:06 AM, NeilBrown wrote: On Sat, 16 May 2015 19:42:54 +0200 Patrick Marlier wrote: On 05/13/2015 04:58 AM, NeilBrown wrote: On Tue, 12 May 2015 22:38:53 -0400 Steven Rostedt wrote: On Tue, 12 May 2015 15:46:26 -0700

Re: [PATCH tip/core/rcu 11/13] rculist: Make list_entry_rcu() use lockless_dereference()

On 10/28/2015 09:33 AM, Ingo Molnar wrote: * Tejun Heo wrote: Subject: writeback: don't use list_entry_rcu() for pointer offsetting in bdi_split_work_to_wbs() bdi_split_work_to_wbs() uses list_for_each_entry_rcu_continue() to walk @bdi->wb_list. To set up the initial iteration

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

On 09/22/2015 10:50 PM, Paul E. McKenney wrote: On Sun, Sep 13, 2015 at 09:10:24AM -0700, Paul E. McKenney wrote: On Sun, Sep 13, 2015 at 12:06:33PM +0200, Patrick Marlier wrote: [ . . . ] Paul, This sounds good to me. It should fix the performance issue (will check with my benchmark

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

On 09/12/2015 01:05 AM, Paul E. McKenney wrote: On Tue, May 19, 2015 at 03:07:25PM -0700, Paul E. McKenney wrote: On Mon, May 18, 2015 at 09:43:21AM -0400, Steven Rostedt wrote: On Mon, 18 May 2015 12:06:47 +1000 NeilBrown wrote: struct mddev { ... struct list_head