[PATCH] powerpc: re-enable dynticks

2015-02-13 Thread Paul Clarke
/* _ASM_IRQ_WORK_H */ -- Regards, Paul Clarke, IBM -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH v2] powerpc: re-enable dynticks

2015-02-20 Thread Paul Clarke
implement arch_irq_work_has_interrupt() for powerpc Commit 9b01f5bf3 introduced a dependency on IRQ work self-IPIs for full dynamic ticks to be enabled, by expecting architectures to implement a suitable arch_irq_work_has_interrupt() routine. Several arches have implemented this routine,

[PATCH v2] powerpc: re-enable dynticks

2015-02-20 Thread Paul Clarke
implement arch_irq_work_has_interrupt() for powerpc (resending because I messed up the e-mail addresses) Commit 9b01f5bf3 introduced a dependency on IRQ work self-IPIs for full dynamic ticks to be enabled, by expecting architectures to implement a suitable arch_irq_work_has_interrupt()

Re: [PATCH perf/core ] [BUGFIX] perf probe: Fix a segfault when removing uprobe events

2015-09-18 Thread Paul Clarke
On 09/16/2015 07:52 AM, Masami Hiramatsu wrote: Fix a segfault bug and a small mistake in perf probe -d. Since the "ulist" in perf_del_probe_events is never initialized, strlist__add(ulist, *) always causes a segfault when removing uprobe events by perf probe -d. Also, the "str" local variable

Re: [PATCH] cpufreq: powernv: Redesign the presentation of throttle notification

2015-12-14 Thread Paul Clarke
On 12/13/2015 12:17 PM, Shilpasri G Bhat wrote: Replace the throttling event console messages to perf trace event "power:powernv_throttle" and throttle counter stats which are exported in sysfs. The newly added sysfs files are as follows: 1)/sys/devices/system/node/node0/throttle_frequencies

Re: [PATCH 2/2] powerpc/pseries: Dynamically increase RMA size

2016-08-05 Thread Paul Clarke
Only nits from me...(see below) On 08/05/2016 01:30 PM, Sukadev Bhattiprolu wrote: Here is an updated patch to fix the build when CONFIG_PPC_PSERIES=n. --- From d4f77a6ca7b6ea83f6588e7d541cc70bf001ae85 Mon Sep 17 00:00:00 2001 From: root Date: Thu, 4 Aug 2016

Re: perf event grouping for dummies (was Re: [PATCH] arc: perf: Enable generic "cache-references" and "cache-misses" events)

2016-09-21 Thread Paul Clarke
it's possible for the _groups_ to be multiplexed with other events or groups, but the group as a whole will be scheduled together, as a group. If you have a single counter, I don't believe you can support perf event groups, by definition. Regards, Paul Clarke, IBM

Re: perf event grouping for dummies (was Re: [PATCH] arc: perf: Enable generic "cache-references" and "cache-misses" events)

2016-09-22 Thread Paul Clarke
On 09/22/2016 12:50 PM, Vineet Gupta wrote: On 09/22/2016 12:56 AM, Peter Zijlstra wrote: On Wed, Sep 21, 2016 at 07:43:28PM -0500, Paul Clarke wrote: On 09/20/2016 03:56 PM, Vineet Gupta wrote: On 09/01/2016 01:33 AM, Peter Zijlstra wrote: - is that what perf event grouping is ? Again

[PATCH v2] Allow user probes on versioned symbols

2017-03-30 Thread Paul Clarke
= n->rb_left; @@ -429,7 +429,7 @@ static struct symbol *symbols__find_by_name(struct rb_root *symbols, struct symbol_name_rb_node *tmp; tmp = rb_entry(n, struct symbol_name_rb_node, rb_node); - if (arch__compare_symbol_names(tmp->sym.name, s->sym.name)) + if (map__compare_symbol_names(tmp->sym.name, s->sym.name)) break; s = tmp; -- 2.1.4 Regards, Paul Clarke

Re: [PATCH v3] Allow user probes on versioned symbols

2017-03-31 Thread Paul Clarke
On 03/31/2017 12:31 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Mar 31, 2017 at 11:06:16AM -0500, Paul Clarke escreveu: Symbol versioning, as in glibc, results in symbols being defined as: @[@] (Note that "@@" identifies a default symbol, if the symbol name is repeated.) perf is

[PATCH v5] Allow user probes on versioned symbols.

2017-04-12 Thread Paul Clarke
Symbol versioning, as in glibc, results in symbols being defined as: @[@] (Note that "@@" identifies a default symbol, if the symbol name is repeated.) perf is currently unable to deal with this, and is unable to create user probes at such symbols: -- $ nm

Re: [PATCH v4] tools/perf: Allow user probes on versioned symbols

2017-04-06 Thread Paul Clarke
On 04/06/2017 09:36 AM, Arnaldo Carvalho de Melo wrote: Em Wed, Apr 05, 2017 at 10:30:03PM -0500, Paul Clarke escreveu: Symbol versioning, as in glibc, results in symbols being defined as: @[@] (Note that "@@" identifies a default symbol, if the symbol name is repeated.) perf is

[PATCH v4] tools/perf: Allow user probes on versioned symbols

2017-04-05 Thread Paul Clarke
Symbol versioning, as in glibc, results in symbols being defined as: @[@] (Note that "@@" identifies a default symbol, if the symbol name is repeated.) perf is currently unable to deal with this, and is unable to create user probes at such symbols: -- $ nm

Re: [PATCH v3] Allow user probes on versioned symbols

2017-04-05 Thread Paul Clarke
On 04/04/2017 09:26 AM, Arnaldo Carvalho de Melo wrote: Em Tue, Apr 04, 2017 at 11:18:02PM +0900, Masami Hiramatsu escreveu: On Mon, 3 Apr 2017 11:46:58 -0300 Arnaldo Carvalho de Melo wrote: > > > But apart from those problems, I think that one should be able to ask > > > for

Re: [PATCH v4] tools/perf: Allow user probes on versioned symbols

2017-04-10 Thread Paul Clarke
On 04/10/2017 08:11 AM, Masami Hiramatsu wrote: On Wed, 5 Apr 2017 22:30:03 -0500 Paul Clarke <p...@us.ibm.com> wrote: Symbol versioning, as in glibc, results in symbols being defined as: @[@] (Note that "@@" identifies a default symbol, if the symbol name is repeated.) p

Re: [PATCH v4 4/7] powerpc/kprobes: Use safer string functions in kprobe_lookup_name()

2017-04-21 Thread Paul Clarke
On 04/21/2017 07:33 AM, Naveen N. Rao wrote: > Convert usage of strchr()/strncpy()/strncat() to > strnchr()/memcpy()/strlcat() for simpler and safer string manipulation. > > Reported-by: David Laight > Signed-off-by: Naveen N. Rao > ---

Re: [PATCH v4 4/7] powerpc/kprobes: Use safer string functions in kprobe_lookup_name()

2017-04-21 Thread Paul Clarke
On 04/21/2017 08:33 AM, Paul Clarke wrote: > On 04/21/2017 07:33 AM, Naveen N. Rao wrote: >> } else if (name[0] != '.') { >> dot_name[0] = '.'; >> dot_name[1] = '\0'; >> -strncat(dot_name, name, KSYM_NAME_LEN - 2); >> +

Re: [PATCH v4 3/7] kprobes: validate the symbol name provided during probe registration

2017-04-21 Thread Paul Clarke
a nit or two, below... On 04/21/2017 07:32 AM, Naveen N. Rao wrote: > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > index 6a128f3a7ed1..ff9b1ac72a38 100644 > --- a/kernel/kprobes.c > +++ b/kernel/kprobes.c > @@ -1383,6 +1383,34 @@ bool within_kprobe_blacklist(unsigned long addr) > } > >

Re: [PATCH v4 4/7] powerpc/kprobes: Use safer string functions in kprobe_lookup_name()

2017-04-21 Thread Paul Clarke
Sent too soon. The suggestions don't guarantee null termination. Refined, below. (Sorry for the noise.) On 04/21/2017 08:33 AM, Paul Clarke wrote: > On 04/21/2017 07:33 AM, Naveen N. Rao wrote: >> Convert usage of strchr()/strncpy()/strncat() to >> strnchr()/memcpy()/strlca

Re: [PATCH v5] Allow user probes on versioned symbols.

2017-04-13 Thread Paul Clarke
On 04/12/2017 09:20 PM, Masami Hiramatsu wrote: On Wed, 12 Apr 2017 09:41:51 -0500 Paul Clarke <p...@us.ibm.com> wrote: static struct symbol *symbols__find_by_name(struct rb_root *symbols, - const char

[PATCH v6] Allow user probes on versioned symbols

2017-04-13 Thread Paul Clarke
Symbol versioning, as in glibc, results in symbols being defined as: @[@] (Note that "@@" identifies a default symbol, if the symbol name is repeated.) perf is currently unable to deal with this, and is unable to create user probes at such symbols: -- $ nm

Re: [PATCH v6] Allow user probes on versioned symbols

2017-04-20 Thread Paul Clarke
ping On 04/13/2017 12:03 PM, Paul Clarke wrote: > Symbol versioning, as in glibc, results in symbols being defined as: > @[@] > (Note that "@@" identifies a default symbol, if the symbol name > is repeated.) > > perf is currently unable to deal with this, and is un

[PATCH v3] Allow user probes on versioned symbols

2017-03-31 Thread Paul Clarke
Symbol versioning, as in glibc, results in symbols being defined as: @[@] (Note that "@@" identifies a default symbol, if the symbol name is repeated.) perf is currently unable to deal with this, and is unable to create user probes at such symbols: -- $ nm

Re: [PATCH v6] Allow user probes on versioned symbols

2017-04-25 Thread Paul Clarke
On 04/24/2017 11:34 AM, Arnaldo Carvalho de Melo wrote: > Em Thu, Apr 13, 2017 at 12:03:13PM -0500, Paul Clarke escreveu: >> v4: >> - rebased to acme/perf/core > > Are you sure? > > [acme@jouet linux]$ patch -p1 < /wb/1.patch > patching file tools/perf/arch/powe

Re: [PATCH] perf report: don't crash on invalid maps in `-g srcline` mode

2017-05-11 Thread Paul Clarke
On 05/09/2017 03:50 PM, Milian Wolff wrote: > diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c > index 9ab68682c6d0..295f0846fd84 100644 > --- a/tools/perf/util/callchain.c > +++ b/tools/perf/util/callchain.c > @@ -642,13 +642,22 @@ static enum match_result

Re: [PATCH v2 2/5] perf-probe: Cut off the version suffix from event name

2017-12-08 Thread Paul Clarke
On 12/07/2017 09:01 PM, Masami Hiramatsu wrote: > On Thu, 7 Dec 2017 10:34:51 -0600 > Paul Clarke <p...@us.ibm.com> wrote: >> On 12/07/2017 01:20 AM, Masami Hiramatsu wrote: >>> Cut off the version suffix (e.g. @GLIBC_2.2.5 etc.) from >>> automatic generated e

Re: [PATCH v2 2/5] perf-probe: Cut off the version suffix from event name

2017-12-07 Thread Paul Clarke
On 12/07/2017 01:20 AM, Masami Hiramatsu wrote: > Cut off the version suffix (e.g. @GLIBC_2.2.5 etc.) from > automatic generated event name. This fixes wildcard event > adding like below case; > > = > # perf probe -x /lib64/libc-2.25.so malloc* > Internal error:

Re: [PATCH v2 2/5] perf-probe: Cut off the version suffix from event name

2017-12-07 Thread Paul Clarke
On 12/07/2017 10:56 AM, Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 07, 2017 at 04:20:28PM +0900, Masami Hiramatsu escreveu: >> Cut off the version suffix (e.g. @GLIBC_2.2.5 etc.) from >> automatic generated event name. This fixes wildcard event >> adding like below case; >> >> = >> #

Re: [PATCH 42/46] perf script powerpc: Python script for hypervisor call statistics

2018-06-07 Thread Paul Clarke
On 06/07/2018 12:34 AM, Ravi Bangoria wrote: > On 06/06/2018 08:23 PM, Paul Clarke wrote: >> On 06/05/2018 12:50 PM, Arnaldo Carvalho de Melo wrote: >>> From: Ravi Bangoria >>> >>> Add python script to show hypervisor call statistics. Ex, >>> &g

Re: [PATCH 1/3] perf alias: Remove trailing newline when reading sysfs files

2018-06-14 Thread Paul Clarke
On 06/14/2018 06:48 AM, Thomas Richter wrote: > Remove a trailing newline when reading sysfs file contents > such as /sys/devices/cpum_cf/events/TX_NC_TEND. > This show when verbose option -v is used. > > Output before: > tx_nc_tend -> 'cpum_cf'/'event=0x008d > '/ > > Output after: > tx_nc_tend

Re: [PATCH 2/3] perf alias: Rebuild alias expression string to make it comparable

2018-06-14 Thread Paul Clarke
On 06/14/2018 06:48 AM, Thomas Richter wrote: > PMU alias definitions in sysfs files may have spaces, newlines > and number with leading zeroes. Same alias definitions may > also appear in JSON files without spaces, etc. > > Scan alias definitions and remove leading zeroes, spaces, > newlines,

Re: [PATCH 42/46] perf script powerpc: Python script for hypervisor call statistics

2018-06-06 Thread Paul Clarke
On 06/05/2018 12:50 PM, Arnaldo Carvalho de Melo wrote: > From: Ravi Bangoria > > Add python script to show hypervisor call statistics. Ex, > > # perf record -a -e "{powerpc:hcall_entry,powerpc:hcall_exit}" > # perf script -s scripts/python/powerpc-hcalls.py > hcall

Re: [PATCH v2 2/5] perf-probe: Cut off the version suffix from event name

2017-12-07 Thread Paul Clarke
On 12/07/2017 01:20 AM, Masami Hiramatsu wrote: > Cut off the version suffix (e.g. @GLIBC_2.2.5 etc.) from > automatic generated event name. This fixes wildcard event > adding like below case; > > = > # perf probe -x /lib64/libc-2.25.so malloc* > Internal error:

Re: [PATCH v2 2/5] perf-probe: Cut off the version suffix from event name

2017-12-07 Thread Paul Clarke
On 12/07/2017 10:56 AM, Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 07, 2017 at 04:20:28PM +0900, Masami Hiramatsu escreveu: >> Cut off the version suffix (e.g. @GLIBC_2.2.5 etc.) from >> automatic generated event name. This fixes wildcard event >> adding like below case; >> >> = >> #

Re: [PATCH v2 2/5] perf-probe: Cut off the version suffix from event name

2017-12-08 Thread Paul Clarke
On 12/07/2017 09:01 PM, Masami Hiramatsu wrote: > On Thu, 7 Dec 2017 10:34:51 -0600 > Paul Clarke wrote: >> On 12/07/2017 01:20 AM, Masami Hiramatsu wrote: >>> Cut off the version suffix (e.g. @GLIBC_2.2.5 etc.) from >>> automatic generated event name. This fixes

[PATCH 3/4] [powerpc] perf vendor events: Add JSON metrics for POWER9

2019-02-09 Thread Paul Clarke
Descriptions of metrics for POWER9 processors can be found in the "POWER9 Performance Monitor Unit User’s Guide", which is currently available on the "IBM Portal for OpenPOWER" (https://www-355.ibm.com/systems/power/openpower/welcome.xhtml) at

[PATCH 1/4] [powerpc] perf vendor events: Add JSON metrics for POWER9

2019-02-09 Thread Paul Clarke
Descriptions of metrics for POWER9 processors can be found in the "POWER9 Performance Monitor Unit User’s Guide", which is currently available on the "IBM Portal for OpenPOWER" (https://www-355.ibm.com/systems/power/openpower/welcome.xhtml) at

[PATCH v2 0/4] [powerpc] perf vendor events: Add JSON metrics for POWER9

2019-02-09 Thread Paul Clarke
[Note this is for POWER*9* and is different content than a previous patchset for POWER*8*.] The patches define metrics and metric groups for computation by "perf" for POWER9 processors. Paul Clarke (4): [powerpc] perf vendor events: Add JSON metrics for POWER9 [powerpc] perf ven

[PATCH 4/4] [powerpc] perf vendor events: Add JSON metrics for POWER9

2019-02-09 Thread Paul Clarke
Descriptions of metrics for POWER9 processors can be found in the "POWER9 Performance Monitor Unit User’s Guide", which is currently available on the "IBM Portal for OpenPOWER" (https://www-355.ibm.com/systems/power/openpower/welcome.xhtml) at

[PATCH 2/4] [powerpc] perf vendor events: Add JSON metrics for POWER9

2019-02-09 Thread Paul Clarke
Descriptions of metrics for POWER9 processors can be found in the "POWER9 Performance Monitor Unit User’s Guide", which is currently available on the "IBM Portal for OpenPOWER" (https://www-355.ibm.com/systems/power/openpower/welcome.xhtml) at

[PATCH v2 0/4] [powerpc] perf vendor events: Add JSON metrics for POWER8

2019-02-07 Thread Paul Clarke
The patches define metrics and metric groups for computation by "perf" for POWER8 processors. Paul Clarke (4): [powerpc] perf vendor events: Add JSON metrics for POWER8 1/4 [powerpc] perf vendor events: Add JSON metrics for POWER8 2/4 [powerpc] perf vendor events: Add JS

[PATCH v2 1/4] [powerpc] perf vendor events: Add JSON metrics for POWER8

2019-02-07 Thread Paul Clarke
POWER8 metrics not well publicized. Some are here: https://www.ibm.com/support/knowledgecenter/en/SSFK5S_2.2.0/com.ibm.cluster.pedev.v2r2.pedev100.doc/bl7ug_derivedmetricspower8.htm This patch is for metric groups: - cpi_breakdown - estimated_dcache_miss_cpi Signed-off-by: Paul A. Clarke ---

[PATCH v2 4/4] [powerpc] perf vendor events: Add JSON metrics for POWER8

2019-02-07 Thread Paul Clarke
POWER8 metrics not well publicized. Some are here: https://www.ibm.com/support/knowledgecenter/en/SSFK5S_2.2.0/com.ibm.cluster.pedev.v2r2.pedev100.doc/bl7ug_derivedmetricspower8.htm This patch is for metric groups: - translation - general and other metrics not in a metric group. Signed-off-by:

[PATCH v2 2/4] [powerpc] perf vendor events: Add JSON metrics for POWER8

2019-02-07 Thread Paul Clarke
POWER8 metrics not well publicized. Some are here: https://www.ibm.com/support/knowledgecenter/en/SSFK5S_2.2.0/com.ibm.cluster.pedev.v2r2.pedev100.doc/bl7ug_derivedmetricspower8.htm This patch is for metric groups: - dl1_reloads_percent_per_inst - dl1_reloads_percent_per_ref -

[PATCH v2 3/4] [powerpc] perf vendor events: Add JSON metrics for POWER8

2019-02-07 Thread Paul Clarke
POWER8 metrics not well publicized. Some are here: https://www.ibm.com/support/knowledgecenter/en/SSFK5S_2.2.0/com.ibm.cluster.pedev.v2r2.pedev100.doc/bl7ug_derivedmetricspower8.htm This patch is for metric groups: - branch_prediction - latency - bus_stats - instruction_mix -

Re: perf tools:Is there any tools to found out the max latency by irq or cpu idle

2019-04-15 Thread Paul Clarke
On 4/13/19 1:01 AM, Linhaifeng wrote: > Sorry, the value 131081408 is just for example. Actually the result is like > this: > sqrt 2019-04-10 23:53:50: 43968 > sqrt 2019-04-10 23:53:51: 44060 > sqrt 2019-04-10 23:53:52: 49012 > sqrt 2019-04-10 23:53:53: 38172 > sqrt 2019-04-10 23:53:54:

Re: [PATCH 1/3] perf alias: Remove trailing newline when reading sysfs files

2018-06-14 Thread Paul Clarke
On 06/14/2018 06:48 AM, Thomas Richter wrote: > Remove a trailing newline when reading sysfs file contents > such as /sys/devices/cpum_cf/events/TX_NC_TEND. > This show when verbose option -v is used. > > Output before: > tx_nc_tend -> 'cpum_cf'/'event=0x008d > '/ > > Output after: > tx_nc_tend

Re: [PATCH 2/3] perf alias: Rebuild alias expression string to make it comparable

2018-06-14 Thread Paul Clarke
On 06/14/2018 06:48 AM, Thomas Richter wrote: > PMU alias definitions in sysfs files may have spaces, newlines > and number with leading zeroes. Same alias definitions may > also appear in JSON files without spaces, etc. > > Scan alias definitions and remove leading zeroes, spaces, > newlines,

Re: [PATCH 42/46] perf script powerpc: Python script for hypervisor call statistics

2018-06-06 Thread Paul Clarke
On 06/05/2018 12:50 PM, Arnaldo Carvalho de Melo wrote: > From: Ravi Bangoria > > Add python script to show hypervisor call statistics. Ex, > > # perf record -a -e "{powerpc:hcall_entry,powerpc:hcall_exit}" > # perf script -s scripts/python/powerpc-hcalls.py > hcall

Re: [PATCH 42/46] perf script powerpc: Python script for hypervisor call statistics

2018-06-07 Thread Paul Clarke
On 06/07/2018 12:34 AM, Ravi Bangoria wrote: > On 06/06/2018 08:23 PM, Paul Clarke wrote: >> On 06/05/2018 12:50 PM, Arnaldo Carvalho de Melo wrote: >>> From: Ravi Bangoria >>> >>> Add python script to show hypervisor call statistics. Ex, >>> &g

[PATCH] powerpc: re-enable dynticks

2015-02-13 Thread Paul Clarke
5ec --- /dev/null +++ b/arch/powerpc/include/asm/irq_work.h @@ -0,0 +1,11 @@ +#ifndef _ASM_IRQ_WORK_H +#define _ASM_IRQ_WORK_H + +#include + +static inline bool arch_irq_work_has_interrupt(void) +{ + return 1; +} + +#endif /* _ASM_IRQ_WORK_H */ -- Regards, Paul Clarke, IBM -- To unsubscri

[PATCH v2] powerpc: re-enable dynticks

2015-02-20 Thread Paul Clarke
implement arch_irq_work_has_interrupt() for powerpc Commit 9b01f5bf3 introduced a dependency on "IRQ work self-IPIs" for full dynamic ticks to be enabled, by expecting architectures to implement a suitable arch_irq_work_has_interrupt() routine. Several arches have implemented this routine,

[PATCH v2] powerpc: re-enable dynticks

2015-02-20 Thread Paul Clarke
implement arch_irq_work_has_interrupt() for powerpc (resending because I messed up the e-mail addresses) Commit 9b01f5bf3 introduced a dependency on "IRQ work self-IPIs" for full dynamic ticks to be enabled, by expecting architectures to implement a suitable arch_irq_work_has_interrupt()

Re: perf event grouping for dummies (was Re: [PATCH] arc: perf: Enable generic "cache-references" and "cache-misses" events)

2016-09-21 Thread Paul Clarke
it's possible for the _groups_ to be multiplexed with other events or groups, but the group as a whole will be scheduled together, as a group. If you have a single counter, I don't believe you can support perf event groups, by definition. Regards, Paul Clarke, IBM

Re: perf event grouping for dummies (was Re: [PATCH] arc: perf: Enable generic "cache-references" and "cache-misses" events)

2016-09-22 Thread Paul Clarke
On 09/22/2016 12:50 PM, Vineet Gupta wrote: On 09/22/2016 12:56 AM, Peter Zijlstra wrote: On Wed, Sep 21, 2016 at 07:43:28PM -0500, Paul Clarke wrote: On 09/20/2016 03:56 PM, Vineet Gupta wrote: On 09/01/2016 01:33 AM, Peter Zijlstra wrote: - is that what perf event grouping is ? Again

Re: [PATCH v6] Allow user probes on versioned symbols

2017-04-20 Thread Paul Clarke
ping On 04/13/2017 12:03 PM, Paul Clarke wrote: > Symbol versioning, as in glibc, results in symbols being defined as: > @[@] > (Note that "@@" identifies a default symbol, if the symbol name > is repeated.) > > perf is currently unable to deal with this, and is un

Re: [PATCH v4 3/7] kprobes: validate the symbol name provided during probe registration

2017-04-21 Thread Paul Clarke
a nit or two, below... On 04/21/2017 07:32 AM, Naveen N. Rao wrote: > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > index 6a128f3a7ed1..ff9b1ac72a38 100644 > --- a/kernel/kprobes.c > +++ b/kernel/kprobes.c > @@ -1383,6 +1383,34 @@ bool within_kprobe_blacklist(unsigned long addr) > } > >

Re: [PATCH v4 4/7] powerpc/kprobes: Use safer string functions in kprobe_lookup_name()

2017-04-21 Thread Paul Clarke
On 04/21/2017 07:33 AM, Naveen N. Rao wrote: > Convert usage of strchr()/strncpy()/strncat() to > strnchr()/memcpy()/strlcat() for simpler and safer string manipulation. > > Reported-by: David Laight > Signed-off-by: Naveen N. Rao > --- > Changes: Additionally convert the strchr(). > > >

Re: [PATCH v4 4/7] powerpc/kprobes: Use safer string functions in kprobe_lookup_name()

2017-04-21 Thread Paul Clarke
On 04/21/2017 08:33 AM, Paul Clarke wrote: > On 04/21/2017 07:33 AM, Naveen N. Rao wrote: >> } else if (name[0] != '.') { >> dot_name[0] = '.'; >> dot_name[1] = '\0'; >> -strncat(dot_name, name, KSYM_NAME_LEN - 2); >> +

Re: [PATCH v4 4/7] powerpc/kprobes: Use safer string functions in kprobe_lookup_name()

2017-04-21 Thread Paul Clarke
Sent too soon. The suggestions don't guarantee null termination. Refined, below. (Sorry for the noise.) On 04/21/2017 08:33 AM, Paul Clarke wrote: > On 04/21/2017 07:33 AM, Naveen N. Rao wrote: >> Convert usage of strchr()/strncpy()/strncat() to >> strnchr()/memcpy()/strlca

[PATCH v5] Allow user probes on versioned symbols.

2017-04-12 Thread Paul Clarke
Symbol versioning, as in glibc, results in symbols being defined as: @[@] (Note that "@@" identifies a default symbol, if the symbol name is repeated.) perf is currently unable to deal with this, and is unable to create user probes at such symbols: -- $ nm

Re: [PATCH v5] Allow user probes on versioned symbols.

2017-04-13 Thread Paul Clarke
On 04/12/2017 09:20 PM, Masami Hiramatsu wrote: On Wed, 12 Apr 2017 09:41:51 -0500 Paul Clarke wrote: static struct symbol *symbols__find_by_name(struct rb_root *symbols, - const char *name) + const char

[PATCH v6] Allow user probes on versioned symbols

2017-04-13 Thread Paul Clarke
Symbol versioning, as in glibc, results in symbols being defined as: @[@] (Note that "@@" identifies a default symbol, if the symbol name is repeated.) perf is currently unable to deal with this, and is unable to create user probes at such symbols: -- $ nm

Re: [PATCH] perf report: don't crash on invalid maps in `-g srcline` mode

2017-05-11 Thread Paul Clarke
On 05/09/2017 03:50 PM, Milian Wolff wrote: > diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c > index 9ab68682c6d0..295f0846fd84 100644 > --- a/tools/perf/util/callchain.c > +++ b/tools/perf/util/callchain.c > @@ -642,13 +642,22 @@ static enum match_result

[PATCH v4] tools/perf: Allow user probes on versioned symbols

2017-04-05 Thread Paul Clarke
Symbol versioning, as in glibc, results in symbols being defined as: @[@] (Note that "@@" identifies a default symbol, if the symbol name is repeated.) perf is currently unable to deal with this, and is unable to create user probes at such symbols: -- $ nm

Re: [PATCH v3] Allow user probes on versioned symbols

2017-04-05 Thread Paul Clarke
On 04/04/2017 09:26 AM, Arnaldo Carvalho de Melo wrote: Em Tue, Apr 04, 2017 at 11:18:02PM +0900, Masami Hiramatsu escreveu: On Mon, 3 Apr 2017 11:46:58 -0300 Arnaldo Carvalho de Melo wrote: > > > But apart from those problems, I think that one should be able to ask > > > for a versioned

Re: [PATCH v4] tools/perf: Allow user probes on versioned symbols

2017-04-06 Thread Paul Clarke
On 04/06/2017 09:36 AM, Arnaldo Carvalho de Melo wrote: Em Wed, Apr 05, 2017 at 10:30:03PM -0500, Paul Clarke escreveu: Symbol versioning, as in glibc, results in symbols being defined as: @[@] (Note that "@@" identifies a default symbol, if the symbol name is repeated.) perf is

Re: [PATCH v4] tools/perf: Allow user probes on versioned symbols

2017-04-10 Thread Paul Clarke
On 04/10/2017 08:11 AM, Masami Hiramatsu wrote: On Wed, 5 Apr 2017 22:30:03 -0500 Paul Clarke wrote: Symbol versioning, as in glibc, results in symbols being defined as: @[@] (Note that "@@" identifies a default symbol, if the symbol name is repeated.) perf is currently unab

Re: [PATCH v6] Allow user probes on versioned symbols

2017-04-25 Thread Paul Clarke
On 04/24/2017 11:34 AM, Arnaldo Carvalho de Melo wrote: > Em Thu, Apr 13, 2017 at 12:03:13PM -0500, Paul Clarke escreveu: >> v4: >> - rebased to acme/perf/core > > Are you sure? > > [acme@jouet linux]$ patch -p1 < /wb/1.patch > patching file tools/perf/arch/powe

[PATCH v2] Allow user probes on versioned symbols

2017-03-30 Thread Paul Clarke
tic struct symbol *symbols__find_by_name(struct rb_root *symbols, struct symbol_name_rb_node *tmp; tmp = rb_entry(n, struct symbol_name_rb_node, rb_node); - if (arch__compare_symbol_names(tmp->sym.name, s->sym.name)) + if (map__compare_symbol_names(tmp->sym.name, s->sym.name)) break; s = tmp; -- 2.1.4 Regards, Paul Clarke

[PATCH v3] Allow user probes on versioned symbols

2017-03-31 Thread Paul Clarke
Symbol versioning, as in glibc, results in symbols being defined as: @[@] (Note that "@@" identifies a default symbol, if the symbol name is repeated.) perf is currently unable to deal with this, and is unable to create user probes at such symbols: -- $ nm

Re: [PATCH v3] Allow user probes on versioned symbols

2017-03-31 Thread Paul Clarke
On 03/31/2017 12:31 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Mar 31, 2017 at 11:06:16AM -0500, Paul Clarke escreveu: Symbol versioning, as in glibc, results in symbols being defined as: @[@] (Note that "@@" identifies a default symbol, if the symbol name is repeated.) perf is

Re: [PATCH] cpufreq: powernv: Redesign the presentation of throttle notification

2015-12-14 Thread Paul Clarke
On 12/13/2015 12:17 PM, Shilpasri G Bhat wrote: Replace the throttling event console messages to perf trace event "power:powernv_throttle" and throttle counter stats which are exported in sysfs. The newly added sysfs files are as follows: 1)/sys/devices/system/node/node0/throttle_frequencies

Re: [PATCH 2/2] powerpc/pseries: Dynamically increase RMA size

2016-08-05 Thread Paul Clarke
Only nits from me...(see below) On 08/05/2016 01:30 PM, Sukadev Bhattiprolu wrote: Here is an updated patch to fix the build when CONFIG_PPC_PSERIES=n. --- From d4f77a6ca7b6ea83f6588e7d541cc70bf001ae85 Mon Sep 17 00:00:00 2001 From: root Date: Thu, 4 Aug 2016 23:13:37 -0400 Subject: [PATCH

Re: [PATCH perf/core ] [BUGFIX] perf probe: Fix a segfault when removing uprobe events

2015-09-18 Thread Paul Clarke
On 09/16/2015 07:52 AM, Masami Hiramatsu wrote: Fix a segfault bug and a small mistake in perf probe -d. Since the "ulist" in perf_del_probe_events is never initialized, strlist__add(ulist, *) always causes a segfault when removing uprobe events by perf probe -d. Also, the "str" local variable

[tip:perf/urgent] perf symbols: Allow user probes on versioned symbols

2017-05-03 Thread tip-bot for Paul Clarke
Commit-ID: d80406453ad4a69932dc17a617d5b7bc7ae80b8f Gitweb: http://git.kernel.org/tip/d80406453ad4a69932dc17a617d5b7bc7ae80b8f Author: Paul Clarke <p...@us.ibm.com> AuthorDate: Tue, 25 Apr 2017 13:15:49 -0500 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitDate

[tip:perf/core] perf vendor events power8: Cpi_breakdown & estimated_dcache_miss_cpi metrics

2019-02-15 Thread tip-bot for Paul Clarke
Commit-ID: dd81eafacc52961ed1b2bf3e998b92ccfd9108bc Gitweb: https://git.kernel.org/tip/dd81eafacc52961ed1b2bf3e998b92ccfd9108bc Author: Paul Clarke AuthorDate: Thu, 7 Feb 2019 12:53:11 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 14 Feb 2019 13:31:08 -0300 perf vendor

[tip:perf/core] perf vendor events power8: Dl1_reload, instruction_misses, l2_stats, lsu_rejects, memory & pteg_reloads metrics

2019-02-15 Thread tip-bot for Paul Clarke
Commit-ID: ffe18505ba1d641a4935321d3c525e4e2efd64c3 Gitweb: https://git.kernel.org/tip/ffe18505ba1d641a4935321d3c525e4e2efd64c3 Author: Paul Clarke AuthorDate: Thu, 7 Feb 2019 12:53:12 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 14 Feb 2019 13:31:09 -0300 perf vendor

[tip:perf/core] perf vendor events power8: Branch_prediction, latency, bus_stats, instruction_mix & instruction_stats metrics

2019-02-15 Thread tip-bot for Paul Clarke
Commit-ID: 69ba708f4df6250dfa0410297024eeedd7ab3362 Gitweb: https://git.kernel.org/tip/69ba708f4df6250dfa0410297024eeedd7ab3362 Author: Paul Clarke AuthorDate: Thu, 7 Feb 2019 12:53:13 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 14 Feb 2019 13:31:09 -0300 perf vendor

[tip:perf/core] perf vendor events power9: Cpi_breakdown & estimated_dcache_miss_cpi metrics

2019-02-15 Thread tip-bot for Paul Clarke
Commit-ID: 7f3cf5ac7743f924753a2c75fd71317e418844d0 Gitweb: https://git.kernel.org/tip/7f3cf5ac7743f924753a2c75fd71317e418844d0 Author: Paul Clarke AuthorDate: Sat, 9 Feb 2019 13:14:26 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 14 Feb 2019 13:31:10 -0300 perf vendor

[tip:perf/core] perf vendor events power8: Translaton & general metrics

2019-02-15 Thread tip-bot for Paul Clarke
Commit-ID: 72ab50203f3f588c2b64c68f11a28ef56a8ff1a1 Gitweb: https://git.kernel.org/tip/72ab50203f3f588c2b64c68f11a28ef56a8ff1a1 Author: Paul Clarke AuthorDate: Thu, 7 Feb 2019 12:53:14 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 14 Feb 2019 13:31:10 -0300 perf vendor

[tip:perf/core] perf vendor events power9: Branch_prediction, instruction_stats, latency, lsu_rejects, memory, prefetch & translation metrics

2019-02-15 Thread tip-bot for Paul Clarke
Commit-ID: a4d832726471963b327fae33f14fa28c83db6a0e Gitweb: https://git.kernel.org/tip/a4d832726471963b327fae33f14fa28c83db6a0e Author: Paul Clarke AuthorDate: Sat, 9 Feb 2019 13:14:28 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 14 Feb 2019 13:31:10 -0300 perf vendor

[tip:perf/core] perf vendor events power9: Dl1_reloads, instruction_misses, l[23]_stats & pteg_reloads metrics

2019-02-15 Thread tip-bot for Paul Clarke
Commit-ID: 0133491d4641b493aa0d0e5bd66b52999619cd8a Gitweb: https://git.kernel.org/tip/0133491d4641b493aa0d0e5bd66b52999619cd8a Author: Paul Clarke AuthorDate: Sat, 9 Feb 2019 13:14:27 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 14 Feb 2019 13:31:10 -0300 perf vendor

[tip:perf/core] perf vendor events power9: General metrics

2019-02-15 Thread tip-bot for Paul Clarke
Commit-ID: 33937e599449c65dbd69c60d7e2255012427baed Gitweb: https://git.kernel.org/tip/33937e599449c65dbd69c60d7e2255012427baed Author: Paul Clarke AuthorDate: Sat, 9 Feb 2019 13:14:29 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 14 Feb 2019 13:31:11 -0300 perf vendor

[tip:perf/urgent] perf symbols: Allow user probes on versioned symbols

2017-05-03 Thread tip-bot for Paul Clarke
Commit-ID: d80406453ad4a69932dc17a617d5b7bc7ae80b8f Gitweb: http://git.kernel.org/tip/d80406453ad4a69932dc17a617d5b7bc7ae80b8f Author: Paul Clarke AuthorDate: Tue, 25 Apr 2017 13:15:49 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 2 May 2017 18:23:11 -0300 perf symbols