Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2016-01-03 Thread Paul Kocialkowski
Le jeudi 31 décembre 2015 à 22:14 +, Mark Brown a écrit : > On Thu, Dec 31, 2015 at 10:59:06PM +0100, Paul Kocialkowski wrote: > > > I understand, thanks for pointing this out. Well, for my use case, there > > is no use in disabling the chip at any point as it powers th

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-29 Thread Paul Kocialkowski
Le mardi 29 décembre 2015 à 14:02 -0600, Rob Herring a écrit : > On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > > LP872x regulators are made active via the EN pin, which might be hooked to a > > GPIO. This adds support for driving the GPIO high when the d

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-30 Thread Paul Kocialkowski
Le mercredi 30 décembre 2015 à 16:33 +, Mark Brown a écrit : > On Wed, Dec 30, 2015 at 09:35:21AM +0100, Paul Kocialkowski wrote: > > > In my opinion, it would be more elegant to adapt the core regulator > > framework to first enable the GPIO and then call the regula

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-31 Thread Paul Kocialkowski
Le jeudi 31 décembre 2015 à 21:40 +, Mark Brown a écrit : > On Wed, Dec 30, 2015 at 07:37:19PM +0100, Paul Kocialkowski wrote: > > Le mercredi 30 décembre 2015 à 16:33 +, Mark Brown a écrit : > > > On Wed, Dec 30, 2015 at 09:35:21AM +0100, Paul Kocialkowski wrote: >

Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO

2015-12-23 Thread Paul Kocialkowski
Le mercredi 23 décembre 2015 à 11:41 +, Mark Brown a écrit : > On Wed, Dec 23, 2015 at 11:58:36AM +0100, Paul Kocialkowski wrote: > > Some devices don't hook the DVS pin to a GPIO but to ground or VCC. > > In those cases, it is not a problem to have no DVS GPIO. > > I wo

Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features

2015-12-24 Thread Paul Kocialkowski
please use the IOPAD mux macros from > include/dt-bindings/pinctrl/omap.h instead? > > We just did a massive cleanup on the OMAP DTS to use them instead of > an offset from the padconf registers. Sure thing, will do in v2. Thanks for the review! -- Paul Kocialkowski, Replicant develo

Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features

2015-12-24 Thread Paul Kocialkowski
Hi, Le mercredi 23 décembre 2015 à 07:44 -0800, Tony Lindgren a écrit : > * Paul Kocialkowski <cont...@paulk.fr> [151223 03:00]: > > + { > > + ti,no-reset-on-init; > > +}; > > + > > + { > > + ti,no-reset-on-init; >

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-24 Thread Paul Kocialkowski
Le jeudi 24 décembre 2015 à 19:35 +, Mark Brown a écrit : > On Thu, Dec 24, 2015 at 07:12:53PM +0100, Paul Kocialkowski wrote: > > Le mercredi 23 décembre 2015 à 11:56 +, Mark Brown a écrit : > > > > This isn't really adding support for the enable GPIO as the cha

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-24 Thread Paul Kocialkowski
Le mercredi 23 décembre 2015 à 11:56 +, Mark Brown a écrit : > On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > > > + gpio = lp->pdata->enable_gpio; > > + if (!gpio_is_valid(gpio)) > > + return 0; > > + > > + /* A

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-28 Thread Paul Kocialkowski
Hi Milo, thanks for the review, Le lundi 28 décembre 2015 à 09:56 +0900, Milo Kim a écrit : > Hi Paul, > > On 23/12/15 20:56, Mark Brown wrote: > > On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > > > >> + gpio = lp->pdata->enable_g

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-23 Thread Paul Kocialkowski
Le mercredi 23 décembre 2015 à 11:56 +, Mark Brown a écrit : > On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > > > + gpio = lp->pdata->enable_gpio; > > + if (!gpio_is_valid(gpio)) > > + return 0; > > + > > + /* A

[PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-23 Thread Paul Kocialkowski
LP872x regulators are made active via the EN pin, which might be hooked to a GPIO. This adds support for driving the GPIO high when the driver is in use. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- .../devicetree/bindings/regulator/lp872x.txt | 1 + drivers/regulator/lp

[PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO

2015-12-23 Thread Paul Kocialkowski
The lp872x structure holds a reference to the DVS GPIO, but it is never actually used anywhere, since a first reference exists from the lp872x_dvs structure. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- drivers/regulator/lp872x.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO

2015-12-23 Thread Paul Kocialkowski
Some devices don't hook the DVS pin to a GPIO but to ground or VCC. In those cases, it is not a problem to have no DVS GPIO. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- drivers/regulator/lp872x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/reg

[PATCH 0/6] LG Optimus Black (P970) codename sniper support and lp872x improvements

2015-12-23 Thread Paul Kocialkowski
This series introduces support for the LG Optimus Black, as described in the patch adding devicetree support for the device. In order to power the external mmc (mmc1), the lp872x regulator is used. Its code had to be improved a bit to work on the device. Note that the patch adding devicetree

[PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features

2015-12-23 Thread Paul Kocialkowski
, internal emmc and external mmc. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/omap3-sniper.dts | 220 + 2 files changed, 221 insertions(+) create mode 100644 arch/arm/boot/dts

[PATCH 6/6] ARM: multi_v7_defconfig: Enable LP872x regulator support

2015-12-23 Thread Paul Kocialkowski
The LP872x regulator is used in the LG Optimus Black (P970) codename sniper to supply the external mmc card. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig

[PATCH 1/6] regulator: lp872x: Add missing of_match in regulators descriptions

2015-12-23 Thread Paul Kocialkowski
In order to select the regulators via of_find_regulator_by_node (and thus use them in devicetree), defining of_match for each regulator is required. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- drivers/regulator/lp872x.c | 15 +++ 1 file changed, 15 insertions(+)

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-30 Thread Paul Kocialkowski
Hi Milo, Le mercredi 30 décembre 2015 à 09:22 +0900, Milo Kim a écrit : > Hi Paul, > > On 29/12/15 20:13, Paul Kocialkowski wrote: > > Hi Milo, > > > > Le mardi 29 décembre 2015 à 09:45 +0900, Milo Kim a écrit : > >> Hi Paul, > >> > >> On

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-29 Thread Paul Kocialkowski
Hi Milo, Le mardi 29 décembre 2015 à 09:45 +0900, Milo Kim a écrit : > Hi Paul, > > On 29/12/15 07:49, Paul Kocialkowski wrote: > > Hi Milo, thanks for the review, > > > > Le lundi 28 décembre 2015 à 09:56 +0900, Milo Kim a écrit : > >> Hi Paul, > >

Re: [PATCH v2 3/4] ARM: LG Optimus Black (P970) codename sniper support, with basic features

2016-02-07 Thread Paul Kocialkowski
Hi, Le vendredi 05 février 2016 à 20:39 +0100, Paul Kocialkowski a écrit : > Le vendredi 05 février 2016 à 19:42 +0100, Paul Kocialkowski a écrit : > > The LG Optimus Black (P970) codename sniper is a smartphone that was > > designed > > and manufactured by LG Electronics (L

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2016-02-05 Thread Paul Kocialkowski
Le lundi 28 décembre 2015 à 09:34 +0900, Milo Kim a écrit : > Hi Paul, > > Thanks for the patches. Please see my comments below. Thanks for the review Milo, I have just submitted v2 with those suggestions integrated. > On 23/12/15 19:58, Paul Kocialkowski wrote: > > LP872x r

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2016-02-05 Thread Paul Kocialkowski
Hi, Le lundi 18 janvier 2016 à 16:32 +, Mark Brown a écrit : > On Sat, Jan 16, 2016 at 08:32:13AM +0100, Paul Kocialkowski wrote: > > > Is there some git tree I can work with that has regulator runtime PM > > support at this point? I'll certainly end up handling the GPIO

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2016-02-05 Thread Paul Kocialkowski
Hi, Le mardi 29 décembre 2015 à 15:55 -0600, Rob Herring a écrit : > On Tue, Dec 29, 2015 at 3:26 PM, Paul Kocialkowski <cont...@paulk.fr> wrote: > > Le mardi 29 décembre 2015 à 14:02 -0600, Rob Herring a écrit : > >> On Wed, Dec 23, 2015 at 11:58:37AM +0100,

[PATCH v2 4/4] ARM: multi_v7_defconfig: Enable LP872x regulator support

2016-02-05 Thread Paul Kocialkowski
The LP872x regulator is used in the LG Optimus Black (P970) codename sniper to supply the external mmc card. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig

[PATCH v2 3/4] ARM: LG Optimus Black (P970) codename sniper support, with basic features

2016-02-05 Thread Paul Kocialkowski
, internal emmc and external mmc. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/omap3-sniper.dts | 215 + 2 files changed, 216 insertions(+) create mode 100644 arch/arm/boot/dts

[PATCH v2 2/4] regulator: lp872x: Add enable GPIO pin support

2016-02-05 Thread Paul Kocialkowski
LP872x regulators are made active via the EN pin, which might be hooked to a GPIO. This adds support for driving the GPIO high when the driver is in use. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- .../devicetree/bindings/regulator/lp872x.txt | 1 + drivers/regulator/lp

[PATCH v2 0/6] LG Optimus Black (P970) codename sniper support and lp872x improvements

2016-02-05 Thread Paul Kocialkowski
Changes since v1: * Remove lp872x patches that were accepted already from the series * Explain why removing the invalid DVS GPIO warning is enough * Update copyright notice on omap3-sniper.dts * Rename the devicetree property for the enable GPIO to enable-gpios * Rename function to enable GPIO to

[PATCH v2 1/4] regulator: lp872x: Remove warning about invalid DVS GPIO

2016-02-05 Thread Paul Kocialkowski
bit on the LP872X_GENERAL_CFG register (in lp872x_select_buck_vout_addr) to decide whether to use software or hardware DVS selection. Thus, there is no need to print a warning when the DVS GPIO is invalid. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- drivers/regulator/lp872x

Re: [PATCH v2 3/4] ARM: LG Optimus Black (P970) codename sniper support, with basic features

2016-02-05 Thread Paul Kocialkowski
Hi, Le vendredi 05 février 2016 à 19:42 +0100, Paul Kocialkowski a écrit : > The LG Optimus Black (P970) codename sniper is a smartphone that was designed > and manufactured by LG Electronics (LGE) and released back in 2011. > It is using an OMAP3630 SoC, GP version. > > This

Re: [PATCH v2 2/4] regulator: lp872x: Add enable GPIO pin support

2016-02-12 Thread Paul Kocialkowski
Hi, Le vendredi 12 février 2016 à 09:14 +0900, Kim, Milo a écrit : > Thanks for the patch. Please see my comments below. Thanks for the review! > On 2/6/2016 3:42 AM, Paul Kocialkowski wrote: > > LP872x regulators are made active via the EN pin, which might be hooked to a > &g

Re: [PATCH 2/2] regulator: core: Provide per-regulator runtime PM support

2016-02-12 Thread Paul Kocialkowski
Hi, Le mardi 09 février 2016 à 21:51 +0100, Paul Kocialkowski a écrit : > Le jeudi 21 janvier 2016 à 20:24 +, Mark Brown a écrit : > > Provide a flag auto_runtime_pm in the regulator_desc which causes the > > regulator core to take a runtime PM reference to a regulator while it

Re: [PATCH 2/2] regulator: core: Provide per-regulator runtime PM support

2016-02-09 Thread Paul Kocialkowski
Hi, Le jeudi 21 janvier 2016 à 20:24 +, Mark Brown a écrit : > Provide a flag auto_runtime_pm in the regulator_desc which causes the > regulator core to take a runtime PM reference to a regulator while it > is enabled. This helps integration with chip wide power management for > auxiliary

Re: [PATCH 2/2] regulator: core: Provide per-regulator runtime PM support

2016-01-29 Thread Paul Kocialkowski
Le jeudi 21 janvier 2016 à 20:24 +, Mark Brown a écrit : > Provide a flag auto_runtime_pm in the regulator_desc which causes the > regulator core to take a runtime PM reference to a regulator while it > is enabled. This helps integration with chip wide power management > for > auxiliary PMICs,

[PATCH v3 1/4] ARM: dts: LG Optimus Black codename sniper basic support

2016-02-28 Thread Paul Kocialkowski
, internal emmc and external mmc. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/omap3-sniper.dts | 215 + 2 files changed, 216 insertions(+) create mode 100644 arch/arm/boot/dts/omap3-snip

[PATCH v3 0/4] LG Optimus Black codename sniper support series

2016-02-28 Thread Paul Kocialkowski
This series requires lp872x regulator patches from the regulator tree[0] to work at run-time but can be applied as-is. Changes since v2: * Add USB OTG support * Add TWL4030 keypad support * Drop references to P970 since other devices (e.g. KU5900) are supported too Changes since v1: * Remove

[PATCH v3 2/4] ARM: dts: omap3-sniper: USB OTG support

2016-02-28 Thread Paul Kocialkowski
This adds support for USB OTG on the Optimus Black. The HSUSB0 interface is connected to the TWL4030 USB PHY. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/omap3-sniper.dts | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-)

Re: [PATCH v3 0/4] LG Optimus Black codename sniper support series

2016-02-28 Thread Paul Kocialkowski
Will send out v4 soon, with minor changes. Le dimanche 28 février 2016 à 11:20 +0100, Paul Kocialkowski a écrit : > This series requires lp872x regulator patches from the regulator tree[0] to > work > at run-time but can be applied as-is. > > Changes since v2: > * Add USB O

[PATCH v4 2/5] ARM: dts: omap3-sniper: USB OTG support

2016-02-28 Thread Paul Kocialkowski
This adds support for USB OTG on the Optimus Black. The HSUSB0 interface is connected to the TWL4030 USB PHY. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/omap3-sniper.dts | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-)

[PATCH v4 3/5] ARM: dts: omap3-sniper: TWL4030 keypad support

2016-02-28 Thread Paul Kocialkowski
This adds support for the volume and gesture keys, using TWL4030 keypad. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/omap3-sniper.dts | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/omap3-sniper.dts b/arch/arm/boot/dts

[PATCH v4 5/5] ARM: multi_v7_defconfig: Enable LP872x regulator support

2016-02-28 Thread Paul Kocialkowski
The LP872x regulator is used in the LG Optimus Black codename sniper to supply the external mmc card. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/ar

[PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic support

2016-02-28 Thread Paul Kocialkowski
, internal emmc and external mmc. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/omap3-sniper.dts | 215 + 2 files changed, 216 insertions(+) create mode 100644 arch/arm/boot/dts/omap3-snip

[PATCH v4 4/5] ARM: omap2plus_defconfig: Enable LP872x regulator support

2016-02-28 Thread Paul Kocialkowski
The LP872x regulator is used in the LG Optimus Black codename sniper to supply the external mmc card. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/configs/omap2plus_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/omap2plus_defconfig b/ar

[PATCH v4 0/5] LG Optimus Black codename sniper support series

2016-02-28 Thread Paul Kocialkowski
This series requires lp872x regulator patches from the regulator tree[0] to work at run-time but can be applied as-is. Changes since v3: * Switch to the already-defined devicetree vendor prefix for LG * Enable the lp872x regulator in omap2plus_defconfig Changes since v2: * Add USB OTG support *

[PATCH v3 4/4] ARM: multi_v7_defconfig: Enable LP872x regulator support

2016-02-28 Thread Paul Kocialkowski
The LP872x regulator is used in the LG Optimus Black codename sniper to supply the external mmc card. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/ar

[PATCH v3 3/4] ARM: dts: omap3-sniper: TWL4030 keypad support

2016-02-28 Thread Paul Kocialkowski
This adds support for the volume and gesture keys, using TWL4030 keypad. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/omap3-sniper.dts | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/omap3-sniper.dts b/arch/arm/boot/dts

Re: [PATCH v4 3/5] ARM: dts: omap3-sniper: TWL4030 keypad support

2016-03-01 Thread Paul Kocialkowski
Hi, Le dimanche 28 février 2016 à 13:39 +0100, Paul Kocialkowski a écrit : > This adds support for the volume and gesture keys, using TWL4030 keypad. I noticed this patch hadn't been picked up in: https://git.kernel.org/cgit/linux /kernel/git/tmlind/linux-omap.git/log/?h=omap-for-v4.6/dt Sho

Re: [PATCH v4 3/5] ARM: dts: omap3-sniper: TWL4030 keypad support

2016-03-01 Thread Paul Kocialkowski
Le mardi 01 mars 2016 à 12:59 -0800, Tony Lindgren a écrit : > * Paul Kocialkowski <cont...@paulk.fr> [160301 11:19]: > > Hi, > > > > Le dimanche 28 février 2016 à 13:39 +0100, Paul Kocialkowski a écrit : > > > This adds support for the volume and gesture ke

Re: [PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic support

2016-03-01 Thread Paul Kocialkowski
Le lundi 29 février 2016 à 13:51 -0800, Tony Lindgren a écrit : > Hi, > > * Paul Kocialkowski <cont...@paulk.fr> [160228 04:40]: > > The LG Optimus Black codename sniper is a smartphone that was designed and > > manufactured by LG Electronics (LGE) and released ba

Re: [PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic support

2016-03-30 Thread Paul Kocialkowski
Le mercredi 30 mars 2016 à 12:13 -0700, Tony Lindgren a écrit : > * Paul Kocialkowski <cont...@paulk.fr> [160320 08:59]: > > > > Le lundi 29 février 2016 à 13:51 -0800, Tony Lindgren a écrit : > > > > > > Anyways, applying the dts changes into omap-f

Re: [PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic support

2016-03-20 Thread Paul Kocialkowski
Hi, Le lundi 29 février 2016 à 13:51 -0800, Tony Lindgren a écrit : > Hi, > > * Paul Kocialkowski <cont...@paulk.fr> [160228 04:40]: > > > > The LG Optimus Black codename sniper is a smartphone that was designed and > > manufactured by LG Electronic

Re: [PATCH] kconfig: Add localdefconfig helper

2016-03-26 Thread Paul Kocialkowski
Le samedi 26 mars 2016 à 19:53 +0100, Sam Ravnborg a écrit : > On Sat, Mar 26, 2016 at 07:31:27PM +0100, Paul Kocialkowski wrote: > > > > This introduces a localdefconfig make target to specify out-of-tree default > > configs. The out-of-tree default target is

[PATCH] kconfig: Add localdefconfig helper

2016-03-26 Thread Paul Kocialkowski
widely. In addition, it keeps all the path handling logic inside the Makefiles, as opposed to delegating some of it to a wrapper script or such, when copying the default configuration to .config. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- Makefile | 2 +- s

[PATCH 5/8] ARM: OMAP2+: Only select TWL4030_POWER for OMAP3

2016-03-29 Thread Paul Kocialkowski
The TWL4030 is generally used with the OMAP3, not with OMAP4. The TWL6030 is generally used with the OMAP4 instead. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/mach-omap2/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/K

[PATCH 1/8] mfd: twl-core: Rename struct twl4030_platform_data to twl_platform_data

2016-03-29 Thread Paul Kocialkowski
Since twl4030_platform_data also holds platform data (e.g. regulators) for other TWL chips, it makes sense to rename it to a non-model-specific name. This will also allow hooking more platform data structure to it in the future. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- ar

[PATCH 4/5] ARM: dts: omap4-kc1: LEDs support

2016-03-29 Thread Paul Kocialkowski
This adds support for the Kindle Fire (first generation) power button LEDs, that are wired to the TWL6030 PWM outputs. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/omap4-kc1.dts | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/bo

[PATCH 5/5] ARM: dts: omap4-kc1: Power off support

2016-03-29 Thread Paul Kocialkowski
This adds support for turning off the main power supply via the TWL6030 on the Kindle Fire (first generation). Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/omap4-kc1.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/omap4-kc1.dts

[PATCH 3/5] ARM: dts: omap4-kc1: USB OTG support

2016-03-29 Thread Paul Kocialkowski
This adds support for USB OTG on the Kindle Fire (first generation). Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/omap4-kc1.dts | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm/boot/dts/omap4-kc1.dts b/arch/arm/boot/dts/oma

[PATCH 2/8] mfd: twl-core: Rename some non-model-specific structures, without model name

2016-03-29 Thread Paul Kocialkowski
Some of the structures exposed in the twl_platform_data structure are common to various TWL chips, so it makes sense to rename them to a non-model-specific name. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/mach-omap2/board-rx51-peripherals.c | 4 ++-- arch/arm/mach

[PATCH] pwm: twl: Reliably disable TWL6030 PWMs

2016-03-29 Thread Paul Kocialkowski
to the driver. It consists in enabling the PWM clock after issuing a reset. This is what TI kernel trees and production code seem to be using. However, adding an extra step to disable the PWM clock seems to work reliably, despite looking quite odd. Signed-off-by: Paul Kocialkowski <cont...@paulk

Re: [PATCH 1/8] mfd: twl-core: Rename struct twl4030_platform_data to twl_platform_data

2016-04-02 Thread Paul Kocialkowski
Hi, Le mercredi 30 mars 2016 à 18:20 +0300, Grygorii Strashko a écrit : > On 03/29/2016 10:22 PM, Paul Kocialkowski wrote: > > Since twl4030_platform_data also holds platform data (e.g. regulators) for > > other > > TWL chips, it makes sense to rename it to a no

Re: [PATCH 2/2] ARM: OMAP4: Store reboot mode to SAR scratchpad memory before restart

2016-04-02 Thread Paul Kocialkowski
Hi, Le mardi 29 mars 2016 à 18:50 -0500, Nishanth Menon a écrit : > On 03/29/2016 02:25 PM, Paul Kocialkowski wrote: > > > > This adds support for storing the reboot mode command to SAR scratchpad > > memory, > > at a location compatible with TI kernels, s

Re: [PATCH 3/8] mfd: twl-core: Rename TWL4030_CORE Kconfig option to TWL_CORE

2016-04-02 Thread Paul Kocialkowski
Le mercredi 30 mars 2016 à 18:34 +0300, Grygorii Strashko a écrit : > On 03/29/2016 10:22 PM, Paul Kocialkowski wrote: > > > > Since the twl-core mfd driver is not limited to twl4030 support, but also > > supports other chips of the TWL family, it makes sense to re

Re: [PATCH 4/8] mfd: Add TWL6030 power driver, with minimal support for power off

2016-04-02 Thread Paul Kocialkowski
Le mercredi 30 mars 2016 à 18:56 +0300, Grygorii Strashko a écrit : > On 03/29/2016 10:22 PM, Paul Kocialkowski wrote: > > > > This adds a TWL6030 power driver, that currently only supports powering off > > the > > device when the TWL is used as system power controller.

Re: [PATCH 7/8] input: misc: Add TWL6030 power button support to twl-pwrbutton

2016-04-02 Thread Paul Kocialkowski
Hi, Le mercredi 30 mars 2016 à 19:16 +0300, Grygorii Strashko a écrit : > On 03/29/2016 10:22 PM, Paul Kocialkowski wrote: > > > > This renames the twl4030-pwrbutton driver to twl-pwrbutton, since power > > button > > handling is very similar on most TWL chips. T

[PATCH 8/8] input: twl-pwrbutton: Rename interrupt routine for better consistency

2016-03-29 Thread Paul Kocialkowski
This renames the twl-pwrbutton interrupt routing from powerbutton_irq to twl_pwrbutton_irq, for better consistency with the driver name. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- drivers/input/misc/twl-pwrbutton.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 7/8] input: misc: Add TWL6030 power button support to twl-pwrbutton

2016-03-29 Thread Paul Kocialkowski
unmasking and remasking support Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- .../devicetree/bindings/input/twl-pwrbutton.txt| 22 .../bindings/input/twl4030-pwrbutton.txt | 21 --- arch/arm/boot/dts/twl6030.dtsi | 5 + arch/arm/c

[PATCH 1/2] ARM: OMAP3: Use offset definition and omap_ctrl_writel for boot mode

2016-03-29 Thread Paul Kocialkowski
This introduces offset definitions for scratchpad and scratchpad boot mode to be used with omap_ctrl_writel, fixing a comment suggesting this. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/mach-omap2/control.c | 4 +--- arch/arm/mach-omap2/control.h | 3 +++ 2 files chan

[PATCH 3/8] mfd: twl-core: Rename TWL4030_CORE Kconfig option to TWL_CORE

2016-03-29 Thread Paul Kocialkowski
Since the twl-core mfd driver is not limited to twl4030 support, but also supports other chips of the TWL family, it makes sense to rename its matching Kconfig opton to a non-model-specific name. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/mach-omap2/Kconfig | 2 +-

[PATCH 4/8] mfd: Add TWL6030 power driver, with minimal support for power off

2016-03-29 Thread Paul Kocialkowski
This adds a TWL6030 power driver, that currently only supports powering off the device when the TWL is used as system power controller. This driver might be extended to support more power-related features of the TWL6030. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- .../devi

[PATCH 6/8] ARM: OMAP2+: Select TWL6030_POWER for OMAP4

2016-03-29 Thread Paul Kocialkowski
The TWL6030 is generally used with the OMAP4. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/mach-omap2/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 6ffa7f1..2d67eaf 100644 --- a/arch/arm/mach

[PATCH 2/2] ARM: OMAP4: Store reboot mode to SAR scratchpad memory before restart

2016-03-29 Thread Paul Kocialkowski
This adds support for storing the reboot mode command to SAR scratchpad memory, at a location compatible with TI kernels, so that bootloaders can grab the reboot mode and act upon it. Currently, upstream U-Boot has support for this feature on OMAP4. Signed-off-by: Paul Kocialkowski <c

[PATCH] ARM: dts: omap3-sniper: Discard deprecated twl4030-power property

2016-03-29 Thread Paul Kocialkowski
This uses ti,system-power-controller instead of the deprecated ti,use_poweroff property for powering off. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/omap3-sniper.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH 1/5] devicetree: bindings: Add vendor prefix for Amazon.com, Inc.

2016-03-29 Thread Paul Kocialkowski
This adds the amazon vendor prefix for Amazon.com, Inc. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documen

[PATCH 0/5] Amazon Kindle Fire (first generation) codename kc1 support series

2016-03-29 Thread Paul Kocialkowski
This series adds basic support for the Amazon Kindle Fire (first generation) codename kc1. A few features such as serial, i2c, the internal eMMC, USB gadget and power button leds. It requires some TWL-related patches to work properly, in particular: * pwm: twl: Reliably disable TWL6030 PWMs *

[PATCH] ARM: dts: omap3-sniper: Discard deprecated twl4030-power property

2016-03-29 Thread Paul Kocialkowski
This uses ti,system-power-controller instead of the deprecated ti,use_poweroff property for powering off. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/omap3-sniper.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH 2/5] ARM: dts: Amazon Kindle Fire (first generation) codename kc1 basic support

2016-03-29 Thread Paul Kocialkowski
-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/omap4-kc1.dts | 140 2 files changed, 141 insertions(+) create mode 100644 arch/arm/boot/dts/omap4-kc1.dts diff --git a/arch/arm/boot/dts/Makefile b/ar

[PATCH v2 4/6] ARM: tegra: nyan-blaze: Include compatible revisions for proper detection

2017-01-22 Thread Paul Kocialkowski
it detects instead of using the default kernel. This allows having a FIT image with multiple kernels for multiple devices. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/tegra124-nyan-blaze.dts | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH v2 6/6] ARM: tegra: nyan-blaze: Proper pinmux for TPM i2c

2017-01-22 Thread Paul Kocialkowski
From: Jerome Coste This corrects the pinmux for accessing the TPM over the i2c line. Thus, it allows correctly probing the module, that previously failed with i2c errors. --- arch/arm/boot/dts/tegra124-nyan-blaze.dts | 20 ++-- 1 file changed, 10

[PATCH v2 1/6] ARM: tegra: nyan: Use proper IRQ type definitions

2017-01-22 Thread Paul Kocialkowski
This switches a few interrupt definitions that were using GPIO_ACTIVE_HIGH as IRQ type, which is invalid. This is mostly a cosmetic change, that doesn't affect any driver. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/tegra124-nyan.dtsi | 4 ++-- 1 file chan

[PATCH v2 2/6] ARM: tegra: nyan: Use external control for bq24735 charger

2017-01-22 Thread Paul Kocialkowski
Nyan boards come with an embedded controller that controls when to enable and disable the charge. Thus, it should not be left up to the kernel to handle that. Using the ti,external-control property allows specifying this use-case. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- ar

[PATCH v2 3/6] ARM: tegra: nyan-big: Include compatible revisions for proper detection

2017-01-22 Thread Paul Kocialkowski
it detects instead of using the default kernel. This allows having a FIT image with multiple kernels for multiple devices. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/tegra124-nyan-big.dts | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ar

[PATCH v2 5/6] ARM: tegra: nyan-big: Proper pinmux for TPM i2c

2017-01-22 Thread Paul Kocialkowski
This corrects the pinmux for accessing the TPM over the i2c line. Thus, it allows correctly probing the module, that previously failed with i2c errors. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/tegra124-nyan-big.dts | 20 ++-- 1 file chang

[PATCH 2/5] ARM: tegra: nyan: Use external control for bq24735 charger

2017-01-22 Thread Paul Kocialkowski
Nyan boards come with an embedded controller that controls when to enable and disable the charge. Thus, it should not be left up to the kernel to handle that. Using the ti,external-control property allows specifying this use-case. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- ar

[PATCH 1/5] ARM: tegra: nyan: Use proper IRQ type definitions

2017-01-22 Thread Paul Kocialkowski
This switches a few interrupt definitions that were using GPIO_ACTIVE_HIGH as IRQ type, which is invalid. This is mostly a cosmetic change, that doesn't affect any driver. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/tegra124-nyan.dtsi | 4 ++-- 1 file chan

[PATCH 5/5] ARM: tegra: nyan-blaze: Proper pinmux for TPM i2c

2017-01-22 Thread Paul Kocialkowski
From: Jerome Coste This corrects the pinmux for accessing the TPM over the i2c line. Thus, it allows correctly probing the module, that previously failed with i2c errors. --- arch/arm/boot/dts/tegra124-nyan-blaze.dts | 20 ++-- 1 file changed, 10

[PATCH 3/5] ARM: tegra: nyan-big: Include compatible revisions for proper detection

2017-01-22 Thread Paul Kocialkowski
it detects instead of using the default kernel. This allows having a FIT image with multiple kernels for multiple devices. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/tegra124-nyan-big.dts | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ar

[PATCH 4/5] ARM: tegra: nyan-big: Proper pinmux for TPM i2c

2017-01-22 Thread Paul Kocialkowski
This corrects the pinmux for accessing the TPM over the i2c line. Thus, it allows correctly probing the module, that previously failed with i2c errors. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- arch/arm/boot/dts/tegra124-nyan-big.dts | 20 ++-- 1 file chang

Re: [PATCH v3] dt-bindings: power: supply: bq24735: reverse the polarity of ac-detect

2017-01-24 Thread Paul Kocialkowski
his patch). I'd also be happy to implement and test that solution on nyans, as I've done other bq24735-related work for nyans recently. -- Paul Kocialkowski, developer of free digital technology at the lower levels Website: https://www.paulk.fr/ Coding blog: https://code.paulk.fr/ Git repositories:

Re: [PATCH v2 3/6] ARM: tegra: nyan-big: Include compatible revisions for proper detection

2017-01-25 Thread Paul Kocialkowski
Le mercredi 25 janvier 2017 à 12:02 +0100, Thierry Reding a écrit : > On Sun, Jan 22, 2017 at 04:47:50PM +0100, Paul Kocialkowski wrote: > > Depthcharge (the payload used with cros devices) will attempt to detect > > boards using their revision. This includes all the

Re: [PATCH v2 2/6] ARM: tegra: nyan: Use external control for bq24735 charger

2017-01-25 Thread Paul Kocialkowski
Le mercredi 25 janvier 2017 à 11:59 +0100, Thierry Reding a écrit : > On Sun, Jan 22, 2017 at 04:47:49PM +0100, Paul Kocialkowski wrote: > > Nyan boards come with an embedded controller that controls when to > > enable and disable the charge. Thus, it should not be left up to

Re: [PATCH v2 3/6] ARM: tegra: nyan-big: Include compatible revisions for proper detection

2017-01-25 Thread Paul Kocialkowski
Le mercredi 25 janvier 2017 à 12:14 +0100, Thierry Reding a écrit : > On Wed, Jan 25, 2017 at 12:08:08PM +0100, Paul Kocialkowski wrote: > > Le mercredi 25 janvier 2017 à 12:02 +0100, Thierry Reding a écrit : > > > On Sun, Jan 22, 2017 at 04:47:50PM +0100, Paul

Re: [PATCH v3] dt-bindings: power: supply: bq24735: reverse the polarity of ac-detect

2017-01-26 Thread Paul Kocialkowski
On 25/01/17 13:20, Peter Rosin wrote: > On 2017-01-24 17:24, Paul Kocialkowski wrote: > > Le jeudi 15 décembre 2016 à 18:50 +0100, Peter Rosin a écrit : > > > The bindings are fine. > > >  > > > The Tegra dts files are buggy, but the driver is also buggy, so th

Re: [PATCH v3] power: bq24735-charger: Request status GPIO with initial input setup

2016-09-02 Thread Paul Kocialkowski
6 at 11:27:00PM +0200, Paul Kocialkowski wrote: > > > > This requests the status GPIO with initial input setup. it is required > > to read the GPIO status at probe time and thus correctly avoid sending > > i2c messages when AC is not plugged. > > > > When request

[PATCH v4] power: bq24735-charger: Request status GPIO with initial input setup

2016-09-02 Thread Paul Kocialkowski
the charger is connected, sends i2c messages and fails. While at it, this switches the driver over to gpio consumer. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- drivers/power/supply/bq24735-charger.c | 44 +- include/linux/power/bq24735-charger.h

Re: [PATCH v4] power: bq24735-charger: Request status GPIO with initial input setup

2016-09-05 Thread Paul Kocialkowski
Hi, Le lundi 05 septembre 2016 à 13:08 +0200, Sebastian Reichel a écrit : > Hi Paul, > > On Sat, Sep 03, 2016 at 12:09:53AM +0200, Paul Kocialkowski wrote: > > > > This requests the status GPIO with initial input setup. it is required > > to read the GPIO status at pr

[PATCH v3] power: bq24735-charger: Request status GPIO with initial input setup

2016-09-01 Thread Paul Kocialkowski
the charger is connected, sends i2c messages and fails. While at it, this switches the driver over to gpio consumer. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- drivers/power/bq24735-charger.c | 42 +-- include/linux/power/bq24735-charger.

Re: [PATCH v2] power: bq24735-charger: Request status GPIO with initial input setup

2016-09-01 Thread Paul Kocialkowski
Le mardi 30 août 2016 à 01:32 +0200, Sebastian Reichel a écrit : > Hi, > > On Mon, Aug 29, 2016 at 08:15:03PM +0200, Paul Kocialkowski wrote: > > > > This requests the status GPIO with initial input setup. it is required > > to read the GPIO status at probe time and t

[PATCH v2] power: bq24735-charger: Request status GPIO with initial input setup

2016-08-29 Thread Paul Kocialkowski
the charger is connected, sends i2c messages and fails. While at it, this switches the driver over to devm and gpio consumer. Signed-off-by: Paul Kocialkowski <cont...@paulk.fr> --- drivers/power/bq24735-charger.c | 29 +++-- include/linux/power/bq24735-charger.

Re: [PATCH 1/2] power: bq24735-charger: Request status GPIO with initial input setup

2016-08-29 Thread Paul Kocialkowski
Le lundi 29 août 2016 à 02:36 +0200, Sebastian Reichel a écrit : > Hi, > > On Sun, Aug 28, 2016 at 07:34:45PM +0200, Paul Kocialkowski wrote: > > > > This requests the status GPIO with initial input setup. it is required > > to read the GPIO status at probe time and t

  1   2   3   4   5   6   7   8   9   10   >