The entries in tpm_protected_ordinal_duration are exactly the same as
the first 12 in tpm_ordinal_duration, so we can simply remove this one,
and save some bytes.
This does not change the behavior of the driver.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
This patch reflects only my opinion
/tpm.c:360 tpm_calc_ordinal_duration() error: buffer
overflow 'tpm_protected_ordinal_duration' 12 = 243
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/char/tpm/tpm.c | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/char/tpm/tpm.c b/drivers/char
retained as a compatible id as a fallback to
slb9635 protocol.
The driver was tested on Beaglebone.
Signed-off-by: Peter Huewe peter.hu...@infineon.com
---
Please apply on top of char/tpm: Convert struct i2c_msg initialization to C99
format by Shubhrajyoti Datta
.../devicetree/bindings/i2c/trivial
As the subject says.
It's probably a good idea to have these fields populated.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/char/tpm/tpm_i2c_infineon.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/drivers/char/tpm/tpm_i2c_infineon.c
b
Kent Yoder indicated that the code might be a bit clearer with a comment
here, so this patch adds a small explanation of the code.
CC: Kent Yoder shpedoi...@gmail.com
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/char/tpm/tpm_i2c_infineon.c | 9 +
1 file changed, 9 insertions
patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
v3 for this tiny patch... shame on me.
drivers/char/tpm/tpm_tis.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm
':
goldfish_nand.c:(.text+0x6e8ba2): undefined reference to
`mtd_erase_callback'
drivers/built-in.o: In function `goldfish_nand_init_device':
goldfish_nand.c:(.text+0x6e8eba): undefined reference to
`mtd_device_parse_register'
Reported-by: Randy Dunlap rdun...@infradead.org
Signed-off-by: Peter Huewe peterhu
':
goldfish_nand.c:239:2:
warning: format '%x' expects argument of type 'unsigned int', but
argument 3 has type 'size_t' [-Wformat]
- As defined in the printk-formats use %zx for size_t variables
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/goldfish/goldfish_nand.c |8
retained as a compatible id as a fallback to
slb9635 protocol.
The driver was tested on Beaglebone.
Signed-off-by: Peter Huewe peter.hu...@infineon.com
---
Patch against Kent's tpmdd-02-05-13 branch
You might get an out-of-office reply, but I'm monitoring this email address
nevertheless.
Thanks, Peter
Local variable AcmCtrl is never read/used after assignment so we can remove
all assignments to it and the related code around the assignments.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 49 +--
1 files changed, 1
In SetAntennaConfig87SE both branches of if (bAntDiversity) do exactly
the same, except that there is an offset of 0x80 for the register values
if bAntDiversity is true.
- Consolidate both branches and assign the offset if necessary.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers
variables UCharData and RegisterContent in
WriteBBPortUchar as they are not used / without effect.
Both functions are only 'local' so we can mark them as static.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 30 +++---
1 files
These two functions PlatformIORead2Byte and PlatformIORead4Byte are
unused and thus can be removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 20
1 files changed, 0 insertions(+), 20 deletions(-)
diff --git a/drivers
' was not declared. Should it be
static?
- Add the static keyword.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 34 +++---
1 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8185b_init.c
to
read_nic_byte but is kept for readability.
Since this functions is local only we can mark it as static.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 17 +
1 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/drivers/staging
The local variable u4bAcParam is never read/used after assignment,
thus we can remove the declaration, assignment and any related code.
- the local variables u1bAIFS, eACI and pAcParam can also be removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c
The local variable AcParam is only assigned to but not read/used
afterwards, thus it and all related code can be removed.
The bFollowLegacySetting variable and check can also be removed as it is
always true.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se
The local variables priv and ieee are not used and thus can be removed.
The local variable u1bAIFS is not used/read after assignment and thus
can be removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c |5 -
1 files changed, 0 insertions(+), 5
Local variable AcmCtrl is never read/used after assignment so we can remove
all assignments to it and the related code around the assignments.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 49 +--
1 files changed, 1
The local variable AcParam is only assigned to but not read/used
afterwards, thus it and all related code can be removed.
The bFollowLegacySetting variable and check can also be removed as it is
always true.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se
The local variables priv and ieee are not used and thus can be removed.
The local variable u1bAIFS is not used/read after assignment and thus
can be removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c |5 -
1 files changed, 0 insertions(+), 5
The local variable u4bAcParam is never read/used after assignment,
thus we can remove the declaration, assignment and any related code.
- the local variables u1bAIFS, eACI and pAcParam can also be removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c
to
read_nic_byte but is kept for readability.
Since this functions is local only we can mark it as static.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 17 +
1 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/drivers/staging
These two functions PlatformIORead2Byte and PlatformIORead4Byte are
unused and thus can be removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 20
1 files changed, 0 insertions(+), 20 deletions(-)
diff --git a/drivers
In SetAntennaConfig87SE both branches of if (bAntDiversity) do exactly
the same, except that there is an offset of 0x80 for the register values
if bAntDiversity is true.
- Consolidate both branches and assign the offset if necessary.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers
variables UCharData and RegisterContent in
WriteBBPortUchar as they are not used / without effect.
Both functions are only 'local' so we can mark them as static.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 30 +++---
1 files
' was not declared. Should it be
static?
- Add the static keyword.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 34 +++---
1 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8185b_init.c
VMK8061_MODEL and
VMK8055_MODEL it's safe to assume that VMK8055_DO_REG was meant as an
initial value.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/comedi/drivers/vmk80xx.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/comedi/drivers/vmk80xx.c
b
VMK8061_MODEL and
VMK8055_MODEL it's safe to assume that VMK8055_DO_REG was meant as an
initial value.
And to avoid duplication we can move the assignments to the top.
Acked-by: Ian Abbott abbo...@mev.co.uk
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/comedi/drivers/vmk80xx.c | 17
can simply replace the whole lookup table with a simple if/else assignment.
Tested-by: Aaro Koskinen aaro.koski...@iki.fi
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_init.c |2 +-
drivers/staging/xgifb/vb_table.h | 11 ---
2 files changed, 1 insertions
XGINew_SetDRAMDefaultRegister340 uses the same code fragment 4 times
with only a slight variation each time.
- Move this code to a helper function - this saves some lines and
~450bytes in the .o / .ko
Tested-by: Aaro Koskinen aaro.koski...@iki.fi
Signed-off-by: Peter Huewe peterhu...@gmx.de
1) The same condition (pVBInfo-IF_DEF_LVDS == 0) was checked in the if
clause directly in front of this one.
2) The same condition pVBInfo-VBType (VB_SIS301B | VB_SIS302B |
VB_SIS301LV | VB_SIS302LV | VB_XGI301C) was checked in the if
clause directly in front of this one.
Signed-off-by: Peter
Since XGI_LCDDesStruct is fully contained in XGI330_LCDDataDesStruct2
and the offsets for the first members is identical we can consolidate
the if/else branches here and use XGI330_LCDDataDesStruct2 for
everything.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb
are unnecessary.
- we can safely remove them.
Tested-by: Aaro Koskinen aaro.koski...@iki.fi
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_init.c | 19 ++-
1 files changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/xgifb/vb_init.c b
’
[-Wunused-variable]
This patch fixes this
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
Sorry that I missed that one in the patch series.
drivers/staging/xgifb/vb_init.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb
of
XGINew_GetXG20DRAMType which can only be 0, 1 or 2
- pVBInfo-CR40 is assigned to either XGI340_cr41 or XGI27_cr41 in
vb_setmode.c
- only the first three values are used.
This becomes also evident as values 3-7 are all 0.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_struct.h |2
of
XGINew_GetXG20DRAMType which can only be 0, 1 or 2
- pVBInfo-SR15 is assigned to either XG27_SR13 or XGI340_SR13 in
vb_setmode.c
- only the first three values are used.
This becomes also evident as values 3-7 are all 0.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_struct.h |2
which can only be 0, 1 or 2
- pVBInfo-MCLKData is assigned to either XGI340New_MCLKData or
XGI27New_MCLKData in vb_setmode.c
- only the first three values are used, the rest can be removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_table.h | 10 --
1
pVBInfo-ram_type is assigned the return value of
XGINew_GetXG20DRAMType which can only be 0, 1 or 2
- The conditional assignment is not needed here as it always evaluates
to true.
- remove
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_init.c |2 +-
1 files
MCLKData does not contain any 0x1C value for its field SR28 nor does
XGI340_ECLKData contain any 0x1C or 0x22 value for its field SR2E.
- the statement always evaluates to false.
- remove
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_init.c | 16
1
or 2
- only the first three values are used.
- remove the remeining entries.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_table.h |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/xgifb/vb_table.h b/drivers/staging/xgifb
-by: Fengguang Wu fengguang...@intel.com
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/vt6656/card.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
index 7d725bb..f988f07 100644
--- a/drivers
/devm_request_and_ioremap.cocci.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/i2c/busses/i2c-mxs.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
index d6abaf2..4ca92b6 100644
--- a/drivers/i2c/busses/i2c-mxs.c
+++ b
assignment a few lines later.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/XGI_main_26.c | 35 +++
1 files changed, 3 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26.c
index
assignment - remove the dead assignment.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c | 46
1 files changed, 10 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb
XGI_P3cc is unused and the assignment without side effects - remove;
Data can be simply replaced by the Temp variable, which was changed to
temp in order to make checkpatch happy.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c | 19 ---
1
Index is not used here - remove.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index 53b5557..a7fb52f 100644
Pindex and Pdata are unused - remove
tempbx is unused - remove
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb
The code checks twice for if (pVBInfo-VBInfo SetCRT2ToTV) without any
changes in between - we can remove the second check.
And while at it we can also save the temp variable and use tempbx
directly.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c | 34
This patch removes some comparisons that always evaluate to false since
xoffset and yoffset are defined as __u32 in fb_var_screeninfo in
include/linux/fb.h and thus can never be negative.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/XGI_main_26.c |9 +
1
The mttr field must be declared as signed int (as in every other fb
driver) for the mttr functions to work properly.
Moreover the value should be initialized with -1.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/XGI_main_26.c |2 +-
drivers/staging/xgifb/XGIfb.h
We don't need to use this switch-case here for a simple two case
if-else.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/XGI_main_26.c | 16 ++--
1 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers
Instead of subtracting one and then assign a different name and add 1
again we simply use HDE directly. HDE wasn't used directly before, so no
change in functionality.
Same applies to VDE.
- now we can remove the variable with the very descriptive name E ;)
Signed-off-by: Peter Huewe peterhu
These two functions share the same code except one line - thus we can
simply merge them and add a parameter to switch between both variants.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c | 48 +--
1 files changed, 13
the
assignment to SR1 into the loop, which I prefer to start at 0.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c | 23 ++-
drivers/staging/xgifb/vb_table.h |2 +-
2 files changed, 7 insertions(+), 18 deletions(-)
diff --git a/drivers/staging
This patch simplifies the code of XGISetModeNew by reordering the
if/else if/case conditions when both branches are doing exactly the
same.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c | 18 +++---
1 files changed, 3 insertions(+), 15
Since data can only be 0x, 0x0035 or 0x0048 we can simply skip the
bit shifting and masking as data 0xFF is always equal to data and
data 0xFF00 is always 0.
So we simply use data and 0 directly and save the assignment.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb
the variable in this case.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/XGI_main_26.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26.c
index fa351f9..106abc8 100644
-of-bounds access I changed the mask from 0x0F
to 0x07 and added a dummy value.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
Please apply this series after my previous one
[PATCH 1/6] staging/xgifb: Remove unused variables and dead assignments
[PATCH 2/6] staging/xgifb: Remove unused variable
Am Donnerstag, 24. Januar 2013, 11:02:35 schrieb Ian Abbott:
On 2013-01-22 23:03, Peter Huewe wrote:
Since comedi_pci_auto_unconfig cannot be inlined anymore after
staging/comedi: Use comedi_pci_auto_unconfig directly for
pci_driver.remove
is applied, it makes sense to move
Found with coccicheck.
The semantic patch that makes this change is available
in scripts/coccinelle/api/ptr_ret.cocci.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/media/solo6x10/v4l2.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers
Found with coccicheck.
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/csr/drv.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/csr/drv.c
Found with coccicheck.
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/media/go7007/go7007-driver.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers
Found with coccicheck.
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/omapdrm/omap_gem.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
Assigning a string is really bad,
and since we only have 1 char strings here we
can simply use a char to store the value and change the format specifier.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/comedi/drivers/adl_pci8164.c | 28 +-
1 files
Found with coccicheck.
The semantic patch that makes this output is available
in scripts/coccinelle/misc/boolinit.cocci.
More information about semantic patching is available at
http://coccinelle.lip6.fr/
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/comedi/comedi_fops.c
This patch adds the comedi_driver.name to pci_driver.name
to the skel driver, so we can remove the workaround in drivers.c
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/comedi/drivers/skel.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers
All pci drivers in drivers/ have the pci_driver.name field set, so we
can remove this workaround and the accompanying todo.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/comedi/drivers.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers
-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/iio/iio_hwmon.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/iio/iio_hwmon.c b/drivers/staging/iio/iio_hwmon.c
index c7a5f97..97ad645 100644
--- a/drivers/staging/iio/iio_hwmon.c
+++ b/drivers/staging
This patch adds the comedi_driver.name to pci_driver.name
to the skel driver, so we can remove the workaround in drivers.c
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
missed a comma, sorry
drivers/staging/comedi/drivers/skel.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff
Instead of coding calling comedi_driver_(un)register and
usb_(de)register directly we can use the comedi_usb_driver_(un)register
wrapper.
This removes some boilerplate and is less error prone.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/comedi/drivers/dt9812.c | 25
code and saves some bytes.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
Maybe we should move the implementation now to drivers.c,
because now it cannot be inlined anymore.
This would save some more bytes in the .kos but comedi_pci_auto_unconfig
then has to become an exported symbol.
drivers
Since comedi_pci_auto_unconfig cannot be inlined anymore after
staging/comedi: Use comedi_pci_auto_unconfig directly for
pci_driver.remove
is applied, it makes sense to move it drivers.c
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/comedi/comedidev.h |5 +
drivers
!= WLAN_DEVICE_OPEN) evaluates to true.
the execution flow then continues at the 'failed' label where
p80211_wep.data is used without being initialized first.
- Initialize the data field to NULL to fix this issue.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/wlan-ng/p80211netdev.c |2
.
This is done in a similar fashion in
staging/rtl8187se/ieee80211/ieee80211_softmac_wx.c
While at it cleaned some whitespace issues.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
.../rtl8192u/ieee80211/ieee80211_softmac_wx.c | 29 ++-
1 files changed, 15 insertions(+), 14 deletions
sparse complains that:
drivers/staging/comedi/drivers/adl_pci9118.c:813 pci9118_calc_divisors()
warn: maybe use instead of
usessh is used as a boolean flag (0 and 1) and is compared to a boolean
value so we should use here.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging
Smatch warns about:
staging/comedi/drivers/cb_pcidas64.c:3304 prep_ao_dma() warn: if();
So the check currently does nothing and could be removed, but the better
alternative is to activate the check again and return -1; if it
evaluates to true.
Signed-off-by: Peter Huewe peterhu...@gmx.de
:1382:6: warning: symbol 'lcd_init' was not declared. Should it be
static?
panel.c:2181:5: warning: symbol 'panel_init' was not declared. Should it be
static?
Add the static keyword to silence these warnings and make smatch happy.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging
This patch fixes the warning Using plain integer as NULL pointer,
generated by sparse, by replacing the offending 0s with NULL.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
I split up this patch series on a per file basis so that review is easier.
drivers/staging/ozwpan/ozpd.c | 68
This patch fixes the warning Using plain integer as NULL pointer,
generated by sparse, by replacing the offending 0s with NULL.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/ozwpan/ozusbsvc1.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions
This patch fixes the warning Using plain integer as NULL pointer,
generated by sparse, by replacing the offending 0s with NULL.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/ozwpan/ozusbsvc.c | 22 +++---
1 files changed, 11 insertions(+), 11 deletions
This patch fixes the warning Using plain integer as NULL pointer,
generated by sparse, by replacing the offending 0s with NULL.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/ozwpan/ozhcd.c | 135
1 files changed, 68 insertions(+), 67
This patch fixes the warning Using plain integer as NULL pointer,
generated by sparse, by replacing the offending 0s with NULL.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/ozwpan/ozproto.c | 78 +++---
1 files changed, 39 insertions(+), 39
This patch fixes the warning Using plain integer as NULL pointer,
generated by sparse, by replacing the offending 0s with NULL.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/ozwpan/ozeltbuf.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git
This patch fixes the warning Using plain integer as NULL pointer,
generated by sparse, by replacing the offending 0s with NULL.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/ozwpan/ozcdev.c | 24
1 files changed, 12 insertions(+), 12 deletions
Smatch warns about:
staging/comedi/drivers/cb_pcidas64.c:3304 prep_ao_dma() warn: if();
So the check currently does nothing and can be removed, as indicated by
Ian.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
v1 was staging/comedi: Fix if(); by adding proper code
which was unfortunately
marked
as const.
CC: David Howells dhowe...@redhat.com
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
v2: Included feedback about const by David Howells. Thanks David.
drivers/staging/panel/panel.c | 31 ---
1 files changed, 16 insertions(+), 15 deletions(-)
diff
This patch fixes the warning Using plain integer as NULL pointer,
generated by sparse, by replacing the offending 0s with NULL.
If the initialization with NULL was unnecessary (due to unconditional
assignment before first use) it was removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
This patch fixes the warning Using plain integer as NULL pointer,
generated by sparse, by replacing the offending 0s with NULL.
If the initialization with NULL was unnecessary (due to unconditional
assignment before first use) it was removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
This patch fixes the warning Using plain integer as NULL pointer,
generated by sparse, by replacing the offending 0s with NULL.
If the initialization with NULL was unnecessary (due to unconditional
assignment before first use) it was removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
This patch fixes the warning Using plain integer as NULL pointer,
generated by sparse, by replacing the offending 0s with NULL.
If the initialization with NULL was unnecessary (due to unconditional
assignment before first use) it was removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
This patch fixes the warning Using plain integer as NULL pointer,
generated by sparse, by replacing the offending 0s with NULL.
If the initialization with NULL was unnecessary (due to unconditional
assignment before first use) it was removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
This patch fixes the warning Using plain integer as NULL pointer,
generated by sparse, by replacing the offending 0s with NULL.
If the initialization with NULL was unnecessary (due to unconditional
assignment before first use) it was removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
This patch fixes the warning Using plain integer as NULL pointer,
generated by sparse, by replacing the offending 0s with NULL.
If the initialization with NULL was unnecessary (due to unconditional
assignment before first use) it was removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
The tempal variable is assigned and then immediately overwritten.
- remove everything without effect.
The inb is kept for possible side effects.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c |9 +
1 files changed, 1 insertions(+), 8 deletions
Both branches of this if statement end in the same return statement.
- move the return to the bottom and get rid of the else statement.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git
Both branches of this if statement execute the same code.
Thus we can || them together and remove code duplication
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging
Instead of calling the same function three times in a loop, multiply the
loop counter by three.
And since the value in DAC_TEST_PARMS is always the same we can use the
value directly.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c | 11 +++
1 files
Both functions xgifb_reg_get and inb return an u8 value, so we don't
need to cast their return value to unsigned char.
- remove the cast
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_init.c|2 +-
drivers/staging/xgifb/vb_setmode.c | 66
happy.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/usbip/stub_dev.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c
index ca5de9d..67556ac 100644
--- a/drivers/staging/usbip
1 - 100 of 702 matches
Mail list logo
