Re: [PATCH v2 2/4] tpm: Move eventlog files to a subdirectory

Hi Mimi, > [Cc'ing Petr Vorel and the ltp mailing list] > Hi Jarrko, > On Fri, 2018-04-20 at 08:39 +0300, Jarkko Sakkinen wrote: > > On Thu, Apr 12, 2018 at 12:13:48PM +0200, Thiebaud Weksteen wrote: > > > Signed-off-by: Thiebaud Weksteen <tw...@google.com> >

Re: linux-next: build warning after merge of the integrity tree

Hi Stephen, > Hi all, > After merging the integrity tree, today's linux-next build (powerpc > allyesconfig) produced this warning: > security/integrity/ima/ima_kexec.c:18:0: warning: "pr_fmt" redefined > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > In file included from

Re: [PATCH] ima: Fix pr_fmt() redefinition

Hi Mimi, > On Thu, 2018-05-17 at 12:47 +0200, Petr Vorel wrote: > > Previous definition was too late and caused problems in powerpc > > allyesconfig: > > security/integrity/ima/ima_kexec.c:18:0: warning: "pr_fmt" redefined > > #define pr_fmt(fmt) KBUILD_M

[PATCH] ima: Fix pr_fmt() redefinition

previous definition #define pr_fmt(fmt) fmt Fixes: 3dea0d93d257 ("ima: Unify logging") Signed-off-by: Petr Vorel <pvo...@suse.cz> Reported-by: Stephen Rothwell <s...@canb.auug.org.au> --- security/integrity/ima/ima_kexec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

Re: [PATCH] kconfig: clean-up reverse dependency help implementation

for a single line, it was previously > displayed in the same line as "Selected by", like this: > Selected by: A [=n] && B [=n] > This will be displayed in a new line, consistently: > Selected by: > - A [=n] && B [=n] >

Re: [PATCH] kconfig: Print reverse dependencies in groups

Hi Masahiro, > Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> Acked-by: Petr Vorel <pvo...@suse.cz> Just please fix typo leading to segfault and add ':' > get_symbol_props_str(r, sym, P_SELECT, _(" Selects: ")); > if (sym->rev_dep.

Re: [PATCH] kconfig: Print reverse dependencies in groups

Hi Masahiro, > > Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> > Acked-by: Petr Vorel <pvo...@suse.cz> Well, I'm not really the one to ack anything here, so please: Reviewed-by: Petr Vorel <pvo...@suse.cz> Kind regards, Petr

Re: [PATCH v2] kconfig: make unmet dependency warnings readable

cies detected for OF_GPIO > Depends on: > GPIOLIB [=y] && OF [=y] && HAS_IOMEM [=n] > Selected by [y]: > - PINCTRL_MTK [=y] && PINCTRL [=y] && (ARCH_MEDIATEK || COMPILE_TEST > [=y]) && OF [=y] > - PINCTRL_MT7622 [=y] &&

Re: [PATCH] kconfig: merge_config: avoid false positive matches from comment lines

t against false positives from > comment lines. The new sed expression matches to config options > followed by '=' or ' is not set'. > Signed-off-by: Masahiro Yamada > --- Reviewed-by: Petr Vorel > -SED_CONFIG_EXP="s/^\(# \)\{0,1\}\(${CONFIG_PREFIX}[a-zA-Z0-9_]*\)[= ].*/\2/p

Re: [PATCH] kconfig: Print reverse dependencies in groups

Hi Masahiro, > Signed-off-by: Masahiro Yamada Acked-by: Petr Vorel Just please fix typo leading to segfault and add ':' > get_symbol_props_str(r, sym, P_SELECT, _(" Selects: ")); > if (sym->rev_dep.expr) { > - str_appen

Re: [PATCH] kconfig: clean-up reverse dependency help implementation

for a single line, it was previously > displayed in the same line as "Selected by", like this: > Selected by: A [=n] && B [=n] > This will be displayed in a new line, consistently: > Selected by: > - A [=n] && B [=n] > Signed-off-by: Masahi

Re: [PATCH] kconfig: Print reverse dependencies in groups

Hi Masahiro, > > Signed-off-by: Masahiro Yamada > Acked-by: Petr Vorel Well, I'm not really the one to ack anything here, so please: Reviewed-by: Petr Vorel Kind regards, Petr

Re: linux-next: build warning after merge of the integrity tree

Hi Stephen, > Hi all, > After merging the integrity tree, today's linux-next build (powerpc > allyesconfig) produced this warning: > security/integrity/ima/ima_kexec.c:18:0: warning: "pr_fmt" redefined > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > In file included from

[PATCH] ima: Fix pr_fmt() redefinition

previous definition #define pr_fmt(fmt) fmt Fixes: 3dea0d93d257 ("ima: Unify logging") Signed-off-by: Petr Vorel Reported-by: Stephen Rothwell --- security/integrity/ima/ima_kexec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/security/integrity/ima/ima_kex

Re: [PATCH] ima: Fix pr_fmt() redefinition

Hi Mimi, > On Thu, 2018-05-17 at 12:47 +0200, Petr Vorel wrote: > > Previous definition was too late and caused problems in powerpc > > allyesconfig: > > security/integrity/ima/ima_kexec.c:18:0: warning: "pr_fmt" redefined > > #define pr_fmt(fmt) KBUILD_M

Re: [PATCH v2 2/4] tpm: Move eventlog files to a subdirectory

Hi Mimi, > [Cc'ing Petr Vorel and the ltp mailing list] > Hi Jarrko, > On Fri, 2018-04-20 at 08:39 +0300, Jarkko Sakkinen wrote: > > On Thu, Apr 12, 2018 at 12:13:48PM +0200, Thiebaud Weksteen wrote: > > > Signed-off-by: Thiebaud Weksteen > > > Suggested-b

Re: [PATCH v2] kconfig: make unmet dependency warnings readable

cies detected for OF_GPIO > Depends on: > GPIOLIB [=y] && OF [=y] && HAS_IOMEM [=n] > Selected by [y]: > - PINCTRL_MTK [=y] && PINCTRL [=y] && (ARCH_MEDIATEK || COMPILE_TEST > [=y]) && OF [=y] > - PINCTRL_MT7622 [=y] && PINCTR

[PATCH 1/1] linux/sysinfo.h: Add guarder for struct sysinfo

for all but glibc libc. This fixes redefinition on MUSL which also defines struct sysinfo when including (which includes via ) and . glibc loads in . Signed-off-by: Petr Vorel --- include/uapi/linux/sysinfo.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/linux

Re: [musl] [PATCH 1/1] linux/sysinfo.h: Add guarder for struct sysinfo

Hi Rich, ... > I don't think this is the right way to do it. It prevents getting > access to the kernel uapi structure (which may be wanted) if you're > not using glibc or if you include kernel headers before any libc > headers. Rather, , whose only real purpose is > providing this structure to

[PATCH 1/1] uapi: Don't include in

-linux-musl/sysroot/usr/include/sys/sysinfo.h:10:8: note: originally defined here [1] or , , , Suggested-by: Rich Felker Signed-off-by: Petr Vorel --- Hi, this looks to be long standing problem: python-psutil [2], iproute2 [3], even for glibc in the past [4] and it tried to be solved bef

Re: [musl] [PATCH 1/1] uapi: Don't include in

Hi Rich, > On Thu, Oct 01, 2020 at 09:52:31PM +0200, Petr Vorel wrote: > > + update code where needed (include in code which > > included only to get struct sysinfo or SI_LOAD_SHIFT). > > The reason is to avoid indirect include when using > > some net

[RFC PATCH v2 1/1] uapi: Introduce

o.h:10:8: note: originally defined here Suggested-by: Rich Felker Signed-off-by: Petr Vorel --- Changes v1->v2: * Move kernel.h content into new header in order not break the existing contract with glibc. Background: long standing problem: python-psutil [1], iproute2 [2], even for glibc in th

Re: [musl] [PATCH 1/1] uapi: Don't include in

Hi, > On Thu, Oct 01, 2020 at 10:27:03PM +0200, Petr Vorel wrote: > > Hi Rich, > > > On Thu, Oct 01, 2020 at 09:52:31PM +0200, Petr Vorel wrote: > > > > + update code where needed (include in code which > > > > included only to get struct sysi

[PATCH v3 1/1] uapi: Move constants from to

inally defined here Suggested-by: Rich Felker Signed-off-by: Petr Vorel --- Changes v2->v3: * Move things to instead of creating new header . Kind regards, Petr include/uapi/linux/const.h | 5 + include/uapi/linux/ethtool.h| 2 +- include/uapi/linux/kernel.h

Re: [PATCH v3 1/1] uapi: Move constants from to

/tst_safe_macros.h:15, > from ../include/tst_test.h:93, > from tst_crypto.c:11: > x86_64-buildroot-linux-musl/sysroot/usr/include/sys/sysinfo.h:10:8: note: > originally defined here > Suggested-by: Rich Felker > Signed-off-by: Petr Vorel > --- &g

Re: [PATCH] HID: logitech-dj: Fix check of logi_dj_recv_query_paired_devices()

Hi, > In delayedwork_callback(), logi_dj_recv_query_paired_devices > may return positive value while success now, so check it > correctly. > Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of > logi_dj_recv_query_hidpp_devices") > Signed-off-by: YueHaib

Re: [PATCH] HID: logitech-dj: Fix check of logi_dj_recv_query_paired_devices()

gt; > Signed-off-by: YueHaibing > Reviewed-by: Petr Vorel OK, not only it didn't fix problems with logitech mouse (see below), but removing mouses USB dongle effectively crashes kernel, so this one probably shouldn't be applied :). [ 330.721629] logitech-djreceiver: probe of 0003:046D:C52F.

Re: [PATCH] HID: logitech-dj: Fix check of logi_dj_recv_query_paired_devices()

Hi Hans, > Please test my patch titled: "HID: logitech-dj: Really fix return value of > logi_dj_recv_query_hidpp_devices" > which should fix this. Indeed, patch [1] fixed that, thanks :) > Regards, > Hans Kind regards, Petr [1] https://patchwork.kernel.org/patch/11064087/

Re: [LTP] [PATCH 5.8 000/232] 5.8.3-rc1 review

Hi all, > On Thu, Aug 20, 2020 at 08:57:57PM +0530, Naresh Kamboju wrote: > > On Thu, 20 Aug 2020 at 14:55, Greg Kroah-Hartman > > wrote: > > > This is the start of the stable review cycle for the 5.8.3 release. > > > There are 232 patches in this series, all will be posted as a response > > >

Re: [PATCH v3 1/1] loop: scale loop device by introducing per device lock

t global > data such as loop_index_idr, loop_lookup, loop_add. > Lock ordering: loop_ctl_mutex > lo_mutex. Reviewed-by: Petr Vorel Kind regards, Petr

Re: [PATCH] selftests/tpm2: Add the missing TEST_FILES assignment

Hi Jarkko, > The Python files required by the selftests are not packaged because of > the missing assignment to TEST_FILES. Add the assignment. > Cc: sta...@vger.kernel.org > Fixes: 6ea3dfe1e073 ("selftests: add TPM 2.0 tests") > Signed-off-by: Jarkko Sakkinen Revie

Re: [PATCH v2] Kernel selftests: Add check if tpm devices are supported

Hi Nikita, > tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they > are available. In case, when these devices are not available test > fails, but expected behaviour is skipped test. > Signed-off-by: Nikita Sobolev Reviewed-by: Petr Vorel Thanks for v2, but I se

Re: [PATCH v2] Kernel selftests: Add check if tpm devices are supported

> tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they > are available. In case, when these devices are not available test > fails, but expected behaviour is skipped test. > Signed-off-by: Nikita Sobolev OK, I see it was also reverted by Jarkko

Re: [PATCH v3] Kernel selftests: Add check if TPM devices are supported

Hi, > TPM2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they > are available. In case, when these devices are not available test > fails, but expected behaviour is skipped test. Reviewed-by: Petr Vorel Kind regards, Petr

Re: [PATCH] sefltest/ima: support appended signatures (modsig)

Hi Mimi, > Detect and allow appended signatures. > Signed-off-by: Mimi Zohar Reviewed-by: Petr Vorel Kind regards, Petr

Re: s390 EAGAIN on send{msg,to}()/recvmsg() on small MTU and big packet size

Hi, [ Cc Alexey and Ihno ] Any hint on this? I know it's a corner case, but it'd be nice to have it fixed. Kind regards, Petr > Hi, > I've found a bug on s390 on small MTU combined with big packet size, using > ping > (of course both within valid ranges, e.g. MTU 552 and packet size 61245).

Re: [PATCH] ipv6: Properly check reference count flag before taking reference

cremented, which > would result in the use-after-free users are seeing. This commit changes > the `|` to the proper `&` test. > Cc: sta...@vger.kernel.org > Fixes: 7d30a7f6424e ("Merge branch > 'ipv6-avoid-taking-refcnt-on-dst-during-route-lookup'") > Signed-off-

s390 EAGAIN on send{msg,to}()/recvmsg() on small MTU and big packet size

Hi, I've found a bug on s390 on small MTU combined with big packet size, using ping (of course both within valid ranges, e.g. MTU 552 and packet size 61245). Below is full reproducer on netns. I tested it on vanilla: v5.3-rc8 and v4.16. I reproduced it on current iputils master which uses

Re: [LTP] 12abeb544d: ltp.read_all_dev.fail

Hi, > > FYI, we noticed the following commit (built with gcc-7): > > commit: 12abeb544d548f55f56323fc6e5e6c0fb74f58e1 ("horrible test hack") > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/luto/linux.git > > random/kill-it ... > > tst_test.c:1108: INFO: Timeout per run is 0h 05m

Re: [LTP] [blk] 6e6fcbc27e: ltp.fs_fill.fail

Hi, > FYI, we noticed the following commit (built with gcc-9): > commit: 6e6fcbc27e7788af54139c53537395d95560f2ef ("blk-mq: support batching > dispatch in case of io") > https://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git > for-5.9/drivers > in testcase: ltp > with following

Re: [PATCH] Kernel selftests: Add check if tpm devices are supported

Hi Nikita, > tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they > are available. In case, when these devices are not available test > fails, but expected behaviour is test to be skipped. > Signed-off-by: Nikita Sobolev Good catch. Reviewed-by: Petr Vorel &g

Re: [PATCH 1/3] selftest/ima: cleanup the kexec selftest

Hi Mimi, > Remove the few bashisms in the script and use the complete option name > for clarity. > Signed-off-by: Mimi Zohar Reviewed-by: Petr Vorel > --- > tools/testing/selftests/ima/test_kexec_load.sh | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletion

Re: [PATCH 2/3] scripts/ima: define a set of common functions

Hi Mimi, > Define and move get_secureboot_mode() to a common file for use by other > tests. > Signed-off-by: Mimi Zohar Reviewed-by: Petr Vorel > --- > tools/testing/selftests/ima/common_lib.sh | 20 > tools/testing/selftests/ima/test_

Re: [PATCH 3/3] selftests/ima: kexec_file_load syscall test

> Signed-off-by: Mimi Zohar Reviewed-by: Petr Vorel ... > +++ b/tools/testing/selftests/ima/test_kexec_file_load.sh > @@ -0,0 +1,250 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0+ # SPDX-License-Identifier: GPL-2.0-or-later > +# > +# Loading a kernel image via the k

Re: [PATCH] selftests: add TPM 2.0 tests

Hi Jarkko, > Added the tests that I've been using for testing TPM 2.0 functionality > for long time but have out-of-tree so far residing in > https://github.com/jsakkine-intel/tpm2-scripts > Cc: Tadeusz Struk > Signed-off-by: Jarkko Sakkinen > Acked-By: Joey Pabalinas Revie

Re: [PATCH v2 2/5] selftests/ima: define a set of common functions

Hi Mimi, > Define, update and move get_secureboot_mode() to a common file for use > by other tests. > Signed-off-by: Mimi Zohar Reviewed-by: Petr Vorel ... > ifeq ($(ARCH),x86) > TEST_PROGS := test_kexec_load.sh > +TEST_FILES := common_lib.sh In case there might be s

Re: [PATCH v2 3/5] selftests/ima: define common logging functions

Hi Mimi, > Define log_info, log_pass, log_fail, and log_skip functions. > Suggested-by: Petr Vorel > Signed-off-by: Mimi Zohar > --- > tools/testing/selftests/ima/common_lib.sh | 43 > +++--- > tools/testing/selftests/ima/test_kexec_load.sh |

Re: [PATCH v2 3/5] selftests/ima: define common logging functions

Hi Mimi, > Define log_info, log_pass, log_fail, and log_skip functions. > Suggested-by: Petr Vorel > Signed-off-by: Mimi Zohar Reviewed-by: Petr Vorel > --- > tools/testing/selftests/ima/common_lib.sh | 43 > +++--- > tools/testing/selftests/i

Re: [PATCH v2 4/5] selftests/ima: kexec_file_load syscall test

> Signed-off-by: Mimi Zohar Reviewed-by: Petr Vorel LGTM, minor comments below. ... > +++ b/tools/testing/selftests/ima/common_lib.sh ... > +# Look for config option in Kconfig file. > +# Return 1 for found and 0 for not found. > +kconfig_enabled() > +{ > + local config="

Re: [PATCH v2 4/5] selftests/ima: kexec_file_load syscall test

Hi Mimi, > The kernel can be configured to verify PE signed kernel images, IMA > kernel image signatures, both types of signatures, or none. This test > verifies only properly signed kernel images are loaded into memory, > based on the kernel configuration and runtime policies. > Signed-off-by:

Re: [PATCH v2 5/5] selftests/ima: loading kernel modules

ured, that at least an appended kernel > module signature or an IMA signature is required based on the Kconfig > and the runtime IMA policy. > Signed-off-by: Mimi Zohar Reviewed-by: Petr Vorel ... > diff --git a/tools/testing/selftests/ima/test_kernel_module.sh > b/tools/testing/selfte

Re: [PATCH v2 5/5] selftests/ima: loading kernel modules

Hi Shuah, > We can do this as a separate effort in the interest of getting these > in the interest of getting these in. > We have common functions in ksefltest.h for c and we don't have them > for tests scripts. We might be able to collect common routines such > as get_kconfig into a common .sh

Re: [PATCH] scripts/kconfig/Makefile: use KCONFIG_CONFIG if set

ent filename. > If KCONFIG_CONFIG is set, use it; otherwise behave as if it was set > to `.config'. > Signed-off-by: Arseny Maslennikov Good catch :). Yes, many targets are affected to it: xenconfig, tinyconfig + archs: rm -f .config; make ARCH=arm KCONFIG_CONFIG=.myconfig dram_0xd000.c

Re: [PATCH] scripts/package/mkdebian: expose KCONFIG_CONFIG to debian/rules

or: debian/rules build subprocess returned exit status 2 > debuild: fatal error at line 1182: > dpkg-buildpackage -us -uc -ui -i failed Reviewed-by: Petr Vorel Kind regards, Petr

Re: [PATCH] scripts/package/Makefile: put proper config in source tarball

ss of the value of KCONFIG_CONFIG, > failing spectacularly if .config is absent and packing the wrong config > if it exists. > Let's fix that. > Signed-off-by: Arseny Maslennikov Reviewed-by: Petr Vorel Kind regards, Petr

Re: [PATCH v2 1/8] evmtest: Regression testing integrity subsystem

Hi David, > $ evmtest runtest example_test -e /bin/bash > [*] Starting test: example_test > [*] TEST: PASSED > Example 1a: successful verbose example test output > $ evmtest runtest example_test -e /bin/bash -v ... > Changelog: ... > * checkbashishms compliant Not yet :). I noticed using source

Re: [PATCH v3 5/7] selftests/ima: kexec_file_load syscall test

Hi Mimi, Dave, > > Frankly I did not read and followup much about the testing code changes, > > not sure if it is doable or not. The code sharing under testing folder > > seems not very good. For example the basic check_root is needed by > > different parts, but all have its own implementation.

Re: [PATCH v2 4/5] selftests/ima: kexec_file_load syscall test

Hi Mimi, > On Thu, 2019-02-28 at 23:00 +0100, Petr Vorel wrote: > > > + local keypair1="$2" > > > + local keypair2="$3" > > > + > > > + mount_securityfs > > > + > > > + local ima_policy=$SECURITYFS/ima/policy > >

Re: [PATCH] kconfig: merge_config: avoid false positive matches from comment lines

t against false positives from > comment lines. The new sed expression matches to config options > followed by '=' or ' is not set'. > Signed-off-by: Masahiro Yamada > --- Reviewed-by: Petr Vorel > -SED_CONFIG_EXP="s/^\(# \)\{0,1\}\(${CONFIG_PREFIX}[a-zA-Z0-9_]*\)[= ].*/\2/p

Re: [PATCH v2 1/2] ima: Free IMA measurement buffer on error

Hi all, > > > > > > > > This is not the correct way to submit patches for inclusion in the > > > > stable kernel tree. Please read: > > > > > > > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > > > for how to do this properly. > > > > > > > Thanks for

Re: [PATCH v3] IMA: support for duplicate measurement records

Hi Tushar, > Change Log v3: > - Incorporated feedback from Mimi on v2. > - Updated patch title and description to make it generic. > - Changed config description word 'data' to 'records'. > - Tested use cases for boot param "ima_policy=tcb". LGTM. Reviewed-by: Petr Vorel Kind regards, Petr