Re: [PATCH v2 5/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states

Hi Sudeep, >> +static void combine_lpi_states(struct acpi_processor_lpi *l_lpi, >> + struct acpi_processor_lpi *p_lpi, >> + struct acpi_processor_lpi *c_lpi) >> +{ >> + c_lpi->min_residency = max(l_lpi->min_residency, >>

Re: [PATCH v3 0/5] ACPI / processor_idle: Add ACPI v6.0 LPI support

Reviewed the patch-set and tested it on an ARM platform over the last couple of days without any issues, so Tested-by: Prashanth Prakash Thanks, Prashanth On 12/2/2015 7:10 AM, Sudeep Holla wrote: > ACPI 6.0 introduced LPI(Low Power Idle) states that provides an

Re: [PATCH v2 5/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states

Hi Sudeep, On 10/27/2015 8:09 AM, Sudeep Holla wrote: > Hi Prashanth, > > On 27/10/15 00:21, Prakash, Prashanth wrote: >> Hi Sudeep, >> >> While testing with these patches everything looked fine except that we >> are flattening all the LPI >> states even if

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

On 6/8/2016 10:24 AM, Hoan Tran wrote: > Hi Ashwin, > > On Wed, Jun 8, 2016 at 5:18 AM, Ashwin Chaugule > wrote: >> + Prashanth (Can you please have a look as well?) >> >> On 31 May 2016 at 15:35, Hoan Tran wrote: >>> Hi Ashwin, >> Hi, >> >> Sorry

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

On 6/9/2016 2:47 PM, Hoan Tran wrote: > Hi Ashwin and Prashanth, > > On Wed, Jun 8, 2016 at 5:41 PM, Hoan Tran <hot...@apm.com> wrote: >> Hi Prashanth, >> >> >> On Wed, Jun 8, 2016 at 5:32 PM, Prakash, Prashanth >> <pprak...@codeaurora.org> w

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

On 6/9/2016 4:43 PM, Hoan Tran wrote: > Hi Prashanth, > > On Thu, Jun 9, 2016 at 3:25 PM, Prakash, Prashanth > <pprak...@codeaurora.org> wrote: >> >> On 6/9/2016 2:47 PM, Hoan Tran wrote: >>> Hi Ashwin and Prashanth, >>> >>> On Wed,

Re: [PATCH] mailbox: pcc: Add PCC request and free channel declarations

Hi Hoan, On 6/14/2016 5:12 PM, Hoan Tran wrote: > As PCC will be used by other clients not only CPPC. > This change exports pcc_mbox_request_channel() and pcc_mbox_free_channel() > declarations > > Signed-off-by: Hoan Tran > --- > include/acpi/cppc_acpi.h | 4 >

Re: [PATCH] ACPI: CPPC: Return error if _CPC is invalid on a CPU

Hi Hoan, On 6/17/2016 4:16 PM, Hoan Tran wrote: > Based on 8.4.7.1 section of ACPI 6.1 specification, if the platform > supports CPPC, the _CPC object must exist under all processor objects. > If cpc_desc_ptr pointer is invalid on any CPUs, acpi_get_psd_map() > should return error and CPPC

Re: [PATCH v2] mailbox: pcc: Add PCC request and free channel declarations

Hi Rafael, On 6/22/2016 6:49 PM, Rafael J. Wysocki wrote: > On Thursday, June 16, 2016 02:09:38 PM Hoan Tran wrote: >> Exports pcc_mbox_request_channel() and pcc_mbox_free_channel() >> declarations into a pcc.h header file. >> >> v2 >> * Introduce pcc.h header file for pcc client methods >> >>

Re: [PATCH v4 4/5] arm64: add support for ACPI Low Power Idle(LPI)

Hi Sudeep, On 4/19/2016 6:30 AM, Sudeep Holla wrote: > +struct acpi_processor_lpi *lpi; > +int acpi_processor_ffh_lpi_enter(struct acpi_processor_lpi *lpi, int idx) > +{ > + int ret; > + > + if (!idx) { > + cpu_do_idle(); > + return idx; > + } > + > + /*

Re: [PATCH v5 2/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states

On 5/18/2016 11:37 AM, Sudeep Holla wrote: > > > On 17/05/16 18:46, Prakash, Prashanth wrote: >> Hi Sudeep, >> >> On 5/11/2016 9:37 AM, Sudeep Holla wrote: >>> + >>> +static int acpi_processor_get_lpi_info(struct acpi_processor *pr

Re: [PATCH v5 2/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states

Hi Sudeep, On 5/11/2016 9:37 AM, Sudeep Holla wrote: > + > +static int acpi_processor_get_lpi_info(struct acpi_processor *pr) > +{ > + int ret, i; > + struct acpi_lpi_states_array *info; > + struct acpi_device *d = NULL; > + acpi_handle handle = pr->handle, pr_ahandle; > +

Re: [PATCH v4] Force cppc_cpufreq to report values in KHz to fix user space reporting

On 7/14/2016 10:15 AM, Al Stone wrote: > On 07/14/2016 04:03 AM, Alexey Klimov wrote: >> Hi Al, >> >> On Tue, Jul 12, 2016 at 11:16:11AM -0600, Al Stone wrote: >>> When CPPC is being used by ACPI on arm64, user space tools such as >>> cpupower report CPU frequency values from sysfs that are

Re: [PATCH v4] Force cppc_cpufreq to report values in KHz to fix user space reporting

Hi Al, On 7/14/2016 11:57 AM, Al Stone wrote: > On 07/14/2016 11:39 AM, Prakash, Prashanth wrote: >> >> On 7/14/2016 10:15 AM, Al Stone wrote: >>> On 07/14/2016 04:03 AM, Alexey Klimov wrote: >>>> Hi Al, >>>> >>>> On Tue, Jul 1

Re: [PATCH] ACPI: CPPC: Support PCC with interrupt flag

Hi Hoan, On 8/30/2016 12:20 PM, Hoan Tran wrote: > On Thu, Jul 21, 2016 at 2:07 PM, Hoan Tran wrote: >> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone() >> function to notify the mailbox framework about TX completion. >> >> Signed-off-by: Hoan Tran

Re: [PATCH] mailbox: PCC: Fix lockdep warning when request PCC channel

Hi Hoan, On 10/14/2016 4:52 PM, Hoan Tran wrote: > This patch fixes the lockdep warning below > > [7.229767] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) > [7.229776] [ cut here ] > [7.229787] WARNING: CPU: 1 PID: 1 at >

Re: [PATCH v2] mailbox: PCC: Fix lockdep warning when request PCC channel

Hi Hoan, On 10/18/2016 1:00 AM, Hoan Tran wrote: > This patch fixes the lockdep warning below > > [7.229767] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) > [7.229776] [ cut here ] > [7.229787] WARNING: CPU: 1 PID: 1 at >

Re: [PATCH v4] mailbox: PCC: Fix lockdep warning when request PCC channel

Hi Hoan, On 11/14/2016 12:19 PM, Hoan Tran wrote: > This patch fixes the lockdep warning below > > [7.229767] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) > [7.229776] [ cut here ] > [7.229787] WARNING: CPU: 1 PID: 1 at >

Re: [PATCH v3] mailbox: PCC: Fix lockdep warning when request PCC channel

HI Hoan, On 11/9/2016 11:39 PM, Hoan Tran wrote: > Hi All, > > On Thu, Oct 27, 2016 at 3:34 PM, Hoan Tran wrote: >> This patch fixes the lockdep warning below >> >> [7.229767] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) >> [7.229776] [ cut here

Re: [PATCH v2] cpufreq: CPPC: Correct desired_perf calculation

On 10/13/2016 11:33 AM, Hoan Tran wrote: > The desired_perf is an abstract performance number. Its value should > be in the range of [lowest perf, highest perf] of CPPC. > The correct calculation is > desired_perf = freq * cppc_highest_perf / cppc_dmi_max_khz > > And cppc_cpufreq_set_target()

Re: [PATCH] cpufreq: CPPC: Correct desired_perf calculation

Hi Hoan, On 10/11/2016 3:12 PM, Hoan Tran wrote: > The desired_perf is an abstract performance number. Its value should > be in the range of [lowest perf, highest perf] of CPPC. > The correct calculation is > desired_perf = freq * cppc_highest_perf / cppc_dmi_max_khz > > Signed-off-by: Hoan

Re: [PATCH] ACPI/CPC: Don't try to clean up uninitialized CPC data

Hi Boris, On 12/16/2016 11:35 AM, Boris Ostrovsky wrote: > If acpi_cppc_processor_probe() had not executed successfully (for > example, if _CPC object was not found) then cpc_desc_ptr for that > processor will be invalid. > > Signed-off-by: Boris Ostrovsky > --- >

Re: [PATCH 0/2] Make cppc acpi driver aware of pcc subspace ids

Hi George, On 3/31/2017 12:24 AM, George Cherian wrote: > The current cppc acpi driver works with only one pcc subspace id. > It maintains and registers only one pcc channel even if the acpi table has > different pcc subspace ids. The series tries to address the same by making > cppc acpi

Re: [PATCH 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

Hi George, On 6/13/2017 8:17 AM, George Cherian wrote: > Based on ACPI 6.2 Section 8.4.7.1.9 If the PCC register space is used, > all PCC registers, for all processors in the same performance > domain (as defined by _PSD), must be defined to be in the same subspace. > Based on Section 14.1 of

Re: [PATCH 0/2] Make cppc acpi driver aware of pcc subspace ids

On 6/28/2017 3:20 PM, Rafael J. Wysocki wrote: > On Tuesday, June 13, 2017 02:17:09 PM George Cherian wrote: >> The current cppc acpi driver works with only one pcc subspace id. >> It maintains and registers only one pcc channel even if the acpi table has >> different pcc subspace ids. >> >> As

Re: [PATCH] mailbox: pcc: Fix crash when request PCC channel 0

On 7/24/2017 2:32 PM, Rafael J. Wysocki wrote: > On Friday, July 21, 2017 03:09:29 PM Hoan Tran wrote: >> When PCCT is not available, kernel crashes as below when requests PCC >> channel 0. This patch fixes this issue. >> >> [0.920454] PCCT header not found. >> ... >> [8.031309] Unable

Re: [PATCHv2 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

Hi George, On 7/21/2017 1:43 AM, George Cherian wrote: > Based on ACPI 6.2 Section 8.4.7.1.9 If the PCC register space is used, > all PCC registers, for all processors in the same performance > domain (as defined by _PSD), must be defined to be in the same subspace. > Based on Section 14.1 of

Re: [PATCH v4 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

On 10/3/2017 5:01 AM, George Cherian wrote: > Hi Prakash, > > On 09/29/2017 04:49 AM, Prakash, Prashanth wrote: >> Hi George, >> >> On 9/19/2017 11:24 PM, George Cherian wrote: >>> Based on ACPI 6.2 Section 8.4.7.1.9 If the PCC register space is used, >&

Re: [PATCH v4 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

Hi George, On 9/19/2017 11:24 PM, George Cherian wrote: > Based on ACPI 6.2 Section 8.4.7.1.9 If the PCC register space is used, > all PCC registers, for all processors in the same performance > domain (as defined by _PSD), must be defined to be in the same subspace. > Based on Section 14.1 of

Re: [PATCH v3 3/3] mailbox: ACPI: erroneous error message when parsing the ACPI PCCT

On 4/30/2018 6:39 PM, Al Stone wrote: > There have been multiple reports of the following error message: > > [0.068293] Error parsing PCC subspaces from PCCT > > This error message is not correct. In multiple cases examined, the PCCT > (Platform Communications Channel Table) concerned is

Re: [PATCH] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

On 5/25/2018 12:27 AM, George Cherian wrote: > Hi Prashanth, > > On 05/25/2018 12:55 AM, Prakash, Prashanth wrote: >> Hi George, >> >> On 5/22/2018 5:42 AM, George Cherian wrote: >>> Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance >>

Re: [PATCH] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

Hi George, On 5/22/2018 5:42 AM, George Cherian wrote: > Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance > feedback via set of performance counters. To determine the actual > performance level delivered over time, OSPM may read a set of > performance counters from the

Re: [PATCH v4 3/3] mailbox: ACPI: erroneous error message when parsing the ACPI, PCCT

On 5/17/2018 4:24 AM, Rafael J. Wysocki wrote: > On Thu, May 17, 2018 at 12:01 AM, Al Stone wrote: >> There have been multiple reports of the following error message: >> >> [0.068293] Error parsing PCC subspaces from PCCT >> >> This error message is not correct. In multiple

Re: [PATCH v2] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

Hi George, On 6/15/2018 4:03 AM, George Cherian wrote: > Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance > feedback via set of performance counters. To determine the actual > performance level delivered over time, OSPM may read a set of > performance counters from the

Re: [PATCH] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

On 5/28/2018 1:09 AM, George Cherian wrote: > Hi Prashanth, > > On 05/26/2018 02:30 AM, Prakash, Prashanth wrote: >> >> On 5/25/2018 12:27 AM, George Cherian wrote: >>> Hi Prashanth, >>> >>> On 05/25/2018 12:55 AM, Prakash, Prashanth wrote: >&g

Re: [PATCH v5 1/2] mailbox: PCC: Move the MAX_PCC_SUBSPACES definition to header file

On 10/11/2017 2:54 AM, George Cherian wrote: > Move the MAX_PCC_SUBSPACES definition to acpi/pcc.h file. In preparation to > add subspace id support for cppc_acpi driver. > > Signed-off-by: George Cherian Reviewed-by: Prashanth Prakash --

Re: [PATCH v5 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

On 10/11/2017 2:54 AM, George Cherian wrote: > Based on ACPI 6.2 Section 8.4.7.1.9 If the PCC register space is used, > all PCC registers, for all processors in the same performance > domain (as defined by _PSD), must be defined to be in the same subspace. > Based on Section 14.1 of ACPI

Re: [PATCH v2] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

Hi George, On 6/20/2018 3:17 AM, George Cherian wrote: > Hi Prakash, > > Thanks for the review. > > On 06/19/2018 01:51 AM, Prakash, Prashanth wrote: >> External Email >> >> Hi George, >> >> On 6/15/2018 4:03 AM, George Cherian wrote: >>> Pe

Re: [PATCH v3] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

On 7/9/2018 11:42 PM, George Cherian wrote: > Hi Prakash, > > > On 07/09/2018 10:12 PM, Prakash, Prashanth wrote: >> >> Hi George, >> >> >> On 7/9/2018 4:10 AM, George Cherian wrote: >>> Per Section 8.4.7.1.3 of ACPI 6.2, The platform provi

Re: [PATCH v3] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

Hi George, On 7/9/2018 4:10 AM, George Cherian wrote: > Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance > feedback via set of performance counters. To determine the actual > performance level delivered over time, OSPM may read a set of > performance counters from the

Re: [PATCH v4] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

Hi George, This version looks good. Thanks! On 7/12/2018 12:07 AM, George Cherian wrote: > Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance > feedback via set of performance counters. To determine the actual > performance level delivered over time, OSPM may read a set of >

Re: [PATCH v3 3/3] mailbox: ACPI: erroneous error message when parsing the ACPI PCCT

On 4/30/2018 6:39 PM, Al Stone wrote: > There have been multiple reports of the following error message: > > [0.068293] Error parsing PCC subspaces from PCCT > > This error message is not correct. In multiple cases examined, the PCCT > (Platform Communications Channel Table) concerned is

Re: [PATCH v4 3/3] mailbox: ACPI: erroneous error message when parsing the ACPI, PCCT

On 5/17/2018 4:24 AM, Rafael J. Wysocki wrote: > On Thu, May 17, 2018 at 12:01 AM, Al Stone wrote: >> There have been multiple reports of the following error message: >> >> [0.068293] Error parsing PCC subspaces from PCCT >> >> This error message is not correct. In multiple cases examined,

Re: [PATCH] mailbox: pcc: Fix crash when request PCC channel 0

On 7/24/2017 2:32 PM, Rafael J. Wysocki wrote: > On Friday, July 21, 2017 03:09:29 PM Hoan Tran wrote: >> When PCCT is not available, kernel crashes as below when requests PCC >> channel 0. This patch fixes this issue. >> >> [0.920454] PCCT header not found. >> ... >> [8.031309] Unable

Re: [PATCH v4 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

On 10/3/2017 5:01 AM, George Cherian wrote: > Hi Prakash, > > On 09/29/2017 04:49 AM, Prakash, Prashanth wrote: >> Hi George, >> >> On 9/19/2017 11:24 PM, George Cherian wrote: >>> Based on ACPI 6.2 Section 8.4.7.1.9 If the PCC register space is used, >&

Re: [PATCHv2 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

Hi George, On 7/21/2017 1:43 AM, George Cherian wrote: > Based on ACPI 6.2 Section 8.4.7.1.9 If the PCC register space is used, > all PCC registers, for all processors in the same performance > domain (as defined by _PSD), must be defined to be in the same subspace. > Based on Section 14.1 of

Re: [PATCH v4 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

Hi George, On 9/19/2017 11:24 PM, George Cherian wrote: > Based on ACPI 6.2 Section 8.4.7.1.9 If the PCC register space is used, > all PCC registers, for all processors in the same performance > domain (as defined by _PSD), must be defined to be in the same subspace. > Based on Section 14.1 of

Re: [PATCH v5 1/2] mailbox: PCC: Move the MAX_PCC_SUBSPACES definition to header file

On 10/11/2017 2:54 AM, George Cherian wrote: > Move the MAX_PCC_SUBSPACES definition to acpi/pcc.h file. In preparation to > add subspace id support for cppc_acpi driver. > > Signed-off-by: George Cherian Reviewed-by: Prashanth Prakash -- Thanks, Prashanth

Re: [PATCH v5 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

On 10/11/2017 2:54 AM, George Cherian wrote: > Based on ACPI 6.2 Section 8.4.7.1.9 If the PCC register space is used, > all PCC registers, for all processors in the same performance > domain (as defined by _PSD), must be defined to be in the same subspace. > Based on Section 14.1 of ACPI

Re: [PATCH 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

Hi George, On 6/13/2017 8:17 AM, George Cherian wrote: > Based on ACPI 6.2 Section 8.4.7.1.9 If the PCC register space is used, > all PCC registers, for all processors in the same performance > domain (as defined by _PSD), must be defined to be in the same subspace. > Based on Section 14.1 of

Re: [PATCH 0/2] Make cppc acpi driver aware of pcc subspace ids

On 6/28/2017 3:20 PM, Rafael J. Wysocki wrote: > On Tuesday, June 13, 2017 02:17:09 PM George Cherian wrote: >> The current cppc acpi driver works with only one pcc subspace id. >> It maintains and registers only one pcc channel even if the acpi table has >> different pcc subspace ids. >> >> As

Re: [PATCH v3] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

Hi George, On 7/9/2018 4:10 AM, George Cherian wrote: > Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance > feedback via set of performance counters. To determine the actual > performance level delivered over time, OSPM may read a set of > performance counters from the

Re: [PATCH v3] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

On 7/9/2018 11:42 PM, George Cherian wrote: > Hi Prakash, > > > On 07/09/2018 10:12 PM, Prakash, Prashanth wrote: >> >> Hi George, >> >> >> On 7/9/2018 4:10 AM, George Cherian wrote: >>> Per Section 8.4.7.1.3 of ACPI 6.2, The platform provi

Re: [PATCH v2] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

Hi George, On 6/20/2018 3:17 AM, George Cherian wrote: > Hi Prakash, > > Thanks for the review. > > On 06/19/2018 01:51 AM, Prakash, Prashanth wrote: >> External Email >> >> Hi George, >> >> On 6/15/2018 4:03 AM, George Cherian wrote: >>> Pe

Re: [PATCH] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

Hi George, On 5/22/2018 5:42 AM, George Cherian wrote: > Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance > feedback via set of performance counters. To determine the actual > performance level delivered over time, OSPM may read a set of > performance counters from the

Re: [PATCH] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

On 5/25/2018 12:27 AM, George Cherian wrote: > Hi Prashanth, > > On 05/25/2018 12:55 AM, Prakash, Prashanth wrote: >> Hi George, >> >> On 5/22/2018 5:42 AM, George Cherian wrote: >>> Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance >>

Re: [PATCH v2] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

Hi George, On 6/15/2018 4:03 AM, George Cherian wrote: > Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance > feedback via set of performance counters. To determine the actual > performance level delivered over time, OSPM may read a set of > performance counters from the

Re: [PATCH] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

On 5/28/2018 1:09 AM, George Cherian wrote: > Hi Prashanth, > > On 05/26/2018 02:30 AM, Prakash, Prashanth wrote: >> >> On 5/25/2018 12:27 AM, George Cherian wrote: >>> Hi Prashanth, >>> >>> On 05/25/2018 12:55 AM, Prakash, Prashanth wrote: >&g

Re: [PATCH v4] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

Hi George, This version looks good. Thanks! On 7/12/2018 12:07 AM, George Cherian wrote: > Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance > feedback via set of performance counters. To determine the actual > performance level delivered over time, OSPM may read a set of >

Re: [PATCH] ACPI/CPC: Don't try to clean up uninitialized CPC data

Hi Boris, On 12/16/2016 11:35 AM, Boris Ostrovsky wrote: > If acpi_cppc_processor_probe() had not executed successfully (for > example, if _CPC object was not found) then cpc_desc_ptr for that > processor will be invalid. > > Signed-off-by: Boris Ostrovsky > --- > drivers/acpi/cppc_acpi.c | 2

Re: [PATCH] cpufreq: CPPC: Correct desired_perf calculation

Hi Hoan, On 10/11/2016 3:12 PM, Hoan Tran wrote: > The desired_perf is an abstract performance number. Its value should > be in the range of [lowest perf, highest perf] of CPPC. > The correct calculation is > desired_perf = freq * cppc_highest_perf / cppc_dmi_max_khz > > Signed-off-by: Hoan

Re: [PATCH v2] cpufreq: CPPC: Correct desired_perf calculation

On 10/13/2016 11:33 AM, Hoan Tran wrote: > The desired_perf is an abstract performance number. Its value should > be in the range of [lowest perf, highest perf] of CPPC. > The correct calculation is > desired_perf = freq * cppc_highest_perf / cppc_dmi_max_khz > > And cppc_cpufreq_set_target()

Re: [PATCH] mailbox: PCC: Fix lockdep warning when request PCC channel

Hi Hoan, On 10/14/2016 4:52 PM, Hoan Tran wrote: > This patch fixes the lockdep warning below > > [7.229767] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) > [7.229776] [ cut here ] > [7.229787] WARNING: CPU: 1 PID: 1 at >

Re: [PATCH v4] mailbox: PCC: Fix lockdep warning when request PCC channel

Hi Hoan, On 11/14/2016 12:19 PM, Hoan Tran wrote: > This patch fixes the lockdep warning below > > [7.229767] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) > [7.229776] [ cut here ] > [7.229787] WARNING: CPU: 1 PID: 1 at >

Re: [PATCH v3] mailbox: PCC: Fix lockdep warning when request PCC channel

HI Hoan, On 11/9/2016 11:39 PM, Hoan Tran wrote: > Hi All, > > On Thu, Oct 27, 2016 at 3:34 PM, Hoan Tran wrote: >> This patch fixes the lockdep warning below >> >> [7.229767] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) >> [7.229776] [ cut here ] >> [

Re: [PATCH] ACPI: CPPC: Support PCC with interrupt flag

Hi Hoan, On 8/30/2016 12:20 PM, Hoan Tran wrote: > On Thu, Jul 21, 2016 at 2:07 PM, Hoan Tran wrote: >> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone() >> function to notify the mailbox framework about TX completion. >> >> Signed-off-by: Hoan Tran >> --- >> This patch

Re: [PATCH v2] mailbox: PCC: Fix lockdep warning when request PCC channel

Hi Hoan, On 10/18/2016 1:00 AM, Hoan Tran wrote: > This patch fixes the lockdep warning below > > [7.229767] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) > [7.229776] [ cut here ] > [7.229787] WARNING: CPU: 1 PID: 1 at >

Re: [PATCH 0/2] Make cppc acpi driver aware of pcc subspace ids

Hi George, On 3/31/2017 12:24 AM, George Cherian wrote: > The current cppc acpi driver works with only one pcc subspace id. > It maintains and registers only one pcc channel even if the acpi table has > different pcc subspace ids. The series tries to address the same by making > cppc acpi

Re: [PATCH v4 4/5] arm64: add support for ACPI Low Power Idle(LPI)

Hi Sudeep, On 4/19/2016 6:30 AM, Sudeep Holla wrote: > +struct acpi_processor_lpi *lpi; > +int acpi_processor_ffh_lpi_enter(struct acpi_processor_lpi *lpi, int idx) > +{ > + int ret; > + > + if (!idx) { > + cpu_do_idle(); > + return idx; > + } > + > + /*

Re: [PATCH v5 2/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states

Hi Sudeep, On 5/11/2016 9:37 AM, Sudeep Holla wrote: > + > +static int acpi_processor_get_lpi_info(struct acpi_processor *pr) > +{ > + int ret, i; > + struct acpi_lpi_states_array *info; > + struct acpi_device *d = NULL; > + acpi_handle handle = pr->handle, pr_ahandle; > +

Re: [PATCH v5 2/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states

On 5/18/2016 11:37 AM, Sudeep Holla wrote: > > > On 17/05/16 18:46, Prakash, Prashanth wrote: >> Hi Sudeep, >> >> On 5/11/2016 9:37 AM, Sudeep Holla wrote: >>> + >>> +static int acpi_processor_get_lpi_info(struct acpi_processor *pr

Re: [PATCH v2 5/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states

Hi Sudeep, >> +static void combine_lpi_states(struct acpi_processor_lpi *l_lpi, >> + struct acpi_processor_lpi *p_lpi, >> + struct acpi_processor_lpi *c_lpi) >> +{ >> + c_lpi->min_residency = max(l_lpi->min_residency, >>

Re: [PATCH v3 0/5] ACPI / processor_idle: Add ACPI v6.0 LPI support

Reviewed the patch-set and tested it on an ARM platform over the last couple of days without any issues, so Tested-by: Prashanth Prakash Thanks, Prashanth On 12/2/2015 7:10 AM, Sudeep Holla wrote: > ACPI 6.0 introduced LPI(Low Power Idle) states that provides an alternate > method to describe

Re: [PATCH v2 5/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states

Hi Sudeep, On 10/27/2015 8:09 AM, Sudeep Holla wrote: > Hi Prashanth, > > On 27/10/15 00:21, Prakash, Prashanth wrote: >> Hi Sudeep, >> >> While testing with these patches everything looked fine except that we >> are flattening all the LPI >> states even if

Re: [PATCH] ACPI: CPPC: Return error if _CPC is invalid on a CPU

Hi Hoan, On 6/17/2016 4:16 PM, Hoan Tran wrote: > Based on 8.4.7.1 section of ACPI 6.1 specification, if the platform > supports CPPC, the _CPC object must exist under all processor objects. > If cpc_desc_ptr pointer is invalid on any CPUs, acpi_get_psd_map() > should return error and CPPC

Re: [PATCH v2] mailbox: pcc: Add PCC request and free channel declarations

Hi Rafael, On 6/22/2016 6:49 PM, Rafael J. Wysocki wrote: > On Thursday, June 16, 2016 02:09:38 PM Hoan Tran wrote: >> Exports pcc_mbox_request_channel() and pcc_mbox_free_channel() >> declarations into a pcc.h header file. >> >> v2 >> * Introduce pcc.h header file for pcc client methods >> >>

Re: [PATCH v4] Force cppc_cpufreq to report values in KHz to fix user space reporting

On 7/14/2016 10:15 AM, Al Stone wrote: > On 07/14/2016 04:03 AM, Alexey Klimov wrote: >> Hi Al, >> >> On Tue, Jul 12, 2016 at 11:16:11AM -0600, Al Stone wrote: >>> When CPPC is being used by ACPI on arm64, user space tools such as >>> cpupower report CPU frequency values from sysfs that are

Re: [PATCH v4] Force cppc_cpufreq to report values in KHz to fix user space reporting

Hi Al, On 7/14/2016 11:57 AM, Al Stone wrote: > On 07/14/2016 11:39 AM, Prakash, Prashanth wrote: >> >> On 7/14/2016 10:15 AM, Al Stone wrote: >>> On 07/14/2016 04:03 AM, Alexey Klimov wrote: >>>> Hi Al, >>>> >>>> On Tue, Jul 1

Re: [PATCH] mailbox: pcc: Add PCC request and free channel declarations

Hi Hoan, On 6/14/2016 5:12 PM, Hoan Tran wrote: > As PCC will be used by other clients not only CPPC. > This change exports pcc_mbox_request_channel() and pcc_mbox_free_channel() > declarations > > Signed-off-by: Hoan Tran > --- > include/acpi/cppc_acpi.h | 4 >

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

On 6/9/2016 4:43 PM, Hoan Tran wrote: > Hi Prashanth, > > On Thu, Jun 9, 2016 at 3:25 PM, Prakash, Prashanth > wrote: >> >> On 6/9/2016 2:47 PM, Hoan Tran wrote: >>> Hi Ashwin and Prashanth, >>> >>> On Wed, Jun 8, 2016 at 5:41 PM, Hoan Tran w

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

On 6/8/2016 10:24 AM, Hoan Tran wrote: > Hi Ashwin, > > On Wed, Jun 8, 2016 at 5:18 AM, Ashwin Chaugule > wrote: >> + Prashanth (Can you please have a look as well?) >> >> On 31 May 2016 at 15:35, Hoan Tran wrote: >>> Hi Ashwin, >> Hi, >> >> Sorry about the delay. I'm in the middle of

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

On 6/9/2016 2:47 PM, Hoan Tran wrote: > Hi Ashwin and Prashanth, > > On Wed, Jun 8, 2016 at 5:41 PM, Hoan Tran wrote: >> Hi Prashanth, >> >> >> On Wed, Jun 8, 2016 at 5:32 PM, Prakash, Prashanth >> wrote: >>> >>> On 6/8/2016 10:24 AM,