Re: [PATCH 2/2] drm: tegra: Add HDMI support

2012-11-09 Thread Rafał Miłecki
2012/11/9 Thierry Reding thierry.red...@avionic-design.de: +/* all fields little endian */ +struct hdmi_audio_infoframe { + /* PB0 */ + u8 csum; + + /* PB1 */ + unsigned cc:3; /* channel count */ + unsigned res1:1; + unsigned ct:4; /* coding type */ +

Re: [PATCH 2/2] drm: tegra: Add HDMI support

2012-11-09 Thread Rafał Miłecki
2012/11/9 Christian König deathsim...@vodafone.de: On 09.11.2012 16:45, Rafał Miłecki wrote: I was told it won't work on different endian devices. See [RFC][PATCH] drm/radeon/hdmi: define struct for AVI infoframe http://lists.freedesktop.org/archives/dri-devel/2012-May/022544.html Yeah

Re: pull request: wireless 2013-04-08

2013-04-08 Thread Rafał Miłecki
2013/4/8 John W. Linville linvi...@tuxdriver.com: Please consider this set of fixes for the 3.9 stream... (...) Please let me know if there are problems! John, could you take a look at what has happened to the [PATCH V2] ssb: implement spurious tone avoidance ? Message-Id:

Re: [patch v3] b43: N-PHY: fix gain in b43_nphy_get_gain_ctl_workaround_ent()

2013-01-20 Thread Rafał Miłecki
2013/1/20 Dan Carpenter dan.carpen...@oracle.com: There were no break statements in this switch statement so everything used the default settings. Per Walter Harms's suggestion, I've replaced the switch statement and done a little cleanup. Signed-off-by: Dan Carpenter

Re: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS

2013-11-18 Thread Rafał Miłecki
2013/11/17 Arend van Spriel ar...@broadcom.com: On 11/17/13 14:37, Borislav Petkov wrote: From: Borislav Petkovb...@suse.de When building randconfigs with CONFIG_BCMA_DRIVER_GPIO=y, I get drivers/built-in.o: In function `brcms_led_unregister': (.text+0x351aca): undefined reference to

Re: [PATCH] drivers/mtd/devices/bcm47xxsflash.c: correct argument to kfree

2013-06-08 Thread Rafał Miłecki
2013/6/8 Julia Lawall julia.law...@lip6.fr: From: Julia Lawall julia.law...@lip6.fr The argument to kfree should not be the address of a structure field. The argument is adjusted to correspond to what is found in the subsequent remove function. This was already addressed in [PATCH RESEND

Re: [PATCH RESEND 1/2] mtd: bcm47: convert kzalloc to avoid invalid access

2013-05-31 Thread Rafał Miłecki
2013/5/30 Libo Chen clbchenlibo.c...@huawei.com: mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. So I use devm_kazlloc instead of kazlloc to avoid it. I think you should use mtd: bcm47xxsflash: prefix for both patches, but Artem or David may want to

Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-21 Thread Rafał Miłecki
2013/5/22 Libo Chen clbchenlibo.c...@huawei.com: mtd is just member of bcm47xxsflash, so we should free bcm47xxsflash not its member. Thanks! -- Rafał -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH RESEND] mtd: fix kfree bcm47xxsflash

2013-05-28 Thread Rafał Miłecki
2013/5/28 Libo Chen clbchenlibo.c...@huawei.com: ping... It takes a lot of time for someone to pick up mtd patches, just be patient ;) -- Rafał -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/4] ALSA: hda - hdmi: Add ATI/AMD multi-channel audio support

2013-10-30 Thread Rafał Miłecki
2013/10/1 Anssi Hannula anssi.hann...@iki.fi: ATI/AMD codecs do not support all the standard HDA HDMI/DP functions, instead various vendor-specific verbs are provided. I've just tried my HD6970M (BARTS, DCE5) in my Samsung NP700G7A-S01PL. cat /proc/asound/card1/eld#0.0 monitor_present 1

Re: [PATCH 1/4] ALSA: hda - hdmi: Add ATI/AMD multi-channel audio support

2013-10-31 Thread Rafał Miłecki
2013/10/30 Anssi Hannula anssi.hann...@iki.fi: BTW, there is a newer version (which was actually applied) of this patchset in alsa-devel@, seems you were missing from CC on that one. I didn't try that updated version yet, but I'm afraid I discovered some problem. I've switched from my Denon

Re: [PATCH 1/4] ALSA: hda - hdmi: Add ATI/AMD multi-channel audio support

2013-10-31 Thread Rafał Miłecki
2013/10/31 Anssi Hannula anssi.hann...@iki.fi: But I can hear sound for rear right and rear left only :( Is there anything more I can provide to help resolve this? Do you have any idea how we can resolve this? According to the below the receiver has separate PCM SADs for 2-channel and

Re: [PATCH 1/4] ALSA: hda - hdmi: Add ATI/AMD multi-channel audio support

2013-10-31 Thread Rafał Miłecki
2013/11/1 Anssi Hannula anssi.hann...@iki.fi: Just to check, is the display mode 720p50 or higher (as per HDMI spec 7.3.3)? Though I guess too small mode would cause something else, not this... I'm using 1080p all the time. Do you think that HDMI_AUDIO_PACKETS_PER_LINE may have anything to do

Re: [PATCH 1/4] ALSA: hda - hdmi: Add ATI/AMD multi-channel audio support

2013-11-01 Thread Rafał Miłecki
2013/11/1 Anssi Hannula anssi.hann...@iki.fi: Both are working for me. I've tested it using 2 movies: 1) English TrueHD.5.1 @ 1417 kbps 2) Audio Codec: DTSHD-MA Bitrate..: 3718 kbps kHz/bit..: 24-bit Channels.: 5.1 Language.:

Re: [PATCH 1/4] ALSA: hda - hdmi: Add ATI/AMD multi-channel audio support

2013-11-01 Thread Rafał Miłecki
2013/11/1 Anssi Hannula anssi.hann...@iki.fi: Strange. One other thing to check (in addition to trying fglrx) would be to try 192kHz 8ch audio with a different (non-ATI/AMD) card altogether, to see if this is a receiver issue. What about this: 01:00.0 VGA compatible controller [0300]: NVIDIA

Re: [PATCH 1/4] ALSA: hda - hdmi: Add ATI/AMD multi-channel audio support

2013-11-01 Thread Rafał Miłecki
2013/11/1 Rafał Miłecki zaj...@gmail.com: 2013/11/1 Anssi Hannula anssi.hann...@iki.fi: Strange. One other thing to check (in addition to trying fglrx) would be to try 192kHz 8ch audio with a different (non-ATI/AMD) card altogether, to see if this is a receiver issue. What about this: 01

Re: [PATCH 06/11] bcma: convert bus code to use dev_groups

2013-10-10 Thread Rafał Miłecki
2013/10/9 John W. Linville linvi...@tuxdriver.com: On Sun, Oct 06, 2013 at 11:55:45PM -0700, Greg Kroah-Hartman wrote: The dev_attrs field of struct bus_type is going away soon, dev_groups should be used instead. This converts the bcma bus code to use the correct field. Cc: Rafał Miłecki

Re: pull request: wireless-next 2014-06-06

2014-06-06 Thread Rafał Miłecki
Hi John, On 6 June 2014 18:05, John W. Linville linvi...@tuxdriver.com wrote: Please accept this batch of fixes intended for the 3.16 stream. I'll be very thankful if you include my fix in the next pull request: [FIX for 3.16][PATCH] b43: disable 5 GHz on G-PHY It fixes a regression I

Re: Bisected 3.9 regression: Corrupted low memory (x86, mm: Move reserving low memory later in initialization)

2014-05-21 Thread Rafał Miłecki
On 16 May 2014 07:29, Rafał Miłecki zaj...@gmail.com wrote: Sorry for the late report, this bug appears on my old notebook I don't commonly use. Anyway, I've noticed following problem when using 3.15-rc1: Corrupted low memory at 8800be98 (be98 phys) = b02a0004 Ping

Re: Bisected 3.9 regression: Corrupted low memory (x86, mm: Move reserving low memory later in initialization)

2014-05-21 Thread Rafał Miłecki
On 21 May 2014 19:34, H. Peter Anvin h...@zytor.com wrote: On 05/21/2014 06:31 AM, Rafał Miłecki wrote: On 16 May 2014 07:29, Rafał Miłecki zaj...@gmail.com wrote: Sorry for the late report, this bug appears on my old notebook I don't commonly use. Anyway, I've noticed following problem when

Re: Linux 3.14-rc1 is out

2014-02-02 Thread Rafał Miłecki
Is that OK/wanted to note a possibly wide regression as Reply-To in the announce thread? If your USB 3.0 stopped working with 3.14-rc1, please note it's already tracked regression reported in: xhci regression since xhci: replace xhci_write_64() with writeq() - devices not detected

Re: Oops in acpi_gpiochip_add on MacBookPro with Linux v3.14-12042-g69cd9eba3886

2014-04-10 Thread Rafał Miłecki
2014-04-09 23:09 GMT+02:00 Josh Boyer jwbo...@fedoraproject.org: With Linux v3.14-12042-g69cd9eba3886 I get an oops from the bcma module on the MacBookPro 10,2 I have here. This works fine with Linux v3.14-7333-g59ecc26004e7. There have been no changes between those two versions to bcma

Re: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-16 Thread Rafał Miłecki
On 14 October 2014 03:26, Bean Huo 霍斌斌 (beanhuo) bean...@micron.com wrote: This patch used to modify the method of spi_nor_scan overwrite platform ID point. If type of platform data match with the name of spi_nor_ids set, and JEDEC ID also match with INFO ID of spi_nor_ids set,spi device ID

Re: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-16 Thread Rafał Miłecki
On 16 October 2014 10:00, Bean Huo 霍斌斌 (beanhuo) bean...@micron.com wrote: There are a lot of changes happening/requested around this code. I also proposed some patch touching this code, see https://patchwork.ozlabs.org/patch/377917/ Right now there is a slow ongoing work on fixing some m25p80

Re: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-16 Thread Rafał Miłecki
On 16 October 2014 10:41, bpqw b...@micron.com wrote: By the way ,I still don't understand why you specify id NULL in you patch: I guess I needed it for my Broadcom SPI driver, see: mtd: bcm53xxspiflash: new driver for SPI flahes on Broadcom ARM SoCs https://patchwork.ozlabs.org/patch/381902/

Re: [PATCH] mtd: spi-nor: Add support for SST spi flash

2014-10-21 Thread Rafał Miłecki
On 21 October 2014 13:37, Michal Simek michal.si...@xilinx.com wrote: From: Harini Katakam harini.kata...@xilinx.com Add sst25wf080 to the spi-nor device id table. I guess commit message could include some details. We already support plenty of SST flashes without this patch, don't we? -- To

Re: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-22 Thread Rafał Miłecki
On 16 October 2014 02:52, bpqw b...@micron.com wrote: For example: const struct spi_device_id spi_nor_ids[] = { .. .. .. { n25q064, INFO(0x20ba17, 0, 64 * 1024, 128, 0) }, { n25q128a11, INFO(0x20bb18, 0, 64 * 1024, 256, 0) },//former right platform

Re: [PATCH] bcma: Add dependency on OF_ADDRESS

2014-10-09 Thread Rafał Miłecki
On 9 October 2014 18:41, Guenter Roeck li...@roeck-us.net wrote: Commit 2101e533f41a (bcma: register bcma as device tree driver) introduces a hard dependency on OF_ADDRESS into the bcma driver. OF_ADDRESS is specifically disabled for the sparc architecture. This results in the following error

Re: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-10-03 Thread Rafał Miłecki
On 3 October 2014 17:27, Artem Bityutskiy dedeki...@gmail.com wrote: Yes, I guess a single patch is indeed OK. I have few nit-picks, though. On Tue, 2014-09-30 at 18:13 +0300, Tanya Brokhman wrote: - ubi_err('ubi_io_read_ec_hdr()' returned unknown code %d, err); +

Re: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-10-03 Thread Rafał Miłecki
On 3 October 2014 18:19, Artem Bityutskiy dedeki...@gmail.com wrote: On Fri, 2014-10-03 at 17:50 +0200, Rafał Miłecki wrote: On 3 October 2014 17:27, Artem Bityutskiy dedeki...@gmail.com wrote: Yes, I guess a single patch is indeed OK. I have few nit-picks, though. On Tue, 2014-09-30 at 18

Re: [PATCH] spi: bcm53xx: add BCMA dependency

2014-09-30 Thread Rafał Miłecki
On 30 September 2014 14:09, Arnd Bergmann a...@arndb.de wrote: The BCMA bus framework can be disabled on bcm53xx, which leads to a link error when building the SPI driver: You missed this one:

Re: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-27 Thread Rafał Miłecki
On 27 October 2014 09:44, bpqw b...@micron.com wrote: Maybe this patch is not very reasonable.But for fix this case,I will develop a new patch that is just used to add extended ID for micron spi nor in the spi_nor_ids[]. Great, I hope it will work on top of the [PATCH] mtd: spi-nor: prefer

Re: [PATCH] Drivers: bcma: Fix three coding style issues, more than 80 characters per line.

2014-12-23 Thread Rafał Miłecki
On 24 December 2014 at 00:55, Oscar Forner Martinez oscar.forner.marti...@gmail.com wrote: Three lines with more than 80 characters per line have been split in several lines. Signed-off-by: Oscar Forner Martinez oscar.forner.marti...@gmail.com --- drivers/bcma/driver_chipcommon.c | 10

Re: [PATCH] Drivers: bcma: Fix three coding style issues, more than 80 characters per line.

2014-12-23 Thread Rafał Miłecki
On 24 December 2014 at 00:55, Oscar Forner Martinez oscar.forner.marti...@gmail.com wrote: Three lines with more than 80 characters per line have been split in several lines. Since you will need V2 anyway, you may also drop this Drivers: prefix :) -- To unsubscribe from this list: send the

Re: [PATCH] Drivers: bcma: Fix three coding style issues, more than 80 characters per line.

2014-12-26 Thread Rafał Miłecki
On 24 December 2014 at 08:20, Kalle Valo kv...@codeaurora.org wrote: Oscar Forner Martinez oscar.forner.marti...@gmail.com writes: Three lines with more than 80 characters per line have been split in several lines. Signed-off-by: Oscar Forner Martinez oscar.forner.marti...@gmail.com ---

Re: [PATCH v2] bcma: Fix three coding style issues, more than 80 characters per line

2014-12-26 Thread Rafał Miłecki
On 26 December 2014 at 19:33, Oscar Forner Martinez oscar.forner.marti...@gmail.com wrote: - /* 4706 CC and PMU watchdogs are clocked at 1/4 of ALP clock */ + /* 4706 CC and PMU watchdogs are clocked +* at 1/4 of ALP clock +

Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line

2014-12-27 Thread Rafał Miłecki
On 27 December 2014 at 20:24, Oscar Forner Martinez oscar.forner.marti...@gmail.com wrote: Three lines with more than 80 characters per line have been split in several lines. Thanks for the next version :) 1) You missed version number. Something like git format-patch --subject-prefix=PATCH V3

Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line

2014-12-27 Thread Rafał Miłecki
On 27 December 2014 at 23:04, Oscar Forner Martinez oscar.forner.marti...@gmail.com wrote: 2014-12-27 21:14 GMT+00:00 Oscar Forner Martinez oscar.forner.marti...@gmail.com: 2014-12-27 20:19 GMT+00:00 Rafał Miłecki zaj...@gmail.com: On 27 December 2014 at 20:24, Oscar Forner Martinez

Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line

2014-12-27 Thread Rafał Miłecki
On 27 December 2014 at 20:24, Oscar Forner Martinez oscar.forner.marti...@gmail.com wrote: Three lines with more than 80 characters per line have been split in several lines. Signed-off-by: Oscar Forner Martinez oscar.forner.marti...@gmail.com Acked-by: Rafał Miłecki zaj...@gmail.com Kalle

Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line

2014-12-28 Thread Rafał Miłecki
On 28 December 2014 at 06:50, Sedat Dilek sedat.di...@gmail.com wrote: On Sun, Dec 28, 2014 at 12:44 AM, Rafał Miłecki zaj...@gmail.com wrote: On 27 December 2014 at 20:24, Oscar Forner Martinez oscar.forner.marti...@gmail.com wrote: Three lines with more than 80 characters per line have been

Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line

2014-12-28 Thread Rafał Miłecki
On 28 December 2014 at 10:12, Sedat Dilek sedat.di...@gmail.com wrote: On Sun, Dec 28, 2014 at 9:53 AM, Rafał Miłecki zaj...@gmail.com wrote: On 28 December 2014 at 06:50, Sedat Dilek sedat.di...@gmail.com wrote: On Sun, Dec 28, 2014 at 12:44 AM, Rafał Miłecki zaj...@gmail.com wrote: On 27

Re: [PATCH V3] MIPS: BCM47XX: Move NVRAM driver to the drivers/soc/

2014-11-27 Thread Rafał Miłecki
On 27 November 2014 at 20:56, Paul Walmsley p...@pwsan.com wrote: On Tue, 25 Nov 2014, Rafał Miłecki wrote: I understand your arguments against drivers/soc/, but on the other hand I have no idea where else this driver could go. After looking around the tree to find out where similar code

Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-28 Thread Rafał Miłecki
On 28 November 2014 at 23:16, Nicholas Krause xerofo...@gmail.com wrote: Adds needed mutex lockng of wl-mutex in order to prevent issues with separate threads executing on the b43_update_templates function call in the function, b43_op_beacon_set_time at the same time. For all kind of

Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-29 Thread Rafał Miłecki
On 29 November 2014 at 04:32, nick xerofo...@gmail.com wrote: I don't have hardware for this driver on me, so I didn't test it. However this seems to be correct from my reading of the code around this function and other locking related to this driver. So do you say it's not executed in an

Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

2014-11-29 Thread Rafał Miłecki
On 29 November 2014 at 09:56, Michael Büsch m...@bues.ch wrote: On Fri, 28 Nov 2014 22:32:30 -0500 nick xerofo...@gmail.com wrote: I don't have hardware for this driver on me, so I didn't test it. However this seems to be correct from my reading of the code around this function and other

Re: [PATCH V3] MIPS: BCM47XX: Move NVRAM driver to the drivers/soc/

2014-12-03 Thread Rafał Miłecki
On 4 December 2014 at 07:43, Paul Walmsley p...@pwsan.com wrote: Hello Rafał, On Fri, 28 Nov 2014, Paul Walmsley wrote: On Thu, 27 Nov 2014, Rafał Miłecki wrote: I'm pretty sure you look at some old version of arch/bcm47xx/nvram.c. I wouldn't dare to move such a MIPS-focused driver

Re: [PATCH 2/2] mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller.

2014-12-05 Thread Rafał Miłecki
On 5 December 2014 at 20:35, Graham Moore grmo...@opensource.altera.com wrote: + if (of_modalias_node(np, modalias, sizeof(modalias)) 0) + goto probe_failed; + + ret = spi_nor_scan(nor, modalias, SPI_NOR_QUAD); + if (ret) +

Re: [V6 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-12-08 Thread Rafał Miłecki
On 8 December 2014 at 09:50, Bean Huo 霍斌斌 (beanhuo) bean...@micron.com wrote: This patch is based on the latest l2-mtd,I don't know if can pass? I have one question is that about following code. I have added our Mciron quad flag into spi_nor_ids[] table,but line over 80 characters, If I

Re: [PATCH] drivers:net:wireless: Add proper locking for the function, b43_op_beacon_set_tim in main.c

2015-01-02 Thread Rafał Miłecki
On 2 January 2015 at 10:27, Michael Büsch m...@bues.ch wrote: On Fri, 2 Jan 2015 02:34:01 -0500 Nicholas Krause xerofo...@gmail.com wrote: This adds proper locking for the function, b43_op_beacon_set_tim in main.c by using the mutex lock in the structure pointer wl, as embedded into this

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

2015-01-02 Thread Rafał Miłecki
On 2 January 2015 at 13:05, Rafał Miłecki zaj...@gmail.com wrote: On 1 January 2015 at 16:46, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. This was partially found by using a static code analysis

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

2015-01-02 Thread Rafał Miłecki
On 1 January 2015 at 16:46, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. It seems to be for A-PHY based hardware

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

2015-01-02 Thread Rafał Miłecki
On 2 January 2015 at 18:46, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: 2015-01-02 13:14 GMT+01:00 Sedat Dilek sedat.di...@gmail.com: On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki zaj...@gmail.com wrote: On 2 January 2015 at 13:05, Rafał Miłecki zaj...@gmail.com wrote

Re: [PATCH] m25p80, spi-nor: add SFDP detect method

2015-02-04 Thread Rafał Miłecki
On 4 February 2015 at 16:50, Jim-Ting Kuo jimting...@gmail.com wrote: The serial flash discoverable parameters (SFDP) is needed to spi nor devices for some specific features. I added some sfdp structure and detect method. And I hope the method will be useful in the future. The code have been

Re: [PATCH RESEND] ssb: Fix Sparse error in main

2015-01-28 Thread Rafał Miłecki
On 28 January 2015 at 06:49, Pramod Gurav pramod.gu...@smartplayin.com wrote: This change fixes below sparse error: drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus' was not declared. Should it be static? Seems like it was never used. Looks OK. -- To unsubscribe from this list:

Re: [PATCH] net:wireless:Add proper locking for the function, b43_op_beacon_set_tim in main.c

2015-01-25 Thread Rafał Miłecki
On 25 January 2015 at 08:06, Nicholas Krause xerofo...@gmail.com wrote: Adds proper locking for the function, b43_op_beacon_set_tim in main.c that internally calls b43_update_templates. Due to the function that is being called internally,b43_update_templates needing the mutex lock of the

Re: [PATCH v4] bcma: fix two coding style issues, more than 80 characters per line.

2015-01-09 Thread Rafał Miłecki
On 9 January 2015 at 15:03, Kalle Valo kv...@codeaurora.org wrote: Rafał Miłecki zaj...@gmail.com writes: On 7 January 2015 at 19:39, Kalle Valo kv...@codeaurora.org wrote: Rafał Miłecki zaj...@gmail.com writes: On 7 January 2015 at 18:55, Kalle Valo kv...@codeaurora.org wrote: Oscar Forner

Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function

2015-01-04 Thread Rafał Miłecki
On 3 January 2015 at 13:28, Rickard Strandqvist rickard_strandqv...@spectrumdigital.se wrote: 2015-01-02 22:34 GMT+01:00 Rafał Miłecki zaj...@gmail.com: 1) I gave you Ack for the changes 2) You could drop net: wireless: or better use something Sedat proposed Nice, yes I miss the Ack :) I

Re: [PATCH v4] bcma: fix two coding style issues, more than 80 characters per line.

2015-01-07 Thread Rafał Miłecki
On 7 January 2015 at 19:39, Kalle Valo kv...@codeaurora.org wrote: Rafał Miłecki zaj...@gmail.com writes: On 7 January 2015 at 18:55, Kalle Valo kv...@codeaurora.org wrote: Oscar Forner Martinez oscar.forner.marti...@gmail.com writes: Two lines with more than 80 characters per line have been

Re: [PATCH v4] bcma: fix two coding style issues, more than 80 characters per line.

2015-01-07 Thread Rafał Miłecki
On 7 January 2015 at 18:55, Kalle Valo kv...@codeaurora.org wrote: Oscar Forner Martinez oscar.forner.marti...@gmail.com writes: Two lines with more than 80 characters per line have been split in several lines. Signed-off-by: Oscar Forner Martinez oscar.forner.marti...@gmail.com Thanks,

Re: [PATCH] b43legacy: Remove unused function

2015-01-06 Thread Rafał Miłecki
rickard_strandqv...@spectrumdigital.se Acked-by: Rafał Miłecki zaj...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

2015-03-16 Thread Rafał Miłecki
On 16 March 2015 at 09:16, vn...@altera.com wrote: +static struct flash_device flash_devices[] = { + FLASH_ID(epcq16-nonjedec, 2, 0x15), + FLASH_ID(epcq32-nonjedec, 2, 0x16), + FLASH_ID(epcq64-nonjedec, 2, 0x17), + FLASH_ID(epcq128-nonjedec, 2, 0x18), +

Re: [PATCH] bgmac: ratelimit warning messages

2015-03-06 Thread Rafał Miłecki
On 6 March 2015 at 19:17, Peter Senna Tschudin peter.se...@gmail.com wrote: On my test environment the troughput of a file transfer drops from 4.4Mbps to 116Kbps due the number of repeated warning messages. Adding printk_ratelimit() solves the issue without removing the warning message.

Re: [PATCH 0/3] mtd: nand: add Broadcom NAND controller support

2015-03-08 Thread Rafał Miłecki
On 8 March 2015 at 01:57, Brian Norris computersforpe...@gmail.com wrote: 2. Endianness is a known issue with at least one other platform. On many chips (spanning MIPS LE, MIPS BE, and ARM LE), NAND has been integrated such that data can just be read/programmed in the native endianness through

Re: [PATCH 3/3] mtd: nand: add NAND driver for Broadcom STB NAND controller

2015-03-07 Thread Rafał Miłecki
On 7 March 2015 at 02:18, Brian Norris computersforpe...@gmail.com wrote: This core originated in Set-Top Box chips (BCM7xxx) but is used in a variety of other Broadcom chips, including some BCM63xxx, BCM33xx, and iProc/Cygnus. It's been used only on ARM and MIPS SoCs, so restrict it to those

Re: [PATCH 3/3] mtd: nand: add NAND driver for Broadcom STB NAND controller

2015-03-07 Thread Rafał Miłecki
On 7 March 2015 at 02:18, Brian Norris computersforpe...@gmail.com wrote: + /* NAND register range */ + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + ctrl-nand_base = devm_ioremap_resource(dev, res); + if (!ctrl-nand_base) + return -ENODEV;

Re: [PATCH V2] bgmac: Clean warning messages

2015-03-07 Thread Rafał Miłecki
0xC000 bits. Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com Acked-by: Rafał Miłecki zaj...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] bgmac: Clean warning messages

2015-03-07 Thread Rafał Miłecki
On 7 March 2015 at 11:51, Peter Senna Tschudin peter.se...@gmail.com wrote: On my test environment the throughput of a file transfer drops from 4.4MBps to 116KBps due the number of repeated warning messages. This patch removes the warning messages. This sounds like you're removing these

Re: [PATCH 3/3] mtd: nand: add NAND driver for Broadcom STB NAND controller

2015-03-07 Thread Rafał Miłecki
On 7 March 2015 at 18:39, Rafał Miłecki zaj...@gmail.com wrote: On 7 March 2015 at 02:18, Brian Norris computersforpe...@gmail.com wrote: This core originated in Set-Top Box chips (BCM7xxx) but is used in a variety of other Broadcom chips, including some BCM63xxx, BCM33xx, and iProc/Cygnus

Re: [PATCH 3/3] mtd: nand: add NAND driver for Broadcom STB NAND controller

2015-03-07 Thread Rafał Miłecki
On 7 March 2015 at 02:18, Brian Norris computersforpe...@gmail.com wrote: +static int brcmnand_waitfunc(struct mtd_info *mtd, struct nand_chip *this) +{ + struct nand_chip *chip = mtd-priv; + struct brcmnand_host *host = chip-priv; + struct brcmnand_controller *ctrl =

Re: [PATCH 0/3] mtd: nand: add Broadcom NAND controller support

2015-03-07 Thread Rafał Miłecki
Hi Brian, Thanks for your work on this. It looks amazing, nice piece of code :) On 7 March 2015 at 02:18, Brian Norris computersforpe...@gmail.com wrote: This adds (long in coming) support for the Broadcom BCM7xxx Set-Top Box NAND controller. This controller has been used in a variety of

Re: [PATCH 3/3] mtd: nand: add NAND driver for Broadcom STB NAND controller

2015-03-07 Thread Rafał Miłecki
On 7 March 2015 at 18:39, Rafał Miłecki zaj...@gmail.com wrote: It seems that brcmnand_ctlrdy_irq never fires on my device. Just like controller was never generating any IRQ. I started comparing your driver with OpenWrt's bcm_nand.c (which should be very similar to Broadcom's SDK NAND driver

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-09 Thread Rafał Miłecki
Hi Viet, I'm not too active in mtd subsystem, so I didn't notice your patch earlier. However I would like to share few comments. On 11 February 2015 at 05:53, Viet Nga Dao vn...@altera.com wrote: From: Viet Nga Dao vn...@altera.com Altera EPCQ Controller is a soft IP which enables access to

Re: [PATCH 0/3] mtd: nand: add Broadcom NAND controller support

2015-03-08 Thread Rafał Miłecki
On 8 March 2015 at 01:57, Brian Norris computersforpe...@gmail.com wrote: 3. I was told that there were only 2 or 3 chips that were released with a v6.1 NAND controller, and BCM4708 wasn't one of them. Apparently I was told wrong... I'll have to see if there are any other quirks we should be

Re: FW: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-12 Thread Rafał Miłecki
On 11 March 2015 at 09:41, Viet Nga Dao vn...@altera.com wrote: On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao vn...@altera.com wrote: Ok. I will modify the code the way you suggest. I just realize that the opcode for RDID is handled by hardware in my case, therefore i dont really need to

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-10 Thread Rafał Miłecki
On 10 March 2015 at 07:11, Viet Nga Dao vn...@altera.com wrote: On Mon, Mar 9, 2015 at 2:31 PM, Rafał Miłecki zaj...@gmail.com wrote: On 11 February 2015 at 05:53, Viet Nga Dao vn...@altera.com wrote: /* NOTE: double check command sets and memory organization when you add * more nor chips

Re: [PATCH] bcma: Kconfig: Let it depend on PCI

2015-03-04 Thread Rafał Miłecki
On 4 March 2015 at 17:38, Michael Büsch m...@bues.ch wrote: On Wed, 4 Mar 2015 14:36:10 +0100 Rafał Miłecki zaj...@gmail.com wrote: Any other opinions? I think this is the only way to go. In ssb we always had optional pcicore driver, as far as I remember, so we should have the same in bcma

Re: randconfig build error with next-20150303, in drivers/bcma/driver_pcie2.c

2015-03-04 Thread Rafał Miłecki
On 4 March 2015 at 22:01, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Kalle, On Wed, 04 Mar 2015 16:31:00 +0200 Kalle Valo kv...@codeaurora.org wrote: Jim Davis jim.ep...@gmail.com writes: Building with the attached random configuration file, drivers/bcma/driver_pcie2.c: In

Re: [PATCH] bcma: Kconfig: Let it depend on PCI

2015-03-04 Thread Rafał Miłecki
On 3 March 2015 at 22:16, Chen Gang xili_gchen_5...@hotmail.com wrote: bcma also needs PCI, just like IOMEM and DMA, so let it depend on PCI, or will cause building break for allmodconfig under c6x: CC [M] drivers/bcma/driver_pcie2.o drivers/bcma/driver_pcie2.c: In function

Re: [PATCH] bcma: Kconfig: Let it depend on PCI

2015-03-03 Thread Rafał Miłecki
On 3 March 2015 at 22:16, Chen Gang xili_gchen_5...@hotmail.com wrote: bcma also needs PCI, just like IOMEM and DMA, so let it depend on PCI, or will cause building break for allmodconfig under c6x: CC [M] drivers/bcma/driver_pcie2.o drivers/bcma/driver_pcie2.c: In function

Re: [PATCH] bcma: Kconfig: Let it depend on PCI

2015-03-04 Thread Rafał Miłecki
On 4 March 2015 at 07:19, Rafał Miłecki zaj...@gmail.com wrote: On 3 March 2015 at 22:16, Chen Gang xili_gchen_5...@hotmail.com wrote: bcma also needs PCI, just like IOMEM and DMA, so let it depend on PCI, or will cause building break for allmodconfig under c6x: CC [M] drivers/bcma

Re: [PATCH] bcma: Kconfig: Let it depend on PCI

2015-03-04 Thread Rafał Miłecki
On 4 March 2015 at 13:08, Rafał Miłecki zaj...@gmail.com wrote: On 4 March 2015 at 07:19, Rafał Miłecki zaj...@gmail.com wrote: On 3 March 2015 at 22:16, Chen Gang xili_gchen_5...@hotmail.com wrote: bcma also needs PCI, just like IOMEM and DMA, so let it depend on PCI, or will cause building

Re: [PATCH 1/6] mtd: nand_bbt: drop unnecessary header

2015-04-24 Thread Rafał Miłecki
On 24 April 2015 at 02:36, Peter Pan 潘栋 (peterpandong) peterpand...@micron.com wrote: On 23 April 2015 at 15:47, Rafał Miłecki wrote: On 22 April 2015 at 19:50, Brian Norris computersforpe...@gmail.com wrote: On Thu, Apr 16, 2015 at 02:09:41AM +, Peter Pan 潘栋 (peterpandong) wrote

Re: [PATCH 1/6] mtd: nand_bbt: drop unnecessary header

2015-04-23 Thread Rafał Miłecki
On 16 April 2015 at 04:09, Peter Pan 潘栋 (peterpandong) peterpand...@micron.com wrote: Signed-off-by: Brian Norris computersforpe...@gmail.com Signed-off-by: Peter Pan peterpand...@micron.com I'm curious, what made you picking my e-mail address directly? -- Rafał -- To unsubscribe from this

Re: [PATCH 2/6] mtd: diskonchip: don't call nand_scan_bbt() directly

2015-04-23 Thread Rafał Miłecki
On 23 April 2015 at 02:30, Peter Pan 潘栋 (peterpandong) peterpand...@micron.com wrote: On Thu, Apr 23, 2015 at 01:51:27PM +, Brian Norris wrote: On Thu, Apr 16, 2015 at 02:11:24AM +, Peter Pan 潘栋 (peterpandong) wrote: The diskonchip driver almost uses the default nand_base hooks

Re: [PATCH 1/6] mtd: nand_bbt: drop unnecessary header

2015-04-23 Thread Rafał Miłecki
On 22 April 2015 at 19:50, Brian Norris computersforpe...@gmail.com wrote: On Thu, Apr 16, 2015 at 02:09:41AM +, Peter Pan 潘栋 (peterpandong) wrote: Signed-off-by: Brian Norris computersforpe...@gmail.com Signed-off-by: Peter Pan peterpand...@micron.com Why are you just resending my

Re: [PATCH 3/3] MTD: spi-nor: add flag to not use sector erase.

2015-05-01 Thread Rafał Miłecki
On 30 April 2015 at 23:13, Michal Suchanek hramr...@gmail.com wrote: The sector size of the flash memory is unclear from datasheet or may possibly vary between chips so add a flag to always use 4k blocks. Currently 4k blocks are always used when possible but in the future somebody might want

Re: [PATCH] Documentation: dt: mtd: replace nor-jedec binding with jedec,spi-nor

2015-05-19 Thread Rafał Miłecki
On 19 May 2015 at 03:34, Brian Norris computersforpe...@gmail.com wrote: So how about the following patch? It seems like we'll need to be able to ignore useless 'modalias' values in cases like this: // modalias = shinynewdevice compatible = myvendor,shinynewdevice,

Re: [PATCH] Documentation: dt: mtd: replace nor-jedec binding with jedec,spi-nor

2015-05-15 Thread Rafał Miłecki
On 15 May 2015 at 22:02, Brian Norris computersforpe...@gmail.com wrote: Thanks all. I see that I've gotten an ack from Mark as well (thanks!), so I'll apply this (plus the fixup I just sent) to linux-mtd.git and probably pullreq it before the weekend is over. I'll assume Rafal and Geert will

Re: [RFC PATCH] bgmac: Fix build error seen if BCM47XX is not configured

2015-04-15 Thread Rafał Miłecki
: implicit declaration of function 'bcm47xx_nvram_getenv' Fixes: fc300dc3733f (bgmac: allow enabling on ARCH_BCM_5301X) Cc: Rafał Miłecki zaj...@gmail.com Signed-off-by: Guenter Roeck li...@roeck-us.net --- Seen in today's upstream kernel. I don't like this fix too much (I think

Re: [PATCH 3/4] spi: bcm-mspi: Make BCMA optional to support non-BCMA chips

2015-04-06 Thread Rafał Miłecki
On 3 April 2015 at 19:52, Florian Fainelli f.faine...@gmail.com wrote: On 03/04/15 06:38, Andy Shevchenko wrote: On Thu, Apr 2, 2015 at 10:23 PM, Jonathan Richardson jonat...@broadcom.com wrote: The Broadcom MSPI controller is used on various chips. The driver only supported BCM53xx chips

Re: [PATCH 3/4] spi: bcm-mspi: Make BCMA optional to support non-BCMA chips

2015-04-06 Thread Rafał Miłecki
On 2 April 2015 at 21:23, Jonathan Richardson jonat...@broadcom.com wrote: The Broadcom MSPI controller is used on various chips. The driver only supported BCM53xx chips with BCMA (an AMBA bus variant). The driver is refactored to make BCMA optional and provides a new config for non BCMA

Re: [PATCH 2/4] spi: bcm53xx: Refactor to make driver nonspecific to 53xx SoCs

2015-04-06 Thread Rafał Miłecki
On 3 April 2015 at 15:35, Andy Shevchenko andy.shevche...@gmail.com wrote: On Thu, Apr 2, 2015 at 10:23 PM, Jonathan Richardson jonat...@broadcom.com wrote: The Broadcom MSPI controller is used on various SoCs. It is being renamed so that it can be extended and reused on other chips. It is

Re: [PATCH 3/4] spi: bcm-mspi: Make BCMA optional to support non-BCMA chips

2015-04-06 Thread Rafał Miłecki
On 3 April 2015 at 15:38, Andy Shevchenko andy.shevche...@gmail.com wrote: On Thu, Apr 2, 2015 at 10:23 PM, Jonathan Richardson jonat...@broadcom.com wrote: The Broadcom MSPI controller is used on various chips. The driver only supported BCM53xx chips with BCMA (an AMBA bus variant). The

Re: [PATCH] Documentation: dt: mtd: replace nor-jedec binding with jedec,spi-nor

2015-05-21 Thread Rafał Miłecki
On 21 May 2015 at 09:25, Brian Norris computersforpe...@gmail.com wrote: (trim CC a bit, as this is no longer a DT binding question) On Thu, May 21, 2015 at 09:12:25AM +0200, Rafał Miłecki wrote: On 20 May 2015 at 23:35, Brian Norris computersforpe...@gmail.com wrote: On Tue, May 19, 2015

Re: [PATCH] Documentation: dt: mtd: replace nor-jedec binding with jedec,spi-nor

2015-05-21 Thread Rafał Miłecki
On 21 May 2015 at 10:15, Brian Norris computersforpe...@gmail.com wrote: On Thu, May 21, 2015 at 10:01:05AM +0200, Rafał Miłecki wrote: On 21 May 2015 at 09:25, Brian Norris computersforpe...@gmail.com wrote: (trim CC a bit, as this is no longer a DT binding question) On Thu, May 21, 2015

Re: [PATCH] Documentation: dt: mtd: replace nor-jedec binding with jedec,spi-nor

2015-05-21 Thread Rafał Miłecki
On 20 May 2015 at 23:35, Brian Norris computersforpe...@gmail.com wrote: On Tue, May 19, 2015 at 09:27:50AM +0200, Rafał Miłecki wrote: On 19 May 2015 at 03:34, Brian Norris computersforpe...@gmail.com wrote: So how about the following patch? It seems like we'll need to be able to ignore

Re: [PATCH] Documentation: dt: mtd: replace nor-jedec binding with jedec,spi-nor

2015-05-21 Thread Rafał Miłecki
On 21 May 2015 at 10:58, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Thu, May 21, 2015 at 10:50 AM, Rafał Miłecki zaj...@gmail.com wrote: I think your comments suggest that I shouldn't be removing spi-nor from m25p_ids[] nor from this block: if (data data-type

Re: [PATCH] Documentation: dt: mtd: replace nor-jedec binding with jedec,spi-nor

2015-05-21 Thread Rafał Miłecki
On 21 May 2015 at 10:39, Geert Uytterhoeven ge...@linux-m68k.org wrote: Hi Rafal, Brian, On Thu, May 21, 2015 at 10:25 AM, Rafał Miłecki zaj...@gmail.com wrote: On 21 May 2015 at 10:15, Brian Norris computersforpe...@gmail.com wrote: On Thu, May 21, 2015 at 10:01:05AM +0200, Rafał Miłecki

Re: [RFC PATCH] mtd: spi-nor: Added flag check for quad io protocol for micron flash parts

2015-06-20 Thread Rafał Miłecki
Hi, I don't really have enough knowledge to comment QUAD IO, I'll just include some general comments. On 18 June 2015 at 16:58, Anurag Kumar Vulisha anurag.kumar.vuli...@xilinx.com wrote: micron flash parts by default operates in extended spi protocol,which accepts command on single line and

Re: [PATCH] Documentation: dt: mtd: replace nor-jedec binding with jedec,spi-nor

2015-05-21 Thread Rafał Miłecki
On 21 May 2015 at 11:39, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Thu, May 21, 2015 at 11:31 AM, Rafał Miłecki zaj...@gmail.com wrote: On 21 May 2015 at 10:58, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Thu, May 21, 2015 at 10:50 AM, Rafał Miłecki zaj...@gmail.com wrote: I

  1   2   3   4   5   6   7   8   9   10   >