Re: [PATCH] drivers/usb/Config.in

2000-10-10 Thread Randy Dunlap
James Simmons wrote: Not needed. This is a misunderstanding. Maybe that needs some work (in Help maybe), but not this patch. Yes please. It can be very misleading. Then if you select USB HID support, that builds the hid driver, which handles mice, keyboards, joysticks, gamepads,

Re: 2.4.0-test9-pre8, usb, unresolved symbols

2000-10-18 Thread Randy Dunlap
Keith Owens wrote: Objects that export symbols must be explicitly listed before the calculation of OX_OBJS. usb.o is not explicitly listed as an object, it is implicitly included via the link of usbcore. Index: 0-test10-pre3.1/drivers/usb/Makefile ---

usbdevfs mount 2x, umount 1x

2000-11-29 Thread Randy Dunlap
[I reported this a couple of months back. Got no feedback on it. If it's just a DDT (don't do that) or a user error, please say so.] Summary: After I mount usbdevfs 2 times, and umount it 1 time, the usbcore module use count prevents it from being rmmod-ed. This is test12-pre2. 1. Start

[Fwd: 2.4.0-test12-pre7]

2000-12-07 Thread Randy Dunlap
From: Russell King [mailto:[EMAIL PROTECTED]] Linus Torvalds writes: - me: UHCI drivers really need to enable bus mastering. But it'll already be turned on if pci_assign_unassigned_resources() is called. This calls pdev_enable_device for every single device, which turns on the bus

Re: usb dc2xx quirk

2001-01-03 Thread Randy Dunlap
Hi, Looks like dc2xx.c shouldn't use __devinit/__devexit [patch attached] or you should enable CONFIG_HOTPLUG under General Setup. David? The ov511 (usb) driver is the only other USB device driver that uses __devinit/__devexit. ~Randy josh wrote: Kernel Version: 2.4.0-test11 -

Re: test10-pre7 (LINK ordering)

2000-10-31 Thread Randy Dunlap
Linus Torvalds wrote: [snip] That was going to be my next question if somebody actually said "sure". The question was rhetorical, since the way LINK_FIRST is implemented means that it has all the same problems that $(obj-y) has, and is hard to get right in the generic case (but you can

Re: [PATCH] Report that kernel is tainted if there were an OOPS before

2007-04-16 Thread Randy Dunlap
On Mon, 16 Apr 2007 14:23:26 +0400 Pavel Emelianov wrote: If the kernel OOPS-ed or BUG-ed then it probably should considered as tainted. Use die_counter introduced by many architectures to determine whether or not the kernel died. This saves a lot of time explaining oddities in the

Re: [nameidata 2/2] Pass no useless nameidata to the create, lookup, and permission IOPs

2007-04-16 Thread Randy Dunlap
On Mon, 16 Apr 2007 18:29:20 +0200 Andreas Gruenbacher wrote: Here is a patch with request for comment. --- a/include/linux/namei.h +++ b/include/linux/namei.h @@ -14,21 +14,39 @@ struct open_intent { enum { MAX_NESTED_LINKS = 8 }; +/** Please don't use the kernel-doc begin-marker

Re: [nameidata 2/2] Pass no useless nameidata to the create, lookup, and permission IOPs

2007-04-16 Thread Randy Dunlap
Andreas Gruenbacher wrote: On Monday 16 April 2007 18:42, Randy Dunlap wrote: Please don't use the kernel-doc begin-marker /** when the comment block isn't in kernel-doc format. Sigh, kernel-doc should improve things, not get in the way ... Well, I see it as sort of a language

[RFC/PATCH -mm] add pci_try_set_mwi

2007-04-16 Thread Randy Dunlap
(presently unimplemented) - review callers - remove __must_check ? From: Randy Dunlap [EMAIL PROTECTED] As suggested by Andrew, add pci_try_set_mwi(), which does not require return-value checking. - add pci_try_set_mwi() without __must_check - make it return 0 on success, errno if the try

Re: so what *is* obsolete and removable?

2007-04-16 Thread Randy Dunlap
On Tue, 17 Apr 2007 00:39:10 +0200 Tilman Schmidt wrote: Am 15.04.2007 22:55 schrieb Robert P. J. Day: as i recall, the isdn4linux was *un*obsoleted, wasn't it? Actually, it wasn't. We *did* reach a consensus that isdn4linux is not obsolete in the accepted sense of the word, because

Re: [PATCH] Introduce a handy list_first_entry macro

2007-04-17 Thread Randy Dunlap
On Tue, 17 Apr 2007 15:18:56 +0400 Pavel Emelianov wrote: There are many places in the kernel where the construction like foo = list_entry(head-next, struct foo_struct, list); are used. The code might look more descriptive and neat if using the macro list_first_entry(head, type,

Re: Permanent Kgdb integration into the kernel - lets get with it.

2007-04-17 Thread Randy Dunlap
On Thu, 08 Mar 2007 14:24:10 -0800 Piet Delaney wrote: On Thu, 2007-03-08 at 11:49 -0700, Tom Rini wrote: On Thu, Mar 08, 2007 at 07:37:56PM +0100, Andi Kleen wrote: On Thursday 08 March 2007 18:44, Dave Jiang wrote: In spite of kgdb, shouldn't it have that \n anyways in case some

Re: Permanent Kgdb integration into the kernel - lets get with it.

2007-04-17 Thread Randy Dunlap
Sergei Shtylyov wrote: Hello. Randy Dunlap wrote: In spite of kgdb, shouldn't it have that \n anyways in case some other code gets added in the future after the macro? Or are you saying that there should never be any code ever after that macro? Sure if there is mainline code added after

Re: [PATCH] [KERNEL-DOC] kill warnings when building mandocs

2007-04-18 Thread Randy Dunlap
On Tue, 17 Apr 2007 12:49:07 +0200 Borislav Petkov wrote: On Sun, Apr 15, 2007 at 09:10:50AM +0200, Borislav Petkov wrote: On Sat, Apr 14, 2007 at 09:13:41AM -0700, Randy Dunlap wrote: On Fri, 13 Apr 2007 11:14:22 +0200 Borislav Petkov wrote: This patch shuts warnings of the sort

Re: [PATCH] [KERNEL-DOC] kill warnings when building mandocs

2007-04-18 Thread Randy Dunlap
On Fri, 13 Apr 2007 11:29:43 +0200 Borislav Petkov wrote: Sorry for the improper whitespaces, here's a correct version. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] Index: 21-rc6/scripts/kernel-doc === ---

Re: [RFC][PATCH] fix abs() macro to work with types wider than int

2007-04-19 Thread Randy Dunlap
On Thu, 19 Apr 2007 11:23:39 +0200 Jiri Bohac wrote: Hi, is there any reason to use an explicit int instead of a typeof in the abs() macro? The current implementation will return bogus results when used with longs. I think it's like it is just to be consistent with abs() in C, which also

Re: [PATCH] [KERNEL-DOC] kill warnings when building mandocs

2007-04-19 Thread Randy Dunlap
On Thu, 19 Apr 2007 08:20:59 +0200 Borislav Petkov wrote: snip I'm pretty sure the reason you cannot reproduce this warning is the line xsl:param name=refentry.version.suppress1/xsl:param which can be found in param.xsl, it being a part of the docbook-xsl distribution. The

Re: [PATCHv2] [KERNEL-DOC] kill warnings when building mandocs

2007-04-19 Thread Randy Dunlap
constraints in the xml DTD for the man header, I believe, for the troff output is truncated too. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- scripts/kernel-doc | 36 1 file changed, 36 insertions

Re: [PATCH] [KERNEL-DOC] kill warnings when building mandocs

2007-04-22 Thread Randy Dunlap
--- ~Randy --- Original Message --- On Thu, Apr 19, 2007 at 08:53:36AM -0700, Randy Dunlap wrote: On Thu, 19 Apr 2007 08:20:59 +0200 Borislav Petkov wrote: snip I'm pretty sure the reason you cannot reproduce this warning is the line xsl:param name

Re: /dev/null implementation question

2007-03-08 Thread Randy Dunlap
On Thu, 8 Mar 2007 19:01:39 +0100 Michael Nitschinger wrote: Hello, I asked myself how /dev/null is implemented in C, but i didn't find anything in the documentation or generally on the internet. It would be great if someone could tell me where i can find the source for this device or how

Re: the usage of DEBUG_DRIVER seems ambiguous

2007-03-08 Thread Randy Dunlap
On Wed, 7 Mar 2007 19:44:41 -0500 (EST) Robert P. J. Day wrote: the usage of the DEBUG_DRIVER preprocessor variable is a big confusing: $ $ grep -rw DEBUG_DRIVER * drivers/net/sunlance.c:#undef DEBUG_DRIVER drivers/net/a2065.c:#ifdef DEBUG_DRIVER drivers/net/a2065.c:#ifdef

Re: [RFC] [Patch 1/1] IBAC Patch

2007-03-08 Thread Randy Dunlap
On Thu, 08 Mar 2007 17:58:16 -0500 Mimi Zohar wrote: This is a request for comments for a new Integrity Based Access Control(IBAC) LSM module which bases access control decisions on the new integrity framework services. (Hopefully this will help clarify the interaction between an LSM

Re: [RFC] [Patch 1/1] IBAC Patch

2007-03-09 Thread Randy Dunlap
On Fri, 09 Mar 2007 08:19:36 -0500 Mimi Zohar wrote: On Thu, 2007-03-08 at 15:08 -0800, Randy Dunlap wrote: On Thu, 08 Mar 2007 17:58:16 -0500 Mimi Zohar wrote: This is a request for comments for a new Integrity Based Access Control(IBAC) LSM module which bases access control

Re: [PATCH] Use more gcc extensions in the Linux headers

2007-03-09 Thread Randy Dunlap
On Sat, 10 Mar 2007 09:57:32 +1100 Rusty Russell wrote: On Fri, 2007-03-09 at 16:56 +1100, Rusty Russell wrote: __builtin_types_compatible_p() has been around since gcc 2.95, and we don't use it anywhere. This patch quietly fixes that. Bah. Just because gcc has a feature doesn't mean we

Re: [PATCH] Use more gcc extensions in the Linux headers

2007-03-09 Thread Randy Dunlap
On Fri, 09 Mar 2007 23:03:05 -0500 [EMAIL PROTECTED] wrote: On Sat, 10 Mar 2007 09:57:32 +1100, Rusty Russell said: +/* GCC is awesome. */ #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) \ + sizeof(typeof(int[1 -

Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addr bogosity

2007-03-09 Thread Randy Dunlap
On Fri, 9 Mar 2007 09:19:07 -0500 John W. Linville wrote: Probably should copy me and [EMAIL PROTECTED] Other than that, this looks fine to me. I'll queue it up shortly. John On Fri, Mar 09, 2007 at 01:11:46PM +1100, Tony Breeds wrote: On Wed, Mar 07, 2007 at 03:00:57PM -0800, Andrew

Re: [PATCH 10/22 take 3] UBI: EBA unit

2007-03-15 Thread Randy Dunlap
On Thu, 15 Mar 2007 11:07:03 -0800 Andrew Morton wrote: There's way too much code here to expect it to get decently reviewed, alas. Yes. /me repeats wish that Not Everything Should Be Sent to lkml. :( On Wed, 14 Mar 2007 17:20:24 +0200 Artem Bityutskiy [EMAIL PROTECTED] wrote: ...

Re: CONFIG_REORDER Kconfig help strange sentence.

2007-03-15 Thread Randy Dunlap
On Tue, 13 Mar 2007 17:37:35 +1100 Rusty Russell wrote: On Tue, 2007-03-13 at 00:56 +0100, Andi Kleen wrote: On Tue, Mar 13, 2007 at 10:18:03AM +1100, Rusty Russell wrote: OK, this confused me: Function reordering (REORDER) [N/y/?] (NEW) ? This option

Re: [PATCH 10/22 take 3] UBI: EBA unit

2007-03-15 Thread Randy Dunlap
On Thu, 15 Mar 2007 18:29:51 -0500 Josh Boyer wrote: On Thu, Mar 15, 2007 at 02:24:10PM -0700, Randy Dunlap wrote: On Thu, 15 Mar 2007 11:07:03 -0800 Andrew Morton wrote: There's way too much code here to expect it to get decently reviewed, alas. Yes. /me repeats wish

Re: [PATCH 10/22 take 3] UBI: EBA unit

2007-03-16 Thread Randy Dunlap
On Fri, 16 Mar 2007 12:21:08 +0200 Artem Bityutskiy wrote: On Thu, 2007-03-15 at 14:24 -0700, Randy Dunlap wrote: /me repeats wish that Not Everything Should Be Sent to lkml. :( If you do statement like this, please, provide reasons why you say it for these patches and suggest something

Re: [5/6] 2.6.21-rc2: known regressions

2007-03-16 Thread Randy Dunlap
On Tue, 6 Mar 2007 08:44:43 -0800 (PST) Linus Torvalds wrote: This is just a coding style thing, but I thought I should really point it out, because these kinds of things quite often result in nasty bugs simply because the source code is so hard to read properly: On Tue, 6 Mar 2007,

Re: Linux 2.6.21-rc4

2007-03-16 Thread Randy Dunlap
On Fri, 16 Mar 2007 09:33:54 -0700 (PDT) Linus Torvalds wrote: I pushed out the -git trees yesterday, but then got distracted, so the patches and tar-balls and the announcement got delayed until this morning. Oops. I'm a scatter-brain. allmodconfig on i386: WARNING: default_idle

Re: [patch 10/34] Xen-pv_ops: Simplify smp_call_function*() by using common implementation

2007-03-15 Thread Randy Dunlap
not quite correct. Patch below applies on top of this patch from Jeremy. --- From: Randy Dunlap [EMAIL PROTECTED] Clean up arch/i386/kernel/smp.c after the Xen pv_ops patches for smp_call_function variants. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- arch/i386/kernel/smp.c | 13

Re: Linux 2.6.21-rc4

2007-03-16 Thread Randy Dunlap
On Fri, 16 Mar 2007 14:11:21 -0700 Randy Dunlap wrote: On Fri, 16 Mar 2007 09:33:54 -0700 (PDT) Linus Torvalds wrote: I pushed out the -git trees yesterday, but then got distracted, so the patches and tar-balls and the announcement got delayed until this morning. Oops. I'm a scatter

[PATCH] kprobes: fix sparse NULL warning

2007-03-16 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix sparse NULL warnings: kernel/kprobes.c:915:49: warning: Using plain integer as NULL pointer Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- kernel/kprobes.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-2621-rc4.orig/kernel

is SpellCaster ISDN still used?

2007-03-16 Thread Randy Dunlap
There is an API argument mismatch in it: drivers/isdn/sc/init.c:281: warning: assignment from incompatible pointer type interface-writebuf_skb = sndpkt; where: int sndpkt(int devId, int channel, struct sk_buff *data) { ... } should look like this: /* * Send data using

[PATCH 2/3] PCI/sysfs/kobject kernel-doc fixes

2007-02-10 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix kernel-doc warnings in PCI, sysfs, and kobject files. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/pci/pci-driver.c |1 + drivers/pci/pci.c|2 +- fs/sysfs/file.c |2 +- lib/kobject.c|1 + 4 files

[PATCH 3/3] IRQ kernel-doc fixes

2007-02-10 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix kernel-doc warnings in IRQ management. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- include/linux/irq.h |1 + kernel/irq/chip.c |2 +- 2 files changed, 2 insertions(+), 1 deletion(-) --- linux-2.6.20-git6.orig/include/linux/irq.h

[PATCH 1/3] USB kernel-doc fixes

2007-02-10 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix kernel-doc warnings and errors in USB. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- Documentation/DocBook/gadget.tmpl |4 ++-- Documentation/DocBook/usb.tmpl|6 +++--- drivers/usb/core/driver.c |1 + 3 files changed, 6

Re: [PATCH] iomap: make PCI iomap stuff excluded when PCI isn't configured

2007-02-10 Thread Randy Dunlap
On Sat, 10 Feb 2007 12:43:16 -0500 Tejun Heo wrote: devres iomap made lib/iomap.c always built and added several arch-indep PCI routines to include/linux/io.h and lib/iomap.c without wrapping them inside CONFIG_PCI. This breaks configurations where PCI is not configured. Wrap pci_iomap() in

[PATCH] fix fatal kernel-doc error

2007-02-10 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Teach kernel-doc to handle functions that look like the new pcim_iomap_table(). Fixes this fatal error in scripts/kernel-doc: DOCPROC Documentation/DocBook/kernel-api.xml Error(/tester/linsrc/linux-2.6.20-git6//drivers/pci/pci.c:1351): cannot understand

[PATCH] devres: kernel-doc and DocBook

2007-02-10 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Make devres.c ready for adding to DocBook. Fix a few comment typos in drivers/pci/pci.c. Add devres.c to DocBook. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- Documentation/DocBook/kernel-api.tmpl |4 drivers/base/devres.c

Re: [patch] linux/io.h: forward declare struct pci_dev

2007-02-10 Thread Randy Dunlap
On Sun, 11 Feb 2007 06:34:31 + Al Viro wrote: My current version: From 97f115834b5ebef4f04e0f18aaa10f78f43733a0 Mon Sep 17 00:00:00 2001 From: Al Viro [EMAIL PROTECTED] Date: Sat, 10 Feb 2007 23:41:09 -0500 Subject: [PATCH] sort the devres mess out Split the implementation-agnostic

Re: Still cant boot 2.6.20

2007-02-10 Thread Randy Dunlap
On Sun, 11 Feb 2007 01:02:47 -0600 [EMAIL PROTECTED] wrote: I don't see CONFIG_BLK_DEV_INITRD=y Regards, Vito Caputo BTW, this isnt the appropriate place for asking this type of question... Please explain why not. And please delete large parts of email that are not needed in replies

Re: Still cant boot 2.6.20

2007-02-11 Thread Randy Dunlap
Willy Tarreau wrote: On Sun, Feb 11, 2007 at 01:37:31AM -0600, [EMAIL PROTECTED] wrote: On Sat, Feb 10, 2007 at 11:12:34PM -0800, Randy Dunlap wrote: On Sun, 11 Feb 2007 01:02:47 -0600 [EMAIL PROTECTED] wrote: I don't see CONFIG_BLK_DEV_INITRD=y Regards, Vito Caputo BTW, this isnt

Re: Found trivial error in linux-headers-2.6.17-11-generic/include/linux/tty.h

2007-02-12 Thread Randy Dunlap
On Mon, 12 Feb 2007 12:42:22 +0100 Milan Markovic wrote: I upgraded the kernel on my Kubuntu 6.10 to 2.6.17-11-generic and had a lot of trouble compiling my softmodem driver. Apparently it was, among others, because of a mistake in kernel-headers this is what I've found in tty.h $ cat -n

Re: [PATCH x86 for review III] [1/29] i386: avoid gcc extension

2007-02-12 Thread Randy Dunlap
. --- From: Randy Dunlap [EMAIL PROTECTED] setcc() in math-emu is written as a gcc extension statement expression macro that returns a value. However, it's not used that way and it's not needed like that, so just make it an inline void so that we don't use an extension when it's not needed. Signed

build errors: uevent with CONFIG_SYSFS=n

2007-02-12 Thread Randy Dunlap
in kernel/params.c: kernel/params.c:700: error: 'module_uevent_ops' undeclared here (not in a function) in kernel/module.c: kernel/built-in.o: In function `module_add_driver': (.text+0x20c5b): undefined reference to `module_subsys' kernel/built-in.o: In function `sys_init_module':

[PATCH] build errors: uevent with CONFIG_SYSFS=n

2007-02-12 Thread Randy Dunlap
On Mon, 12 Feb 2007 13:50:21 -0800 Randy Dunlap wrote: in kernel/params.c: kernel/params.c:700: error: 'module_uevent_ops' undeclared here (not in a function) in kernel/module.c: kernel/built-in.o: In function `module_add_driver': (.text+0x20c5b): undefined reference

build error: allnoconfig fails on mincore/swapper_space

2007-02-12 Thread Randy Dunlap
2.6.20-git8 on x86_64: LD init/built-in.o LD .tmp_vmlinux1 mm/built-in.o: In function `sys_mincore': (.text+0xe584): undefined reference to `swapper_space' make: *** [.tmp_vmlinux1] Error 1 --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -

Re: build error: allnoconfig fails on mincore/swapper_space

2007-02-12 Thread Randy Dunlap
Andrew Morton wrote: On Mon, 12 Feb 2007 14:50:40 -0800 Randy Dunlap [EMAIL PROTECTED] wrote: 2.6.20-git8 on x86_64: LD init/built-in.o LD .tmp_vmlinux1 mm/built-in.o: In function `sys_mincore': (.text+0xe584): undefined reference to `swapper_space' make: *** [.tmp_vmlinux1

Re: 2.6.20: Rebuild after trivial patch rebuilds way too much

2007-02-12 Thread Randy Dunlap
On Mon, 12 Feb 2007 20:37:35 +0300 Andrey Borzenkov wrote: Is not it too much fore a trivial two lines patch to a single file? {pts/1}% stg import ~/patch/Re_2_6_20_rc6_libata_PATA_ATAPI_CDROM_is_not_working.patch Importing patch

Re: SATA Drive No Longer Recognized In New 2.6.20 Kernel

2007-02-12 Thread Randy Dunlap
On Mon, 12 Feb 2007 17:30:38 -0700 Joseph Cosby wrote: Hi, Until recently I was using the 2.6.18 kernel. I have a SATA hard drive that was detected by the kernel, using the PIIX driver. But after updating to 2.6.20, the hard drive is no longer detected by the kernel. I used make oldconfig to

Re: SATA Drive No Longer Recognized In New 2.6.20 Kernel

2007-02-12 Thread Randy Dunlap
Joseph Cosby wrote: Thanks. Now having enabled the new ATA config options, the vendor-id shows up in my modules pci list. But the hard drive still isn't detected by the kernel. Is there more that needs to be enabled for this to work? Please be more explicit about which options you enabled.

Re: [PATCH x86 for review III] [1/29] i386: avoid gcc extension

2007-02-13 Thread Randy Dunlap
On Tue, 13 Feb 2007 16:11:14 +0100 Arnd Bergmann wrote: On Monday 12 February 2007 17:51, Andi Kleen wrote: setcc() in math-emu is written as a gcc extension statement expression macro that returns a value.  However, it's not used that way and it's not needed like that, so just make it a

Re: Coding style RFC: convert for (i=0;iARRAY_SIZE(array);i++) to array_for_each(index, array)

2007-02-13 Thread Randy Dunlap
On Tue, 13 Feb 2007 09:37:38 +0200 Muli Ben-Yehuda wrote: On Mon, Feb 12, 2007 at 03:47:50PM -0800, Joe Perches wrote: Now that most of the sizeof(array)/sizeof(array[0]) conversions have been done (there are about 800 done and about another 130 left), perhaps it could be useful to

Re: Small problem with kernel 2.6.20 and make menuconfig

2007-02-13 Thread Randy Dunlap
On Tue, 13 Feb 2007 09:17:51 + Dominic Newton wrote: Just a small issue with the latest kernel 2.6.20. When compiling make menuconfig our ncurses library is not being detected. I currently use 2.6.15 with no problem and comparing the 2 I found a script (

[PATCH] kernel-doc: include struct short description in title output

2007-02-13 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Output of a struct in html mode needs to include the short description from the struct name line in the output title line. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- scripts/kernel-doc |2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2] kernel-doc: include struct short description in title output

2007-02-13 Thread Randy Dunlap
Yup, that fixes it for structs. I guess I forgot to mention this earlier because I didn't notice it until now... the same bug exists for functions as well. updated patch. Thanks. --- From: Randy Dunlap [EMAIL PROTECTED] Output of a function or struct in html mode needs to include the short

[patch] build error: allnoconfig fails on mincore/swapper_space

2007-02-13 Thread Randy Dunlap
On Tue, 13 Feb 2007 13:48:53 +1100 Nick Piggin wrote: Andrew Morton wrote: On Mon, 12 Feb 2007 14:50:40 -0800 Randy Dunlap [EMAIL PROTECTED] wrote: 2.6.20-git8 on x86_64: LD init/built-in.o LD .tmp_vmlinux1 mm/built-in.o: In function `sys_mincore': (.text+0xe584

Re: [patch] build error: allnoconfig fails on mincore/swapper_space

2007-02-13 Thread Randy Dunlap
to be a migration entry, which always counts as present. BUT: what is present used for in that loop? or is it used? Well spotted! Something has gone missing: there needs to be a vec[i] = present; at the bottom of that loop. From: Randy Dunlap [EMAIL PROTECTED] Don't check

[PATCH v2] build errors: uevent with CONFIG_SYSFS=n

2007-02-13 Thread Randy Dunlap
On Mon, 12 Feb 2007 14:58:23 -0800 Andrew Morton wrote: On Mon, 12 Feb 2007 14:29:19 -0800 Randy Dunlap [EMAIL PROTECTED] wrote: Here's a patch, tested both ways (SYSFS=y, SYSFS=n). --- From: Randy Dunlap [EMAIL PROTECTED] Fix source files to build with CONFIG_SYSFS=n

[PATCH] tty: use NULL for ptrs

2007-02-13 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix sparse warning in tty_io: drivers/char/tty_io.c:1536:34: warning: Using plain integer as NULL pointer Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/char/tty_io.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2.6.20-git9

[PATCH] cdrom: use unsigned bitfields

2007-02-13 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix 23 of these sparse warnings on x86_64 allmodconfig: include/linux/cdrom.h:942:19: error: dubious bitfield without explicit `signed' or `unsigned' Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- include/linux/cdrom.h |2 +- 1 file changed, 1

kbuild feature/question: default ARCH

2007-02-13 Thread Randy Dunlap
suggestions for how to complete this? Thanks. --- From: Randy Dunlap [EMAIL PROTECTED] If ARCH is unspecified (command line or environment) and if include/asm is already a symlink to include/asm-$ARCH, use that ARCH as the default instead of the host ARCH. Undo the effect of this by using 'make

Re: kbuild feature/question: default ARCH

2007-02-13 Thread Randy Dunlap
On Tue, 13 Feb 2007 22:06:19 -0800 Randy Dunlap wrote: --- If ARCH is unspecified (command line or environment) and if include/asm is already a symlink to include/asm-$ARCH, use that ARCH as the default instead of the host ARCH. Undo the effect of this by using 'make mrproper' or just 'rm

Re: Is this bug too obvious?

2007-02-13 Thread Randy Dunlap
On Tue, 13 Feb 2007 19:41:34 -0500 Chuck Ebbert wrote: [adding linux-usb-devel] drivers/usb/net/usbnet.c: int usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod) { struct usbnet *dev; struct net_device *net;

Re: CONFIG_SWAP=n broken in latest tree

2007-02-14 Thread Randy Dunlap
On Wed, 14 Feb 2007 14:41:05 -0800 Roland Dreier wrote: Commit 42da9cbd (mm: mincore anon) breaks CONFIG_SWAP=n builds with: mm/built-in.o: In function `sys_mincore': (.text+0xe2c4): undefined reference to `swapper_space' because swapper_space is used unconditionally in

Re: GPL vs non-GPL device drivers

2007-02-14 Thread Randy Dunlap
On Wed, 14 Feb 2007 22:27:10 -0800 v j wrote: On 2/14/07, Dave Jones [EMAIL PROTECTED] wrote: On Wed, Feb 14, 2007 at 09:16:28PM -0800, v j wrote: Welcome to three months ago. Here in the future, this was deemed a non-issue. However this does highlight another problem. End-users who

Re: [patch] build error: allnoconfig fails on mincore/swapper_space

2007-02-15 Thread Randy Dunlap
On Wed, 14 Feb 2007 00:19:06 + (GMT) Hugh Dickins wrote: On Tue, 13 Feb 2007, Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Don't check for pte swap entries when CONFIG_SWAP=n. And save 'present' in the vec array. mm/built-in.o: In function `sys_mincore': (.text

Re: [PATCH] Don't probe for DDC on VBE1.2

2007-02-15 Thread Randy Dunlap
On Thu, 15 Feb 2007 08:29:49 -0800 (PST) Zwane Mwaikambo wrote: VBE1.2 doesn't support function 15h (DDC) resulting in a 'hang' whilst uncompressing kernel with some video cards. Make sure we check VBE version before fiddling around with DDC. http://bugzilla.kernel.org/show_bug.cgi?id=1458

[PATCH] MAINTAINERS: mark framebuffer as Orphan

2007-02-15 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Are we ready to do this? I'd love for Tony to return, but he's been missing for awhile now. So this give us the following major areas that are marked as Orphan: Firmware loader Framebuffer Serial (8250/16x50) and PCMCIA has a Team. It doesn't seem

Re: [PATCH] MAINTAINERS: mark framebuffer as Orphan

2007-02-15 Thread Randy Dunlap
should be using that. On Thu, 15 Feb 2007, Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Are we ready to do this? I'd love for Tony to return, but he's been missing for awhile now. So this give us the following major areas that are marked as Orphan: Firmware loader

[PATCH] update Doc/oops-tracing.txt for TAINT_USER

2007-02-15 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Add TAINT_USER description to Tainted flags in oops-tracing.txt. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- Documentation/oops-tracing.txt |3 +++ 1 file changed, 3 insertions(+) --- linux-2.6.20-git9.orig/Documentation/oops-tracing.txt +++ linux

Re: [PATCH] Linux Kernel Markers Documentation

2007-02-15 Thread Randy Dunlap
On Thu, 15 Feb 2007 20:33:48 -0500 Mathieu Desnoyers wrote: Linux Kernel Markers - Documentation Here is some documentation explaining what is/how to use the Linux Kernel Markers. Signed-off-by: Mathieu Desnoyers [EMAIL PROTECTED] --- /dev/null +++ b/Documentation/marker.txt @@ -0,0

Re: [PATCH] update Doc/oops-tracing.txt for TAINT_USER

2007-02-16 Thread Randy Dunlap
On Fri, 16 Feb 2007 09:50:33 -0500 Theodore Tso wrote: I suggest you change this to read if a user or user application. Otherwise, Signed-off-by: Theodore Ts'o [EMAIL PROTECTED] From: Randy Dunlap [EMAIL PROTECTED] Add TAINT_USER description to Tainted flags in oops-tracing.txt. Signed

Re: 2.6.20-mm1

2007-02-16 Thread Randy Dunlap
On Fri, 16 Feb 2007 10:37:12 -0600 Steve Fox wrote: bl6-13, an x86_64 box listed on test.kernel.org, tripped on this during an LTP run, even with unify-queue_delayed_work-and-queue_delayed_work_on-fix.patch applied. I'm not sure why the LTP results aren't copied over to TKO, but here's

Re: S_NORMAL_ACTIVE, S_CLOSING

2007-02-16 Thread Randy Dunlap
On Fri, 16 Feb 2007 19:41:54 +0300 (MSK) Mockern wrote: Hello, In which header I can find S_NORMAL_ACTIVE and S_CLOSING? Thank you cd top_of_linux_source_tree find . -name \*\.h | xargs grep -w S_CLOSING --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code

Re: Using sched_clock for mmio-trace

2007-02-16 Thread Randy Dunlap
On Fri, 16 Feb 2007 13:30:14 -0500 Jeff Muizelaar wrote: On Fri, Feb 16, 2007 at 11:30:56AM -0500, Frank Ch. Eigler wrote: Jeff Muizelaar [EMAIL PROTECTED] writes: I've built a tool with the goal of logging mmio writes and reads by device drivers. See

Re: Linus' laptop and Num lock status

2007-02-18 Thread Randy Dunlap
On Sun, 18 Feb 2007 17:04:01 +0100 Jean Delvare wrote: On Thu, 15 Feb 2007 06:34:35 -0800, H. Peter Anvin wrote: Jean Delvare wrote: On x86, the BIOS led state can be read from byte 0x97 the BIOS RAM. The BIOS RAM is mapped at 0x400 so all we need to do is to one byte from RAM (offset

Re: Linus' laptop and Num lock status

2007-02-18 Thread Randy Dunlap
On Sun, 18 Feb 2007 09:32:15 -0800 H. Peter Anvin wrote: Jean Delvare wrote: On Thu, 15 Feb 2007 06:34:35 -0800, H. Peter Anvin wrote: Jean Delvare wrote: On x86, the BIOS led state can be read from byte 0x97 the BIOS RAM. The BIOS RAM is mapped at 0x400 so all we need to do is to one

Re: [patch/rfc 2.6.20-git] parport reports physical devices

2007-02-18 Thread Randy Dunlap
On Sun, 18 Feb 2007 21:08:07 -0800 David Brownell wrote: Currently a parport_driver can't get a handle on the device node for the underlying parport (PNPACPI, PCI, etc). That prevents correct placement of sysfs child nodes, which can affect things like power management. This patch resolves

Re: CONFIG_REORDER Kconfig help strange sentence.

2007-03-17 Thread Randy Dunlap
On Sat, 17 Mar 2007 19:54:30 +1100 Rusty Russell wrote: On Thu, 2007-03-15 at 18:34 -0700, Randy Dunlap wrote: On Tue, 13 Mar 2007 17:37:35 +1100 Rusty Russell wrote: diff -r de5618b5e562 arch/x86_64/Kconfig --- a/arch/x86_64/Kconfig Tue Mar 13 11:41:55 2007 +1100 +++ b/arch/x86_64

Re: [PATCH 21-rc4] misc doc and kconfig typos

2007-03-17 Thread Randy Dunlap
On Sat, 17 Mar 2007 14:44:51 -0400 Matt LaPlante wrote: Fix various typos in kernel docs and Kconfigs, 2.6.21-rc4. Signed-off-by: Matt LaPlante [EMAIL PROTECTED] Acked-by: Randy Dunlap [EMAIL PROTECTED] Thanks, Matt. BTW, I would prefer to see doc and kconfig patches in separate files

Re: Linux 2.6.21-rc4

2007-03-18 Thread Randy Dunlap
On Sun, 18 Mar 2007 13:39:45 +0100 Sam Ravnborg wrote: On Sat, Mar 17, 2007 at 07:43:40AM +0100, Sam Ravnborg wrote: On Fri, Mar 16, 2007 at 03:39:57PM -0700, Randy Dunlap wrote: On Fri, 16 Mar 2007 14:11:21 -0700 Randy Dunlap wrote: On Fri, 16 Mar 2007 09:33:54 -0700 (PDT) Linus

Re: [PATCH][1/5][resend] floppy.c: Initial (partial) CodingStyle cleanup

2007-03-19 Thread Randy Dunlap
On Mon, 19 Mar 2007 16:10:13 +0100 Jesper Juhl wrote: This is a basic CodingStyle cleanup for drivers/block/floppy.c There are no functional changes in this patch. --- diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index 5231ed7..5da54b8 100644 ---

Re: taskstats accounting info

2007-03-19 Thread Randy Dunlap
you find the updated version of it. ~Randy From: Randy Dunlap [EMAIL PROTECTED] 1. add usage() function 2. add unknown character in %c format (was only in %d, not useful): ./getdelays: invalid option -- h Unknown option '?' (63) instead of: ./getdelays: invalid option -- h Unknown option 63

Re: [PATCH RESEND 1/1] crypto API: RSA algorithm patch (kernel version 2.6.20.1) (and i hope pine does not break it either)

2007-03-19 Thread Randy Dunlap
On Mon, 19 Mar 2007 19:22:00 +0200 (EET) Tasos Parisinos wrote: As mentioned in the subject this patch applies in kernel version 2.6.20.1. It needs to apply to Linus's current tree (and it doesn't). diff -uprN -X linux-2.6.20.1-vanilla/Documentation/dontdiff linux-2.6.20.1/crypto/Kconfig

Re: [2/6] 2.6.21-rc4: known regressions

2007-03-19 Thread Randy Dunlap
/show_bug.cgi?id=8162 Submitter : Randy Dunlap [EMAIL PROTECTED] Status : unknown Bug is rejected due to user error. This seems to be a netconsole hang, not ACPI. --- ~Randy - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [2/6] 2.6.21-rc4: known regressions

2007-03-19 Thread Randy Dunlap
Adrian Bunk wrote: On Mon, Mar 19, 2007 at 09:06:57AM -0700, Randy Dunlap wrote: On Sun, 18 Mar 2007 19:49:15 +0100 Adrian Bunk wrote: This email lists some known regressions in Linus' tree compared to 2.6.20. If you find your name in the Cc header, you are either submitter of one

Re: 2.6.21-rc3-mm2

2007-03-19 Thread Randy Dunlap
On Wed, 7 Mar 2007 20:19:15 -0800 Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc3/2.6.21-rc3-mm2/ - This is the same as 2.6.21-rc3-mm1, except Con's CPU scheduler changes were dropped. This is for A/B comparison purposes, and because

[PATCH] sysctl: vfs_cache_divisor

2007-03-19 Thread Randy Dunlap
. I missed this sysctl since the name isn't really all that obvious. Peter, Were there any patches written after this? If so, I missed them. If not, does this patch help any? --- From: Randy Dunlap [EMAIL PROTECTED] Add sysctl_vfs_cache_divisor (default value 100), which is used

Re: 2.6.21-rc3-mm2

2007-03-19 Thread Randy Dunlap
On Wed, 7 Mar 2007 20:19:15 -0800 Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc3/2.6.21-rc3-mm2/ - This is the same as 2.6.21-rc3-mm1, except Con's CPU scheduler changes were dropped. This is for A/B comparison purposes, and because

Re: [PATCH] sysctl: vfs_cache_divisor

2007-03-19 Thread Randy Dunlap
Andrew Morton wrote: On Mon, 19 Mar 2007 12:27:40 -0700 Randy Dunlap [EMAIL PROTECTED] wrote: +The default vfs_cache_divisor value is 100 (like percent). However, for +extremely large systems where a value of vfs_cache_pressure of less than +1 percent is desirable, using a larger

[PATCH] ptrace needs PROC_FS

2007-03-19 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] CONFIG_PTRACE needs PROC_FS; with CONFIG_PROC_FS=n (x86_64): LD .tmp_vmlinux1 kernel/built-in.o: In function `ptrace_start': ptrace.c:(.text+0x300f9): undefined reference to `ptrace_may_attach' make: *** [.tmp_vmlinux1] Error 1 Signed-off-by: Randy

Re: kref refcounting breakage in mainline

2007-03-19 Thread Randy Dunlap
On Thu, 15 Mar 2007 07:54:14 -0700 Greg KH wrote: On Thu, Mar 15, 2007 at 11:19:20AM +0100, Mike Galbraith wrote: On Thu, 2007-03-15 at 01:06 -0700, Greg KH wrote: That's good. But why don't we have a module name for this driver? And if we don't have a module name, why would

Re: 2.6.21-rc3-mm2

2007-03-19 Thread Randy Dunlap
On Wed, 7 Mar 2007 20:19:15 -0800 Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc3/2.6.21-rc3-mm2/ - This is the same as 2.6.21-rc3-mm1, except Con's CPU scheduler changes were dropped. This is for A/B comparison purposes, and because

Re: 2.6.21-rc3-mm2

2007-03-19 Thread Randy Dunlap
On Mon, 19 Mar 2007 17:39:15 -0700 Andrew Morton wrote: On Mon, 19 Mar 2007 17:27:11 -0700 Randy Dunlap [EMAIL PROTECTED] wrote: On Wed, 7 Mar 2007 20:19:15 -0800 Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc3/2.6.21-rc3-mm2

Re: 2.6.21-rc3-mm2

2007-03-20 Thread Randy Dunlap
Sam Ravnborg wrote: On Mon, Mar 19, 2007 at 05:27:11PM -0700, Randy Dunlap wrote: On Wed, 7 Mar 2007 20:19:15 -0800 Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc3/2.6.21-rc3-mm2/ - This is the same as 2.6.21-rc3-mm1, except Con's CPU scheduler

  1   2   3   4   5   6   7   8   9   10   >