[PATCH v1 1/1] arm64: dts: stingray: fix usb dma address translation

2021-01-18 Thread Rayagonda Kokatanur
From: Bharat Gooty Add a non-empty dma-ranges so that dma address translation happens. Fixes: 2013a4b684b6 ("arm64: dts: broadcom: clear the warnings caused by empty dma-ranges") Signed-off-by: Bharat Gooty Signed-off-by: Rayagonda Kokatanur --- arch/arm64/boot/dts/broadco

[PATCH v1 1/1] firmware: tee_bnxt: reduce shared mem size to 4K

2020-10-05 Thread Rayagonda Kokatanur
Reduce the DMA shared memory for OP-TEE and Linux to 4K. Signed-off-by: Rayagonda Kokatanur --- drivers/firmware/broadcom/tee_bnxt_fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c index

[PATCH v1 0/6] fix iproc driver to handle master read request

2020-10-11 Thread Rayagonda Kokatanur
This series of patches adds the following, - Handle master abort error - Fix support for single/multi byte master read request with/without repeated start. - Handle rx fifo full interrupt - Fix typo Rayagonda Kokatanur (6): i2c: iproc: handle Master aborted error i2c: iproc: handle only slave

[PATCH v1 2/6] i2c: iproc: handle only slave interrupts which are enabled

2020-10-11 Thread Rayagonda Kokatanur
is set and enabled. Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm-

[PATCH v1 6/6] i2c: iproc: handle rx fifo full interrupt

2020-10-11 Thread Rayagonda Kokatanur
ore than 64 bytes. Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index 22e04055b447..cceaf69279a9 100

[PATCH v1 4/6] i2c: iproc: fix typo in slave_isr function

2020-10-11 Thread Rayagonda Kokatanur
Fix typo in bcm_iproc_i2c_slave_isr(). Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/buss

[PATCH v1 1/6] i2c: iproc: handle Master aborted error

2020-10-11 Thread Rayagonda Kokatanur
Handle Master aborted error by flushing tx and rx fifo and reinitializing the hw. Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c

[PATCH v1 3/6] i2c: iproc: update slave isr mask (ISR_MASK_SLAVE)

2020-10-11 Thread Rayagonda Kokatanur
Update slave isr mask (ISR_MASK_SLAVE) to include remaining two slave interrupts. Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH v1 5/6] i2c: iproc: handle master read request

2020-10-11 Thread Rayagonda Kokatanur
Handle single or multi byte master read request with or without repeated start. Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 215 +++-- 1 fi

Re: [PATCH v3 5/6] i2c: iproc: handle master read request

2020-12-19 Thread Rayagonda Kokatanur
On Fri, Dec 18, 2020 at 12:41 AM Ray Jui wrote: > > > > On 12/16/2020 8:08 PM, Rayagonda Kokatanur wrote: > > On Wed, Dec 2, 2020 at 11:14 PM Ray Jui wrote: > >> > >> > >> > >> On 12/2/2020 6:35 AM, Wolfram Sang wrote: > >>> >

Re: [PATCH v3 5/6] i2c: iproc: handle master read request

2020-12-16 Thread Rayagonda Kokatanur
On Wed, Dec 2, 2020 at 11:14 PM Ray Jui wrote: > > > > On 12/2/2020 6:35 AM, Wolfram Sang wrote: > > > >> All review comments are scattered now, please let me know what has to be > >> done further, > >> Are we going to change the tasklet to irq thread ? > >> Are we going to remove batching 64

Re: [PATCH v1 4/6] i2c: iproc: fix typo in slave_isr function

2020-10-26 Thread Rayagonda Kokatanur
On Fri, Oct 23, 2020 at 10:51 PM Ray Jui wrote: > > > > On 10/11/2020 11:22 AM, Rayagonda Kokatanur wrote: > > Fix typo in bcm_iproc_i2c_slave_isr(). > > > > Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for > > slave mode") &g

Re: [PATCH v1 5/6] i2c: iproc: handle master read request

2020-10-26 Thread Rayagonda Kokatanur
On Fri, Oct 23, 2020 at 10:56 PM Ray Jui wrote: > > > > On 10/13/2020 10:12 PM, Rayagonda Kokatanur wrote: > > > > > > On Wed, Oct 14, 2020 at 8:50 AM Dhananjay Phadke > > mailto:dpha...@linux.microsoft.com>> wrote: > > > > On Sun,

Re: [PATCH v1 6/6] i2c: iproc: handle rx fifo full interrupt

2020-10-26 Thread Rayagonda Kokatanur
Hi Dhanajay, On Fri, Oct 23, 2020 at 11:12 PM Ray Jui wrote: > > > > On 10/12/2020 3:03 PM, Dhananjay Phadke wrote: > > From: Rayagonda Kokatanur > > > > On Sun, 11 Oct 2020 23:52:54 +0530, Rayagonda Kokatanur wrote: > >> Add code to handle IS_S_

[PATCH v2 2/6] i2c: iproc: handle only slave interrupts which are enabled

2020-10-30 Thread Rayagonda Kokatanur
is set and enabled. Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm-

[PATCH v2 0/6] fix iproc driver to handle master read request

2020-10-30 Thread Rayagonda Kokatanur
This series of patches adds the following, - Handle master abort error - Fix support for single/multi byte master read request with/without repeated start. - Handle rx fifo full interrupt - Fix typo Changes from V1: --Address review comments from Ray Jui, Remove fixes tag Rayagonda Kokatanur

[PATCH v2 3/6] i2c: iproc: update slave isr mask (ISR_MASK_SLAVE)

2020-10-30 Thread Rayagonda Kokatanur
Update slave isr mask (ISR_MASK_SLAVE) to include remaining two slave interrupts. Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH v2 1/6] i2c: iproc: handle Master aborted error

2020-10-30 Thread Rayagonda Kokatanur
Handle Master aborted error by flushing tx and rx fifo and reinitializing the hw. Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c

[PATCH v2 6/6] i2c: iproc: handle rx fifo full interrupt

2020-10-30 Thread Rayagonda Kokatanur
ore than 64 bytes. Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index 22e04055b447..cceaf69279a9 100

[PATCH v2 4/6] i2c: iproc: fix typo in slave_isr function

2020-10-30 Thread Rayagonda Kokatanur
Fix typo in bcm_iproc_i2c_slave_isr(). Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index cd687696bf0b..7a235f9f5884 100644

[PATCH v2 5/6] i2c: iproc: handle master read request

2020-10-30 Thread Rayagonda Kokatanur
Handle single or multi byte master read request with or without repeated start. Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 215 +++-- 1 fi

Re: [PATCH v3 5/6] i2c: iproc: handle master read request

2020-11-09 Thread Rayagonda Kokatanur
Hi Ray, Could you please check Dhananjay comments and update your thoughts. On Fri, Nov 6, 2020 at 11:11 PM Dhananjay Phadke wrote: > > On Thu, 5 Nov 2020 15:13:04 +0530, Rayagonda Kokatanur wrote: > >> So the suggestion was to set HW threshold for rx fifo interrupt, not &

[PATCH v1 1/1] i2c: iproc: Add i2c repeated start capability

2019-08-06 Thread Rayagonda Kokatanur
followed by a read. Signed-off-by: Lori Hikichi Signed-off-by: Rayagonda Kokatanur Signed-off-by: Icarus Chau Signed-off-by: Ray Jui Signed-off-by: Shivaraj Shetty --- drivers/i2c/busses/i2c-bcm-iproc.c | 70 +++--- 1 file changed, 57 insertions(+), 13 deletions

[PATCH v1 0/2] Remove smbus quick cmd and update adapter name

2019-08-07 Thread Rayagonda Kokatanur
Hi, This patchset contains following changes: - Remove SMBUS quick command support - Update full name of dt node to adapter name Lori Hikichi (2): i2c: iproc: Stop advertising support of SMBUS quick cmd i2c: iproc: Add full name of devicetree node to adapter name

[PATCH v1 1/2] i2c: iproc: Stop advertising support of SMBUS quick cmd

2019-08-07 Thread Rayagonda Kokatanur
, even though it is present. Fixes: e6e5dd3566e0 (i2c: iproc: Add Broadcom iProc I2C Driver) Signed-off-by: Lori Hikichi Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-bcm

[PATCH v1 2/2] i2c: iproc: Add full name of devicetree node to adapter name

2019-08-07 Thread Rayagonda Kokatanur
ri Hikichi Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index 19ef2b0..183b220 100644 --- a/drivers/i2c/busses/i2c-bcm-ipr

[PATCH v1 1/1] i2c: iproc: Fix i2c master read more than 63 bytes

2019-07-24 Thread Rayagonda Kokatanur
: Extend I2C read up to 255 bytes") Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index 2c7f145..d7fd76b 100644

Re: [PATCH v3 5/6] i2c: iproc: handle master read request

2020-11-05 Thread Rayagonda Kokatanur
On Thu, Nov 5, 2020 at 1:16 PM Dhananjay Phadke wrote: > > On Wed, 4 Nov 2020 10:01:06 -0800, Ray Jui wrote: > > +#define MAX_SLAVE_RX_PER_INT 10 > > >>> > In patch [3/6], you've enabled IS_S_RX_THLD_SHIFT in slave ISR bitmask, > however it's not actually used in

Re: [PATCH v1 5/6] i2c: iproc: handle master read request

2020-10-14 Thread Rayagonda Kokatanur
On Wed, Oct 14, 2020 at 8:50 AM Dhananjay Phadke wrote: > > On Sun, 11 Oct 2020 23:52:53 +0530, Rayagonda Kokatanur wrote: > > --- a/drivers/i2c/busses/i2c-bcm-iproc.c > > +++ b/drivers/i2c/busses/i2c-bcm-iproc.c > > > > - } else if (st

Re: [PATCH v3 5/6] i2c: iproc: handle master read request

2020-11-03 Thread Rayagonda Kokatanur
On Wed, Nov 4, 2020 at 9:05 AM Florian Fainelli wrote: > > > > On 11/2/2020 10:19 PM, Dhananjay Phadke wrote: > > On Mon, 2 Nov 2020 09:24:32 +0530, Rayagonda Kokatanur wrote: > > > >> Handle single or multi byte master read request with or without >

[PATCH v3 4/6] i2c: iproc: fix typo in slave_isr function

2020-11-01 Thread Rayagonda Kokatanur
Fix typo in bcm_iproc_i2c_slave_isr(). Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index cd687696bf0b..7a235f9f5884 100644

[PATCH v3 6/6] i2c: iproc: handle rx fifo full interrupt

2020-11-01 Thread Rayagonda Kokatanur
ore than 64 bytes. Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index 22e04055b447..cceaf69279a9 100

[PATCH v3 5/6] i2c: iproc: handle master read request

2020-11-01 Thread Rayagonda Kokatanur
Handle single or multi byte master read request with or without repeated start. Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 215 +++-- 1 fi

[PATCH v3 3/6] i2c: iproc: update slave isr mask (ISR_MASK_SLAVE)

2020-11-01 Thread Rayagonda Kokatanur
Update slave isr mask (ISR_MASK_SLAVE) to include remaining two slave interrupts. Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") Signed-off-by: Rayagonda Kokatanur Acked-by: Ray Jui --- drivers/i2c/busses/i2c-bcm-iproc.c | 3 ++- 1 file

[PATCH v3 0/6] fix iproc driver to handle master read request

2020-11-01 Thread Rayagonda Kokatanur
Jui, Remove fixes tag Rayagonda Kokatanur (6): i2c: iproc: handle Master aborted error i2c: iproc: handle only slave interrupts which are enabled i2c: iproc: update slave isr mask (ISR_MASK_SLAVE) i2c: iproc: fix typo in slave_isr function i2c: iproc: handle master read request i2c

[PATCH v3 1/6] i2c: iproc: handle Master aborted error

2020-11-01 Thread Rayagonda Kokatanur
Handle Master aborted error by flushing tx and rx fifo and reinitializing the hw. Signed-off-by: Rayagonda Kokatanur Acked-by: Ray Jui --- drivers/i2c/busses/i2c-bcm-iproc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b

[PATCH v3 2/6] i2c: iproc: handle only slave interrupts which are enabled

2020-11-01 Thread Rayagonda Kokatanur
is set and enabled. Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") Signed-off-by: Rayagonda Kokatanur Acked-by: Ray Jui --- drivers/i2c/busses/i2c-bcm-iproc.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH v1 1/1] arm64: dts: Fix gpio to pinmux mapping

2019-09-09 Thread Rayagonda Kokatanur
There are total of 151 non-secure gpio (0-150) and four pins of pinmux (91, 92, 93 and 94) are not mapped to any gpio pin, hence update same in DT. Fixes: 8aa428cc1e2e ("arm64: dts: Add pinctrl DT nodes for Stingray SOC") Signed-off-by: Rayagonda Kokatanur --- arch/arm64/boot/dt

[PATCH v1 1/1] pinctrl: iproc: Add 'get_direction' support

2019-09-10 Thread Rayagonda Kokatanur
Add 'get_direction' support to the iProc GPIO driver. Signed-off-by: Rayagonda Kokatanur --- drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c index

Re: [PATCH v1 1/1] drivers: phy: sr-usb: do not use internal fsm for USB2 phy init

2020-05-19 Thread Rayagonda Kokatanur
Hi Vinod, On Tue, May 19, 2020 at 12:22 PM Vinod Koul wrote: > > On 13-05-20, 23:09, Rayagonda Kokatanur wrote: > > From: Bharat Gooty > > > > During different reboot cycles, USB PHY PLL may not always lock > > during initialization and therefore can caus

[PATCH v2 1/1] drivers: mtd: spi-nor: update read capabilities for w25q64 and s25fl064k

2020-05-29 Thread Rayagonda Kokatanur
Both w25q64 and s25fl064k nor flash support QUAD and DUAL read command, hence update the same in flash_info table. This is tested on Broadcom Stingray SoC (bcm958742t). Signed-off-by: Rayagonda Kokatanur --- Changes from v1: -Address review comments from Vignesh Raghavendra Update commit

[PATCH v1 1/1] spi: bcm-qspi: Fix BSPI QUAD and DUAL mode support when using flex mode

2019-08-06 Thread Rayagonda Kokatanur
Fix data transfer width settings based on DT field 'spi-rx-bus-width' to configure BSPI in single, dual or quad mode by using data width and not the command width. Fixes: 5f195ee7d830c ("spi: bcm-qspi: Implement the spi_mem interface") Signed-off-by: Rayagonda Kokatanur --- drivers/s

[PATCH v1 1/1] spi: bcm-qspi: Make BSPI default mode

2019-08-06 Thread Rayagonda Kokatanur
Switch back to BSPI mode after MSPI operations (write and erase) are completed. This change will keep qpsi in BSPI mode by default. Signed-off-by: Rayagonda Kokatanur --- drivers/spi/spi-bcm-qspi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi

Re: [PATCH] dmaengine: bcm-sba-raid: Handle mbox_request_channel failure

2019-09-26 Thread Rayagonda Kokatanur
Hi Vinod, Did you get chance to review this fix? Best regards, Rayagonda On Thu, Jan 10, 2019 at 11:06 PM Ray Jui wrote: > > > > On 1/9/2019 10:07 PM, Rayagonda Kokatanur wrote: > > Fix kernel NULL pointer dereference error when mbox_request_channel() > > f

[PATCH v2 1/1] i2c: iproc: Add i2c repeated start capability

2019-09-30 Thread Rayagonda Kokatanur
followed by a read. Signed-off-by: Lori Hikichi Signed-off-by: Rayagonda Kokatanur Signed-off-by: Icarus Chau Signed-off-by: Ray Jui Signed-off-by: Shivaraj Shetty --- changes from v1: - Address following review comments from Wolfarm Sang, Use i2c_8bit_addr_from_msg() api instead of decoding

Re: [PATCH v2 1/1] i2c: iproc: Add i2c repeated start capability

2019-09-30 Thread Rayagonda Kokatanur
On Sat, Sep 28, 2019 at 11:53 PM Wolfram Sang wrote: > > On Thu, Sep 26, 2019 at 10:10:08AM +0530, Rayagonda Kokatanur wrote: > > From: Lori Hikichi > > > > Enable handling of i2c repeated start. The current code > > handles a multi msg i2c transfer as sep

[PATCH V3 1/1] spi: bcm-qspi: Make BSPI default mode

2019-08-29 Thread Rayagonda Kokatanur
The spi-nor controller defaults to BSPI mode, hence switch back to its default mode after MSPI operations (write or erase) are completed. Signed-off-by: Rayagonda Kokatanur Reviewed-by: Mark Brown Reviewed-by: Kamal Dasu --- changes from V2: - Address code review comment from Mark Brown about

Re: [PATCH V2 1/1] spi: bcm-qspi: Make BSPI default mode

2019-08-29 Thread Rayagonda Kokatanur
On Thu, Aug 29, 2019 at 3:29 PM Mark Brown wrote: > > On Thu, Aug 29, 2019 at 09:46:13AM +0530, Rayagonda Kokatanur wrote: > > The spi-nor controller defaults to BSPI mode, hence switch back > > to its default mode after MSPI operations (write or erase) > > are completed.

[PATCH V2 1/1] spi: bcm-qspi: Make BSPI default mode

2019-08-28 Thread Rayagonda Kokatanur
The spi-nor controller defaults to BSPI mode, hence switch back to its default mode after MSPI operations (write or erase) are completed. Changes from V1: - Address code review comment from Mark Brown. Signed-off-by: Rayagonda Kokatanur Reviewed-by: Mark Brown Reviewed-by: Kamal Dasu

Re: [PATCH v2 1/1] i2c: iproc: Add i2c repeated start capability

2019-10-16 Thread Rayagonda Kokatanur
Hi Wolfram, Please review the patch and let me know if you still have any review comments. Best regards, Rayagonda On Thu, Oct 10, 2019 at 3:02 PM Rayagonda Kokatanur wrote: > > Hi Wolfram, > > Did you get a chance to review this patch. > > Best regards, > Rayagonda >

Re: [PATCH v2 1/1] i2c: iproc: Add i2c repeated start capability

2019-10-10 Thread Rayagonda Kokatanur
Hi Wolfram, Did you get a chance to review this patch. Best regards, Rayagonda On Mon, Sep 30, 2019 at 12:19 PM Rayagonda Kokatanur wrote: > > From: Lori Hikichi > > Enable handling of i2c repeated start. The current code > handles a multi msg i2c transfer as separate i2c bus

[PATCH v2 1/1] i2c: iproc: Add i2c repeated start capability

2019-09-25 Thread Rayagonda Kokatanur
followed by a read. Signed-off-by: Lori Hikichi Signed-off-by: Rayagonda Kokatanur Signed-off-by: Icarus Chau Signed-off-by: Ray Jui Signed-off-by: Shivaraj Shetty --- changes from v1: - Address code review comment from Wolfram Sang drivers/i2c/busses/i2c-bcm-iproc.c | 63

Re: [PATCH] i2c: iproc: fix race between client unreg and isr

2020-07-26 Thread Rayagonda Kokatanur
On Sat, Jul 25, 2020 at 3:48 PM Wolfram Sang wrote: > > > > I think the following sequence needs to be implemented to make this > > safe, i.e., after 'synchronize_irq', no further slave interrupt will be > > fired. > > > > In 'bcm_iproc_i2c_unreg_slave': > > > > 1. Set an atomic variable

Re: [PATCH] i2c: iproc: fix race between client unreg and isr

2020-07-19 Thread Rayagonda Kokatanur
mp &= ~(IE_S_ALL_INTERRUPT_MASK << > IE_S_ALL_INTERRUPT_SHIFT); > iproc_i2c_wr_reg(iproc_i2c, IE_OFFSET, tmp); > > + synchronize_irq(iproc_i2c->irq); > + iproc_i2c->slave = NULL; > + > /* Erase the slave address programmed */ > tmp = iproc_i2c_rd_reg(iproc_i2c, S_CFG_SMBUS_ADDR_OFFSET); > tmp &= ~BIT(S_CFG_EN_NIC_SMB_ADDR3_SHIFT); Looks good to me. Thank you for the patch. Reviewed-by: Rayagonda Kokatanur Regards, Rayagonda

Re: [PATCH v2 1/2] i2c: add PEC error event

2020-07-24 Thread Rayagonda Kokatanur
On Fri, Jul 24, 2020 at 1:46 AM Wolfram Sang wrote: > > On Fri, Jul 17, 2020 at 02:31:54PM +0530, Rayagonda Kokatanur wrote: > > Add new event I2C_SLAVE_PEC_ERR to list of slave events. > > This event will be used by slave bus driver to indicate > > PEC error to slave

Re: [PATCH v2 2/2] i2c: iproc: add slave pec support

2020-07-24 Thread Rayagonda Kokatanur
On Fri, Jul 24, 2020 at 1:50 AM Wolfram Sang wrote: > > > > + /* Enable partial slave HW PEC support if requested by the client */ > > + iproc_i2c->en_s_pec = !!(slave->flags & I2C_CLIENT_PEC); > > + if (iproc_i2c->en_s_pec) > > + dev_info(iproc_i2c->device, "Enable

[PATCH V1 0/2] add PEC support on slave side

2020-07-16 Thread Rayagonda Kokatanur
This patch set adds support for PEC on Slave side. Rayagonda Kokatanur (2): i2c: add PEC error event i2c: iproc: add slave pec support drivers/i2c/busses/i2c-bcm-iproc.c | 50 +++--- include/linux/i2c.h| 1 + 2 files changed, 47 insertions(+), 4

[PATCH V1 1/2] i2c: add PEC error event

2020-07-16 Thread Rayagonda Kokatanur
Add new event I2C_SLAVE_PEC_ERR to list of slave events. This event will be used by slave bus driver to indicate PEC error to slave client or backend driver. Signed-off-by: Rayagonda Kokatanur --- include/linux/i2c.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/i2c.h b

[PATCH V1 2/2] i2c: iproc: add slave pec support

2020-07-16 Thread Rayagonda Kokatanur
Iproc supports PEC computation and checking in both Master and Slave mode. This patch adds support for PEC in slave mode. Signed-off-by: Rayagonda Kokatanur --- drivers/i2c/busses/i2c-bcm-iproc.c | 50 +++--- 1 file changed, 46 insertions(+), 4 deletions(-) diff --git

Re: [PATCH V1 2/2] i2c: iproc: add slave pec support

2020-07-16 Thread Rayagonda Kokatanur
Hi Andy, On Thu, Jul 16, 2020 at 3:44 PM Andy Shevchenko wrote: > > On Thu, Jul 16, 2020 at 11:14 AM Rayagonda Kokatanur > wrote: > > > > Iproc supports PEC computation and checking in both Master > > and Slave mode. > > > > This patch adds support for PE

[PATCH v2 0/2] add PEC support on slave side

2020-07-17 Thread Rayagonda Kokatanur
This patch set adds support for PEC on Slave side. Changes from v1: -Address review comments from Andy Shevchenko Update commit message, Rewrite bcm_iproc_smbus_check_slave_pec() to remove local variable ret and type casting, Use positive condition. Rayagonda Kokatanur (2): i2c: add

[PATCH v2 1/2] i2c: add PEC error event

2020-07-17 Thread Rayagonda Kokatanur
Add new event I2C_SLAVE_PEC_ERR to list of slave events. This event will be used by slave bus driver to indicate PEC error to slave client or backend driver. Signed-off-by: Rayagonda Kokatanur --- include/linux/i2c.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/i2c.h b

[PATCH v2 2/2] i2c: iproc: add slave pec support

2020-07-17 Thread Rayagonda Kokatanur
Iproc supports PEC computation and checking in both Master and Slave mode. This patch adds support for PEC in slave mode. As per hw spec, PEC ERROR status bits are [29:28] in S_RX_OFFSET register, hence this patch corrects the S_RX_PEC_ERR_SHIFT. Signed-off-by: Rayagonda Kokatanur --- Changes

Re: [PATCH 1/1] i2c: iproc: Add multi byte read-write support for slave mode

2019-05-26 Thread Rayagonda Kokatanur
Hi All, Please review the patch and let me know your review comments if any. Best regards, Rayagonda On Wed, May 15, 2019 at 9:58 PM Rayagonda Kokatanur wrote: > > No change, it's just duplicate, please ignore first patch and review > second patch. > > Best regards > Rayago

[PATCH v1 1/1] drivers: phy: sr-usb: do not use internal fsm for USB2 phy init

2020-05-13 Thread Rayagonda Kokatanur
B PHY driver") Signed-off-by: Bharat Gooty Signed-off-by: Rayagonda Kokatanur --- drivers/phy/broadcom/phy-bcm-sr-usb.c | 55 +-- 1 file changed, 2 insertions(+), 53 deletions(-) diff --git a/drivers/phy/broadcom/phy-bcm-sr-usb.c b/drivers/phy/broadcom/phy-bcm-sr-u

Re: [PATCH v2 1/1] drivers: mtd: spi-nor: update read capabilities for w25q64 and s25fl064k

2020-07-07 Thread Rayagonda Kokatanur
On Wed, Jul 1, 2020 at 12:21 PM wrote: > > On 5/29/20 10:16 AM, Rayagonda Kokatanur wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Both w25q64 and s25fl064k nor flash support QUAD and DUAL read >

[PATCH v1 1/1] drivers: mtd: spi-nor: update read capabilities for w25q64 and s25fl064k

2020-05-20 Thread Rayagonda Kokatanur
Both w25q64 and s25fl064k nor flash support QUAD and DUAL read command, hence update the same in flash_info table. Signed-off-by: Rayagonda Kokatanur --- drivers/mtd/spi-nor/spansion.c | 3 ++- drivers/mtd/spi-nor/winbond.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 1/1] i2c: iproc: Add multi byte read-write support for slave mode

2019-05-08 Thread Rayagonda Kokatanur
Add multiple byte read-write support for slave mode. Signed-off-by: Rayagonda Kokatanur Signed-off-by: Srinath Mannam --- drivers/i2c/busses/i2c-bcm-iproc.c | 117 + 1 file changed, 53 insertions(+), 64 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm

[PATCH 1/1] i2c: iproc: Add multi byte read-write support for slave mode

2019-05-08 Thread Rayagonda Kokatanur
Add multiple byte read-write support for slave mode. Signed-off-by: Rayagonda Kokatanur Signed-off-by: Srinath Mannam --- drivers/i2c/busses/i2c-bcm-iproc.c | 117 + 1 file changed, 53 insertions(+), 64 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm

Re: [PATCH 1/1] i2c: iproc: Add multi byte read-write support for slave mode

2019-05-15 Thread Rayagonda Kokatanur
No change, it's just duplicate, please ignore first patch and review second patch. Best regards Rayagonda On Thu, May 9, 2019 at 9:58 PM Ray Jui wrote: > > Why is the email sent twice? What has changed? > > On 5/8/2019 9:21 PM, Rayagonda Kokatanur wrote: > > Add multip

Re: [PATCH v5 2/8] i2c: iproc: Add slave mode support

2019-04-02 Thread Rayagonda Kokatanur
Hi Ray/Wolfram, On Tue, Apr 2, 2019 at 3:03 AM Ray Jui wrote: > > Hi Wolfram/Rayagonda, > > On 3/27/2019 3:14 PM, Wolfram Sang wrote: > > > >> +static void bcm_iproc_i2c_slave_init( > >> +struct bcm_iproc_i2c_dev *iproc_i2c, bool need_reset) > >> +{ > >> +u32 val; > >> + > >> +if