+strncpy(netdev-name, pci_name(pdev), sizeof(netdev-name) - 1);
...
+strcpy(netdev-name, eth%d);
+retval = register_netdev(netdev);
The strcpy is unnecessary, alloc_etherdev already sets that.
The strcpy is useful. netdev-name is set as pci_name in front. So the strcpy
restores
From: David Miller [mailto:da...@davemloft.net]
Sent: Wednesday, August 15, 2012 1:33 PM
From: Ren, Cloud cj...@qca.qualcomm.com
Date: Wed, 15 Aug 2012 03:29:26 +
+ strncpy(netdev-name, pci_name(pdev), sizeof(netdev-name) - 1);
...
+ strcpy(netdev-name, eth%d);
+ retval
From: Stephen Hemminger [mailto:shemmin...@vyatta.com]
Sent: Wednesday, August 15, 2012 11:02 PM
+ strncpy(netdev-name, pci_name(pdev), sizeof(netdev-name) -
1);
...
+ strcpy(netdev-name, eth%d);
+ retval = register_netdev(netdev);
The strcpy is unnecessary,
From: Joe Perches [mailto:j...@perches.com]
Sent: Thursday, August 16, 2012 9:16 PM
Hi Cloud. Please convert this to
netdev_printk(level, hw-adpt-netdev, %pV, vaf);
I will submit a patch soon to make the __netdev_printk variant static.
Ok, thanks.
Hi Jeo
I only want to do some additional explanations to david. It makes nothing with
original patch.
Thanks
cloud
-Original Message-
From: Joe Perches [mailto:j...@perches.com]
Sent: 2012年8月9日 12:10
To: Ren, Cloud
Cc: da...@davemloft.net; net...@vger.kernel.org; linux-kernel
-Original Message-
From: David Miller [mailto:da...@davemloft.net]
Sent: 2012年8月9日 14:18
To: Ren, Cloud
Cc: j...@perches.com; net...@vger.kernel.org; linux-kernel@vger.kernel.org;
qca-linux-team; nic-devel; Huang, Xiong; hao-ran@canonical.com; Rodriguez,
Luis
Subject: Re: [PATCH] net
-Original Message-
From: Joe Perches [mailto:j...@perches.com]
Sent: Thursday, August 09, 2012 3:58 PM
On Thu, 2012-08-09 at 06:49 +, Ren, Cloud wrote:
Luis has ever asked joe for adding as a Signed-off-by. At that time
joe agreed with it.
What I replied to Luis and some qca list
>> +strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1);
>> ...
>> +strcpy(netdev->name, "eth%d");
>> +retval = register_netdev(netdev);
>
>The strcpy is unnecessary, alloc_etherdev already sets that.
The strcpy is useful. netdev->name is set as pci_name in front. So the
From: David Miller [mailto:da...@davemloft.net]
Sent: Wednesday, August 15, 2012 1:33 PM
>From: "Ren, Cloud"
>Date: Wed, 15 Aug 2012 03:29:26 +
>
>>>> + strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1);
>>>> ...
>
Hi Jeo
I only want to do some additional explanations to david. It makes nothing with
original patch.
Thanks
cloud
-Original Message-
From: Joe Perches [mailto:j...@perches.com]
Sent: 2012年8月9日 12:10
To: Ren, Cloud
Cc: da...@davemloft.net; net...@vger.kernel.org; linux-kernel
>-Original Message-
>From: David Miller [mailto:da...@davemloft.net]
>Sent: 2012年8月9日 14:18
>To: Ren, Cloud
>Cc: j...@perches.com; net...@vger.kernel.org; linux-kernel@vger.kernel.org;
>qca-linux-team; nic-devel; Huang, Xiong; hao-ran@canonical.com; Rodriguez,
>-Original Message-
>From: Joe Perches [mailto:j...@perches.com]
>Sent: Thursday, August 09, 2012 3:58 PM
>
>On Thu, 2012-08-09 at 06:49 +0000, Ren, Cloud wrote:
>> Luis has ever asked joe for adding as a Signed-off-by. At that time
>> joe agreed with it.
>
&g
From: Stephen Hemminger [mailto:shemmin...@vyatta.com]
Sent: Wednesday, August 15, 2012 11:02 PM
>> + strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) -
>1);
>> ...
>> + strcpy(netdev->name, "eth%d");
>> + retval = register_netdev(netdev);
>> >>>
>>
From: Joe Perches [mailto:j...@perches.com]
Sent: Thursday, August 16, 2012 9:16 PM
>Hi Cloud. Please convert this to
>
> netdev_printk(level, hw->adpt->netdev, "%pV", );
>
>I will submit a patch soon to make the __netdev_printk variant static.
Ok, thanks.
14 matches
Mail list logo
