Unable to change sata NCQ depth due to readonly /sys/block/sdc/device/queue_depth file

2007-06-28 Thread Roy Franz
Hi, I am unable to change the NCQ settings for a sata drive that supports it - NCQ is always on. This is due to the sysfs queue_depth file being read-only. This is on vanilla 2.6.21.5 running with Debian Etch. (Several earlier versions of the kernel had this same issue.) The drive (WD

[PATCH 6/7] Add EFI stub for ARM

2013-08-02 Thread Roy Franz
, which is not used by the zImage interface. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/arm/boot/compressed/Makefile | 18 +- arch/arm/boot/compressed/efi-header.S | 114 arch/arm/boot/compressed/efi-stub.c | 514 + arch/arm/boot/compressed

[PATCH 4/7] Add proper definitions for some EFI function pointers.

2013-08-02 Thread Roy Franz
. Signed-off-by: Roy Franz roy.fr...@linaro.org --- include/linux/efi.h | 61 +-- 1 file changed, 44 insertions(+), 17 deletions(-) diff --git a/include/linux/efi.h b/include/linux/efi.h index 51f5641..779ec8c 100644 --- a/include/linux/efi.h +++ b

[PATCH 7/7] Add config EFI_STUB for ARM

2013-08-02 Thread Roy Franz
Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/arm/Kconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 37c0f4e..192968c 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1805,6 +1805,16 @@ config UACCESS_WITH_MEMCPY

[PATCH 5/7] Add strstr to compressed string.c for ARM.

2013-08-02 Thread Roy Franz
The shared efi-stub-helper.c functions require a strstr implementation. Implementation copied from arch/x86/boot/string.c Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/arm/boot/compressed/string.c | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm/boot

[PATCH 2/7] Move common EFI stub code from x86 arch code to common location

2013-08-02 Thread Roy Franz
No code changes made, just moving functions from x86 arch directory to common location. Code is shared using #include, similar to how decompression code is shared among architectures. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86/boot/compressed/eboot.c | 442

[PATCH 0/7] RFC: EFI stub for ARM

2013-08-02 Thread Roy Franz
=df981edcb9bce00b9c5e4f3cc33f3f98bc9a2394 Roy Franz (7): EFI stub documentation updates Move common EFI stub code from x86 arch code to common location Change EFI helper APIs to be more flexible Add proper definitions for some EFI function pointers. Add strstr to compressed string.c for ARM. Add EFI stub for ARM

[PATCH 3/7] Change EFI helper APIs to be more flexible

2013-08-02 Thread Roy Franz
() efi_high_alloc(), and efi_free() * Enforce minimum pagesize alignment as expected by EFI allocate_pages(). * check for 0 size in efi_free. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86/boot/compressed/eboot.c | 46 drivers/firmware/efi/efi-stub-helper.c | 181

[PATCH 1/7] EFI stub documentation updates

2013-08-02 Thread Roy Franz
The ARM kernel also has an EFI stub which works largely the same way as the x86 stub, so move the documentation out of x86 directory and update to reflect that it is generic, and add ARM specific text. Signed-off-by: Roy Franz roy.fr...@linaro.org --- Documentation/efi-stub.txt | 78

Re: [PATCH 1/7] EFI stub documentation updates

2013-08-05 Thread Roy Franz
On Mon, Aug 5, 2013 at 7:12 AM, Dave Martin dave.mar...@arm.com wrote: On Fri, Aug 02, 2013 at 02:29:02PM -0700, Roy Franz wrote: The ARM kernel also has an EFI stub which works largely the same way as the x86 stub, so move the documentation out of x86 directory and update to reflect

Re: [PATCH 6/7] Add EFI stub for ARM

2013-08-05 Thread Roy Franz
On Mon, Aug 5, 2013 at 8:33 AM, Leif Lindholm leif.lindh...@linaro.org wrote: On Mon, Aug 05, 2013 at 03:11:49PM +0100, Dave Martin wrote: diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S index 75189f1..4c70b9e 100644 --- a/arch/arm/boot/compressed/head.S

Re: [PATCH 6/7] Add EFI stub for ARM

2013-08-05 Thread Roy Franz
diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S index 75189f1..4c70b9e 100644 --- a/arch/arm/boot/compressed/head.S +++ b/arch/arm/boot/compressed/head.S @@ -122,19 +122,106 @@ .arm@ Always enter in ARM state start:

[PATCH V2 00/17] EFI stub for ARM

2013-08-06 Thread Roy Franz
=df981edcb9bce00b9c5e4f3cc33f3f98bc9a2394 Changes since V1: * Updated head.S based on feedback from Dave Martin. ARM/THUMB switches now much cleaner. * Broke up changes to x86 and common code into more patches. 10 more patches in this series. Roy Franz (17): EFI stub documentation updates Move common

[PATCH 02/17] Move common EFI stub code from x86 arch code to common location

2013-08-06 Thread Roy Franz
No code changes made, just moving functions from x86 arch directory to common location. Code is shared using #include, similar to how decompression code is shared among architectures. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86/boot/compressed/eboot.c | 442

[PATCH 13/17] Fix types in EFI calls to match EFI function definitions.

2013-08-06 Thread Roy Franz
EFI calls can made directly on ARM, so the function pointers are directly invoked. This allows types to be checked at compile time, so here we ensure that the parameters match the function signature. Signed-off-by: Roy Franz roy.fr...@linaro.org --- drivers/firmware/efi/efi-stub-helper.c | 15

[PATCH 15/17] Add strstr to compressed string.c for ARM.

2013-08-06 Thread Roy Franz
The shared efi-stub-helper.c functions require a strstr implementation. Implementation copied from arch/x86/boot/string.c Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/arm/boot/compressed/string.c | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm/boot

[PATCH 17/17] Add config EFI_STUB for ARM to Kconfig

2013-08-06 Thread Roy Franz
Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/arm/Kconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 37c0f4e..192968c 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1805,6 +1805,16 @@ config UACCESS_WITH_MEMCPY

[PATCH 06/17] rename __get_map() to efi_get_memory_map(), add parameter to optionally return mmap key. The mmap key is required to exit EFI boot services, and allows efi_get_memory_map() to be used fo

2013-08-06 Thread Roy Franz
Signed-off-by: Roy Franz roy.fr...@linaro.org --- drivers/firmware/efi/efi-stub-helper.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/firmware/efi/efi-stub-helper.c b/drivers/firmware/efi/efi-stub-helper.c index 63e3556..cd7701f 100644

[PATCH 14/17] resolve warnings found on ARM compile

2013-08-06 Thread Roy Franz
2 unused labels 1 value computed is not used Signed-off-by: Roy Franz roy.fr...@linaro.org --- drivers/firmware/efi/efi-stub-helper.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/firmware/efi/efi-stub-helper.c b/drivers/firmware/efi/efi-stub-helper.c index

[PATCH 10/17] Renames in handle_cmdline_files() to complete generalization.

2013-08-06 Thread Roy Franz
Rename variables to be not initrd specific, as now the function loads arbitrary files. Signed-off-by: Roy Franz roy.fr...@linaro.org --- drivers/firmware/efi/efi-stub-helper.c | 92 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/drivers

[PATCH 08/17] Allow efi_free() to be called with size of 0, and do nothing in that case.

2013-08-06 Thread Roy Franz
Make efi_free() safely callable with size of 0, similar to free() being callable with NULL pointers. Remove size checks that this makes redundant. This also avoids some size checks in the ARM EFI stub code that will be added as well. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86

[PATCH 07/17] Enforce minimum alignment of 1 page on allocations. The efi_high_alloc() and efi_low_alloc() functions use the EFI_ALLOCATE_ADDRESS option to the EFI function allocate_pages(), which req

2013-08-06 Thread Roy Franz
The existing code could fail to allocate depending on allocation size, as although repeated allocation attempts were made, none were guaranteed to be page aligned. Signed-off-by: Roy Franz roy.fr...@linaro.org --- drivers/firmware/efi/efi-stub-helper.c | 14 ++ 1 file changed, 14

[PATCH 09/17] Generalize handle_ramdisks() and rename to handle_cmdline_files().

2013-08-06 Thread Roy Franz
The handle_cmdline_files now takes the option to handle as a string, and returns the loaded data through parameters, rather than taking an x86 specific setup_header structure. For ARM, this will be used to load a device tree blob in addition to initrd images. Signed-off-by: Roy Franz roy.fr

[PATCH 04/17] Rename memory allocation/free functions

2013-08-06 Thread Roy Franz
Rename them to be more similar, as low_free() could be used to free memory allocated by both high_alloc() and low_alloc(). high_alloc() - efi_high_alloc() low_alloc() - efi_low_alloc() low_free() - efi_free() Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86/boot/compressed/eboot.c

[PATCH 01/17] EFI stub documentation updates

2013-08-06 Thread Roy Franz
The ARM kernel also has an EFI stub which works largely the same way as the x86 stub, so move the documentation out of x86 directory and update to reflect that it is generic, and add ARM specific text. Signed-off-by: Roy Franz roy.fr...@linaro.org --- Documentation/efi-stub.txt | 78

[PATCH 05/17] Add minimum address parameter to efi_low_alloc()

2013-08-06 Thread Roy Franz
This allows allocations to be made low in memory while avoiding allocations at the base of memory. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86/boot/compressed/eboot.c | 11 ++- drivers/firmware/efi/efi-stub-helper.c |5 - 2 files changed, 10 insertions

[PATCH 11/17] Move EFI_READ_CHUNK_SIZE define to shared location.

2013-08-06 Thread Roy Franz
This #define is only used the the shared code, so move it there. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86/boot/compressed/eboot.h |1 - drivers/firmware/efi/efi-stub-helper.c |2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/boot

[PATCH 16/17] Add EFI stub for ARM

2013-08-06 Thread Roy Franz
, which is not used by the zImage interface. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/arm/boot/compressed/Makefile | 18 +- arch/arm/boot/compressed/efi-header.S | 114 arch/arm/boot/compressed/efi-stub.c | 514 + arch/arm/boot/compressed

[PATCH 12/17] Add proper definitions for some EFI function pointers.

2013-08-06 Thread Roy Franz
. Signed-off-by: Roy Franz roy.fr...@linaro.org --- include/linux/efi.h | 42 +- 1 file changed, 25 insertions(+), 17 deletions(-) diff --git a/include/linux/efi.h b/include/linux/efi.h index 51f5641..96bb866 100644 --- a/include/linux/efi.h +++ b/include/linux

[PATCH 03/17] Add system pointer argument to shared EFI stub related functions so they no longer use global system table pointer as they did when part of eboot.c.

2013-08-06 Thread Roy Franz
Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86/boot/compressed/eboot.c | 38 +++-- drivers/firmware/efi/efi-stub-helper.c | 96 +--- 2 files changed, 72 insertions(+), 62 deletions(-) diff --git a/arch/x86/boot/compressed/eboot.c b/arch

Re: [PATCH 03/17] Add system pointer argument to shared EFI stub related functions so they no longer use global system table pointer as they did when part of eboot.c.

2013-08-07 Thread Roy Franz
On Wed, Aug 7, 2013 at 6:08 AM, Matt Fleming m...@console-pimps.org wrote: On Tue, 06 Aug, at 08:44:59PM, Roy Franz wrote: Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86/boot/compressed/eboot.c | 38 +++-- drivers/firmware/efi/efi-stub-helper.c | 96

Re: [PATCH 04/17] Rename memory allocation/free functions

2013-08-07 Thread Roy Franz
On Wed, Aug 7, 2013 at 6:09 AM, Matt Fleming m...@console-pimps.org wrote: On Tue, 06 Aug, at 08:45:00PM, Roy Franz wrote: Rename them to be more similar, as low_free() could be used to free memory allocated by both high_alloc() and low_alloc(). high_alloc() - efi_high_alloc() low_alloc

Re: [PATCH 12/17] Add proper definitions for some EFI function pointers.

2013-08-07 Thread Roy Franz
On Wed, Aug 7, 2013 at 6:09 AM, Matt Fleming m...@console-pimps.org wrote: On Tue, 06 Aug, at 08:45:08PM, Roy Franz wrote: The x86/AMD64 EFI stubs must us a call wrapper to convert between the Linux and EFI ABIs, so void pointers are sufficient. For ARM, the ABIs are compatible, so we can

[PATCH] correct call to free_pages to specify memory size in pages, not bytes.

2013-07-24 Thread Roy Franz
in question is moved to a shared location and shared by both x86 and ARM EFI stubs. Roy Franz (1): correct call to free_pages to specify memory size in pages, not bytes. arch/x86/boot/compressed/eboot.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.7.10.4

[PATCH] correct call to free_pages to specify memory size in pages, not bytes.

2013-07-24 Thread Roy Franz
Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86/boot/compressed/eboot.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c index d606463..b7388a4 100644 --- a/arch/x86/boot/compressed/eboot.c +++ b

Re: [PATCH V3 RFC 00/16] EFI stub for ARM

2013-08-23 Thread Roy Franz
On Fri, Aug 16, 2013 at 5:16 PM, Roy Franz roy.fr...@linaro.org wrote: On Tue, Aug 13, 2013 at 10:58 AM, Roy Franz roy.fr...@linaro.org wrote: On Fri, Aug 9, 2013 at 4:26 PM, Roy Franz roy.fr...@linaro.org wrote: This patch series adds EFI stub support for the ARM architecture. Some code

Re: [PATCH 16/16] Add config EFI_STUB for ARM to Kconfig

2013-08-13 Thread Roy Franz
On Tue, Aug 13, 2013 at 6:18 AM, Dave Martin dave.mar...@arm.com wrote: On Fri, Aug 09, 2013 at 04:26:17PM -0700, Roy Franz wrote: Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/arm/Kconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/Kconfig b/arch

Re: [PATCH V3 RFC 00/16] EFI stub for ARM

2013-08-13 Thread Roy Franz
On Fri, Aug 9, 2013 at 4:26 PM, Roy Franz roy.fr...@linaro.org wrote: This patch series adds EFI stub support for the ARM architecture. Some code that was previously only used by x86/x86_64 is now shared and has been made more general. The stub for ARM is implemented in a similar manner

Re: [PATCH 15/16] Add EFI stub for ARM

2013-08-13 Thread Roy Franz
On Tue, Aug 13, 2013 at 6:44 PM, Roy Franz roy.fr...@linaro.org wrote: Thanks Dave - comments inline, and I have an updated head.S diff at the end. Roy On Tue, Aug 13, 2013 at 7:19 AM, Dave Martin dave.mar...@arm.com wrote: On Fri, Aug 09, 2013 at 04:26:16PM -0700, Roy Franz wrote

Re: [PATCH V3 RFC 00/16] EFI stub for ARM

2013-08-16 Thread Roy Franz
On Tue, Aug 13, 2013 at 10:58 AM, Roy Franz roy.fr...@linaro.org wrote: On Fri, Aug 9, 2013 at 4:26 PM, Roy Franz roy.fr...@linaro.org wrote: This patch series adds EFI stub support for the ARM architecture. Some code that was previously only used by x86/x86_64 is now shared and has been made

Re: [PATCH 2/6] Add shared update_fdt() function for ARM/ARM64

2013-10-03 Thread Roy Franz
On Thu, Oct 3, 2013 at 7:27 AM, Matt Fleming m...@console-pimps.org wrote: On Thu, 03 Oct, at 09:43:24AM, Mark Salter wrote: On Thu, 2013-10-03 at 10:52 +0100, Matt Fleming wrote: +#if defined(CONFIG_ARM) || defined(CONFIG_ARM64) +static efi_status_t update_fdt(efi_system_table_t

[PATCH] Remove redundant and incorrect memset()

2013-10-04 Thread Roy Franz
-by: Roy Franz roy.fr...@linaro.org Acked-by: Mark Salter msal...@redhat.com --- drivers/firmware/efi/efi-stub-helper.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/firmware/efi/efi-stub-helper.c b/drivers/firmware/efi/efi-stub-helper.c index cc0581d..b6bffbf 100644 --- a/drivers

[PATCH 02/17] Add proper definitions for some EFI function pointers.

2013-09-16 Thread Roy Franz
. Also add some EFI types used by EFI functions. Signed-off-by: Roy Franz roy.fr...@linaro.org Acked-by: Mark Salter msal...@redhat.com Reviewed-by: Grant Likely grant.lik...@linaro.org --- arch/x86/boot/compressed/eboot.h |8 -- include/linux/efi.h | 50

[PATCH V4 00/17] ARM EFI stub common code

2013-09-16 Thread Roy Franz
into more patches. 10 more patches in this series. Roy Franz (17): EFI stub documentation updates Add proper definitions for some EFI function pointers. Move common EFI stub code from x86 arch code to common location Add system table pointer argument to shared functions. Rename memory

[PATCH 13/17] Allow efi_free() to be called with size of 0, and do nothing in that case.

2013-09-16 Thread Roy Franz
Make efi_free() safely callable with size of 0, similar to free() being callable with NULL pointers. Remove size checks that this makes redundant. This also avoids some size checks in the ARM EFI stub code that will be added as well. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86

[PATCH 10/17] Rename __get_map() to efi_get_memory_map()

2013-09-16 Thread Roy Franz
Rename function in preparation for making it more flexible and sharing it. Signed-off-by: Roy Franz roy.fr...@linaro.org --- drivers/firmware/efi/efi-stub-helper.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/firmware/efi/efi-stub-helper.c b/drivers

[PATCH 12/17] use efi_get_memory_map() to get final map for x86

2013-09-16 Thread Roy Franz
Replace the open-coded memory map getting with the efi_get_memory_map() that is now general enough to use. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86/boot/compressed/eboot.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/arch/x86

[PATCH 08/17] Generalize relocate_kernel() for use by other architectures.

2013-09-16 Thread Roy Franz
kernel, and needs to allocate space for BSS. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86/boot/compressed/eboot.c | 12 -- drivers/firmware/efi/efi-stub-helper.c | 74 ++-- 2 files changed, 60 insertions(+), 26 deletions(-) diff --git a/arch

[PATCH 16/17] Fix types in EFI calls to match EFI function definitions.

2013-09-16 Thread Roy Franz
on native width as specified by the EFI_FILE_PROTOCOL read() function. Signed-off-by: Roy Franz roy.fr...@linaro.org --- drivers/firmware/efi/efi-stub-helper.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/firmware/efi/efi-stub-helper.c b/drivers

[PATCH 17/17] resolve warnings found on ARM compile

2013-09-16 Thread Roy Franz
warnings from gcc: warning: label 'free_pool' defined but not used [-Wunused-label] warning: value computed is not used [-Wunused-value] Signed-off-by: Roy Franz roy.fr...@linaro.org --- drivers/firmware/efi/efi-stub-helper.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH 14/17] Generalize handle_ramdisks() and rename to handle_cmdline_files().

2013-09-16 Thread Roy Franz
The handle_cmdline_files now takes the option to handle as a string, and returns the loaded data through parameters, rather than taking an x86 specific setup_header structure. For ARM, this will be used to load a device tree blob in addition to initrd images. Signed-off-by: Roy Franz roy.fr

[PATCH 15/17] Renames in handle_cmdline_files() to complete generalization.

2013-09-16 Thread Roy Franz
Rename variables to be not initrd specific, as now the function loads arbitrary files. This change is exclusively renames and comment changes to reflect the generalization. Signed-off-by: Roy Franz roy.fr...@linaro.org Acked-by: Mark Salter msal...@redhat.com Reviewed-by: Grant Likely grant.lik

[PATCH 06/17] Enforce minimum alignment of 1 page on allocations.

2013-09-16 Thread Roy Franz
allocation attempts were made, none were guaranteed to be page aligned. Signed-off-by: Roy Franz roy.fr...@linaro.org Acked-by: Mark Salter msal...@redhat.com Reviewed-by: Grant Likely grant.lik...@linaro.org --- drivers/firmware/efi/efi-stub-helper.c | 14 ++ 1 file changed, 14

[PATCH 07/17] Move relocate_kernel() to shared file.

2013-09-16 Thread Roy Franz
The relocate_kernel() function will be generalized and used by all architectures, as they all have similar requirements. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86/boot/compressed/eboot.c | 34 --- drivers/firmware/efi/efi-stub-helper.c | 35

[PATCH 11/17] generalize efi_get_memory_map()

2013-09-16 Thread Roy Franz
Add arguments for returning the descriptor version and also the memory map key. The key is required for calling exit_boot_services(). Signed-off-by: Roy Franz roy.fr...@linaro.org --- drivers/firmware/efi/efi-stub-helper.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions

[PATCH 05/17] Rename memory allocation/free functions

2013-09-16 Thread Roy Franz
Rename them to be more similar, as low_free() could be used to free memory allocated by both high_alloc() and low_alloc(). high_alloc() - efi_high_alloc() low_alloc() - efi_low_alloc() low_free() - efi_free() Signed-off-by: Roy Franz roy.fr...@linaro.org Acked-by: Mark Salter msal

[PATCH 09/17] Move unicode to ASCII conversion to shared function.

2013-09-16 Thread Roy Franz
line and device tree. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86/boot/compressed/eboot.c | 43 --- drivers/firmware/efi/efi-stub-helper.c | 58 2 files changed, 64 insertions(+), 37 deletions(-) diff --git a/arch/x86

[PATCH 01/17] EFI stub documentation updates

2013-09-16 Thread Roy Franz
Move efi-stub.txt out of x86 directory and into common directory in preparation for adding ARM EFI stub support. Signed-off-by: Roy Franz roy.fr...@linaro.org --- Documentation/efi-stub.txt | 65 Documentation/x86/efi-stub.txt | 65

[PATCH 03/17] Move common EFI stub code from x86 arch code to common location

2013-09-16 Thread Roy Franz
No code changes made, just moving functions and #define from x86 arch directory to common location. Code is shared using #include, similar to how decompression code is shared among architectures. Signed-off-by: Roy Franz roy.fr...@linaro.org Acked-by: Mark Salter msal...@redhat.com Reviewed

[PATCH 04/17] Add system table pointer argument to shared functions.

2013-09-16 Thread Roy Franz
stub fixup its GOT, which is shared with the decompressor, simplifies the relocating of the zImage to a bootable address. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/x86/boot/compressed/eboot.c | 38 +++-- drivers/firmware/efi/efi-stub-helper.c | 96

Re: [PATCH 08/17] Generalize relocate_kernel() for use by other architectures.

2013-09-18 Thread Roy Franz
On Wed, Sep 18, 2013 at 5:12 AM, Matt Fleming m...@console-pimps.org wrote: On Mon, 16 Sep, at 09:11:24PM, Roy Franz wrote: Rename relocate_kernel() to efi_relocate_kernel(), and take parameters rather than x86 specific structure. Add max_addr argument as for ARM we have some address

Re: [PATCH 09/17] Move unicode to ASCII conversion to shared function.

2013-09-18 Thread Roy Franz
On Wed, Sep 18, 2013 at 8:44 PM, Adam Borowski kilob...@angband.pl wrote: On Mon, Sep 16, 2013 at 09:11:25PM -0700, Roy Franz wrote: +/* Convert the unicode UEFI command line to ASCII to pass to kernel. + * Size of memory allocated return in *cmd_line_len. + * Returns NULL on error

[PATCH V5 3/6] Add strstr to compressed string.c for ARM.

2013-11-27 Thread Roy Franz
The shared efi-stub-helper.c functions require a strstr implementation. Implementation copied from arch/x86/boot/string.c Signed-off-by: Roy Franz roy.fr...@linaro.org Reviewed-by: Grant Likely grant.lik...@linaro.org --- arch/arm/boot/compressed/string.c | 21 + 1 file

[PATCH V5 6/6] Add config EFI_STUB for ARM to Kconfig

2013-11-27 Thread Roy Franz
Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/arm/Kconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index a1b4758..6601985 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1857,6 +1857,16 @@ config EFI

[PATCH V5 4/6] Add EFI stub for ARM

2013-11-27 Thread Roy Franz
-off-by: Roy Franz roy.fr...@linaro.org --- arch/arm/boot/compressed/Makefile | 15 +- arch/arm/boot/compressed/efi-header.S | 117 + arch/arm/boot/compressed/efi-stub.c | 291 + arch/arm/boot/compressed/efi-stub.h |5 + arch/arm/boot

[PATCH V5 5/6] Disable stack protection for decompressor/stub

2013-11-27 Thread Roy Franz
-stack-protector. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/arm/boot/compressed/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile index c0c7fee..7974791 100644 --- a/arch/arm/boot

[PATCH V5 0/6] Add ARM EFI stub

2013-11-27 Thread Roy Franz
of prints, and reviewed all messages. * Change mixed usage of dtb/fdt to all be fdt or device tree in efi-stub.c * remove unnecessary zimage_size variable from relocate_kernel() * correct return types on EFI functions - should be efi_status_t, not int. Roy Franz (6): efi-stub.txt updates for ARM Add

[PATCH V5 2/6] Add shared update_fdt() function for ARM/ARM64

2013-11-27 Thread Roy Franz
allocation type for memory map to EFI_RUNTIME_SERVICES_DATA, since we are passing this buffer to the kernel, or immediately freeing it. Signed-off-by: Roy Franz roy.fr...@linaro.org --- drivers/firmware/efi/efi-stub-helper.c |9 ++- drivers/firmware/efi/fdt.c | 115

[PATCH V5 1/6] efi-stub.txt updates for ARM

2013-11-27 Thread Roy Franz
Update efi-stub.txt documentation to be more general and not x86 specific. Add ARM only dtb= command line option description. Signed-off-by: Roy Franz roy.fr...@linaro.org --- Documentation/efi-stub.txt | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff

Re: [PATCH V5 2/6] Add shared update_fdt() function for ARM/ARM64

2013-12-02 Thread Roy Franz
On Mon, Dec 2, 2013 at 6:56 AM, Mark Salter msal...@redhat.com wrote: On Fri, 2013-11-29 at 11:30 +, Matt Fleming wrote: /* * Add an additional efi_memory_desc_t because we're doing an * allocation which may be in a new descriptor region. + * We allocate as

Re: [PATCH 1/3] arm64: add EFI stub

2013-12-03 Thread Roy Franz
On Tue, Dec 3, 2013 at 10:38 AM, Will Deacon will.dea...@arm.com wrote: Hi Mark, Roy, On Fri, Nov 29, 2013 at 10:05:10PM +, Mark Salter wrote: This patch adds PE/COFF header fields to the start of the Image so that it appears as an EFI application to EFI firmware. An EFI stub is included

Re: [PATCH V5 2/6] Add shared update_fdt() function for ARM/ARM64

2013-12-05 Thread Roy Franz
On Thu, Dec 5, 2013 at 11:24 AM, Grant Likely grant.lik...@linaro.org wrote: On Wed, 27 Nov 2013 15:31:51 -0800, Roy Franz roy.fr...@linaro.org wrote: Both ARM and ARM64 stubs will update the device tree that they pass to the kernel. In both cases they primarily need to add the same UEFI

Re: [PATCH V5 4/6] Add EFI stub for ARM

2013-12-05 Thread Roy Franz
On Thu, Dec 5, 2013 at 12:00 PM, Grant Likely grant.lik...@linaro.org wrote: On Wed, 27 Nov 2013 15:31:53 -0800, Roy Franz roy.fr...@linaro.org wrote: This patch adds EFI stub support for the ARM Linux kernel. The EFI stub operates similarly to the x86 stub: it is a shim between the EFI

Re: [PATCH 06/22] Add helper functions used by arm/arm64

2014-03-03 Thread Roy Franz
On Mon, Mar 3, 2014 at 6:08 AM, Matt Fleming m...@console-pimps.org wrote: On Fri, 14 Feb, at 11:02:49AM, Roy Franz wrote: The get_dram_base() function is only used by arm/arm64, but there is nothing architecture specific about it, which is why I put it here to begin with. I don't feel

[PATCH V6 5/8] Add strstr to compressed string.c for ARM.

2014-01-10 Thread Roy Franz
the arch/x86/boot/string.c file used by the x86 decompressor. Signed-off-by: Roy Franz roy.fr...@linaro.org Reviewed-by: Grant Likely grant.lik...@linaro.org --- arch/arm/boot/compressed/string.c | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm/boot/compressed

[PATCH V6 0/8] Add ARM EFI stub

2014-01-10 Thread Roy Franz
on EFI functions - should be efi_status_t, not int. Roy Franz (8): efi-stub.txt updates for ARM Add shared printk wrapper for consistent prefixing Add helper function to get and convert EFI command line Add shared FDT related functions for ARM/ARM64 Add strstr to compressed string.c for ARM

[PATCH V6 2/8] Add shared printk wrapper for consistent prefixing

2014-01-10 Thread Roy Franz
Add a wrapper for printk to standardize the prefix for informational and error messages from the EFI stub. Signed-off-by: Roy Franz roy.fr...@linaro.org --- drivers/firmware/efi/efi-stub-helper.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git

[PATCH V6 8/8] Add config EFI_STUB for ARM to Kconfig

2014-01-10 Thread Roy Franz
The previous patches have added the implementation of the EFI stub functionality to the kernel, so now the Kconfig support is added to enable it. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/arm/Kconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/Kconfig

[PATCH V6 6/8] Add EFI stub for ARM

2014-01-10 Thread Roy Franz
-off-by: Roy Franz roy.fr...@linaro.org Acked-by: Grant Likely grant.lik...@linaro.org --- arch/arm/boot/compressed/Makefile | 15 ++- arch/arm/boot/compressed/efi-header.S | 117 ++ arch/arm/boot/compressed/efi-stub.c | 214 + arch/arm/boot

[PATCH V6 7/8] Disable stack protection for decompressor/stub

2014-01-10 Thread Roy Franz
-stack-protector. Signed-off-by: Roy Franz roy.fr...@linaro.org --- arch/arm/boot/compressed/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile index c0c7fee..7974791 100644 --- a/arch/arm/boot

[PATCH V6 4/8] Add shared FDT related functions for ARM/ARM64

2014-01-10 Thread Roy Franz
-off-by: Roy Franz roy.fr...@linaro.org Acked-by: Grant Likely grant.lik...@linaro.org --- drivers/firmware/efi/fdt.c | 225 1 file changed, 225 insertions(+) create mode 100644 drivers/firmware/efi/fdt.c diff --git a/drivers/firmware/efi/fdt.c b

[PATCH V6 1/8] efi-stub.txt updates for ARM

2014-01-10 Thread Roy Franz
Update efi-stub.txt documentation to be more general and not x86 specific. Add ARM only dtb= command line option description. Signed-off-by: Roy Franz roy.fr...@linaro.org Acked-by: Grant Likely grant.lik...@linaro.org --- Documentation/efi-stub.txt | 27 --- 1 file

[PATCH V6 3/8] Add helper function to get and convert EFI command line

2014-01-10 Thread Roy Franz
Add an EFI stub helper function to retrieve the EFI command line using the LOADED_IMAGE_PROTOCOL, and convert it to ASCII. This function will be shared by the various EFI stub implementations. Signed-off-by: Roy Franz roy.fr...@linaro.org --- drivers/firmware/efi/efi-stub-helper.c | 30

Re: [PATCH 4/6] arm64: add EFI stub

2014-01-14 Thread Roy Franz
On Tue, Jan 14, 2014 at 6:44 AM, Mark Salter msal...@redhat.com wrote: On Mon, 2014-01-13 at 19:49 +0100, Arnd Bergmann wrote: On Friday 10 January 2014, Mark Salter wrote: This patch adds PE/COFF header fields to the start of the Image so that it appears as an EFI application to EFI

Re: [PATCH V6 6/8] Add EFI stub for ARM

2014-01-14 Thread Roy Franz
On Tue, Jan 14, 2014 at 11:29 AM, Rob Herring robherri...@gmail.com wrote: On Fri, Jan 10, 2014 at 10:30 AM, Roy Franz roy.fr...@linaro.org wrote: This patch adds EFI stub support for the ARM Linux kernel. The EFI stub operates similarly to the x86 stub: it is a shim between the EFI firmware

Re: [PATCH V6 0/8] Add ARM EFI stub

2014-01-14 Thread Roy Franz
On Mon, Jan 13, 2014 at 7:07 AM, Matt Fleming m...@console-pimps.org wrote: On Fri, 10 Jan, at 08:30:09AM, Roy Franz wrote: This patch series adds EFI stub support for the ARM architecture. The stub for ARM is implemented in a similar manner to x86 in that it is a shim layer between EFI

Re: [PATCH V6 3/8] Add helper function to get and convert EFI command line

2014-01-14 Thread Roy Franz
On Mon, Jan 13, 2014 at 7:04 AM, Matt Fleming m...@console-pimps.org wrote: On Fri, 10 Jan, at 08:30:12AM, Roy Franz wrote: Add an EFI stub helper function to retrieve the EFI command line using the LOADED_IMAGE_PROTOCOL, and convert it to ASCII. This function will be shared by the various

Re: [PATCH 06/22] Add helper functions used by arm/arm64

2014-02-14 Thread Roy Franz
On Thu, Feb 13, 2014 at 3:26 AM, Matt Fleming m...@console-pimps.org wrote: On Wed, 05 Feb, at 05:03:57PM, Leif Lindholm wrote: From: Roy Franz roy.fr...@linaro.org Add the get_dram_base() function and efi_call_physN() macros that are shared by arm/arm64. Signed-off-by: Roy Franz roy.fr

Re: [PATCH v2 11/15] arm64: add EFI stub

2014-03-18 Thread Roy Franz
On Tue, Mar 18, 2014 at 2:40 PM, Mark Salter msal...@redhat.com wrote: On Tue, 2014-03-18 at 18:28 +, Catalin Marinas wrote: On Tue, Mar 18, 2014 at 02:40:29PM +, Mark Salter wrote: On Tue, 2014-03-18 at 12:09 +, Catalin Marinas wrote: On Thu, Mar 13, 2014 at 10:47:04PM +,

Re: [PATCH v2 06/13] x86/efi: Build our own EFI services pointer table

2014-03-21 Thread Roy Franz
On Tue, Mar 4, 2014 at 5:14 AM, Matt Fleming m...@console-pimps.org wrote: From: Matt Fleming matt.flem...@intel.com It's not possible to dereference the EFI System table directly when booting a 64-bit kernel on a 32-bit EFI firmware because the size of pointers don't match. In preparation

Re: [PATCH v2 06/13] x86/efi: Build our own EFI services pointer table

2014-03-22 Thread Roy Franz
On Sat, Mar 22, 2014 at 4:05 AM, Matt Fleming m...@console-pimps.org wrote: On Fri, 21 Mar, at 05:52:29PM, Roy Franz wrote: For both arm32 and arm64 the Linux and EFI calling conventions are the same, so we are directly invoking the function pointers in the boot_services table. This gives us

Re: [PATCH 14/16] Add strstr to compressed string.c for ARM.

2013-08-30 Thread Roy Franz
On Fri, Aug 30, 2013 at 7:02 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Fri, Aug 30, 2013 at 2:47 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Aug 30, 2013 at 02:43:25PM +0100, Grant Likely wrote: On Fri, 9 Aug 2013 16:26:15 -0700, Roy Franz roy.fr

Re: [PATCH 02/16] Add system pointer argument to shared EFI stub related functions so they no longer use global system table pointer as they did when part of eboot.c. This code is now shared, so using

2013-08-30 Thread Roy Franz
On Fri, Aug 30, 2013 at 5:53 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Fri, 9 Aug 2013 16:26:03 -0700, Roy Franz roy.fr...@linaro.org wrote: Signed-off-by: Roy Franz roy.fr...@linaro.org The entire commit message is contained in the subject line! The first line of a commit message

Re: [PATCH 04/16] Add minimum address parameter to efi_low_alloc()

2013-08-30 Thread Roy Franz
On Fri, Aug 30, 2013 at 6:01 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Fri, 9 Aug 2013 16:26:05 -0700, Roy Franz roy.fr...@linaro.org wrote: This allows allocations to be made low in memory while avoiding allocations at the base of memory. Your commit message should include /why

Re: [PATCH 10/16] Move EFI_READ_CHUNK_SIZE define to shared location.

2013-08-30 Thread Roy Franz
On Fri, Aug 30, 2013 at 6:33 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Fri, 9 Aug 2013 16:26:11 -0700, Roy Franz roy.fr...@linaro.org wrote: This #define is only used the the shared code, so move it there. Signed-off-by: Roy Franz roy.fr...@linaro.org Can this be squashed

Re: [PATCH 12/16] Fix types in EFI calls to match EFI function definitions.

2013-08-30 Thread Roy Franz
On Fri, Aug 30, 2013 at 6:39 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Fri, 9 Aug 2013 16:26:13 -0700, Roy Franz roy.fr...@linaro.org wrote: EFI calls can made directly on ARM, so the function pointers are directly invoked. This allows types to be checked at compile time, so here

Re: [PATCH 12/16] Fix types in EFI calls to match EFI function definitions.

2013-08-30 Thread Roy Franz
On Fri, Aug 30, 2013 at 4:14 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Sat, Aug 31, 2013 at 12:12 AM, Roy Franz roy.fr...@linaro.org wrote: On Fri, Aug 30, 2013 at 6:39 AM, Grant Likely grant.lik...@secretlab.ca wrote: I think you need some description in the commit text about why

Re: [PATCH 15/16] Add EFI stub for ARM

2013-08-30 Thread Roy Franz
On Fri, Aug 30, 2013 at 7:36 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Fri, 9 Aug 2013 16:26:16 -0700, Roy Franz roy.fr...@linaro.org wrote: This patch adds EFI stub support for the ARM Linux kernel. The EFI stub operations similarly to the x86 stub: it is a shim between the EFI

Re: [PATCH V3 RFC 00/16] EFI stub for ARM

2013-09-02 Thread Roy Franz
On Mon, Sep 2, 2013 at 3:33 AM, Matt Fleming m...@console-pimps.org wrote: On Tue, 13 Aug, at 10:58:16AM, Roy Franz wrote: Hi Matt, Do you have any more feedback on the X86 and common code (patches 1-13) that needs to be addressed? Mark Salter has a working ARM64 EFI stub implemented

Re: [PATCH 09/17] Move unicode to ASCII conversion to shared function.

2013-09-21 Thread Roy Franz
On Fri, Sep 20, 2013 at 8:00 AM, H. Peter Anvin h...@zytor.com wrote: On 09/20/2013 04:27 AM, Matt Fleming wrote: On Wed, 18 Sep, at 09:48:44PM, Roy Franz wrote: Would it be acceptable to fix the naming/comments, and convert values above 126 to '?' in the current patchset, and address a more

  1   2   3   4   >