[PATCH V2] staging: ks7010: Fix warnings on printk() usage

2016-09-26 Thread Sabitha George
This patch fixes the following warnings on ks7010_sdio.c 1. printk() should include KERN_ facility level 2. Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks7010_sdio.c

[PATCH] staging: ks7010: fix coding style issues in ks7010_sdio.c

2016-09-01 Thread Sabitha George
generally useful 5) "foo * bar" should be "foo *bar" 6) Code indent should use tabs where possible 7) printk() should include KERN_ facility level Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks7010_sdio.c | 107 ++- 1 file ch

[PATCH 1/2] staging: ks7010: Replace asm/uaccess.h and asm/atomic.h

2016-10-10 Thread Sabitha George
Replaces inclusion of asm/uaccess.h with linux/uaccess.h and asm/atomic.h with linux/atomic.h in ks_wlan_net.c Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_wlan_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b

[PATCH 2/2] staging: ks7010: Fixes error "foo * bar should be foo *bar"

2016-10-10 Thread Sabitha George
Fixes checkpatch warning on ks_wlan_net.c: foo * bar should be foo *bar Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_wlan_net.c | 64 ++-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b

[PATCH 1/2] staging: ks7010: Replace __attribute__(aligned(x)) with __aligned(x)

2016-10-13 Thread Sabitha George
Fixes checkpatch.pl warning: __aligned(size) is preferred over __attribute__((aligned(size)) in ks7010_sdio.h Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks7010_sdio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b

[PATCH 2/2] staging: ks7010: Fixes warning :do not add new typedefs

2016-10-13 Thread Sabitha George
Fixes checkpatch.pl warning: do not add new typedefs in ks_wlan_net.c Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_wlan_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c

[PATCH 1/3] staging:ks7010: use __packed instead of __attribute__((packed))

2016-10-08 Thread Sabitha George
This patch fixes the below checkpatch warning in ks_hostif.c: __packed is preferred over __attribute__((packed)) Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_hostif.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c

[PATCH 3/3] staging: ks7010: Replace header files

2016-10-08 Thread Sabitha George
This patch replaces inclusion of asm/atomic.h with linux/atomic.h and asm/io.h with linux/io.h to fix checkpatch warning in ks_wlan.h Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_wlan.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010

[PATCH 2/3] staging: ks7010: use netdev_* instead of printk()

2016-10-08 Thread Sabitha George
Fixes checkpatch warning on printk usage in ks_hostif.c Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_hostif.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010

[PATCH V2] staging: ks7010: use netdev_* instead of printk()

2016-10-09 Thread Sabitha George
Fixes checkpatch warning on printk usage in ks_hostif.c Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_hostif.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c

[PATCH V3] staging: ks7010: use netdev_* instead of printk()

2016-10-09 Thread Sabitha George
1. Fixes checkpatch warning on printk usage in ks_hostif.c 2. Dropped "ks_wlan" prefix from the messages 3. Removed the "Memory squeeze,dropping packet" messages Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_hostif.c | 23 ++- 1 file ch

[PATCH V4] staging: ks7010: use netdev_* instead of printk()

2016-10-09 Thread Sabitha George
1. Fixes checkpatch warning on printk usage in ks_hostif.c 2. Dropped "ks_wlan" prefix from the messages 3. Removed the "Memory squeeze,dropping packet" messages Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_hostif.c | 22 +- 1 file changed,

[PATCH 1/2] staging: ks7010: Add blank line after declarations

2016-10-16 Thread Sabitha George
Fixes checkpatch.pl warning :Missing a blank line after declarations Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_hostif.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 1f9f63e..ad840f9

[PATCH 2/2] staging: ks7010: Remove braces around single statement blocks

2016-10-16 Thread Sabitha George
Fixes checkpatch warning: braces{} are not necessary for single statment blocks Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_hostif.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging

[PATCH 1/5] staging: ks7010: Fix coding style warning in ks7010_sdio.c

2016-09-03 Thread Sabitha George
This patch fixes the coding style warning ' braces {} are not necessary for single statement blocks' found by checkpatch.pl Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks7010_sdio.c | 41 +++- 1 file changed, 17 insertions(+), 24 deletion

[PATCH 5/5] staging: ks7010: Fix missing blankline after declarations

2016-09-03 Thread Sabitha George
This patch fixes the checkpatch.pl warning of the missing blank line after declarations in ks7010_sdio.c Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks7010_sdio.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging

[PATCH 2/5] staging: ks7010:Fix warning on return for void functions

2016-09-03 Thread Sabitha George
This patch fixes the checkpatch warning in ksdio_sdio.c 'void function return statements are not generally useful' Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks7010_sdio.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/ks7010/ks7010

[PATCH 3/5] staging: ks7010: Remove redundant null pointer check prior to kfree()

2016-09-03 Thread Sabitha George
This patch fixes the warning on ks7010_sdio.c :'kfree(NULL) is safe and this check is probably not required' Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks7010_sdio.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/stag

[PATCH 4/5] staging: ks7010: Fix warnings on printk() usage

2016-09-03 Thread Sabitha George
This patch fixes the following warnings on ks7010_sdio.c 1. printk() should include KERN_ facility level 2. Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks7010_sdio.c