[PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Sasha Levin
This hashtable implementation is using hlist buckets to provide a simple hashtable to prevent it from getting reimplemented all over the kernel. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- Changes from v8: - Addressed comments from Tejun Heo and Mathieu Desnoyers. include/linux

[PATCH v8 03/16] mm,ksm: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch ksm to use the new hashtable implementation. This reduces the amount of generic unrelated code in the ksm module. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- mm/ksm.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/mm/ksm.c

[PATCH v8 04/16] workqueue: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch workqueues to use the new hashtable implementation. This reduces the amount of generic unrelated code in the workqueues. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- kernel/workqueue.c | 86 ++ 1 file changed, 15 insertions

[PATCH v8 06/16] tracepoint: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch tracepoints to use the new hashtable implementation. This reduces the amount of generic unrelated code in the tracepoints. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- kernel/tracepoint.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff

[PATCH v8 07/16] net,9p: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch 9p error table to use the new hashtable implementation. This reduces the amount of generic unrelated code in 9p. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- net/9p/error.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/net/9p/error.c

[PATCH v8 08/16] block,elevator: use new hashtable implementation

2012-10-30 Thread Sasha Levin
accessing it. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- block/blk.h | 2 +- block/elevator.c | 23 --- include/linux/elevator.h | 5 - 3 files changed, 9 insertions(+), 21 deletions(-) diff --git a/block/blk.h b/block/blk.h index ca51543

[PATCH v8 09/16] SUNRPC/cache: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch cache to use the new hashtable implementation. This reduces the amount of generic unrelated code in the cache implementation. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- net/sunrpc/cache.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git

[PATCH v8 10/16] dlm: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch dlm to use the new hashtable implementation. This reduces the amount of generic unrelated code in the dlm. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- fs/dlm/lowcomms.c | 53 ++--- 1 file changed, 18 insertions(+), 35 deletions

[PATCH v8 11/16] net,l2tp: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch l2tp to use the new hashtable implementation. This reduces the amount of generic unrelated code in l2tp. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- net/l2tp/l2tp_core.c| 140 +++- net/l2tp/l2tp_core.h| 15 -- net/l2tp

[PATCH v8 12/16] dm: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch dm to use the new hashtable implementation. This reduces the amount of generic unrelated code in the dm. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- drivers/md/dm-snap.c | 24 + drivers/md/persistent-data/dm-block-manager.c

[PATCH v8 02/16] userns: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch to using the new hashtable implementation to store user structs. This reduces the amount of generic unrelated code in kernel/user.c. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- kernel/user.c | 33 - 1 file changed, 12 insertions(+), 21 deletions

[PATCH v8 14/16] net,rds: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch rds to use the new hashtable implementation. This reduces the amount of generic unrelated code in rds. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- net/rds/bind.c | 20 +-- net/rds/connection.c | 100 ++- 2 files

[PATCH v8 16/16] tracing output: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch tracing to use the new hashtable implementation. This reduces the amount of generic unrelated code in the tracing module. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- kernel/trace/trace_output.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff

[PATCH v8 15/16] openvswitch: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch openvswitch to use the new hashtable implementation. This reduces the amount of generic unrelated code in openvswitch. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- net/openvswitch/vport.c | 35 --- 1 file changed, 12 insertions(+), 23 deletions

[PATCH v8 13/16] lockd: use new hashtable implementation

2012-10-30 Thread Sasha Levin
Switch lockd to use the new hashtable implementation. This reduces the amount of generic unrelated code in lockd. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- fs/lockd/svcsubs.c | 58 ++ 1 file changed, 28 insertions(+), 30 deletions

[PATCH v8 05/16] mm/huge_memory: use new hashtable implementation

2012-10-30 Thread Sasha Levin
it. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- mm/huge_memory.c | 53 - 1 file changed, 12 insertions(+), 41 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 3c14a96..4b32238 100644 --- a/mm/huge_memory.c +++ b/mm

Re: [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Sasha Levin
On Tue, Oct 30, 2012 at 5:42 PM, Tejun Heo t...@kernel.org wrote: Hello, Just some nitpicks. On Tue, Oct 30, 2012 at 02:45:57PM -0400, Sasha Levin wrote: +/* Use hash_32 when possible to allow for fast 32bit hashing in 64bit kernels. */ +#define hash_min(val, bits

Re: [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Sasha Levin
On Tue, Oct 30, 2012 at 8:51 PM, Jim Rees r...@umich.edu wrote: Sasha Levin wrote: On Tue, Oct 30, 2012 at 5:42 PM, Tejun Heo t...@kernel.org wrote: Hello, Just some nitpicks. On Tue, Oct 30, 2012 at 02:45:57PM -0400, Sasha Levin wrote: +/* Use hash_32 when possible

Re: [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-10-30 Thread Sasha Levin
Hi Linus, But whatever. This series has gotten way too much bike-shedding anyway. I think it should just be applied, since it does remove lines of code overall. I'd even possibly apply it to mainline, but it seems to be against linux-next. Yup, I switched to using -next because I've been

Re: [PATCH v11] kvm: notify host when the guest is panicked

2012-10-30 Thread Sasha Levin
On Tue, Oct 30, 2012 at 9:48 PM, Wen Congyang we...@cn.fujitsu.com wrote: At 10/31/2012 09:12 AM, Marcelo Tosatti Wrote: It has been asked earlier why a simple virtio device is not usable for this (with no response IIRC). 1. We can't use virtio device when the kernel is booting. So the issue

Re: [PATCH 21/21] TTY: move tty buffers to tty_port

2012-10-31 Thread Sasha Levin
On Wed, Oct 31, 2012 at 8:53 AM, Jiri Slaby jsl...@suse.cz wrote: On 10/25/2012 08:02 PM, Sasha Levin wrote: Fuzzing with trinity inside a KVM tools (lkvm) guest with -next kernel uncovered the following warning: I cannot reproduce that :(. Do you still see it? Yes, it reproduces pretty

Re: [patch for-3.7] mm, mempolicy: fix printing stack contents in numa_maps

2012-10-31 Thread Sasha Levin
On Fri, Oct 26, 2012 at 4:48 AM, Peter Zijlstra pet...@infradead.org wrote: On Thu, 2012-10-25 at 16:09 -0700, Linus Torvalds wrote: On Thu, Oct 25, 2012 at 7:39 AM, Peter Zijlstra pet...@infradead.org wrote: So I think the below should work, we hold the spinlock over both rb-tree

Re: [PATCH 21/21] TTY: move tty buffers to tty_port

2012-10-31 Thread Sasha Levin
On 10/31/2012 11:32 AM, Jiri Slaby wrote: On 10/31/2012 04:30 PM, Sasha Levin wrote: On Wed, Oct 31, 2012 at 8:53 AM, Jiri Slaby jsl...@suse.cz wrote: On 10/25/2012 08:02 PM, Sasha Levin wrote: Fuzzing with trinity inside a KVM tools (lkvm) guest with -next kernel uncovered the following

[RFC] hlist: drop the node parameter from iterators

2012-11-01 Thread Sasha Levin
prettier, we also drop 400 lines. win-win? Signed-off-by: Sasha Levin sasha.le...@oracle.com --- include/linux/list.h| 46 +--- include/linux/rculist.h | 56 - 2 files changed, 47 insertions(+), 55 deletions

Re: [RFC] hlist: drop the node parameter from iterators

2012-11-01 Thread Sasha Levin
On 11/01/2012 08:59 PM, Linus Torvalds wrote: On Thu, Nov 1, 2012 at 4:06 PM, Sasha Levin sasha.le...@oracle.com wrote: I'm not sure why, but the hlist for each entry iterators were conceived differently from the list ones. While the list ones are nice and elegant: list_for_each_entry

Re: [PATCH v8 01/16] hashtable: introduce a small and naive hashtable

2012-11-01 Thread Sasha Levin
On Tue, Oct 30, 2012 at 10:23 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Tue, Oct 30, 2012 at 6:36 PM, Sasha Levin levinsasha...@gmail.com wrote: I can either rebase that on top of mainline, or we can ask maintainers to take it to their own trees if you take only 01/16

Re: [PATCH 21/21] TTY: move tty buffers to tty_port

2012-11-02 Thread Sasha Levin
On Fri, Nov 2, 2012 at 11:51 AM, Jiri Slaby jsl...@suse.cz wrote: On 10/31/2012 04:59 PM, Sasha Levin wrote: So you probably want a lot more than 100k syscalls, why limit it at all actually? I unset the limit but I still can't reproduce... I've attached my .config for the guest kernel

Re: [PATCH 21/21] TTY: move tty buffers to tty_port

2012-11-02 Thread Sasha Levin
On 11/02/2012 12:18 PM, Jiri Slaby wrote: On 11/02/2012 05:07 PM, Sasha Levin wrote: On Fri, Nov 2, 2012 at 11:51 AM, Jiri Slaby jsl...@suse.cz wrote: On 10/31/2012 04:59 PM, Sasha Levin wrote: So you probably want a lot more than 100k syscalls, why limit it at all actually? I unset

Re: [RFC] hlist: drop the node parameter from iterators

2012-11-02 Thread Sasha Levin
On 11/02/2012 04:16 PM, Linus Torvalds wrote: On Thu, Nov 1, 2012 at 7:26 PM, Sasha Levin sasha.le...@oracle.com wrote: Here are some stats: - Applying the patch from -next on top of your current git head results in 3 conflicts. - Applying the patch from your current git head on top

Re: [RFC] mm: add support for zsmalloc and zcache

2012-09-22 Thread Sasha Levin
On 09/21/2012 09:14 PM, Dan Magenheimer wrote: +#define MAX_CLIENTS 16 Seems a bit arbitrary. Why 16? Sasha Levin posted a patch to fix this but it was tied in to the proposed KVM implementation, so was never merged. My patch changed the max pools per client, not the maximum amount

Re: [RFC] mm: add support for zsmalloc and zcache

2012-09-22 Thread Sasha Levin
On 09/22/2012 03:31 PM, Sasha Levin wrote: On 09/21/2012 09:14 PM, Dan Magenheimer wrote: +#define MAX_CLIENTS 16 Seems a bit arbitrary. Why 16? Sasha Levin posted a patch to fix this but it was tied in to the proposed KVM implementation, so was never merged. My patch changed the max

Re: RCU idle CPU detection is broken in linux-next

2012-09-22 Thread Sasha Levin
On 09/22/2012 05:56 PM, Paul E. McKenney wrote: And now the prime suspect is the new CONFIG_RCU_USER_QS=y. Do these warnings ever show up with CONFIG_RCU_USER_QS=n? It seems that disabling that does make the warnings go away. I'll keep the tests running in case it just reduces the chances or

blk: NULL ptr deref in blk_dequeue_request()

2012-09-22 Thread Sasha Levin
Hi all, While fuzzing with trinity inside a KVM tools guest running the latest linux-next kernel, I've stumbled on the following BUG. I've also hit a similar trace where the 'BUG_ON(ELV_ON_HASH(rq));' above that list_del_init() gets hit, so I guess it's a race condition of some sorts. [

Re: RCU idle CPU detection is broken in linux-next

2012-09-22 Thread Sasha Levin
On 09/23/2012 02:21 AM, Paul E. McKenney wrote: On Sat, Sep 22, 2012 at 02:27:35PM -0700, Paul E. McKenney wrote: On Sat, Sep 22, 2012 at 07:50:29PM +0200, Sasha Levin wrote: On 09/22/2012 05:56 PM, Paul E. McKenney wrote: And now the prime suspect is the new CONFIG_RCU_USER_QS=y. Do

Re: RCU idle CPU detection is broken in linux-next

2012-09-24 Thread Sasha Levin
Hi Frederic, On 09/24/2012 11:29 PM, Frederic Weisbecker wrote: Sasha, Can you please test the following branch: git://github.com/fweisbec/linux-dynticks.git rcu/idle-for-v3.7-take3 with CONFIG_RCU_USER_QS and CONFIG_RCU_USER_QS_FORCE enabled. I hope this fixes the warning. The

Re: RCU idle CPU detection is broken in linux-next

2012-09-24 Thread Sasha Levin
On 09/25/2012 12:47 AM, Sasha Levin wrote: - While I no longer see the warnings I've originally noticed, if I run with Paul's last debug patch I see the following warning: Correction: Original warnings are still there, they just got buried in the huge spew that was caused by additional debug

tty ldisc lockups in linux-next

2012-09-25 Thread Sasha Levin
Hi all, While fuzzing with trinity in a KVM tools guest running linux-next kernel, I keep hitting the following lockup: [ 842.780242] INFO: task init:1 blocked for more than 120 seconds. [ 842.780732] echo 0 /proc/sys/kernel/hung_task_timeout_secs disables this message. [ 842.781559] init

Re: tty ldisc lockups in linux-next

2012-09-25 Thread Sasha Levin
On 09/25/2012 10:52 AM, Jiri Slaby wrote: Hi all, While fuzzing with trinity in a KVM tools guest running linux-next kernel, I keep hitting the following lockup: Hi, I'm confused here. Is this different to what you reported a couple days ago? Doesn't reverting aa3c8af86382 help in the

Re: tty ldisc lockups in linux-next

2012-09-25 Thread Sasha Levin
On 09/25/2012 10:56 AM, Jiri Slaby wrote: On 09/25/2012 10:55 AM, Sasha Levin wrote: On 09/25/2012 10:52 AM, Jiri Slaby wrote: Hi all, While fuzzing with trinity in a KVM tools guest running linux-next kernel, I keep hitting the following lockup: Hi, I'm confused here. Is this different

Re: RCU idle CPU detection is broken in linux-next

2012-09-25 Thread Sasha Levin
On 09/25/2012 02:06 PM, Frederic Weisbecker wrote: Sasha, sorry to burden you with more testing request. Could you please try out this new branch? It includes some fixes after Wu Fenguang and Dan Carpenter reports (not related to your warnings though) and a patch on the top of the pile to

[PATCH v6] hashtable: introduce a small and naive hashtable

2012-09-26 Thread Sasha Levin
This hashtable implementation is using hlist buckets to provide a simple hashtable to prevent it from getting reimplemented all over the kernel. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- Changes since v5: - Fix hash_init. - Clarify this implementation deals with statically

Re: [PATCH v6] hashtable: introduce a small and naive hashtable

2012-09-26 Thread Sasha Levin
On 09/26/2012 03:59 PM, Steven Rostedt wrote: On Wed, 2012-09-26 at 14:45 +0100, David Laight wrote: Amazing how something simple gets lots of comments and versions :-) ... + * This has to be a macro since HASH_BITS() will not work on pointers since + * it calculates the size during

Re: [PATCH v6] hashtable: introduce a small and naive hashtable

2012-09-27 Thread Sasha Levin
On 09/27/2012 10:25 AM, David Laight wrote: And even then, if we would do: for (i = 0; i HASH_SIZE(hashtable); i++) if (!hlist_empty(hashtable[i])) break; return i = HASH_SIZE(hashtable); What happens if the last entry of the table is non-empty ? It

[PATCH] fs: prevent use after free in auditing when symlink following was denied

2012-10-04 Thread Sasha Levin
Commit fs: add link restriction audit reporting has added auditing of failed attempts to follow symlinks. Unfortunately, the auditing was being done after the struct path structure was released earlier. Signed-off-by: Sasha Levin sasha.le...@oracle.com --- fs/namei.c | 2 +- 1 file changed, 1

[PATCH] fs: handle failed audit_log_start properly

2012-10-04 Thread Sasha Levin
audit_log_start() may return NULL, this is unchecked by the caller in audit_log_link_denied() and could cause a NULL ptr deref. Introduced by commit a51d9eaa (fs: add link restriction audit reporting). Signed-off-by: Sasha Levin sasha.le...@oracle.com --- kernel/audit.c | 2 ++ 1 file changed

[PATCH] net, bluetooth: don't attempt to free a channel that wasn't created

2012-10-04 Thread Sasha Levin
We may currently attempt to free a channel which wasn't created due to an error in the initialization path, this would cause a NULL ptr deref. Introduced in commit 61d6ef3e (Bluetooth: Make better use of l2cap_chan reference counting). Signed-off-by: Sasha Levin sasha.le...@oracle.com --- net

[PATCH] net, TTY: initialize tty-driver_data before usage

2012-10-04 Thread Sasha Levin
Commit 9c650ffc (TTY: ircomm_tty, add tty install) split _open() to _install() and _open(). It also moved the initialization of driver_data out of open(), but never added it to install() - causing a NULL ptr deref whenever the driver was used. Signed-off-by: Sasha Levin sasha.le...@oracle.com

Re: [PATCH] net, bluetooth: don't attempt to free a channel that wasn't created

2012-10-05 Thread Sasha Levin
On 10/05/2012 06:22 AM, Andrei Emeltchenko wrote: Hi Sasha, On Thu, Oct 04, 2012 at 07:59:57PM -0400, Sasha Levin wrote: We may currently attempt to free a channel which wasn't created due to an error in the initialization path, this would cause a NULL ptr deref. Please put oops dump here

vfs: oops on open_by_handle_at() in linux-next

2012-10-07 Thread Sasha Levin
Hi all, While fuzzing with trinity inside a KVM tools guest using latest linux-next, I've stumbled on the following: [ 74.082463] BUG: unable to handle kernel paging request at 880061cd3000 [ 74.087481] IP: [812190d0] shmem_alloc_inode+0x40/0x40 [ 74.090032] PGD 4e27063 PUD

Re: blk: NULL ptr deref in blk_dequeue_request()

2012-10-07 Thread Sasha Levin
Ping? I'm still seeing this on linux-next. On Sat, Sep 22, 2012 at 4:35 PM, Sasha Levin levinsasha...@gmail.com wrote: Hi all, While fuzzing with trinity inside a KVM tools guest running the latest linux-next kernel, I've stumbled on the following BUG. I've also hit a similar trace where

Re: [PATCH 21/21] TTY: move tty buffers to tty_port

2012-11-02 Thread Sasha Levin
On 11/02/2012 12:18 PM, Jiri Slaby wrote: On 11/02/2012 05:07 PM, Sasha Levin wrote: On Fri, Nov 2, 2012 at 11:51 AM, Jiri Slaby jsl...@suse.cz wrote: On 10/31/2012 04:59 PM, Sasha Levin wrote: So you probably want a lot more than 100k syscalls, why limit it at all actually? I unset

Re: mm: NULL ptr deref in anon_vma_interval_tree_verify

2012-11-02 Thread Sasha Levin
Ping? On Thu, Oct 25, 2012 at 4:26 PM, Sasha Levin levinsasha...@gmail.com wrote: On 10/18/2012 06:46 PM, Sasha Levin wrote: Hi all, While fuzzing with trinity inside a KVM tools (lkvm) guest, on today's linux-next kernel, I saw the following: [ 1857.278176] BUG: unable to handle kernel

Re: [PATCH 21/21] TTY: move tty buffers to tty_port

2012-11-03 Thread Sasha Levin
On 11/03/2012 11:55 AM, Jiri Slaby wrote: On 11/03/2012 03:03 AM, Sasha Levin wrote: On 11/02/2012 12:18 PM, Jiri Slaby wrote: On 11/02/2012 05:07 PM, Sasha Levin wrote: On Fri, Nov 2, 2012 at 11:51 AM, Jiri Slaby jsl...@suse.cz wrote: On 10/31/2012 04:59 PM, Sasha Levin wrote: So you

Re: [PATCH 21/21] TTY: move tty buffers to tty_port

2012-11-03 Thread Sasha Levin
On 11/03/2012 07:06 PM, Sasha Levin wrote: On 11/03/2012 11:55 AM, Jiri Slaby wrote: On 11/03/2012 03:03 AM, Sasha Levin wrote: On 11/02/2012 12:18 PM, Jiri Slaby wrote: On 11/02/2012 05:07 PM, Sasha Levin wrote: On Fri, Nov 2, 2012 at 11:51 AM, Jiri Slaby jsl...@suse.cz wrote: On 10/31/2012

Re: [PATCH 0/8] drop if around WARN_ON

2012-11-04 Thread Sasha Levin
Hi Julia, On Sat, Nov 3, 2012 at 4:30 PM, Julia Lawall julia.law...@lip6.fr wrote: These patches convert a conditional with a simple test expression and a then branch that only calls WARN_ON(1) to just a call to WARN_ON, which will test the condition. // smpl @@ expression e; @@ (

Re: [PATCH 0/8] drop if around WARN_ON

2012-11-04 Thread Sasha Levin
On Sun, Nov 4, 2012 at 10:57 AM, Julia Lawall julia.law...@lip6.fr wrote: On Sun, 4 Nov 2012, Sasha Levin wrote: Hi Julia, On Sat, Nov 3, 2012 at 4:30 PM, Julia Lawall julia.law...@lip6.fr wrote: These patches convert a conditional with a simple test expression and a then branch that only

Re: [PATCH 0/8] drop if around WARN_ON

2012-11-04 Thread Sasha Levin
On Sun, Nov 4, 2012 at 11:16 AM, Julia Lawall julia.law...@lip6.fr wrote: I didn't change any cases where the if test contains a function call. The current definitions of WARN_ON seem to always evaluate the condition expression, but I was worried that that might not always be the case. And

Re: tty, vt: lockdep warnings

2012-11-05 Thread Sasha Levin
Ping? Should I bisect it? On Fri, Oct 26, 2012 at 9:37 AM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: On Thu, 25 Oct 2012 15:37:43 -0400 Sasha Levin sasha.le...@oracle.com wrote: Hi all, While fuzzing with trinity inside a KVM tools (lkvm) guest running latest -next kernel, I've stumbled

Re: tty, vt: lockdep warnings

2012-11-05 Thread Sasha Levin
On 11/05/2012 12:59 PM, Alan Cox wrote: On Mon, 5 Nov 2012 12:26:43 -0500 Sasha Levin levinsasha...@gmail.com wrote: Ping? Should I bisect it? On Fri, Oct 26, 2012 at 9:37 AM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: On Thu, 25 Oct 2012 15:37:43 -0400 Sasha Levin sasha.le...@oracle.com

Re: [PATCH 0/6] VSOCK for Linux upstreaming

2012-11-05 Thread Sasha Levin
Hi George, On Mon, Nov 5, 2012 at 1:00 PM, George Zhang georgezh...@vmware.com wrote: For additional information about the use of VMCI and in particular VMCI Sockets, please refer to the VMCI Socket Programming Guide available at https://www.vmware.com/support/developer/vmci-sdk/. Is there

Re: mm: NULL ptr deref in anon_vma_interval_tree_verify

2012-11-06 Thread Sasha Levin
On 11/06/2012 10:54 PM, Michel Lespinasse wrote: On Tue, Nov 6, 2012 at 12:24 AM, Michel Lespinasse wal...@google.com wrote: On Mon, Nov 5, 2012 at 5:41 AM, Michel Lespinasse wal...@google.com wrote: On Sun, Nov 4, 2012 at 8:44 PM, Michel Lespinasse wal...@google.com wrote: On Sun, Nov 4, 2012

Re: tty, vt: lockdep warnings

2012-11-07 Thread Sasha Levin
On 11/06/2012 12:38 PM, Alan Cox wrote: The root cause is loading two different framebuffers with one taking over from another - that should be an obscure corner case and once the fuzz testing can avoid. I had a semi-informed poke at this and came up with a possible patch (not

Re: [PATCH v6 28/29] slub: slub-specific propagation changes.

2012-11-07 Thread Sasha Levin
On 11/01/2012 08:07 AM, Glauber Costa wrote: SLUB allows us to tune a particular cache behavior with sysfs-based tunables. When creating a new memcg cache copy, we'd like to preserve any tunables the parent cache already had. This can be done by tapping into the store attribute function

Re: [GIT] floppy

2012-11-07 Thread Sasha Levin
/linux-block.git for-jens into your for-3.7/drivers branch to receive revert of patch that Sasha Levin reported to cause NULL pointer dereferences, and it's not necessary. Thanks! Jiri Kosina (1): Revert genhd: Make put_disk() safe for disks that have not been registered block

Re: [GIT] floppy

2012-11-07 Thread Sasha Levin
On Wed, Nov 7, 2012 at 3:48 PM, Jiri Kosina jkos...@suse.cz wrote: On Wed, 7 Nov 2012, Sasha Levin wrote: Hi guys! This is me complaining that I still see the spews that this pull request should fix, probably because this mail got lost. You are seeing that on -next, right? Yup. That's

[PATCH] vmxnet3: convert BUG_ON(true) into a simple BUG()

2012-11-08 Thread Sasha Levin
Signed-off-by: Sasha Levin sasha.le...@oracle.com --- drivers/net/vmxnet3/vmxnet3_drv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index 0ae1bcc..7e9622f 100644 --- a/drivers/net/vmxnet3

[PATCH] ARM: gic: use BUG_ON where possible

2012-11-08 Thread Sasha Levin
-by: Sasha Levin sasha.le...@oracle.com --- arch/arm/common/gic.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c index aa52699..f0b8a10 100644 --- a/arch/arm/common/gic.c +++ b/arch/arm/common/gic.c @@ -336,10 +336,8

[PATCH] ARM: kprobes: use BUG_ON where possible

2012-11-08 Thread Sasha Levin
-by: Sasha Levin sasha.le...@oracle.com --- arch/arm/kernel/kprobes-test.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/kernel/kprobes-test.c b/arch/arm/kernel/kprobes-test.c index 1862d8f..0fb370d 100644 --- a/arch/arm/kernel/kprobes-test.c +++ b/arch/arm/kernel/kprobes

[PATCH] ARM: versatile: use BUG_ON where possible

2012-11-08 Thread Sasha Levin
-by: Sasha Levin sasha.le...@oracle.com --- arch/arm/mach-versatile/pci.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-versatile/pci.c b/arch/arm/mach-versatile/pci.c index 2f84f40..3936a11 100644 --- a/arch/arm/mach-versatile/pci.c +++ b/arch/arm/mach

[PATCH] ARM: integrator: use BUG_ON where possible

2012-11-08 Thread Sasha Levin
-by: Sasha Levin sasha.le...@oracle.com --- arch/arm/mach-integrator/pci_v3.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-integrator/pci_v3.c b/arch/arm/mach-integrator/pci_v3.c index bbeca59..85938de 100644 --- a/arch/arm/mach-integrator/pci_v3.c +++ b

[PATCH] ARM: dma: use BUG_ON where possible

2012-11-08 Thread Sasha Levin
-by: Sasha Levin sasha.le...@oracle.com --- arch/arm/mach-rpc/dma.c |3 +-- arch/arm/mach-s3c64xx/dma.c |3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-rpc/dma.c b/arch/arm/mach-rpc/dma.c index 85883b2..92e22ba 100644 --- a/arch/arm/mach-rpc/dma.c +++ b/arch

[PATCH] ARM: OMAP1: use BUG_ON where possible

2012-11-08 Thread Sasha Levin
-by: Sasha Levin sasha.le...@oracle.com --- arch/arm/mach-omap1/board-fsample.c |3 +-- arch/arm/mach-omap1/board-h2.c |3 +-- arch/arm/mach-omap1/board-h3.c |3 +-- arch/arm/mach-omap1/board-perseus2.c |3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/arch

[PATCH] alpha: use BUG_ON where possible

2012-11-08 Thread Sasha Levin
-by: Sasha Levin sasha.le...@oracle.com --- arch/alpha/kernel/pci_iommu.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/alpha/kernel/pci_iommu.c b/arch/alpha/kernel/pci_iommu.c index 3f844d2..a21d0ab 100644 --- a/arch/alpha/kernel/pci_iommu.c +++ b/arch/alpha/kernel

[PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-08 Thread Sasha Levin
-by: Sasha Levin sasha.le...@oracle.com --- arch/arm/mach-exynos/common.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c index 4e577f6..6a55a5a 100644 --- a/arch/arm/mach-exynos/common.c +++ b/arch/arm/mach-exynos

[PATCH] kvm, async_pf: exit idleness when handling KVM_PV_REASON_PAGE_NOT_PRESENT

2012-10-19 Thread Sasha Levin
] [81139c25] ? prepare_to_wait+0x25/0x90 [ 732.790032] [810a3a66] do_async_page_fault+0x56/0xa0 [ 732.790032] [83a6a6e8] async_page_fault+0x28/0x30 Signed-off-by: Sasha Levin sasha.le...@oracle.com --- arch/x86/kernel/kvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH resend] net, bluetooth: don't attempt to free a channel that wasn't created

2012-10-08 Thread Sasha Levin
] RIP [836645c4] l2cap_chan_put+0x34/0x50 [ 12.920166] RSP 880066933c38 [ 12.920167] CR2: 0010 [ 12.920417] ---[ end trace 5a9114e8a158ab84 ]--- Introduced in commit 61d6ef3e (Bluetooth: Make better use of l2cap_chan reference counting). Signed-off-by: Sasha Levin

Re: blk: NULL ptr deref in blk_dequeue_request()

2012-10-09 Thread Sasha Levin
On 10/08/2012 05:45 PM, Jiri Kosina wrote: On Mon, 8 Oct 2012, Jan Kara wrote: I'm still seeing this on linux-next. I think this is floppy related (see redo_fd_request() in the stack trace). And there were quite some changes to the area recently. Adding maintainer to CC. Hmm ... I

Re: blk: NULL ptr deref in blk_dequeue_request()

2012-10-09 Thread Sasha Levin
On 10/09/2012 09:21 AM, Sasha Levin wrote: On 10/08/2012 05:45 PM, Jiri Kosina wrote: On Mon, 8 Oct 2012, Jan Kara wrote: I'm still seeing this on linux-next. I think this is floppy related (see redo_fd_request() in the stack trace). And there were quite some changes to the area recently

Re: [PATCH 2/2] xattr: prevent NULL ptr deref warnings in __simple_xattr_set

2012-10-09 Thread Sasha Levin
On 09/14/2012 04:58 PM, Aristeu Rozanski wrote: On Fri, Sep 14, 2012 at 01:55:55PM -0700, Tejun Heo wrote: On Fri, Sep 14, 2012 at 01:54:34PM -0700, Tejun Heo wrote: On Fri, Sep 14, 2012 at 09:35:54PM +0200, Sasha Levin wrote: Prevent warnings generated by smatch due to unchecked dereference

Re: [PATCH v3 06/10] mm: kill vma flag VM_CAN_NONLINEAR

2012-10-09 Thread Sasha Levin
On 07/31/2012 06:42 AM, Konstantin Khlebnikov wrote: This patch moves actual ptes filling for non-linear file mappings into special vma operation: -remap_pages(). File system must implement this method to get non-linear mappings support, if it uses filemap_fault() then

[PATCH] of/mdio: fix build errors when CONFIG_OF isn't set

2012-10-10 Thread Sasha Levin
Commit f9dc9ac5 (of/mdio: Add dummy functions in of_mdio.h.) has added empty stubs into of_mdio.h which were not static, this causes build errors when these symbols were defined across several objects. Fix it by marking those stubs as 'static inline'. Signed-off-by: Sasha Levin sasha.le

Re: [Patch 3/7] smpboot: Provide infrastructure for percpu hotplug threads

2012-10-11 Thread Sasha Levin
On Wed, Sep 19, 2012 at 5:47 PM, Sasha Levin levinsasha...@gmail.com wrote: Hi Thomas, On 07/16/2012 12:42 PM, Thomas Gleixner wrote: Provide a generic interface for setting up and tearing down percpu threads. On registration the threads for already online cpus are created and started

Re: blk: NULL ptr deref in blk_dequeue_request()

2012-10-12 Thread Sasha Levin
Hi Ben, On Wed, Oct 10, 2012 at 11:52 AM, Ben Hutchings b...@decadent.org.uk wrote: On Tue, 2012-10-09 at 09:26 -0400, Sasha Levin wrote: On 10/09/2012 09:21 AM, Sasha Levin wrote: On 10/08/2012 05:45 PM, Jiri Kosina wrote: On Mon, 8 Oct 2012, Jan Kara wrote: I'm still seeing

Re: [patch for-3.7] mm, mempolicy: fix printing stack contents in numa_maps

2012-10-24 Thread Sasha Levin
On Wed, Oct 17, 2012 at 1:24 AM, David Rientjes rient...@google.com wrote: On Wed, 17 Oct 2012, Dave Jones wrote: BUG: sleeping function called from invalid context at kernel/mutex.c:269 in_atomic(): 1, irqs_disabled(): 0, pid: 8558, name: trinity-child2 3 locks on stack by

Re: [patch for-3.7] mm, mempolicy: fix printing stack contents in numa_maps

2012-10-24 Thread Sasha Levin
On Wed, Oct 24, 2012 at 7:34 PM, David Rientjes rient...@google.com wrote: On Wed, 24 Oct 2012, Sasha Levin wrote: I'm not sure about the status of the patch, but it doesn't apply on top of -next, and I still see the warnings when fuzzing on -next. This should be fixed by 9e7814404b77

Re: [patch for-3.7] mm, mempolicy: fix printing stack contents in numa_maps

2012-10-25 Thread Sasha Levin
On 10/25/2012 10:39 AM, Peter Zijlstra wrote: On Thu, 2012-10-25 at 14:19 +0200, Peter Zijlstra wrote: On Wed, 2012-10-24 at 17:08 -0700, David Rientjes wrote: Ok, this looks the same but it's actually a different issue: mpol_misplaced(), which now only exists in linux-next and not in

Re: [PATCH 21/21] TTY: move tty buffers to tty_port

2012-10-25 Thread Sasha Levin
Hi guys, On 10/18/2012 04:26 PM, Jiri Slaby wrote: So this is it. The big step why we did all the work over the past kernel releases. Now everything is prepared, so nothing protects us from doing that big step. | |\ \ /^l | | | | \

Re: [BUG] lkvm crash on crashkernel boot

2012-10-25 Thread Sasha Levin
On Thu, Oct 25, 2012 at 8:16 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: On Thu, Oct 25, 2012 at 10:17:27AM +0300, Pekka Enberg wrote: On Wed, Oct 24, 2012 at 6:27 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Hi, I've tried to play with kexec using lkvm.

tty, vt: lockdep warnings

2012-10-25 Thread Sasha Levin
Hi all, While fuzzing with trinity inside a KVM tools (lkvm) guest running latest -next kernel, I've stumbled on the following spew: [ 603.081796] == [ 603.081797] [ INFO: possible circular locking dependency detected ] [ 603.081800]

Re: mm: NULL ptr deref in anon_vma_interval_tree_verify

2012-10-25 Thread Sasha Levin
On 10/18/2012 06:46 PM, Sasha Levin wrote: Hi all, While fuzzing with trinity inside a KVM tools (lkvm) guest, on today's linux-next kernel, I saw the following: [ 1857.278176] BUG: unable to handle kernel NULL pointer dereference at 0090 [ 1857.283725] IP

ipc, msgqueue: NULL ptr deref in msgrcv

2012-10-25 Thread Sasha Levin
Hi all, While fuzzing with trinity inside a KVM tools (lkvm) guest running latest -next, I've stumbled on the follwing: [ 80.110944] NULL pointer dereference at 0011 [ 80.110944] IP: [8190cf90] testmsg.isra.5+0x40/0x70 [ 80.110944] PGD 23812067 PUD 23811067 PMD 0 [

Re: ipc, msgqueue: NULL ptr deref in msgrcv

2012-10-27 Thread Sasha Levin
On 10/25/2012 08:43 PM, Sasha Levin wrote: Hi all, While fuzzing with trinity inside a KVM tools (lkvm) guest running latest -next, I've stumbled on the follwing: [ 80.110944] NULL pointer dereference at 0011 [ 80.110944] IP: [8190cf90] testmsg.isra.5+0x40/0x70

[PATCH v7 01/16] hashtable: introduce a small and naive hashtable

2012-10-28 Thread Sasha Levin
This hashtable implementation is using hlist buckets to provide a simple hashtable to prevent it from getting reimplemented all over the kernel. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- Sorry for the long delay, I was busy with a bunch of personal things. Changes since v6: - Use

[PATCH v7 04/16] workqueue: use new hashtable implementation

2012-10-28 Thread Sasha Levin
Switch workqueues to use the new hashtable implementation. This reduces the amount of generic unrelated code in the workqueues. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- kernel/workqueue.c | 86 ++ 1 file changed, 15 insertions

[PATCH v7 05/16] mm/huge_memory: use new hashtable implementation

2012-10-28 Thread Sasha Levin
it. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- mm/huge_memory.c | 55 ++- 1 file changed, 14 insertions(+), 41 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 3c14a96..38ce8e9 100644 --- a/mm/huge_memory.c +++ b

[PATCH v7 07/16] net,9p: use new hashtable implementation

2012-10-28 Thread Sasha Levin
Switch 9p error table to use the new hashtable implementation. This reduces the amount of generic unrelated code in 9p. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- net/9p/error.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/net/9p

[PATCH v7 08/16] block,elevator: use new hashtable implementation

2012-10-28 Thread Sasha Levin
accessing it. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- block/blk.h | 2 +- block/elevator.c | 23 --- include/linux/elevator.h | 5 - 3 files changed, 9 insertions(+), 21 deletions(-) diff --git a/block/blk.h b/block/blk.h index ca51543

[PATCH v7 09/16] SUNRPC/cache: use new hashtable implementation

2012-10-28 Thread Sasha Levin
Switch cache to use the new hashtable implementation. This reduces the amount of generic unrelated code in the cache implementation. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- net/sunrpc/cache.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git

[PATCH v7 11/16] net,l2tp: use new hashtable implementation

2012-10-28 Thread Sasha Levin
Switch l2tp to use the new hashtable implementation. This reduces the amount of generic unrelated code in l2tp. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- net/l2tp/l2tp_core.c| 134 ++-- net/l2tp/l2tp_core.h| 8 +-- net/l2tp

[PATCH v7 13/16] lockd: use new hashtable implementation

2012-10-28 Thread Sasha Levin
Switch lockd to use the new hashtable implementation. This reduces the amount of generic unrelated code in lockd. Signed-off-by: Sasha Levin levinsasha...@gmail.com --- fs/lockd/svcsubs.c | 66 +- 1 file changed, 36 insertions(+), 30 deletions

  1   2   3   4   5   6   7   8   9   10   >