On Thu, Nov 22, 2012 at 10:10 AM, Rafael Aquini wrote:
> On Thu, Nov 22, 2012 at 09:19:15AM -0500, Sasha Levin wrote:
>> And managed to reproduce it only once through last night, here is the dump I
>> got
>> before the oops:
>>
>> [ 2760.356820] page:ead0
Hi all,
On 11/22/2012 05:49 PM, Ingo Molnar wrote:
> +static void task_numa_placement(struct task_struct *p)
> +{
> + int seq = ACCESS_ONCE(p->mm->numa_scan_seq);
I was fuzzing with trinity on my fake numa setup, and discovered that this can
be called for task_structs with p->mm == NULL, whic
On 11/12/2012 03:54 PM, Sasha Levin wrote:
> On 11/12/2012 06:51 AM, Michel Lespinasse wrote:
>> Using the trinity fuzzer, Sasha Levin uncovered a case where
>> rb_subtree_gap wasn't correctly updated.
>>
>> Digging into this, the root cause was that vma insertions
On 11/27/2012 08:07 AM, Gleb Natapov wrote:
> Those rcu_irq_enter()/rcu_irq_exit() were introduced by commit
> c5e015d4949aa665 "KVM guest: exit idleness when handling
> KVM_PV_REASON_PAGE_NOT_PRESENT", but now I am starting to question this
> commit. KVM_PV_REASON_PAGE_NOT_PRESENT should not kick
echo 1 > /sys/kernel/debug/nfsd/forget_locks
Signed-off-by: Sasha Levin
---
fs/nfsd/netns.h | 3 +++
fs/nfsd/nfs4state.c | 9 +
2 files changed, 12 insertions(+)
diff --git a/fs/nfsd/netns.h b/fs/nfsd/netns.h
index 227b93e..c5806a57 100644
--- a/fs/nfsd/netns.h
+++ b/fs/nfsd/net
On 03/17/2013 12:23 PM, Ming Lei wrote:
> On Sun, Mar 17, 2013 at 10:24 PM, Sasha Levin wrote:
>>
>> I still see it going on with the patch applied:
>
> Looks the previous patch still has the race problem, so could you just
> apply the attachment patch and cancel all
On 03/19/2013 07:54 AM, Ming Lei wrote:
> Hi Sasha,
>
> On Tue, Mar 19, 2013 at 11:40 AM, Ming Lei wrote:
>> Hi Sasha,
>>
>> On Tue, Mar 19, 2013 at 10:06 AM, Sasha Levin
>> wrote:
>>> [ 232.822703] sysfs_dir_pos-973 sysfs_dirent use after free:
>
On 03/19/2013 09:02 PM, Ming Lei wrote:
> Hi Sasha,
>
> On Wed, Mar 20, 2013 at 12:28 AM, Sasha Levin wrote:
>> On 03/19/2013 07:54 AM, Ming Lei wrote:
>>
>> With v3 of the patch:
>>
>> [ 1275.665758] sysfs_dir_pos-973 sysfs_dirent use after free:
>&
sysfs started complaining about cases where permissions don't
match what's in the sysfs ops structure (such as allowing read
without a "show" callback).
Signed-off-by: Sasha Levin
---
kernel/rtmutex-tester.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --
On 02/03/2013 06:04 AM, Ingo Molnar wrote:
>
> So I applied your patches and did:
>
> cd tools/lib/lockdep
> make
>
> and got:
>
> comet:~/tip/tools/lib/lockdep> make
> CC FPICcommon.o
> In file included from ./uinclude/linux/lockdep.h:13:0,
> from
> /fast/mi
On 02/03/2013 06:05 AM, Ingo Molnar wrote:
>
> * Sasha Levin wrote:
>
>> liblockdep is simply userspace lockdep. We can use that to analyze and
>> verify the locking in perf.
>>
>> Usage is simple, to compile perf with liblockdep all that's needed it:
>&
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/include/liblockdep/common.h | 42 +++
tools/lib/lockdep/include/liblockdep/mutex.h | 73 +++
2 files changed, 115 insertions(+)
create mode 100644 tools/lib/lockdep/include/liblockdep/common.h
create mode 1
A simple test to make sure we handle rwlocks correctly.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/tests/WW.c | 16
1 file changed, 16 insertions(+)
create mode 100644 tools/lib/lockdep/tests/WW.c
diff --git a/tools/lib/lockdep/tests/WW.c b/tools/lib/lockdep/tests/WW.c
Signed-off-by: Sasha Levin
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 212c255..a64abfb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4637,6 +4637,11 @@ F: drivers/lguest/
F: include/linux/lguest*.h
F: tools/lguest
e591d]
./perf[0x4190d9]
Signed-off-by: Sasha Levin
---
tools/perf/Makefile | 22 ++
tools/perf/builtin-sched.c | 6 --
tools/perf/builtin-top.c| 4
tools/perf/config/feature-tests.mak | 12
tools/perf/p
oo similar.
We wrap kernel/lockdep.c and include/linux/lockdep.h with several
headers which allow us to build and use lockdep from userspace. We don't
touch the kernel code itself which means that any work done on lockdep
in the kernel will automatically benefit userspace lockdep as well!
Signe
Both pthreads and lockdep support dealing with rwlocks, so here's the
liblockdep implementation for those.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/include/liblockdep/rwlock.h | 91 +++
1 file changed, 91 insertions(+)
create mode 100644 tools/lib/lo
This is a rather simple and basic test suite to test common locking
issues.
Beyond tests, it also shows how to use the library.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/run_tests.sh | 15 +++
tools/lib/lockdep/tests/AA.c | 16
tools
; check in ioctl write. There is a report of a case where
> this breaks userland (clvmd) when maximum resource name
> lengths are used. I am still sorting out exactly which
> combinations of kernel and userland libs are a problem.
>
> Reported-by: Jana Saout
> CC: Sasha Levin
> S
These functions are no longer needed by liblockdep, drop them.
Signed-off-by: Sasha Levin
---
tools/perf/builtin-sched.c | 2 --
tools/perf/builtin-top.c| 4
tools/perf/config/feature-tests.mak | 1 -
tools/perf/perf.c | 3 ---
tools/perf/util
We re-use kernel's rbtree structure for the preload improvement in the
following patches.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/rbtree.c | 1 +
tools/lib/lockdep/uinclude/linux/rbtree.h | 1 +
tools/lib/lockdep/uinclude/linux/rbtree_augmented.
We need the public headers in the core module code for the preload thing.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/include/liblockdep/mutex.h | 4 ++--
tools/lib/lockdep/include/liblockdep/rwlock.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/lib
at's
outside of the scope of this patch.
Instead of taking the perf in this series another option would
be to just revert the existing perf patch from me in core/locking,
which would mean perf would just work with the new LD_PRELOAD
feature.
Sasha Levin (11):
liblockdep: remove the need
We were accidently unlocking the dummy mutex in the test, which meant
that we were testing unlock balance instead of AA deadlock.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/tests/AA.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/lockdep/tests/AA.c b/tools
Generate the task_struct data on the fly when needed, instead on on
thread creation.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/common.c| 8 +---
tools/lib/lockdep/include/liblockdep/common.h | 1 -
tools/lib/lockdep/tests/AA.c | 2 --
tools/lib
This allows lockdep to be used without being compiled in the original program.
Usage is quite simple:
LD_PRELOAD=/path/to/liblockdep.so /path/to/my/program
And magically, you'll have lockdep in your program!
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/Makefile | 4 +-
Use same tests, but without compiling with liblockdep in the first place.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/run_tests.sh | 12
1 file changed, 12 insertions(+)
diff --git a/tools/lib/lockdep/run_tests.sh b/tools/lib/lockdep/run_tests.sh
index 4dd32d1..211e91d 100755
This is a simple wrapper to make using liblockdep on existing applications
much easier.
After running 'make && make install', it becomes quite simple to test things
with liblockdep. For example, to try it on perf:
liblockdep perf
No other integration required.
Si
Use a constructor in the library instead of making the user manually
call liblockdep_init().
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/common.c| 2 +-
tools/lib/lockdep/include/liblockdep/common.h | 1 -
tools/lib/lockdep/tests/AA.c | 1 -
tools/lib
There's no need to use liblockdep specific calls, they are wrapped for us.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/tests/ABCDBCDA.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/lib/lockdep/tests/ABCDBCDA.c
b/tools/lib/lockdep/tests/ABCDB
They are declared once in the public and once in the private headers, prevent
declaring them twice if both headers are used.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/include/liblockdep/common.h | 3 +++
tools/lib/lockdep/uinclude/linux/kernel.h | 2 ++
2 files changed, 5 insertions
On 02/04/2013 02:17 AM, Michel Lespinasse wrote:
> munlock_vma_pages_range() was always incrementing addresses by PAGE_SIZE
> at a time. When munlocking THP pages (or the huge zero page), this resulted
> in taking the mm->page_table_lock 512 times in a row.
>
> We can do better by making use of th
Hi Michel,
We're now hitting the VM_BUG_ON() which was added in the last hunk of the
patch:
[ 143.217822] [ cut here ]
[ 143.219938] kernel BUG at mm/mlock.c:424!
[ 143.220031] invalid opcode: [#2] PREEMPT SMP DEBUG_PAGEALLOC
[ 143.220031] Modules linked in:
[ 14
On 02/06/2013 07:55 PM, Andrew Morton wrote:
> On Wed, 30 Jan 2013 21:00:22 -0500
> Sasha Levin wrote:
>
>> I'm not sure why, but the hlist for each entry iterators were conceived
>> differently from the list ones. While the list ones are nice and elegant:
>>
&g
On 02/06/2013 08:10 PM, Andrew Morton wrote:
> On Wed, 06 Feb 2013 19:39:11 -0500
> Sasha Levin wrote:
>
>> We're now hitting the VM_BUG_ON() which was added in the last hunk of the
>> patch:
>
> hm, why was that added.
>
> Michel, I seem to have conf
On 02/06/2013 09:50 PM, Li Zhong wrote:
> On Wed, 2013-02-06 at 18:44 -0500, Sasha Levin wrote:
>> On 02/04/2013 02:17 AM, Michel Lespinasse wrote:
>>> munlock_vma_pages_range() was always incrementing addresses by PAGE_SIZE
>>> at a time. When munlocking THP pages (o
On 02/07/2013 01:55 AM, Namhyung Kim wrote:
> On Wed, 6 Feb 2013 17:11:34 -0500, Sasha Levin wrote:
>> diff --git a/tools/lib/lockdep/lockdep b/tools/lib/lockdep/lockdep
>> new file mode 100755
>> index 000..616bf9a
>> --- /dev/null
>> +++ b/tools/li
On 02/07/2013 05:28 AM, Jamie Iles wrote:
>> +int pthread_rwlock_init(pthread_rwlock_t *rwlock,
>> > + const pthread_rwlockattr_t *attr)
>> > +{
>> > + if (ll_pthread_rwlock_init == NULL)
>> > + init_preload();
> Why is this one special, doesn't init_preload being a const
Hi guys,
I got the following while fuzzing with trinity inside a KVM tools guest:
[ 51.680236] ===
[ 51.681914] [ INFO: suspicious RCU usage. ]
[ 51.683610] 3.8.0-rc6-next-20130206-sasha-00028-g83214f7-dirty #276 Tainted:
GW
[ 51.686703] --
On Thu, Feb 7, 2013 at 8:38 PM, Cong Wang wrote:
> On Thu, 07 Feb 2013 at 19:32 GMT, Sasha Levin wrote:
>> Hi guys,
>>
>> I got the following while fuzzing with trinity inside a KVM tools guest:
>>
>> [ 51.680236] ===
>> [
On 01/25/2013 02:09 AM, Li Zefan wrote:
> rename() will change dentry->d_name. The result of this race can
> be worse than seeing partially rewritten name, but we might access
> a stale pointer because rename() will re-allocate memory to hold
> a longer name.
>
> Use dentry_path_raw(), and this vf
On 02/08/2013 05:43 AM, Jamie Iles wrote:
> On Thu, Feb 07, 2013 at 09:31:22AM -0500, Sasha Levin wrote:
>> On 02/07/2013 05:28 AM, Jamie Iles wrote:
>>>> +int pthread_rwlock_init(pthread_rwlock_t *rwlock,
>>>>> + const pthread_rwl
Generate the task_struct data on the fly when needed, instead on on
thread creation.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/common.c| 8 +---
tools/lib/lockdep/include/liblockdep/common.h | 1 -
tools/lib/lockdep/tests/AA.c | 2 --
tools/lib
We need the public headers in the core module code for the preload thing.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/include/liblockdep/mutex.h | 4 ++--
tools/lib/lockdep/include/liblockdep/rwlock.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/lib
Use same tests, but without compiling with liblockdep in the first place.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/run_tests.sh | 12
1 file changed, 12 insertions(+)
diff --git a/tools/lib/lockdep/run_tests.sh b/tools/lib/lockdep/run_tests.sh
index 4dd32d1..211e91d 100755
This allows lockdep to be used without being compiled in the original program.
Usage is quite simple:
LD_PRELOAD=/path/to/liblockdep.so /path/to/my/program
And magically, you'll have lockdep in your program!
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/Makefile | 4 +-
There's no need to use liblockdep specific calls, they are wrapped for us.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/tests/ABCDBCDA.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/lib/lockdep/tests/ABCDBCDA.c
b/tools/lib/lockdep/tests/ABCDB
We re-use kernel's rbtree structure for the preload improvement in the
following patches.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/rbtree.c | 1 +
tools/lib/lockdep/uinclude/linux/rbtree.h | 1 +
tools/lib/lockdep/uinclude/linux/rbtree_augmented.
They are declared once in the public and once in the private headers, prevent
declaring them twice if both headers are used.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/include/liblockdep/common.h | 3 +++
tools/lib/lockdep/uinclude/linux/kernel.h | 2 ++
2 files changed, 5 insertions
Use a constructor in the library instead of making the user manually
call liblockdep_init().
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/common.c| 2 +-
tools/lib/lockdep/include/liblockdep/common.h | 1 -
tools/lib/lockdep/tests/AA.c | 1 -
tools/lib
We were accidently unlocking the dummy mutex in the test, which meant
that we were testing unlock balance instead of AA deadlock.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/tests/AA.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/lockdep/tests/AA.c b/tools
This is a simple wrapper to make using liblockdep on existing applications
much easier.
After running 'make && make install', it becomes quite simple to test things
with liblockdep. For example, to try it on perf:
lockdep perf
No other integration required.
Signed-o
These functions are no longer needed by liblockdep, drop them.
Signed-off-by: Sasha Levin
---
tools/perf/builtin-sched.c | 2 --
tools/perf/builtin-top.c| 4
tools/perf/config/feature-tests.mak | 1 -
tools/perf/perf.c | 3 ---
tools/perf/util
On 03/29/2013 03:36 PM, Peter Hurley wrote:
> On Fri, 2013-03-29 at 12:26 -0700, Linus Torvalds wrote:
>> On Fri, Mar 29, 2013 at 12:06 PM, Dave Jones wrote:
>>>
>>> Here's an oops I just hit..
>>>
>>> BUG: unable to handle kernel NULL pointer dereference at 000f
>>> IP: [] testmsg.isr
Hi all,
It seems that trying to fuzz bcache without any devices triggers a BUG:
sh-4.2# echo 1 > /sys/fs/bcache/fuzz
[ 89.700458] bio: create slab at 1
[ 89.704543] [ cut here ]
[ 89.710043] kernel BUG at drivers/md/bcache/debug.c:447!
[ 89.710043] invalid opcode:
Ping?
On 03/20/2013 11:58 AM, Sasha Levin wrote:
> sysfs started complaining about cases where permissions don't
> match what's in the sysfs ops structure (such as allowing read
> without a "show" callback).
>
> Signed-off-by: Sasha Levin
> ---
> ke
On 04/02/2013 01:52 PM, Linus Torvalds wrote:
> On Tue, Apr 2, 2013 at 9:08 AM, Sasha Levin wrote:
>>
>> By just playing with the 'msgsz' parameter with MSG_COPY set.
>
> Hmm. Looking closer, I suspect you're testing without commit
> 88b9e456b164 (&quo
Ping? I'm seeing a whole bunch of these with current -next.
Thanks,
Sasha
On 03/29/2013 09:04 AM, Sasha Levin wrote:
> Hi all,
>
> While fuzzing with trinity inside a KVM tools guest running latest -next
> kernel,
> I've stumbled on the following.
>
On 04/04/2013 10:30 AM, Kirill A. Shutemov wrote:
> Sasha Levin wrote:
>> Ping? I'm seeing a whole bunch of these with current -next.
>
> Do you have a way to reproduce?
Not really, trinity just manages to make it happen quite often.
I can add something in the code to spew
On 04/04/2013 12:28 PM, Kirill A. Shutemov wrote:
> Sasha Levin wrote:
>> On 04/04/2013 10:30 AM, Kirill A. Shutemov wrote:
>>> Sasha Levin wrote:
>>>> Ping? I'm seeing a whole bunch of these with current -next.
>>>
>>> Do you have a way to repr
On 01/30/2013 06:47 PM, Andrew Morton wrote:
> On Tue, 29 Jan 2013 20:08:30 -0500
> Sasha Levin wrote:
>
>> Also, ping :)
>>
>> ...
>>
>>> 216 files changed, 1031 insertions(+), 1526 deletions(-)
>
> Whimper.
>
> I don't really s
On 01/30/2013 07:22 PM, Andrew Morton wrote:
> On Wed, 30 Jan 2013 19:09:49 -0500
> Sasha Levin wrote:
>> If not, should I send it over to you on -rc1?
>
> Probably that's the way to go, but there's no point in going via my
> tree on this - put it straight i
These headers provide the same API as their pthread mutex counterparts.
The design here is to allow to easily switch to liblock lock validation
just by adding a "liblock_" to pthread_mutex_*() calls, which means that
it's easy to integrate liblock into existing codebases.
Signe
Signed-off-by: Sasha Levin
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 212c255..f26afae 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4637,6 +4637,11 @@ F: drivers/lguest/
F: include/linux/lguest*.h
F: tools/lguest
oo similar.
We wrap kernel/lockdep.c and include/linux/lockdep.h with several
headers which allow us to build and use lockdep from userspace. We don't
touch the kernel code itself which means that any work done on lockdep
in the kernel will automatically benefit userspace lockdep as well!
Signe
190d9]
Signed-off-by: Sasha Levin
---
tools/perf/Makefile | 22 ++
tools/perf/builtin-sched.c | 31 +--
tools/perf/builtin-top.c| 19 ++-
tools/perf/config/feature-tests.mak | 12
tools
Both pthreads and lockdep support dealing with rwlocks, so here's the
liblock implementation for those.
Signed-off-by: Sasha Levin
---
tools/lib/liblock/include/liblock/rwlock.h | 78 ++
1 file changed, 78 insertions(+)
create mode 100644 tools/lib/liblock/in
This is a rather simple and basic test suite to test common locking
issues.
Beyond tests, it also shows how to use the library.
Signed-off-by: Sasha Levin
---
tools/lib/liblock/run_tests.sh | 16
tools/lib/liblock/tests/AA.c | 16
tools
This patch series adds a userspace lock correctnes validator into
tools/lib/liblock.
There are no changes to any kernel code whatsoever, lockdep is
being used as is.
First 6 patches are the liblock implementation, the last one is
an example of liblock being used on an existing codebase.
Sasha
A simple test to make sure we handle rwlocks correctly.
Signed-off-by: Sasha Levin
---
tools/lib/liblock/tests/WW.c | 16
1 file changed, 16 insertions(+)
create mode 100644 tools/lib/liblock/tests/WW.c
diff --git a/tools/lib/liblock/tests/WW.c b/tools/lib/liblock/tests/WW.c
On 02/01/2013 04:57 AM, Ingo Molnar wrote:
>
> * Sasha Levin wrote:
>
>> These headers provide the same API as their pthread mutex counterparts.
>>
>> The design here is to allow to easily switch to liblock lock validation
>> just by adding a "liblock_&qu
Both pthreads and lockdep support dealing with rwlocks, so here's the
liblockdep implementation for those.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/include/liblockdep/rwlock.h | 91 +++
1 file changed, 91 insertions(+)
create mode 100644 tools/lib/lo
+0xed)[0x7fa063ae591d]
./perf[0x4190d9]
Signed-off-by: Sasha Levin
---
tools/perf/Makefile | 22 ++
tools/perf/builtin-sched.c | 6 --
tools/perf/builtin-top.c| 4
tools/perf/config/feature-tests.mak | 12
tools/perf/p
oo similar.
We wrap kernel/lockdep.c and include/linux/lockdep.h with several
headers which allow us to build and use lockdep from userspace. We don't
touch the kernel code itself which means that any work done on lockdep
in the kernel will automatically benefit userspace lockdep as well!
Signe
This is a rather simple and basic test suite to test common locking
issues.
Beyond tests, it also shows how to use the library.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/run_tests.sh | 15 +++
tools/lib/lockdep/tests/AA.c | 16
tools
A simple test to make sure we handle rwlocks correctly.
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/tests/WW.c | 16
1 file changed, 16 insertions(+)
create mode 100644 tools/lib/lockdep/tests/WW.c
diff --git a/tools/lib/lockdep/tests/WW.c b/tools/lib/lockdep/tests/WW.c
Signed-off-by: Sasha Levin
---
tools/lib/lockdep/include/liblockdep/common.h | 42 +++
tools/lib/lockdep/include/liblockdep/mutex.h | 73 +++
2 files changed, 115 insertions(+)
create mode 100644 tools/lib/lockdep/include/liblockdep/common.h
create mode 1
Signed-off-by: Sasha Levin
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 212c255..a64abfb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4637,6 +4637,11 @@ F: drivers/lguest/
F: include/linux/lguest*.h
F: tools/lguest
+0xed)[0x7fa063ae591d]
./perf[0x4190d9]
Signed-off-by: Sasha Levin
---
I've forgot a debug line in the original patch, resending it without it.
tools/perf/Makefile | 22 ++
tools/perf/builtin-sched.c | 6 --
tools/perf/builtin-top.c
Hi folks,
Commit "swap: make each swap partition have one address_space" is triggering
a series of warnings on boot:
[3.446071] [ cut here ]
[3.446664] WARNING: at lib/debugobjects.c:261 debug_print_object+0x8e/0xb0()
[3.447715] ODEBUG: init active (active stat
Hello Masami,
Thank you for your review!
My comments are below.
On 01/21/2013 06:49 AM, Masami Hiramatsu wrote:
> (2013/01/10 8:09), Sasha Levin wrote:
>> @@ -278,7 +278,7 @@ static int __kprobes can_optimize(unsigned long paddr)
>> }
>>
>> /* Check optim
On 01/18/2013 04:25 PM, Steven Rostedt wrote:
> On Wed, 2013-01-09 at 18:09 -0500, Sasha Levin wrote:
>> Modify the parameters of all the lookup and the bookkeeping functions which
>> should be const to const.
>>
>> For example, jump_label_text_reserved() doesn't m
On 01/24/2013 11:25 PM, Shaohua Li wrote:
> On Thu, Jan 24, 2013 at 10:45:57PM -0500, Sasha Levin wrote:
>> Hi folks,
>>
>> Commit "swap: make each swap partition have one address_space" is triggering
>> a series of warnings on boot:
>&g
On 02/22/2013 01:37 PM, Peter Hurley wrote:
> On Thu, 2013-02-21 at 08:38 -0500, Peter Hurley wrote:
>> On Thu, 2013-02-21 at 08:16 -0500, Sasha Levin wrote:
>>> On 02/20/2013 03:02 PM, Peter Hurley wrote:
>>>> Sasha and Dave, my trinity testbeds die in other areas
On 02/23/2013 10:24 AM, Sasha Levin wrote:
> On 02/22/2013 01:37 PM, Peter Hurley wrote:
>> On Thu, 2013-02-21 at 08:38 -0500, Peter Hurley wrote:
>>> On Thu, 2013-02-21 at 08:16 -0500, Sasha Levin wrote:
>>>> On 02/20/2013 03:02 PM, Peter Hurley wrote:
>>>
On 02/23/2013 01:43 PM, Peter Hurley wrote:
> On Sat, 2013-02-23 at 10:24 -0500, Sasha Levin wrote:
>> On 02/22/2013 01:37 PM, Peter Hurley wrote:
>>> On Thu, 2013-02-21 at 08:38 -0500, Peter Hurley wrote:
>>>> On Thu, 2013-02-21 at 08:16 -0500, Sasha Levin wrote
Hi all,
While fuzzing with trinity inside a KVM tools guest running latest -next kernel,
I've stumbled on the following BUG:
[13551.830090] [ cut here ]
[13551.830090] kernel BUG at mm/mempolicy.c:2187!
[13551.830090] invalid opcode: [#1] PREEMPT SMP DEBUG_PAGEALLOC
[
On 02/25/2013 08:52 PM, KOSAKI Motohiro wrote:
> On Mon, Feb 25, 2013 at 8:30 AM, Sasha Levin wrote:
>> Hi all,
>>
>> While fuzzing with trinity inside a KVM tools guest running latest -next
>> kernel,
>> I've stumbled on the following BUG:
>&
Hi all,
While fuzzing with trinity inside a KVM tools guest running latest -next,
I've started seeing a bunch of these, which wasn't there in the -next from
couple of days ago:
[ 1169.020539] [ cut here ]
[ 1169.021297] WARNING: at fs/dcache.c:2587 prepend_path+0x188/0x1f0
On 02/28/2013 11:27 AM, Greg Kroah-Hartman wrote:
> On Thu, Feb 28, 2013 at 11:03:58AM -0500, Sasha Levin wrote:
>> Hi Greg,
>>
>> While fuzzing with trinity inside a KVM tools guest, running latest -next
>> kernel
>> I got the following spew.
>>
>&
On 02/18/2013 03:26 AM, Ingo Molnar wrote:
>
> * Sasha Levin wrote:
>
>> I suspect it's the result of adding the new rcu_oom_notify, but that happened
>> about half a year ago so I'm not sure why this showed u
Hi all,
While fuzzing with trinity inside a KVM tools guest, running today's -next,
I've stumbled on the following spew.
I've cc'ed Steven Rostedt since the culprit looks like "sched: Enable
interrupts in idle_balance()".
[ 119.938711] [ cut here ]
[ 119.940026] kernel
On 02/18/2013 08:26 PM, Steven Rostedt wrote:
> On Mon, 2013-02-18 at 19:55 -0500, Sasha Levin wrote:
>> Hi all,
>>
>> While fuzzing with trinity inside a KVM tools guest, running today's -next,
>> I've stumbled on the following spew.
>>
>> I
On 02/18/2013 07:35 PM, Christoph Lameter wrote:
> Maybe the result of free pointer corruption due to writing to an object
> after free. Please run again with slub_debug specified on the commandline
> to get detailed reports on how this came about.
>
> On Sun, 17 Feb 2013, Sa
On 02/19/2013 01:29 PM, Dave Jones wrote:
> On Tue, Feb 19, 2013 at 01:18:25PM -0500, Sasha Levin wrote:
>
> > >> [ 169.930103] ---[ end trace 4d135f3def21b4bd ]---
> > >>
> > >> The code translates to the following in fs/pipe.c:alloc_pipe_info :
>
On 02/19/2013 02:58 AM, Ingo Molnar wrote:
>
> * Sasha Levin wrote:
>
>> Use a constructor in the library instead of making the user manually
>> call liblockdep_init().
>>
>> Signed-off-by: Sasha Levin
>> ---
>> tools/lib/lockdep/common.c
On 02/20/2013 10:46 AM, Ingo Molnar wrote:
>
> * Sasha Levin wrote:
>
>> On 02/19/2013 02:58 AM, Ingo Molnar wrote:
>>>
>>> * Sasha Levin wrote:
>>>
>>>> Use a constructor in the library instead of making the user manually
>>>
'hint' will be NULL if we're looking up before adding anything
to the IDR.
Signed-off-by: Sasha Levin
---
include/linux/idr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/idr.h b/include/linux/idr.h
index aed2a0c..a6f38b5 100644
--- a/incl
On 02/20/2013 01:45 PM, Tejun Heo wrote:
> Hello, Sasha.
>
> On Wed, Feb 20, 2013 at 10:44 AM, Sasha Levin wrote:
>> 'hint' will be NULL if we're looking up before adding anything
>> to the IDR.
>>
>> Signed-off-by: Sasha Levin
>
> An
IDs were in use, it would have returned pointer for the incorrect
> entry.
>
> Signed-off-by: Tejun Heo
> Reported-by: Sasha Levin
> Cc: Thomas Gleixner
> ---
> Sasha, can you please test whether this makes the warning go away?
Looks like it did.
Thanks,
Sasha
--
To unsubscri
1 - 100 of 33307 matches
Mail list logo
