Re: [PATCH] rc: correctly handling failed allocation

2016-02-16 Thread Sean Young
On Mon, Feb 15, 2016 at 09:33:11PM -0500, Insu Yun wrote: > Since rc_allocate_device() uses kmalloc, > it can returns NULL, so need to check, > otherwise, NULL derefenrece can be happened. Thanks for catching that. > Signed-off-by: Insu Yun > --- >

Re: [RFC 5/7] [media] ir-lirc-codec: do not handle any buffer for raw transmitters

2016-07-21 Thread Sean Young
Hi Andi, On Thu, Jul 21, 2016 at 09:48:12AM +0900, Andi Shyti wrote: > > > Raw transmitters receive the data which need to be sent to > > > receivers from userspace as stream of bits, they don't require > > > any handling from the lirc framework. > > > > No drivers of type RC_DRIVER_IR_RAW_TX

Re: [RFC 7/7] [media] rc: add support for IR LEDs driven through SPI

2016-07-21 Thread Sean Young
Hi Andi, On Thu, Jul 21, 2016 at 10:09:26AM +0900, Andi Shyti wrote: > > > + ret = regulator_enable(idata->regulator); > > > + if (ret) > > > + return ret; > > > + > > > + mutex_lock(>mutex); > > > + idata->xfer.len = n; > > > + idata->xfer.tx_buf = buffer; > > > + mutex_unlock(>mutex); >

Re: [RFC 7/7] [media] rc: add support for IR LEDs driven through SPI

2016-07-19 Thread Sean Young
On Wed, Jul 20, 2016 at 12:56:58AM +0900, Andi Shyti wrote: > The ir-spi is a simple device driver which supports the > connection between an IR LED and the MOSI line of an SPI device. > > The driver, indeed, uses the SPI framework to stream the raw data > provided by userspace through a

Re: [RFC 1/7] [media] rc-main: assign driver type during allocation

2016-07-19 Thread Sean Young
ere lots of issues that checkpatch.pl would pick in these series. > > Suggested-by: Sean Young <s...@mess.org> > Signed-off-by: Andi Shyti <andi.sh...@samsung.com> > --- > drivers/media/rc/rc-main.c | 4 +++- > include/media/rc-core.h| 2 +- > 2 files changed, 4 inse

Re: [RFC 3/7] [media] rc-core: add support for IR raw transmitters

2016-07-19 Thread Sean Young
ce applications, therefore they > don't need any input device allocation, but still they need to be > registered as raw devices. > > Suggested-by: Sean Young <s...@mess.org> > Signed-off-by: Andi Shyti <andi.sh...@samsung.com> > --- > drivers/media/rc/rc-main.c | 35

Re: [RFC 5/7] [media] ir-lirc-codec: do not handle any buffer for raw transmitters

2016-07-19 Thread Sean Young
On Wed, Jul 20, 2016 at 12:56:56AM +0900, Andi Shyti wrote: > Raw transmitters receive the data which need to be sent to > receivers from userspace as stream of bits, they don't require > any handling from the lirc framework. No drivers of type RC_DRIVER_IR_RAW_TX should handle tx just like any

Re: [PATCH] media: rc: nuvoton: decrease size of raw event fifo

2016-07-06 Thread Sean Young
On Tue, Jul 05, 2016 at 07:48:34PM +0200, Heiner Kallweit wrote: > Am 05.07.2016 um 11:17 schrieb Sean Young: > > On Tue, Jul 05, 2016 at 08:05:16AM +0200, Heiner Kallweit wrote: > >> Am 04.07.2016 um 23:06 schrieb Sean Young: > >>> On Mon, Jul 04, 2016 at 10:51:50P

Re: [PATCH v2 15/15] [media] include: lirc: add LIRC_GET_LENGTH command

2016-07-01 Thread Sean Young
On Fri, Jul 01, 2016 at 05:01:38PM +0900, Andi Shyti wrote: > Added the get length command to allow userspace users to check on > the data length. So what does LIRC_GET_LENGTH do? If you want to add an ioctl, it need justification, documenting in

Re: [PATCH] [media] rc: ir-spi: add support for IR LEDs connected with SPI

2016-07-01 Thread Sean Young
On Fri, Jul 01, 2016 at 05:33:42PM +0900, Andi Shyti wrote: > The ir-spi is a simple device driver which supports the > connection between an IR LED and the MOSI line of an SPI device. > > The driver, indeed, uses the SPI framework to stream the raw data > provided by userspace through a

Re: [PATCH] [media] rc: ir-spi: add support for IR LEDs connected with SPI

2016-07-01 Thread Sean Young
On Fri, Jul 01, 2016 at 09:30:35PM +0900, Andi Shyti wrote: > Hi Sean, > > > > The ir-spi is a simple device driver which supports the > > > connection between an IR LED and the MOSI line of an SPI device. > > > > > > The driver, indeed, uses the SPI framework to stream the raw data > > >

Re: [PATCH 15/15] include: lirc: add set length and frequency ioctl options

2016-06-29 Thread Sean Young
On Wed, Jun 29, 2016 at 10:20:44PM +0900, Andi Shyti wrote: > The Lirc framework works mainly with receivers, but there is > nothing that prevents us from using it for transmitters as well. The lirc interface already provides for transmitting IR. > For that we need to have more control on the

Re: [PATCH v2 02/15] [media] lirc_dev: allow bufferless driver registration

2016-07-02 Thread Sean Young
On Fri, Jul 01, 2016 at 05:01:25PM +0900, Andi Shyti wrote: > Some drivers don't necessarily need to have a FIFO managed buffer > for their transfers. Drivers now should call > lirc_register_bufferless_driver in order to handle the buffer > themselves. > > The function works exaclty like

Re: [PATCH RESEND] staging: media: lirc: use new parport device model

2017-01-30 Thread Sean Young
On Sat, Jan 21, 2017 at 12:55:54AM +, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > Modify lirc_parallel driver to use the new parallel port device model. > > Signed-off-by: Sudip Mukherjee > --- > > Resending after

Re: [PATCH] Staging: media: lirc: style fix, using octal file permissions

2017-01-30 Thread Sean Young
On Sat, Jan 07, 2017 at 04:02:55PM +1300, Derek Robson wrote: > Change file permissions to octal style. > Found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/staging/media/lirc/lirc_imon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [WARNING: A/V UNSCANNABLE][Merge tag 'media/v4.11-1' of git] ff58d005cd: BUG: unable to handle kernel NULL pointer dereference at 0000039c

2017-02-25 Thread Sean Young
On Fri, Feb 24, 2017 at 11:15:51AM -0800, Linus Torvalds wrote: > Added more relevant people. I've debugged the immediate problem below, > but I think there's another problem that actually triggered this. > > On Fri, Feb 24, 2017 at 10:28 AM, kernel test robot > wrote: >

[PATCH] [media] serial_ir: ensure we're ready to receive interrupts

2017-02-25 Thread Sean Young
: <sta...@vger.kernel.org> # 4.10 Signed-off-by: Sean Young <s...@mess.org> --- drivers/media/rc/serial_ir.c | 243 +-- 1 file changed, 118 insertions(+), 125 deletions(-) diff --git a/drivers/media/rc/serial_ir.c b/drivers/media/rc/serial_ir.c i

Re: [PATCH 1/5] [media] ir-rx51: port to rc-core

2017-01-16 Thread Sean Young
Hi Ivo, On Fri, Dec 30, 2016 at 03:50:42PM +0200, Ivaylo Dimitrov wrote: > On 30.12.2016 15:30, Sean Young wrote: > > > >On Fri, Dec 30, 2016 at 01:07:52PM +0000, Sean Young wrote: > >>Hi Ivo,, > >> > >>On Fri, Dec 30, 2016 at 01:30:01PM +0200, Ivayl

Re: [PATCH v2 3/7] [media] rc-core: add support for IR raw transmitters

2016-09-01 Thread Sean Young
ce applications, therefore they > don't need any input device allocation, but still they need to be > registered as raw devices. > > Suggested-by: Sean Young <s...@mess.org> > Signed-off-by: Andi Shyti <andi.sh...@samsung.com> > --- > drivers/media/rc/rc-main.c | 39 ++

Re: [PATCH v2 7/7] [media] rc: add support for IR LEDs driven through SPI

2016-09-01 Thread Sean Young
Thanks Andi, this is looking great! On Fri, Sep 02, 2016 at 02:16:29AM +0900, Andi Shyti wrote: > The ir-spi is a simple device driver which supports the > connection between an IR LED and the MOSI line of an SPI device. > > The driver, indeed, uses the SPI framework to stream the raw data >

Re: [PATCH v2 1/7] [media] rc-main: assign driver type during allocation

2016-09-01 Thread Sean Young
be > set as RC_DRIVER_SCANCODE which was the default '0' value. > > Suggested-by: Sean Young <s...@mess.org> > Signed-off-by: Andi Shyti <andi.sh...@samsung.com> > --- ... > diff --git a/drivers/media/pci/cx88/cx88-input.c > b/drivers/media/pci/cx88/cx88-input.c

Re: [PATCH v2 5/7] [media] ir-lirc-codec: don't wait any transmitting time for tx only devices

2016-09-02 Thread Sean Young
On Fri, Sep 02, 2016 at 02:16:27AM +0900, Andi Shyti wrote: > Transmitters do not need to wait until the data has been sent > (and of course received). Return before waiting. > > Signed-off-by: Andi Shyti > --- > drivers/media/rc/ir-lirc-codec.c | 2 +- > 1 file changed,

Re: [PATCH v2 7/7] [media] rc: add support for IR LEDs driven through SPI

2016-09-02 Thread Sean Young
On Fri, Sep 02, 2016 at 02:27:08PM +0900, Andi Shyti wrote: > > Thanks Andi, this is looking great! > > Thanks Sean! With your reviews the whole thing looks much better > now :) > > I agree with all your points here, I will fix them. Can I add > your reviewd-by? Yes, please add it to this

Re: console issue since 3.6, console=ttyS1 hangs

2016-10-25 Thread Sean Young
On Mon, Oct 24, 2016 at 04:49:25PM -0500, Nathan Zimmer wrote: > [0.974874] system 00:03: Plug and Play ACPI device, IDs PNP0c02 (active) > [0.975038] pnp 00:04: parse resource options > [0.975048] pnp 00:04: dependent set 0 (acceptable) io min 0x2f8 max > 0x2f8 align 1 size 8

Re: [PATCH v2 5/7] [media] ir-lirc-codec: don't wait any transmitting time for tx only devices

2016-10-27 Thread Sean Young
On Thu, Oct 27, 2016 at 04:44:01PM +0900, Andi Shyti wrote: > Hi Sean, > > it's been a while :) > > I was going through your review fixing what needs to be fixed, > but... > > > > @@ -153,7 +153,7 @@ static ssize_t ir_lirc_transmit_ir(struct file *file, > > > const char __user *buf, > > > }

Re: console issue since 3.6, console=ttyS1 hangs

2016-10-27 Thread Sean Young
On Wed, Oct 26, 2016 at 01:16:16PM -0500, Nathan Zimmer wrote: > On 10/25/2016 03:41 PM, Sean Young wrote: > >On Mon, Oct 24, 2016 at 04:49:25PM -0500, Nathan Zimmer wrote: > >>[1.565062] serial8250: ttyS1 at I/O 0x2f8 (irq = 3) is a 16550A > >The isa probe dri

Re: console issue since 3.6, console=ttyS1 hangs

2016-10-29 Thread Sean Young
On Fri, Oct 28, 2016 at 02:42:25PM -0500, Nathan Zimmer wrote: > On Thu, Oct 27, 2016 at 09:19:16PM +0100, Sean Young wrote: > > On Wed, Oct 26, 2016 at 01:16:16PM -0500, Nathan Zimmer wrote: > > > On 10/25/2016 03:41 PM, Sean Young wrote: > > > >On Mon, Oct 24, 20

Re: [PATCH] media: fix uninitialized variable warning in dib0700_rc_urb_completion()

2016-11-08 Thread Sean Young
On Mon, Nov 07, 2016 at 08:41:12AM -0700, Shuah Khan wrote: > Fix the following uninitialized variable compiler warning: > > drivers/media/usb/dvb-usb/dib0700_core.c: In function > ‘dib0700_rc_urb_completion’: > drivers/media/usb/dvb-usb/dib0700_core.c:763:2: warning: ‘protocol’ may be > used

Re: console issue since 3.6, console=ttyS1 hangs

2016-10-18 Thread Sean Young
On Tue, Oct 18, 2016 at 11:40:04AM -0500, Nathan Zimmer wrote: > 3.7.0 > cat /sys/bus/pnp/drivers/serial/*/resources > state = active > io 0x2f8-0x2ff > irq 12 > dma disabled > > 3.6.0 > :~ # cat /sys/bus/pnp/drivers/serial/*/resources > cat: /sys/bus/pnp/drivers/serial/*/resources: No such file

Re: console issue since 3.6, console=ttyS1 hangs

2016-10-24 Thread Sean Young
On Fri, Oct 21, 2016 at 10:55:40AM -0500, Nathan Zimmer wrote: > It didn't seem to make a difference as far as output. > Did I miss a config option? or something else? > > [0.00] Linux version 3.6.0 (root@r1i2n0) (gcc version 4.3.4 > [gcc-4_3-branch revision 152973] (SUSE Linux) ) #3 SMP

Re: console issue since 3.6, console=ttyS1 hangs

2016-10-20 Thread Sean Young
On Wed, Oct 19, 2016 at 05:13:41PM -0500, Nathan Zimmer wrote: > On 10/19/2016 04:07 AM, Sean Young wrote: > >So with 3.6.0: > > > >>[2.079980] Serial: 8250/16550 driver, 8 ports, IRQ sharing disabled > >>[2.100887] serial8250: ttyS1 at I/O 0x2f8 (irq =

Re: console issue since 3.6, console=ttyS1 hangs

2016-10-19 Thread Sean Young
On Tue, Oct 18, 2016 at 02:29:30PM -0500, Nathan Zimmer wrote: > On Tue, Oct 18, 2016 at 07:05:18PM +0100, Sean Young wrote: > > On Tue, Oct 18, 2016 at 11:40:04AM -0500, Nathan Zimmer wrote: > > > 3.7.0 > > > cat /sys/bus/pnp/drivers/serial/*/resources > > >

Re: [PATCH v2 5/7] [media] ir-lirc-codec: don't wait any transmitting time for tx only devices

2016-11-01 Thread Sean Young
Hi Andi, On Tue, Nov 01, 2016 at 03:51:11PM +0900, Andi Shyti wrote: > > Andi, it would be good to know what the use-case for the original change is. > > the use case is the ir-spi itself which doesn't need the lirc to > perform any waiting on its behalf. Here is the crux of the problem: in

Re: console issue since 3.6, console=ttyS1 hangs

2016-10-31 Thread Sean Young
On Sun, Oct 30, 2016 at 10:33:02AM -0500, Nathan wrote: > I think this should be PNP0501 instead of PNP0c02. > Once I alter that then when I boot the serial comes up on irq 3. However it > still hangs. > I'll keep digging. Well that's that theory out of the window. I'm not sure where to look now,

Re: [PATCH v3 0/6] Add support for IR transmitters

2016-11-02 Thread Sean Young
s currently ongoing. Looks great! For the whole series: Reviewed-by: Sean Young <s...@mess.org> Thanks, Sean

Re: [PATCH v2 5/7] [media] ir-lirc-codec: don't wait any transmitting time for tx only devices

2016-10-31 Thread Sean Young
Hi David, Andi, On Mon, Oct 31, 2016 at 02:31:52PM +, David Härdeman wrote: > October 27, 2016 4:36 PM, "Sean Young" <s...@mess.org> wrote: > > Since we have to be able to switch between waiting and not waiting, > > we need some sort of ABI for this. I think thi

Re: [PATCH] [media] dib0700: fix nec repeat handling

2016-11-02 Thread Sean Young
On Sat, Oct 29, 2016 at 11:04:32PM +0200, Arnd Bergmann wrote: > On Thursday, October 13, 2016 10:28:44 PM CEST Sean Young wrote: > > When receiving a nec repeat, ensure the correct scancode is repeated > > rather than a random value from the stack. This removes the need &g

Re: [PATCH] [media] rc: Fix uninitialized variable in debug print

2016-10-13 Thread Sean Young
mediate "toggle" variable, like is done in > other branches. > > Fixes: 00bb820755ed8ee9 ("[media] rc: Hauppauge z8f0811 can decode RC6") > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> Thanks for finding this and writing a patch. Acked-by: Sean Young &l

Re: [PATCH] [media] dib0700: Fix uninitialized protocol for NEC repeat codes

2016-10-13 Thread Sean Young
On Thu, Oct 13, 2016 at 03:51:39PM +0200, Geert Uytterhoeven wrote: > drivers/media/usb/dvb-usb/dib0700_core.c: In function > ‘dib0700_rc_urb_completion’: > drivers/media/usb/dvb-usb/dib0700_core.c:679: warning: ‘protocol’ may be > used uninitialized in this function > > When receiving

[PATCH] [media] dib0700: fix nec repeat handling

2016-10-13 Thread Sean Young
/media/usb/dvb-usb/dib0700_core.c:679: warning: ‘protocol’ may be used uninitialized in this function Signed-off-by: Sean Young <s...@mess.org> --- drivers/media/usb/dvb-usb/dib0700_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/d

Re: [PATCH 12/18] [media] RedRat3: Move a variable assignment in redrat3_init_rc_dev()

2016-10-13 Thread Sean Young
On Thu, Oct 13, 2016 at 06:39:23PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 13 Oct 2016 14:50:05 +0200 > > Move the assignment for the local variable "prod" behind the source code > for a memory allocation by this function. The redrat3

Re: console issue since 3.6, console=ttyS1 hangs

2016-10-17 Thread Sean Young
d in here: > > commit 835d844d1a28efba81d5aca7385e24c29d3a6db2 > Author: Sean Young <s...@mess.org> > Date: Fri Sep 7 19:06:23 2012 +0100 > > 8250_pnp: do pnp probe before legacy probe > > > I found I can revert the part of the patch in 8250.c (now 8250_core.c

Re: [PATCH 04/18] [media] RedRat3: One function call less in redrat3_transmit_ir() after error detection

2016-10-15 Thread Sean Young
On Thu, Oct 13, 2016 at 06:24:46PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 13 Oct 2016 10:50:24 +0200 > > The kfree() function was called in one case by the > redrat3_transmit_ir() function during error handling > even if the passed

Re: [PATCH 4/5] [media] winbond-cir: One variable and its check less in wbcir_shutdown() after error detection

2016-10-15 Thread Sean Young
On Fri, Oct 14, 2016 at 01:44:02PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 14 Oct 2016 12:48:41 +0200 > > The local variable "do_wake" was set to "false" after an invalid system > setting was detected so that a bit of error handling was

Re: [PATCH v5 2/6] [media] rc-main: split setup and unregister functions

2016-12-16 Thread Sean Young
ctions. > > Signed-off-by: Andi Shyti <andi.sh...@samsung.com> > Reviewed-by: Sean Young <s...@mess.org> > --- > drivers/media/rc/rc-main.c | 143 > + > 1 file changed, 81 insertions(+), 62 deletions(-) > > diff --git

Re: [PATCH v4 2/6] [media] rc-main: split setup and unregister functions

2016-12-15 Thread Sean Young
yti <andi.sh...@samsung.com> > Reviewed-by: Sean Young <s...@mess.org> > --- > drivers/media/rc/rc-main.c | 143 > + > 1 file changed, 81 insertions(+), 62 deletions(-) > > diff --git a/drivers/media/rc/rc-main.c b/drivers/media

Re: [PATCH v5 2/6] [media] rc-main: split setup and unregister functions

2016-12-16 Thread Sean Young
Hi Andi, On Fri, Dec 16, 2016 at 12:10:26PM +, Sean Young wrote: > Sorry to add to your woes, but there are some checkpatch warnings and > errors. Please can you correct these. One is below. Actually, the changes are pretty minor, I can fix them up before sending them to Mauro.

Re: [PATCH v2 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

2017-01-10 Thread Sean Young
Hi Sean, The driver is looking very good, we are looking at minor details now. On Tue, Jan 10, 2017 at 09:59:49PM +0800, Sean Wang wrote: > On Tue, 2017-01-10 at 11:09 +0000, Sean Young wrote: > > > > +#include > > > +#include > > > +#include > > > +

Re: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

2017-01-05 Thread Sean Young
Hi Sean, Some review comments. On Fri, Jan 06, 2017 at 12:06:24AM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > This patch adds driver for IR controller on > Mediatek MT7623 SoC. Currently testing successfully > on NEC and SONY remote controller only but it

Re: [PATCH 1/5] [media] ir-rx51: port to rc-core

2016-12-30 Thread Sean Young
Hi Ivo,, On Fri, Dec 30, 2016 at 01:30:01PM +0200, Ivaylo Dimitrov wrote: > On 20.12.2016 19:50, Sean Young wrote: > >This driver was written using lirc since rc-core did not support > >transmitter-only hardware at that time. Now that it does, port > >this driver. >

Re: [PATCH 1/5] [media] ir-rx51: port to rc-core

2016-12-30 Thread Sean Young
On Fri, Dec 30, 2016 at 01:07:52PM +, Sean Young wrote: > Hi Ivo,, > > On Fri, Dec 30, 2016 at 01:30:01PM +0200, Ivaylo Dimitrov wrote: > > On 20.12.2016 19:50, Sean Young wrote: > > >This driver was written using lirc since rc-core did not support > > >trans

Re: [PATCH 1/5] [media] ir-rx51: port to rc-core

2016-12-30 Thread Sean Young
Hi Ivo, On Fri, Dec 30, 2016 at 03:50:42PM +0200, Ivaylo Dimitrov wrote: > On 30.12.2016 15:30, Sean Young wrote: > >On Fri, Dec 30, 2016 at 01:07:52PM +0000, Sean Young wrote: > >Speaking of which, if you would please test this, that would be great. My > >N900 died many ye

Re: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

2017-01-09 Thread Sean Young
On Mon, Jan 09, 2017 at 11:13:21AM +0800, Sean Wang wrote: > I had another question. I found multiple and same IR messages being > received when using SONY remote controller. Should driver needs to > report each message or only one of these to the upper layer ? In general the driver shouldn't try

Re: [PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

2017-01-08 Thread Sean Young
Hi Sean, On Fri, Jan 06, 2017 at 03:31:25PM +0800, Sean Wang wrote: > On Thu, 2017-01-05 at 17:12 +0000, Sean Young wrote: > > On Fri, Jan 06, 2017 at 12:06:24AM +0800, sean.w...@mediatek.com wrote: > > > + /* Handle pulse and space until end of message */ > > > + for

Re: [PATCH v2 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

2017-01-10 Thread Sean Young
testing successfully on NEC and SONY remote controller > only but it should work on others (lirc, rc-5 and rc-6). > > Signed-off-by: Sean Wang <sean.w...@mediatek.com> > Reviewed-by: Sean Young <s...@mess.org> > --- > drivers/media/rc/Kconfig | 11 ++ > drivers/me

[PATCH 0/5] Lirc staging drivers

2016-12-20 Thread Sean Young
drivers were merged in 2010, and other than trival patches, they have not made any progress towards mainline. ir-rx51 is not a staging driver, but it should not rely on the lirc in-kernel API like the staging drivers do. Sean Young (5): [media] ir-rx51: port to rc-core [media] staging: lirc_sir

[PATCH 1/5] [media] ir-rx51: port to rc-core

2016-12-20 Thread Sean Young
This driver was written using lirc since rc-core did not support transmitter-only hardware at that time. Now that it does, port this driver. Compile tested only. Signed-off-by: Sean Young <s...@mess.org> Cc: Timo Kokkonen <timo.t.kokko...@iki.fi> Cc: Ivaylo Dimitrov <ivo.g.dimitr

[PATCH 3/5] [media] staging: lirc_parallel: remove

2016-12-20 Thread Sean Young
The lirc_parallel driver was merged in 2010 and noone has attempted to do the work necessary to get it out of staging (i.e. port it to rc-core). I have not been able to find one of these devices, and a machine with a parallel port is pretty rare too. Signed-off-by: Sean Young <s...@mess.org&

[PATCH 4/5] [media] staging: lirc_bt829: remove

2016-12-20 Thread Sean Young
. Signed-off-by: Sean Young <s...@mess.org> Cc: Jarod Wilson <ja...@redhat.com> Cc: Leonid Froenchenko <lfr...@galileo.co.il> --- drivers/staging/media/lirc/Kconfig | 6 - drivers/staging/media/lirc/Makefile | 1 - drivers/staging/media/lirc/

[PATCH 2/5] [media] staging: lirc_sir: port to rc-core

2016-12-20 Thread Sean Young
Before this driver can be moved out of staging, it should be ported to rc-core. I've tried to make the minimum changes possible without upsetting checkpatch. Compile tested only. Signed-off-by: Sean Young <s...@mess.org> Cc: Jarod Wilson <ja...@redhat.com> Cc: Christoph

[PATCH 5/5] [media] staging: lirc_imon: port remaining usb ids to imon and remove

2016-12-20 Thread Sean Young
staging to mainline imon. Now that mainline imon can handle these four devices, lirc_imon is no longer needed. Compile tested only. Signed-off-by: Sean Young <s...@mess.org> Cc: Venky Raju <d...@venky.ws> Cc: Jarod Wilson <ja...@redhat.com> Cc: Alexey Khoroshilov <

Re: linux-next: manual merge of the staging tree with the v4l-dvb tree

2017-04-06 Thread Sean Young
On Thu, Apr 06, 2017 at 09:19:22PM +0200, Greg KH wrote: > On Thu, Apr 06, 2017 at 07:58:57PM +0100, Sean Young wrote: > > On Thu, Apr 06, 2017 at 01:34:20PM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > Today's linux-next mer

Re: linux-next: manual merge of the staging tree with the v4l-dvb tree

2017-04-06 Thread Sean Young
On Thu, Apr 06, 2017 at 01:34:20PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the staging tree got conflicts in: > > drivers/staging/media/lirc/lirc_sasem.c > drivers/staging/media/lirc/lirc_sir.c > > between commits: > > e66267161971 ("[media] rc: promote

Re: [PATCH 4.10 084/110] [media] rx51: broken build

2017-04-11 Thread Sean Young
On Mon, Apr 10, 2017 at 06:43:15PM +0200, Greg Kroah-Hartman wrote: > 4.10-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Sean Young <s...@mess.org> > > [ Upstream commit 922ee72da7c739157ed02ea04a5c100d

Re: [PATCH v1 0/4] media: rc: add support for IR receiver on MT7622 SoC

2017-08-02 Thread Sean Young
Hi Sean, On Wed, Aug 02, 2017 at 10:24:07AM +0800, Sean Wang wrote: > Hi, Mauro and Sean > > Just a gentle ping on the whole patchset porting MediaTek CIR to another > platform. I'm creating the rc-core pull request, should be done by the end of the week. Sean

Re: [PATCH 2/3] [media] rc: constify usb_device_id

2017-08-15 Thread Sean Young
v <arvind.yadav...@gmail.com> Acked-by: Sean Young <s...@mess.org> Thanks for spotting that. Sean > --- > drivers/media/rc/ati_remote.c | 2 +- > drivers/media/rc/igorplugusb.c | 2 +- > drivers/media/rc/imon.c| 2 +- > drivers/media/rc/mceusb.c |

Re: [PATCH] imon: constify attribute_group structures

2017-08-10 Thread Sean Young
On Fri, Aug 04, 2017 at 09:51:38PM -0400, Amitoj Kaur Chawla wrote: > Functions working with attribute_groups provided by > work with const attribute_group. These attribute_group structures do not > change at runtime so mark them as const. I'm afraid the exact same patch has already been

[PATCH v4.13 REGRESSION] Revert "serial: Delete dead code for CIR serial ports"

2017-08-01 Thread Sean Young
) is a CIR port lirc lirc0: lirc_dev: driver ir-lirc-codec (winbond-cir) registered at minor = 0 winbond-cir 00:03: Region 0x2f8-0x2ff already in use! winbond-cir: probe of 00:03 failed with error -16 Signed-off-by: Sean Young <s...@mess.org> --- drivers/tty/serial/8250/8250_core.

[PATCH] [media] sir_ir: infinite loop in interrupt handler

2017-05-16 Thread Sean Young
Since this driver does no detection of hardware, it might be used with a non-sir port. Escape out if we are spinning. Signed-off-by: Sean Young <s...@mess.org> --- drivers/media/rc/sir_ir.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/rc/sir_ir.c b/drivers/me

Re: [[media] rc] e662671619: BUG: kernel hang in test stage

2017-05-16 Thread Sean Young
756b4e17f2f2f82b9f842 > Author: Sean Young <s...@mess.org> > AuthorDate: Tue Mar 7 17:07:59 2017 -0300 > Commit: Mauro Carvalho Chehab <mche...@s-opensource.com> > CommitDate: Wed Apr 5 14:50:57 2017 -0300 > > [media] rc: promote lirc_sir out of staging &g

[PATCH v3 26/26] kfifo: DECLARE_KIFO_PTR(fifo, u64) does not work on arm 32 bit

2017-10-10 Thread Sean Young
returns EINVAL. So, ensure that __is_kfifo_ptr() compares to the right structure. Signed-off-by: Sean Young <s...@mess.org> Acked-by: Stefani Seibold <stef...@seibold.net> --- include/linux/kfifo.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/lin

Re: [PATCH] media: default for RC_CORE should be n

2017-09-08 Thread Sean Young
On Fri, Sep 08, 2017 at 09:39:29AM -0700, Stephen Hemminger wrote: > The Linus policy on Kconfig is that the default should be no > for all new devices. I.e the user rebuild a new kernel from an > old config should not by default get a larger kernel. That might make sense for new config, but

[PATCH v3 26/26] kfifo: DECLARE_KIFO_PTR(fifo, u64) does not work on arm 32 bit

2017-10-10 Thread Sean Young
returns EINVAL. So, ensure that __is_kfifo_ptr() compares to the right structure. Signed-off-by: Sean Young <s...@mess.org> --- include/linux/kfifo.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h index 41eb6f

Re: [PATCH 1/2] [media] rc/keymaps: add support for RC of hisilicon TV demo boards

2017-10-18 Thread Sean Young
On Wed, Oct 18, 2017 at 06:54:56AM -0400, Jiancheng Xue wrote: > From: Younian Wang > > This is a NEC protocol type remote controller distributed with > hisilicon TV demo boards. > > Signed-off-by: Younian Wang > Signed-off-by: Jiancheng

Re: [PATCH v4 06/12] [media] cxd2880: Add integration layer for the driver

2017-12-03 Thread Sean Young
On Fri, Oct 13, 2017 at 03:08:34PM +0900, yasunari.takigu...@sony.com wrote: > From: Yasunari Takiguchi > > These functions monitor the driver and watch for task completion. > This is part of the Sony CXD2880 DVB-T2/T tuner + demodulator driver. > > Signed-off-by:

Re: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver

2017-12-03 Thread Sean Young
Hello, Many thanks for the driver. The ./scripts/checkpatch.pl with --strict has many warnings, some of which might be nice to have cleaned up. There are some very minor comments below. Similar constructs are in other files too. After reading and understanding through all the code, I think

Re: [PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

2017-12-17 Thread Sean Young
On Sun, Dec 17, 2017 at 11:45:43PM +0100, Philipp Rossak wrote: > This patch updates the sunxi-ir driver to set the base clock frequency from > devicetree. > > This is neccessary since there are different ir recievers on the > market, that operate with different frequencys. So this value could be

Re: 4.14 regression from commit d57ea877af38 media: rc: per-protocol repeat period

2017-11-16 Thread Sean Young
On Thu, Nov 16, 2017 at 04:27:01PM +0100, Matthias Reichl wrote: > The following commit introduced a regression > > commit d57ea877af38057b0ef31758cf3b99765dc33695 > Author: Sean Young <s...@mess.org> > Date: Wed Aug 9 13:19:16 2017 -0400 > > media: rc:

Re: [PATCH] media: rc: double keypresses due to timeout expiring to early

2017-11-19 Thread Sean Young
On Fri, Nov 17, 2017 at 03:52:50PM +0100, Matthias Reichl wrote: > Hi Sean! > > On Thu, Nov 16, 2017 at 09:54:51PM +0000, Sean Young wrote: > > Since commit d57ea877af38 ("media: rc: per-protocol repeat period"), > > double keypresses are reported on the ite-

Re: [PATCH 2/6] media: rc keymaps: add SPDX identifiers to the code I wrote

2017-11-19 Thread Sean Young
On Fri, Nov 17, 2017 at 08:21:29AM -0200, Mauro Carvalho Chehab wrote: > As we're now using SPDX identifiers, on the several > RC keymap files I wrote, add the proper SPDX, identifying > the license I meant. > > As we're now using the short license, it doesn't make sense to > keep the original

[PATCH] media: rc: double keypresses due to timeout expiring to early

2017-11-16 Thread Sean Young
. So, add the IR timeout to the keyup timeout. Cc: <sta...@vger.kernel.org> # 4.14 Reported-by: Matthias Reichl <h...@horus.com> Signed-off-by: Sean Young <s...@mess.org> --- drivers/media/rc/rc-main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH] media: ttpci: remove autorepeat handling and use timer_setup

2017-10-31 Thread Sean Young
Leave the autorepeat handling up to the input layer, and move to the new timer API. Compile tested only. Signed-off-by: Sean Young <s...@mess.org> --- drivers/media/pci/ttpci/av7110.h| 2 +- drivers/media/pci/ttpci/av7110_ir.c | 54 ++--- 2 files chang

Re: [PATCH] media: av7110: switch to useing timer_setup()

2017-10-31 Thread Sean Young
On Tue, Oct 24, 2017 at 05:40:05PM -0700, Dmitry Torokhov wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Also stop poking into input core

Re: [PATCH] media: ttpci: remove autorepeat handling and use timer_setup

2017-10-31 Thread Sean Young
Hi Dmitry, On Tue, Oct 31, 2017 at 11:22:36AM -0700, Dmitry Torokhov wrote: > Hi Sean, > > On Tue, Oct 31, 2017 at 05:45:58PM +0000, Sean Young wrote: > > Leave the autorepeat handling up to the input layer, and move > > to the new timer API. > > > > Compile

[PATCH v2] media: ttpci: remove autorepeat handling and use timer_setup

2017-10-31 Thread Sean Young
Leave the autorepeat handling up to the input layer, and move to the new timer API. Compile tested only. Signed-off-by: Sean Young <s...@mess.org> --- v2: - fixes and improvements from Dmitry Torokhov drivers/media/pci/ttpci/av7110.h| 2 +- drivers/media/pci/ttpci/av7110_ir.

[PATCH v1 1/4] media: rc: introduce BPF_PROG_IR_DECODER

2018-05-14 Thread Sean Young
Add support for BPF_PROG_IR_DECODER. This type of BPF program can call rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report that the last key should be repeated. Signed-off-by: Sean Young <s...@mess.org> --- drivers/media/rc/Kconfig | 8 +++ drivers/media/rc/Ma

[PATCH v1 4/4] samples/bpf: an example of a raw IR decoder

2018-05-14 Thread Sean Young
This implements the grundig-16 IR protocol. Signed-off-by: Sean Young <s...@mess.org> --- samples/bpf/Makefile | 4 + samples/bpf/bpf_load.c| 9 +- samples/bpf/grundig_decoder_kern.c| 112 ++ sampl

[PATCH v1 3/4] media: rc bpf: move ir_raw_event to uapi

2018-05-14 Thread Sean Young
The context provided to a BPF_PROG_RAWIR_DECODER is a struct ir_raw_event; ensure user space has a a definition. Signed-off-by: Sean Young <s...@mess.org> --- include/media/rc-core.h| 19 +-- include/uapi/linux/bpf_rcdev.h | 24 2 files c

[PATCH v1 0/4] IR decoding using BPF

2018-05-14 Thread Sean Young
s underway to extend ir-keytable to have an extensive library of bpf-based decoders, and a much expanded library of rc keymaps. Another future application would be to compile IRP[3] to a IR BPF program, and so support virtually every remote without having to write a decoder for each. Thanks, Sean

[PATCH v1 2/4] media: bpf: allow raw IR decoder bpf programs to be used

2018-05-14 Thread Sean Young
This implements attaching, detaching, querying and execution. The target fd has to be the /dev/lircN device. Signed-off-by: Sean Young <s...@mess.org> --- drivers/media/rc/ir-bpf-decoder.c | 191 ++ drivers/media/rc/lirc_dev.c | 30 + drivers/media

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-17 Thread Sean Young
Hi Quentin, On Thu, May 17, 2018 at 01:10:56PM +0100, Quentin Monnet wrote: > 2018-05-16 22:04 UTC+0100 ~ Sean Young <s...@mess.org> > > Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call > > rc_keydown() to reported decoded IR scancodes, or

Re: [PATCH v2 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-16 Thread Sean Young
On Tue, May 15, 2018 at 07:50:19PM +0100, Sean Young wrote: > Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report > that the last key should be repeated. > > The bpf program can be at

Re: [PATCH v1 4/4] samples/bpf: an example of a raw IR decoder

2018-05-15 Thread Sean Young
On Mon, May 14, 2018 at 10:34:57PM -0700, Y Song wrote: > On Mon, May 14, 2018 at 2:11 PM, Sean Young <s...@mess.org> wrote: > > This implements the grundig-16 IR protocol. > > > > Signed-off-by: Sean Young <s...@mess.org> > > --- > > samples/bpf/Makef

Re: [PATCH v1 1/4] media: rc: introduce BPF_PROG_IR_DECODER

2018-05-15 Thread Sean Young
On Mon, May 14, 2018 at 04:27:19PM -0700, Randy Dunlap wrote: > On 05/14/2018 02:10 PM, Sean Young wrote: > > Add support for BPF_PROG_IR_DECODER. This type of BPF program can call > > Kconfig file below uses IR_BPF_DECODER instead of the symbol name above. > > and then

Re: [PATCH v1 1/4] media: rc: introduce BPF_PROG_IR_DECODER

2018-05-15 Thread Sean Young
On Mon, May 14, 2018 at 09:48:05PM -0700, Y Song wrote: > On Mon, May 14, 2018 at 2:10 PM, Sean Young <s...@mess.org> wrote: > > Add support for BPF_PROG_IR_DECODER. This type of BPF program can call > > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report

[PATCH v2 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-15 Thread Sean Young
device. Signed-off-by: Sean Young <s...@mess.org> --- drivers/media/rc/Kconfig | 10 + drivers/media/rc/Makefile | 1 + drivers/media/rc/bpf-rawir-event.c | 322 + drivers/media/rc/lirc_dev.c| 28 +++ drivers/media/rc/rc-core-priv.h

[PATCH v2 0/2] IR decoding using BPF

2018-05-15 Thread Sean Young
s underway to extend ir-keytable to have an extensive library of bpf-based decoders, and a much expanded library of rc keymaps. Another future application would be to compile IRP[3] to a IR BPF program, and so support virtually every remote without having to write a decoder for each. Thanks, Sean

[PATCH v2 2/2] bpf: add selftest for rawir_event type program

2018-05-15 Thread Sean Young
This is simple test over rc-loopback. Signed-off-by: Sean Young <s...@mess.org> --- tools/bpf/bpftool/prog.c | 1 + tools/include/uapi/linux/bpf.h| 55 +++- tools/lib/bpf/libbpf.c| 1 + tools/testing/selftests/bpf/Ma

Re: [PATCH v4 0/3] IR decoding using BPF

2018-05-23 Thread Sean Young
On Wed, May 23, 2018 at 02:21:27PM +0200, Daniel Borkmann wrote: > On 05/18/2018 04:07 PM, Sean Young wrote: > > The kernel IR decoders (drivers/media/rc/ir-*-decoder.c) support the most > > widely used IR protocols, but there are many protocols which are not > > supp

Re: [PATCH v4 2/3] media: rc: introduce BPF_PROG_LIRC_MODE2

2018-05-26 Thread Sean Young
On Fri, May 25, 2018 at 01:45:11PM -0700, Alexei Starovoitov wrote: > On Fri, May 18, 2018 at 03:07:29PM +0100, Sean Young wrote: > > Add support for BPF_PROG_LIRC_MODE2. This type of BPF program can call > > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report &g

  1   2   >