Re: [PATCH 00/19 v2] Improve IRQ remapping abstraction in x86 core code

2012-11-01 Thread Sebastian Andrzej Siewior
On Wed, Sep 19, 2012 at 04:52:27PM +0200, Joerg Roedel wrote: Hi Sebastian, Hi Joerg, After browsing through the new functions in irq_remapping_modify_x86_ops() I see that some of them test for remap_ops which is pointless because you don't call irq_remapping_modify_x86_ops() if it is

Re: [PATCH 00/19 v3] Improve IRQ remapping abstraction in x86 core code

2012-11-01 Thread Sebastian Andrzej Siewior
mentioned, Acked-by: Sebastian Andrzej Siewior sebast...@breakpoint.cc Sebastian -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCAAGBQJQkuuWAAoJEHuW6BYqjPXRnVwP/08DxdazUY4SOPIvBK4+gZh7 3VW5EdTLjBSYnaWEFccwhaqqq6FgJ5MfJ862sSXUpejjApDFQdOQPlZmIwfY5lFh n3z20/6Nvum6mCvZLUEi7D

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-24 Thread Sebastian Andrzej Siewior
On Mon, Oct 08, 2012 at 11:59:03PM +0300, Dmytro Milinevskyy wrote: Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com --- drivers/usb/gadget/f_ncm.c

Re: lockdep says circular locking since tty: localise the lock

2012-10-24 Thread Sebastian Andrzej Siewior
On Wed, Oct 17, 2012 at 09:20:35PM +0200, Sebastian Andrzej Siewior wrote: With dummy_hcd and g_nokia (that is CONFIG_USB_GADGET=m, CONFIG_USB_DUMMY_HCD=m, CONFIG_USB_G_NOKIA=m) I see a lockdep complaing about a circular locking dependency after executing ping? Or is it an obvious false

[PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-24 Thread Sebastian Andrzej Siewior
From: Sebastian Andrzej Siewior bige...@linutronix.de Date: Wed, 24 Oct 2012 16:40:10 +0200 found by randconfig, Randy Dunlap and Stephen Rothwell: |drivers/built-in.o: In function `fsg_setup': |file_storage.c:(.text+0x24db7c): undefined reference to `usb_gadget_config_buf' |file_storage.c

Re: lockdep says circular locking since tty: localise the lock

2012-10-24 Thread Sebastian Andrzej Siewior
On Wed, Oct 24, 2012 at 11:13:18AM -0400, Alan Stern wrote: Are you pinging yourself? That's what it looks like... :-) Hehe. It seems that it got the job done :) Alan Stern Sebastian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-24 Thread Sebastian Andrzej Siewior
On Wed, Oct 24, 2012 at 07:30:42PM +0200, Michal Nazarewicz wrote: At first it looks strange as FSG does not use composite, but yeah: Yeah. However, it should be removed in v3.8 anyway :) Acked-by: Michal Nazarewicz min...@mina86.com Sebastian -- To unsubscribe from this list: send the line

Re: [PATCH 3/3] x86: ce4100: fixup PCI configuration register access for devices without interrupts

2012-10-26 Thread Sebastian Andrzej Siewior
the configuration space. So they realy don't have an Interrupt. I assumed that I was not good enough reading the table and matching the entries to the HW. Signed-off-by: Florian Fainelli ffaine...@freebox.fr Acked-by: Sebastian Andrzej Siewior bige...@linutronix.de for patches 1-3 Sebastian -- To unsubscribe

Re: [PATCH] x86/dt: use linear irq domain for ioapic(s).

2012-10-26 Thread Sebastian Andrzej Siewior
* Florian Fainelli | 2012-10-19 15:40:29 [+0200]: On Friday 19 October 2012 11:36:25 Fainelli wrote: Sebastian Andrzej Siewior bigeasy at linutronix.de writes: No. You do have a compatible entry. It first appeared on the ce4100 CPU. If it happens to also work on the n450 then it seems

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-28 Thread Sebastian Andrzej Siewior
On Sun, Oct 28, 2012 at 06:30:02PM +0100, Dmytro Milinevskyy wrote: I was trying to keep 2 tabs but checkpatch didn't accept long line that's why I killed extra tab. Then move them to the code section instead to initialize them in the declaration section. How does it work? Is the test on host

[PATCH] drivers/base: fix typo in comment for arch_setup_pdev_archdata()

2012-10-29 Thread Sebastian Andrzej Siewior
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/base/platform.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 8727e9c..af1d47f 100644 --- a/drivers/base/platform.c +++ b/drivers/base

lockdep says circular locking since tty: localise the lock

2012-10-17 Thread Sebastian Andrzej Siewior
With dummy_hcd and g_nokia (that is CONFIG_USB_GADGET=m, CONFIG_USB_DUMMY_HCD=m, CONFIG_USB_G_NOKIA=m) I see a lockdep complaing about a circular locking dependency after executing |modprobe dummy_hcd |modprobe g_nokia |cat /dev/ttyACM0 |sleep 1 |echo basilimi /dev/ttyGS2 the first one goes

Re: [PATCH 2/3] kernel/SRCU: provide a static initializer

2013-04-08 Thread Sebastian Andrzej Siewior
On 04/05/2013 09:21 AM, Lai Jiangshan wrote: Hi, Sebastian Hi Lai, I don't want to expose __SRCU_STRUCT_INIT(), due to it has strong coupling with the percpu array. I hope other structure which uses SRCU should use init_srcu_struct(). I need a static initialization for this kind. Patch #3

Re: [PATCH 1/3] kernel/srcu: merge common code into a macro

2013-04-08 Thread Sebastian Andrzej Siewior
On 04/05/2013 09:21 AM, Lai Jiangshan wrote: Hi, Sebastian Hi Lai, The patch hurts readability. The original code are simple enough, merging them as one macro gives us no benefit. Except when you need to adjust the macro and you have to touch both of them instead just one. But I don't have

Re: [ANNOUNCE] 3.8.4-rt2

2013-04-08 Thread Sebastian Andrzej Siewior
* Paul Gortmaker | 2013-04-05 19:35:51 [-0400]: Thanks for the work in putting this together. Just a heads up that the split queue fails on a patch with no author/date/subject as follows: [...] git am of percpu-rwsem-compilefix.patch failed. This treercu-use-simple-waitqueue.patch has the

Re: [PATCH 2/3] kernel/SRCU: provide a static initializer

2013-04-11 Thread Sebastian Andrzej Siewior
* Lai Jiangshan | 2013-04-09 09:09:56 [+0800]: If the percpu array can be defined in __SRCU_STRUCT_INIT(), I'm happy to expose it. but it is not currently. I have no idea how to achieve this. Why crypto can't use boot time initialization? It would require something like this: ---

Re: [PATCH v3 00/23] ldisc fixes

2013-03-17 Thread Sebastian Andrzej Siewior
* Peter Hurley | 2013-03-05 17:20:29 [-0500]: Not sure I understood. tty_hangup() is only called from within gserial_disconnect() which calls right after usb_ep_disable(). After usb_ep_disable() no further serial packets can be received until the endpoints are re-enabled. This happens in

[PATCH 3/3] cpufreq: use static initializer for the SRCU notifier

2013-03-19 Thread Sebastian Andrzej Siewior
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/cpufreq/cpufreq.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 1f93dbd..cd5acda 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers

[PATCH 1/3] kernel/srcu: merge common code into a macro

2013-03-19 Thread Sebastian Andrzej Siewior
DEFINE_SRCU() and DEFINE_STATIC_SRCU() does the same thing except for the static attribute. This patch moves the common pieces into _DEFINE_SRCU() which is used by the the former macros either adding the static attribute or not. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de

[PATCH 2/3] kernel/SRCU: provide a static initializer

2013-03-19 Thread Sebastian Andrzej Siewior
-by: Sebastian Andrzej Siewior bige...@linutronix.de --- include/linux/notifier.h | 26 +- include/linux/srcu.h |6 +++--- 2 files changed, 24 insertions(+), 8 deletions(-) diff --git a/include/linux/notifier.h b/include/linux/notifier.h index d65746e..6bfd703 100644

Re: [PATCH 1/3] kernel/srcu: merge common code into a macro

2013-03-19 Thread Sebastian Andrzej Siewior
On 03/19/2013 05:22 PM, Joe Perches wrote: +#define DEFINE_SRCU(name) _DEFINE_SRCU(name, ) +#define DEFINE_STATIC_SRCU(name)_DEFINE_SRCU(name, static) I think the use of an empty argument, even in a macro, unsightly. __wait_event_lock_irq() = __wait_event_lock_irq() is a

[ANNOUNCE] 3.8.4-rt2

2013-03-26 Thread Sebastian Andrzej Siewior
Dear RT Folks, I'm pleased to announce the 3.8.4-rt2 release. changes since v3.8.4-rt1: - build fix for i915 (reported by Luis Claudio R. Goncalves) - build fix for fscache (reported by tglx) - build fix for !RT (kernel/softirq.c did not compile) - per-cpu rwsem fixed for RT (required only by

Re: Fixup for 3.4.34 merge conflict

2013-03-26 Thread Sebastian Andrzej Siewior
* Steven Rostedt | 2013-03-19 12:50:34 [-0400]: @@ -1054,19 +1032,39 @@ int __hrtimer_start_range_ns(struct hrtimer *timer, ktime_t tim, * * XXX send_remote_softirq() ? */ - if (leftmost new_base-cpu_base == __get_cpu_var(hrtimer_bases)) { - ret =

Re: linux-3.6.11-rt30 smoke test on ARM

2013-03-11 Thread Sebastian Andrzej Siewior
* Frank Rowand | 2013-03-07 20:03:18 [-0800]: panda boot often fails due to a usb timeout, while sending a command on behalf of the smsc95xx ethernet driver. This patch is a temporary hack to force a retry when the timeout occurs. It looks like you overrun the chip for some reason. Can you

Re: Threaded irqs + 100% CPU RT task = RCU stall

2013-03-11 Thread Sebastian Andrzej Siewior
* Paul E. McKenney | 2013-03-06 13:45:02 [-0800]: Is this behavior OK? If so, the following (untested) patch might do what you want. ;-) Paul (Gortmaker) could you please test Paul's (McKenney) to see if it makes things for Joe (Average) easier to spot? Sebastian -- To unsubscribe from this

[PATCH] usb/gadget: initialize gadget functions helper befor functions gadgets

2013-03-04 Thread Sebastian Andrzej Siewior
which I did wrong and now I correct this. Cc: Fengguang Wu fengguang...@intel.com Signed-off-by: Sebastian Andrzej Siewior sebast...@breakpoint.cc --- I kinda assumed that this was already fixed (i.e. a patch like this was sent) but it seems not to be that case. drivers/usb/gadget/Makefile

Re: [PATCH] usb/gadget: initialize gadget functions helper befor functions gadgets

2013-03-05 Thread Sebastian Andrzej Siewior
* Felipe Balbi | 2013-03-05 12:49:44 [+0200]: I kinda assumed that this was already fixed (i.e. a patch like this was sent) but it seems not to be that case. already in Greg's queue, cheers great… Sebastian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH] usb/gadget: initialize gadget functions helper befor functions gadgets

2013-03-05 Thread Sebastian Andrzej Siewior
* Fengguang Wu | 2013-03-05 18:35:13 [+0800]: Note that I still get this warning, however looks like an unrelated issue: [ 602.536679] [ INFO: possible circular locking dependency detected ] [ 602.536672] [ 602.536679] == [ 602.536679] [

Re: [PATCH v3 00/23] ldisc fixes

2013-03-05 Thread Sebastian Andrzej Siewior
* Peter Hurley | 2013-02-05 15:20:15 [-0500]: Please re-test with your dummy_hcd/g_nokia testcase, although I'm not convinced that usb gadget is using tty_hangup() appropriately. tty drivers use this for async carrier loss coming from an IRQ which will be disabled if the tty has been

Re: [PATCH v4 00/32] ldisc patchset

2013-03-05 Thread Sebastian Andrzej Siewior
* Peter Hurley | 2013-02-20 15:02:47 [-0500]: Sebastian, please re-test your g_nokia+dummy_hcd testcase with this series. I tested this on top ov v3.9-rc1. Without this series I see often a warning in drivers/tty/tty_buffer.c:428 / flush_to_ldisc(). With this things seem to work fine. Sebastian

[PATCH] fs/configfs: allow to create groups on demand

2012-11-29 Thread Sebastian Andrzej Siewior
as a child of the UDC node. The UDC itself will appear once the hardware driver is loaded and can appear later. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- fs/configfs/dir.c| 63 ++ include/linux/configfs.h |4 +++ 2

Re: [PATCH RESEND] tty: don't dead lock while flushing workqueue

2012-11-30 Thread Sebastian Andrzej Siewior
On Tue, Nov 27, 2012 at 07:01:08PM +0100, Sebastian Andrzej Siewior wrote: Since commit 89c8d91e31f2 (tty: localise the lock) I see a dead lock in one of my dummy_hcd + g_nokia test cases. The first run one was usually okay, the second often resulted in a splat by lockdep and the third

Re: [PATCH RESEND] tty: don't dead lock while flushing workqueue

2012-11-30 Thread Sebastian Andrzej Siewior
On Fri, Nov 30, 2012 at 09:21:43AM -0800, Greg Kroah-Hartman wrote: Ping. Can you feed this to your tty tree? :) It's really late in the release cycle, I would like to have this get more testing in linux-next before I send it to Linus, so I was going to wait until after 3.8-rc1 is out

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-12-03 Thread Sebastian Andrzej Siewior
On Thu, Nov 01, 2012 at 09:21:16AM +0200, Felipe Balbi wrote: then we can merge to net tree and handle the conflicts when merging to Linus, that'd be fine by me as long as people know how to solve the conflict properly ;-) Felipe please drop this patch. I don't like this VLAIS patch and its

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-12-04 Thread Sebastian Andrzej Siewior
On Mon, Dec 03, 2012 at 07:57:33PM +0100, Behan Webster wrote: However, in order to approximate what gcc is doing in code, obviously some math is required. The thought was that macros would hide the worst of it, trying not to obfuscate what was actually being done. Why hide? The thing that is

[PATCH] scatterlist: add a warning if sg_virt() is used on highmem pages

2012-12-05 Thread Sebastian Andrzej Siewior
sg_virt() on highmem pages won't work. This WARN_ON() should catch some that still try. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- include/linux/scatterlist.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/scatterlist.h b/include/linux

[PREEMPT RT] SLUB and split softirq lock for v3.2-rt

2013-02-13 Thread Sebastian Andrzej Siewior
3.2-rt is a long term supported kernel, which lacks two RT features from 3.6: SLUB support and the split softirq lock implementation. SLUB has a way better performance than SLAB on RT and the split softirq lock implementation is necessary especially for realtime networking applications. The

[PATCH 01/16] softirq: Make serving softirqs a task flag

2013-02-13 Thread Sebastian Andrzej Siewior
From: Thomas Gleixner t...@linutronix.de Avoid the percpu softirq_runner pointer magic by using a task flag. Signed-off-by: Thomas Gleixner t...@linutronix.de [bigeasy@linutronix: different PF_IN_SOFTIRQ bit] Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- include/linux

[PATCH 02/16] softirq: Split handling function

2013-02-13 Thread Sebastian Andrzej Siewior
From: Thomas Gleixner t...@linutronix.de Split out the inner handling function, so RT can reuse it. Signed-off-by: Thomas Gleixner t...@linutronix.de --- kernel/softirq.c | 43 +++ 1 file changed, 23 insertions(+), 20 deletions(-) diff --git

[PATCH 03/16] softirq: Split softirq locks

2013-02-13 Thread Sebastian Andrzej Siewior
: PF_MALLOC handling, __raise_softirq_irqoff() not inline, shrink invoke_softirq()] Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- include/linux/interrupt.h |6 +- include/linux/sched.h |1 + kernel/softirq.c | 295 - 3

[PATCH 07/16] softirq: Fix nohz pending issue for real

2013-02-13 Thread Sebastian Andrzej Siewior
and complains about pending softirq Y. Now iterating over all softirqs lets us find the runner for X and eliminate Y from the to warn about list as well. Signed-off-by: Thomas Gleixner t...@linutronix.de Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- kernel/softirq.c | 13

[PATCH 09/16] FIX [1/2] slub: Do not dereference NULL pointer in node_match

2013-02-13 Thread Sebastian Andrzej Siewior
-by: Thomas Gleixner t...@linutronix.de [bigeasy@linutronix: replace page with c-page] Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- mm/slub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index 5710788..08eb4c1 100644 --- a/mm/slub.c

[PATCH 08/16] net: Use local_bh_disable in netif_rx_ni()

2013-02-13 Thread Sebastian Andrzej Siewior
, but going through local_bh_disable/enable here is not going to hurt badly. Signed-off-by: Thomas Gleixner t...@linutronix.de Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- net/core/dev.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/core/dev.c b/net

[PREEMPT RT] SLUB and split softirq lock for v3.4-rt

2013-02-13 Thread Sebastian Andrzej Siewior
3.4-rt which lacks two RT features from 3.6: SLUB support and the split softirq lock implementation. SLUB has a way better performance than SLAB on RT and the split softirq lock implementation is necessary especially for realtime networking applications. The following patch series backports

[PATCH 01/12] softirq: Make serving softirqs a task flag

2013-02-13 Thread Sebastian Andrzej Siewior
From: Thomas Gleixner t...@linutronix.de Avoid the percpu softirq_runner pointer magic by using a task flag. Signed-off-by: Thomas Gleixner t...@linutronix.de Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- include/linux/sched.h |1 + kernel/softirq.c | 20

[PATCH 03/12] softirq: Split softirq locks

2013-02-13 Thread Sebastian Andrzej Siewior
: remove PF_MEMALLOC logic] Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- include/linux/sched.h |1 + kernel/softirq.c | 277 +++-- 2 files changed, 179 insertions(+), 99 deletions(-) diff --git a/include/linux/sched.h b/include

[PATCH 09/12] FIX [2/2] slub: Tid must be retrieved from the percpu area of the current processor

2013-02-13 Thread Sebastian Andrzej Siewior
-by: Thomas Gleixner t...@linutronix.de Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- mm/slub.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index fbf6810..634aabc 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2313,13 +2313,18

[PATCH 08/12] FIX [1/2] slub: Do not dereference NULL pointer in node_match

2013-02-13 Thread Sebastian Andrzej Siewior
-by: Thomas Gleixner t...@linutronix.de [bigeasy@linutronix: replace page with c-page] Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- mm/slub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index 71de9b5..fbf6810 100644 --- a/mm/slub.c

[PATCH 07/12] net: Use local_bh_disable in netif_rx_ni()

2013-02-13 Thread Sebastian Andrzej Siewior
, but going through local_bh_disable/enable here is not going to hurt badly. Signed-off-by: Thomas Gleixner t...@linutronix.de Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- net/core/dev.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/core/dev.c b/net

[PATCH 06/12] softirq: Fix nohz pending issue for real

2013-02-13 Thread Sebastian Andrzej Siewior
and complains about pending softirq Y. Now iterating over all softirqs lets us find the runner for X and eliminate Y from the to warn about list as well. Signed-off-by: Thomas Gleixner t...@linutronix.de Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- kernel/softirq.c | 13

[PATCH 05/12] softirq: Add more debugging

2013-02-13 Thread Sebastian Andrzej Siewior
-off-by: Thomas Gleixner t...@linutronix.de Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- kernel/softirq.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index 72abc38..499329d 100644 --- a/kernel

[PATCH 04/12] softirq: Adapt NOHZ softirq pending check to new RT scheme

2013-02-13 Thread Sebastian Andrzej Siewior
-by: Sebastian Andrzej Siewior bige...@linutronix.de --- kernel/softirq.c | 68 +- 1 file changed, 52 insertions(+), 16 deletions(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index 8e5e1c7..72abc38 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c

[PATCH 02/12] softirq: Split handling function

2013-02-13 Thread Sebastian Andrzej Siewior
From: Thomas Gleixner t...@linutronix.de Split out the inner handling function, so RT can reuse it. Signed-off-by: Thomas Gleixner t...@linutronix.de Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- kernel/softirq.c | 43 +++ 1 file

[PATCH 06/16] softirq: Add more debugging

2013-02-13 Thread Sebastian Andrzej Siewior
-off-by: Thomas Gleixner t...@linutronix.de Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- kernel/softirq.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index 66999ad..385fcea 100644 --- a/kernel

[PATCH 05/16] softirq: Adapt NOHZ softirq pending check to new RT scheme

2013-02-13 Thread Sebastian Andrzej Siewior
-by: Sebastian Andrzej Siewior bige...@linutronix.de --- kernel/softirq.c | 68 +- 1 file changed, 52 insertions(+), 16 deletions(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index 3f7b3fb..66999ad 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c

[PATCH 04/16] rcu: rcutiny: Prevent RCU stall

2013-02-13 Thread Sebastian Andrzej Siewior
it's missing a big fat comment. Paul See mainline commits: ec433f0c5 and 8762705a for further enlightment. Reported-by: Kristian Lehmann krlei...@hs-esslingen.de Signed-off-by: Thomas Gleixner t...@linutronix.de [bigeasy@linutronix: different in-irq check] Signed-off-by: Sebastian Andrzej

[PATCH 10/12] slub: Use correct cpu_slab on dead cpu

2013-02-13 Thread Sebastian Andrzej Siewior
: remove unused n2] Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- mm/slub.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 634aabc..f788e7e 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1879,11 +1879,15 @@ static void

[PATCH 12/12] slub: Enable irqs for __GFP_WAIT

2013-02-13 Thread Sebastian Andrzej Siewior
Andrzej Siewior bige...@linutronix.de --- mm/slub.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 624deaa..bdb7f3a 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1293,14 +1293,15 @@ static struct page *allocate_slab(struct kmem_cache *s

[PATCH 14/16] slub: only IPI CPUs that have per cpu obj to flush

2013-02-13 Thread Sebastian Andrzej Siewior
kosaki.motoh...@gmail.com Cc: Milton Miller milt...@bga.com Signed-off-by: Andrew Morton a...@linux-foundation.org Signed-off-by: Linus Torvalds torva...@linux-foundation.org Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- mm/slub.c | 10 +- 1 file changed, 9 insertions(+), 1

[PATCH 13/16] smp: add func to IPI cpus based on parameter func

2013-02-13 Thread Sebastian Andrzej Siewior
kosaki.motoh...@gmail.com Cc: Milton Miller milt...@bga.com Reviewed-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com Signed-off-by: Andrew Morton a...@linux-foundation.org Signed-off-by: Linus Torvalds torva...@linux-foundation.org Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de

[PATCH 10/16] FIX [2/2] slub: Tid must be retrieved from the percpu area of the current processor

2013-02-13 Thread Sebastian Andrzej Siewior
-by: Thomas Gleixner t...@linutronix.de Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- mm/slub.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 08eb4c1..78d2756 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2286,13 +2286,18

[PATCH 12/16] smp: introduce a generic on_each_cpu_mask() function

2013-02-13 Thread Sebastian Andrzej Siewior
-off-by: Linus Torvalds torva...@linux-foundation.org Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- arch/arm/kernel/smp_tlb.c | 20 +--- arch/tile/include/asm/smp.h |7 --- arch/tile/kernel/smp.c | 19 --- include/linux/smp.h

[PATCH 16/16] slub: Enable irqs for __GFP_WAIT

2013-02-13 Thread Sebastian Andrzej Siewior
Andrzej Siewior bige...@linutronix.de --- mm/slub.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 8475580..4c62b7f 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1285,14 +1285,15 @@ static struct page *allocate_slab(struct kmem_cache *s

[PATCH 15/16] mm: Enable SLUB for RT

2013-02-13 Thread Sebastian Andrzej Siewior
From: Thomas Gleixner t...@linutronix.de Make SLUB RT aware and remove the restriction in Kconfig. Signed-off-by: Thomas Gleixner t...@linutronix.de [bigeasy@linutronix: fix a few conflicts] Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- include/linux/slub_def.h |2

[PATCH 11/16] slub: Use correct cpu_slab on dead cpu

2013-02-13 Thread Sebastian Andrzej Siewior
: remove unused n2] Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- mm/slub.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 78d2756..d9ba33d 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1870,11 +1870,15 @@ static void

[PATCH 11/12] mm: Enable SLUB for RT

2013-02-13 Thread Sebastian Andrzej Siewior
From: Thomas Gleixner t...@linutronix.de Make SLUB RT aware and remove the restriction in Kconfig. Signed-off-by: Thomas Gleixner t...@linutronix.de [bigeasy@linutronix: fix a few conflicts] Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- include/linux/slub_def.h |2

Re: Kernel Failure - 3.4.24

2013-01-29 Thread Sebastian Andrzej Siewior
On 01/28/2013 08:57 PM, John L. Males wrote: I was not suggesting you are responsible for the bug at all. On Okay then :) I have no custom patches to the kernel. okay. I looked at the RedHat bug 468794. The bug seems to indicate it was never fixed. The bug was reported against

[RFC] Consider CPU idle state while choosing a new CPU

2013-01-30 Thread Sebastian Andrzej Siewior
The scheduler does not consider the power states CPUs while selecting an idle one. So it might happen, that it puts load on a cpu which is in a deeper power state than another idle one, which has higher latency and power costs than pushing the load to the core which is not in a deep power saving

[RFC 1/2] cpuidle: trace state of the CPU

2013-01-30 Thread Sebastian Andrzej Siewior
is in some kind of idle state. The larger the value, the deeper the idle state. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- drivers/cpuidle/cpuidle.c | 13 - include/linux/cpuidle.h |2 ++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers

[RFC 2/2] sched/fair: prefer a CPU in the lowest idle state

2013-01-30 Thread Sebastian Andrzej Siewior
then it is consider as a valid target. Should there be no CPU in an idle state at disposal then the loadavg is used as a fallback. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- include/linux/sched.h |1 + kernel/sched/core.c |6 -- kernel/sched/fair.c | 24

Re: [RFC 1/2] cpuidle: trace state of the CPU

2013-02-02 Thread Sebastian Andrzej Siewior
On 01/31/2013 06:21 AM, Namhyung Kim wrote: diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index e1f6860..3594e0c 100644 --- a/drivers/cpuidle/cpuidle.c +++ b/drivers/cpuidle/cpuidle.c @@ -23,6 +23,7 @@ #include cpuidle.h DEFINE_PER_CPU(struct cpuidle_device *,

Re: [RFC 2/2] sched/fair: prefer a CPU in the lowest idle state

2013-02-02 Thread Sebastian Andrzej Siewior
On 01/31/2013 03:12 AM, Michael Wang wrote: I'm not sure, but just concern about this case: group 0 cpu 0 cpu 1 least idle 4 task group 1 cpu 2 cpu 3 1 task

Re: [usb gadget] WARNING: at kernel/mutex.c:198 __mutex_lock_common()

2013-03-02 Thread Sebastian Andrzej Siewior
On 03/02/2013 02:37 PM, Fengguang Wu wrote: On Wed, Feb 27, 2013 at 12:49:35PM +0200, Felipe Balbi wrote: Hi, On Wed, Feb 06, 2013 at 10:04:24AM +0800, Fengguang Wu wrote: Greetings, I got the below warning and the first bad commit is can you send a fixup patch ? Sorry I don't have the

Re: Kernel Failure - 3.4.24

2013-01-27 Thread Sebastian Andrzej Siewior
On 01/17/2013 12:42 AM, John L. Males wrote: Hello, Hi, I copied Sebastian in on the post my review of Changelogs suggests Sebastian is the one who will want to know about this kernel failure or will know who should be. I did what? I reviewed patches since they went in this problem occurs?

Re: [PATCH 1/2]linux-usb:Define a new macro for USB storage match rules

2013-01-27 Thread Sebastian Andrzej Siewior
On Fri, Jan 25, 2013 at 10:44:50AM +0800, fangxiaozhi 00110321 wrote: diff -uprN linux-3.8-rc4_orig/drivers/usb/storage/usual-tables.c linux-3.8-rc4/drivers/usb/storage/usual-tables.c --- linux-3.8-rc4_orig/drivers/usb/storage/usual-tables.c 2013-01-22 14:12:42.594238726 +0800 +++

Re: [PATCH 2/2]linux-usb:optimize to match the Huawei USB storage devices and support new switch command

2013-01-27 Thread Sebastian Andrzej Siewior
On Fri, Jan 25, 2013 at 10:46:13AM +0800, fangxiaozhi 00110321 wrote: diff -uprN linux-3.8-rc4_orig/drivers/usb/storage/initializers.c linux-3.8-rc4/drivers/usb/storage/initializers.c --- linux-3.8-rc4_orig/drivers/usb/storage/initializers.c 2013-01-22 14:12:42.594238726 +0800 +++

Re: [PATCH v4 00/32] ldisc patchset

2013-02-20 Thread Sebastian Andrzej Siewior
On 02/20/2013 09:02 PM, Peter Hurley wrote: Sebastian, please re-test your g_nokia+dummy_hcd testcase with this series. I've seen your first series but I did not have the time yet. I hope this will change this weekend. Sebastian -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] usb: gadget: Conform with checkpatch -3 warnings, 1 error

2012-09-10 Thread Sebastian Andrzej Siewior
On Sun, Sep 09, 2012 at 10:50:35AM +1000, Ben Minerds wrote: Removed 3 checkpatch.sh warnings and 1 error in drivers/usb/gadget/serial.c. -sizeof brackets x2 -remove initialise to 0 -pr_warning to pr_warn I have a series pending which removes the last two chunks. Sebastian -- To unsubscribe

Re: [PATCH 4/7] ptrace: Partly fix set_task_blockstep()-update_debugctlmsr() logic

2012-09-10 Thread Sebastian Andrzej Siewior
* Oleg Nesterov | 2012-09-03 17:26:09 [+0200]: Afaics the usage of update_debugctlmsr() and TIF_BLOCKSTEP in step.c was always very wrong. 1. update_debugctlmsr() was simply unneeded. The child sleeps TASK_TRACED, __switch_to_xtra(next_p = child) should notice TIF_BLOCKSTEP and set/clear

Re: [PATCH 0/7] uprobes: single-step fixes

2012-09-10 Thread Sebastian Andrzej Siewior
On 09/03/2012 05:25 PM, Oleg Nesterov wrote: Hello. Hi Oleg, Sebastian, I changed your patches a bit: snip please let me know if you disagree. Thank you very much. I'm fine with those. Just tested, looks good so far. Oleg. Sebastian -- To unsubscribe from this list: send the line

[PATCH 2/2] uprobes: add global breakpoints

2012-09-11 Thread Sebastian Andrzej Siewior
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- rfc..v1: - removing pids from the exlude list once a task terminates - skip_handler has been switched from int to struct uprobe * to address Oleg's review comment regading the case where we receive

[PATCH 1/2] uprobes: probe definiton can only start with 'p' and '-'

2012-09-11 Thread Sebastian Andrzej Siewior
'r' and ' ' is not supported according to current code. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- kernel/trace/trace_uprobe.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index 03003cd

Re: [PATCH] of: specify initrd location using 64-bit

2012-09-12 Thread Sebastian Andrzej Siewior
On 09/12/2012 08:02 PM, Cyril Chemparathy wrote: -void __init early_init_dt_setup_initrd_arch(unsigned long start, unsigned long end) +void __init early_init_dt_setup_initrd_arch(u64 start, u64 end) Why not phys_addr_t? The rest of the memory specific bits of the device-tree code use u64

Re: [PATCH] of: specify initrd location using 64-bit

2012-09-13 Thread Sebastian Andrzej Siewior
On 09/13/2012 12:08 AM, Rob Herring wrote: Geert is right here. If it is a physical address, it should be phys_addr_t. While generally true, for the DT specific code I think it should be a fixed u64. The size of the address is defined by the FDT, not the kernel. It is very likely we could have

Re: [PATCH v2 4/4]: ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc

2012-09-14 Thread Sebastian Andrzej Siewior
On Fri, Sep 14, 2012 at 08:52:58AM +0200, Rene Buergel wrote: Git should show this as a move, not as a add a file and remove a file type patch. Are you generating it properly? Whats the proper way to do this? I did a git mv, git commit and than git diff on that commit hash. Thatis

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

2012-09-14 Thread Sebastian Andrzej Siewior
On Fri, Sep 14, 2012 at 03:42:42PM +0400, Sergei Shtylyov wrote: diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c index 92ced35..f584af8 100644 --- a/drivers/staging/usbip/stub_dev.c +++ b/drivers/staging/usbip/stub_dev.c @@ -233,6 +230,13 @@ static void

Re: [PATCH] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

2012-09-14 Thread Sebastian Andrzej Siewior
On Fri, Sep 14, 2012 at 05:16:38PM +0300, Dan Carpenter wrote: I don't think this text is allowed on patches. Oh Oh Oh Dan, I think you crossed a line here. You were not one of the recipient and you reviewed and forwarded the email but you should have deleted this email instead. Now legal action

[PATCH] uprobes: don't enable/disable signle step if the user did it

2012-07-26 Thread Sebastian Andrzej Siewior
enabled. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- include/linux/uprobes.h |2 ++ kernel/events/uprobes.c | 10 -- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h index efe4b33..1be2d44 100644

Re: [PATCH] uprobes: don't enable/disable signle step if the user did it

2012-07-26 Thread Sebastian Andrzej Siewior
On 07/26/2012 05:20 PM, Sebastian Andrzej Siewior wrote: diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index f935327..772eb3a 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -1528,7 +1528,10 @@ static void handle_swbp(struct pt_regs *regs) utask

Re: [PATCH] uprobes: don't enable/disable signle step if the user did it

2012-07-27 Thread Sebastian Andrzej Siewior
if the instruction on which we placed the uprobe activates it? But I am not sure about this patch... On 07/26, Sebastian Andrzej Siewior wrote: @@ -1528,7 +1528,10 @@ static void handle_swbp(struct pt_regs *regs) utask-state = UTASK_SSTEP; if (!pre_ssout(uprobe, regs, bp_vaddr

Re: [PATCH] uprobes: don't enable/disable signle step if the user did it

2012-07-30 Thread Sebastian Andrzej Siewior
On 07/30/2012 04:16 PM, Oleg Nesterov wrote: I'd suggest you to make 2 patches: - 1/2 creates arch_uprobe_*_step(...) __weak helpers in kernel/events/uprobes.c which simply call user_*_single_step() and updates the callers Not strictly

[PATCH 1/2] uprobes: Use a helper instead of ptrace's single step enable

2012-07-31 Thread Sebastian Andrzej Siewior
As Oleg pointed out in [0] utrace should not use the ptrace interface for enabling/disabling single stepping. [0] http://lkml.kernel.org/20120730141638.ga5...@redhat.com Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- include/linux/uprobes.h |4 kernel/events

[PATCH 2/2] x86/uprobes: implement x86 specific arch_uprobe_*_step

2012-07-31 Thread Sebastian Andrzej Siewior
look at the opcode and send SIGTRAP depending on the jump/flag status. For now we wait for the next exception/jump to be taken. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- arch/x86/include/asm/uprobes.h |3 ++ arch/x86/kernel/uprobes.c | 60

Re: [RFC 0/2] USB gadget - configfs

2012-08-29 Thread Sebastian Andrzej Siewior
On 08/21/2012 10:19 AM, Andrzej Pietrasiewicz wrote: @Joel: However, I am wondering if it would make sense to get rid of the connect (or ready, if you will) attribute altogether and instead use symlinks: when a user wants to make the gadget ready, they do an ln -s, when they want to unbind the

[PATCH] x86/uprobes: don't disable single stepping if it was already on

2012-08-30 Thread Sebastian Andrzej Siewior
). Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- arch/x86/include/asm/uprobes.h |2 ++ arch/x86/kernel/uprobes.c | 33 +++-- 2 files changed, 33 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/uprobes.h b/arch/x86/include/asm

[PATCH] uprobes: don't put NULL pointer in uprobe_register()

2012-08-30 Thread Sebastian Andrzej Siewior
alloc_uprobe() might return a NULL pointer, put_uprobe() can't deal with this. Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- kernel/events/uprobes.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c

Re: [RFC 5/5 v2] uprobes: add global breakpoints

2012-08-30 Thread Sebastian Andrzej Siewior
On 08/29/2012 05:49 PM, Oleg Nesterov wrote: That would help but would require a change in ptrace_attach() or something in gdb/strace/… Well, I still think you should not touch ptrace_attach() at all. Okay. One thing I just noticed: If I don't register a handler for SIGUSR1 and send one to

[PATCH v2] x86/dt: use linear irq domain for ioapic(s).

2012-08-13 Thread Sebastian Andrzej Siewior
() and won't work with ACPI without changes. So this is probably easiest for everyone. Tested-by: Thierry Reding thierry.red...@avionic-design.de Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- v1..v2: - added tested tag from Thierry - moved argument ioapic_irq_domain_ops

Re: [PATCH v2 2/5] x86/uprobes: implement x86 specific arch_uprobe_*_step

2012-08-14 Thread Sebastian Andrzej Siewior
On 08/13/2012 03:24 PM, Oleg Nesterov wrote: On 08/09, Sebastian Andrzej Siewior wrote: v1..v2: re-use auprobe-fixups for fixups Yes, but @@ -46,6 +46,8 @@ struct arch_uprobe_task { #ifdef CONFIG_X86_64 unsigned long saved_scratch_register; #endif +#define

Re: [RFC 5/5] uprobes: add global breakpoints

2012-08-14 Thread Sebastian Andrzej Siewior
On 08/13/2012 03:16 PM, Oleg Nesterov wrote: On 08/09, Sebastian Andrzej Siewior wrote: * Oleg Nesterov | 2012-08-08 15:14:57 [+0200]: What I miss right now is an interface to tell the user/gdb that there is a program that hit a global breakpoint and is waiting for further instructions

  1   2   3   4   5   6   7   8   9   10   >