Re: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation

2015-01-15 Thread Sebastian Reichel
Hi, On Thu, Jan 15, 2015 at 08:36:44AM +0100, Dr. H. Nikolaus Schaller wrote: 1. Perform conversion in input core rather than individual drivers. I think we should allocate a new bitmaps for some transformations and have the code do X/Y flip/clip of the coordinates. Do you have a

Re: [PATCH RESEND 00/13] ltc2952 modernization and new functionality

2015-01-14 Thread Sebastian Reichel
Hi, On Wed, Jan 14, 2015 at 09:15:33AM +0100, Frans Klaver wrote: Here's a resend of an earlier cleanup and improvement series for the ltc2952 driver. This series implements devm_* usage, reduction of globals, some cleanup and finally makes the input trigger optional. From the changes to

Re: [PATCH v2 1/3] power: rt5033_battery: Add RT5033 Fuel gauge device driver

2015-01-14 Thread Sebastian Reichel
Hi, On Fri, Jan 09, 2015 at 05:45:11PM +0900, Beomho Seo wrote: This patch adds device driver of Richtek PMIC. The driver support battery fuel gange. Fuel gauge calculates and determines the battery state of charge(SOC) according to battery open circuit voltage(OCV). Also, this driver

Re: [PATCH v5 0/5] power: Add max77693 charger driver

2015-01-20 Thread Sebastian Reichel
Hi, On Tue, Jan 20, 2015 at 11:00:51AM +0100, Krzysztof Kozlowski wrote: You already acked some earlier version of this patch. In that time there were more dependencies on MFD tree. Now the MFD patch (2/5) is acked by Lee Jones so could you pick up everything? Thanks for the patchset, queued:

Re: [PATCH v6 0/7] Add initial support for DA9150 Charger Fuel-Gauge IC

2015-01-21 Thread Sebastian Reichel
Hi, On Wed, Jan 21, 2015 at 03:46:25PM +, Adam Thomson wrote: This patch set adds initial support for the Dialog DA9150 Integrated Charger Fuel-Gauge IC. The device also provides GPIO and GPADC functionality. In this patch set the following is provided: - MFD Core support and DT

Re: [RFC PATCHv2 00/19] power_supply: Allow safe usage of power supply

2015-01-21 Thread Sebastian Reichel
is preserved. Fine with me, but I need acks from all involved maintainers. So for the patchset: Reviewed-By: Sebastian Reichel s...@kernel.org -- Sebastian signature.asc Description: Digital signature

Re: [PATCH] power: bq24190_charger: suppress build warning

2015-01-21 Thread Sebastian Reichel
Hi, On Thu, Dec 04, 2014 at 02:56:04PM +, Lad, Prabhakar wrote: This patch fixes following build warning: In file included from include/linux/printk.h:261:0, from include/linux/kernel.h:13, from include/linux/list.h:8, from

Re: [PATCH V3 01/11] power: charger-manager: Use alarmtimer for battery monitoring in suspend.

2015-01-21 Thread Sebastian Reichel
Hi, On Fri, Dec 19, 2014 at 05:55:13PM +0900, Jonghwa Lee wrote: To guerantee proper charing and managing batteries even in suspend, charger-manager has used rtc device with rtc framework interface. However, it is better to use alarmtimer for cleaner and more appropriate operation. This

Re: [RFC PATCH 0/3] power: Generic interface to get battery specification.

2015-01-21 Thread Sebastian Reichel
Hi Jonghwa, On Tue, Oct 07, 2014 at 07:58:35PM +0900, Jonghwa Lee wrote: This patches contains supporting generic interface to get battery specification and of-based battery driver which use the interface. Up to now, power supply subsystem assumes that battery's charartric data is static

Re: [PATCH V3 02/11] power: charger-manager: Use thermal subsystem interface only to get temperature.

2015-01-21 Thread Sebastian Reichel
Hi Jonghwa, On Fri, Dec 19, 2014 at 05:55:14PM +0900, Jonghwa Lee wrote: It drops the way of using power_supply interface to reference battery's temperature. Then it tries to use thermal subsystem's only. This makes driver more simple and also can remove ifdeferies. this breaks allmodconfig,

Re: [PATCH] Add LTC2941/LTC2943 Battery Gauge Driver

2015-01-21 Thread Sebastian Reichel
Hi, On Tue, Oct 28, 2014 at 08:05:12AM +0100, Mike Looijmans wrote: Both the LTC2941 and LTC2943 measure battery capacity. The LTC2943 is compatible with the LTC2941, it adds voltage and temperature monitoring, and uses a slightly different conversion formula for the charge counter. To

Re: [PATCH] Add devicetree binding documentation for the LTC2941/LTC2943 driver

2015-01-21 Thread Sebastian Reichel
Hi, On Tue, Oct 28, 2014 at 08:08:04AM +0100, Mike Looijmans wrote: This adds the devicetree binding documentation for the LTC2941 and LTC2943 driver. These are I2C connected battery gas gauge ICs. Thanks, applied. -- Sebastian signature.asc Description: Digital signature

Re: [PATCH v4 0/2] power: rt5033: Add Richtek RT533 drivers

2015-01-21 Thread Sebastian Reichel
Hi, On Thu, Jan 22, 2015 at 01:06:38PM +0900, Beomho Seo wrote: This patchset adds driver for Richtek rt5033 chip The chip contains switching charge mode Li-Ion/Li-Polymer battery charger, fuelgauge. Additionally, This includes document for device tree of RT5033 device. Thanks, applied. --

Re: [PATCH v3 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-01-21 Thread Sebastian Reichel
Hi, On Thu, Jan 22, 2015 at 09:38:11AM +0900, Beomho Seo wrote: This patch add device driver of Richtek RT5033 PMIC. The driver support switching charger. rt5033 charger provide three charging mode. Three charging mode are pre charge mode, fast cahrge mode and constant voltage mode. They are

Re: [PATCH] MAINTAINERS: Add entry for Maxim PMIC-s on Samsung boards

2015-01-16 Thread Sebastian Reichel
of them), - clock (clk-max77686.c) - RTC (rtc-max77686.c). Lately I am the author of major contributors to them. These drivers are used on Exynos-based boards (Trats 2, Gear 1 and Gear 2). Acked-By: Sebastian Reichel s...@kernel.org -- Sebastian signature.asc Description: Digital signature

Re: [PATCH RESEND V2 2/2] power: collie_battery: support generating wakeup event

2015-01-15 Thread Sebastian Reichel
Hi, On Thu, Jan 15, 2015 at 05:00:38AM +0300, Dmitry Eremin-Solenikov wrote: Teach collie_battery driver to communicate to the kernel that it can generate wakeup events. Handle enabling/disabling wakeup on battery full event in suspend/resume callbacks. Thanks, applied:

Re: [PATCH RESEND V2 1/2] power: gpio-charger: balance enable/disable_irq_wake calls

2015-01-15 Thread Sebastian Reichel
Hi, On Thu, Jan 15, 2015 at 05:00:37AM +0300, Dmitry Eremin-Solenikov wrote: enable_irq_wakeup returns 0 in case it correctly enabled the IRQ to generate the wakeup event (and thus resume should call disable_irq_wake). Currently gpio-charger driver has this logic inverted. Correct that thus

Re: [PATCH v4 2/2] Documentation: Add documentation for rt5033 multifunction device

2015-01-22 Thread Sebastian Reichel
: Sebastian Reichel s...@kernel.org Cc: Lee Jones lee.jo...@linaro.org Cc: Mark Brown broo...@kernel.org Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Ian campbell ijc+devicet...@hellion.org.uk Cc: Kumar Gala ga

Re: [PATCH] power/reset: vexpress: Remove non-DT code

2015-01-20 Thread Sebastian Reichel
Hi, On Tue, Jan 20, 2015 at 05:24:02PM +, Pawel Moll wrote: Now, as all VE platforms have to be booted with DT, the code handling non-DT case can be removed. Signed-off-by: Pawel Moll pawel.m...@arm.com Thanks, applied. -- Sebastian signature.asc Description: Digital signature

Re: [PATCH] power: max77693: fix simple_return.cocci warnings

2015-01-21 Thread Sebastian Reichel
Hi, On Wed, Jan 21, 2015 at 12:11:34PM +0800, kbuild test robot wrote: drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by:

Re: [PATCH] power: max77693: fix platform_no_drv_owner.cocci warnings

2015-01-21 Thread Sebastian Reichel
Hi, On Wed, Jan 21, 2015 at 12:11:34PM +0800, kbuild test robot wrote: drivers/power/max77693_charger.c:747:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by:

Re: [PATCH] power: ab8500_fg.c: Remove unused function

2015-01-21 Thread Sebastian Reichel
Hi, On Thu, Jan 01, 2015 at 06:04:52PM +0100, Rickard Strandqvist wrote: Remove the function ab8500_fg_reinit() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist

Re: [PATCH] power: max17042: Constify struct regmap_config

2015-01-18 Thread Sebastian Reichel
Hi, On Mon, Jan 05, 2015 at 09:50:17AM +0100, Krzysztof Kozlowski wrote: The regmap_config struct may be const because it is not modified by the driver and regmap_init() accepts pointer to const. Thanks, applied. -- Sebastian signature.asc Description: Digital signature

Re: [PATCH 3/3] power/axp288_fuel_gauge: axp288 fuel gauge driver

2015-01-18 Thread Sebastian Reichel
Hi, On Wed, Jan 07, 2015 at 01:26:55PM -0800, Todd E Brandt wrote: X-Power AXP288 PMIC Fuel Gauge Driver new power_supply driver at driver/power interfaces with the axp20x mfd driver as a cell provides battery info and monitors for changes generates alerts on temperature and capacity

Re: [PATCH] power: bq24190: Fix ignored supplicants

2015-01-18 Thread Sebastian Reichel
Hi, On Mon, Jan 05, 2015 at 09:51:48AM +0100, Krzysztof Kozlowski wrote: The driver mismatched 'num_supplicants' with 'num_supplies' of power_supply structure. It provided list of supplicants (power_supply.supplied_to) but did not set the number of supplicants. Instead it set the

Re: [PATCH] Add LTC2941/LTC2943 Battery Gauge Driver

2015-02-11 Thread Sebastian Reichel
On Wed, Feb 11, 2015 at 12:21:52PM +0100, Mike Looijmans wrote: On 22-01-15 03:24, Sebastian Reichel wrote: Hi, On Tue, Oct 28, 2014 at 08:05:12AM +0100, Mike Looijmans wrote: Both the LTC2941 and LTC2943 measure battery capacity. The LTC2943 is compatible with the LTC2941, it adds voltage

Re: [PATCH v6 0/7] Add initial support for DA9150 Charger Fuel-Gauge IC

2015-02-17 Thread Sebastian Reichel
Hi, On Mon, Feb 16, 2015 at 09:45:59PM +, Opensource [Adam Thomson] wrote: Just a quick one to see what the status is on this patch set? Just interested as to when it'll be pulled in. I plan to pull it into for-next once -rc1 has been tagged (probably about a week). Feel free to send a new

Re: [PATCH] Devicetree binding for omap3-serial bcm2048 combination

2015-01-28 Thread Sebastian Reichel
Hi, On Wed, Jan 28, 2015 at 10:35:01AM +0100, Pavel Machek wrote: Nokia N900 contains bluetooth module connected on serial port. Unfortunately, serial and bluetooth are rather closely coupled, so standard serial driver can not be used, and we really don't want /dev/ttyS1 to be published for

Re: [PATCH] power_supply: 88pm860x: Fix leaked power supply on probe fail

2015-01-28 Thread Sebastian Reichel
Hi, On Tue, Jan 27, 2015 at 04:51:54PM +0100, Krzysztof Kozlowski wrote: Driver forgot to unregister power supply if request_threaded_irq() failed in probe(). In such case the memory associated with power supply leaked. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Fixes:

Re: [PATCH v2 3/3] X-Power AXP288 PMIC Fuel Gauge Driver

2015-01-25 Thread Sebastian Reichel
Hi, On Thu, Jan 22, 2015 at 12:52:07PM -0800, Todd Brandt wrote: New power_supply driver at driver/power which interfaces with the axp20x mfd driver as a cell. Provides battery info, monitors for changes, and generates alerts on temperature and capacity issues Apart from two issues the driver

Re: [PATCH 1/6] power/reset: arm-versatile: Register with kernel restart handler

2015-01-25 Thread Sebastian Reichel
Hi, On Sun, Jan 25, 2015 at 10:13:37AM -0800, Guenter Roeck wrote: Register with kernel restart handler instead of setting arm_pm_restart directly. Select high priority since the restart handler is instantiated through devicetree, indicating that it should be used if configured. This does not

Re: [PATCH v2 1/3] mfd/axp20x: change battery cell name to fuel gauge

2015-01-25 Thread Sebastian Reichel
= ARRAY_SIZE(axp288_fuel_gauge_resources), + .resources = axp288_fuel_gauge_resources, }, { .name = axp288_pmic_acpi, Acked-By: Sebastian Reichel s...@kernel.org -- Sebastian signature.asc Description: Digital signature

Re: [PATCH 4/6] power: max77843_battery: Add Max77843 fuel gauge device driver

2015-01-25 Thread Sebastian Reichel
and portable devices. Cc: Sebastian Reichel s...@kernel.org Signed-off-by: Beomho Seo beomho@samsung.com --- drivers/power/Kconfig|9 ++ drivers/power/Makefile |1 + drivers/power/max77843_battery.c | 283 ++ 3 files changed

Re: [PATCH v2 2/3] mfd/axp20x: add support for fuel gauge cell

2015-01-25 Thread Sebastian Reichel
design_cap; + int min_volt; + int max_volt; + int max_temp; + int min_temp; + int cap1; + int cap0; + int rdc1; + int rdc0; + int ocv_curve[OCV_CURVE_SIZE]; + int tcsz; + int thermistor_curve[MAX_THERM_CURVE_SIZE][2]; +}; Acked-By: Sebastian

[GIT PULL] HSI changes for 3.20

2015-02-09 Thread Sebastian Reichel
Hi Linus, The following changes since commit 29169f823067b07bc2967f64ec4b6c9cd1a714a4: Merge tag 'sound-3.19-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound (2014-12-27 13:12:00 -0800) are available in the git repository at:

[GIT PULL] power supply changes for 3.20

2015-02-09 Thread Sebastian Reichel
The following changes since commit 06efe0e54018cb19cf0807447dc3ac747ffcfd1c: Merge tag 'pinctrl-v3.19-3' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl (2015-01-20 21:23:41 +1200) are available in the git repository at: git://git.infradead.org/battery-2.6.git

Re: [PATCH] hsi: nokia-modem: fix uninitialized device pointer

2015-01-04 Thread Sebastian Reichel
Hi Aaro, On Sun, Jan 04, 2015 at 07:34:13PM +0200, Aaro Koskinen wrote: modem-device was never initialized. This resulted in logs such as: [ 241.386322] (NULL device *): CMT rst line change detected Thanks, applied to for-next:

Re: [PATCH 4/6] power/reset/rmobile-reset.c: Fix !HAS_IOMEM build

2015-03-20 Thread Sebastian Reichel
Hi Richard, On Mon, Mar 16, 2015 at 10:27:08PM +0100, Richard Weinberger wrote: Fixes: drivers/power/reset/rmobile-reset.c: In function ‘rmobile_reset_probe’: drivers/power/reset/rmobile-reset.c:61:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]

Re: [PATCH 06/35 linux-next] power: constify of_device_id array

2015-03-20 Thread Sebastian Reichel
Hi Fabian, On Mon, Mar 16, 2015 at 08:17:12PM +0100, Fabian Frederick wrote: of_device_id is always used as const. (See driver.of_match_table and open firmware functions) Signed-off-by: Fabian Frederick f...@skynet.be Thanks, applied:

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-03-20 Thread Sebastian Reichel
Hi, On Fri, Mar 20, 2015 at 09:54:21AM +0100, Dr. H. Nikolaus Schaller wrote: [...] And we do not write a driver for the w2sg0004 but the regulator inside that chip. DT describes the hardware structure and not the Linux driver structure. You also won’t expect that the omap3 driver hides

[PATCHv3 2/2] HSI: nokia-modem: Add cmt-speech support

2015-03-21 Thread Sebastian Reichel
Register cmt-speech driver in nokia-modem driver and forward hsi channel information. Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/hsi/clients/Kconfig | 2 +- drivers/hsi/clients/nokia-modem.c | 32 +++- 2 files changed, 32 insertions(+), 2

[PATCHv3 1/2] HSI: cmt_speech: Add cmt-speech driver

2015-03-21 Thread Sebastian Reichel
hardcoded channels numbers with values provided via the HSI framework (e.g. coming from DT) Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/hsi/clients/Kconfig | 10 + drivers/hsi/clients/Makefile |1 + drivers/hsi/clients/cmt_speech.c | 1456

[PATCHv3 0/2] N900 Modem Speech Support

2015-03-21 Thread Sebastian Reichel
/2015/3/4/1139 -- Sebastian Kai Vehmanen (1): HSI: cmt_speech: Add cmt-speech driver Sebastian Reichel (1): HSI: nokia-modem: Add cmt-speech support drivers/hsi/clients/Kconfig | 12 +- drivers/hsi/clients/Makefile |1 + drivers/hsi/clients/cmt_speech.c | 1456

Re: [PATCHv3 0/2] N900 Modem Speech Support

2015-03-21 Thread Sebastian Reichel
Hi, On Sat, Mar 21, 2015 at 08:09:15PM +0100, Sebastian Reichel wrote: [1] git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi.git branch/cmt-speech-2 This should actually be: git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi.git branch/cmt-speech-3 -- Sebastian

Re: [PATCH] power_supply: 88pm860x_charger: Fix possible NULL pointer dereference and use of initialized variable

2015-03-20 Thread Sebastian Reichel
Hi Krzysztof, On Fri, Mar 20, 2015 at 10:26:02AM +0100, Krzysztof Kozlowski wrote: Do not put reference to power supply in early exit paths of pm860x_done_handler() because: 1. it is not yet initialized, 2. it is NULL. This fixes possible NULL pointer dereference and following build

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-03-20 Thread Sebastian Reichel
Hi, On Fri, Mar 20, 2015 at 02:57:12PM +0100, Dr. H. Nikolaus Schaller wrote: On Fri, Mar 20, 2015 at 09:54:21AM +0100, Dr. H. Nikolaus Schaller wrote: [...] And we do not write a driver for the w2sg0004 but the regulator inside that chip. DT describes the hardware structure and not

Re: twl4030_charger: need changes to get probed?

2015-03-09 Thread Sebastian Reichel
Hi, On Mon, Mar 09, 2015 at 11:06:53AM +1100, NeilBrown wrote: On Sat, 7 Mar 2015 22:01:02 +0100 Sebastian Reichel s...@debian.org wrote: platform_driver_probe() does not support deferred probing. Neil, can you take this patch into your series for the next round? I could, but I do

Re: [RFC 1/4] power_supply: Introduce charging object table

2015-03-09 Thread 'Sebastian Reichel'
Hi, On Mon, Mar 09, 2015 at 12:26:21PM +, Tc, Jenny wrote: + char name[PSY_MAX_BAT_NAME_LEN]; char *name; No need for arbitrary length limitation. The length limitation is introduced to form a packed structure so that the data can be read directly from memory without parsing.

Re: [RFC 3/4] power_supply: Introduce charger control interface

2015-03-09 Thread Sebastian Reichel
Hi, On Mon, Mar 09, 2015 at 12:47:18PM +, Tc, Jenny wrote: +struct power_supply_charger { + int (*get_property)(struct power_supply_charger *psyc, + enum psy_charger_control_property pspc, + union power_supply_propval *val); The

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-11 Thread Sebastian Reichel
Hi, On Wed, Mar 11, 2015 at 10:43:17AM -0700, Tony Lindgren wrote: No no, capacity-uah is what we should use, but you need an ack from the battery and device tree people that this is OK. Let's not add ti,capacity-uah” as that can obviously be a generic property. I'm okay with capacity-uah.

Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-08 Thread Sebastian Reichel
. They are have vary charge rate, charge parameters. The charge parameters can be controlled by i2c interface. Driver looks mostly ok, but I have some comments [inline]. Cc: Sebastian Reichel s...@kernel.org Cc: Dmitry Eremin-Solenikov dbarysh...@gmail.com Cc: David Woodhouse dw...@infradead.org

Re: [PATCH] power: generic-adc-battery: Fix power_supply_property returned value

2015-03-08 Thread Sebastian Reichel
Hi, On Sun, Mar 08, 2015 at 07:21:20PM +, nicolassae...@gmail.com wrote: From: Nicolas Saenz Julienne nicolassae...@gmail.com The POWER_SUPPLY_PROP_STATUS case in gab_get_property() wasn't providing any value. Thanks, queued:

Re: [PATCH 0/2] bq2415x_charger: Fix coding style issues and add new charger in the list of supported chargers

2015-03-07 Thread Sebastian Reichel
Hi, On Thu, Mar 05, 2015 at 01:23:55PM +0200, Anda-Maria Nicolae wrote: Hello, First patch from patchset fixes coding style issues: removes unnecessary else after return. This way, the coding style complies with checkpatch.pl. Second patch from patchset updates bq2415x driver to support

Re: [PATCH v4 0/3] X-Power AXP288 PMIC Fuel Gauge Driver

2015-03-07 Thread Sebastian Reichel
Hi, On Wed, Feb 04, 2015 at 04:24:35PM -0800, Todd Brandt wrote: New power_supply driver at driver/power which interfaces with the axp20x mfd driver as a cell. Provides battery info, monitors for changes, and generates alerts on temperature and capacity issues Sebestian, please review the

Re: [PATCH] ab8500_fg.c: only request threaded IRQs when necessary

2015-03-07 Thread Sebastian Reichel
Hi Valentin, On Mon, Feb 16, 2015 at 05:32:48PM +0100, Valentin Rothberg wrote: All 5 IRQ handlers of the driver are requested as threaded interrupt handlers. However, only 1 handler can block. The remaining 4 handlers defer the actual handling to a workqueue. Hence, 4 of 5 IRQ handlers

Re: [PATCH] power/smb347-charger.c: set IRQF_ONESHOT flag to ensure IRQ request

2015-03-07 Thread Sebastian Reichel
Hi, On Mon, Mar 02, 2015 at 03:32:48PM +0100, Valentin Rothberg wrote: Since commit 1c6c69525b40eb76de8adf039409722015927dc3 (genirq: Reject bogus threaded irq requests) threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request may fail. Generated

Re: [PATCH v1 0/3 RESEND] NI Ettus Research USRP E3x0 soft-poweroff.

2015-03-07 Thread Sebastian Reichel
Hi, Please CC linux-pm. On Wed, Mar 04, 2015 at 02:25:46PM -0800, Moritz Fischer wrote: This patchset adds support for the NI Ettus Research USRP E3x0 SDR's poweroff functionality. I would prefer to have a generic driver like syscon-reboot does for system reset. -- Sebastian signature.asc

Re: [PATCH v7 2/5] power: max77843_charger: Add Max77843 charger device driver

2015-03-07 Thread Sebastian Reichel
charging paramters to use i2c interface. Cc: Sebastian Reichel s...@kernel.org Signed-off-by: Beomho Seo beomho@samsung.com Reviewed-By: Sebastian Reichel s...@kernel.org I can't take it as is, since it depends on the private header file of PATCHv1. -- Sebastian signature.asc Description

Re: [PATCH v7 3/5] power: max77843_battery: Add Max77843 fuel gauge device driver

2015-03-07 Thread Sebastian Reichel
and portable devices. Cc: Sebastian Reichel s...@kernel.org Signed-off-by: Beomho Seo beomho@samsung.com Reviewed-By: Sebastian Reichel s...@kernel.org I can't take it as is, since it depends on the private header file of PATCH 1. -- Sebastian signature.asc Description: Digital signature

Re: twl4030_charger: need changes to get probed?

2015-03-07 Thread Sebastian Reichel
Hi, On Fri, Mar 06, 2015 at 10:24:17PM +0100, Pavel Machek wrote: According to n900 dts, twl4030-bci (aka charger) should be included. its part of twl, but not used on N900 afaik. (But it does not seem to do anything useful on n900. I was hoping for measurement of input voltage, but .. no.)

Re: [PATCH v7 4/5] Input: add haptic drvier on max77843

2015-03-07 Thread Sebastian Reichel
Hi, On Wed, Mar 04, 2015 at 02:47:42PM -0800, Dmitry Torokhov wrote: [...] Do you want it to go through my or MFD tree? Other drivers merged in each maintainers git. Actually only Lee took PATCH 1 so far. If you don`t hava a problem, please merge your input git tree. Applied, thank

Re: [PATCH 07/15] twl4030_charger: allow fine control of charger current.

2015-03-07 Thread Sebastian Reichel
Hi Pavel, On Wed, Mar 04, 2015 at 11:24:15AM +0100, Pavel Machek wrote: (Now I'd need to study the datasheets... and figure out how to enable this on N900). The N900 uses bq24150a for charging ;) -- Sebastian signature.asc Description: Digital signature

Re: [PATCH 03/15] twl4030_charger: use devres for power_supply_register and kzalloc.

2015-03-07 Thread Sebastian Reichel
Hi, On Tue, Feb 24, 2015 at 03:33:50PM +1100, NeilBrown wrote: [...] @@ -667,13 +667,6 @@ static int __init twl4030_bci_probe(struct platform_device *pdev) return 0; fail: - power_supply_unregister(bci-usb); -fail_register_usb: - power_supply_unregister(bci-ac);

Re: [PATCH 09/15] twl4030_charger: allow max_current to be managed via sysfs.

2015-03-07 Thread Sebastian Reichel
Hi, On Thu, Mar 05, 2015 at 05:26:00PM +1100, NeilBrown wrote: [...] +What: /sys/class/power_supply/twl4030_ac/max_current + /sys/class/power_supply/twl4030_usb/max_current +Description: + Read/Write limit on current which which may + be drawn from the ac (Accessory

Re: [RFC 1/4] power_supply: Introduce charging object table

2015-03-07 Thread Sebastian Reichel
Hi, On Fri, Mar 06, 2015 at 04:03:24PM +0530, Jenny TC wrote: Charging current (CC) and charging voltage (CV) may vary based on battery temperature. To support CC and CV for different temperature zones, defined a charging object which holds the properties related to battery charging.

Re: [RFC 4/4] charger-manager: Enable psy based charge control

2015-03-07 Thread Sebastian Reichel
Hi, On Fri, Mar 06, 2015 at 04:03:27PM +0530, Jenny TC wrote: At present charger manager support only regulator based charging control. But most of the charger drivers are registered with power supply subsystem. This patch adds support for power supply based charging control along with the

Re: [RFC 1/4] power_supply: Introduce charging object table

2015-03-07 Thread Sebastian Reichel
Hi, On Fri, Mar 06, 2015 at 12:12:50PM +0100, Oliver Neukum wrote: On Fri, 2015-03-06 at 16:03 +0530, Jenny TC wrote: +struct psy_temp_mon_table { + int temp_max; + int temp_min; + int charging_current; /* CC */ + int charging_voltage; /* CV */ In which units? First few

Re: [RFC 3/4] power_supply: Introduce charger control interface

2015-03-07 Thread Sebastian Reichel
Hi, On Fri, Mar 06, 2015 at 04:03:26PM +0530, Jenny TC wrote: Introduce power_supply charger control interfaces to control charging from charging framework like charger-manager. The interfaces are similar to the existing power supply get/set interfaces, but introduce a different set of

Re: [PATCH 1/2] power: reset: Add generic SYSCON register mapped poweroff.

2015-03-10 Thread Sebastian Reichel
Hi, On Tue, Mar 10, 2015 at 04:21:09PM -0700, Moritz Fischer wrote: Add a generic SYSCON register mapped poweroff mechanism. Driver looks mostly fine. [...] +#ifdef CONFIG_OF +static const struct of_device_id syscon_poweroff_of_match[] = { + { .compatible = syscon-poweroff }, + {}

Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver

2015-03-09 Thread Sebastian Reichel
Hi, On Mon, Mar 09, 2015 at 01:53:58PM +0900, Beomho Seo wrote: remove the special handling of POWER_SUPPLY_PROP_CURRENT_MAX in rt5033_get_charger_current() and do it like this: case POWER_SUPPLY_PROP_CURRENT_NOW: val-intval = rt5033_get_charger_current(charger); break;

Re: [PATCHv2 1/2] power: reset: Add generic SYSCON register mapped poweroff.

2015-03-11 Thread Sebastian Reichel
Hi Moritz, On Wed, Mar 11, 2015 at 03:32:24PM -0700, Moritz Fischer wrote: [...] +static struct platform_driver syscon_poweroff_driver = { + .probe = syscon_poweroff_probe, + .remove = syscon_poweroff_remove, + .driver = { + .name = syscon-poweroff, +

Re: [PATCH] HID: input: Fix NULL pointer dereference when power_supply_register fails

2015-03-24 Thread Sebastian Reichel
Hi Krzysztof Jiri, On Tue, Mar 24, 2015 at 12:02:41PM +0100, Jiri Kosina wrote: On Mon, 23 Mar 2015, Krzysztof Kozlowski wrote: Do not call power_supply_powers() if power_supply_register() failed earlier. This fixes possible NULL pointer dereference by power_supply_powers() in such

Re: [PATCH] power_supply: charger-manager: Fix dereferencing of ERR_PTR

2015-03-24 Thread Sebastian Reichel
Hi Krzysztof, On Tue, Mar 24, 2015 at 08:58:43AM +0100, Krzysztof Kozlowski wrote: If power_supply_register() fails do not dereference returned ERR_PTR. The pointer was dereferenced to print name of battery which registration failed. Instead use the name from the power supply description

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-24 Thread Sebastian Reichel
Hi, On Tue, Mar 24, 2015 at 06:58:15PM +0100, Dr. H. Nikolaus Schaller wrote: So you propose that the parent-child relationship is “control”? I.e. some channel which allows to address some bus client (through reg) and control that devices. Makes sense. This is how i2c and spi clients are

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-25 Thread Sebastian Reichel
Hi, On Wed, Mar 25, 2015 at 08:59:14AM +0100, Dr. H. Nikolaus Schaller wrote: Am 25.03.2015 um 02:45 schrieb Sebastian Reichel s...@kernel.org: On Tue, Mar 24, 2015 at 06:58:15PM +0100, Dr. H. Nikolaus Schaller wrote: So you propose that the parent-child relationship is “control”? I.e. some

[PATCHv2 1/4] lis3lv02d: DT: use s32 to support negative values

2015-03-27 Thread Sebastian Reichel
st,axis-{x,y,z} can be negative to imply inverted axis. Apart from that the minimal and maximal threshold may be negative. Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/misc/lis3lv02d/lis3lv02d.c | 39 +++--- 1 file changed, 20 insertions(+), 19

[PATCHv2 2/4] lis3lv02d: DT: add wakeup unit 2 and wakeup threshold

2015-03-27 Thread Sebastian Reichel
This adds support for the the wakeup threshold and support for the second wakeup unit to the DT based setup. Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/misc/lis3lv02d/lis3lv02d.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/misc/lis3lv02d

[PATCHv2 0/4] [RESENT] lis3lv02d: update DT binding for use with Nokia N900

2015-03-27 Thread Sebastian Reichel
tree: This at least currently does not conflict with anything I have queued, so I suggest you try to get Greg to take the whole set: [0] Documentation/devicetree/bindings/misc/lis302.txt [1] http://article.gmane.org/gmane.linux.ports.arm.omap/125020 -- Sebastian Sebastian Reichel (4

[PATCHv2 4/4] DTS: ARM: OMAP3-N900: Add lis3lv02d support

2015-03-27 Thread Sebastian Reichel
This adds support for the N900's accelerometer to the Nokia N900 DTS file. Signed-off-by: Sebastian Reichel s...@kernel.org Acked-by: Tony Lindgren t...@atomide.com --- Quote from Tony: This at least currently does not conflict with anything I have queued, so I suggest you try to get Greg

[PATCHv2 3/4] Documentation: DT: lis302: update wakeup binding

2015-03-27 Thread Sebastian Reichel
This updated the documentation of the DT binding to describe the added wakeup threshold and second wakeup engine. It also adds a note, that the axis values may be negative. Signed-off-by: Sebastian Reichel s...@kernel.org --- Documentation/devicetree/bindings/misc/lis302.txt | 9 - 1

Re: [PATCHv3 0/2] N900 Modem Speech Support

2015-03-31 Thread Sebastian Reichel
Hi, On Sat, Mar 21, 2015 at 08:09:15PM +0100, Sebastian Reichel wrote: This patchset contains the missing speech data support for the Nokia N900 modem. [...] HSI: cmt_speech: Add cmt-speech driver HSI: nokia-modem: Add cmt-speech support drivers/hsi/clients/Kconfig | 12

[PATCHv2 2/2] HSI: nokia-modem: Add cmt-speech support

2015-03-02 Thread Sebastian Reichel
Register cmt-speech driver in nokia-modem driver and forward hsi channel information. Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/hsi/clients/Kconfig | 2 +- drivers/hsi/clients/nokia-modem.c | 31 ++- 2 files changed, 31 insertions(+), 2

[PATCHv2 1/2] HSI: cmt_speech: Add cmt-speech driver

2015-03-02 Thread Sebastian Reichel
hardcoded channels numbers with values provided via the HSI framework (e.g. coming from DT) Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/hsi/clients/Kconfig |9 + drivers/hsi/clients/Makefile |1 + drivers/hsi/clients/cmt_speech.c | 1457

[PATCHv2 0/2] N900 Modem Speech Support

2015-03-02 Thread Sebastian Reichel
://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-hsi.git branch/cmt-speech-2 [2] https://lkml.org/lkml/2015/3/1/282 -- Sebastian Kai Vehmanen (1): HSI: cmt_speech: Add cmt-speech driver Sebastian Reichel (1): HSI: nokia-modem: Add cmt-speech support drivers/hsi/clients/Kconfig | 11

Re: [PATCH 0/9] N900 Modem Speech Support

2015-03-02 Thread Sebastian Reichel
Hi, On Mon, Mar 02, 2015 at 08:05:31PM +0100, Pali Rohár wrote: On Monday 02 March 2015 05:38:50 Sebastian Reichel wrote: This patchset contains the missing speech data support for the Nokia N900 modem. [...] Hello, do you have also DT patches? Or no DT changes are needed? No DT

Re: [PATCH v2] power: bq27x00_battery: add bq27510 support

2015-02-28 Thread Sebastian Reichel
Hi Alexandre, On Sat, Feb 28, 2015 at 02:18:12PM +0100, Alexandre Belloni wrote: Add support for bq27510 to the bq27x00 driver. Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com --- Changes in v2: - corrected the bq27x00_battery_read_cyct changes patch looks fine, but

Re: [PATCH 1/9] HSI: cmt_speech: Add cmt-speech driver

2015-03-02 Thread Sebastian Reichel
Hi Oliver, On Mon, Mar 02, 2015 at 11:22:33AM +0100, Oliver Neukum wrote: +static ssize_t cs_char_read(struct file *file, char __user *buf, size_t count, + loff_t *unused) +{ + struct cs_char *csdata = file-private_data; +

Re: [PATCH v3 4/9] power: reset: Add AT91RM9200 reset driver

2015-03-04 Thread Sebastian Reichel
Hi, On Wed, Mar 04, 2015 at 03:21:32PM +0100, Alexandre Belloni wrote: AT91RM9200 uses the watchdog from the system timer to reset. [...] + regmap_write(regmap_st, AT91_ST_WDMR, + AT91_ST_RSTEN | AT91_ST_EXTEN | 1); + regmap_write(regmap_st, AT91_ST_CR,

Re: [PATCH v3 4/6] ARM: dts: omap3-gta04: Add battery support

2015-03-04 Thread Sebastian Reichel
Hi, On Wed, Feb 04, 2015 at 11:14:33PM +0100, Marek Belisko wrote: Signed-off-by: Marek Belisko ma...@goldelico.com --- arch/arm/boot/dts/omap3-gta04.dtsi | 30 ++ 1 file changed, 30 insertions(+) DTS changes must go via omap-dt tree once the driver changes have

Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-04 Thread Sebastian Reichel
Hi, On Wed, Feb 04, 2015 at 11:14:32PM +0100, Marek Belisko wrote: + - volt-to-capacity-charging-map : list of voltage(mV):level(%) values + for charging calibration (see example) + - volt-to-capacity-discharging-map : list of voltage(mV):level(%) values + for discharging calibration

Re: [PATCH v4 0/3] X-Power AXP288 PMIC Fuel Gauge Driver

2015-03-04 Thread Sebastian Reichel
Hi, On Wed, Feb 04, 2015 at 04:24:35PM -0800, Todd Brandt wrote: New power_supply driver at driver/power which interfaces with the axp20x mfd driver as a cell. Provides battery info, monitors for changes, and generates alerts on temperature and capacity issues Sebestian, please review the

Re: [PATCH] power: bq27x00_battery: add bq27510 support

2015-02-28 Thread Sebastian Reichel
Hi Alexandre, On Sat, Feb 28, 2015 at 02:22:23PM +0100, Alexandre Belloni wrote: Hi, On 25/02/2015 at 23:17:48 +0100, Sebastian Reichel wrote : @@ -350,6 +378,9 @@ static int bq27x00_battery_read_cyct(struct bq27x00_device_info *di) { int cyct; + spurious newline

Re: [PATCH v3] power: bq27x00_battery: add bq27510 support

2015-02-28 Thread Sebastian Reichel
Hi Alexandre, On Sat, Feb 28, 2015 at 06:59:28PM +0100, Alexandre Belloni wrote: Add support for bq27510 to the bq27x00 driver. Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com Thanks, queued:

[PATCH 0/9] N900 Modem Speech Support

2015-03-01 Thread Sebastian Reichel
: Avoid GFP_ATOMIC in cs_char_open HSI: cmt_speech: Return error if HSI port not configured Sebastian Reichel (6): HSI: cmt_speech: Fix build for 4.0 kernel HSI: cmt_speech: Cleanup initialisation HSI: cmt_speech: Rename driver to cmt-speech HSI: cmt_speech: Move cs-protocol.h to include/uapi

[PATCH 2/9] HSI: cmt_speech: Avoid GFP_ATOMIC in cs_char_open

2015-03-01 Thread Sebastian Reichel
From: Kai Vehmanen kai.vehma...@nokia.com Also fixes a bug in updating 'opened' state in case cs_hsi_start() fails when opening the char device. Signed-off-by: Kai Vehmanen kai.vehma...@nokia.com Signed-off-by: Joni Lapilainen joni.lapilai...@gmail.com Signed-off-by: Sebastian Reichel s

[PATCH 7/9] HSI: cmt_speech: Move cs-protocol.h to include/uapi/linux/hsi

2015-03-01 Thread Sebastian Reichel
Move cs-protocol.h to include/uapi/linux/hsi, since it describes a userspace API. Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/hsi/clients/cmt_speech.c| 2 +- include/uapi/linux/hsi/Kbuild | 2 +- include/{linux = uapi/linux/hsi}/cs-protocol.h

[PATCH 1/9] HSI: cmt_speech: Add cmt-speech driver

2015-03-01 Thread Sebastian Reichel
Vehmanen kai.vehma...@nokia.com Signed-off-by: Carlos Chinea carlos.chi...@nokia.com Signed-off-by: Joni Lapilainen joni.lapilai...@gmail.com Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/hsi/clients/cmt_speech.c | 1426 ++ include/linux/cs-protocol.h

[PATCH 8/9] HSI: cmt_speech: Remove hardcoded channel numbers

2015-03-01 Thread Sebastian Reichel
cmt-speech channel numbers should be coming from Device Tree instead of being hardcoded. Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/hsi/clients/cmt_speech.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/drivers/hsi/clients

[PATCH 9/9] HSI: nokia-modem: Add cmt_speech support

2015-03-01 Thread Sebastian Reichel
This adds cmt_speech support to the nokia-modem driver and adds Kconfig entries for cmt_speech, so that it can be built. Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/hsi/clients/Kconfig | 11 ++- drivers/hsi/clients/Makefile | 1 + drivers/hsi/clients/nokia

[PATCH 6/9] HSI: cmt_speech: Rename driver to cmt-speech

2015-03-01 Thread Sebastian Reichel
Rename driver and platform alias to cmt-speech, so that it's consistent with the ssi-protocol driver. Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/hsi/clients/cmt_speech.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hsi/clients/cmt_speech.c

  1   2   3   4   5   6   7   8   9   10   >