Re: [PATCH 2/3] x86: Convert vdso to use vm_fault_t

2018-08-03 Thread Souptick Joarder
On Mon, Jul 16, 2018 at 2:47 PM, Thomas Gleixner wrote: > On Tue, 3 Jul 2018, Matthew Wilcox wrote: > >> Return vm_fault_t codes directly from the appropriate mm routines instead >> of converting from errnos ourselves. Fixes a minor bug where we'd return >> SIGBUS instead of the correct OOM code

[PATCH] x86/vdso: Change return type to vm_fault_t for fault handlers

2018-06-25 Thread Souptick Joarder
_fault_t") Previously vm_insert_pfn() returns err which has to mapped into VM_FAULT_* type. The new function vmf_insert_pfn() will replace this inefficiency by returning VM_FAULT_* type. Signed-off-by: Souptick Joarder --- arch/x86/entry/vdso/vma.c | 19 --- 1 file changed, 8 inse

Re: [PATCH 2/3] x86: Convert vdso to use vm_fault_t

2018-08-27 Thread Souptick Joarder
On Fri, Aug 3, 2018 at 6:44 PM Thomas Gleixner wrote: > > On Fri, 3 Aug 2018, Souptick Joarder wrote: > > On Mon, Jul 16, 2018 at 2:47 PM, Thomas Gleixner wrote: > > > On Tue, 3 Jul 2018, Matthew Wilcox wrote: > > > > > >> Return vm_fault_t codes directl

[PATCH] fs: iomap: Change return type to vm_fault_t

2018-08-27 Thread Souptick Joarder
Return type has been changed to vm_fault_t type for iomap_page_mkwrite(). see commit 1c8f422059ae ("mm: change return type to vm_fault_t") for reference. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- fs/iomap.c| 2 +- include/linux/iomap.h | 4 +++

Re: [PATCH 2/3] x86: Convert vdso to use vm_fault_t

2018-08-27 Thread Souptick Joarder
On Mon, Aug 27, 2018 at 11:35 PM Matthew Wilcox wrote: > > On Mon, Aug 27, 2018 at 09:01:48PM +0530, Souptick Joarder wrote: > > On Fri, Aug 3, 2018 at 6:44 PM Thomas Gleixner wrote: > > > > > > On Fri, 3 Aug 2018, Souptick Joarder wrote: > > > > On Mon

[PATCH] mm: Conveted to use vm_fault_t

2018-08-28 Thread Souptick Joarder
As part of vm_fault_t conversion filemap_page_mkwrite() for NOMMU case was missed. Now converted. Signed-off-by: Souptick Joarder --- mm/filemap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 52517f2..de6fed2 100644 --- a/mm/filemap.c

Re: [PATCH] mm: Conveted to use vm_fault_t

2018-08-28 Thread Souptick Joarder
On Tue, Aug 28, 2018 at 11:18 PM Souptick Joarder wrote: > > As part of vm_fault_t conversion filemap_page_mkwrite() > for NOMMU case was missed. Now converted. > > Signed-off-by: Souptick Joarder cc: Matthew Wilcox > --- > mm/filemap.c | 4 ++-- > 1 file cha

[PATCH] fs: Convert return type int to vm_fault_t

2018-08-28 Thread Souptick Joarder
error number along with VM_FAULT return value and use it further. Return type of block_page_mkwrite_return() is also changed to use new vm_fault_t type. Signed-off-by: Souptick Joarder --- fs/buffer.c | 20 +++- fs/ext4/ext4.h | 4 ++-- fs/ext4

Re: [PATCH 1/3] mm: Introduce vmf_insert_pfn_prot

2018-07-26 Thread Souptick Joarder
On Tue, Jul 3, 2018 at 6:09 PM, Matthew Wilcox wrote: > Like vm_insert_pfn_prot(), but returns a vm_fault_t instead of an errno. > Also unexport vm_insert_pfn_prot as it has no modular users. > > Signed-off-by: Matthew Wilcox > --- Any comment on this patch ? > include/linux/mm.h | 2 ++ > mm

Re: [PATCH 3/3] mm: Make vm_insert_pfn_prot static

2018-07-26 Thread Souptick Joarder
On Tue, Jul 3, 2018 at 6:09 PM, Matthew Wilcox wrote: > Now this is no longer used outside mm/memory.c, make it static. > > Signed-off-by: Matthew Wilcox > --- Any comment on this patch ? > include/linux/mm.h | 2 -- > mm/memory.c| 50 +++--- >

[PATCH] ext4: Convert int to vm_fault_t type

2018-07-28 Thread Souptick Joarder
Use new return type vm_fault_t for ext4_page_mkwrite handler and block_page_mkwrite_return. Signed-off-by: Souptick Joarder --- fs/ext4/ext4.h | 2 +- fs/ext4/inode.c | 20 ++-- include/linux/buffer_head.h | 3 ++- 3 files changed, 13 insertions(+), 12

Re: [PATCH] ext4: Convert int to vm_fault_t type

2018-07-28 Thread Souptick Joarder
On Sat, Jul 28, 2018 at 2:20 PM, Souptick Joarder wrote: > Use new return type vm_fault_t for ext4_page_mkwrite > handler and block_page_mkwrite_return. > > Signed-off-by: Souptick Joarder As part of commit 2fae376c0a16db42eb438 in linux-next tree, this conversion was missed. So

[PATCH] fs/buffer: Convert return type int to vm_fault_t

2018-07-28 Thread Souptick Joarder
Return type of block_page_mkwrite() is converted to vm_fault_t type. The caller of block_page_mkwrite inside fs/nilfs2 nilfs_page_mkwrite converted accordingly. Signed-off-by: Souptick Joarder --- fs/buffer.c | 16 +--- fs/nilfs2/file.c| 13

Re: [PATCH] fs/buffer: Convert return type int to vm_fault_t

2018-07-29 Thread Souptick Joarder
On Sat, Jul 28, 2018 at 8:34 PM, Jens Axboe wrote: > On 7/28/18 3:50 AM, Souptick Joarder wrote: >> out_unlock: >> unlock_page(page); >> + ret = block_page_mkwrite_return(err); >> return ret; > > return block_page_mkwrite_return(err);

[PATCH v2] fs/buffer: Convert return type int to vm_fault_t

2018-07-30 Thread Souptick Joarder
Return type of block_page_mkwrite() is converted to vm_fault_t type. The caller of block_page_mkwrite inside fs/nilfs2 nilfs_page_mkwrite converted accordingly. Signed-off-by: Souptick Joarder --- v2: Address Jens's comment. Remove ret variable from block_page_mkwrite(). fs/buf

[PATCH] gpu/drm/hisilicon: Convert drm_atomic_helper_suspend/resume()

2018-07-19 Thread Souptick Joarder
convert drm_atomic_helper_suspend/resume() to use drm_mode_config_helper_suspend/resume(). Fixed one sparse warning by making hibmc_drm_interrupt static. Signed-off-by: Souptick Joarder Signed-off-by: Ajit Negi --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 24

Re: [PATCH] fs: iomap: Change return type to vm_fault_t

2018-07-19 Thread Souptick Joarder
On Wed, Jul 4, 2018 at 3:22 AM, Andreas Gruenbacher wrote: > On 3 July 2018 at 23:39, Darrick J. Wong wrote: >> On Mon, Jul 02, 2018 at 07:52:41PM +0200, Andreas Gruenbacher wrote: >>> On 2 July 2018 at 17:43, Souptick Joarder wrote: >>> > Return type has been

Re: [PATCH] fs: iomap: Change return type to vm_fault_t

2018-07-19 Thread Souptick Joarder
On Fri, Jul 20, 2018 at 11:39 AM, Darrick J. Wong wrote: > On Fri, Jul 20, 2018 at 10:31:30AM +0530, Souptick Joarder wrote: >> On Wed, Jul 4, 2018 at 3:22 AM, Andreas Gruenbacher >> wrote: >> > On 3 July 2018 at 23:39, Darrick J. Wong wrote: >> >> On M

[PATCH] fs: ceph: Adding new return type vm_fault_t

2018-07-22 Thread Souptick Joarder
Use new return type vm_fault_t for page_mkwrite and fault handler. vmf_error() is the newly introduce inline function in 4.17 Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- fs/ceph/addr.c | 62 ++ 1 file changed, 32

[PATCH] arch/s390: Use new return type vm_fault_t

2018-07-22 Thread Souptick Joarder
use new return type vm_fault_t for fault handler vdso_fault. Signed-off-by: Souptick Joarder --- arch/s390/kernel/vdso.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/kernel/vdso.c b/arch/s390/kernel/vdso.c index 09abae4..3031cc6 100644 --- a/arch/s390/kernel

Re: [PATCH] ext4: Convert int to vm_fault_t type

2018-08-01 Thread Souptick Joarder
On Wed, Aug 1, 2018 at 6:25 PM, Theodore Y. Ts'o wrote: > On Sat, Jul 28, 2018 at 02:20:00PM +0530, Souptick Joarder wrote: >> Use new return type vm_fault_t for ext4_page_mkwrite >> handler and block_page_mkwrite_return. >> >> Signed-off-by: Souptick Joarder >

Re: [PATCH] ext4: Convert int to vm_fault_t type

2018-08-01 Thread Souptick Joarder
On Wed, Aug 1, 2018 at 6:34 PM, Souptick Joarder wrote: > On Wed, Aug 1, 2018 at 6:25 PM, Theodore Y. Ts'o wrote: >> On Sat, Jul 28, 2018 at 02:20:00PM +0530, Souptick Joarder wrote: >>> Use new return type vm_fault_t for ext4_page_mkwrite >>> handl

Re: [PATCH] drm/rockchip: Convert drm_atomic_helper_suspend/resume()

2018-08-01 Thread Souptick Joarder
On Wed, Aug 1, 2018 at 6:40 PM, Heiko Stuebner wrote: > Am Mittwoch, 1. August 2018, 14:43:47 CEST schrieb Souptick Joarder: >> On Wed, Aug 1, 2018 at 6:03 PM, Heiko Stuebner wrote: >> > Hi Souptick, >> > >> > Am Dienstag, 31. Juli 2018, 22:34:30 CEST sch

Re: [PATCH] ext4: Convert int to vm_fault_t type

2018-08-01 Thread Souptick Joarder
On Wed, Aug 1, 2018 at 6:43 PM, Matthew Wilcox wrote: > On Wed, Aug 01, 2018 at 06:34:45PM +0530, Souptick Joarder wrote: >> > The fact that ext4_page_mkwrite() returns a vm_fault_t, while >> > block_page_mkwrite() returns an int which then has to get translated >&

Re: [PATCH v2] fs/buffer: Convert return type int to vm_fault_t

2018-08-01 Thread Souptick Joarder
On Mon, Jul 30, 2018 at 8:31 PM, Souptick Joarder wrote: > Return type of block_page_mkwrite() is converted to > vm_fault_t type. The caller of block_page_mkwrite > inside fs/nilfs2 nilfs_page_mkwrite converted accordingly. > > Signed-off-by: Souptick Joarder > --- > v2: A

[PATCH v2] fs: ceph: Adding new return type vm_fault_t

2018-07-23 Thread Souptick Joarder
Use new return type vm_fault_t for page_mkwrite and fault handler. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- v2: Fixed kbuild warning fs/ceph/addr.c | 62 ++ 1 file changed, 32 insertions(+), 30 deletions(-) diff

[PATCH] char: agp: Change return type to vm_fault_t

2018-07-13 Thread Souptick Joarder
_t") was added in 4.17-rc1 to introduce the new typedef vm_fault_t. Currently we are making change to all drivers to return vm_fault_t for page fault handlers. As part of that char/agp driver is also getting changed to return vm_fault_t type from fault handler. Signed-off-by: Souptick Joarder

Re: [PATCH v3] mm: Change return type int to vm_fault_t for fault handlers

2018-07-13 Thread Souptick Joarder
On Tue, Jun 19, 2018 at 10:26 AM, Souptick Joarder wrote: > On Mon, Jun 4, 2018 at 10:47 PM, Souptick Joarder > wrote: >> Use new return type vm_fault_t for fault handler. For >> now, this is just documenting that the function returns >> a VM_FAULT value rather than an e

Re: [PATCH] fs: ext4: use new return type vm_fault_t

2018-07-15 Thread Souptick Joarder
On Sat, Jul 7, 2018 at 4:00 PM, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler > ext4_filemap_fault. > > Signed-off-by: Souptick Joarder Any comment on this patch ? > --- > fs/ext4/ext4.h | 2 +- > fs/ext4/inode.c | 8 > 2 files cha

[PATCH] mm/filemap.c: Use vmf_error()

2018-09-27 Thread Souptick Joarder
These codes can be replaced with new inline vmf_error(). Signed-off-by: Souptick Joarder --- mm/filemap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 52517f2..7d04d7c 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2581,9 +2581,7

[PATCH] mm: Introduce new function vm_insert_kmem_page

2018-09-27 Thread Souptick Joarder
vm_insert_kmem_page after this API be available in linus tree. Signed-off-by: Souptick Joarder --- include/linux/mm.h | 2 ++ mm/memory.c| 69 ++ mm/nommu.c | 7 ++ 3 files changed, 78 insertions(+) diff --git a/include/linux/mm.h b/include

Re: [PATCH] mm: Introduce new function vm_insert_kmem_page

2018-09-28 Thread Souptick Joarder
On Fri, Sep 28, 2018 at 12:02 AM Michal Hocko wrote: > > On Thu 27-09-18 23:21:23, Souptick Joarder wrote: > > vm_insert_kmem_page is similar to vm_insert_page and will > > be used by drivers to map kernel (kmalloc/vmalloc/pages) > > allocated memory to user vma. > >

Re: [PATCH v3] mm: Create the new vm_fault_t type

2018-11-23 Thread Souptick Joarder
On Thu, Nov 15, 2018 at 7:17 AM Mike Rapoport wrote: > > On Tue, Nov 06, 2018 at 05:36:42PM +0530, Souptick Joarder wrote: > > Page fault handlers are supposed to return VM_FAULT codes, > > but some drivers/file systems mistakenly return error > > numbers. Now that all d

Re: [PATCH 2/9] arch/arm/mm/dma-mapping.c: Convert to use vm_insert_range

2018-11-25 Thread Souptick Joarder
Hi Russell, On Thu, Nov 15, 2018 at 9:13 PM Souptick Joarder wrote: > > Convert to use vm_insert_range() to map range of kernel > memory to user vma. > > Signed-off-by: Souptick Joarder Any comment on this patch ? > --- > arch/arm/mm/dma-mapping.c | 21 +++---

Re: [PATCH 1/9] mm: Introduce new vm_insert_range API

2018-11-19 Thread Souptick Joarder
On Mon, Nov 19, 2018 at 9:56 PM Mike Rapoport wrote: > > On Mon, Nov 19, 2018 at 08:43:09PM +0530, Souptick Joarder wrote: > > Hi Mike, > > > > On Sat, Nov 17, 2018 at 8:07 PM Matthew Wilcox wrote: > > > > > > On Sat, Nov 17, 2018 at 12:26:38PM +0530, S

[PATCH 2/9] arch/arm/mm/dma-mapping.c: Convert to use vm_insert_range

2018-11-15 Thread Souptick Joarder
Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder --- arch/arm/mm/dma-mapping.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index

[PATCH 3/9] drivers/firewire/core-iso.c: Convert to use vm_insert_range

2018-11-15 Thread Souptick Joarder
Convert to use vm_insert_range to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- drivers/firewire/core-iso.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/firewire/core-iso.c b/drivers

Re: [Xen-devel] [PATCH 5/9] drm/xen/xen_drm_front_gem.c: Convert to use vm_insert_range

2018-11-19 Thread Souptick Joarder
On Mon, Nov 19, 2018 at 3:22 PM Oleksandr Andrushchenko wrote: > > On 11/15/18 5:49 PM, Souptick Joarder wrote: > > Convert to use vm_insert_range() to map range of kernel > > memory to user vma. > > > > Signed-off-by: Souptick Joarder > > Reviewed-by: Matth

Re: [PATCH 1/9] mm: Introduce new vm_insert_range API

2018-11-19 Thread Souptick Joarder
Hi Mike, On Sat, Nov 17, 2018 at 8:07 PM Matthew Wilcox wrote: > > On Sat, Nov 17, 2018 at 12:26:38PM +0530, Souptick Joarder wrote: > > On Fri, Nov 16, 2018 at 11:59 PM Mike Rapoport wrote: > > > > + * vm_insert_range - insert range of kernel pages into user vma >

Re: [PATCH v3] mm: Create the new vm_fault_t type

2018-11-13 Thread Souptick Joarder
On Tue, Nov 6, 2018 at 5:33 PM Souptick Joarder wrote: > > Page fault handlers are supposed to return VM_FAULT codes, > but some drivers/file systems mistakenly return error > numbers. Now that all drivers/file systems have been converted > to use the vm_fault_t return type,

[PATCH v3 2/9] arch/arm/mm/dma-mapping.c: Convert to use vm_insert_range

2018-12-06 Thread Souptick Joarder
Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder --- arch/arm/mm/dma-mapping.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index

[PATCH v3 3/9] drivers/firewire/core-iso.c: Convert to use vm_insert_range

2018-12-06 Thread Souptick Joarder
Convert to use vm_insert_range to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- drivers/firewire/core-iso.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/firewire/core-iso.c b/drivers

Re: [PATCH v3 2/9] arch/arm/mm/dma-mapping.c: Convert to use vm_insert_range

2018-12-08 Thread Souptick Joarder
Hi Robin, On Fri, Dec 7, 2018 at 12:07 AM Souptick Joarder wrote: > > Convert to use vm_insert_range() to map range of kernel > memory to user vma. > > Signed-off-by: Souptick Joarder > --- > arch/arm/mm/dma-mapping.c | 21 +++-- > 1 file changed, 7 ins

[PATCH v3 0/9] Use vm_insert_range

2018-12-06 Thread Souptick Joarder
ff* to vm_insert_range(). v2 -> v3: Declaration of vm_insert_range() moved to include/linux/mm.h Souptick Joarder (9): mm: Introduce new vm_insert_range API arch/arm/mm/dma-mapping.c: Convert to use vm_insert_range drivers/firewire/core-iso.c: Convert to use vm_insert_range drm

[PATCH v3 1/9] mm: Introduce new vm_insert_range API

2018-12-06 Thread Souptick Joarder
. vm_insert_range is the new API which will be used to map a range of kernel memory/pages to user vma. This API is tested by Heiko for Rockchip drm driver, on rk3188, rk3288, rk3328 and rk3399 with graphics. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox Reviewed-by: Mike Rapoport Tested-by

[PATCH v3 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-12-06 Thread Souptick Joarder
Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Tested-by: Heiko Stuebner Acked-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff

[PATCH v3 5/9] drm/xen/xen_drm_front_gem.c: Convert to use vm_insert_range

2018-12-06 Thread Souptick Joarder
Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox Reviewed-by: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/xen_drm_front_gem.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions

[PATCH v3 6/9] iommu/dma-iommu.c: Convert to use vm_insert_range

2018-12-06 Thread Souptick Joarder
Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- drivers/iommu/dma-iommu.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma

[PATCH v3 7/9] videobuf2/videobuf2-dma-sg.c: Convert to use vm_insert_range

2018-12-06 Thread Souptick Joarder
Convert to use vm_insert_range to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox Acked-by: Marek Szyprowski --- drivers/media/common/videobuf2/videobuf2-dma-sg.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions

[PATCH v3 8/9] xen/gntdev.c: Convert to use vm_insert_range

2018-12-06 Thread Souptick Joarder
Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox Reviewed-by: Boris Ostrovsky --- drivers/xen/gntdev.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/xen/gntdev.c b

[PATCH v3 9/9] xen/privcmd-buf.c: Convert to use vm_insert_range

2018-12-06 Thread Souptick Joarder
Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox Reviewed-by: Boris Ostrovsky --- drivers/xen/privcmd-buf.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/xen/privcmd

Re: [PATCH v3 1/9] mm: Introduce new vm_insert_range API

2018-12-07 Thread Souptick Joarder
On Fri, Dec 7, 2018 at 10:41 PM Matthew Wilcox wrote: > > On Fri, Dec 07, 2018 at 03:34:56PM +, Robin Murphy wrote: > > > +int vm_insert_range(struct vm_area_struct *vma, unsigned long addr, > > > + struct page **pages, unsigned long page_count) > > > +{ > > > + unsigned lo

Re: [PATCH v3 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range

2018-12-07 Thread Souptick Joarder
On Fri, Dec 7, 2018 at 8:20 PM Robin Murphy wrote: > > On 06/12/2018 18:42, Souptick Joarder wrote: > > Convert to use vm_insert_range() to map range of kernel > > memory to user vma. > > > > Signed-off-by: Souptick Joarder > > Tested-by: Heiko St

Re: [PATCH v3 6/9] iommu/dma-iommu.c: Convert to use vm_insert_range

2018-12-07 Thread Souptick Joarder
On Fri, Dec 7, 2018 at 7:17 PM Robin Murphy wrote: > > On 06/12/2018 18:43, Souptick Joarder wrote: > > Convert to use vm_insert_range() to map range of kernel > > memory to user vma. > > > > Signed-off-by: Souptick Joarder > > Reviewed-by: Matthew Wilcox >

Re: [PATCH v3 1/9] mm: Introduce new vm_insert_range API

2018-12-07 Thread Souptick Joarder
On Sat, Dec 8, 2018 at 2:40 AM Robin Murphy wrote: > > On 2018-12-07 7:28 pm, Souptick Joarder wrote: > > On Fri, Dec 7, 2018 at 10:41 PM Matthew Wilcox wrote: > >> > >> On Fri, Dec 07, 2018 at 03:34:56PM +, Robin Murphy wrote: > >>>> +int vm_inse

[PATCH v2 2/9] arch/arm/mm/dma-mapping.c: Convert to use vm_insert_range

2018-12-01 Thread Souptick Joarder
Convert to use vm_insert_range() to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder --- arch/arm/mm/dma-mapping.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index

[PATCH v2 3/9] drivers/firewire/core-iso.c: Convert to use vm_insert_range

2018-12-01 Thread Souptick Joarder
Convert to use vm_insert_range to map range of kernel memory to user vma. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- drivers/firewire/core-iso.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/firewire/core-iso.c b/drivers

Re: [PATCH v2 1/9] mm: Introduce new vm_insert_range API

2018-12-02 Thread Souptick Joarder
Hi Mike, On Sun, Dec 2, 2018 at 4:43 PM Mike Rapoport wrote: > > On Sun, Dec 02, 2018 at 11:49:44AM +0530, Souptick Joarder wrote: > > Previouly drivers have their own way of mapping range of > > kernel pages/memory into user vma and this was done by > > invoking vm_ins

Re: [PATCH] infiniband/hw/hns/hns_roce_hw_v2.c: Use dma_zalloc_coherent

2018-11-09 Thread Souptick Joarder
On Fri, Nov 9, 2018 at 8:08 PM Sabyasachi Gupta wrote: > > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent There are few other places in this file where same is applicable. Can we get those changes in same patch ? > > Signed-off-by: Sabyasachi Gupta > --- > drivers/infiniband/hw/h

Re: [PATCH] drivers/android/binder.c: Remove duplicate header

2018-11-09 Thread Souptick Joarder
On Fri, Nov 9, 2018 at 8:17 PM Greg KH wrote: > > On Fri, Nov 09, 2018 at 10:40:14PM +0800, kbuild test robot wrote: > > Hi Brajeswar, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test ERROR on staging/staging-testing] > > [also build test ERROR on v4.20-rc1 next-

[PATCH] fs: afs: Adding new return type vm_fault_t

2018-07-02 Thread Souptick Joarder
hange return type to vm_fault_t") for reference. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- fs/afs/internal.h | 3 ++- fs/afs/write.c| 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/afs/internal.h b/fs/afs/internal.h index f38d6a5..35e405c 10064

[PATCH] fs: nfs: Adding new return type vm_fault_t

2018-07-02 Thread Souptick Joarder
hange return type to vm_fault_t") for reference. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- fs/nfs/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nfs/file.c b/fs/nfs/file.c index 81cca49..29553fd 100644 --- a/fs/nfs/file.c +++ b/fs/

[PATCH] fs: proc: Adding new typedef vm_fault_t

2018-07-02 Thread Souptick Joarder
hange return type to vm_fault_t") for reference. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- fs/proc/vmcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index a45f0af..7243e94 100644 --- a/fs/proc/vmcore.c +++

[PATCH] fs: iomap: Change return type to vm_fault_t

2018-07-02 Thread Souptick Joarder
Return type has been changed to vm_fault_t type for iomap_page_mkwrite(). see commit 1c8f422059ae ("mm: change return type to vm_fault_t") for reference. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- fs/iomap.c| 2 +- include/linux/iomap.h | 4 +++

[PATCH] fs: 9p: Adding new return type vm_fault_t

2018-07-02 Thread Souptick Joarder
Use new return type vm_fault_t for page_mkwrite handler. see commit 1c8f422059ae ("mm: change return type to vm_fault_t") for reference. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- fs/9p/vfs_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH] hwtracing: intel_th: Change return type to vm_fault_t

2018-07-02 Thread Souptick Joarder
quot;) for reference. Signed-off-by: Souptick Joarder --- drivers/hwtracing/intel_th/msu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c index dfb57ea..0ac84eb 100644 --- a/drivers/hwtracing/intel_th/msu.c +++

Re: [PATCH v2] char: agp: Change return type to vm_fault_t

2018-07-02 Thread Souptick Joarder
On Mon, Jun 18, 2018 at 5:07 PM, Souptick Joarder wrote: > On Thu, May 31, 2018 at 10:38 AM, Souptick Joarder > wrote: >> On Mon, May 21, 2018 at 11:47 PM, Souptick Joarder >> wrote: >>> Use new return type vm_fault_t for fault handler. For now, >>> this i

Re: [PATCH v2] char: agp: Change return type to vm_fault_t

2018-07-02 Thread Souptick Joarder
On Mon, Jul 2, 2018 at 9:42 PM, Greg KH wrote: > On Mon, Jul 02, 2018 at 09:33:19PM +0530, Souptick Joarder wrote: >> On Mon, Jun 18, 2018 at 5:07 PM, Souptick Joarder >> wrote: >> > On Thu, May 31, 2018 at 10:38 AM, Souptick Joarder >> > wrote: >&

Re: [PATCH v2] x86/vdso: Change return type to vm_fault_t for fault handlers

2018-07-03 Thread Souptick Joarder
On Tue, Jul 3, 2018 at 4:47 PM, Matthew Wilcox wrote: > On Mon, Jun 25, 2018 at 11:27:37PM +0530, Souptick Joarder wrote: >> Use new return type vm_fault_t for both fault handler >> vdso_fault() and vvar_fault(). Previously vm_insert_pfn() >> returns err which has to mapped

Re: [PATCH v2] x86/vdso: Change return type to vm_fault_t for fault handlers

2018-07-03 Thread Souptick Joarder
On Tue, Jul 3, 2018 at 5:41 PM, Matthew Wilcox wrote: > On Tue, Jul 03, 2018 at 05:18:30PM +0530, Souptick Joarder wrote: >> On Tue, Jul 3, 2018 at 4:47 PM, Matthew Wilcox wrote: >> > On Mon, Jun 25, 2018 at 11:27:37PM +0530, Souptick Joarder wrote: >> >> Use new r

[PATCH] fs: ext4: use new return type vm_fault_t

2018-07-07 Thread Souptick Joarder
Use new return type vm_fault_t for fault handler ext4_filemap_fault. Signed-off-by: Souptick Joarder --- fs/ext4/ext4.h | 2 +- fs/ext4/inode.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 0b12785..aec0010 100644 --- a/fs

Re: [PATCH] orangefs: Adding new return type vm_fault_t

2018-07-10 Thread Souptick Joarder
ch in queue for 4.19 merge window ? > -Mike > > On Fri, Jul 6, 2018 at 10:05 AM, Mike Marshall wrote: >> Souptick Joarder: Any comment for this patch? >> >> Thanks for sending it ... >> >> I have it in my stack, but I haven't studied it, or xfstested it ye

Re: [PATCH] x86/vdso: Change return type to vm_fault_t for fault handlers

2018-06-25 Thread Souptick Joarder
On Mon, Jun 25, 2018 at 9:41 PM, Andy Lutomirski wrote: > On Mon, Jun 25, 2018 at 8:55 AM Souptick Joarder wrote: >> >> Use new return type vm_fault_t for fault handler. For >> now, this is just documenting that the function returns >> a VM_FAULT value rather than a

[PATCH v2] x86/vdso: Change return type to vm_fault_t for fault handlers

2018-06-25 Thread Souptick Joarder
: 1c8f422059ae ("mm: change return type to vm_fault_t") b3ec9f33acb8 ("mm: change return type to vm_fault_t") Signed-off-by: Souptick Joarder --- v2: Updated the change log arch/x86/entry/vdso/vma.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-

[PATCH] orangefs: Adding new return type vm_fault_t

2018-06-28 Thread Souptick Joarder
pe to vm_fault_t") Fixed checkpatch.pl warning. Signed-off-by: Souptick Joarder --- fs/orangefs/file.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/fs/orangefs/file.c b/fs/orangefs/file.c index db0b521..a5a2fe7 100644 --- a/fs/orangefs/file.c +++ b/f

Re: [PATCH] gpu: drm: vgem: Change return type to vm_fault_t

2018-05-24 Thread Souptick Joarder
On Thu, May 24, 2018 at 6:27 PM, Daniel Vetter wrote: > On Wed, May 23, 2018 at 03:05:35PM +0530, Souptick Joarder wrote: >> On Mon, May 14, 2018 at 9:56 PM, Daniel Vetter wrote: >> > On Thu, May 10, 2018 at 02:51:38PM -0400, Sean Paul wrote: >> >> On Thu, Ma

Re: [PATCH] gpu: drm: drm_vm: Adding new typedef vm_fault_t

2018-05-24 Thread Souptick Joarder
On Wed, May 16, 2018 at 10:09 AM, Souptick Joarder wrote: > On Thu, May 10, 2018 at 7:12 PM, Souptick Joarder > wrote: >> Use new return type vm_fault_t for fault handler. For >> now, this is just documenting that the function returns >> a VM_FAULT value rather than an e

Re: [PATCH v2] gpu: drm: gma500: Change return type to vm_fault_t

2018-05-26 Thread Souptick Joarder
ase drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Souptick-Joarder/gpu-drm-gma500-Change-return-type-to-vm_fault_t/20180526-084629 > base: git://people.freedesktop.org/~airlied/linux.git drm-next > config: x86_64-rand

[PATCH v3] gpu: drm: gma500: Change return type to vm_fault_t

2018-05-26 Thread Souptick Joarder
_fault_t") Previously vm_insert_{pfn,mixed} returns err which driver mapped into VM_FAULT_* type. The new function vmf_insert_{pfn,mixed} will replace this inefficiency by returning VM_FAULT_* type. vmf_error() is the newly introduce inline function in 4.17-rc6. Signed-off-by: Souptick Joarder

Re: [PATCH] gpu: drm: msm: Change return type to vm_fault_t

2018-05-28 Thread Souptick Joarder
On Mon, May 21, 2018 at 10:59 PM, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a distinct t

[PATCH v4] dax: Change return type to vm_fault_t

2018-05-11 Thread Souptick Joarder
Previously vm_insert_mixed() returns err which driver mapped into VM_FAULT_* type. The new function vmf_insert_mixed() will replace this inefficiency by returning VM_FAULT_* type. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox Reviewed-by: Ross Zwisler --- v2: Modified the chan

Re: [PATCH v4] dax: Change return type to vm_fault_t

2018-05-11 Thread Souptick Joarder
On Fri, May 11, 2018 at 10:04 PM, Dan Williams wrote: > On Fri, May 11, 2018 at 9:34 AM, Souptick Joarder > wrote: >> Use new return type vm_fault_t for fault handler. For >> now, this is just documenting that the function returns >> a VM_FAULT value rather than an e

[PATCH v2] mm: Change return type to vm_fault_t

2018-05-11 Thread Souptick Joarder
eturn type to vm_fault_t") Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- v2: Updated the change log mm/hugetlb.c | 2 +- mm/mmap.c| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 7c204e3..acb432a 100644 --- a/mm

Re: [PATCH] gpu: drm: tegra: Adding new typedef vm_fault_t

2018-05-11 Thread Souptick Joarder
On Mon, Apr 23, 2018 at 4:24 PM, Matthew Wilcox wrote: > On Wed, Apr 18, 2018 at 10:24:39AM +0200, Thierry Reding wrote: >> > @@ -437,20 +436,7 @@ static int tegra_bo_fault(struct vm_fault *vmf) >> > offset = (vmf->address - vma->vm_start) >> PAGE_SHIFT; >> > page = bo->pages[offset]; >> >

Re: [PATCH v2] mm: Change return type to vm_fault_t

2018-05-11 Thread Souptick Joarder
On Fri, May 11, 2018 at 11:45 PM, Matthew Wilcox wrote: > On Fri, May 11, 2018 at 11:36:39PM +0530, Souptick Joarder wrote: >> mm/hugetlb.c | 2 +- >> mm/mmap.c| 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) > > Don't we also need to

[PATCH v2] mm: Adding new return type vm_fault_t

2018-05-11 Thread Souptick Joarder
eturn type to vm_fault_t") Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- v2: updated the change log include/linux/mm.h | 4 ++-- mm/filemap.c | 8 mm/nommu.c | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/mm.h

[PATCH v3] mm: Change return type to vm_fault_t

2018-05-11 Thread Souptick Joarder
eturn type to vm_fault_t") Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- v2: updated the change log v3: added changes into the same patch include/linux/mm_types.h | 2 +- mm/hugetlb.c | 2 +- mm/mmap.c| 4 ++-- 3 files changed, 4 insert

Re: [PATCH v3] mm: Change return type to vm_fault_t

2018-05-11 Thread Souptick Joarder
On Sat, May 12, 2018 at 11:50 AM, Joe Perches wrote: > On Sat, 2018-05-12 at 11:47 +0530, Souptick Joarder wrote: >> Use new return type vm_fault_t for fault handler >> in struct vm_operations_struct. For now, this is >> just documenting that the function returns a >>

Re: [PATCH v3] mm: Change return type to vm_fault_t

2018-05-11 Thread Souptick Joarder
On Sat, May 12, 2018 at 11:55 AM, Souptick Joarder wrote: > On Sat, May 12, 2018 at 11:50 AM, Joe Perches wrote: >> On Sat, 2018-05-12 at 11:47 +0530, Souptick Joarder wrote: >>> Use new return type vm_fault_t for fault handler >>> in struct vm_operations_struct

[PATCH v4] mm: Change return type to vm_fault_t

2018-05-11 Thread Souptick Joarder
eturn type to vm_fault_t") Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- include/linux/mm_types.h | 6 +++--- mm/hugetlb.c | 2 +- mm/mmap.c| 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/mm_types.h b/inc

Re: [PATCH v3] mm: Change return type to vm_fault_t

2018-05-12 Thread Souptick Joarder
>> It'd be nicer to realign the 2nd and 3rd arguments >> on the subsequent lines. >> >> vm_fault_t (*fault)(const struct vm_special_mapping *sm, >> struct vm_area_struct *vma, >> struct vm_fault *vmf); >> > > It'd be nicer if people didn't

Re: [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t

2018-05-14 Thread Souptick Joarder
On Mon, May 14, 2018 at 2:32 PM, Gerd Hoffmann wrote: > Hi, > >> > So my expectation that a backmerge happens anyway after -rc1/2 is in >> > line with reality, it is just to be delayed this time. I'll stay >> > tuned ;) >> >> Is this patch already merged in drm-misc-next tree ? > > Pushed now.

Re: [PATCH] hwtracing: intel_th: Change return type to vm_fault_t

2018-06-16 Thread Souptick Joarder
On Wed, May 2, 2018 at 7:32 PM, Souptick Joarder wrote: > On 02-May-2018 7:28 PM, "Alexander Shishkin" > wrote: >> >> On Wed, May 02, 2018 at 11:14:48AM +0530, Souptick Joarder wrote: >> > Any comment for this patch ? >> >> Looks good, I'

Re: [Freedreno] [PATCH] gpu: drm: msm: Change return type to vm_fault_t

2018-06-17 Thread Souptick Joarder
On Thu, May 31, 2018 at 11:29 PM, Jordan Crouse wrote: > On Mon, May 28, 2018 at 12:38:41PM +0530, Souptick Joarder wrote: >> On Mon, May 21, 2018 at 10:59 PM, Souptick Joarder >> wrote: >> > Use new return type vm_fault_t for fault handler. For >> > now,

Re: [PATCH v2] char: agp: Change return type to vm_fault_t

2018-06-18 Thread Souptick Joarder
On Thu, May 31, 2018 at 10:38 AM, Souptick Joarder wrote: > On Mon, May 21, 2018 at 11:47 PM, Souptick Joarder > wrote: >> Use new return type vm_fault_t for fault handler. For now, >> this is just documenting that the function returns a >> VM_FAULT value rather

Re: [PATCH v3] mm: Change return type int to vm_fault_t for fault handlers

2018-06-18 Thread Souptick Joarder
On Mon, Jun 4, 2018 at 10:47 PM, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a distinct t

Re: [PATCH] mm: Change return type to vm_fault_t

2018-05-29 Thread Souptick Joarder
On Tue, May 29, 2018 at 11:04 PM, Matthew Wilcox wrote: > On Tue, May 29, 2018 at 09:25:05PM +0530, Souptick Joarder wrote: >> On Tue, May 29, 2018 at 8:20 PM, Matthew Wilcox wrote: >> > On Tue, May 29, 2018 at 08:01:26PM +0530, Souptick Joarder wrote: >> >> Use

Re: [PATCH v2] char: agp: Change return type to vm_fault_t

2018-05-30 Thread Souptick Joarder
On Mon, May 21, 2018 at 11:47 PM, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. For now, > this is just documenting that the function returns a > VM_FAULT value rather than an errno. Once all instances are > converted, vm_fault_t will become a distinct t

Re: [PATCH] mm: Change return type to vm_fault_t

2018-06-02 Thread Souptick Joarder
On Wed, May 30, 2018 at 4:46 PM, Matthew Wilcox wrote: > On Wed, May 30, 2018 at 09:10:47AM +0530, Souptick Joarder wrote: >> On Tue, May 29, 2018 at 11:04 PM, Matthew Wilcox wrote: >> > I see: >> > >> > mm/gup.c:817:15: warning: invalid assignment: |= >>

Re: [PATCH] mm: Change return type to vm_fault_t

2018-06-02 Thread Souptick Joarder
Please ignoe this mail. I send it by mistake. On Sat, Jun 2, 2018 at 8:14 PM, Souptick Joarder wrote: > On Wed, May 30, 2018 at 4:46 PM, Matthew Wilcox wrote: >> On Wed, May 30, 2018 at 09:10:47AM +0530, Souptick Joarder wrote: >>> On Tue, May 29, 2018 at 11:04 PM, Matthew

  1   2   3   4   5   6   7   >