[PATCH] Staging: greybus: vibrator.c: Fixed alignment to match open parenthesis.

Fixed alignment so that it matched open parenthesis Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/greybus/vibrator.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/vibrator.c b/drivers/staging/greybus/vibr

[PATCH] Staging: fsl-dpaa2: ethernet: dpaa2-eth.c: Multiple assignments should be avoided.

Fixed a check reported by checkpatch.pl to avoid multiple assignments in a single statement. Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fsl

Re: [PATCH] Staging: fsl-dpaa2: ethernet: dpaa2-eth.c: Multiple assignments should be avoided.

On Sun, Aug 20, 2017 at 5:37 AM, Greg KH <gre...@linuxfoundation.org> wrote: > On Sun, Aug 20, 2017 at 04:01:25AM +0530, Srishti Sharma wrote: >> Fixed a check reported by checkpatch.pl to avoid multiple assignments in a >> single statement. > > Always wrap your c

[PATCH] Staging: fsl-dpaa2: ethernet: dpni.c: Fixed alignment to match open parenthesis.

Fixed alignment so that it matched open parenthesis Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/fsl-dpaa2/ethernet/dpni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpni.c b/drivers/staging/fsl

Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning

On Tue, May 16, 2017 at 2:45 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Tue, May 16, 2017 at 02:00:23PM +0530, srishti wrote: >> Fixed a warning : struct comedi_lrange is generally constant. >> >> Signed-off-by: Srishti Sharma <srishtis...@gmail.com> &

Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

On Mon, Jun 12, 2017 at 5:53 PM, Dan Carpenter <dan.carpen...@oracle.com> wrote: > On Sat, Jun 10, 2017 at 12:33:57AM +0530, srishti sharma wrote: >> On Sat, Jun 10, 2017 at 12:25 AM, srishti sharma <srishtis...@gmail.com> >> wrote: >> > Fixed alignment

Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

On Mon, Jun 12, 2017 at 6:47 PM, Dan Carpenter <dan.carpen...@oracle.com> wrote: > On Mon, Jun 12, 2017 at 06:16:30PM +0530, srishti sharma wrote: >> >> Thanks :) , so will this be accepted ? >> > > Probably, yes. Unless Greg has already dropped it because y

[PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

Fixed alignment so that it matched open parenthesis. Signed-off-by: srishti sharma <srishtis...@gmail.com> --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835

[PATCH v2] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

Fixed alignment so that it matched open parenthesis. Signed-off-by: srishti sharma <srishtis...@gmail.com> --- Changes in v2: -Fix all checks of the type "alignment should match open parenthesis" for a file in the same patch. .../staging/vc04_services/bcm2835-audio/bcm

Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis

On Fri, Jun 23, 2017 at 9:50 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Thu, Jun 15, 2017 at 01:04:55AM +0530, srishti sharma wrote: >> Fixed alignment so that it matched open parenthesis. >> >> Signed-off-by: srishti sharma <srishtis...@gmail.com> >

Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis

On Sat, Jun 24, 2017 at 8:11 AM, srishti sharma <srishtis...@gmail.com> wrote: > On Fri, Jun 23, 2017 at 9:50 PM, Greg KH <gre...@linuxfoundation.org> wrote: >> On Thu, Jun 15, 2017 at 01:04:55AM +0530, srishti sharma wrote: >>> Fixed alignment so that it matched op

[PATCH v2] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

Fixed alignment so that it matched open parenthesis. Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2: -Fix all checks of the type "alignment should match open parenthesis" for a file in the same patch. .../staging/vc04_services/bcm2835-audio/bcm

Re: [PATCH v2] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

On Sun, Jun 25, 2017 at 8:01 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Sat, Jun 24, 2017 at 08:58:10AM +0530, srishti sharma wrote: >> Fixed alignment so that it matched open parenthesis. >> >> Signed-off-by: srishti sharma <srishtis...@gmail.com>

Fwd: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue

-- Forwarded message -- From: srishti sharma <srishtis...@gmail.com> Date: Thu, May 18, 2017 at 9:06 PM Subject: Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue To: Greg KH <gre...@linuxfoundation.org> On Thu, May 18, 2017 at 7:28

[PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue.

fixed a trailing */ issue Signed-off-by: srishti sharma <srishtis...@gmail.com> --- drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c

Re: [PATCH] Staging: bcm2835-audio: bcm2835-ctl.c: Fixed a comment coding style issue.

On Thu, May 25, 2017 at 4:58 AM, Tobin C. Harding <m...@tobin.cc> wrote: > On Wed, May 24, 2017 at 08:03:14PM +0530, srishti sharma wrote: > > This driver is not in Greg KH's staging tree. You may like to work off > of that tree when doing staging patches. > > https://git.

Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue

On Thu, May 18, 2017 at 04:20:15PM +0530, srishti wrote: >> From: srishti sharma <srishtis...@gmail.com> >> >> Fixed a trailing */ issue. >> >> Signed-off-by: srishti sharma <srishtis...@gmail.com> >> --- >> drivers/staging/bcm2835-audio/bcm2835-

Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue

On Sat, May 20, 2017 at 1:03 AM, Dan Carpenter <dan.carpen...@oracle.com> wrote: > On Sat, May 20, 2017 at 01:00:17AM +0530, srishti sharma wrote: >> Was the format of this patch acceptable ,the "from" matches the >> "signed-off-by" right , so this sho

[PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue.

fixed a trailing */ issue . Signed-off-by: srishti sharma <srishtis...@gmail.com> --- drivers/staging/bcm2835-audio/bcm2835-ctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835

[PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue.

Fixed a comment coding style issue that generated a warning stating that block comments should align the * on each line. Signed-off-by: srishti sharma <srishtis...@gmail.com> --- drivers/staging/ccree/cc_crypto_ctx.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error.

Fixed a pointer declaration error , the dereferencing operator was misplaced. Signed-off-by: srishti sharma <srishtis...@gmail.com> --- drivers/staging/ccree/ssi_aead.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.h b/drivers/s

[PATCH] Staging: ccree: ssi_aead.h: Fixed a comment coding style issue.

Fixed a comment coding style issue , block comments use * on subsequent lines. Signed-off-by: srishti sharma <srishtis...@gmail.com> --- drivers/staging/ccree/ssi_aead.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_aead.h b/drivers/s

Re: [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error.

of them will compile , but the second one is a better representation of it and does not produce an error on running checkpatch.pl . Regards, Srishti On Sat, Jun 3, 2017 at 2:07 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Sat, Jun 03, 2017 at 04:15:17AM +0530, srishti sha

[PATCH 0/4] Fixed comment coding style issues.

This patchset contains a series of comment coding style issues fixes. srishti sharma (4): Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block. Staging: ccree: cc_crypto_ctx.h: Fixed trailing */ issue in a comment block Staging: ccree: cc_crypto_ctx.h

[PATCH 3/4] Staging: ccree: cc_crypto_ctx.h: Fixed * alignment issues in a comment block

Fixed the alignment of * in a comment block. Signed-off-by: srishti sharma <srishtis...@gmail.com> --- drivers/staging/ccree/cc_crypto_ctx.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/drivers/staging/ccree/cc_crypto

[PATCH 2/4] Staging: ccree: cc_crypto_ctx.h: Fixed trailing */ issue in a comment block

Fixed trailing */ style issue in a block comment. Signed-off-by: srishti sharma <srishtis...@gmail.com> --- drivers/staging/ccree/cc_crypto_ctx.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/drivers/staging

[PATCH 4/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block

Added *'s on subsequent lines of a comment block to fix coding style issues. Signed-off-by: srishti sharma <srishtis...@gmail.com> --- drivers/staging/ccree/cc_crypto_ctx.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/d

[PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block.

Added * on subsequent lines of a comment block. Signed-off-by: srishti sharma <srishtis...@gmail.com> --- drivers/staging/ccree/cc_crypto_ctx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/drivers/staging/ccree/cc_crypto_ctx.h

[PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue.

Fixed a comment coding style issue that generated a warning stating block comments use * on subsequent lines. Signed-off-by: srishti sharma <srishtis...@gmail.com> --- drivers/staging/ccree/cc_crypto_ctx.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/s

Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

On Tue, Jun 13, 2017 at 6:30 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Sat, Jun 10, 2017 at 02:37:22AM +0530, srishti sharma wrote: >> Fixed alignment so that it matched open parenthesis. >> >> Signed-off-by: srishti sharma <srishtis...@gmail.c

Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

On Tue, Jun 13, 2017 at 8:17 PM, Dan Carpenter <dan.carpen...@oracle.com> wrote: > On Tue, Jun 13, 2017 at 08:07:14PM +0530, srishti sharma wrote: >> On Tue, Jun 13, 2017 at 6:30 PM, Greg KH <gre...@linuxfoundation.org> wrote: >> > On Sat, Jun 10, 2017 at 02:37:22

Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open paranthesis.

On Thu, Jun 15, 2017 at 12:29 AM, Joe Perches <j...@perches.com> wrote: > On Wed, 2017-06-14 at 19:36 +0530, srishti sharma wrote: >> Fixed alignment so that it matched open paranthesis. > > Please try to avoid typos in your commit message and as > well try to do a

Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

On Wed, Jun 14, 2017 at 10:39 AM, Greg KH <gre...@linuxfoundation.org> wrote: > On Wed, Jun 14, 2017 at 03:15:11AM +0530, srishti sharma wrote: >> On Tue, Jun 13, 2017 at 8:17 PM, Dan Carpenter <dan.carpen...@oracle.com> >> wrote: >> > On Tue, Jun 13, 2017

Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

On Wed, Jun 14, 2017 at 7:19 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Wed, Jun 14, 2017 at 07:11:01PM +0530, srishti sharma wrote: >> On Wed, Jun 14, 2017 at 10:39 AM, Greg KH <gre...@linuxfoundation.org> wrote: >> > On Wed, Jun 14, 2017 at 03:15:11

[PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open paranthesis.

Fixed alignment so that it matched open paranthesis. Signed-off-by: srishti sharma <srishtis...@gmail.com> --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835

[PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis

Fixed alignment so that it matched open parenthesis. Signed-off-by: srishti sharma <srishtis...@gmail.com> --- .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835

[PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

Fixed alignment so that it matched open paranthesis . Signed-off-by: srishti sharma <srishtis...@gmail.com> --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_ho

Re: [PATCH] Staging: ks7010: ks_hostif.c: Fixed alignment to match open parenthesis

On Sat, Jun 10, 2017 at 12:25 AM, srishti sharma <srishtis...@gmail.com> wrote: > Fixed alignment so that it matched open paranthesis . > > Signed-off-by: srishti sharma <srishtis...@gmail.com> > --- > drivers/staging/ks7010/ks_hostif.c | 4 ++-- > 1 file changed

Re: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue.

On Thu, May 25, 2017 at 10:27 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Sat, May 20, 2017 at 02:00:24AM +0530, srishti sharma wrote: >> fixed a trailing */ issue . >> >> Signed-off-by: srishti sharma <srishtis...@gmail.com> >> --- >> dr

Re: [PATCH 1/4] Staging: ccree: cc_crypto_ctx.h: Added * on subsequent lines of a comment block.

On Sun, Jun 4, 2017 at 1:49 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Sun, Jun 04, 2017 at 05:02:08AM +0530, srishti sharma wrote: >> Added * on subsequent lines of a comment block. >> >> Signed-off-by: srishti sharma <srishtis...@gmail.com>

[PATCH] Staging: media: atomisp: Use kcalloc instead of kzalloc

Use kcalloc instead of kzalloc to check for an overflow before multiplication. Done using the following semantic patch by coccinelle. http://coccinelle.lip6.fr/rules/kzalloc.cocci Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/media/atomisp/pci/atomisp2/c

[PATCH v2] Staging: ccree: Use kcalloc instead of kzalloc

Use kcalloc instead of kzalloc to check for overflow before multiplication. Done using the following semantic patch by coccinelle. http://coccinelle.lip6.fr/rules/kzalloc.cocci Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2: - eliminate parentheses around the

[PATCH] Staging: lustre: obdclass: Use kcalloc instead of kzalloc

Use kcalloc instead of kzalloc to check for overflow before multiplication. Done using the following semantic patch by coccinelle. http://coccinelle.lip6.fr/rules/kzalloc.cocci Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/lustre/lustre/obdclass/cl_object.c | 2

[PATCH] Staging: ccree: Use kcalloc instead of kzalloc

Use kcalloc instead of kzalloc to check for overflow before multiplication. Done using the following semantic patch by coccinelle. http://coccinelle.lip6.fr/rules/kzalloc.cocci Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/ccree/ssi_sysfs.c | 2 +- 1 file chan

[PATCH] Staging: irda: Don't use assignment inside if statement

Write assignment statement outside the if statement. Done using the following semantic patch by coccinelle. @@ identifier E; expression F; statement S; @@ -if((E = F)) +E = F +if(E) S Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/irda/drivers/irda-usb

Re: [Outreachy kernel] [PATCH] Staging: irda: Don't use assignment inside if statement

On Sat, Sep 16, 2017 at 1:08 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > >> Write assignment statement outside the if statement. Done using >> the following semantic patch by coccinelle. >> >> @@ >&g

[PATCH v2] Staging: irda: Don't use assignment inside if statement

Write assignment statement outside the if statement. Done using the following semantic patch by coccinelle. @@ identifier E; expression F; statement S; @@ -if((E = F)) +E = F; +if(E) S Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2: -Semicolon was missing

Re: [PATCH] Staging: irda: Don't use assignment inside if statement

On Sat, Sep 16, 2017 at 1:03 AM, Srishti Sharma <srishtis...@gmail.com> wrote: > Write assignment statement outside the if statement. Done using > the following semantic patch by coccinelle. > > @@ > identifier E; > expression F; > statement S; > @@ > >

[PATCH] Staging: irda: Use !x instead of NULL comparison

) S | -if(E==NULL) +if(!E) S ) Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/irda/net/discovery.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/irda/net/discovery.c b/drivers/staging/irda/net/discovery.c index 3

[PATCH] Staging: dgnc: Remove unused variables from structure definition

Some variables in the structure were unused and hence them and the comments associated with them can be removed. Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/stagin

Re: [Outreachy kernel] [PATCH] Staging: dgnc: Remove unused variables from structure definition

On Sat, Sep 16, 2017 at 5:20 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > >> Some variables in the structure were unused and hence them and >> the comments associated with them can be removed. > > How did you

[PATCH v2 0/2] Remove unused fields in structure definition

Remove fields that are not used, from structure definitions , and eliminate the comments associated with them. Srishti Sharma (2): Staging: dgnc: Remove unused variables in structure definition Staging: dgnc: Remove unused variable in structure drivers/staging/dgnc/dgnc_driver.h | 15

[PATCH v2 1/2] Staging: dgnc: Remove unused fields in struct dgnc_board

Remove unused fields and comments associated with them in the structure definition. Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2: - Use the word field instead of variable. drivers/staging/dgnc/dgnc_driver.h | 9 - 1 file changed, 9 deletions(-) diff

[PATCH 0/2] Remove unused variables in structure definition

This patch series attempts to remove unused variables in structure variables and the comments associated with them. Srishti Sharma (2): Staging: dgnc: Remove unused variables in structure definition Staging: dgnc: Remove unused variable in structure drivers/staging/dgnc/dgnc_driver.h | 15

[PATCH 2/2] Staging: dgnc: Remove unused variable in struct channel_t

Eliminate the variables that are not used and the comments associated with them. Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/stagin

[PATCH 1/2] Staging: dgnc: Remove unused variables in struct dgnc_board

Remove unused variables and comments associated with them in the structure definition. Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/s

Re: [Outreachy kernel] [PATCH] Staging: dgnc: Remove unused variables from structure definition

On Sat, Sep 16, 2017 at 5:45 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > >> On Sat, Sep 16, 2017 at 5:20 PM, Julia Lawall <julia.law...@lip6.fr> wrote: >> > >> > >> > On Sat, 16

[PATCH v2 2/2] Staging: dgnc: Remove unused fields in struct channel_t

Eliminate the fields that are not used and the comments associated with them. Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2: - Use the word field instead of variable. drivers/staging/dgnc/dgnc_driver.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/d

[PATCH 1/2] Staging: irda: Don't use assignment inside if statement

Write assignment statement outside of the if statement. Done using the following semantic patch by coccinelle. @@ identifier E; expression F; statement S; @@ -if((E = F)) +E = F; +if(E) S Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/irda/drivers/irda-usb

[PATCH 2/2] Staging: irda: Remove parentheses on the right of assignment

Parentheses are not needed on the right hand side of assignment statement in most cases. Done using the following semantic patch by coccinelle. @@ identifier E,F,G,f; expression e,r; @@ ( E = (G == F); | E = (e == r); | E = -( ... -) ; ) Signed-off-by: Srishti Sharma <srishtis...@gmail.

[PATCH 0/2] Assign outside if

This patch series intends to remove the assignment statements inside the if statement, and eliminates the cases of parentheses around the right hand side of assignment generated as a result of the same. Srishti Sharma (2): Staging: irda: Don't use assignment inside if statement Staging

Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use assignment inside if statement

On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > >> Write assignment statement outside the if statement. Done using >> the following semantic patch by coccinelle. >> >> @@ >&g

Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use assignment inside if statement

On Sat, Sep 16, 2017 at 2:39 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > >> On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall <julia.law...@lip6.fr> wrote: >> > >> > >> > On Sat, 16 Se

[PATCH v2] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; ... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ... } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2 -Make commit message cl

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

ile(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_ap.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-)

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

ile(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8 +++- 1 file changed, 3 insertions(+), 5 del

[PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of the struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma <srishtis...@gmail.

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

ile(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 23 ++- 1 file changed, 6 insertions(+),

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

gt;> > >> > > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote: >> > > > Use list_for_each_entry_safe when the list elements may get deleted >> > > > during traversal. >> > > >> > > This patch is fine as a clea

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 4, 2017 at 10:37 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Wed, 4 Oct 2017, Srishti Sharma wrote: > >> On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter <dan.carpen...@oracle.com> >> wrote: >> > On Wed, Oct 04, 2017 at 03:34:05P

[PATCH v2] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2 -Make comm

[PATCH v2] Staging: rtl8188eu: core: rtw_xmit: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2 -Make comm

[PATCH v2] Staging: rtl8188eu: core: rtw_mlme_ext: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2 -Make th

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter wrote: > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote: >> Again, you have three patches on different files with the same subject >> line. You could add the file name eg rtw_ap: to the subject line to make >>

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

; ... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ... } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_ap.c | 22 ++ 1 file change

[PATCH v3] Staging: rtl8188eu: core: rtw_mlme_ext: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v3 -Add a blank l

Re: [PATCH v5] Staging: ccree: Remove unused variable.

On Thu, Sep 7, 2017 at 2:20 PM, Gilad Ben-Yossef <gi...@benyossef.com> wrote: > Hi, > > On Thu, Sep 7, 2017 at 10:49 AM, Srishti Sharma <srishtis...@gmail.com> wrote: >> Remove the local variable inflight_counter as it is never used. >> >> Signed-off-by

[PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON().

Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel. Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/media/omap4iss/iss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging

Re: [Outreachy kernel] [PATCH] Staging: media: imx: Prefer using BIT macro

On Fri, Sep 8, 2017 at 8:59 PM, Sean Paul <seanp...@chromium.org> wrote: > On Fri, Sep 8, 2017 at 11:11 AM, Srishti Sharma <srishtis...@gmail.com> wrote: >> Use BIT(x) instead of (1<<x). >> >> Signed-off-by: Srishti Sharma <srishtis...@gmail.com> >

[PATCH] Staging: media: imx: Prefer using BIT macro

Use BIT(x) instead of (1<<x). Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/media/imx/imx-media.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/media/imx/imx-media.h b/drivers/staging/media/imx/imx-m

Re: [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON().

On Fri, Sep 8, 2017 at 8:08 PM, Dan Carpenter <dan.carpen...@oracle.com> wrote: > On Fri, Sep 08, 2017 at 07:38:18PM +0530, Srishti Sharma wrote: >> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel. >> >> Signed-off-by: Srishti Sharma <srishtis...

Re: [Outreachy kernel] [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON().

On Fri, Sep 8, 2017 at 7:40 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Fri, 8 Sep 2017, Srishti Sharma wrote: > >> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel. >> >> Signed-off-by: Srishti Sharma <srishtis...@gmail.com>

Re: [Outreachy kernel] [PATCH] Staging: ccree: Merge assignment with return

On Sat, Sep 9, 2017 at 1:42 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > >> Return the return value of a function directly, instead of first saving it >> in a variable and then returning it. This change was mad

Re: [Outreachy kernel] [PATCH v2] Staging: ccree: Merge assignment with return

On Sat, Sep 9, 2017 at 2:28 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > >> Merge the assignment and return statements to return the value >> directly. Done using coccinelle. >> >> @@ >> local ide

[PATCH] Staging: ccree: Merge assignment with return

Return the return value of a function directly, instead of first saving it in a variable and then returning it. This change was made using the following semantic patch by coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma

[PATCH v3] Staging: ccree: Merge assignment with return

Merge the assignment and return statements to return the value directly. Done using coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v3: -Edit commit message so that it respe

[PATCH v2] Staging: ccree: Merge assignment with return

Merge the assignment and return statements to return the value directly. Done using coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2: - Edit commit message so that it re

Re: [Outreachy kernel] [PATCH v2] Staging: ccree: Merge assignment with return

On Sat, Sep 9, 2017 at 12:27 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > >> On Sat, Sep 9, 2017 at 2:28 AM, Julia Lawall <julia.law...@lip6.fr> wrote: >> > >> > >> > On Sat, 9 Sep 20

[PATCH v4] Staging: ccree: Merge assignment with return

Merge the assignment and the return statements to return the value directly. Done using coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v4: -Edit commit message so that it re

Re: [Outreachy kernel] [PATCH v3] Staging: ccree: Merge assignment with return

On Sat, Sep 9, 2017 at 12:26 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > >> Merge the assignment and return statements to return the value >> directly. Done using coccinelle. >> >> @@ >> local ide

[PATCH] Staging: rtl8712: Remove multiple blank lines

Remove extra blank line. Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtl8712/rtl8712_event.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl8712_event.h b/drivers/staging/rtl8712/rtl8712_event.h index b383740..cad7085

[PATCH v2] Staging: ccree: Merge assignment with return

Merge the assignment and return statements to return the value directly. Done using the following semantic patch by coccinelle. @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2: -C

Re: [Outreachy kernel] [PATCH] Staging: ccree: Merge assignment with return

On Sat, Sep 9, 2017 at 10:29 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 9 Sep 2017, Srishti Sharma wrote: > >> Merge the assignment and return statements to return the value >> directly. Done using coccinelle. > > Coccinelle is not always p

[PATCH] Staging: ccree: Don't use volatile for monitor_lock

The use of volatile for the variable monitor_lock is unnecessary. Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/ccree/ssi_request_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging

Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Mon, Sep 11, 2017 at 9:34 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> The use of volatile for the variable monitor_lock is unnecessary. >> >> Signed-off-by: Srishti Sharma <srishtis...@gmail.c

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Mon, Sep 11, 2017 at 9:45 PM, Srishti Sharma <srishtis...@gmail.com> wrote: > On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall <julia.law...@lip6.fr> wrote: >> >> >> On Mon, 11 Sep 2017, Srishti Sharma wrote: >> >>> On Mon, Sep 11, 2017 at 9:3

Re: [PATCH v2] Staging: ccree: Prefer using BIT macro.

On Mon, Sep 11, 2017 at 9:54 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Thu, Sep 07, 2017 at 07:44:52PM +0530, Srishti Sharma wrote: >> Use BIT(x) instead of using (1<<x), reported by checkpatch.pl. >> >> Signed-off-by: Srishti Sharma <srishtis..

[PATCH v2] Staging: ccree: Remove unused variable monitor_lock

Remove the variable monitor_lock as it is not used anywhere. Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2: -The variable that was not to be declared as volatile can be eliminated as it is not being used anywhere. drivers/staging/ccree/ssi_request_mgr.c |

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Mon, 11 Sep 2017, Srishti Sharma wrote: > >> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH <gre...@linuxfoundation.org> wrote: >> > On Mon, Sep 11, 2017 at 09:29:31PM +05

[PATCH] Staging: xgifb: vb_setmode.c: Remove unnecessary parentheses.

Fixed warning produced by checkpatch.pl to remove unecessary parentheses Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/xgifb/vb_setmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging

  1   2   3   >