[PATCH 0/2] remoteproc/rpmsg: fix kconfig dependencies for VIRTIO

2013-04-16 Thread Suman Anna
both REMOTEPROC RPMSG. The split should also enable the patches to come through remoteproc rpmsg trees respectively. regards Suman Suman Anna (2): remoteproc: fix kconfig dependencies for VIRTIO rpmsg: fix kconfig dependencies for VIRTIO drivers/remoteproc/Kconfig | 1 + drivers/rpmsg/Kconfig

[PATCH 1/2] remoteproc: fix kconfig dependencies for VIRTIO

2013-04-16 Thread Suman Anna
dependencies (VIRTUALIZATION) warning: (VIRTIO_PCI VIRTIO_MMIO REMOTEPROC RPMSG) selects VIRTIO which has unmet direct dependencies (VIRTUALIZATION) Signed-off-by: Suman Anna s-a...@ti.com --- drivers/remoteproc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/remoteproc

[PATCH 2/2] rpmsg: fix kconfig dependencies for VIRTIO

2013-04-16 Thread Suman Anna
: (VIRTIO_PCI VIRTIO_MMIO REMOTEPROC RPMSG) selects VIRTIO which has unmet direct dependencies (VIRTUALIZATION) warning: (VIRTIO_PCI VIRTIO_MMIO REMOTEPROC RPMSG) selects VIRTIO which has unmet direct dependencies (VIRTUALIZATION) Signed-off-by: Suman Anna s-a...@ti.com --- drivers/rpmsg/Kconfig

[PATCHv3 01/14] mailbox: rename pl320-ipc specific mailbox.h

2013-03-12 Thread Suman Anna
The patch 30058677 ARM / highbank: add support for pl320 IPC added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Signed-off-by: Suman Anna s-a...@ti.com Cc: Mark Langsdorf

[PATCHv3 07/14] mailbox: change protection mechanisms

2013-03-12 Thread Suman Anna
From: Loic Pallardy loic.palla...@st.com TX: replace spin by mutex to release CPU during wait on mailbox resource. Signed-off-by: Loic Pallardy loic.palla...@st.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/mailbox/mailbox.c | 5 +++--

[PATCHv3 09/14] mailbox: add IRQF_NO_SUSPEND flag

2013-03-12 Thread Suman Anna
From: Loic Pallardy loic.palla...@st.com Coprocessor must be accessible during suspend transitions. Signed-off-by: Loic Pallardy loic.palla...@st.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/mailbox/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCHv3 13/14] mailbox: check for NULL nb in mailbox_put

2013-03-12 Thread Suman Anna
The mailbox_put function must check the notifier block for NULL before trying to unregister it. Signed-off-by: Fernando Guzman Lugo lugo.ferna...@gmail.com Signed-off-by: Suman Anna s-a...@ti.com --- drivers/mailbox/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCHv3 06/14] mailbox: create opened message type

2013-03-12 Thread Suman Anna
and tidspbridge drivers. Signed-off-by: Loic Pallardy loic.palla...@st.com Signed-off-by: Omar Ramirez Luna omar.rami...@copitl.com Signed-off-by: Suman Anna s-a...@ti.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/mailbox/Kconfig | 9 drivers/mailbox

[PATCHv3 05/14] mailbox: rename omap_mbox in mailbox

2013-03-12 Thread Suman Anna
From: Loic Pallardy loic.palla...@st.com In order to create a generic mailbox framework, functions and structures should be renamed in mailbox. Taking care of remoteproc and tidspbridge while at it. Signed-off-by: Loic Pallardy loic.palla...@st.com Signed-off-by: Omar Ramirez Luna

[PATCHv3 04/14] mailbox: split internal header from API header

2013-03-12 Thread Suman Anna
From: Omar Ramirez Luna omar.l...@linaro.org Now internal structures can remain hidden to the user and just API related functions and defines are made available. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org Signed-off-by: Linus Walleij linus.wall...@linaro.org ---

[PATCHv3 11/14] mailbox: create dbx500 mailbox driver

2013-03-12 Thread Suman Anna
From: Loic Pallardy loic.palla...@st.com Add STEriccson DBX500 PRCM mailbox support. Signed-off-by: Loic Pallardy loic.palla...@st.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- .../devicetree/bindings/mailbox/dbx500-mailbox.txt | 27 + drivers/mailbox/Kconfig

[PATCHv3 12/14] mailbox/omap: check iomem resource before dereferencing it

2013-03-12 Thread Suman Anna
Add a NULL check for iomem resource in mailbox probe functions. Signed-off-by: Fernando Guzman Lugo lugo.ferna...@gmail.com Signed-off-by: Suman Anna s-a...@ti.com --- drivers/mailbox/mailbox-omap1.c | 3 +++ drivers/mailbox/mailbox-omap2.c | 5 + 2 files changed, 8 insertions(+) diff --git

[PATCHv3 14/14] mailbox: call request_irq after mbox queues are allocated

2013-03-12 Thread Suman Anna
-by: Fernando Guzman Lugo lugo.ferna...@gmail.com Signed-off-by: Suman Anna s-a...@ti.com --- drivers/mailbox/mailbox.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index c38241a..5fea5c2 100644

[PATCHv3 10/14] mailbox: add no_irq send message

2013-03-12 Thread Suman Anna
From: Loic Pallardy loic.palla...@st.com For debug purpose, mailbox must be available when interrupts are disabled to collect dump information. Signed-off-by: Loic Pallardy loic.palla...@st.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/mailbox/mailbox.c | 66

[PATCHv3 08/14] mailbox: add shared memory mailbox type

2013-03-12 Thread Suman Anna
From: Loic Pallardy loic.palla...@st.com Some mailboxes are made up of cross interrupts and associated shared memory. Shared memory mapping is fixed and cross interrupt/shared memory relation make impossible the use of virtio. Mailbox framework must be enough opened to support any kind of

[PATCHv3 00/14] drivers: mailbox: framework creation

2013-03-12 Thread Suman Anna
mechanisms mailbox: add shared memory mailbox type mailbox: add IRQF_NO_SUSPEND flag mailbox: add no_irq send message mailbox: create dbx500 mailbox driver Omar Ramirez Luna (2): mailbox: OMAP: introduce mailbox framework mailbox: split internal header from API header Suman Anna (5): mailbox

[PATCHv3 02/14] ARM: OMAP2+: mbox: remove dependencies with soc.h

2013-03-12 Thread Suman Anna
driver. This data is now represented in a concise format and moved to the respective omap_hwmod data files and published to the driver through the platform data. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/devices.c | 9 +- arch/arm/mach-omap2/mailbox.c

[PATCH] remoteproc: fix the error check for idr_alloc

2013-03-06 Thread Suman Anna
The new idr_alloc interface returns the allocated id back on success, so fix the error path to check for negative values. This was missed out in the newer idr interface adoption patch, 15fc611 remoteproc: convert to idr_alloc(). Signed-off-by: Suman Anna s-a...@ti.com Cc: Tejun Heo t

[PATCH v2 13/13] mailbox: call request_irq after mbox queues are allocated

2013-02-11 Thread Suman Anna
-by: Fernando Guzman Lugo lugo.ferna...@gmail.com Signed-off-by: Suman Anna s-a...@ti.com --- drivers/mailbox/mailbox.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index c38241a..5fea5c2 100644

[PATCH v2 09/13] mailbox: add no_irq send message

2013-02-11 Thread Suman Anna
From: Loic Pallardy loic.palla...@st.com For debug purpose, mailbox must be available when interrupts are disabled to collect dump information. Signed-off-by: Loic Pallardy loic.palla...@st.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/mailbox/mailbox.c | 66

[PATCH v2 12/13] mailbox: check for NULL nb in mailbox_put

2013-02-11 Thread Suman Anna
The mailbox_put function must check the notifier block for NULL before trying to unregister it. Signed-off-by: Fernando Guzman Lugo lugo.ferna...@gmail.com Signed-off-by: Suman Anna s-a...@ti.com --- drivers/mailbox/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v2 05/13] mailbox: create opened message type

2013-02-11 Thread Suman Anna
and tidspbridge drivers. Signed-off-by: Loic Pallardy loic.palla...@st.com Signed-off-by: Omar Ramirez Luna omar.rami...@copitl.com Signed-off-by: Suman Anna s-a...@ti.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/mailbox/Kconfig | 9 drivers/mailbox

[PATCH v2 01/13] ARM: OMAP2+: mbox: remove dependencies with soc.h

2013-02-11 Thread Suman Anna
driver. This data is now represented in a concise format and moved to the respective omap_hwmod data files and published to the driver through the platform data. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/devices.c | 13 +- arch/arm/mach-omap2/mailbox.c

[PATCH v2 03/13] mailbox: split internal header from API header

2013-02-11 Thread Suman Anna
From: Omar Ramirez Luna omar.l...@linaro.org Now internal structures can remain hidden to the user and just API related functions and defines are made available. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org Signed-off-by: Linus Walleij linus.wall...@linaro.org ---

[PATCH v2 04/13] mailbox: rename omap_mbox in mailbox

2013-02-11 Thread Suman Anna
From: Loic Pallardy loic.palla...@st.com In order to create a generic mailbox framework, functions and structures should be renamed in mailbox. Taking care of remoteproc and tidspbridge while at it. Signed-off-by: Loic Pallardy loic.palla...@st.com Signed-off-by: Omar Ramirez Luna

[PATCH v2 08/13] mailbox: add IRQF_NO_SUSPEND flag

2013-02-11 Thread Suman Anna
From: Loic Pallardy loic.palla...@st.com Coprocessor must be accessible during suspend transitions. Signed-off-by: Loic Pallardy loic.palla...@st.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/mailbox/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH v2 10/13] mailbox: create dbx500 mailbox driver

2013-02-11 Thread Suman Anna
From: Loic Pallardy loic.palla...@st.com Add STEriccson DBX500 PRCM mailbox support. Signed-off-by: Loic Pallardy loic.palla...@st.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/mailbox/Kconfig | 7 + drivers/mailbox/Makefile |

[PATCH v2 11/13] mailbox/omap: check iomem resource before dereferencing it

2013-02-11 Thread Suman Anna
Add a NULL check for iomem resource in mailbox probe functions. Signed-off-by: Fernando Guzman Lugo lugo.ferna...@gmail.com Signed-off-by: Suman Anna s-a...@ti.com --- drivers/mailbox/mailbox-omap1.c | 3 +++ drivers/mailbox/mailbox-omap2.c | 5 + 2 files changed, 8 insertions(+) diff --git

[PATCH v2 00/13] drivers: mailbox: framework creation

2013-02-11 Thread Suman Anna
header from API header Suman Anna (4): ARM: OMAP2+: mbox: remove dependencies with soc.h mailbox/omap: check iomem resource before dereferencing it mailbox: check for NULL nb in mailbox_put mailbox: call request_irq after mbox queues are allocated arch/arm/configs/omap1_defconfig

[PATCH v2 06/13] mailbox: change protection mechanisms

2013-02-11 Thread Suman Anna
From: Loic Pallardy loic.palla...@st.com TX: replace spin by mutex to release CPU during wait on mailbox resource. Signed-off-by: Loic Pallardy loic.palla...@st.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/mailbox/mailbox.c | 5 +++--

[PATCH v2 07/13] mailbox: add shared memory mailbox type

2013-02-11 Thread Suman Anna
From: Loic Pallardy loic.palla...@st.com Some mailboxes are made up of cross interrupts and associated shared memory. Shared memory mapping is fixed and cross interrupt/shared memory relation make impossible the use of virtio. Mailbox framework must be enough opened to support any kind of

Re: [PATCH] mailbox: remove unnecessary platform_set_drvdata()

2013-08-23 Thread Suman Anna
. Signed-off-by: Jingoo Han jg1@samsung.com Acked-by: Suman Anna s-a...@ti.com --- drivers/mailbox/mailbox-omap2.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mailbox/mailbox-omap2.c b/drivers/mailbox/mailbox-omap2.c index eba380d..42d2b89 100644 --- a/drivers/mailbox

Re: linux-next: manual merge of the arm-soc tree with the mailbox tree

2013-06-21 Thread Suman Anna
. The branch that Arnd took has some of the OMAP patches reworked in preparation for the newer one. I already rebuilt the arm-soc tree before Stephen started with today's linux-next, so I think the conflict is elsewhere. It's probably best if Suman Anna rebases the mailbox tree on top

Re: [PATCH] iommu/omap: Remove casting the return value which is a void pointer

2013-09-12 Thread Suman Anna
On 09/09/2013 12:39 AM, Jingoo Han wrote: Casting the return value which is a void pointer is redundant. The conversion from void pointer to any other pointer type is guaranteed by the C programming language. Signed-off-by: Jingoo Han jg1@samsung.com Thanks, LGTM. ---

Re: [PATCHv2 2/9] hwspinlock/omap: add support for dt nodes

2013-10-02 Thread Suman Anna
Hi Mark, On Fri, Sep 27, 2013 at 05:06:38PM +0100, Kumar Gala wrote: On Sep 17, 2013, at 2:30 PM, Suman Anna wrote: HwSpinlock IP is present only on OMAP4 and other newer SoCs, which are all device-tree boot only. This patch adds the base support for parsing the DT nodes, and removes

Re: [PATCHv2 1/9] hwspinlock/core: add common dt bindings and OF helpers

2013-10-02 Thread Suman Anna
, at 2:30 PM, Suman Anna wrote: All the platform-specific hwlock driver implementations need the number of locks and the associated base id for registering the locks present within a hwspinlock device with the driver core. These two variables are represented by 'hwlock-num-locks' and 'hwlock

Re: [PATCH 1/2] hwspinlock/omap: add support for dt nodes

2013-10-03 Thread Suman Anna
Tony, On 10/03/2013 01:05 PM, Tony Lindgren wrote: * Suman Anna s-a...@ti.com [130903 11:00]: HwSpinlock IP is present only on OMAP4 and other newer SoCs, which are all device-tree boot only. This patch adds the base support for parsing the DT nodes, and removes the code dealing

[PATCHv2 0/9] omap hwspinlock dt support

2013-09-17 Thread Suman Anna
(Patch 3) v1: - Add DT parse support to OMAP hwspinlock driver - Add OMAP4 DT node and bindings information http://marc.info/?l=linux-omapm=137823082308009w=2 [1] https://lkml.org/lkml/2013/8/14/528 [2] http://marc.info/?t=13782309035r=1w=2 Suman Anna (9): hwspinlock/core: add common dt

[PATCHv2 1/9] hwspinlock/core: add common dt bindings and OF helpers

2013-09-17 Thread Suman Anna
. The documentation and OF helpers to retrieve these common properties have been added to the driver core. Signed-off-by: Suman Anna s-a...@ti.com --- .../devicetree/bindings/hwlock/hwlock.txt | 26 + drivers/hwspinlock/hwspinlock_core.c | 61 +- include/linux

[PATCHv2 3/9] ARM: dts: OMAP4: Add hwspinlock node

2013-09-17 Thread Suman Anna
Add the hwspinlock device tree node for OMAP4 family of SoCs. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap4.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index 22d9f2b..a8cc274 100644 --- a/arch

[PATCHv2 7/9] hwspinlock/omap: enable module before reading SYSSTATUS register

2013-09-17 Thread Suman Anna
controlled, and it is disabled out of reset. Make sure the module is enabled and clocked before reading the SYSSTATUS register. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/hwspinlock/omap_hwspinlock.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCHv2 6/9] hwspinlock/omap: support AM33xx

2013-09-17 Thread Suman Anna
AM33XX device family also supports hwspinlocks. The IP is identical to that of OMAP4/OMAP5, except for the number of locks. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/hwspinlock/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwspinlock/Kconfig b

[PATCHv2 4/9] ARM: OMAP5: hwmod data: Add spinlock data

2013-09-17 Thread Suman Anna
Add the hwmod data for the spinlock IP in OMAP5 SoC. This is needed to be able to enable the OMAP spinlock support for OMAP5. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 44 ++ 1 file changed, 44 insertions(+) diff --git

[PATCHv2 2/9] hwspinlock/omap: add support for dt nodes

2013-09-17 Thread Suman Anna
HwSpinlock IP is present only on OMAP4 and other newer SoCs, which are all device-tree boot only. This patch adds the base support for parsing the DT nodes, and removes the code dealing with the traditional platform device instantiation. Signed-off-by: Suman Anna s-a...@ti.com --- .../devicetree

[PATCHv2 9/9] ARM: AM33xx: hwmod_data: add the sysc configuration for spinlock

2013-09-17 Thread Suman Anna
Add the missing sysc configuration to the AM335 spinlock hwmod data. This ensures that smart-idle is enabled whenever the module is enabled by the driver. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 13 + 1 file changed, 13 insertions

[PATCHv2 5/9] ARM: dts: OMAP5: Add hwspinlock node

2013-09-17 Thread Suman Anna
Add the hwspinlock device tree node for OMAP5 SoCs. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap5.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index 07be2cd..449be92 100644 --- a/arch/arm/boot/dts

[PATCHv2 8/9] ARM: dts: AM33XX: Add hwspinlock node

2013-09-17 Thread Suman Anna
Add the hwspinlock device tree node for AM33xx family of SoCs. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/am33xx.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index f9c5da9..4371257 100644

Re: [patch] mailbox/omap: make mbox-irq signed for error handling

2013-11-11 Thread Suman Anna
On 11/07/2013 01:49 AM, Dan Carpenter wrote: There is a bug in omap2_mbox_probe() where we try do: mbox-irq = platform_get_irq(pdev, info-irq_id); if (mbox-irq 0) { The problem is that mbox-irq is unsigned so the error handling doesn't work. I've changed it

Re: [PATCHv4 0/7] omap hwspinlock dt support

2014-03-14 Thread Suman Anna
Hi Ohad, On 03/14/2014 03:10 PM, Ohad Ben-Cohen wrote: Hi Suman, Mark, On Mon, Feb 24, 2014 at 8:14 PM, Suman Anna s-a...@ti.com wrote: Mark, Ohad, ... Gentle reminder, can you provide your acks/comments? Sorry for the late jump in. I have a few comments: Thanks for the comments

Re: [RFC 4/5] clocksource: omap-timer: Introduce clocksource driver for OMAP SoCs

2014-03-14 Thread Suman Anna
Hi Joel, On 03/13/2014 03:35 PM, Joel Fernandes wrote: We introduce functions to initialize clocksource and clockevent, use CLOCKSOURCE_OF_DECLARE to declare the clocksource, and handle the clocksource selection on a per-SoC basis (Currently only AM335x is supported). Powering up of the timer

Re: [PATCHv4 0/7] omap hwspinlock dt support

2014-03-17 Thread Suman Anna
Hi Ohad, On 03/17/2014 09:23 AM, Ohad Ben-Cohen wrote: Hi Suman, On Sat, Mar 15, 2014 at 1:58 AM, Suman Anna s-a...@ti.com wrote: The series doesn't change the semantics of hwspinlock registration or adds a new OF controller registration function. Implementations would still need to register

Re: [PATCHv4 0/7] omap hwspinlock dt support

2014-03-17 Thread Suman Anna
Hi Ohad, On 03/17/2014 02:47 PM, Ohad Ben-Cohen wrote: Hi Suman, On Mon, Mar 17, 2014 at 9:10 PM, Suman Anna s-a...@ti.com wrote: base_id would be a property (if added) of the hwspinlock controller node, and from DT perspective, we will be using the phandle for the controller anyway. So

Re: [PATCHv4 0/7] omap hwspinlock dt support

2014-02-24 Thread Suman Anna
Mark, Ohad, On 02/10/2014 01:27 PM, Suman Anna wrote: Mark, On 01/13/2014 06:19 PM, Suman Anna wrote: Hi, This is an updated series mainly addressing Mark Rutland's comments about hwlock specifier being always one-cell. The series adds the support for #hwlock-cells property and adds a simple

Re: [PATCHv4 4/7] hwspinlock/core: add common OF helpers

2014-03-03 Thread Suman Anna
Ohad, On 03/02/2014 02:19 PM, Bjorn Andersson wrote: On Sat, Mar 1, 2014 at 9:14 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Mon, Feb 10, 2014 at 9:14 PM, Suman Anna s-a...@ti.com wrote: On 02/07/2014 04:49 PM, Bjorn Andersson wrote: It seems to be standard practice to pass the error value

Re: [PATCHv4 4/7] hwspinlock/core: add common OF helpers

2014-03-04 Thread Suman Anna
Hi Ohad, On 03/02/2014 02:19 PM, Bjorn Andersson wrote: On Sat, Mar 1, 2014 at 9:14 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Mon, Feb 10, 2014 at 9:14 PM, Suman Anna s-a...@ti.com wrote: On 02/07/2014 04:49 PM, Bjorn Andersson wrote: It seems to be standard practice to pass the error

[PATCHv4 1/7] Documentation: dt: add common bindings for hwspinlock

2014-01-13 Thread Suman Anna
the '#hwlock-cells' property. Note that the document is named hwlock.txt deliberately to keep it a bit more generic. Cc: Rob Herring robh...@kernel.org Signed-off-by: Suman Anna s-a...@ti.com --- .../devicetree/bindings/hwlock/hwlock.txt | 52 ++ 1 file changed, 52

[PATCHv4 3/7] hwspinlock/core: maintain a list of registered hwspinlock banks

2014-01-13 Thread Suman Anna
and a specific lock belonging to the device requested through a phandle + args approach. Signed-off-by: Suman Anna s-a...@ti.com --- Documentation/hwspinlock.txt | 2 ++ drivers/hwspinlock/hwspinlock_core.c | 51 drivers/hwspinlock/hwspinlock_internal.h | 2

[PATCHv4 0/7] omap hwspinlock dt support

2014-01-13 Thread Suman Anna
hwspinlock driver - Add OMAP4 DT node and bindings information http://marc.info/?l=linux-omapm=137823082308009w=2 Suman Anna (7): Documentation: dt: add common bindings for hwspinlock Documentation: dt: add the omap hwspinlock bindings document hwspinlock/core: maintain a list of registered

[PATCHv4 7/7] hwspinlock/omap: enable build for AM33xx, AM43xx DRA7xx

2014-01-13 Thread Suman Anna
. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/hwspinlock/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig index 70637d2..3612cb5 100644 --- a/drivers/hwspinlock/Kconfig +++ b/drivers/hwspinlock/Kconfig @@ -10,7

[PATCHv4 6/7] hwspinlock/omap: enable module before reading SYSSTATUS register

2014-01-13 Thread Suman Anna
controlled, and it is disabled out of reset. Make sure the module is enabled and clocked before reading the SYSSTATUS register. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/hwspinlock/omap_hwspinlock.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCHv4 4/7] hwspinlock/core: add common OF helpers

2014-01-13 Thread Suman Anna
the phandle + args specifier. This function relies on the implementation providing back a relative hwlock id within the bank from the args specifier. Signed-off-by: Suman Anna s-a...@ti.com --- Documentation/hwspinlock.txt | 34 +- drivers/hwspinlock/hwspinlock_core.c

[PATCHv4 5/7] hwspinlock/omap: add support for dt nodes

2014-01-13 Thread Suman Anna
HwSpinlock IP is present only on OMAP4 and other newer SoCs, which are all device-tree boot only. This patch adds the base support for parsing the DT nodes, and removes the code dealing with the traditional platform device instantiation. Signed-off-by: Suman Anna s-a...@ti.com [t...@atomide.com

[PATCHv4 2/7] Documentation: dt: add the omap hwspinlock bindings document

2014-01-13 Thread Suman Anna
HwSpinlock IP is present only on OMAP4 and other newer SoCs, which are all device-tree boot only. This patch adds the DT bindings information for OMAP hwspinlock module. Cc: Rob Herring robh...@kernel.org Signed-off-by: Suman Anna s-a...@ti.com --- .../devicetree/bindings/hwlock/omap

Re: [PATCHv4 4/7] hwspinlock/core: add common OF helpers

2014-02-10 Thread Suman Anna
Bjorn, On 02/07/2014 04:49 PM, Bjorn Andersson wrote: On Mon, Jan 13, 2014 at 4:19 PM, Suman Anna s-a...@ti.com wrote: This patch adds three new OF helper functions to use/request locks from a hwspinlock device instantiated through a device-tree blob. Nice, I ran in to the problem of needing

Re: [PATCHv4 0/7] omap hwspinlock dt support

2014-02-10 Thread Suman Anna
Mark, On 01/13/2014 06:19 PM, Suman Anna wrote: Hi, This is an updated series mainly addressing Mark Rutland's comments about hwlock specifier being always one-cell. The series adds the support for #hwlock-cells property and adds a simple default OF translate function. The DTS patches from

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-06 Thread Suman Anna
Hi Jassi, On 05/04/2013 02:08 PM, Jassi Brar wrote: Hi Suman, Anyway, here is a summary of the open points that we have: 1. Atomic Callbacks: The current code provides some sort of buffering on Tx, but imposes the restriction that the clients do the buffering on Rx. This is main concern

Re: [PATCHv2 0/4] mailbox: Common API

2013-05-06 Thread Suman Anna
Hi Jassi, On 05/06/2013 02:22 AM, Jassi Brar wrote: Hello, I have made the implementation look more proper. Also made some changes suggested by Suman. Changes since V1: * Delete timer upon mailbox release * Filled in the stub ipc_links_unregister() * Check kzalloc return for errors. *

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-07 Thread Suman Anna
Hi Jassi, On 7 May 2013 05:15, Suman Anna s-a...@ti.com wrote: The client(s) can always generate TX requests at a rate greater than the API could transmit on the physical link. So as much as we dislike it, we have to buffer TX requests, otherwise N clients would. The current code doesn't

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-08 Thread Suman Anna
Hi Jassi, The client(s) can always generate TX requests at a rate greater than the API could transmit on the physical link. So as much as we dislike it, we have to buffer TX requests, otherwise N clients would. The current code doesn't support N clients today anyway, and if they are

Re: [PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-09 Thread Suman Anna
Hi Jassi, On 05/06/2013 02:24 AM, Jassi Brar wrote: +++ b/include/linux/mailbox_client.h @@ -0,0 +1,85 @@ +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software

Re: [PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-09 Thread Suman Anna
On 05/09/2013 11:41 AM, Jassi Brar wrote: On 9 May 2013 22:01, Suman Anna s-a...@ti.com wrote: Hi Jassi, On 05/06/2013 02:24 AM, Jassi Brar wrote: +++ b/include/linux/mailbox_client.h @@ -0,0 +1,85 @@ +/* + * This program is free software; you can redistribute it and/or modify

Re: [PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-09 Thread Suman Anna
Jassi, On 05/09/2013 12:48 PM, Jassi Brar wrote: On Thu, May 9, 2013 at 10:10 PM, Suman Anna s-a...@ti.com wrote: On 05/09/2013 11:41 AM, Jassi Brar wrote: On 9 May 2013 22:01, Suman Anna s-a...@ti.com wrote: Hi Jassi, On 05/06/2013 02:24 AM, Jassi Brar wrote: +++ b/include/linux

Re: [PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-09 Thread Suman Anna
Jassi, Perhaps we should change the following void ipc_link_txdone(struct ipc_link *link, enum xfer_result r) to void ipc_link_txdone(struct ipc_link *link, enum xfer_result r, void *data) So that the API could pass that onto clients ? That's if the controller needs to pass some

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-09 Thread Suman Anna
Hi Jassi, On 9 May 2013 06:55, Suman Anna s-a...@ti.com wrote: so it can't be driven by the controller. We could make it a Kconfig option. What do you suggest? I am saying controller/link because they are the ones that knows how the physical transport is, and it may vary from one

Re: [PATCHv3 00/14] drivers: mailbox: framework creation

2013-04-29 Thread Suman Anna
Hi Andy, On 04/26/2013 08:48 PM, Andy Green wrote: On 27/04/13 09:04, the mail apparently from Suman Anna included: Hi Suman - Even though both the scenarios look very similar, I believe there are some slight differences. All the devices belonging to a controller may not be of the same

Re: [PATCHv3 00/14] drivers: mailbox: framework creation

2013-04-29 Thread Suman Anna
Hi Jassi, On 04/26/2013 11:51 PM, Jassi Brar wrote: Hi Suman, On 26 April 2013 03:59, Suman Anna s-a...@ti.com wrote: On 04/25/2013 12:20 AM, Jassi Brar wrote: I never said no-buffering and I never said buffering should be in controller drivers. In fact I don't remember ever objecting

Re: [RFC 3/3] mailbox: pl320: Introduce common API driver

2013-04-29 Thread Suman Anna
On 04/27/2013 01:14 PM, jassisinghb...@gmail.com wrote: From: Jassi Brar jaswinder.si...@linaro.org Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work with thee API. Drop the obsoleted driver pl320-ipc.c I

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-03 Thread Suman Anna
Hi Jassi, On 04/27/2013 01:14 PM, jassisinghb...@gmail.com wrote: From: Jassi Brar jaswinder.si...@linaro.org Introduce common framework for client/protocol drivers and controller drivers of Inter-Processor-Communication (IPC). Client driver developers should have a look at

[PATCH 0/3] minor cleanup fixes in remoteproc

2013-05-31 Thread Suman Anna
Hi Ohad, These are minor cleanup patches in remoteproc code for v3.10, they are fairly independent of each other. Suman Anna (3): remoteproc: fix checkpatch errors in remoteproc code remoteproc/omap: fix a sparse warning remoteproc: free carveout memories only after unmapping them

[PATCH 1/3] remoteproc: fix checkpatch errors in remoteproc code

2013-05-31 Thread Suman Anna
This patch fixes all the existing checkpatch errors and warnings in the remoteproc source files. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/remoteproc/remoteproc_core.c | 6 -- drivers/remoteproc/remoteproc_debugfs.c | 3 +-- drivers/remoteproc/remoteproc_internal.h | 4 ++-- 3

[PATCH 3/3] remoteproc: free carveout memories only after unmapping them

2013-05-31 Thread Suman Anna
are already stopped when the cleanup function is called, but this will make the cleanup code follow the exact reverse path of allocation. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/remoteproc/remoteproc_core.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 2/3] remoteproc/omap: fix a sparse warning

2013-05-31 Thread Suman Anna
This patch fixes a sparse warning in the omap remoteproc code when OMAP_REMOTEPROC is disabled. include/linux/platform_data/remoteproc-omap.h:76:13: warning: symbol 'omap_rproc_reserve_cma' was not declared. Should it be static? Signed-off-by: Suman Anna s-a...@ti.com --- include/linux

Re: [PATCHv3 00/14] drivers: mailbox: framework creation

2013-04-24 Thread Suman Anna
Jassi, On 04/24/2013 03:56 AM, Jassi Brar wrote: Hi - On 24 April 2013 13:38, Loic PALLARDY loic.palla...@st.com wrote: Hi Jassi, On 04/24/2013 06:39 AM, Jassi Brar wrote: The non-atomic API falls flat should just a single client comes with very low latency requirements. In fact

Re: [PATCHv3 00/14] drivers: mailbox: framework creation

2013-04-25 Thread Suman Anna
Jassi, On 04/25/2013 12:20 AM, Jassi Brar wrote: On 25 April 2013 04:46, Suman Anna s-a...@ti.com wrote: On 04/24/2013 03:56 AM, Jassi Brar wrote: I think there are two things here - one is what the client needs to do upon sending/receiving a message, and the other is what the send API

Re: [PATCHv3 00/14] drivers: mailbox: framework creation

2013-04-26 Thread Suman Anna
Hi Jassi, On 04/25/2013 10:46 PM, Jassi Brar wrote: Hi Suman, On 26 April 2013 03:59, Suman Anna s-a...@ti.com wrote: On 04/25/2013 12:20 AM, Jassi Brar wrote: tranmitting right away. OK, I thought you didn't want buffering, if that is not the case, then the buffering should be within

Re: [PATCHv2 4/9] ARM: OMAP5: hwmod data: Add spinlock data

2013-10-09 Thread Suman Anna
On 10/09/2013 02:12 AM, Paul Walmsley wrote: On Tue, 17 Sep 2013, Suman Anna wrote: Add the hwmod data for the spinlock IP in OMAP5 SoC. This is needed to be able to enable the OMAP spinlock support for OMAP5. Signed-off-by: Suman Anna s-a...@ti.com Thanks, queued. You can omit

Re: [PATCHv2 2/9] hwspinlock/omap: add support for dt nodes

2013-10-10 Thread Suman Anna
Hi Mark, On Fri, Sep 27, 2013 at 05:06:38PM +0100, Kumar Gala wrote: On Sep 17, 2013, at 2:30 PM, Suman Anna wrote: HwSpinlock IP is present only on OMAP4 and other newer SoCs, which are all device-tree boot only. This patch adds the base support for parsing the DT nodes, and removes

[PATCHv3 7/8] ARM: dts: OMAP5: Add hwspinlock node

2013-10-10 Thread Suman Anna
Add the hwspinlock device tree node for OMAP5 SoCs. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap5.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index 86295d2..2a98a59 100644 --- a/arch/arm/boot/dts

[PATCHv3 4/8] hwspinlock/omap: enable module before reading SYSSTATUS register

2013-10-10 Thread Suman Anna
controlled, and it is disabled out of reset. Make sure the module is enabled and clocked before reading the SYSSTATUS register. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/hwspinlock/omap_hwspinlock.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCHv3 8/8] ARM: dts: AM33XX: Add hwspinlock node

2013-10-10 Thread Suman Anna
Add the hwspinlock device tree node for AM33xx family of SoCs. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/am33xx.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 8692490..49dfb86 100644

[PATCHv3 6/8] ARM: dts: OMAP4: Add hwspinlock node

2013-10-10 Thread Suman Anna
Add the hwspinlock device tree node for OMAP4 family of SoCs. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap4.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index 45708e1..74db751 100644 --- a/arch

[PATCHv3 2/8] hwspinlock/core: add common dt bindings and OF helpers

2013-10-10 Thread Suman Anna
, and to request a specific lock using the phandle + args specifier. The latter function is different from the existing non-DT function, in that the specifier is relative to the hwlock device instead of being a global lock id registered with the core. Signed-off-by: Suman Anna s-a...@ti.com

[PATCHv3 5/8] hwspinlock/omap: support AM33xx

2013-10-10 Thread Suman Anna
AM33XX device family also supports hwspinlocks. The IP is identical to that of OMAP4/OMAP5, except for the number of locks. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/hwspinlock/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwspinlock/Kconfig b

[PATCHv3 1/8] hwspinlock/core: maintain a list of registered hwspinlock banks

2013-10-10 Thread Suman Anna
and a specific lock belonging to the device requested through a phandle + args approach. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/hwspinlock/hwspinlock_core.c | 48 drivers/hwspinlock/hwspinlock_internal.h | 2 ++ 2 files changed, 50 insertions(+) diff --git

[PATCHv3 0/8] omap hwspinlock dt support

2013-10-10 Thread Suman Anna
to OMAP hwspinlock driver - Add OMAP4 DT node and bindings information http://marc.info/?l=linux-omapm=137823082308009w=2 [1] https://lkml.org/lkml/2013/8/14/528 [2] http://marc.info/?t=13782309035r=1w=2 Suman Anna (8): hwspinlock/core: maintain a list of registered hwspinlock banks

[PATCHv3 3/8] hwspinlock/omap: add support for dt nodes

2013-10-10 Thread Suman Anna
HwSpinlock IP is present only on OMAP4 and other newer SoCs, which are all device-tree boot only. This patch adds the base support for parsing the DT nodes, and removes the code dealing with the traditional platform device instantiation. Signed-off-by: Suman Anna s-a...@ti.com --- .../devicetree

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-10 Thread Suman Anna
Jassi, See how mailbox_startup() tries to balance mbox-ops-startup() and mailbox_fini() the mbox-ops-shutdown() That's very fragile and the cause of imbalance between rpm enable/disable, unless your clients are buggy. Yeah, it is kinda messed up in the existing code, the startup defined

[PATCH 0/2] omap hwspinlock dt support

2013-09-03 Thread Suman Anna
from the MSM HW Mutex driver support series in [1]). [1] https://lkml.org/lkml/2013/8/14/528 Suman Anna (2): hwspinlock/omap: add support for dt nodes ARM: dts: OMAP4: Add hwspinlock node .../devicetree/bindings/hwlock/omap-hwspinlock.txt | 28 ++ arch/arm/boot/dts/omap4.dtsi

[PATCH 2/2] ARM: dts: OMAP4: Add hwspinlock node

2013-09-03 Thread Suman Anna
Add the hwspinlock device tree node for OMAP4 family of SoCs. Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/boot/dts/omap4.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index 22d9f2b..a8cc274 100644 --- a/arch

[PATCH 1/2] hwspinlock/omap: add support for dt nodes

2013-09-03 Thread Suman Anna
HwSpinlock IP is present only on OMAP4 and other newer SoCs, which are all device-tree boot only. This patch adds the base support for parsing the DT nodes, and removes the code dealing with the traditional platform device instantiation. Signed-off-by: Suman Anna s-a...@ti.com --- .../devicetree

  1   2   3   4   5   6   7   >