Re: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

Hello Wenyou, On Tue, Jan 20, 2015 at 04:17:00PM +0800, Wenyou Yang wrote: diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index 691e6db..a1010f0 100644 --- a/arch/arm/mach-at91/pm.c +++ b/arch/arm/mach-at91/pm.c (...) static int at91_pm_enter(suspend_state_t state) {

Re: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

Hello Wenyou, On Tue, Jan 20, 2015 at 04:17:00PM +0800, Wenyou Yang wrote: diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index 691e6db..a1010f0 100644 --- a/arch/arm/mach-at91/pm.c +++ b/arch/arm/mach-at91/pm.c @@ -145,62 +145,51 @@ extern void at91_slow_clock(void

Re: [PATCH 08/12] pm: at91: rename file name: pm_slowclock.S --pm_suspend.S

Hello Wenyou, On Tue, Jan 20, 2015 at 04:17:01PM +0800, Wenyou Yang wrote: diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S new file mode 100644 index 000..420e730 --- /dev/null + /* Turn off the main oscillator */ + ldr tmp1, [pmc,

Re: [PATCH v2 02/12] pm: at91: Workaround DDRSDRC self-refresh bug with LPDDR1 memories.

Hello Nicolas and Peter, On Mon, Jan 26, 2015 at 05:04:25PM +0100, Nicolas Ferre wrote: Le 26/01/2015 16:58, Peter Rosin a écrit : Sylvain Rochet wrote: Hello Nicolas, On Mon, Jan 26, 2015 at 02:34:38PM +0100, Nicolas Ferre wrote: Le 26/01/2015 11:36, Sylvain Rochet a écrit : I

[PATCH v2 0/2] pm: at91: pm_slowclock: improve reliability of suspend/resume

Changes since v1: * I only splitted my patch in two Sylvain Rochet (2): pm: at91: pm_slowclock: fix suspend/resume hang up in timeouts pm: at91: pm_slowclock: remove clocks which are already stopped when entering slow clock mode arch/arm/mach-at91/pm.c | 12 arch

[PATCH v2 1/2] pm: at91: pm_slowclock: fix suspend/resume hang up in timeouts

a message or just panic. As a bonus, not decounting the timeout register in slow clock mode reduce cumulated suspend time and resume time from ~17ms to ~15ms. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- arch/arm/mach-at91/pm_slowclock.S | 33 - 1

[PATCH v2 2/2] pm: at91: pm_slowclock: remove clocks which are already stopped when entering slow clock mode

Assume USB PLL and PLL B are already stopped before entering sleep mode, print a warning if this isn't the case. Removed PLL B from slow clock code, all drivers are supposed to properly unprepare clocks. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- arch/arm/mach-at91/pm.c

Re: [PATCH v2 02/12] pm: at91: Workaround DDRSDRC self-refresh bug with LPDDR1 memories.

Hello Nicolas, On Mon, Jan 26, 2015 at 02:34:38PM +0100, Nicolas Ferre wrote: Le 26/01/2015 11:36, Sylvain Rochet a écrit : I think we should explain we are dealing with an errata here, this is not obvious at first sight, the patch summary may find its place here :-) True

Re: [PATCH] clockevents: don't suspend/resume if unused

-by: Alexandre Belloni alexandre.bell...@free-electrons.com Reported-by: Sylvain Rochet sylvain.roc...@finsecur.com Indeed, this is way better from what I did. + if (dev-suspend dev-mode != CLOCK_EVT_MODE_UNUSED) I wonder if we should use CLOCK_EVT_MODE_SHUTDOWN (or CLOCK_EVT_MODE_UNUSED

Re: [PATCH 1/2] drm: atmel-hlcdc: Add PM suspend/resume support

Hello Boris, On Tue, Feb 10, 2015 at 03:05:57PM +0100, Boris Brezillon wrote: On Tue, 10 Feb 2015 14:40:45 +0100 Sylvain Rochet sylvain.roc...@finsecur.com wrote: + +static SIMPLE_DEV_PM_OPS(atmel_hlcdc_dc_drm_pm_ops, + atmel_hlcdc_dc_drm_suspend, atmel_hlcdc_dc_drm_resume

[PATCHv2 1/2] drm: atmel-hlcdc: Add PM suspend/resume support

On suspend: switch off CRTC if not already suspended with runtime PM On resume: switch on CRTC if we were not already suspended from runtime PM while suspending. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 60

[PATCHv2 2/2] drm: atmel-hlcdc: Add pinctrl PM select sleep,default state in CRTC suspend/resume

Some LCD panels have back-powering issue when un-powered, allows users to use an alternate pinctrl sleep in order to clamp outputs to a wanted state at suspend. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com Acked-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/gpu

[PATCHv2 0/2] drm: atmel-hlcdc: PM support

: * (*crtc_funcs-disable)(crtc) replaced to crtc_funcs-disable(crtc) Sylvain Rochet (2): drm: atmel-hlcdc: Add PM suspend/resume support drm: atmel-hlcdc: Add pinctrl PM select sleep,default state in CRTC suspend/resume drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 3 ++ drivers/gpu/drm

Re: [PATCH 2/4] of: DT quirks infrastructure

Hello, On Thu, Feb 19, 2015 at 07:01:59PM +0100, Maxime Bizon wrote: On Thu, 2015-02-19 at 19:38 +0200, Pantelis Antoniou wrote: Having to boot and tweak the bootloader settings to select the correct dtb (even if it’s present on the flash medium) takes time and is error-prone.

Re: [PATCH v3 07/13] pm: at91: remove the config item CONFIG_AT91_SLOW_CLOCK

Hi, On Tue, Jan 27, 2015 at 11:07:42AM +0100, Alexandre Belloni wrote: Hi, On 27/01/2015 at 10:55:15 +0100, Sylvain Rochet wrote : Hello Wenyou, On Tue, Jan 27, 2015 at 01:57:27PM +0800, Wenyou Yang wrote: static void __init at91_pm_init(void) { -#ifdef

Re: [PATCH v3 08/13] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

Hello Wenyou, On Tue, Jan 27, 2015 at 01:58:20PM +0800, Wenyou Yang wrote: diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index 0377c0d..d967c31 100644 --- a/arch/arm/mach-at91/pm.c +++ b/arch/arm/mach-at91/pm.c @@ -71,7 +71,7 @@ static int at91_pm_begin(suspend_state_t

Re: [PATCH v3 07/13] pm: at91: remove the config item CONFIG_AT91_SLOW_CLOCK

Hello Wenyou, On Tue, Jan 27, 2015 at 01:57:27PM +0800, Wenyou Yang wrote: static void __init at91_pm_init(void) { -#ifdef CONFIG_AT91_SLOW_CLOCK at91_pm_sram_init(); -#endif pr_info(AT91: Power Management%s\n, (slow_clock ? (with slow clock mode) : )); Details, but

Re: [PATCH v4 00/13] AT91 pm cleanup for 3.20

the patches from Peter Rosin and Sylvain Rochet. Since verifying the USB clock and USB PLL disabling before suspending to memory, it aslo depends on the following patch serials from Sylvain: [PATCHv6 0/5] USB: gadget: atmel_usba_udc: Driver improvements [PATCHv7 0/6] USB: host

Re: [PATCH v4 00/13] AT91 pm cleanup for 3.20

Hello Wenyou, On Wed, Jan 28, 2015 at 09:59:13AM +0100, Sylvain Rochet wrote: Hello Wenyou, On Wed, Jan 28, 2015 at 09:39:32AM +0800, Wenyou Yang wrote: Hi Nicolas, This version is rebased on the branch: at91-3.20-cleanup of the repository git://git.kernel.org/pub/scm/linux

Re: [PATCH v2 00/12] AT91 pm cleanup for 3.20

the patches from Peter Rosin and Sylvain Rochet. Since verifying the USB clock and USB PLL disabling before suspending to memory, it aslo depends on the following patch serials from Sylvain: [PATCHv6 0/5] USB: gadget: atmel_usba_udc: Driver improvements [PATCHv7 0/6] USB: host

Re: [PATCH v2 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

Hello Wenyou, On Mon, Jan 26, 2015 at 05:42:11PM +0800, Wenyou Yang wrote: +static int at91_pm_verify_clocks(suspend_state_t state) { unsigned long scsr; int i; + /* For PM_SUSPEND_STANDBY, skip verifying the clock */ + if (state == PM_SUSPEND_STANDBY) +

Re: [PATCH 08/12] pm: at91: rename file name: pm_slowclock.S --pm_suspend.S

Hello Alexandre, On Sat, Jan 24, 2015 at 12:17:38AM +0100, Alexandre Belloni wrote: This is a rework, what is part of linux-3.10-at91 and not yet present in mainline should be part of a following series. I would prefer not mixing reworks and new functionalities (they have been present in

Re: [PATCH v2 02/12] pm: at91: Workaround DDRSDRC self-refresh bug with LPDDR1 memories.

Hello Wenyou, On Mon, Jan 26, 2015 at 05:38:59PM +0800, Wenyou Yang wrote: From: Peter Rosin p...@axentia.se The DDRSDR controller fails miserably to put LPDDR1 memories in self-refresh. Force the controller to think it has DDR2 memories during the self-refresh period, as the DDR2

Re: [PATCH v2] drm: atmel-hlcdc: Atomic mode-setting conversion

to fix. Apart from that, it works perfectly, you can add my: Tested-by: Sylvain Rochet sylvain.roc...@finsecur.com [ cut here ] WARNING: CPU: 0 PID: 9 at drivers/clk/clk.c:992 clk_disable+0x28/0x34() Modules linked in: CPU: 0 PID: 9 Comm: kworker/0:1 Not tainted 3.19.0

[PATCH 0/2] drm: atmel-hlcdc: PM support

This series depends on Boris' [PATCH v2] drm: atmel-hlcdc: Atomic mode-setting conversion 1423236143-6494-1-git-send-email-boris.brezil...@free-electrons.com plus a few fixes which are going to be in v3 of Boris' patch. This series adds basic PM support for Atmel HLCDC. Sylvain Rochet (2

[PATCH 2/2] drm: atmel-hlcdc: Add pinctrl PM select sleep,default state in CRTC suspend/resume

Some LCD panels have back-powering issue when un-powered, allows users to use an alternate pinctrl sleep in order to clamp outputs to a wanted state at suspend. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 3 +++ 1 file changed, 3

[PATCH 1/2] drm: atmel-hlcdc: Add PM suspend/resume support

On suspend: switch off CRTC if not already suspended with runtime PM On resume: switch on CRTC if we were not already suspended from runtime PM while suspending. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 60

Re: [PATCH] drm: atmel-hlcdc: remove useless pm_runtime_put_sync in probe

Hello Boris, On Fri, Feb 13, 2015 at 04:36:25PM +0100, Boris Brezillon wrote: Remove a useless pm_runtime_put_sync leading to unbalanced usage_count. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Reported-by: Sylvain Rochet sylvain.roc...@finsecur.com --- Indeed

Re: [PATCH 3/3] ARM: at91: dt: at91sam9n12ek: enable udp

Hello Bo, On Mon, Feb 09, 2015 at 05:02:52PM +0800, Bo Shen wrote: Enable usb device port on at91sam9n12ek board. Signed-off-by: Bo Shen voice.s...@atmel.com --- arch/arm/boot/dts/at91sam9n12ek.dts | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH] net: phy: micrel: disable NAND-tree for KSZ8021,KSZ8031,KSZ8051,KSZ8081

the optional TM7000 display module, therefore they are switching the PHY in NAND-tree test mode depending on the current IRQ line status at reset. This patch ensure PHY is not in NAND-tree test mode for all Micrel PHYs using IRQ line as a NAND-tree toggle mode at reset. Signed-off-by: Sylvain Rochet

Re: PM: knowing the system state in the device callback

Hi, On Mon, Mar 16, 2015 at 08:52:45PM +0100, Boris Brezillon wrote: Hi Alexandre, On Mon, 16 Mar 2015 20:17:42 +0100 Alexandre Belloni alexandre.bell...@free-electrons.com wrote: Hi, I'm trying to get rid of at91_suspend_entering_slow_clock() which is exposing the platform

Re: [PATCH v2.0 1/2] pm: at91: add the PM initialization for the sama5d3 and sama5d4

Hello Wenyou, On Mon, Mar 09, 2015 at 11:57:08AM +0800, Wenyou Yang wrote: To get the mpddrc peripheral id from the PM initialization, which will be used to disable mpddrc'c clock during suspending. +void __init sam5d3_pm_init(void) +{ + at91_dt_ramc(); + at91_pm_data.uhp_udp_mask

Re: PM: knowing the system state in the device callback

Hi, On Tue, Mar 17, 2015 at 09:38:15AM +0100, Boris Brezillon wrote: On Mon, 16 Mar 2015 21:32:52 +0100 Sylvain Rochet sylvain.roc...@finsecur.com wrote: On Mon, Mar 16, 2015 at 08:52:45PM +0100, Boris Brezillon wrote: On Mon, 16 Mar 2015 20:17:42 +0100 Alexandre Belloni alexandre.bell

Re: [PATCH 2/6] pm: at91: move the copying the sram function to the sram initializationi phase

Hello Wenyou, On Thu, Feb 12, 2015 at 10:46:49AM +0800, Wenyou Yang wrote: To decrease the suspend time, move copying the sram function to the sram initialization phase, instead of every time go to suspend. In the meanwhile, substitute fncpy() for memcpy(). If there is no sram allocated

Re: [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND

Hello, On Sat, Mar 07, 2015 at 12:29:33PM +0100, Pavel Machek wrote: On Sat 2015-03-07 12:06:45, Alexandre Belloni wrote: On 07/03/2015 at 11:39:39 +0100, Pavel Machek wrote : The Atmel watchdog can't be stopped once it's started. This is actually very useful so we can reset if

Re: [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND

Hello, On Sat, Mar 07, 2015 at 10:18:46AM +0100, Peter Zijlstra wrote: On Thu, Mar 05, 2015 at 11:53:08AM +, Mark Rutland wrote: If everyone else is happy with this using IRQF_NO_SUSPEND for now then don't let my comments above block this patch. Yeah, I'm really not happy with

Re: [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND

Hello, On Sat, Mar 07, 2015 at 11:39:39AM +0100, Pavel Machek wrote: On Sat 2015-03-07 11:20:56, Sylvain Rochet wrote: Hello, On Sat, Mar 07, 2015 at 10:18:46AM +0100, Peter Zijlstra wrote: On Thu, Mar 05, 2015 at 11:53:08AM +, Mark Rutland wrote: If everyone else is happy

Re: [PATCH v2.0 0/6] ARM: AT91: pm improvement for 4.1

series: Tested-by: Sylvain Rochet sylvain.roc...@finsecur.com Sylvain -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 2/6] pm: at91: move the copying the sram function to the sram initializationi phase

Hello Wenyou, On Sat, Mar 07, 2015 at 12:22:24AM +0100, Sylvain Rochet wrote: Hello Wenyou, On Thu, Feb 12, 2015 at 10:46:49AM +0800, Wenyou Yang wrote: To decrease the suspend time, move copying the sram function to the sram initialization phase, instead of every time go to suspend

Re: [PATCH v2.0 0/2] ARM: AT91: pm: add support to disable the DDR's clock

Hello Wenyou, On Mon, Mar 09, 2015 at 11:56:18AM +0800, Wenyou Yang wrote: Hi, The patch series purpose is to disable the DDR controller's clock and DDR system clock during the suspending to achieve the lower power consumption. To the whole series: Tested-by: Sylvain Rochet sylvain.roc

Re: [PATCH v2.0 0/3] ARM: AT91: pm cleanup for 4.1

Hello Wenyou, On Mon, Mar 09, 2015 at 11:43:01AM +0800, Wenyou Yang wrote: Hi, The patch series purpose is to clean up the AT91 PM code. To the whole series: Tested-by: Sylvain Rochet sylvain.roc...@finsecur.com Sylvain -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH] drm: atmel-hlcdc: fixes wrong enabled flag used in PM suspend/resume support

Unfortunately we used the enabled flag in struct drm_crtc instead of the enabled flag in struct atmel_hlcdc_crtc. This obviously leads to discrepancies on crtc enable state. This patch fixes the issue by using the struct atmel_hlcdc_crtc enabled flag in PM support. Signed-off-by: Sylvain Rochet

Re: [PATCH v2.0 0/2] ARM: at91: Add pm support for sama5d3 and sama5d4

Hello Wenyou, On Mon, Mar 09, 2015 at 11:53:07AM +0800, Wenyou Yang wrote: Hi, The patch series purpose is to add pm support for sama5d3 and sama5d4. To the whole series: Tested-by: Sylvain Rochet sylvain.roc...@finsecur.com Sylvain -- To unsubscribe from this list: send the line

Re: [PATCH 2/3] pm: at91: pm_slowclock: remove clocks which are already stopped when entering slow clock mode

Hello Nicolas, On Tue, Mar 03, 2015 at 07:42:26PM +0100, Nicolas Ferre wrote: Le 05/02/2015 07:01, Wenyou Yang a écrit : From: Sylvain Rochet sylvain.roc...@finsecur.com Assume USB PLL and PLL B are already stopped before entering sleep mode, print a warning if this isn't the case

[PATCHv3 2/2] drm: atmel-hlcdc: Add pinctrl PM select sleep,default state in CRTC suspend/resume

Some LCD panels have back-powering issue when un-powered, allows users to use an alternate pinctrl sleep in order to clamp outputs to a wanted state at suspend. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com Acked-by: Boris Brezillon boris.brezil...@free-electrons.com --- drivers/gpu

[PATCHv3 1/2] drm: atmel-hlcdc: Add PM suspend/resume support

On suspend: switch off CRTC if not already suspended with runtime PM On resume: switch on CRTC if we were not already suspended from runtime PM while suspending. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 47

Re: [PATCHv2 1/2] drm: atmel-hlcdc: Add PM suspend/resume support

Hello Andrzej, On Tue, Feb 17, 2015 at 10:47:23AM +0100, Andrzej Hajda wrote: On 02/12/2015 09:49 PM, Sylvain Rochet wrote: +static int atmel_hlcdc_dc_resume(struct drm_device *dev) +{ + struct drm_crtc *crtc; + + drm_modeset_lock_all(dev); + + list_for_each_entry(crtc, dev

[PATCHv3 0/2] drm: atmel-hlcdc: PM support

to atmel_hlcdc_dc_drm_suspend and atmel_hlcdc_dc_resume to atmel_hlcdc_dc_drm_resume since we don't need the previous callbacks anymore * Removed useless check of drm_dev in suspend/resume functions Changes since v1: * (*crtc_funcs-disable)(crtc) replaced to crtc_funcs-disable(crtc) Sylvain Rochet (2): drm

[PATCH 1/2] ppp: mppe: sanity error path rework

We are going to need sanity error path a little further, rework to be able to use the sanity error path anywhere in decompressor. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- drivers/net/ppp/ppp_mppe.c | 29 + 1 file changed, 13 insertions(+), 16

[PATCH 2/2] ppp: mppe: discard late packet in stateless mode

a whole count space times (~ 4095 times), drop packets which are not within the forward 4096/2 window and increase sanity error counter. Signed-off-by: Sylvain Rochet sylvain.roc...@finsecur.com --- drivers/net/ppp/ppp_mppe.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net

[PATCH 0/2] ppp: mppe: fixes MPPE desync on links which don't guarantee packet ordering

missed packet 1561 and we already rekeyed 2 times for 1562 we previously received, we can't recover the decryption key we need for 1561, we should drop it instead of rekeying 4095 times. This patch series drop any packet with are not within the 4096/2 forward window. Sylvain Rochet (2): ppp: mppe

Re: [PATCH] clockevents: don't suspend/resume if unused

Hello Thomas, On Mon, May 25, 2015 at 08:48:06PM +0200, Thomas Gleixner wrote: On Fri, 16 Jan 2015, Alexandre Belloni wrote: There is no point in calling suspend/resume for unused clockevents as they are already stopped and disabled. Furthermore, it can take some time to wait for some

Re: [PATCH] clockevents: don't suspend/resume if unused

Hello Thomas, On Mon, May 25, 2015 at 10:11:15PM +0200, Thomas Gleixner wrote: That's a reasonable explanation. While timer IPs seem to be designed by janitors in general, this one has an extraordinary level of stupidity. Yes, that's quite a stupid design, however I wasn't totally right

Re: [RESEND PATCH] pinctrl: at91: fix null pointer dereference

Hello Ludovic, On Tue, Jul 28, 2015 at 03:12:53PM +0200, Ludovic Desroches wrote: On Tue, Jul 28, 2015 at 02:48:09PM +0200, Linus Walleij wrote: On Tue, Jul 28, 2015 at 9:48 AM, Ludovic Desroches ludovic.desroc...@atmel.com wrote: From: David Dueck davidcdu...@googlemail.com Not

Re: [RESEND PATCH] pinctrl: at91: fix null pointer dereference

Hello, On Thu, Jul 30, 2015 at 10:49:27AM +0200, Ludovic Desroches wrote: On Thu, Jul 30, 2015 at 10:33:43AM +0200, Sylvain Rochet wrote: Hello Ludovic, On Tue, Jul 28, 2015 at 03:12:53PM +0200, Ludovic Desroches wrote: On Tue, Jul 28, 2015 at 02:48:09PM +0200, Linus Walleij wrote

[PATCH] drm: atmel-hlcdc: fix vblank initial state

From: Boris Brezillon boris.brezil...@free-electrons.com drm_vblank_on() now warns on nested use or if vblank is not properly initialized. This patch fixes Atmel HLCDC vblank initial state. Signed-off-by: Boris Brezillon boris.brezil...@free-electrons.com Reported-by: Sylvain Rochet sylvain.roc

Atmel SoCs and the newly added CONFIG_DELAY_DEVICE_PROBES option

Hi, FYI, to save you a git bisect, the recently added CONFIG_DELAY_DEVICE_PROBES (enabled by default) breaks Atmel SoCs. For a few of quickly noticeable issues: - PM is not working: at91_pm_sram_init: sram pool unavailable! - Watchdog is not even probed - on -ek boards the wm8904 is not

Re: Atmel sama5d3 boot regression, today's linux-next

Hi, On Thu, Oct 15, 2015 at 04:14:49PM +0200, Alexandre Belloni wrote: > On 15/10/2015 at 15:30:16 +0200, Sylvain Rochet wrote : > > Hi, > > > > Atmel SAMA5D31 boards no longer boot on today's linux-next. Bisected to: > > > > commit 7d24068e144adc03b805806645d

Atmel sama5d3 boot regression, today's linux-next

Hi, Atmel SAMA5D31 boards no longer boot on today's linux-next. Bisected to: commit 7d24068e144adc03b805806645d732cf79488717 Author: Wonhong Kwon Date: Tue Oct 6 10:10:20 2015 +0900 PM / hibernate: Move pm_init/pm_disk_init to late_initcall_sync pm_init is

[PATCH 3/6] watchdog: at91sam9: rename heartbeats into timeout where necessary

hdog, reduce confusion by not telling those values are used right now while there are not. Signed-off-by: Sylvain Rochet <sylvain.roc...@finsecur.com> --- drivers/watchdog/at91sam9_wdt.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/watchdo

[PATCH 0/6] watchdog: sama5d4 and at91sam9: trivial rework

A little bit of trivial rework for both sama5d4 and at91sam9 drivers. Sylvain Rochet (6): watchdog: at91sam9: use devm_request_irq instead of request_irq watchdog: at91sam9: use watchdog_get_drvdata instead of container_of watchdog: at91sam9: rename heartbeats into timeout where necessary

[PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree first

watchdog_init_timeout function doesn't try to get the "timeout-sec" DT property if timeout_parm is not zero. This change makes this DT property working for the sama5d4 watchdog driver. Signed-off-by: Sylvain Rochet <sylvain.roc...@finsecur.com> --- drivers/watchdog/sama5d4_wdt.

[PATCH 2/6] watchdog: at91sam9: use watchdog_get_drvdata instead of container_of

Use watchdog_get_drvdata instead of container_of. Signed-off-by: Sylvain Rochet <sylvain.roc...@finsecur.com> --- drivers/watchdog/at91sam9_wdt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c

[PATCH 5/6] watchdog: at91sam9: remove unused pdata support

All SoC using this driver were converted to device tree. Remove pdata support and initialization steps which are only used for pdata. Signed-off-by: Sylvain Rochet <sylvain.roc...@finsecur.com> --- drivers/watchdog/at91sam9_wdt.c | 15 --- 1 file changed, 15 deletions(-) diff

[PATCH 4/6] watchdog: at91sam9: remove nowayout useless copy

nowayout is a global variable set by module parameter, remove the nowayout useless copy. Signed-off-by: Sylvain Rochet <sylvain.roc...@finsecur.com> --- drivers/watchdog/at91sam9_wdt.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/watchdog/at91sam9_w

[PATCH 1/6] watchdog: at91sam9: use devm_request_irq instead of request_irq

free_irq was missing in the module remove function, fix it by using devm_request_irq instead of request_irq. Signed-off-by: Sylvain Rochet <sylvain.roc...@finsecur.com> --- drivers/watchdog/at91sam9_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/wa

Re: [PATCH 3/6] watchdog: at91sam9: rename heartbeats into timeout where necessary

On Thu, Oct 08, 2015 at 11:34:31PM +0200, Sylvain Rochet wrote: > > @@ -344,7 +342,7 @@ static int __init at91wdt_probe(struct platform_device > *pdev) > wdt->wdd.parent = >dev; > wdt->wdd.info = _wdt_info; > wdt->wdd.ops = _wdt_ops; > -

Re: [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree first

Hi Alexandre, On Mon, Oct 12, 2015 at 09:50:01AM +0200, Alexandre Belloni wrote: > Hi Sylvain, > > The rest of the series looks good to me, one comment below: > > On 08/10/2015 at 23:34:34 +0200, Sylvain Rochet wrote : > > watchdog_init_timeout function doesn't try to get

Re: [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree first

Hi Wenyou, On Mon, Oct 12, 2015 at 08:12:42AM +, Yang, Wenyou wrote: > > -Original Message- > > From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com] > > Sent: 2015年10月12日 15:50 > > To: Sylvain Rochet > > Cc: Guenter Roeck; Boris BREZILLON

[PATCH] watchdog: at91sam9: keep watchdog running in idle mode

fault fixes this. Signed-off-by: Sylvain Rochet <sylvain.roc...@finsecur.com> Fixes: 5161b31dc39a ("watchdog: at91sam9_wdt: better watchdog support") Cc: <sta...@vger.kernel.org> # 3.14+ --- drivers/watchdog/at91sam9_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[PATCH] regmap: fix NULL pointer dereference in __regmap_init if bus is NULL

This fix adds a check for bus pointer before using bus struct members. Signed-off-by: Sylvain Rochet <sylvain.roc...@finsecur.com> --- drivers/base/regmap/regmap.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) It was introduced by https://git.kernel.org/cgit/linux/kernel/gi

Re: [PATCH] regmap: fix NULL pointer dereference in __regmap_init if bus is NULL

Hello, On Mon, Aug 31, 2015 at 07:17:09PM +0200, Sylvain Rochet wrote: > This fix adds a check for bus pointer before using bus struct members. I just found out I'm a little too late, Sergey sent the exact same patch a few hours ago, dammit :-) Sylvain -- To unsubscribe from this list: s

[PATCH linux-next] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding

. Signed-off-by: Sylvain Rochet <sylvain.roc...@finsecur.com> --- drivers/usb/gadget/udc/atmel_usba_udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 2cbbb46..c2ea5e1 100644 --- a/drive

Re: [PATCH v2] clocksource: atmel-pit: register as a sched_clock

Hi, On Wed, Feb 24, 2016 at 05:04:42PM +0100, Romain Izard wrote: > Register the counter of the Periodic Interval Timer as a possible source > for sched_clock. Keep the timer running even if the related clockevent > is disabled. > > This provides a better precision than the jiffies-based

Re: [PATCH] watchdog: at91sam9: keep watchdog running in idle mode

Hi, On Wed, Oct 07, 2015 at 01:01:12PM +0200, Alexandre Belloni wrote: > On 06/10/2015 at 22:28:45 +0200, Sylvain Rochet wrote : > > Since turning on idle-halt in commit 5161b31dc39a (watchdog: > > at91sam9_wdt: better watchdog support"), SoCs compatible with > >

Re: [PATCH] ARM: at91/dt: pullup dbgu rx instead of tx

Hi Peter, On Sun, Oct 16, 2016 at 12:57:09PM +0200, Peter Rosin wrote: > Hi again, > > I forgot about this, and it's been a year. But isn't it time to > upstream those pull-up fixes that Sylvain provided? Thank you for your reminder, actually I waited an answer on this nice subject:

Re: [PATCH] watchdog: at91sam9: keep watchdog running in idle mode

Hi Guenter, On Sun, Oct 16, 2016 at 08:55:41AM -0700, Guenter Roeck wrote: > On 10/16/2016 08:50 AM, Guenter Roeck wrote: > > On 10/16/2016 08:33 AM, Sylvain Rochet wrote: > > > > > > Looks like this one falls through the cracks, it didn't reach mainline > &g

[PATCH] drm: atmel-hlcdc: fixes wrong enabled flag used in PM suspend/resume support

Unfortunately we used the enabled flag in struct drm_crtc instead of the enabled flag in struct atmel_hlcdc_crtc. This obviously leads to discrepancies on crtc enable state. This patch fixes the issue by using the struct atmel_hlcdc_crtc enabled flag in PM support. Signed-off-by: Sylvain Rochet

Re: [PATCH 2/6] pm: at91: move the copying the sram function to the sram initializationi phase

Hello Wenyou, On Sat, Mar 07, 2015 at 12:22:24AM +0100, Sylvain Rochet wrote: > Hello Wenyou, > > On Thu, Feb 12, 2015 at 10:46:49AM +0800, Wenyou Yang wrote: > > To decrease the suspend time, move copying the sram function to the sram > > initialization phase, ins

Re: [PATCH v2.0 0/6] ARM: AT91: pm improvement for 4.1

to memory mode, To the whole series: Tested-by: Sylvain Rochet Sylvain -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2.0 0/2] ARM: at91: Add pm support for sama5d3 and sama5d4

Hello Wenyou, On Mon, Mar 09, 2015 at 11:53:07AM +0800, Wenyou Yang wrote: > Hi, > > The patch series purpose is to add pm support for sama5d3 and sama5d4. To the whole series: Tested-by: Sylvain Rochet Sylvain -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH v2.0 0/2] ARM: AT91: pm: add support to disable the DDR's clock

Hello Wenyou, On Mon, Mar 09, 2015 at 11:56:18AM +0800, Wenyou Yang wrote: > Hi, > > The patch series purpose is to disable the DDR controller's clock and DDR > system clock during the suspending to achieve the lower power consumption. To the whole series: Tested-by: Sylvain Roch

Re: [PATCH v2.0 0/3] ARM: AT91: pm cleanup for 4.1

Hello Wenyou, On Mon, Mar 09, 2015 at 11:43:01AM +0800, Wenyou Yang wrote: > Hi, > > The patch series purpose is to clean up the AT91 PM code. To the whole series: Tested-by: Sylvain Rochet Sylvain -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCH v2.0 1/2] pm: at91: add the PM initialization for the sama5d3 and sama5d4

Hello Wenyou, On Mon, Mar 09, 2015 at 11:57:08AM +0800, Wenyou Yang wrote: > To get the mpddrc peripheral id from the PM initialization, > which will be used to disable mpddrc'c clock during suspending. > +void __init sam5d3_pm_init(void) > +{ > + at91_dt_ramc(); > +

Re: PM: knowing the system state in the device callback

Hi, On Mon, Mar 16, 2015 at 08:52:45PM +0100, Boris Brezillon wrote: > Hi Alexandre, > > On Mon, 16 Mar 2015 20:17:42 +0100 > Alexandre Belloni wrote: > > > Hi, > > > > I'm trying to get rid of at91_suspend_entering_slow_clock() which is > > exposing the platform suspend_state_t to the

Re: PM: knowing the system state in the device callback

Hi, On Tue, Mar 17, 2015 at 09:38:15AM +0100, Boris Brezillon wrote: > On Mon, 16 Mar 2015 21:32:52 +0100 > Sylvain Rochet wrote: > > On Mon, Mar 16, 2015 at 08:52:45PM +0100, Boris Brezillon wrote: > > > On Mon, 16 Mar 2015 20:17:42 +0100 > > > Alexandre Bellon

Re: [PATCH] clockevents: don't suspend/resume if unused

Hello Thomas, On Mon, May 25, 2015 at 08:48:06PM +0200, Thomas Gleixner wrote: > On Fri, 16 Jan 2015, Alexandre Belloni wrote: > > > There is no point in calling suspend/resume for unused > > clockevents as they are already stopped and disabled. > > > > Furthermore, it can take some time to

Re: [PATCH] clockevents: don't suspend/resume if unused

Hello Thomas, On Mon, May 25, 2015 at 10:11:15PM +0200, Thomas Gleixner wrote: > > That's a reasonable explanation. > > While timer IPs seem to be designed by janitors in general, this one > has an extraordinary level of stupidity. Yes, that's quite a stupid design, however I wasn't totally

Re: [RESEND PATCH] pinctrl: at91: fix null pointer dereference

Hello Ludovic, On Tue, Jul 28, 2015 at 03:12:53PM +0200, Ludovic Desroches wrote: > On Tue, Jul 28, 2015 at 02:48:09PM +0200, Linus Walleij wrote: > > On Tue, Jul 28, 2015 at 9:48 AM, Ludovic Desroches > > wrote: > > > > > From: David Dueck > > > > > > Not all gpio banks are necessarily

Re: [RESEND PATCH] pinctrl: at91: fix null pointer dereference

Hello, On Thu, Jul 30, 2015 at 10:49:27AM +0200, Ludovic Desroches wrote: > On Thu, Jul 30, 2015 at 10:33:43AM +0200, Sylvain Rochet wrote: > > Hello Ludovic, > > > > On Tue, Jul 28, 2015 at 03:12:53PM +0200, Ludovic Desroches wrote: > > > On Tue, Jul 28, 2015 at 0

[PATCH] drm: atmel-hlcdc: fix vblank initial state

From: Boris Brezillon drm_vblank_on() now warns on nested use or if vblank is not properly initialized. This patch fixes Atmel HLCDC vblank initial state. Signed-off-by: Boris Brezillon Reported-by: Sylvain Rochet --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 1 + drivers/gpu/drm

[PATCH] regmap: fix NULL pointer dereference in __regmap_init if bus is NULL

This fix adds a check for bus pointer before using bus struct members. Signed-off-by: Sylvain Rochet --- drivers/base/regmap/regmap.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) It was introduced by https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id

Re: [PATCH] regmap: fix NULL pointer dereference in __regmap_init if bus is NULL

Hello, On Mon, Aug 31, 2015 at 07:17:09PM +0200, Sylvain Rochet wrote: > This fix adds a check for bus pointer before using bus struct members. I just found out I'm a little too late, Sergey sent the exact same patch a few hours ago, dammit :-) Sylvain -- To unsubscribe from this list: s

[PATCH linux-next] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding

. Signed-off-by: Sylvain Rochet --- drivers/usb/gadget/udc/atmel_usba_udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 2cbbb46..c2ea5e1 100644 --- a/drivers/usb/gadget/udc/atmel_usba_udc.c +++ b

Re: [PATCH v2 00/12] AT91 pm cleanup for 3.20

PM code, includes the patches from Peter Rosin > and Sylvain Rochet. > > Since verifying the USB clock and USB PLL disabling before suspending to > memory, > it aslo depends on the following patch serials from Sylvain: > [PATCHv6 0/5] USB: gadget: atmel_usba_udc: Driv

Re: [PATCH v2 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

Hello Wenyou, On Mon, Jan 26, 2015 at 05:42:11PM +0800, Wenyou Yang wrote: > +static int at91_pm_verify_clocks(suspend_state_t state) > { > unsigned long scsr; > int i; > > + /* For PM_SUSPEND_STANDBY, skip verifying the clock */ > + if (state == PM_SUSPEND_STANDBY) > +

Re: [PATCH v2 02/12] pm: at91: Workaround DDRSDRC self-refresh bug with LPDDR1 memories.

Hello Wenyou, On Mon, Jan 26, 2015 at 05:38:59PM +0800, Wenyou Yang wrote: > From: Peter Rosin > > The DDRSDR controller fails miserably to put LPDDR1 memories in > self-refresh. Force the controller to think it has DDR2 memories > during the self-refresh period, as the DDR2 self-refresh spec

Re: [PATCH v2 02/12] pm: at91: Workaround DDRSDRC self-refresh bug with LPDDR1 memories.

Hello Nicolas, On Mon, Jan 26, 2015 at 02:34:38PM +0100, Nicolas Ferre wrote: > Le 26/01/2015 11:36, Sylvain Rochet a écrit : > > > > I think we should explain we are dealing with an errata here, this is > > not obvious at first sight, the patch summary may find its pla

[PATCH v2 0/2] pm: at91: pm_slowclock: improve reliability of suspend/resume

Changes since v1: * I only splitted my patch in two Sylvain Rochet (2): pm: at91: pm_slowclock: fix suspend/resume hang up in timeouts pm: at91: pm_slowclock: remove clocks which are already stopped when entering slow clock mode arch/arm/mach-at91/pm.c | 12 arch

[PATCH v2 1/2] pm: at91: pm_slowclock: fix suspend/resume hang up in timeouts

a message or just panic. As a bonus, not decounting the timeout register in slow clock mode reduce cumulated suspend time and resume time from ~17ms to ~15ms. Signed-off-by: Sylvain Rochet --- arch/arm/mach-at91/pm_slowclock.S | 33 - 1 file changed, 4 insertions

  1   2   >