Re: [PATCH v8 03/50] mic_virtio: robust feature array size calculation

-features)) * 8; + bits = min_t(unsigned, feature_len, sizeof(features)) * 8; for (i = 0; i bits; i++) if (ioread8(in_features[i / 8]) (BIT(i % 8))) features |= BIT(i); Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com -- To unsubscribe from this list

Re: [PATCH v8 06/50] virtio_ccw: add support for 64 bit features.

, but we do it for clarity. Based on patches by Rusty, Thomas Huth and Cornelia. Signed-off-by: Rusty Russell ru...@rustcorp.com.au Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: David Hildebrand d...@linux.vnet.ibm.com

Re: [PATCH v2] virtio-balloon: do not call blocking ops when !TASK_RUNNING

, rewrite using wait_woken. Cc: sta...@vger.kernel.org Reported-by: Thomas Huth th...@linux.vnet.ibm.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- changes from v1: remove wait_event_interruptible noticed by Cornelia Huck cornelia.h...@de.ibm.com drivers

Re: [PATCHv4] kvmppc: Implement H_LOGICAL_CI_{LOAD,STORE} in KVM

Am Tue, 21 Apr 2015 10:41:51 +1000 schrieb David Gibson da...@gibson.dropbear.id.au: On POWER, storage caching is usually configured via the MMU - attributes such as cache-inhibited are stored in the TLB and the hashed page table. This makes correctly performing cache inhibited IO accesses

Re: [PATCH v5 1/8] virtio: introduce virtio_is_little_endian() helper

Am Thu, 23 Apr 2015 17:26:20 +0200 schrieb Greg Kurz gk...@linux.vnet.ibm.com: Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- include/linux/virtio_config.h | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/include/linux/virtio_config.h

Re: [PATCH v5 1/8] virtio: introduce virtio_is_little_endian() helper

); + return __cpu_to_virtio64(virtio_is_little_endian(vdev), val); } Reviewed-by: Thomas Huth th...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v5 2/8] tun: add tun_is_little_endian() helper

); + return __cpu_to_virtio16(tun_is_little_endian(tun), val); } Reviewed-by: Thomas Huth th...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v5 4/8] vringh: introduce vringh_is_little_endian() helper

__cpu_to_virtio64(vrh-little_endian, val); + return __cpu_to_virtio64(vringh_is_little_endian(vrh), val); } #endif /* _LINUX_VRINGH_H */ Reviewed-by: Thomas Huth th...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v5 6/8] virtio: add explicit big-endian support to memory accessors

On Thu, 23 Apr 2015 17:29:06 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: The current memory accessors logic is: - little endian if little_endian - native endian (i.e. no byteswap) if !little_endian If we want to fully support cross-endian vhost, we also need to be able to convert to

Re: [PATCH v5 1/8] virtio: introduce virtio_is_little_endian() helper

Am Thu, 23 Apr 2015 19:22:15 +0200 schrieb Thomas Huth th...@redhat.com: Am Thu, 23 Apr 2015 17:26:20 +0200 schrieb Greg Kurz gk...@linux.vnet.ibm.com: Signed-off-by: Greg Kurz gk...@linux.vnet.ibm.com --- include/linux/virtio_config.h | 17 +++-- 1 file changed, 11

Re: [PATCH v5 3/8] macvtap: introduce macvtap_is_little_endian() helper

) { - return __cpu_to_virtio16(q-flags MACVTAP_VNET_LE, val); + return __cpu_to_virtio16(macvtap_is_little_endian(q), val); } Reviewed-by: Thomas Huth th...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v5 5/8] vhost: introduce vhost_is_little_endian() helper

(vhost_is_little_endian(vq), val); } #endif Reviewed-by: Thomas Huth th...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCHv4] kvmppc: Implement H_LOGICAL_CI_{LOAD,STORE} in KVM

Am Tue, 21 Apr 2015 16:51:21 +1000 schrieb David Gibson da...@gibson.dropbear.id.au: On Tue, Apr 21, 2015 at 08:37:02AM +0200, Thomas Huth wrote: Am Tue, 21 Apr 2015 10:41:51 +1000 schrieb David Gibson da...@gibson.dropbear.id.au: On POWER, storage caching is usually configured via

Re: [PATCH kernel v10 05/34] powerpc/iommu: Always release iommu_table in iommu_free_table()

On Wed, 13 May 2015 16:30:16 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: On 05/13/2015 03:33 PM, Gavin Shan wrote: On Tue, May 12, 2015 at 01:38:54AM +1000, Alexey Kardashevskiy wrote: At the moment iommu_free_table() only releases memory if the table was initialized for the platform

Re: [PATCH kernel v10 23/34] powerpc/iommu/powernv: Release replaced TCE

On Thu, 14 May 2015 13:53:57 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: On 05/14/2015 01:00 AM, Thomas Huth wrote: On Tue, 12 May 2015 01:39:12 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: ... -/* - * hwaddr is a kernel virtual address here (0xc... bazillion), - * tce_build

Re: [PATCH kernel v10 23/34] powerpc/iommu/powernv: Release replaced TCE

On Tue, 12 May 2015 01:39:12 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: At the moment writing new TCE value to the IOMMU table fails with EBUSY if there is a valid entry already. However PAPR specification allows the guest to write new TCE value without clearing it first. Another

[PATCH RESEND] virtio: Fix typecast of pointer in vring_init()

The virtio_ring.h header is used in userspace programs (ie. QEMU), too. Here we can not assume that sizeof(pointer) is the same as sizeof(long), e.g. when compiling for Windows, so the typecast in vring_init() should be done with (uintptr_t) instead of (unsigned long). Signed-off-by: Thomas Huth

Re: [PATCH RESEND] virtio: Fix typecast of pointer in vring_init()

On Sun, 5 Jul 2015 14:59:54 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Jul 05, 2015 at 12:58:53PM +0200, Michael S. Tsirkin wrote: On Thu, Jul 02, 2015 at 09:21:22AM +0200, Thomas Huth wrote: The virtio_ring.h header is used in userspace programs (ie. QEMU), too. Here we can

Re: [PATCH RESEND] virtio: Fix typecast of pointer in vring_init()

On Mon, 6 Jul 2015 12:50:22 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Jul 06, 2015 at 11:24:42AM +0200, Thomas Huth wrote: On Sun, 5 Jul 2015 14:59:54 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Jul 05, 2015 at 12:58:53PM +0200, Michael S. Tsirkin wrote

Re: [PULL] virtio/vhost: cross endian support

On Thu, 2 Jul 2015 11:32:52 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jul 02, 2015 at 11:12:56AM +0200, Greg Kurz wrote: On Thu, 2 Jul 2015 08:01:28 +0200 Michael S. Tsirkin m...@redhat.com wrote: ... Yea, well - support for legacy BE guests on the new LE hosts is exactly

Re: [PATCH] KVM: Add Kconfig option to signal cross-endian guests

On Thu, 9 Jul 2015 16:07:47 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Jul 09, 2015 at 02:57:33PM +0200, Paolo Bonzini wrote: On 09/07/2015 11:48, Laurent Vivier wrote: On 09/07/2015 09:49, Thomas Huth wrote: The option for supporting cross-endianness legacy

[PATCH] KVM: Add Kconfig option to signal cross-endian guests

The option for supporting cross-endianness legacy guests in the vhost and tun code should only be available on systems that support cross-endian guests. Signed-off-by: Thomas Huth th...@redhat.com --- arch/arm/kvm/Kconfig | 1 + arch/arm64/kvm/Kconfig | 1 + arch/powerpc/kvm/Kconfig | 1

Re: [PATCH] kvm-pr: manage single-step mode

On 08.04.2016 08:58, Laurent Vivier wrote: > > > On 08/04/2016 08:23, Thomas Huth wrote: >> On 22.03.2016 15:53, Laurent Vivier wrote: >>> Until now, when we connect gdb to the QEMU gdb-server, the >>> single-step mode is not managed. >>>

Re: [PATCH v2] kvm-pr: manage single-step mode

RUPT_MACHINE_CHECK and BOOK3S_INTERRUPT_TRACE > > arch/powerpc/kvm/book3s_pr.c | 32 +++- > 1 file changed, 31 insertions(+), 1 deletion(-) Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [PATCH] kvm-pr: manage single-step mode

On 22.03.2016 15:53, Laurent Vivier wrote: > Until now, when we connect gdb to the QEMU gdb-server, the > single-step mode is not managed. > > This patch adds this, only for kvm-pr: > > If KVM_GUESTDBG_SINGLESTEP is set, we enable single-step trace bit in the > MSR (MSR_SE) just before the

Re: powerpc/pseries: start rtasd before PCI probing

/rtasd.c | 19 ++- > 1 file changed, 14 insertions(+), 5 deletions(-) By the way, same is true for device UNplugging: When unplugging devices in QEMU while the firmware is still running, they are never properly removed from the guest. I've checked it, and your patch fixes this problem as well! Great :-) Tested-by: Thomas Huth <th...@redhat.com>

Re: [PATCH] kvm-pr: manage illegal instructions

On 18.05.2016 12:53, Thomas Huth wrote: > On 18.05.2016 12:18, Thomas Huth wrote: >> On 17.05.2016 19:49, Laurent Vivier wrote: >>> >>> >>> On 17/05/2016 10:37, Alexander Graf wrote: >>>> On 05/17/2016 10:35 AM, Laurent Vivier wrote: >&

Re: [PATCH] kvm-pr: manage illegal instructions

On 18.05.2016 12:18, Thomas Huth wrote: > On 17.05.2016 19:49, Laurent Vivier wrote: >> >> >> On 17/05/2016 10:37, Alexander Graf wrote: >>> On 05/17/2016 10:35 AM, Laurent Vivier wrote: >>>> >>>> On 12/05/2016 16:23, Laurent Vivier wrote:

Re: [PATCH] kvm-pr: manage illegal instructions

On 17.05.2016 19:49, Laurent Vivier wrote: > > > On 17/05/2016 10:37, Alexander Graf wrote: >> On 05/17/2016 10:35 AM, Laurent Vivier wrote: >>> >>> On 12/05/2016 16:23, Laurent Vivier wrote: On 12/05/2016 11:27, Alexander Graf wrote: > On 05/12/2016 11:10 AM, Laurent Vivier wrote:

Re: [PATCH] kvm-pr: manage illegal instructions

On 21.04.2016 11:25, Thomas Huth wrote: > On 15.03.2016 21:18, Laurent Vivier wrote: >> While writing some instruction tests for kvm-unit-tests for powerpc, >> I've found that illegal instructions are not managed correctly with kvm-pr, >> while it is fine with kvm-hv.

Re: [PATCH] kvm-pr: manage illegal instructions

kvmppc_set_gpr(vcpu, 3, EV_UNIMPLEMENTED); > kvmppc_set_pc(vcpu, kvmppc_get_pc(vcpu) + 4); > emulated = EMULATE_DONE; > + } else { > + kvmppc_core_queue_program(vcpu, SRR1_PROGILL); > + emulated = EMULATE_AGAIN; > } > break; > case 19: > Tested-by: Thomas Huth <th...@redhat.com>

Re: [PATCH 05/11] KVM: PPC: Book3S HV: Adjust nine checks for null pointers

On 20.01.2017 19:23, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 20 Jan 2017 11:25:48 +0100 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The script "checkpatch.pl" pointed information out like

Re: [Qemu-devel] [PATCH] drm: update MAINTAINERS for qemu drivers (bochs, cirrus, qxl, virtio-gpu)

On 23.11.2016 09:06, Gerd Hoffmann wrote: > Hi, > +L:qemu-de...@nongnu.org >> >> qemu-devel list already has very high traffic - not sure whether it >> makes much sense to route even more additional patches here. Maybe >> rather create a separate mailing list like

Re: [Qemu-devel] [PATCH] drm: update MAINTAINERS for qemu drivers (bochs, cirrus, qxl, virtio-gpu)

On 22.11.2016 10:58, Gerd Hoffmann wrote: > Changes: > * add myself as maintainer, so patches land in my inbox. > * add qemu-devel mailing list. > * add drm-qemu git repo. > * flip bochs and qxl status to "Maintained". > > Signed-off-by: Gerd Hoffmann > --- > MAINTAINERS

Re: [PATCH 2/2] virtio_ring: fix complaint by sparse

On 22.11.2016 16:04, Michael S. Tsirkin wrote: > On Tue, Nov 22, 2016 at 01:51:50PM +0800, Gonglei wrote: >> # make C=2 CF="-D__CHECK_ENDIAN__" ./drivers/virtio/ >> >> drivers/virtio/virtio_ring.c:423:19: warning: incorrect type in assignment >> (different base types) >>

Re: [PATCH 05/11] powerpc/kvm: Split HPT allocation from activation

On 15.12.2016 06:53, David Gibson wrote: > Currently, kvmppc_alloc_hpt() both allocates a new hashed page table (HPT) > and sets it up as the active page table for a VM. For the upcoming HPT > resize implementation we're going to want to allocate HPTs separately from > activating them. > > So,

Re: [PATCH 01/11] powerpc/kvm: Reserve capabilities and ioctls for HPT resizing

On 15.12.2016 06:53, David Gibson wrote: > This adds a new powerpc-specific KVM_CAP_SPAPR_RESIZE_HPT capability to > advertise whether KVM is capable of handling the PAPR extensions for > resizing the hashed page table during guest runtime. > > At present, HPT resizing is possible with KVM PR

Re: [PATCH 02/11] powerpc/kvm: Rename kvm_alloc_hpt() for clarity

_SYMBOL_GPL(kvm_alloc_hpt); > +EXPORT_SYMBOL_GPL(kvm_alloc_hpt_cma); > > -void kvm_release_hpt(struct page *page, unsigned long nr_pages) > +void kvm_free_hpt_cma(struct page *page, unsigned long nr_pages) > { > cma_release(kvm_cma, page, nr_pages); > } > -EXPORT_SYMBOL_GPL(kvm_release_hpt); > +EXPORT_SYMBOL_GPL(kvm_free_hpt_cma); > > /** > * kvm_cma_reserve() - reserve area for kvm hash pagetable Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [PATCH 03/11] powerpc/kvm: Gather HPT related variables into sub-structure

On 15.12.2016 06:53, David Gibson wrote: > Currently, the powerpc kvm_arch structure contains a number of variables > tracking the state of the guest's hashed page table (HPT) in KVM HV. This > patch gathers them all together into a single kvm_hpt_info substructure. > This makes life more

Re: [PATCH 06/11] powerpc/kvm: Allow KVM_PPC_ALLOCATE_HTAB ioctl() to change HPT size

On 15.12.2016 06:53, David Gibson wrote: > The KVM_PPC_ALLOCATE_HTAB ioctl() is used to set the size of hashed page > table (HPT) that userspace expects a guest VM to have, and is also used to > clear that HPT when necessary (e.g. guest reboot). > > At present, once the ioctl() is called for the

Re: [PATCH 07/11] powerpc/kvm: Create kvmppc_unmap_hpte_helper()

On 15.12.2016 06:54, David Gibson wrote: > The kvm_unmap_rmapp() function, called from certain MMU notifiers, is used > to force all guest mappings of a particular host page to be set ABSENT, and > removed from the reverse mappings. > > For HPT resizing, we will have some cases where we want to

Re: [PATCH 01/11] powerpc/kvm: Reserve capabilities and ioctls for HPT resizing

On 15.12.2016 06:53, David Gibson wrote: > This adds a new powerpc-specific KVM_CAP_SPAPR_RESIZE_HPT capability to > advertise whether KVM is capable of handling the PAPR extensions for > resizing the hashed page table during guest runtime. > > At present, HPT resizing is possible with KVM PR

Re: [PATCH 08/11] powerpc/kvm: KVM-HV HPT resizing stub implementation

On 15.12.2016 06:54, David Gibson wrote: > This patch adds a stub (always failing) implementation of the ioctl()s > for the HPT resizing PAPR extension. > > Signed-off-by: David Gibson > --- > arch/powerpc/include/asm/kvm_ppc.h | 4 >

Re: [PATCH 06/11] powerpc/kvm: Allow KVM_PPC_ALLOCATE_HTAB ioctl() to change HPT size

On 19.12.2016 01:48, David Gibson wrote: > On Fri, Dec 16, 2016 at 01:44:57PM +0100, Thomas Huth wrote: >> On 15.12.2016 06:53, David Gibson wrote: >>> The KVM_PPC_ALLOCATE_HTAB ioctl() is used to set the size of hashed page >>> table (HPT) that userspace expects a gu

Re: [PATCH 04/11] powerpc/kvm: Don't store values derivable from HPT order

/* Now skip invalid entries while we can */ > - while (i < kvm->arch.hpt.npte && > + while (i < kvmppc_hpt_npte(>arch.hpt) && > hdr.n_invalid < 0x && > record_hpte(flags, hptp, hpte, revp, 0, first_pass)) { > /* found an invalid entry */ Dito, you could use a local variable to store the value from kvmppc_hpt_npte() Anyway, apart from these nits, patch looks fine to me, so: Reviewed-by: Thomas Huth <th...@redhat.com>

Re: drivers/s390/char/keyboard.c kernel stack infoleak

Hi, On 03.08.2017 15:59, sohu0106 wrote: > > The stack object "kbdiacr" has a total size of 4 bytes. Its last 1 bytes are > padding bytes after "result" which are not initialized and leaked to userland > via "copy_to_user". > > > diff --git a/keyboard.c b/keyboard.c > index ba0e4f9..76a6d35

Re: drivers/s390/char/keyboard.c kernel stack infoleak

On 05.08.2017 03:57, sohu0106 wrote: > My idea is > > struct kbdiacr { > unsigned char diacr, base, result; > }; > > sizeof(struct kbdiacr)=4 > > here we just set 3 bytes > case KDGKBDIACR: > { > struct kbdiacrs __user *a = argp; > struct kbdiacr diacr; > int i; > > if

Re: [PATCH] MAINTAINERS: Add Paul Mackerras as maintainer for KVM/powerpc

On 09.10.2017 16:43, Alexander Graf wrote: > > > On 09.10.17 16:42, Paolo Bonzini wrote: >> On 09/10/2017 16:34, Thomas Huth wrote: >>> Paul is handling almost all of the powerpc related KVM patches nowadays, >>> so he should be mentioned in the MAINTAINERS fil

[PATCH] MAINTAINERS: Add Paul Mackerras as maintainer for KVM/powerpc

Paul is handling almost all of the powerpc related KVM patches nowadays, so he should be mentioned in the MAINTAINERS file accordingly. Signed-off-by: Thomas Huth <th...@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2

Re: [PATCH v2 1/2] s390/virtio: remove the old KVM virtio headers

On 24.11.2017 06:21, Michael S. Tsirkin wrote: > commit 7fb2b2d51 ("s390/virtio: remove the old KVM virtio transport") > dropped the transport support. We don't need to keep the header around. > > Cc: Thomas Huth <th...@redhat.com> > Cc: Cornelia Huck <coh...

Re: [qemu-s390x] s390 qemu boot failure in -next

On 25.06.2018 10:02, Christian Borntraeger wrote: > > > On 06/25/2018 09:27 AM, Christian Borntraeger wrote: >> Also adding QEMU. >> >> On 06/25/2018 09:10 AM, Christian Borntraeger wrote: >>> >>> >>> On 06/22/2018 09:47 PM, Guenter Roeck wrote: Hi, starting with commit

Re: [PATCH v1 2/2] fbdev: Kconfig: Add HAS_IOMEM dependency for FB_OPENCORES

On 25.01.2018 16:47, Farhan Ali wrote: > The Opencores framebuffer device uses I/O memory and with > CONFIG_HAS_IOMEM disabled will lead to build errors: > > ERROR: "devm_ioremap_resource" [drivers/video/fbdev/ocfb.ko] undefined! > > Fix this by adding HAS_IOMEM dependency for FB_OPENCORES. > >

Re: [PATCH v1 1/2] Kconfig : Remove HAS_IOMEM dependency for Graphics support

On 25.01.2018 16:47, Farhan Ali wrote: > The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' > added the HAS_IOMEM dependecy for "Graphics support". This disabled the > "Graphics support" menu for S390. But if we enable VT layer for S390, > we would also need to enable

Re: [PATCH v2 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support

t; tristate "OpenCores VGA/LCD core 2.0 framebuffer support" > - depends on FB && HAS_DMA > + depends on FB && HAS_DMA && HAS_IOMEM > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [PATCH] s390/console: enable dummy console for vt

On 15.02.2018 12:26, Geert Uytterhoeven wrote: > Hi Christian, > > On Thu, Feb 15, 2018 at 12:14 PM, Christian Borntraeger > wrote: >> To enable the virtual terminal layer with virtio-gpu, we need to >> provide the dummy console. This console is hidden behind CONFIG_IOMEM

Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support

you want the console on the Newport aka XL graphics > @@ -153,7 +153,7 @@ config FRAMEBUFFER_CONSOLE_ROTATION > > config STI_CONSOLE > bool "STI text console" > -depends on PARISC > +depends on PARISC && HAS_IOMEM > select FONT_SUPPORT > default y > help > Maybe config VGA_CONSOLE should depend on HAS_IOMEM, too? I think you can hardly use a VGA card without IOMEM, can you? Anyway, this approach now looks reasonable to me, so either way, feel free to add my: Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support

ote: >>>> >>>> >>>> On 02/19/2018 05:38 PM, Farhan Ali wrote: >>>>> >>>>> >>>>> On 02/19/2018 11:25 AM, Thomas Huth wrote: >>>>>> On 19.02.2018 16:47, Farhan Ali wrote: >>>&g

Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support

On 21.02.2018 12:22, Christian Borntraeger wrote: > > > On 02/21/2018 12:14 PM, Thomas Huth wrote: >> On 21.02.2018 12:09, Christian Borntraeger wrote: >>> >>> >>> On 02/21/2018 11:32 AM, Cornelia Huck wrote: >>>> On Wed, 21 Feb 20

Re: [PATCH v3 2/3] s390/char : Rename EBCDIC keymap variables

- > drivers/s390/char/keyboard.c | 32 ++--- > drivers/s390/char/keyboard.h | 11 > 3 files changed, 61 insertions(+), 48 deletions(-) Reviewed-by: Thomas Huth <th...@redhat.com>

Re: [PATCH v3 3/3] s390/setup : enable display support for KVM guest

istian Borntraeger <borntrae...@de.ibm.com> > --- > arch/s390/kernel/setup.c | 2 ++ > drivers/tty/Kconfig | 2 +- > drivers/video/console/Kconfig | 2 +- > 3 files changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth <th...@redhat.com>

[PATCH 0/2] drm: Make it compilable without CONFIG_HDMI and CONFIG_I2C

and CONFIG_I2C. These two patches now refactor the DRM code a little bit so that we can compile it also without CONFIG_HDMI and CONFIG_I2C. Thomas Huth (2): drivers/gpu/drm: Move CONFIG_HDMI-dependent code to a separate file drivers/gpu/drm: Make the DRM code compilable without CONFIG_I2C drivers

[PATCH 1/2] drm: Move CONFIG_HDMI-dependent code to a separate file

he related code to a separate file for this. Signed-off-by: Thomas Huth <th...@redhat.com> --- drivers/gpu/drm/Kconfig | 2 +- drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/drm_crtc_internal.h | 2 + drivers/gpu/drm/drm_edid.

[PATCH 2/2] drm: Make the DRM code compilable without CONFIG_I2C

e Makefile to only compile the affected files with CONFIG_I2C=y and disable some I2C-related code in drm_edid.c. Signed-off-by: Thomas Huth <th...@redhat.com> --- drivers/gpu/drm/Kconfig| 4 ++-- drivers/gpu/drm/Makefile | 16 +--- drivers/gpu/drm/drm_edid.c | 10 +++--- 3 f

Re: [PATCH 0/2] drm: Make it compilable without CONFIG_HDMI and CONFIG_I2C

On 13.04.2018 16:32, Daniel Vetter wrote: > On Fri, Apr 13, 2018 at 11:40 AM, Thomas Huth <th...@redhat.com> wrote: >> By enabling the DRM code for virtio-gpu on S390, you currently also get >> all the code that is enabled by CONFIG_HDMI and CONFIG_I2C automatically. >>

Re: [PATCH] s390/console: enable dummy console for vt

On 15.02.2018 12:26, Geert Uytterhoeven wrote: > Hi Christian, > > On Thu, Feb 15, 2018 at 12:14 PM, Christian Borntraeger > wrote: >> To enable the virtual terminal layer with virtio-gpu, we need to >> provide the dummy console. This console is hidden behind CONFIG_IOMEM >> via the graphics

Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support

t;>>> >>>> On 02/19/2018 05:38 PM, Farhan Ali wrote: >>>>> >>>>> >>>>> On 02/19/2018 11:25 AM, Thomas Huth wrote: >>>>>> On 19.02.2018 16:47, Farhan Ali wrote: >>>>>>> The 'commit e25df1205f37 (&qu

Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support

On 21.02.2018 12:22, Christian Borntraeger wrote: > > > On 02/21/2018 12:14 PM, Thomas Huth wrote: >> On 21.02.2018 12:09, Christian Borntraeger wrote: >>> >>> >>> On 02/21/2018 11:32 AM, Cornelia Huck wrote: >>>> On Wed, 21 Feb

Re: drivers/s390/char/keyboard.c kernel stack infoleak

Hi, On 03.08.2017 15:59, sohu0106 wrote: > > The stack object "kbdiacr" has a total size of 4 bytes. Its last 1 bytes are > padding bytes after "result" which are not initialized and leaked to userland > via "copy_to_user". > > > diff --git a/keyboard.c b/keyboard.c > index ba0e4f9..76a6d35

Re: drivers/s390/char/keyboard.c kernel stack infoleak

On 05.08.2017 03:57, sohu0106 wrote: > My idea is > > struct kbdiacr { > unsigned char diacr, base, result; > }; > > sizeof(struct kbdiacr)=4 > > here we just set 3 bytes > case KDGKBDIACR: > { > struct kbdiacrs __user *a = argp; > struct kbdiacr diacr; > int i; > > if

[PATCH 0/2] drm: Make it compilable without CONFIG_HDMI and CONFIG_I2C

and CONFIG_I2C. These two patches now refactor the DRM code a little bit so that we can compile it also without CONFIG_HDMI and CONFIG_I2C. Thomas Huth (2): drivers/gpu/drm: Move CONFIG_HDMI-dependent code to a separate file drivers/gpu/drm: Make the DRM code compilable without CONFIG_I2C drivers

[PATCH 1/2] drm: Move CONFIG_HDMI-dependent code to a separate file

he related code to a separate file for this. Signed-off-by: Thomas Huth --- drivers/gpu/drm/Kconfig | 2 +- drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/drm_crtc_internal.h | 2 + drivers/gpu/drm/drm_edid.c | 163 +--- drive

[PATCH 2/2] drm: Make the DRM code compilable without CONFIG_I2C

e Makefile to only compile the affected files with CONFIG_I2C=y and disable some I2C-related code in drm_edid.c. Signed-off-by: Thomas Huth --- drivers/gpu/drm/Kconfig| 4 ++-- drivers/gpu/drm/Makefile | 16 +--- drivers/gpu/drm/drm_edid.c | 10 +++--- 3 files changed, 18 inserti

Re: [PATCH 0/2] drm: Make it compilable without CONFIG_HDMI and CONFIG_I2C

On 13.04.2018 16:32, Daniel Vetter wrote: > On Fri, Apr 13, 2018 at 11:40 AM, Thomas Huth wrote: >> By enabling the DRM code for virtio-gpu on S390, you currently also get >> all the code that is enabled by CONFIG_HDMI and CONFIG_I2C automatically. >> This is quit

Re: [PATCH v3 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support

port aka XL graphics > @@ -153,7 +153,7 @@ config FRAMEBUFFER_CONSOLE_ROTATION > > config STI_CONSOLE > bool "STI text console" > -depends on PARISC > +depends on PARISC && HAS_IOMEM > select FONT_SUPPORT > default y > help > Maybe config VGA_CONSOLE should depend on HAS_IOMEM, too? I think you can hardly use a VGA card without IOMEM, can you? Anyway, this approach now looks reasonable to me, so either way, feel free to add my: Reviewed-by: Thomas Huth

Re: [PATCH v3 2/3] s390/char : Rename EBCDIC keymap variables

> drivers/s390/char/keyboard.h | 11 > 3 files changed, 61 insertions(+), 48 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v3 3/3] s390/setup : enable display support for KVM guest

> arch/s390/kernel/setup.c | 2 ++ > drivers/tty/Kconfig | 2 +- > drivers/video/console/Kconfig | 2 +- > 3 files changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 1/3] Kconfig : Remove HAS_IOMEM dependency for Graphics support

ffer support" > - depends on FB && HAS_DMA > + depends on FB && HAS_DMA && HAS_IOMEM > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > Reviewed-by: Thomas Huth

Re: [PATCH v2 1/2] s390/virtio: remove the old KVM virtio headers

On 24.11.2017 06:21, Michael S. Tsirkin wrote: > commit 7fb2b2d51 ("s390/virtio: remove the old KVM virtio transport") > dropped the transport support. We don't need to keep the header around. > > Cc: Thomas Huth > Cc: Cornelia Huck > Cc: Halil Pasic > C

[PATCH] MAINTAINERS: Add Paul Mackerras as maintainer for KVM/powerpc

Paul is handling almost all of the powerpc related KVM patches nowadays, so he should be mentioned in the MAINTAINERS file accordingly. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2d3d750..177ffde 100644

Re: [PATCH] MAINTAINERS: Add Paul Mackerras as maintainer for KVM/powerpc

On 09.10.2017 16:43, Alexander Graf wrote: > > > On 09.10.17 16:42, Paolo Bonzini wrote: >> On 09/10/2017 16:34, Thomas Huth wrote: >>> Paul is handling almost all of the powerpc related KVM patches nowadays, >>> so he should be mentioned in the MAINTAINERS fil

Re: [kvm-unit-tests PATCH] x86: Add tests for PKS

On 05/11/2020 09.18, Chenyi Qiang wrote: This unit-test is intended to test the KVM support for Protection Keys for Supervisor Pages (PKS). If CR4.PKS is set in long mode, supervisor pkeys are checked in addition to normal paging protections and Access or Write can be disabled via a MSR update

Re: [PATCH 2/6] KVM: selftests: Avoid flooding debug log while populating memory

hile (READ_ONCE(vcpu_last_completed_iteration[vcpu_id]) + != iteration) + ; } ts_diff = timespec_elapsed(start); Reviewed-by: Thomas Huth

Re: [PATCH 3/6] KVM: selftests: Convert iterations to int in dirty_log_perf_test

On 12/01/2021 22.42, Ben Gardon wrote: In order to add an iteration -1 to indicate that the memory population phase has not yet completed, convert the interations counters to ints. No functional change intended. Reviewed-by: Jacob Xu Signed-off-by: Ben Gardon ---

[PATCH] KVM: s390: Disallow invalid bits in kvm_valid_regs and kvm_dirty_regs

. Signed-off-by: Thomas Huth --- arch/s390/include/uapi/asm/kvm.h | 6 arch/s390/kvm/kvm-s390.c | 4 +++ .../selftests/kvm/s390x/sync_regs_test.c | 30 +++ 3 files changed, 40 insertions(+) diff --git a/arch/s390/include/uapi/asm/kvm.h b/arch

[PATCH v2 2/2] KVM: selftests: Test invalid bits in kvm_valid_regs and kvm_dirty_regs on s390x

Huck Signed-off-by: Thomas Huth --- .../selftests/kvm/s390x/sync_regs_test.c | 30 +++ 1 file changed, 30 insertions(+) diff --git a/tools/testing/selftests/kvm/s390x/sync_regs_test.c b/tools/testing/selftests/kvm/s390x/sync_regs_test.c index bbc93094519b..d5290b4ad636 100644

[PATCH v2 0/2] KVM: s390: Check for invalid bits in kvm_valid_regs and kvm_dirty_regs

Avoid invalid bits in kvm_valid_regs and kvm_dirty_regs on s390x. v2: - Split the single patch from v1 into two separate patches (I've kept the Reviewed-bys from v1, but if you don't agree with the patch description of the 2nd patch, please complain) Thomas Huth (2): KVM: s390

[PATCH v2 1/2] KVM: s390: Disallow invalid bits in kvm_valid_regs and kvm_dirty_regs

Borntraeger Reviewed-by: Cornelia Huck Signed-off-by: Thomas Huth --- arch/s390/include/uapi/asm/kvm.h | 6 ++ arch/s390/kvm/kvm-s390.c | 4 2 files changed, 10 insertions(+) diff --git a/arch/s390/include/uapi/asm/kvm.h b/arch/s390/include/uapi/asm/kvm.h index 47104e5b47fd

Re: [PATCH v2 1/2] KVM: s390: Disallow invalid bits in kvm_valid_regs and kvm_dirty_regs

On 04/09/2019 11.05, David Hildenbrand wrote: > On 04.09.19 10:51, Thomas Huth wrote: >> If unknown bits are set in kvm_valid_regs or kvm_dirty_regs, this >> clearly indicates that something went wrong in the KVM userspace >> application. The x86 variant of KVM already contai

Re: [PATCH v2 1/2] KVM: s390: Disallow invalid bits in kvm_valid_regs and kvm_dirty_regs

On 04/09/2019 11.15, David Hildenbrand wrote: > On 04.09.19 11:11, Christian Borntraeger wrote: >> >> >> On 04.09.19 11:05, David Hildenbrand wrote: >>> On 04.09.19 10:51, Thomas Huth wrote: >>>> If unknown bits are set in kvm_valid_regs or k

Re: [PATCH] KVM: selftests: Detect max PA width from cpuid

On 26/08/2019 09.57, Peter Xu wrote: > The dirty_log_test is failing on some old machines like Xeon E3-1220 > with tripple faults when writting to the tracked memory region: > > Test iterations: 32, interval: 10 (ms) > Testing guest mode: PA-bits:52, VA-bits:48, 4K pages > guest physical

[PATCH 0/2] KVM: selftests: Enable ucall and dirty_log_test on s390x

Implement the ucall() interface on s390x to be able to use the dirty_log_test KVM selftest on s390x, too. Thomas Huth (2): KVM: selftests: Implement ucall() for s390x KVM: selftests: Enable dirty_log_test on s390x tools/testing/selftests/kvm/Makefile | 1 + tools/testing/selftests

[PATCH 2/2] KVM: selftests: Enable dirty_log_test on s390x

to for the first time, so we have to make sure that we touch all pages during the first iteration to keep the test in sync here. Signed-off-by: Thomas Huth --- tools/testing/selftests/kvm/Makefile | 1 + tools/testing/selftests/kvm/dirty_log_test.c | 70 ++-- 2 files changed, 66

[PATCH 1/2] KVM: selftests: Implement ucall() for s390x

mented, we can use it in the sync_reg_test on s390x, too. Signed-off-by: Thomas Huth --- .../testing/selftests/kvm/include/kvm_util.h | 2 +- tools/testing/selftests/kvm/lib/ucall.c | 34 +++ .../selftests/kvm/s390x/sync_regs_test.c | 6 ++-- 3 files changed, 32

Re: [PATCH 2/2] KVM: selftests: Enable dirty_log_test on s390x

On 30/07/2019 16.57, Christian Borntraeger wrote: > > > On 30.07.19 12:01, Thomas Huth wrote: >> To run the dirty_log_test on s390x, we have to make sure that we >> access the dirty log bitmap with little endian byte ordering and >> we have to properly align the memslo

Re: [PATCH 2/2] KVM: selftests: Enable dirty_log_test on s390x

On 30/07/2019 12.57, Andrew Jones wrote: > On Tue, Jul 30, 2019 at 12:01:12PM +0200, Thomas Huth wrote: >> To run the dirty_log_test on s390x, we have to make sure that we >> access the dirty log bitmap with little endian byte ordering and >> we have to properly align the

Re: [PATCH 1/2] KVM: selftests: Implement ucall() for s390x

On 30/07/2019 12.48, Andrew Jones wrote: > On Tue, Jul 30, 2019 at 12:01:11PM +0200, Thomas Huth wrote: >> On s390x, we can neither exit via PIO nor MMIO, but have to use >> an instruction like DIAGNOSE. While we're at it, rename UCALL_PIO >> to UCALL_DEFAULT, since PIO onl

Re: [PATCH 1/2] KVM: selftests: Implement ucall() for s390x

On 31/07/2019 12.28, Andrew Jones wrote: > On Wed, Jul 31, 2019 at 11:43:16AM +0200, Thomas Huth wrote: >> On 30/07/2019 12.48, Andrew Jones wrote: >>> On Tue, Jul 30, 2019 at 12:01:11PM +0200, Thomas Huth wrote: >>>> On s390x, we can neither exit via

Re: [PATCH trivial] KVM: PPC: Remove superfluous check for non-zero return value

On 18/09/2019 22.54, Greg Kurz wrote: > On Wed, 18 Sep 2019 18:44:36 +0200 > Greg Kurz wrote: > >> On Wed, 11 Sep 2019 21:52:35 +0200 >> Thomas Huth wrote: >> >>> After the kfree()s haven been removed in the previous >>> commit 9798f4ea71ea

[PATCH] KVM: PPC: Remove superfluous check for non-zero return value

After the kfree()s haven been removed in the previous commit 9798f4ea71ea ("fix rollback when kvmppc_xive_create fails"), the code can be simplified even more to simply always "return ret" now. Signed-off-by: Thomas Huth --- arch/powerpc/kvm/book3s_xive.c| 5 +--

Re: [PATCH v1 1/2] Kconfig : Remove HAS_IOMEM dependency for Graphics support

On 25.01.2018 16:47, Farhan Ali wrote: > The 'commit e25df1205f37 ("[S390] Kconfig: menus with depends on HAS_IOMEM.")' > added the HAS_IOMEM dependecy for "Graphics support". This disabled the > "Graphics support" menu for S390. But if we enable VT layer for S390, > we would also need to enable

  1   2   3   >