[PATCH] gpio/gpio-pl061: Covert to use devm_* functions

2012-10-05 Thread Tobias Klauser
Use the devm_* family of functions during probe to reduce the error handling code footprint. Signed-off-by: Tobias Klauser --- drivers/gpio/gpio-pl061.c | 59 1 files changed, 22 insertions(+), 37 deletions(-) diff --git a/drivers/gpio/gpio-pl061

[PATCH] h8300: Remove unnecessary prototypes for kobjsize() and is_in_rom()

2012-10-26 Thread Tobias Klauser
The prototype for kobjsize() is already defined in linux/mm.h which is included where kobjsize() is used. is_in_rom() is neither defined nor used across the whole tree, so delete the prototype. Signed-off-by: Tobias Klauser --- arch/h8300/include/asm/pgtable.h |6 -- 1 files changed, 0

[PATCH] frv: Remove unused is_in_rom()

2012-10-26 Thread Tobias Klauser
The function is not used anywhere in the whole tree (anymore), so remove it. Signed-off-by: Tobias Klauser --- arch/frv/include/asm/sections.h |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/arch/frv/include/asm/sections.h b/arch/frv/include/asm/sections.h index

[PATCH] c6x: Use schedule_preempt_disabled()

2012-08-16 Thread Tobias Klauser
Follow bd2f5536 (sched/rt: Use schedule_preempt_disabled()). Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: Ingo Molnar Signed-off-by: Tobias Klauser --- arch/c6x/kernel/process.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/arch/c6x/kernel/process.c b/arch/c6x

[PATCH] blackfin: Use schedule_preempt_disabled()

2012-08-16 Thread Tobias Klauser
Follow bd2f5536 (sched/rt: Use schedule_preempt_disabled()). b5affb014 (blackfin: add bf60x to current framework) accidentally (?) reverted the change. Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: Ingo Molnar Signed-off-by: Tobias Klauser --- arch/blackfin/kernel/process.c |4 +--- 1

[PATCH] openrisc: Use schedule_preempt_disabled()

2012-08-16 Thread Tobias Klauser
Follow bd2f5536 (sched/rt: Use schedule_preempt_disabled()). Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: Ingo Molnar Signed-off-by: Tobias Klauser --- arch/openrisc/kernel/idle.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/arch/openrisc/kernel/idle.c b/arch

[PATCH] unicore32: Use schedule_preempt_disabled()

2012-08-16 Thread Tobias Klauser
Follow bd2f5536 (sched/rt: Use schedule_preempt_disabled()). Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: Ingo Molnar Signed-off-by: Tobias Klauser --- arch/unicore32/kernel/process.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/arch/unicore32/kernel/process.c b

Re: [PATCH v2 07/31] arm64: Process management

2012-08-16 Thread Tobias Klauser
On 2012-08-14 at 19:52:08 +0200, Catalin Marinas wrote: > +void cpu_idle(void) > +{ > + local_fiq_enable(); > + > + /* endless idle loop with no priority at all */ > + while (1) { > + tick_nohz_idle_enter(); > + rcu_idle_enter(); > + while (!need_re

[PATCH RESEND] ARM: picoxcell: remove unnecessary header common.h

2013-01-09 Thread Tobias Klauser
Since commit 66314223 ("ARM: socfpga: initial support for Altera's SOCFPGA platform") struct sys_timer dw_apb_timer is an extern in , so there is no need for common.h anymore, instead directly #include in common.c Signed-off-by: Tobias Klauser Acked-by: Jamie Iles --- I looks l

[PATCH] Add cscope generated files to .gitignore

2006-12-13 Thread Tobias Klauser
Ignore files generated by 'make cscope' Signed-off-by: Tobias Klauser <[EMAIL PROTECTED]> --- .gitignore |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index e1d5c17..1586b9d 100644 --- a/.gitignore +++ b/.gitignore @@ -41,3

Re: [PATCH 3/9] serial: altera: constify uart_ops structures

2016-09-02 Thread Tobias Klauser
; @@ > e.ops = &i@p; > > @bad@ > position p != {r.p,ok.p}; > identifier r.i; > struct uart_ops e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct uart_ops i = { ... }; > // > > Signed-off-by: Julia Lawall Acked-by: Tobias Klauser Thanks a lot.

Re: [PATCH] tty/serial: altera_uart: Convert timers to use timer_setup()

2017-10-24 Thread Tobias Klauser
On 2017-10-24 at 11:59:56 +0200, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Tobias Klauser > Cc:

Re: net: hns: set correct return value

2017-10-30 Thread Tobias Klauser
g/project/netdev/list/ Care to resend with the proper subject? For the patch itself: Reviewed-by: Tobias Klauser

Re: [PATCH] net: hns: set correct return value

2017-10-30 Thread Tobias Klauser
in this case, the extracted error code will > always be zero, which is unexpected. > > Signed-off-by: Pan Bian Reviewed-by: Tobias Klauser

[PATCH] score: remove unused __ARCH_HAVE_MMU define

2018-01-25 Thread Tobias Klauser
The __ARCH_HAVE_MMU define is (and was) used nowhere in the tree and also doesn't appear to be used by any libc. Signed-off-by: Tobias Klauser --- arch/score/include/uapi/asm/unistd.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/score/include/uapi/asm/unistd.h b/arch/score/in

Re: [PATCH] serial: altera_jtaguart: adding iounmap()

2017-05-13 Thread Tobias Klauser
On 2017-05-12 at 23:36:22 +0200, Alexey Khoroshilov wrote: > The driver does ioremap(port->mapbase, ALTERA_JTAGUART_SIZE), > but there is no any iounmap(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Ack

Re: [RESEND PATCH] nios2: defconfig: Cleanup from old Kconfig options

2018-01-22 Thread Tobias Klauser
On 2017-12-26 at 14:32:07 +0100, Krzysztof Kozlowski wrote: > Remove old, dead Kconfig option INET_LRO. It is gone since > commit 7bbf3cae65b6 ("ipv4: Remove inet_lro library"). > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Tobias Klauser

Re: [PATCH 5/7] nios2: remove arch specific early_init_dt_alloc_memory_arch

2018-01-17 Thread Tobias Klauser
On 2018-01-06 at 00:20:52 +0100, Rob Herring wrote: > Now that the DT core code handles bootmem arches, we can remove the nios2 > specific early_init_dt_alloc_memory_arch function. > > Cc: Ley Foon Tan > Cc: nios2-...@lists.rocketboards.org > Signed-off-by: Rob Herring R

[PATCH] scripts/checkstack.pl: remove blackfin support

2018-03-14 Thread Tobias Klauser
The Blackfin port has been removed from the kernel, also remove the blackfin specific bits from the checkstack.pl script. Signed-off-by: Tobias Klauser --- Patch against the Arnd's asm-generic tree. scripts/checkstack.pl | 3 --- 1 file changed, 3 deletions(-) diff --git a/sc

[PATCH] nios2: kconfig: remove duplicate DEBUG_STACK_USAGE symbol defintions

2018-08-16 Thread Tobias Klauser
DEBUG_STACK_USAGE is already defined in lib/Kconfig.debug Signed-off-by: Tobias Klauser --- arch/nios2/Kconfig.debug | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug index 7a49f0d28d14..f1da8a7b17ff 100644 --- a/arch/nios2

Re: riscv+KASAN does not boot

2021-02-16 Thread Tobias Klauser
On 2021-02-16 at 12:17:30 +0100, Dmitry Vyukov wrote: > On Fri, Jan 29, 2021 at 9:11 AM Dmitry Vyukov wrote: > > > I was fixing KASAN support for my sv48 patchset so I took a look at your > > > issue: I built a kernel on top of the branch riscv/fixes using > > > https://github.com/google/syzkalle

[PATCH] arc: Remove unused prepare_to_copy()

2015-01-05 Thread Tobias Klauser
prepare_to_copy() was removed from all architectures supported at that time in commit 55ccf3fe3f9a ("fork: move the real prepare_to_copy() users to arch_dup_task_struct()"). Remove it from arc as well. Signed-off-by: Tobias Klauser --- arch/arc/include/asm/processor.h | 3 --- 1 file

Re: [PATCH v9 2/2] drivers/gpio: Altera soft IP GPIO driver

2015-01-06 Thread Tobias Klauser
On 2015-01-06 at 03:19:33 +0100, th...@altera.com wrote: [...] > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 633ec21..e38beff 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -156,6 +156,14 @@ config GPIO_DWAPB > Say Y or M here to build support fo

Re: [PATCH] drivers: Kconfig: Remove duplicate sourcing of soc folder

2014-12-08 Thread Tobias Klauser
On 2014-12-08 at 14:36:24 +0100, Pramod Gurav wrote: > Folder soc/ was sourced twice somehow. Remove duplicate entry. I already sent a patch for this a while ago [1], though it wasn't applied yet. [1] http://thread.gmane.org/gmane.linux.kernel/1831623 -- To unsubscribe from this list: send the

Re: [PATCH 26/38] nios2: drop _PAGE_FILE and pte_file()-related helpers

2014-12-25 Thread Tobias Klauser
On 2014-12-24 at 13:22:34 +0100, Kirill A. Shutemov wrote: > We've replaced remap_file_pages(2) implementation with emulation. > Nobody creates non-linear mapping anymore. > > Signed-off-by: Kirill A. Shutemov > Cc: Ley Foon Tan Reviewed-by: Tobias Klauser -- To unsubs

[PATCH] nios2: Use preempt_schedule_irq

2014-12-30 Thread Tobias Klauser
hedule_irq will already take care of rescheduling. This also fixes the following build error when building with CONFIG_PREEMPT: arch/nios2/kernel/built-in.o: In function `need_resched': arch/nios2/kernel/entry.S:374: undefined reference to `PREEMPT_ACTIVE' Cc: Thomas Gleixner Signed-of

Re: [PATCH V2 2/2] bfin_can: rewrite the driver to support the common

2015-01-08 Thread Tobias Klauser
On 2015-01-08 at 07:57:34 +0100, Aaron Wu wrote: > Rewrite the driver to comply to common style with MMU > > Signed-off-by: Aaron Wu > --- > drivers/net/can/bfin_can.c | 21 - > 1 file changed, 8 insertions(+), 13 deletions(-) > > diff --git a/drivers/net/can/bfin_can.c

Re: [PATCH V2] tty: serial: Add const to struct uart_ops declarations

2015-04-07 Thread Tobias Klauser
On 2015-04-05 at 20:24:54 +0200, Joe Perches wrote: [...] > drivers/tty/serial/altera_jtaguart.c| 2 +- > drivers/tty/serial/altera_uart.c| 2 +- For these two drivers: Acked-by: Tobias Klauser -- To unsubscribe from this list: send the line "unsubscribe linux

[PATCH] kdbus: Make kdbus_bus_unref() return void

2015-04-22 Thread Tobias Klauser
kdbus_bus_unref() always returns NULL and none of its callers use the return value, so make it return void. Signed-off-by: Tobias Klauser --- ipc/kdbus/bus.c | 5 + ipc/kdbus/bus.h | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/ipc/kdbus/bus.c b/ipc/kdbus/bus.c index

Re: [PATCH] kdbus: Make kdbus_bus_unref() return void

2015-04-22 Thread Tobias Klauser
On 2015-04-22 at 14:01:05 +0200, David Herrmann wrote: > Hi > > On Wed, Apr 22, 2015 at 1:50 PM, Tobias Klauser wrote: > > kdbus_bus_unref() always returns NULL and none of its callers use the > > return value, so make it return void. > > > > Signed-off

[PATCH] ARC: perf: Remove unnecessary local variable

2015-04-24 Thread Tobias Klauser
Directly return the result of perf_pmu_register() in arc_pmu_device_probe() instead of assigning and returning variable ret. Signed-off-by: Tobias Klauser --- arch/arc/kernel/perf_event.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arc/kernel/perf_event.c b

[PATCH] sched/autogroup: Remove unnecessary #ifdef guards

2015-04-15 Thread Tobias Klauser
Since commit 029632fbb7b7 ("sched: Make separate sched*.c translation units") autogroup is a separate translation unit built from the Makefile and thus no longer needs its content wrapped with #ifdef CONFIG_SCHED_AUTOGROUP. Signed-off-by: Tobias Klauser --- kernel/sched/auto_group.c |

Re: [PATCH v9 01/17] h8300: Assembly headers.

2015-04-27 Thread Tobias Klauser
On 2015-04-27 at 07:35:08 +0200, Yoshinori Sato wrote: [...] > diff --git a/arch/h8300/include/asm/elf.h b/arch/h8300/include/asm/elf.h > new file mode 100644 > index 000..09031d0 > --- /dev/null > +++ b/arch/h8300/include/asm/elf.h > @@ -0,0 +1,101 @@ > +#ifndef __ASM_H8300_ELF_H > +#define

Re: [PATCH v9 01/17] h8300: Assembly headers.

2015-04-27 Thread Tobias Klauser
On 2015-04-27 at 09:48:39 +0200, Arnd Bergmann wrote: > On Monday 27 April 2015 09:42:41 Tobias Klauser wrote: > > > diff --git a/arch/h8300/include/asm/elf.h b/arch/h8300/include/asm/elf.h > > > new file mode 100644 > > > index 000..09031d0 > > > --- /

Re: [PATCH v8 01/17] h8300: Assembly headers.

2015-04-20 Thread Tobias Klauser
On 2015-04-20 at 08:13:17 +0200, Yoshinori Sato wrote: [...] > diff --git a/arch/h8300/include/asm/elf.h b/arch/h8300/include/asm/elf.h > new file mode 100644 > index 000..09031d0 > --- /dev/null > +++ b/arch/h8300/include/asm/elf.h > @@ -0,0 +1,101 @@ > +#ifndef __ASM_H8300_ELF_H > +#define

[PATCH] frv: Remove unused inline function is_in_rom()

2015-04-20 Thread Tobias Klauser
The function is not used anywhere in the tree (anymore) and this is the last remaining instance, so remove it. Signed-off-by: Tobias Klauser --- arch/frv/include/asm/sections.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/arch/frv/include/asm/sections.h b/arch/frv/include/asm

Re: [PATCH v8 01/17] h8300: Assembly headers.

2015-04-20 Thread Tobias Klauser
On 2015-04-20 at 08:13:17 +0200, Yoshinori Sato wrote: [...] > diff --git a/arch/h8300/include/asm/pgtable.h > b/arch/h8300/include/asm/pgtable.h > new file mode 100644 > index 000..8341db6 > --- /dev/null > +++ b/arch/h8300/include/asm/pgtable.h > @@ -0,0 +1,49 @@ > +#ifndef _H8300_PGTABLE_

Re: [PATCH 1/2] drivers/tty/serial: altera: fix typos in #endif comments

2015-04-13 Thread Tobias Klauser
On 2015-04-11 at 12:21:30 +0200, Valentin Rothberg wrote: > Correct reference on CONFIG_SERIAL_ALTERA_{JTAG}UART_CONSOLE in > C-comment after #endif. > > Signed-off-by: Valentin Rothberg Acked-by: Tobias Klauser -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH net-next] net: ethoc: Remove useless test before clk_disable_unprepare

2018-05-16 Thread Tobias Klauser
On 2018-05-16 at 13:18:22 +0200, YueHaibing wrote: > clk_disable_unprepare() already checks that the clock pointer is valid. > No need to test it before calling it. > > Signed-off-by: YueHaibing Reviewed-by: Tobias Klauser

Re: [PATCH] selftests/vDSO: fix ABI selftest on riscv

2021-02-10 Thread Tobias Klauser
On 2021-02-09 at 00:37:24 +0100, Shuah Khan wrote: > On 2/5/21 12:57 AM, Tobias Klauser wrote: > > On 2021-02-05 at 08:06:37 +0100, Palmer Dabbelt wrote: > > > On Thu, 04 Feb 2021 06:50:42 PST (-0800), tklau...@distanz.ch wrote: > > > > [...] > > > >

[PATCH] selftests/vDSO: fix ABI selftest on riscv

2021-02-04 Thread Tobias Klauser
Signed-off-by: Tobias Klauser --- tools/testing/selftests/vDSO/vdso_config.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/vDSO/vdso_config.h b/tools/testing/selftests/vDSO/vdso_config.h index 6a6fe8d4ff55..6188b16827d1 100644 --- a/tools/testing

Re: [PATCH] selftests/vDSO: fix ABI selftest on riscv

2021-02-05 Thread Tobias Klauser
On 2021-02-05 at 08:06:37 +0100, Palmer Dabbelt wrote: > On Thu, 04 Feb 2021 06:50:42 PST (-0800), tklau...@distanz.ch wrote: [...] > Reviewed-by: Palmer Dabbelt > Acked-by: Palmer Dabbelt Thank you! > Not sure if you want this through the RISC-V tree, so I'm leaving it out for > now and ass

Re: [PATCH] tools/bpf/bpftool: Fix wrong return value in do_dump()

2020-08-03 Thread Tobias Klauser
On 2020-08-02 at 13:15:40 +0200, Tianjia Zhang wrote: > In case of btf_id does not exist, a negative error code -ENOENT > should be returned. > > Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types") > Cc: Andrii Nakryiko > Signed-off-by: Tianjia Zhang

Re: riscv+KASAN does not boot

2021-01-18 Thread Tobias Klauser
On 2021-01-14 at 11:24:07 +0100, Dmitry Vyukov wrote: > On Thu, Jan 14, 2021 at 10:23 AM Dmitry Vyukov wrote: > > > > On Thu, Jan 14, 2021 at 5:57 AM Palmer Dabbelt > > wrote: > > > > > > On Fri, 25 Dec 2020 09:13:23 PST (-0800), dvyu...@google.com wrote: > > > > On Fri, Dec 25, 2020 at 5:58 PM

[PATCH] selftests/vDSO: add additional binaries to .gitignore

2020-12-17 Thread Tobias Klauser
Add the test binaries introduced by commit 693f5ca08ca0 ("kselftest: Extend vDSO selftest"), commit 03f55c7952c9 ("kselftest: Extend vDSO selftest to clock_getres") and commit c7e5789b24d3 ("kselftest: Move test_vdso to the vDSO test suite") to .gitignore.

[PATCH] selftests/vDSO: fix -Wformat warning in vdso_test_correctness

2020-12-17 Thread Tobias Klauser
ype ‘long int’, but argument 7 has type ‘long long int’ [-Wformat=] The tv_sec member of __kernel_timespec is long long, both in uapi/linux/time_types.h and locally in vdso_test_correctness.c. Signed-off-by: Tobias Klauser --- tools/testing/selftests/vDSO/vdso_test_correctness.c | 2 +- 1 file change

[PATCH] selftests/timens: add futex binary to .gitignore

2020-12-18 Thread Tobias Klauser
Add the futex test binary introduced by commit a4fd8414659b ("selftests/timens: Add a test for futex()") to .gitignore. Signed-off-by: Tobias Klauser --- tools/testing/selftests/timens/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/timens/.gi

Re: [PATCH V2] support Thinkpad X1 Carbon's adaptive keyboard

2014-03-04 Thread Tobias Klauser
On 2014-03-03 at 17:31:08 +0100, Shuduo Sang wrote: [...] > +/* press Fn key a while second, it will switch to Function Mode. Then > + * release Fn key, previous mode be restored. > + */ > +bool adaptive_keyboard_mode_is_saved; > +int adaptive_keybarod_prev_mode; These should probably be made sta

Re: [PATCH V3] support Thinkpad X1 Carbon 2nd generation's adaptive keyboard

2014-03-04 Thread Tobias Klauser
On 2014-03-04 at 12:13:54 +0100, Shuduo Sang wrote: > > Submit patch V3 to support Adaptive Keyboard on Thinkpad X1 Carbon 2nd > generation according to Tobias's comments. It seems like I missed one in the previous comment, sorry. Also one of the previous comments was only partially addressed in

Re: [PATCH] staging: cxt1e1: use kzalloc instead of kmalloc/memset 0

2014-03-05 Thread Tobias Klauser
On 2014-03-05 at 03:37:15 +0100, Daeseok Youn wrote: > > Signed-off-by: Daeseok Youn > --- > drivers/staging/cxt1e1/sbecom_inline_linux.h |6 ++ > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/cxt1e1/sbecom_inline_linux.h > b/drivers/staging/cxt1e1/

Re: [PATCH 7/7] staging: cxt1e1: remove unneeded a value

2014-03-05 Thread Tobias Klauser
On 2014-03-05 at 02:24:22 +0100, Daeseok Youn wrote: > > It doesn't need to assign name array address to np pointer. > > Signed-off-by: Daeseok Youn > --- > drivers/staging/cxt1e1/linux.c |5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/cxt1e1/

Re: [PATCH 7/7] staging: cxt1e1: remove unneeded a value

2014-03-05 Thread Tobias Klauser
On 2014-03-06 at 08:19:19 +0100, DaeSeok Youn wrote: > 2014-03-05 19:13 GMT+09:00 Tobias Klauser : > > On 2014-03-05 at 02:24:22 +0100, Daeseok Youn > > wrote: > >> > >> It doesn't need to assign name array address to np pointer. > >> > >

[PATCH] MAINTAINERS: Change mailing list address for Altera UART drivers

2014-02-21 Thread Tobias Klauser
The nios2-dev list has been moved to the RocketBoards infrastructure, so adjust the address accordingly. Signed-off-by: Tobias Klauser --- MAINTAINERS |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ca47282..5a4fdfd 100644 --- a/MAINTAINERS

Re: [PATCH 06/28] nios2: Memory management

2014-04-22 Thread Tobias Klauser
On 2014-04-22 at 16:24:43 +0200, Ezequiel Garcia wrote: > Hi Ley Foon, > > On Apr 18, Ley Foon Tan wrote: > > +/* > > + * PAGE_SHIFT determines the page size > > + */ > > +#define PAGE_SHIFT 12 > > +#define PAGE_SIZE 4096 > > +#define PAGE_MASK (~(PAGE_SIZE - 1)) > > + > > How about something

Re: [PATCH 23/28] nios2: Nios2 registers

2014-04-23 Thread Tobias Klauser
On 2014-04-23 at 09:10:26 +0200, Ley Foon Tan wrote: > Hi Tobias > > > On Tue, Apr 22, 2014 at 8:39 PM, Tobias Klauser wrote: > > On 2014-04-18 at 14:27:06 +0200, Ley Foon Tan wrote: > > >> + > >> +/* estatus register bits */ > >> +#define EST

Re: [PATCH 2/2] netlink: Convert netlink_lookup() to use RCU protected hash table

2014-07-29 Thread Tobias Klauser
On 2014-07-29 at 13:41:33 +0200, Thomas Graf wrote: > Heavy Netlink users such as Open vSwitch spend a considerable amount of > time in netlink_lookup() due to the read-lock on nl_table_lock. Use of > RCU relieves the lock contention. > > Makes use of the new resizable hash table to avoid locking

Re: [PATCH v2 05/29] nios2: Memory management

2014-07-30 Thread Tobias Klauser
/null > >>> +++ b/arch/nios2/include/asm/mmu.h > >>> @@ -0,0 +1,18 @@ > >>> +/* > >>> + * Copyright (C) 2010 Tobias Klauser > >>> + * Copyright (C) 2004 Microtronix Datacom Ltd. > >>> + * > >>> + * Tak

Re: [PATCH v2 05/29] nios2: Memory management

2014-07-30 Thread Tobias Klauser
os2/include/asm/page.h b/arch/nios2/include/asm/page.h > new file mode 100644 > index 000..b89c1d6 > --- /dev/null > +++ b/arch/nios2/include/asm/page.h > @@ -0,0 +1,113 @@ > +/* > + * Copyright (C) 2011 Tobias Klauser > + * Copyright (C) 2004 Microtronix Datacom Ltd. > +

Re: [PATCH v2 02/29] nios2: Kernel booting and initialization

2014-07-30 Thread Tobias Klauser
On 2014-07-15 at 10:45:29 +0200, Ley Foon Tan wrote: > This patch adds the kernel booting and the initial setup code. > > Signed-off-by: Ley Foon Tan > --- > arch/nios2/include/asm/entry.h | 152 > arch/nios2/include/asm/setup.h | 38 +++ > arch/nios2/kernel/he

Re: [PATCH v2 1/1] staging: vt6655: ioctl.c - missing __user annotation

2014-07-30 Thread Tobias Klauser
On 2014-07-30 at 12:41:59 +0200, Anil Belur wrote: > From: Anil Belur This line is only necessary if you're sending the patch on behalf of someone else. Also there is no need to have the 1/1 in the Subject line as you're only sending one patch, not an entire series. > v2: > - private_ioctl() in

Re: [PATCH] staging: vt6655: Fix device table definition.

2014-07-30 Thread Tobias Klauser
On 2014-07-29 at 19:44:24 +0200, fernando.apesteg...@gmail.com wrote: > From: Fernando Apesteguia > > Add static to the definition of the pci device table. > > Signed-off-by: Fernando Apesteguia This change is already part of Greg's tree, see commit 9e4c5c2837a4 ("staging: vt6655: statify so

Re: [PATCH] staging: rtl8192u: delete unused function CAM_read_entry

2014-09-18 Thread Tobias Klauser
On 2014-09-17 at 21:17:29 +0200, Benedict Boerger wrote: > Fix the sparse warning: symbol 'CAM_read_entry' was not declared. Should it > be static? > > The function CAM_read_entry is not used and therefore deleted. Your patch is missing a Signed-off-by line. Please check Documentation/Submitti

Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

2014-09-23 Thread Tobias Klauser
On 2014-09-22 at 23:28:03 +0200, Mark Einon wrote: > This patch moves the et131x gigabit ethernet driver from drivers/staging > to drivers/net/ethernet/agere. > > There are no known issues at this time. > > Signed-off-by: Mark Einon > --- > > This patch will only apply once the last few pendin

Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

2014-09-23 Thread Tobias Klauser
On 2014-09-23 at 11:46:15 +0200, Mark Einon wrote: > On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote: > > Hi Tobias, > > Thanks for the details review. I've replied below - > > [...] > > > +/* et131x_rx_dma_memory_alloc > > > + * >

Re: [PATCH v3 01/29] asm-generic: add generic futex for !CONFIG_SMP

2014-09-26 Thread Tobias Klauser
On 2014-09-24 at 13:10:00 +0200, Arnd Bergmann wrote: > On Wednesday 24 September 2014 18:57:54 Ley Foon Tan wrote: > > On Wed, Sep 24, 2014 at 6:40 PM, Arnd Bergmann wrote: > > > On Wednesday 24 September 2014 18:18:50 Ley Foon Tan wrote: > > >> On Tue, Sep 23, 2014 at 6:40 PM, Arnd Bergmann wr

Re: [PATCH v3 26/29] nios2: ptrace support

2014-09-16 Thread Tobias Klauser
On 2014-09-08 at 11:22:37 +0200, Ley Foon Tan wrote: > Add ptrace support for nios2. > > Signed-off-by: Ley Foon Tan > --- > arch/nios2/include/asm/ptrace.h | 33 +++ > arch/nios2/include/uapi/asm/ptrace.h | 120 > arch/nios2/kernel/ptrace.c | 176 >

[PATCH] MAINTAINERS: Add tools/net to NETWORKING [GENERAL]

2014-03-11 Thread Tobias Klauser
Make sure patches for these tools go to the netdev list as well. References: https://marc.info/?l=linux-kernel&m=139450284501328&w=2 Cc: David S. Miller Cc: Daniel Borkmann Signed-off-by: Tobias Klauser --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINT

Re: [PATCH 3/4] staging/wlan-ng: code refactoring

2014-05-16 Thread Tobias Klauser
On 2014-05-12 at 17:22:46 +0200, Denis Pithon wrote: > Extract new static function from p80211netdev_rx_bh() to fix coding > style issue (too many leading tabs). > > Signed-off-by: Denis Pithon > --- > drivers/staging/wlan-ng/p80211netdev.c | 74 > -- > 1 file c

[PATCH] MAINTAINERS: Add closing angle bracket to Vince Bridgers' email address

2014-05-20 Thread Tobias Klauser
Add the missing closing angle bracket to Vince Bridgers' email address in MAINTAINERS. Cc: Vince Bridgers Signed-off-by: Tobias Klauser --- MAINTAINERS |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9b3ee6e..fe421e7 100644

Re: [RFC PATCH] net:Add basic DWC Ethernet QoS Driver

2014-05-09 Thread Tobias Klauser
On 2014-05-08 at 14:50:14 +0200, Andreas Irestal wrote: > This is an early version of a driver for the Synopsys DWC Ethernet QoS IP > version 4. Unfortunately, version 4.00a and onwards of this IP is totally > different from earlier versions used in the STMicroelectronics drivers. Both > function

[PATCH] ARM: nommu: Remove unnecessary prototype for kobjsize()

2014-06-20 Thread Tobias Klauser
The prototype for kobjsize() is already defined in linux/mm.h which is included where kobjsize() is used. Signed-off-by: Tobias Klauser --- arch/arm/include/asm/pgtable-nommu.h |6 -- 1 file changed, 6 deletions(-) diff --git a/arch/arm/include/asm/pgtable-nommu.h b/arch/arm/include

[PATCH] m68knommu: Remove unnecessary prototype for kobjsize()

2014-06-20 Thread Tobias Klauser
The prototype for kobjsize() is already defined in linux/mm.h which is included where kobjsize() is used. Signed-off-by: Tobias Klauser --- arch/m68k/include/asm/pgtable_no.h |5 - 1 file changed, 5 deletions(-) diff --git a/arch/m68k/include/asm/pgtable_no.h b/arch/m68k/include/asm

Re: [PATCH 1/1] drivers: staging: vt6655: ioctl.c - missing __user annotation

2014-07-29 Thread Tobias Klauser
On 2014-07-28 at 09:58:12 +0200, Anil Belur wrote: > From: Anil Belur > > - private_ioctl() the internally calls copy_{to,from}_user() and does > not use '__user' while refrencing user space pointers. > - this patch passes __user annotation as a cast, when the pointer is > being refernced. W

Re: [PATCH] staging: dgnc: remove commented code

2014-07-29 Thread Tobias Klauser
On 2014-07-25 at 18:49:01 +0200, Seunghun Lee wrote: > This patch removes commented code in dgnc driver. > > CC: Lidza Louina > CC: Mark Hounschell > Signed-off-by: Seunghun Lee > --- > drivers/staging/dgnc/dgnc_cls.c |5 +- > drivers/staging/dgnc/dgnc_trace.c | 123 >

Re: [PATCH v2] hwmon: pwm-fan: Add pwm-fan driver

2014-07-14 Thread Tobias Klauser
On 2014-07-14 at 15:50:35 +0200, Kamil Debski wrote: > The pwm-fan driver enables control of fans connected to PWM lines. > This driver uses the PWM framework, so it is compatible with all > PWM devices that provide drivers through the PWM framework. > > Signed-off-by: Kamil Debski > --- > Chang

Re: [PATCH v9 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-07-15 Thread Tobias Klauser
On 2014-07-15 at 00:18:05 +0200, Iyappan Subramanian wrote: > This patch adds network driver for APM X-Gene SoC ethernet. > > Signed-off-by: Iyappan Subramanian > Signed-off-by: Ravi Patel > Signed-off-by: Keyur Chudgar > --- > drivers/net/ethernet/Kconfig | 1 + > dr

Re: [PATCH v2 26/29] Add ELF machine define for Nios2

2014-07-15 Thread Tobias Klauser
On 2014-07-15 at 10:45:53 +0200, Ley Foon Tan wrote: > Signed-off-by: Ley Foon Tan This should probably be sent/applied before "[PATCH v2 14/29] nios2: ELF definitions", since there EM_ALTERA_NIOS2 is already used. > --- > include/uapi/linux/elf-em.h | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH v2 00/29] nios2 Linux kernel port

2014-07-15 Thread Tobias Klauser
On 2014-07-15 at 10:45:27 +0200, Ley Foon Tan wrote: > This is the 2nd version of patchset adds the Linux kernel port for Nios II > processor from > Altera. All of the feedback from v1 patchseries has been addressed. Thanks to > all who > provided feedback on the previous version. > > About Nio

Re: [PATCH] hwmon: pwm-fan: Add pwm-fan driver

2014-07-09 Thread Tobias Klauser
On 2014-07-09 at 16:53:20 +0200, Kamil Debski wrote: > The pwm-fan driver enables control of fans connected to PWM lines. > This driver uses the PWM framework, so it is compatible with all > PWM devices that provide drivers through the PWM framework. > > Signed-off-by: Kamil Debski > --- > .../

Re: [PATCH v2 24/29] nios2: Module support

2014-07-15 Thread Tobias Klauser
On 2014-07-15 at 12:24:46 +0200, Arnd Bergmann wrote: > On Tuesday 15 July 2014 16:45:51 Ley Foon Tan wrote: > > +void *module_alloc(unsigned long size) > > +{ > > + if (size == 0) > > + return NULL; > > + return kmalloc(size, GFP_KERNEL); > > +} > > + > > +/* Free memory returned fr

Re: [PATCH v2 00/29] nios2 Linux kernel port

2014-07-15 Thread Tobias Klauser
Hi Ley Foon On 2014-07-15 at 11:38:36 +0200, Ley Foon Tan wrote: > On Tue, Jul 15, 2014 at 5:08 PM, Tobias Klauser wrote: > > > > On 2014-07-15 at 10:45:27 +0200, Ley Foon Tan wrote: > > > > > Very nice work Ley Foon! It's great to see the Nios II

Re: [PATCH v4] hwmon: pwm-fan: Add pwm-fan driver

2014-07-16 Thread Tobias Klauser
ki Looks good as for my comments. If you want you can add my Reviewed-by: Tobias Klauser -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.ht

Re: [PATCH, RFC] random: introduce getrandom(2) system call

2014-07-17 Thread Tobias Klauser
On 2014-07-17 at 11:18:15 +0200, Theodore Ts'o wrote: [...] > +/* > + * Flags for getrandom(2) > + * > + * GAND_BLOCKAllow getrandom(2) to block > + * GAND_RANDOM Use the /dev/random pool instead of /dev/urandom > + */ Very minor nitpick: These should probably read

Re: [PATCH 28/28] Documentation: Add documentation for Nios2 architecture

2014-04-22 Thread Tobias Klauser
On 2014-04-18 at 14:27:11 +0200, Ley Foon Tan wrote: > Signed-off-by: Ley Foon Tan > --- > Documentation/nios2/README | 23 +++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/nios2/README > > diff --git a/Documentation/nios2/README b/Documentation/nio

Re: [PATCH 23/28] nios2: Nios2 registers

2014-04-22 Thread Tobias Klauser
ll > +++ b/arch/nios2/include/asm/registers.h > @@ -0,0 +1,65 @@ > +/* > + * Copyright (C) 2011 Tobias Klauser > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by >

[PATCH] mailbox/omap: Use module_platform_driver

2014-07-22 Thread Tobias Klauser
Use the module_platform_driver to omit module init/exit boilerplate code. Signed-off-by: Tobias Klauser --- drivers/mailbox/mailbox-omap1.c | 13 + drivers/mailbox/mailbox-omap2.c | 13 + 2 files changed, 2 insertions(+), 24 deletions(-) diff --git a/drivers/mailbox

Re: [PATCH] mailbox/omap: Use module_platform_driver

2014-07-23 Thread Tobias Klauser
On 2014-07-22 at 17:00:44 +0200, Suman Anna wrote: > Hi Tobias, > > On 07/22/2014 07:13 AM, Tobias Klauser wrote: > > Use the module_platform_driver to omit module init/exit boilerplate code. > > > > Signed-off-by: Tobias Klauser > > --- > >

Re: [PATCH v2 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Tobias Klauser
On 2014-07-24 at 10:35:29 +0200, Nicolin Chen wrote: > The Asynchronous Sample Rate Converter (ASRC) converts the sampling rate of a > signal associated with an input clock into a signal associated with a > different > output clock. The driver currently works as a Front End of DPCM with other >

Re: [PATCH 1/1] Managed Devices devres_debugfs file system

2014-07-24 Thread Tobias Klauser
On 2014-07-24 at 17:18:01 +0200, Rob Jones wrote: > Reviewed-by: Ian Molton > Suggested-by: Ben Dooks > Signed-off-by: Rob Jones > --- > Documentation/driver-model/devres-debugfs.txt | 140 + > drivers/base/Kconfig | 18 ++ > drivers/base/devres.c

Re: [PATCH v8 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-06 Thread Tobias Klauser
On 2014-05-05 at 21:10:45 +0200, Darek Marcinkiewicz wrote: > > This driver adds support for EtherCAT master module located on CCAT > FPGA found on Beckhoff CX series industrial PCs. The driver exposes > EtherCAT master as an ethernet interface. > > EtherCAT is a fieldbus protocol defined on top

Re: [PATCH v8 1/1] Driver for Beckhoff CX5020 EtherCAT master module.

2014-05-06 Thread Tobias Klauser
On 2014-05-06 at 16:56:06 +0200, Tobias Klauser wrote: > On 2014-05-05 at 21:10:45 +0200, Darek Marcinkiewicz > wrote: > > > > This driver adds support for EtherCAT master module located on CCAT > > FPGA found on Beckhoff CX series industrial PCs. The driver exposes &

Re: [PATCH 4/4] staging: ozwpan: use kmalloc_array over kmalloc with multiply

2014-09-07 Thread Tobias Klauser
Your From: line does not contain a real name and does not match your Signed-off-by line, please check your e-mail client settings. On 2014-09-07 at 20:28:25 +0200, anicoara wrote: No changelog text? Please add a short notice, describing why this change is done. > Signed-off-by: Adrian Nicoara

Re: [PATCH 3/4] staging: ozwpan: fix redundant return in void function

2014-09-07 Thread Tobias Klauser
Your From: line does not contain a real name and does not match your Signed-off-by line, please check your e-mail client settings. On 2014-09-07 at 20:25:35 +0200, anicoara wrote: > Signed-off-by: Adrian Nicoara No changelog text? Please add a short notice, describing why this change is done.

Re: [PATCH 2/4] staging: ozwpan: fix redundant else after break or return

2014-09-07 Thread Tobias Klauser
Your From: line does not contain a real name and does not match your Signed-off-by line, please check your e-mail client settings. On 2014-09-07 at 20:24:03 +0200, anicoara wrote: > Signed-off-by: Adrian Nicoara No changelog text? Please add a short notice, describing why this change is done.

Re: [PATCH 1/4] staging: ozwpan: fix missing blank line after declaration

2014-09-07 Thread Tobias Klauser
Your From: line does not contain a real name and does not match your Signed-off-by line, please check your e-mail client settings. On 2014-09-07 at 20:21:41 +0200, anicoara wrote: Changelog text is missing. Please add a short notice, describing why this change is done. > Signed-off-by: Adrian N

Re: [PATCH v2 4/4] staging: ozwpan: use kmalloc_array over kmalloc with multiply

2014-09-09 Thread Tobias Klauser
On 2014-09-08 at 21:02:49 +0200, Adrian Nicoara wrote: > Cleanup checkpatch.pl warnings. Please state which warning this is fixing. Same goes for patches 1-3. > Signed-off-by: Adrian Nicoara > --- > > Somehow I missed the comment Tobias made on the line indentation. I fixed the > patch, and ad

Re: [PATCH v5 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-09-10 Thread Tobias Klauser
accordingly. > > Signed-off-by: Matthias Brugger All my previous review comments have been addressed. Reviewed-by: Tobias Klauser -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH v3 25/29] nios2: Module support

2014-09-10 Thread Tobias Klauser
On 2014-09-10 at 09:29:25 +0200, Chung-Lin Tang wrote: > On 14/9/10 5:25 AM, valdis.kletni...@vt.edu wrote: > > On Mon, 08 Sep 2014 17:22:36 +0800, Ley Foon Tan said: > >> This patch adds support for loadable modules. > >> > >> Signed-off-by: Ley Foon Tan > > > >> +/* > >> + * Modules should NO

Re: randconfig build error with next-20140909, in drivers/tty/serial/serial_mctrl_gpio.c

2014-09-10 Thread Tobias Klauser
On 2014-09-10 at 00:32:25 +0200, Jim Davis wrote: > Building with the attached random configuration file, > > drivers/tty/serial/serial_mctrl_gpio.c:44:6: error: redefinition of > ‘mctrl_gpio_set’ > void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl) > ^ > In file included f

[PATCH] tty: serial: serial_mctrl_gpio: Fix build error for !GPIOLIB

2014-09-10 Thread Tobias Klauser
depend on GPIOLIB as well remove the noop functions alltogether. Reported-by: Jim Davis Signed-off-by: Tobias Klauser --- drivers/tty/serial/Kconfig | 1 + drivers/tty/serial/serial_mctrl_gpio.h | 35 -- 2 files changed, 1 insertion(+), 35 deletions

  1   2   3   >