Re: Re: drm/i915: new warning (regression) in 3.7.10 and 3.8.3

2013-04-09 Thread Tomas Melin
On Mon, 18 Mar 2013 09:32:51 +0100, Daniel Vetter wrote: On Sat, Mar 16, 2013 at 01:28:50PM +0100, Richard Cochran wrote: I have an Acer Aspire One netbook, and on it I get the following warning when closing and opening the lid. I think this warning first appeared in 3.7. Does this need

Re: [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring

2013-04-10 Thread Tomas Melin
9f498da114cea3d82c291b7090d4441664d7870c Mon Sep 17 00:00:00 2001 From: Tomas Melin tomas.me...@iki.fi Date: Wed, 10 Apr 2013 18:53:42 +0300 Subject: [PATCH] applied patch --- drivers/gpu/drm/i915/intel_display.c | 36 +++--- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git

Re: [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring

2013-04-10 Thread Tomas Melin
On Wed, Apr 10, 2013 at 9:32 PM, Tomas Melin tomas.me...@iki.fi wrote: On Tue, Apr 9, 2013 at 10:51 PM, Daniel Vetter daniel.vet...@ffwll.ch wrote: v2: Try harder not to create a big patch (Chris). Tested the patch applied to 3.9-rc6. Atleast on my machine that helped, although once I managed

Re: [PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-26 Thread Tomas Melin
On Sat, Oct 25, 2014 at 12:03 PM, David Härdeman da...@hardeman.nu wrote: Wouldn't something like this be a simpler way of achieving the same result? (untested): The idea was to remove the empty change_protocol function that had been added in the breaking commit. IMHO, it would be better to not

Re: [PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-18 Thread Tomas Melin
On Thu, Oct 16, 2014 at 11:49 PM, David Härdeman da...@hardeman.nu wrote: I think this is already addressed in this thread: http://www.spinics.net/lists/linux-media/msg79865.html The patch in that thread would have broken things since the store_protocol function is not changed at the same time.

Re: [PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-19 Thread Tomas Melin
On Sat, Oct 18, 2014 at 9:18 PM, Mauro Carvalho Chehab m.che...@samsung.com wrote: The right behavior here is to enable the protocol as soon as the new keycode table is written by userspace. Except for LIRC and the protocol of the current table enabled is not a good idea because:

[PATCH 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-19 Thread Tomas Melin
change_protocol for drivers that actually have the function set up. Signed-off-by: Tomas Melin tomas.me...@iki.fi --- drivers/media/rc/rc-ir-raw.c |7 --- drivers/media/rc/rc-main.c | 19 --- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/drivers/media

[PATCH 2/2] [media] rc-core: change enabled_protocol default setting

2014-10-19 Thread Tomas Melin
Change default setting for enabled protocols. Instead of enabling all protocols, disable all except lirc during registration. Reduces overhead since all protocols not handled by default. Protocol to use will be enabled when keycode table is written by userspace. Signed-off-by: Tomas Melin

Re: [PATCH 2/2] [media] rc-core: change enabled_protocol default setting

2014-10-21 Thread Tomas Melin
On Mon, Oct 20, 2014 at 5:12 PM, David Härdeman da...@hardeman.nu wrote: On 2014-10-19 12:21, Tomas Melin wrote: Change default setting for enabled protocols. Instead of enabling all protocols, disable all except lirc during registration. Reduces overhead since all protocols not handled

[PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-21 Thread Tomas Melin
. Instead only calling change_protocol for drivers that actually have the function set up. Signed-off-by: Tomas Melin tomas.me...@iki.fi --- drivers/media/rc/rc-ir-raw.c |7 --- drivers/media/rc/rc-main.c | 19 --- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git

[PATCH v2 2/2] [media] rc-core: change enabled_protocol default setting

2014-10-21 Thread Tomas Melin
-by: Tomas Melin tomas.me...@iki.fi --- drivers/media/rc/rc-ir-raw.c |1 - drivers/media/rc/rc-main.c |6 -- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/rc/rc-ir-raw.c b/drivers/media/rc/rc-ir-raw.c index a118539..d3b1e76 100644 --- a/drivers/media/rc/rc-ir

[PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-09 Thread Tomas Melin
all protocols but the one defined by the map. Changed back to original behaviour by removing empty function change_protocol in ir-raw.c. Instead only calling change_protocol for drivers that actually have the function set up. Signed-off-by: Tomas Melin tomas.me...@iki.fi --- drivers/media/rc/rc-ir

[PATCH] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-06 Thread Tomas Melin
all protocols but the one defined by the map. Changed back to original behaviour by removing empty function change_protocol in ir-raw.c. Instead only calling change_protocol for drivers that actually have the function set up. Signed-off-by: Tomas Melin tomas.me...@iki.fi --- drivers/media/rc/rc-ir

Re: [PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-28 Thread Tomas Melin
On Tue, Oct 28, 2014 at 10:42 AM, David Härdeman da...@hardeman.nu wrote: On 2014-10-26 20:33, Tomas Melin wrote: Please let me know your preferences on which you prefer, and, if needed, I'll make a new patch version. I'd prefer the above, minimal, approach. But it's Mauro who decides

[PATCH v3] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-28 Thread Tomas Melin
-by: Tomas Melin tomas.me...@iki.fi --- drivers/media/rc/rc-ir-raw.c |1 - drivers/media/rc/rc-main.c |2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/rc/rc-ir-raw.c b/drivers/media/rc/rc-ir-raw.c index e8fff2a..b732ac6 100644 --- a/drivers/media/rc/rc-ir-raw.c

Re: Re: drm/i915: new warning (regression) in 3.7.10 and 3.8.3

2013-04-09 Thread Tomas Melin
On Mon, 18 Mar 2013 09:32:51 +0100, Daniel Vetter wrote: > > On Sat, Mar 16, 2013 at 01:28:50PM +0100, Richard Cochran wrote: >> >> I have an Acer Aspire One netbook, and on it I get the following >> warning when closing and opening the lid. I think this warning first >> appeared in 3.7. >> >>

Re: [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring

2013-04-10 Thread Tomas Melin
c Mon Sep 17 00:00:00 2001 From: Tomas Melin Date: Wed, 10 Apr 2013 18:53:42 +0300 Subject: [PATCH] applied patch --- drivers/gpu/drm/i915/intel_display.c | 36 +++--- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b

Re: [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring

2013-04-10 Thread Tomas Melin
On Wed, Apr 10, 2013 at 9:32 PM, Tomas Melin wrote: > On Tue, Apr 9, 2013 at 10:51 PM, Daniel Vetter wrote: >> v2: Try harder not to create a big patch (Chris). >> > Tested the patch applied to 3.9-rc6. Atleast on my machine that > helped, although once I man

Re: [PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-28 Thread Tomas Melin
On Tue, Oct 28, 2014 at 10:42 AM, David Härdeman wrote: > On 2014-10-26 20:33, Tomas Melin wrote: >> >> Please let me know your preferences on which you prefer, and, if >> needed, I'll make a new patch version. > > > I'd prefer the above, minimal, approach. But it's

[PATCH v3] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-28 Thread Tomas Melin
Signed-off-by: Tomas Melin --- drivers/media/rc/rc-ir-raw.c |1 - drivers/media/rc/rc-main.c |2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/rc/rc-ir-raw.c b/drivers/media/rc/rc-ir-raw.c index e8fff2a..b732ac6 100644 --- a/drivers/media/rc/rc-ir-raw.c +++

Re: [PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-18 Thread Tomas Melin
On Thu, Oct 16, 2014 at 11:49 PM, David Härdeman wrote: > I think this is already addressed in this thread: > http://www.spinics.net/lists/linux-media/msg79865.html The patch in that thread would have broken things since the store_protocol function is not changed at the same time. The patch I

Re: [PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-19 Thread Tomas Melin
On Sat, Oct 18, 2014 at 9:18 PM, Mauro Carvalho Chehab wrote: > > The right behavior here is to enable the protocol as soon as the > new keycode table is written by userspace. > > Except for LIRC and the protocol of the current table enabled is > not a good idea because: > > 1) It misread

[PATCH 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-19 Thread Tomas Melin
stead only calling change_protocol for drivers that actually have the function set up. Signed-off-by: Tomas Melin --- drivers/media/rc/rc-ir-raw.c |7 --- drivers/media/rc/rc-main.c | 19 --- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/drivers/media/rc/r

[PATCH 2/2] [media] rc-core: change enabled_protocol default setting

2014-10-19 Thread Tomas Melin
Change default setting for enabled protocols. Instead of enabling all protocols, disable all except lirc during registration. Reduces overhead since all protocols not handled by default. Protocol to use will be enabled when keycode table is written by userspace. Signed-off-by: Tomas Melin

[PATCH] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-06 Thread Tomas Melin
eneric driver, this disables all protocols but the one defined by the map. Changed back to original behaviour by removing empty function change_protocol in ir-raw.c. Instead only calling change_protocol for drivers that actually have the function set up. Signed-off-by: Tomas Melin --- drivers/media/rc/rc-ir

Re: [PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-26 Thread Tomas Melin
On Sat, Oct 25, 2014 at 12:03 PM, David Härdeman wrote: > Wouldn't something like this be a simpler way of achieving the same > result? (untested): The idea was to remove the empty change_protocol function that had been added in the breaking commit. IMHO, it would be better to not have functions

[PATCH resend] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-09 Thread Tomas Melin
eneric driver, this disables all protocols but the one defined by the map. Changed back to original behaviour by removing empty function change_protocol in ir-raw.c. Instead only calling change_protocol for drivers that actually have the function set up. Signed-off-by: Tomas Melin --- drivers/media/rc/rc-ir

Re: [PATCH 2/2] [media] rc-core: change enabled_protocol default setting

2014-10-21 Thread Tomas Melin
On Mon, Oct 20, 2014 at 5:12 PM, David Härdeman wrote: > On 2014-10-19 12:21, Tomas Melin wrote: >> >> Change default setting for enabled protocols. >> Instead of enabling all protocols, disable all except lirc during >> registration. >> Reduces overhead since all

[PATCH v2 1/2] [media] rc-core: fix protocol_change regression in ir_raw_event_register

2014-10-21 Thread Tomas Melin
n ir-raw.c. Instead only calling change_protocol for drivers that actually have the function set up. Signed-off-by: Tomas Melin --- drivers/media/rc/rc-ir-raw.c |7 --- drivers/media/rc/rc-main.c | 19 --- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/dri

[PATCH v2 2/2] [media] rc-core: change enabled_protocol default setting

2014-10-21 Thread Tomas Melin
-by: Tomas Melin --- drivers/media/rc/rc-ir-raw.c |1 - drivers/media/rc/rc-main.c |6 -- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/rc/rc-ir-raw.c b/drivers/media/rc/rc-ir-raw.c index a118539..d3b1e76 100644 --- a/drivers/media/rc/rc-ir-raw.c +++ b

Add support for Murata SCA3300 Accelerometer

2021-04-12 Thread Tomas Melin
Hi, Patch series adds driver and dt-bindings for Murata SCA3300 accelerometer. Device is a 3-axis Accelerometer with digital SPI interface. Patches are tested and based on linux-next.

[PATCH 1/2] dt-bindings: iio: accel: Add SCA3300 documentation

2021-04-12 Thread Tomas Melin
initial DT bindings for Murata SCA3300 Accelerometer. Signed-off-by: Tomas Melin --- .../bindings/iio/accel/sca3300.yaml | 51 +++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/accel/sca3300.yaml diff --git a/Documentation

[PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-12 Thread Tomas Melin
t sca3300_remove(struct spi_device *spi) +{ + struct iio_dev *indio_dev = spi_get_drvdata(spi); + + iio_triggered_buffer_cleanup(indio_dev); + return 0; +} + +static const struct of_device_id sca3300_dt_ids[] = { + { .compatible = "murata,sca3300"}, + {}, +}

Re: [PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-15 Thread Tomas Melin
On 4/12/21 2:08 PM, Jonathan Cameron wrote: On Mon, 12 Apr 2021 10:50:56 +0300 Tomas Melin wrote: Add initial support for Murata SCA3300 3-axis industrial accelerometer with digital SPI interface. This device also provides a temperature measurement. Device product page including datasheet

Re: [PATCH v2 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-19 Thread Tomas Melin
Hi Andy, Thanks for the comments. One reply below, otherwise implementing these improvements as suggested to next version. Thanks. Tomas On 4/17/21 3:39 PM, Andy Shevchenko wrote: On Fri, Apr 16, 2021 at 5:21 PM Tomas Melin wrote: Add initial support for Murata SCA3300 3-axis

Re: [PATCH v2 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-19 Thread Tomas Melin
Hi, On 4/19/21 2:14 PM, Andy Shevchenko wrote: On Mon, Apr 19, 2021 at 1:29 PM Tomas Melin wrote: On 4/17/21 3:39 PM, Andy Shevchenko wrote: On Fri, Apr 16, 2021 at 5:21 PM Tomas Melin wrote: Add initial support for Murata SCA3300 3-axis industrial accelerometer with digital SPI interface

Re: [PATCH v2 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-19 Thread Tomas Melin
On 4/19/21 3:29 PM, Andy Shevchenko wrote: On Mon, Apr 19, 2021 at 2:36 PM Tomas Melin wrote: On 4/19/21 2:14 PM, Andy Shevchenko wrote: On Mon, Apr 19, 2021 at 1:29 PM Tomas Melin wrote: On 4/17/21 3:39 PM, Andy Shevchenko wrote: On Fri, Apr 16, 2021 at 5:21 PM Tomas Melin wrote: Add

Re: [PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-19 Thread Tomas Melin
Hi, On 4/18/21 1:03 PM, Jonathan Cameron wrote: On Fri, 16 Apr 2021 15:21:14 +0300 Tomas Melin wrote: Updated email-address for Alexandru. On 4/16/21 3:17 PM, Tomas Melin wrote: On 4/15/21 11:41 AM, Tomas Melin wrote: While working on updates I did notice something new which I cannot

[PATCH v3 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-19 Thread Tomas Melin
Add initial support for Murata SCA3300 3-axis industrial accelerometer with digital SPI interface. This device also provides a temperature measurement. Datasheet: https://www.murata.com/en-global/products/sensor/accel/sca3300 Signed-off-by: Tomas Melin --- drivers/iio/accel/Kconfig | 13

[PATCH v3 0/2] iio: accel: sca3300: Accelerometer support and binding docs

2021-04-19 Thread Tomas Melin
data to buffers - Document startup sequence, providing reference to data sheet section - Convert iio_triggered_buffer_setup to devm_iio_triggered_buffer_setup, making remove() obsolete Tomas Melin (2): dt-bindings: iio: accel: Add SCA3300 documentation iio: accel: Add driver for Murata

[PATCH v3 1/2] dt-bindings: iio: accel: Add SCA3300 documentation

2021-04-19 Thread Tomas Melin
initial DT bindings for Murata SCA3300 Accelerometer. Signed-off-by: Tomas Melin --- .../bindings/iio/accel/murata,sca3300.yaml| 44 +++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/accel/murata,sca3300.yaml diff --git

Re: [PATCH v3 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-20 Thread Tomas Melin
Hi Andy, Thanks for further comments, see some answers/questions below. thanks, Tomas On 4/19/21 4:55 PM, Andy Shevchenko wrote: On Mon, Apr 19, 2021 at 4:26 PM Tomas Melin wrote: Thanks for an update, it's getting better! My comments below. Add initial support for Murata SCA3300 3-axis

Re: [PATCH v3 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-20 Thread Tomas Melin
On 4/20/21 1:47 PM, Andy Shevchenko wrote: On Tue, Apr 20, 2021 at 11:50 AM Tomas Melin wrote: + sca_data->txbuf[0] = 0x0 | (SCA3300_REG_STATUS << 2); Seems you ignored my comment. What is this 0x0? What is the meaning of it? Same for all the rest magic numbers in the cod

[PATCH v4 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-20 Thread Tomas Melin
Add initial support for Murata SCA3300 3-axis industrial accelerometer with digital SPI interface. This device also provides a temperature measurement. Datasheet: https://www.murata.com/en-global/products/sensor/accel/sca3300 Signed-off-by: Tomas Melin --- drivers/iio/accel/Kconfig | 13

[PATCH v4 1/2] dt-bindings: iio: accel: Add SCA3300 documentation

2021-04-20 Thread Tomas Melin
initial DT bindings for Murata SCA3300 Accelerometer. Signed-off-by: Tomas Melin --- .../bindings/iio/accel/murata,sca3300.yaml| 44 +++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/accel/murata,sca3300.yaml diff --git

[PATCH v4 0/2] iio: accel: sca3300: Accelerometer support and binding docs

2021-04-20 Thread Tomas Melin
as part of pushing data to buffers - Document startup sequence, providing reference to data sheet section - Convert iio_triggered_buffer_setup to devm_iio_triggered_buffer_setup, making remove() obsolete Tomas Melin (2): dt-bindings: iio: accel: Add SCA3300 documentation iio: accel: Add driver

iio: accel: sca3300: Accelerometer support and binding docs

2021-04-16 Thread Tomas Melin
Tomas Melin (2): dt-bindings: iio: accel: Add SCA3300 documentation iio: accel: Add driver for Murata SCA3300 accelerometer Documentation/devicetree/bindings/iio/accel/murata,sca3300.yaml | 44 ++ drivers/iio/accel/Kconfig

[PATCH v2 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-16 Thread Tomas Melin
[] = { + { .compatible = "murata,sca3300"}, + {}, +}; +MODULE_DEVICE_TABLE(of, sca3300_dt_ids); + +static struct spi_driver sca3300_driver = { + .driver = { + .name = SCA3300_ALIAS, + .owner = THIS_MODULE, + .of_match_table = of_match_ptr(sca3300_dt_ids), + }, + + .probe = sca3300_probe, +}; + +module_spi_driver(sca3300_driver); + +MODULE_AUTHOR("Tomas Melin "); +MODULE_DESCRIPTION("Murata SCA3300 SPI Accelerometer"); +MODULE_LICENSE("GPL v2"); -- 2.21.3

[PATCH v2 1/2] dt-bindings: iio: accel: Add SCA3300 documentation

2021-04-16 Thread Tomas Melin
Initial DT bindings for Murata SCA3300 Accelerometer. Signed-off-by: Tomas Melin --- .../bindings/iio/accel/murata,sca3300.yaml| 44 +++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/accel/murata,sca3300.yaml diff --git

Re: [PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-16 Thread Tomas Melin
Updated email-address for Alexandru. On 4/16/21 3:17 PM, Tomas Melin wrote: On 4/15/21 11:41 AM, Tomas Melin wrote: While working on updates I did notice something new which I cannot reproduce on older (5.10.17 kernel) version. If compiling this as a module, getting error while

Re: [PATCH 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer

2021-04-16 Thread Tomas Melin
On 4/15/21 11:41 AM, Tomas Melin wrote: While working on updates I did notice something new which I cannot reproduce on older (5.10.17 kernel) version. If compiling this as a module, getting error while unloading module: [   40.200084] Unable to handle kernel NULL pointer dereference