Re: [PATCH 0/2] ARM: Exynos4: Migrate to common clock framework.

2012-10-03 Thread Tomasz Figa
, using OF-based clock lookup), correct me if I'm wrong. If I'm right, since Exynos SoCs are going to be DT-only, is there really a point for adding common clock framework support for non-DT platforms (which are going to be eventually dropped anyway)? Best regards, -- Tomasz Figa Samsung Poland RD

Re: [PATCH 2/2] ARM: Exynos4: Register clocks via common clock framework

2012-10-03 Thread Tomasz Figa
to clk-exynos4.c and made static? Best regards, -- Tomasz Figa Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH 2/2] ARM: Exynos4: Register clocks via common clock framework

2012-10-03 Thread Tomasz Figa
, hsmmc), + GATECLK(exynos4-sdhci.2, hsmmc2, aclk_133, 0, + EXYNOS4_CLKGATE_IP_FSYS, 7, hsmmc), + GATECLK(exynos4-sdhci.3, hsmmc3, aclk_133, 0, + EXYNOS4_CLKGATE_IP_FSYS, 8, hsmmc), [snip] +}; Best regards, -- Tomasz Figa Samsung Poland RD Center

Re: [PATCH 2/2] ARM: Exynos4: Register clocks via common clock framework

2012-10-08 Thread Tomasz Figa
On Monday 08 of October 2012 12:04:18 Thomas Abraham wrote: Hi Tomasz, On 3 October 2012 19:40, Tomasz Figa t.f...@samsung.com wrote: Hi Chander, Thomas, I can see one more problem here. Based on the fact that sdhci-s3c driver receives only the endpoint gate clock (hsmmc

Re: [PATCH 00/20] DMA: DMA unmap fixes

2012-11-06 Thread Tomasz Figa
+- drivers/spi/spi-dw-mid.c| 4 +- include/linux/async_tx.h| 4 + include/linux/dmaengine.h | 34 ++-- 34 files changed, 446 insertions(+), 898 deletions(-) For all patches: Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards

Re: [PATCH v5 2/2] regulator: add device tree support for max8997

2012-10-09 Thread Tomasz Figa
thomas.abra...@linaro.org Acked-by: MyungJoo Ham myungjoo@samsung.com Are there any plans for merging this patch? It is a dependency of Samsung Trats board device tree support. Best regards, -- Tomasz Figa Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 0/4] DMA: PL330 fixes

2012-10-29 Thread Tomasz Figa
(-) For all four patches: Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Linux Platform -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 0/3] regulator: max8998: Add support for Device Tree

2013-04-15 Thread Tomasz Figa
Hi Mark, On Thursday 04 of April 2013 18:19:20 Tomasz Figa wrote: This series adds Device Tree support to max8998 MFD driver. First patch reworks max8998-irq driver to use IRQ domains. Second patch prepares platform data structure to ease generating it at runtime from data parsed from

[PATCH 0/2] regulator: max8952: Add support for Device Tree

2013-04-04 Thread Tomasz Figa
. Tomasz Figa (2): regulator: max8952: Separate constraints from platform data struct regulator: max8952: Add Device Tree support .../devicetree/bindings/regulator/max8952.txt | 52 +++ arch/arm/mach-exynos/mach-universal_c210.c | 27 drivers/regulator/max8952.c

[PATCH 1/2] regulator: max8952: Separate constraints from platform data struct

2013-04-04 Thread Tomasz Figa
This patch modifies platform data structure of max8952 driver to use pointer to regulator_init_data struct instead of embedding it. This is a prerequisite for adding Device Tree support for the driver. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

[PATCH 2/2] regulator: max8952: Add Device Tree support

2013-04-04 Thread Tomasz Figa
This patch adds Device Tree support to max8952 regulator driver. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/regulator/max8952.txt | 52 drivers/regulator/max8952.c

[PATCH 0/3] regulator: max8998: Add support for Device Tree

2013-04-04 Thread Tomasz Figa
documentation. Tested on Universal C210 board. Tomasz Figa (3): mfd: Add irq domain support for max8998 interrupts regulator: max8998: Use arrays for specifying voltages in platform data mfd: max8998: Add support for Device Tree Documentation/devicetree/bindings/mfd/max8998.txt | 111

[PATCH 1/3] mfd: Add irq domain support for max8998 interrupts

2013-04-04 Thread Tomasz Figa
in platform data and max8997 driver private data are removed. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/mfd/Kconfig | 1 + drivers/mfd/max8998-irq.c | 61 ++--- drivers/mfd

[PATCH 2/3] regulator: max8998: Use arrays for specifying voltages in platform data

2013-04-04 Thread Tomasz Figa
. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/mach-universal_c210.c | 8 +-- arch/arm/mach-s5pv210/mach-aquila.c| 8 +-- arch/arm/mach-s5pv210/mach-goni.c | 8 +-- drivers/regulator/max8998.c

[PATCH 3/3] mfd: max8998: Add support for Device Tree

2013-04-04 Thread Tomasz Figa
This patch adds Device Tree support to max8998 driver. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Documentation/devicetree/bindings/mfd/max8998.txt | 111 +++ drivers/mfd/max8998.c | 75

Re: [PATCH] ARM: dts: fix bad merge of display timing node to exynos5250-smdk5250.dts

2013-04-08 Thread Tomasz Figa
Hi Doug, On Monday 08 of April 2013 12:21:32 Doug Anderson wrote: Kukjin, On Mon, Apr 8, 2013 at 11:29 AM, Kukjin Kim kgene@gmail.com wrote: BTW, if any problems on current for-next, please kindly let me know. I usually try to check linux-next at least once a week, but sometimes

Re: [PATCH 17/30] pwm: samsung: repair the worst MMIO abuses

2013-04-12 Thread Tomasz Figa
that until we have a DT binding for pwm-samsung, which may require other changes in this area. Since we are already touching every MMIO accessor in this driver, let's also use the proper readl_relaxed variant rather than __raw_readl. Tomasz Figa has a set of patches to clean this up

Re: [PATCH V2] clk: Add composite clock type

2013-03-13 Thread Tomasz Figa
Hi Prashant, On Thursday 28 of February 2013 11:20:31 Stephen Warren wrote: On 02/28/2013 12:58 AM, Prashant Gaikwad wrote: On Wednesday 06 February 2013 03:36 PM, Tomasz Figa wrote: On Wednesday 06 of February 2013 08:34:32 Prashant Gaikwad wrote: On Tuesday 05 February 2013 03:45 PM

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-08 Thread Tomasz Figa
On Thursday 07 of February 2013 09:46:58 Girish KS wrote: On Thu, Feb 7, 2013 at 3:09 AM, Tomasz Figa t.f...@samsung.com wrote: Hi Girish, On Wednesday 06 of February 2013 12:12:29 Girish KS wrote: On Wed, Feb 6, 2013 at 2:26 AM, Grant Likely grant.lik...@secretlab.ca wrote

Re: [PATCH V2] clk: Add composite clock type

2013-02-05 Thread Tomasz Figa
flags); + /** * clk_register - allocate a new clock, register it and return an opaque cookie * @dev: device that is registering this clock Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Linux Platform -- To unsubscribe from this list: send the line

Re: [PATCH V2] clk: Add composite clock type

2013-02-05 Thread Tomasz Figa
clk_hw *mux_hw = composite-mux_hw; + if (!mux_hw-clk) +return -EINVAL; + Or maybe even: if (!mux_ops) This would be more self-explanatory and save one dereference. Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Linux Platform

Re: [PATCH V2] clk: Add composite clock type

2013-02-06 Thread Tomasz Figa
, This will work, but there is no harm in allocating dynamically. What is preferred? IMHO it is always better to allocate one bigger structure than several smaller if they are always needed together and one cannot exist without others. Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution

Re: [PATCH V2] clk: Add composite clock type

2013-02-06 Thread Tomasz Figa
On Wednesday 06 of February 2013 08:34:32 Prashant Gaikwad wrote: On Tuesday 05 February 2013 03:45 PM, Tomasz Figa wrote: Hi Prashant, Thank you for your patch. Please see some comments inline. On Monday 04 of February 2013 13:41:22 Prashant Gaikwad wrote: Not all clocks

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-07 Thread Tomasz Figa
to clear those bits manually (and I don't think so), you should replace this expression with 0. Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Linux Platform -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Tomasz Figa
Hi, On Thursday 24 of January 2013 19:19:57 Lars-Peter Clausen wrote: On 01/24/2013 05:12 PM, Doug Anderson wrote: Lars, Thank you for your comments / thoughts... Hi, On Thu, Jan 24, 2013 at 1:54 AM, Lars-Peter Clausen l...@metafoo.de wrote: adc: adc@12D1 {

Re: [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver

2013-01-15 Thread Tomasz Figa
Hi Vivek, On Tuesday 15 of January 2013 19:08:30 Vivek Gautam wrote: Adding OHCI device tree node for Exynos5250 along with the device base address. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Jingoo Han jg1@samsung.com Acked-by: Grant Likely

Re: [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos

2013-01-15 Thread Tomasz Figa
Hi Vivek, Don't you need also some clkdev lookup entry to make the clock available in the driver? Best regards, Tomasz On Tuesday 15 of January 2013 19:08:31 Vivek Gautam wrote: Adding necessary device clock to exynos5 needed for the DWC3 controller. Signed-off-by: Vivek Gautam

Re: [PATCH v4 4/4] ARM: Exynos5250: Enabling dwc3-exynos driver

2013-01-15 Thread Tomasz Figa
Hi Vivek, Same comment as for patch 2. Best regards, Tomasz On Tuesday 15 of January 2013 19:08:32 Vivek Gautam wrote: Adding DWC3 device tree node for Exynos5250 needed to parse device tree data. Also enabling XHCI support on exynos5250. Signed-off-by: Vivek Gautam

Re: [PATCH v5 1/4] ARM: Exynos5250: Enabling ehci-s5p driver

2013-01-15 Thread Tomasz Figa
Hi Vivek, Same comment as for patch 2. Best regards, Tomasz On Wednesday 16 of January 2013 11:15:43 Vivek Gautam wrote: Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by:

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-23 Thread Tomasz Figa
Hi Linus, On Sunday 24 of February 2013 01:16:21 Linus Walleij wrote: On Sat, Feb 23, 2013 at 6:57 PM, Heiko Stübner he...@sntech.de wrote: When pinctrl is not built the fallback functions fail silently and emit either 0 error codes or NULL pinctrl handles. Therefore it's needed to also

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-23 Thread Tomasz Figa
On Sunday 24 of February 2013 01:47:49 Linus Walleij wrote: On Sun, Feb 24, 2013 at 1:38 AM, Tomasz Figa tomasz.f...@gmail.com wrote: The driver must know whether pin control is available, because it has to fall back to legacy GPIO-based pin configuration if it is not. This means that we

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-24 Thread Tomasz Figa
On Sunday 24 of February 2013 02:01:45 Linus Walleij wrote: On Sun, Feb 24, 2013 at 1:58 AM, Tomasz Figa tomasz.f...@gmail.com wrote: [Me] Surely you know this when setting up the pdata from your machine? Cases 2) and 3) are both DT-enabled cases, where there is no pdata coming

Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle

2013-02-24 Thread Tomasz Figa
Hi, On Monday 25 of February 2013 00:16:49 Heiko Stübner wrote: Am Sonntag, 24. Februar 2013, 23:39:44 schrieb Linus Walleij: On Sun, Feb 24, 2013 at 6:00 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Note that we are talking here about a temporary solution. The legacy DT- based

Re: [PATCH v3 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-09-05 Thread Tomasz Figa
the gpio property and regulator-fixed driver uses of_get_named_gpio to get the pin number from device tree. Is this kind of setup also valid when using your pinctrl driver? Best regards, -- Tomasz Figa Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 0/3] regulator: max8997: minor updates and device tree support

2012-11-23 Thread Tomasz Figa
-regulator.txt -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html For whole series: Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards

Re: [PATCH 4/4] ODROID-X: dts: Add mshc node for ODROID-X board

2012-12-17 Thread Tomasz Figa
control bindings must be used. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/3] pinctrl: exynos: add support for Samsung's Exynos5250

2012-12-14 Thread Tomasz Figa
/majordomo-info.html Looks good. For the whole series: Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Linux Platform -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH] gpio: samsung: remove exynos_gpio_cfg

2012-12-14 Thread Tomasz Figa
making the legacy GPIO support useless, I think there is no need to extend it. Instead existing boards should be made to use the pinctrl driver. Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Linux Platform -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH RESEND] ARM: dts: Add USB host node for Exynos4

2013-08-06 Thread Tomasz Figa
; reg = 0x1340 0x1; Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH v4 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-08-06 Thread Tomasz Figa
Hi Doug, See my comment inline. On Tuesday 06 of August 2013 14:37:49 Doug Anderson wrote: If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up looping around forever. This has been seen to happen on exynos5420 silicon despite the fact that we haven't enabled any wakeup

Re: [PATCH v4 1/4] mmc: dw_mmc: Invalidate cache of current_speed after suspend/resume

2013-08-06 Thread Tomasz Figa
) continue; if (slot-mmc-pm_flags MMC_PM_KEEP_POWER) { dw_mci_set_ios(slot-mmc, slot-mmc-ios); - dw_mci_setup_bus(slot, true); } ret = mmc_resume_host(host-slot[i]-mmc); Reviewed-by: Tomasz Figa t.f

Re: [PATCH v4 3/4] mmc: dw_mmc: Always setup the bus after suspend/resume

2013-08-06 Thread Tomasz Figa
); ret = mmc_resume_host(host-slot[i]-mmc); if (ret 0) Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v4 4/4] mmc: dw_mmc: Set timeout to max upon resume

2013-08-06 Thread Tomasz Figa
| SDMMC_INT_RXDR | Not sure if we really care about register dumps, but if it gets initialized in probe as well, then this is fine. Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v4 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-08-06 Thread Tomasz Figa
On Tuesday 06 of August 2013 15:09:46 Doug Anderson wrote: Tomasz, On Tue, Aug 6, 2013 at 2:58 PM, Tomasz Figa tomasz.f...@gmail.com wrote: +static int dw_mci_exynos_resume_noirq(struct device *dev) +{ + struct dw_mci *host = dev_get_drvdata(dev); + u32 clksel

Re: [PATCH v1 03/14] clk: Add of_clk_match() for device drivers

2013-07-25 Thread Tomasz Figa
Hi Stephen, On Wednesday 24 of July 2013 17:43:31 Stephen Boyd wrote: In similar fashion as of_regulator_match() add an of_clk_match() function that finds an initializes clock init_data structs from devicetree. Drivers should use this API to find clocks that their device is providing and then

Re: [PATCH v1 02/14] clk: Add of_init_clk_data() to parse common clock bindings

2013-07-25 Thread Tomasz Figa
Hi Stephen, Pretty good idea, but I have some comments inline. On Wednesday 24 of July 2013 17:43:30 Stephen Boyd wrote: Consolidate DT parsing for the common bits of a clock binding in one place to simplify clock drivers. This also has the added benefit of standardizing how the clock names

Re: [PATCH v1 04/14] clk: Add set_rate_and_parent() op

2013-07-25 Thread Tomasz Figa
On Wednesday 24 of July 2013 17:43:32 Stephen Boyd wrote: Some of Qualcomm's clocks can change their parent and rate at the same time with a single register write. Add support for this hardware to the common clock framework by adding a new set_rate_and_parent() op. When the clock framework

Re: [PATCH v1 05/14] clk: msm: Add support for phase locked loops (PLLs)

2013-07-25 Thread Tomasz Figa
Hi Stephen, On Wednesday 24 of July 2013 17:43:33 Stephen Boyd wrote: Add support for MSM's PLLs (phase locked loops). This is sufficient enough to be able to determine the rate the PLL is running at. We can add rate setting support later when it's needed. Cc: devicet...@vger.kernel.org

Re: [PATCH v1 08/14] clk: msm: Add MSM clock driver

2013-07-25 Thread Tomasz Figa
Hi Stephen, On Wednesday 24 of July 2013 17:43:36 Stephen Boyd wrote: Add a clock driver that registers clocks from a DT node's 'clocks' child. Each new SoC will add a file describing the software interface and frequency plan to drivers/clk/msm/ and then hook that into the msm_cc_match_table

Re: [PATCH] drivers/rtc/rtc-palmas.c: support for backup battery charging

2013-07-26 Thread Tomasz Figa
On Friday 26 of July 2013 09:40:15 Stephen Warren wrote: (CC'ing the new DT binding maintainers and mailing list on this reply, hence quoting the whole of the DT binding) On 07/25/2013 06:29 AM, Laxman Dewangan wrote: Palmas series device like TPS65913, TPS80036 supports the backup

Re: [PATCH] regulator: read low power states configuration from device tree

2013-07-26 Thread Tomasz Figa
On Thursday 25 of July 2013 21:03:43 Mark Brown wrote: On Thu, Jul 25, 2013 at 12:42:00PM -0700, Vincent Palatin wrote: +- regulator-suspend-disk-microvolt: voltage applied when entering S2D +- regulator-suspend-disk-disabled: turn off when entering S2D +- regulator-suspend-mem-microvolt:

Re: [Ksummit-2013-discuss] DT bindings as ABI [was: Do we have people interested in device tree janitoring / cleanup?]

2013-07-27 Thread Tomasz Figa
On Saturday 27 of July 2013 07:04:08 Richard Cochran wrote: On Fri, Jul 26, 2013 at 08:49:43AM -0700, Olof Johansson wrote: Long term, final goal is likely to be close to what Russell is saying Why is this a long term goal? Start today. -- nothing should go into the kernel tree unless

Re: DT bindings as ABI [was: Do we have people interested in device tree janitoring / cleanup?]

2013-07-27 Thread Tomasz Figa
On Saturday 27 of July 2013 10:53:01 Richard Cochran wrote: On Fri, Jul 26, 2013 at 11:15:24AM -0600, Jason Gunthorpe wrote: On Fri, Jul 26, 2013 at 06:54:33AM +0200, Richard Cochran wrote: I too work on commercial embedded systems, and DT has proven to be one gigantic *PITA*. Why do

Re: [Ksummit-2013-discuss] DT bindings as ABI [was: Do we have people interested in device tree janitoring / cleanup?]

2013-07-27 Thread Tomasz Figa
On Saturday 27 of July 2013 12:24:24 Arend van Spriel wrote: On 07/27/2013 11:51 AM, Tomasz Figa wrote: On Saturday 27 of July 2013 07:04:08 Richard Cochran wrote: On Fri, Jul 26, 2013 at 08:49:43AM -0700, Olof Johansson wrote: Long term, final goal is likely to be close to what Russell

Re: [PATCH v8 07/12] iommu/exynos: support for device tree

2013-07-27 Thread Tomasz Figa
Hi, On Friday 26 of July 2013 20:28:36 Cho KyongHo wrote: This commit adds device tree support for System MMU. This also include the following changes and enhancements: * use managed device helper functions. Simplyfies System MMU device driver. * use only a single clock descriptor.

Re: [Ksummit-2013-discuss] DT bindings as ABI [was: Do we have people interested in device tree janitoring / cleanup?]

2013-07-27 Thread Tomasz Figa
On Saturday 27 of July 2013 20:31:01 Richard Cochran wrote: On Sat, Jul 27, 2013 at 12:24:24PM +0200, Arend van Spriel wrote: That is a nice summary of how we got from null to now and Richard seems to be simply saying: let's stop mucking about and make this a project with a well-defined

Re: [Ksummit-2013-discuss] DT bindings as ABI [was: Do we have people interested in device tree janitoring / cleanup?]

2013-07-28 Thread Tomasz Figa
On Sunday 28 of July 2013 10:56:52 Richard Cochran wrote: On Sat, Jul 27, 2013 at 11:51:06AM -0700, Tomasz Figa wrote: On Saturday 27 of July 2013 20:31:01 Richard Cochran wrote: Frankly, I am really surprised and shocked at the cavalier attitude expressed here WRT DT bindings in released

Re: How to create IRQ mappings in a GPIO driver that doesn't control its IRQ domain ?

2013-07-28 Thread Tomasz Figa
Hi Laurent, On Wednesday 24 of July 2013 01:21:44 Laurent Pinchart wrote: Hello, I'm running into an issue on several Renesas SoC with IRQ domains and GPIOs. On sh73a0, r8a73a4 and r8a7740, GPIOs and external interrupts are handled by two separate IP cores, namely the PFC (Pin Function

Re: [Ksummit-2013-discuss] DT bindings as ABI [was: Do we have people interested in device tree janitoring / cleanup?]

2013-07-28 Thread Tomasz Figa
On Sunday 28 of July 2013 15:19:03 Richard Cochran wrote: On Sun, Jul 28, 2013 at 11:12:53AM +0200, Tomasz Figa wrote: I'm not really sure what effect on users this has. Maybe you should define users. ... Care to explain this reasoning? Use Case User acquires a machine

Re: [PATCH v2] gpio: interrupt consistency check for OF GPIO IRQs

2013-08-23 Thread Tomasz Figa
On Friday 23 of August 2013 13:52:20 Stephen Warren wrote: On 08/23/2013 12:45 PM, Linus Walleij wrote: On Thu, Aug 22, 2013 at 11:10 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/21/2013 05:36 PM, Linus Walleij wrote: On Thu, Aug 22, 2013 at 1:10 AM, Stephen Warren

Re: [PATCH v3 2/2] max77693: added device tree support

2013-08-23 Thread Tomasz Figa
Hi Andrzej, On Wednesday 21 of August 2013 18:53:34 Andrzej Hajda wrote: This patch adds only of_match_table. There are no device specific properties. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH v3 2/2] max77693: added device tree support

2013-08-23 Thread Tomasz Figa
Hi Mark, On Friday 23 of August 2013 15:14:33 Mark Rutland wrote: On Wed, Aug 21, 2013 at 05:53:34PM +0100, Andrzej Hajda wrote: This patch adds only of_match_table. There are no device specific properties. Could you clarify what functionality this enables and what it doesn't, please?

[PATCH v2 12/18] ARM: s3c64xx: Add support for DMA using generic amba-pl08x driver

2013-08-23 Thread Tomasz Figa
through DMA resource, casted to unsigned long, but this is how Samsung DMA wrappers (used to support both s3c-dma and DMA engine in drivers) are designed. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/Kconfig | 1 + arch/arm/mach-s3c64xx/Kconfig

Re: [PATCH v2 3/3] gpio: pcf857x: Add OF support

2013-08-23 Thread Tomasz Figa
Hi Laurent, On Tuesday 20 of August 2013 01:04:54 Laurent Pinchart wrote: Add DT bindings for the pcf857x-compatible chips and parse the device tree node in the driver. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com ---

Re: [PATCH v2 3/3] gpio: pcf857x: Add OF support

2013-08-24 Thread Tomasz Figa
On Saturday 24 of August 2013 02:54:07 Laurent Pinchart wrote: Hi Tomasz, Thank you for the review. On Saturday 24 August 2013 02:41:59 Tomasz Figa wrote: On Tuesday 20 of August 2013 01:04:54 Laurent Pinchart wrote: Add DT bindings for the pcf857x-compatible chips and parse

Re: [PATCH v5] gpio: pcf857x: Add OF support

2013-08-27 Thread Tomasz Figa
Hi Laurent, On Tuesday 27 of August 2013 10:02:39 Laurent Pinchart wrote: Add DT bindings for the pcf857x-compatible chips and parse the device tree node in the driver. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com ---

Re: [PATCH v5] gpio: pcf857x: Add OF support

2013-08-27 Thread Tomasz Figa
On Tuesday 27 of August 2013 14:00:24 Archit Taneja wrote: Hi, On Tuesday 27 August 2013 01:44 PM, Tomasz Figa wrote: Hi Laurent, On Tuesday 27 of August 2013 10:02:39 Laurent Pinchart wrote: Add DT bindings for the pcf857x-compatible chips and parse the device tree node

Re: [PATCH 1/4] pinctrl: Add s5pv210 support to pinctrl-exynos

2013-08-27 Thread Tomasz Figa
Hi Mateusz, Is this a series of 4 patches? Apparently I have received only this one. On Tuesday 27 of August 2013 11:19:31 Mateusz Krawczuk wrote: This patch implements pinctrl for s5pv210 and adds required device tree bindings. This should be wrapped to have lines shorter than 80 characters.

Re: [PATCH 1/4] pinctrl: Add s5pv210 support to pinctrl-exynos

2013-08-27 Thread Tomasz Figa
Hi Sylwester, On Tuesday 27 of August 2013 11:30:09 Sylwester Nawrocki wrote: Hi, Just a few nits... On 08/27/2013 11:19 AM, Mateusz Krawczuk wrote: This patch implements pinctrl for s5pv210 and adds required device tree bindings. Would be good to wrap this to not exceed 80 columns.

Re: [Patch v2] pinctrl: Add s5pv210 support to pinctrl-exynos

2013-08-27 Thread Tomasz Figa
deletions(-) Acked-by: Tomasz Figa t.f...@samsung.com As a side note, please write the PATCH keyword in the topic in upper case next time. Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 09/18] ASoC: Samsung: Do not queue cyclic buffers multiple times

2013-08-28 Thread Tomasz Figa
On Wednesday 28 of August 2013 09:06:27 Linus Walleij wrote: On Sun, Aug 11, 2013 at 7:59 PM, Tomasz Figa tomasz.f...@gmail.com wrote: The legacy S3C-DMA API required every period of a cyclic buffer to be queued separately. After conversion of Samsung ASoC to Samsung DMA wrappers somebody

Re: [Patch v2] pinctrl: Add s5pv210 support to pinctrl-exynos

2013-08-28 Thread Tomasz Figa
On Wednesday 28 of August 2013 14:51:44 Linus Walleij wrote: On Tue, Aug 27, 2013 at 3:08 PM, Mateusz Krawczuk m.krawc...@partner.samsung.com wrote: This patch implements pinctrl support and adds device tree bindings for s5pv210. Signed-off-by: Mateusz Krawczuk

Re: [PATCH v2 2/4] dmaengine: add driver for Samsung s3c24xx SoCs

2013-08-19 Thread Tomasz Figa
On Monday 19 of August 2013 10:18:12 Vinod Koul wrote: On Wed, Aug 14, 2013 at 02:00:25PM +0200, Heiko Stübner wrote: This adds a new driver to support the s3c24xx dma using the dmaengine and makes the old one in mach-s3c24xx obsolete in the long run. Conceptually the s3c24xx-dma feels

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-21 Thread Tomasz Figa
Hi Xiubo, Please see my comments inline. On Wednesday 21 of August 2013 11:07:42 Xiubo Li wrote: Signed-off-by: Xiubo Li li.xi...@freescale.com --- .../devicetree/bindings/pwm/fsl-ftm-pwm.txt| 52 ++ 1 file changed, 52 insertions(+) create mode 100644

Re: [PATCH v2] gpio: interrupt consistency check for OF GPIO IRQs

2013-08-21 Thread Tomasz Figa
Hi Lars, Linus, On Wednesday 21 of August 2013 15:38:54 Lars Poeschel wrote: From: Linus Walleij linus.wall...@linaro.org Currently the kernel is ambigously treating GPIOs and interrupts from a GPIO controller: GPIOs and interrupts are treated as orthogonal. This unfortunately makes it

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-22 Thread Tomasz Figa
On Thursday 22 of August 2013 02:55:42 Xiubo Li-B47053 wrote: Hi Tomasz, Thanks for your comments. +- #pwm-cells: Should be 3. Number of cells being used to specify PWM property. + First cell specifies the per-chip channel index of the PWM to use, the + second cell is the

Re: [PATCH 4/4] Documentation: Add device tree bindings for Freescale FTM PWM

2013-08-22 Thread Tomasz Figa
On Thursday 22 of August 2013 09:52:42 Xiubo Li-B47053 wrote: Hi Tomasz, If the meaning of flags cell is the same as in generic, default PWM specifier format, then it should be noted here and generic PWM binding documentation mentioned. OK, How about the following ? -

Re: [PATCH v2] gpio: interrupt consistency check for OF GPIO IRQs

2013-08-22 Thread Tomasz Figa
On Thursday 22 of August 2013 15:08:12 Stephen Warren wrote: On 08/22/2013 03:01 AM, Lars Poeschel wrote: On Thursday 22 August 2013 at 01:10:27, Stephen Warren wrote: On 08/21/2013 03:49 PM, Tomasz Figa wrote: diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-08-13 Thread Tomasz Figa
On Tuesday 13 of August 2013 16:14:44 Kishon Vijay Abraham I wrote: Hi, On Wednesday 31 July 2013 11:45 AM, Felipe Balbi wrote: Hi, On Wed, Jul 31, 2013 at 11:14:32AM +0530, Kishon Vijay Abraham I wrote: IMHO we need a lookup method for PHYs, just like for clocks, regulators, PWMs

Re: [PATCH 12/18] ARM: s3c64xx: Add support for DMA using generic amba-pl08x driver

2013-08-13 Thread Tomasz Figa
On Tuesday 13 of August 2013 18:52:51 Mark Brown wrote: On Sun, Aug 11, 2013 at 07:59:24PM +0200, Tomasz Figa wrote: +#define pl330_filter pl08x_filter_id So, this is pretty fun and probably not going to play too nicely for multiplatform kernels... Yes, this is really funny and only shows

Re: [PATCH 10/18] spi: s3c64xx: Do not require legacy DMA API in case of S3C64XX

2013-08-13 Thread Tomasz Figa
On Tuesday 13 of August 2013 21:18:16 Mark Brown wrote: On Tue, Aug 13, 2013 at 07:55:47PM +0100, Mark Brown wrote: I'm still debugging what's going on here - the basic refcounting all looks OK in the SPI driver, I can see it requesting and releasing with the refcounts all going back to

Re: [PATCH 12/18] ARM: s3c64xx: Add support for DMA using generic amba-pl08x driver

2013-08-13 Thread Tomasz Figa
On Tuesday 13 of August 2013 21:35:36 Mark Brown wrote: On Tue, Aug 13, 2013 at 01:10:02PM -0700, Tomasz Figa wrote: On Tuesday 13 of August 2013 18:52:51 Mark Brown wrote: On Sun, Aug 11, 2013 at 07:59:24PM +0200, Tomasz Figa wrote: +#define pl330_filter pl08x_filter_id So

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-08-13 Thread Tomasz Figa
On Wednesday 14 of August 2013 00:19:28 Sylwester Nawrocki wrote: W dniu 2013-08-13 14:05, Kishon Vijay Abraham I pisze: On Tuesday 13 August 2013 05:07 PM, Tomasz Figa wrote: On Tuesday 13 of August 2013 16:14:44 Kishon Vijay Abraham I wrote: On Wednesday 31 July 2013 11:45 AM, Felipe

Re: [PATCH v2] RFC: interrupt consistency check for OF GPIO IRQs

2013-08-15 Thread Tomasz Figa
Hi Lars, Linus, On Tuesday 13 of August 2013 11:46:35 Lars Poeschel wrote: From: Linus Walleij linus.wall...@linaro.org Currently the kernel is ambigously treating GPIOs and interrupts from a GPIO controller: GPIOs and interrupts are treated as orthogonal. This unfortunately makes it

Re: [PATCH v3 01/16] of: add support for retrieving cpu node for a given logical cpu index

2013-08-15 Thread Tomasz Figa
Hi Sudeep, I don't like this constant DT parsing every time a node of given CPU is required, but I believe it was correctly discussed with people that are more into CPU topologies and similar things than me. (My idea would be to make a lookup array with logical ID to struct device_node *

Re: [PATCH v3 03/16] driver/core: cpu: initialize of_node in cpu's device struture

2013-08-15 Thread Tomasz Figa
Hi Sudeep, On Monday 22 of July 2013 12:32:14 Sudeep KarkadaNagesha wrote: From: Sudeep KarkadaNagesha sudeep.karkadanage...@arm.com CPUs are also registered as devices but the of_node in these cpu devices are not initialized. Currently different drivers requiring to access cpu device node

Re: [PATCH 00/18] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-08-15 Thread Tomasz Figa
Hi, [Ccing maintainers and other people responsible for spear, lpc32xx and versatile platforms] On Sunday 11 of August 2013 19:59:12 Tomasz Figa wrote: This is first non-RFC version of my patches extending support of amba-pl08x DMA engine driver to PL080S DMA engine (PL080 modified

Re: [PATCH v2] RFC: interrupt consistency check for OF GPIO IRQs

2013-08-15 Thread Tomasz Figa
On Thursday 15 of August 2013 14:12:43 Lars Poeschel wrote: On Thursday 15 August 2013 at 11:53:15, Tomasz Figa wrote: Hi Lars, Linus, On Tuesday 13 of August 2013 11:46:35 Lars Poeschel wrote: From: Linus Walleij linus.wall...@linaro.org Currently the kernel is ambigously

Re: [PATCH v2] RFC: interrupt consistency check for OF GPIO IRQs

2013-08-17 Thread Tomasz Figa
[Ccing DT maintainers, as they may have some ideas as well] On Saturday 17 of August 2013 02:16:11 Linus Walleij wrote: On Thu, Aug 15, 2013 at 11:53 AM, Tomasz Figa tomasz.f...@gmail.com wrote: + /* Check if we have an IRQ parent, else continue */ + irq_parent

Re: [RFC 2/4] driver core: Allow early registration of devices

2013-08-17 Thread Tomasz Figa
On Friday 16 of August 2013 23:20:55 Grant Likely wrote: On Fri, Aug 16, 2013 at 10:55 PM, Thierry Reding thierry.red...@gmail.com wrote: On Fri, Aug 16, 2013 at 02:06:37PM -0700, Greg Kroah-Hartman wrote: On Fri, Aug 16, 2013 at 10:39:21PM +0200, Thierry Reding wrote: +static

Re: [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures

2013-08-17 Thread Tomasz Figa
Hi Sudeep, This looks good to me overall, but I have one more question inline. On Friday 16 of August 2013 18:39:50 Sudeep KarkadaNagesha wrote: From: Sudeep KarkadaNagesha sudeep.karkadanage...@arm.com Currently different drivers requiring to access cpu device node are parsing the device

Re: [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures

2013-08-17 Thread Tomasz Figa
On Sunday 18 of August 2013 08:09:36 Benjamin Herrenschmidt wrote: On Sat, 2013-08-17 at 12:50 +0200, Tomasz Figa wrote: I wonder how would this handle uniprocessor ARM (pre-v7) cores, for which the updated bindings[1] define #address-cells = 0 and so no reg property. [1] - http

Re: [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree

2013-07-12 Thread Tomasz Figa
the host-side HSIC initialization is also there already. I think if you think of it as reset whatever is on the other side of this PHY, it's okay to put it as an optional feature into the PHY driver. CC'ed Tomasz Figa, Dongjin Kim, Yulgon Kim Hi Tomasz, Dongjin, Julius Werner wants

[PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-18 Thread Tomasz Figa
SoCs on which currently offlining CPUs 2 or 3 caused CPU 1 to be turned off. In addition, bring-up of CPU 2 and 3 is fixed on boards where bootloader powers off secondary cores by default. Cc: sta...@vger.kernel.org Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-18 Thread Tomasz Figa
Ccing Arnd and Olof, because I forgot to add them to git send-email... Sorry for the noise. On Tuesday 18 of June 2013 17:26:31 Tomasz Figa wrote: S5P_ARM_CORE1_* registers affect only core 1. To control further cores properly another registers must be used. This patch replaces

Re: [PATCH 2/2] clk: exynos4: Add alias for cpufreq related clocks

2013-06-19 Thread Tomasz Figa
Hi Tushar, On Wednesday 19 of June 2013 10:20:14 Tushar Behera wrote: On 06/17/2013 10:20 AM, Tushar Behera wrote: On 06/11/2013 12:23 AM, Tomasz Figa wrote: On Monday 10 of June 2013 09:13:11 Tushar Behera wrote: On 06/08/2013 05:20 PM, Tomasz Figa wrote: On Thursday 06 of June 2013 16

Re: [PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-19 Thread Tomasz Figa
On Wednesday 19 of June 2013 17:39:21 Chander Kashyap wrote: On 18 June 2013 23:29, Kukjin Kim kgene@samsung.com wrote: On 06/19/13 02:45, Tomasz Figa wrote: Ccing Arnd and Olof, because I forgot to add them to git send-email... Sorry for the noise. On Tuesday 18 of June 2013 17

Re: [PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-19 Thread Tomasz Figa
On Wednesday 19 of June 2013 14:24:17 Lorenzo Pieralisi wrote: On Wed, Jun 19, 2013 at 01:50:57PM +0100, Tomasz Figa wrote: On Wednesday 19 of June 2013 17:39:21 Chander Kashyap wrote: On 18 June 2013 23:29, Kukjin Kim kgene@samsung.com wrote: On 06/19/13 02:45, Tomasz Figa wrote

Re: [PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-19 Thread Tomasz Figa
On Wednesday 19 of June 2013 19:25:27 Chander Kashyap wrote: On 19 June 2013 19:19, Tomasz Figa t.f...@samsung.com wrote: On Wednesday 19 of June 2013 14:24:17 Lorenzo Pieralisi wrote: On Wed, Jun 19, 2013 at 01:50:57PM +0100, Tomasz Figa wrote: On Wednesday 19 of June 2013 17:39:21

Re: [PATCH] ARM: EXYNOS: Fix incorrect usage of S5P_ARM_CORE1_* registers

2013-06-19 Thread Tomasz Figa
On Wednesday 19 of June 2013 20:26:50 Chander Kashyap wrote: On 19 June 2013 19:58, Tomasz Figa t.f...@samsung.com wrote: On Wednesday 19 of June 2013 19:25:27 Chander Kashyap wrote: On 19 June 2013 19:19, Tomasz Figa t.f...@samsung.com wrote: On Wednesday 19 of June 2013 14:24:17 Lorenzo

  1   2   3   4   5   6   7   8   9   10   >