[BISECTED] Re: psmouse.c: GlidePoint at isa0060/serio1/input0 lost sync at byte 1

2008-01-07 Thread Vegard Nossum
Hi, On Nov 14, 2007 9:26 PM, Vegard Nossum [EMAIL PROTECTED] wrote: Hello, With 2.6.23 kernel, the laptop middle button worked fine. With 2.6.24-rc1, when I press the middle button, the cursor jumps around the screen and this appears in the kernel log (for each time I press the button

Re: [PATCH] Include header required for INT_MAX

2007-11-12 Thread Vegard Nossum
On Nov 12, 2007 1:06 PM, Andreas Schwab [EMAIL PROTECTED] wrote: Robert P. J. Day [EMAIL PROTECTED] writes: On Mon, 12 Nov 2007, Andreas Schwab wrote: Jan Engelhardt [EMAIL PROTECTED] writes: No, because I be damn sure that some developers try compiling programs in non-linux

psmouse.c: GlidePoint at isa0060/serio1/input0 lost sync at byte 1

2007-11-14 Thread Vegard Nossum
: PS/2 mouse device common for all mice input: ImPS/2 Generic Wheel Mouse as /class/input/input2 It seems that the driver used is different. What can I do to fix this? Kind regards, Vegard Nossum - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)

2007-11-29 Thread Vegard Nossum
Hi, On Nov 29, 2007 9:02 AM, Pekka Enberg [EMAIL PROTECTED] wrote: Hi Vegard, On Nov 27, 2007 5:16 PM, Vegard Nossum [EMAIL PROTECTED] wrote: +config KMEMCHECK + bool Trap use of uninitialized memory + depends on X86_32 !CC_OPTIMIZE_FOR_SIZE + help

Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)

2007-11-29 Thread Vegard Nossum
() and GFP_ZERO mark the memory area as initialized to avoid some page faults. On Thu, 29 Nov 2007, Vegard Nossum wrote: Yes, we are in fact only tracking the memory within SLUB allocations (minus what SLUB itself needs for bookkeeping -- like the caches). Yeah but you didn't answer my question: why

Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)

2007-11-29 Thread Vegard Nossum
On 29 Nov 2007 11:29:48 +0100, Andi Kleen [EMAIL PROTECTED] wrote: Vegard Nossum [EMAIL PROTECTED] writes: - We properly flush TLB entries that change. This used to not be the case, and so we For low values of properly @) + pte = lookup_address(addr); + change_page_attr(page

Re: [BUG 2.6.24-rc3-git6] SLUB's ksize() fails for size 2048.

2007-12-02 Thread Vegard Nossum
On Dec 2, 2007 11:39 AM, Tetsuo Handa [EMAIL PROTECTED] wrote: Hello. I can't pass memory allocated by kmalloc() to ksize() if it is allocated by SLUB allocator and size is larger than (I guess) PAGE_SIZE / 2. Regards. Take a look at mm/slub.c around line 2560, in __kmalloc: if

Re: [BUG 2.6.24-rc3-git6] SLUB's ksize() fails for size 2048.

2007-12-02 Thread Vegard Nossum
On Dec 2, 2007 5:30 PM, Vegard Nossum [EMAIL PROTECTED] wrote: On Dec 2, 2007 11:39 AM, Tetsuo Handa [EMAIL PROTECTED] wrote: Hello. I can't pass memory allocated by kmalloc() to ksize() if it is allocated by SLUB allocator and size is larger than (I guess) PAGE_SIZE / 2. Regards

[RFC][PATCH] Implement a memory checker for kernel allocations (kmemcheck)

2007-11-19 Thread Vegard Nossum
to), but that's a detail. The important thing (for now) is to get it working without any false reports. I will try to test it more myself and see if it can actually come up with something that is a real error. Kind regards, Vegard Nossum Sample output: TCP cubic registered Initializing XFRM netlink

[RFC] kmemcheck: trap uses of uninitialized memory (v2)

2007-11-27 Thread Vegard Nossum
qemu-cvs or qemu-0.9.0 with the following patch: http://lists.gnu.org/archive/html/qemu-devel/2007-03/msg00126.html In addition, you probably want to remove the -O2 entirely from the Makefile to inhibit inlining, which makes the stack traces somewhat better. Kind regards, Vegard Nossum arch

Re: [RFC] kmemcheck: trap uses of uninitialized memory (v2)

2007-11-28 Thread Vegard Nossum
Hi, On Nov 28, 2007 7:51 AM, Richard Knutsson [EMAIL PROTECTED] wrote: Vegard Nossum wrote: +static int Not 'static bool'? +page_is_tracked(struct page *page) Why not returning 'false' and 'true'? Sorry, I am not used to using bool in C :-) I will change this if bool is preferred

Re: [RESULTS] Port 0x80 I/O speed

2007-12-12 Thread Vegard Nossum
On Dec 12, 2007 8:14 PM, Rene Herman [EMAIL PROTECTED] wrote: Time varies between 0.54 microseconds and 2.50 microseconds, with most around 1.3/1.4 microseconds. Numbers 58, 59 and 60 (the ones at 2 us) I dont completely trust since similar machines are among the fastest as well. Hi. Just

Re: Check handling of kernel build output directory

2007-10-26 Thread Vegard Nossum
On 10/26/07, Markus Elfring [EMAIL PROTECTED] wrote: Hello, Two ways are mentioned in the Makefile for the Linux kernel 2.6.31.1 to specify output diretories. The description of the environment variable KBUILD_OUTPUT is missing from the file README. Aren't you supposed to use O= as

mm/slub.c warnings

2008-02-09 Thread Vegard Nossum
Hi, I get these warnings when compiling mm/slub.c in linux-2.6.git: mm/slub.c: In function 'slab_alloc': mm/slub.c:1637: warning: assignment makes pointer from integer without a cast mm/slub.c:1637: warning: assignment makes pointer from integer without a cast mm/slub.c: In function 'slab_free':

[PATCH 2/4] kmemcheck v4

2008-02-14 Thread Vegard Nossum
From 5cbf7d1cb81b4f8bb4d80c027b74cdf0f08aaaff Mon Sep 17 00:00:00 2001 From: Vegard Nossum [EMAIL PROTECTED] Date: Thu, 14 Feb 2008 19:20:51 +0100 Subject: [PATCH] kmemcheck: add the x86 hooks The hooks that we modify are: - Page fault handler (to handle kmemcheck faults) - Debug exception

[PATCH 3/4] kmemcheck v4

2008-02-14 Thread Vegard Nossum
From 4ce1c09e38b2402dc04f0246916f3c23abe8f3e1 Mon Sep 17 00:00:00 2001 From: Vegard Nossum [EMAIL PROTECTED] Date: Thu, 14 Feb 2008 19:25:39 +0100 Subject: [PATCH] kmemcheck: make SLUB use kmemcheck With kmemcheck enabled, SLUB needs to do this: 1. Request twice as much memory as would normally

[PATCH 4/4] kmemcheck v4

2008-02-14 Thread Vegard Nossum
From f65bd157b88d3ae9a75737cdff5d6f27920af43d Mon Sep 17 00:00:00 2001 From: Ingo Molnar [EMAIL PROTECTED] Date: Thu, 14 Feb 2008 20:53:42 +0100 Subject: [PATCH] kmemcheck: Fix-up (some bogus) reports Signed-off-by: Vegard Nossum [EMAIL PROTECTED] --- include/asm-generic/siginfo.h |8

[PATCH 1/4] kmemcheck v4

2008-02-14 Thread Vegard Nossum
Nossum From 0fcca4341b6b1b277d936558aa3cab0f212bad9b Mon Sep 17 00:00:00 2001 From: Vegard Nossum [EMAIL PROTECTED] Date: Thu, 14 Feb 2008 19:10:40 +0100 Subject: [PATCH] kmemcheck: add the core kmemcheck changes General description: kmemcheck is a patch to the linux kernel that detects use

Re: [PATCH 4/4] kmemcheck v4

2008-02-14 Thread Vegard Nossum
On 2/14/08, Pekka Enberg [EMAIL PROTECTED] wrote: Hi, Vegard Nossum wrote: diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 412672a..7bdb37f 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -1294,7 +1294,11 @@ static inline void

[RFC] New kernel-message logging API

2007-09-22 Thread Vegard Nossum
After recent discussions on LKML and a general dissatisfaction at the current printk() kernel-message logging interface, I've decided to write down some of the ideas for a better system. Requirements * Backwards compatibility with printk(), syslog(), etc. There is no way the whole

Re: [RFC] New kernel-message logging API

2007-09-23 Thread Vegard Nossum
On 9/23/07, Joe Perches [EMAIL PROTECTED] wrote: On Sat, 2007-09-22 at 21:27 +0200, Vegard Nossum wrote: #define kprint(fmt, ...) Good ideas. Perhaps a prefix of klog or kp_ instead? Given the number of 80 column zealots, character naming length matters. I don't know. Compare the following

Re: [RFC] New kernel-message logging API

2007-09-23 Thread Vegard Nossum
On 9/23/07, Jan Engelhardt [EMAIL PROTECTED] wrote: On Sep 23 2007 10:39, Vegard Nossum wrote: On 9/23/07, Joe Perches [EMAIL PROTECTED] wrote: On Sat, 2007-09-22 at 21:27 +0200, Vegard Nossum wrote: #define kprint(fmt, ...) Good ideas. Perhaps a prefix of klog or kp_ instead? Given

Re: [RFC] New kernel-message logging API

2007-09-24 Thread Vegard Nossum
On 9/24/07, Joe Perches [EMAIL PROTECTED] wrote: On Mon, 2007-09-24 at 11:22 +0200, Michael Holzheu wrote: Together with the idea of not allowing multiple lines in the kprint_xxx functions, that would go with our approach having message numbers to identify a message. How does this

Re: [RFC] New kernel-message logging API

2007-09-24 Thread Vegard Nossum
On 9/24/07, Joe Perches [EMAIL PROTECTED] wrote: On Mon, 2007-09-24 at 18:43 +0200, Vegard Nossum wrote: Storing the format-string separately allows us to hash THAT instead of the formatted (ie. console output) message. Since this will never change from message to message, it can be looked

Re: [RFC] New kernel-message logging API

2007-09-24 Thread Vegard Nossum
On 9/23/07, Miguel Ojeda [EMAIL PROTECTED] wrote: Nice. I would suggest having some kind of standard way to show the information on the screen/dmesg. I mean, instead of having plain lines being written to the log, having something very short like: Thanks for the idea. Is this something you

Re: [RFC] New kernel-message logging API

2007-09-25 Thread Vegard Nossum
On 9/25/07, Joe Perches [EMAIL PROTECTED] wrote: On Tue, 2007-09-25 at 00:58 -0400, [EMAIL PROTECTED] wrote: Even the kp_ prefix is actually pretty unnecessary. It's info and a human-readable string that make it recognizable as a log message. While I agree a prefix isn't necessary, info,

[RFC] New kernel-message logging API (take 2)

2007-09-27 Thread Vegard Nossum
://lkml.org/lkml/2007/6/13/146 (Michael Holzheu) [5] http://lkml.org/lkml/2007/9/24/320 (Jesse Barnes) [6] http://lkml.org/lkml/2007/9/22/162 (Miguel Ojeda) [7] http://lkml.org/lkml/2007/9/25/62 (Vegard Nossum) [8] http://lkml.org/lkml/2007/9/22/157 (Joe Perches) - To unsubscribe from this list: send

Re: [RFC] New kernel-message logging API (take 2)

2007-09-28 Thread Vegard Nossum
On 9/28/07, Jan Engelhardt [EMAIL PROTECTED] wrote: On Sep 27 2007 23:18, Vegard Nossum wrote: * kprint_level() is better than kprint(level), ) because in the case of the default log-level, the argument can be omitted. * Memory allocated for entries and arguments is done in a ring

Re: [RFC] New kernel-message logging API (take 2)

2007-09-28 Thread Vegard Nossum
On 9/28/07, Miguel Ojeda [EMAIL PROTECTED] wrote: On 9/28/07, Vegard Nossum [EMAIL PROTECTED] wrote: reason we can't use KBUILD_MODNAME is that this is defined on the command line. The declaration inside the header would thus be horribly wrong. We can, however, use KBUILD_MODNAME

Re: [RFC] New kernel-message logging API (take 2)

2007-09-28 Thread Vegard Nossum
On 9/27/07, Vegard Nossum [EMAIL PROTECTED] wrote: * Use SUBSYSTEM and KBUILD_MODNAME snip. 2.1.5. Subsystem/driver tags Many parts of the kernel already prefix their log messages with a subsystem and/or driver tag to identify the source of a particular message. With the kprint

Re: [RFC] New kernel-message logging API (take 2)

2007-09-28 Thread Vegard Nossum
On 9/28/07, Kyle Moffett [EMAIL PROTECTED] wrote: On Sep 28, 2007, at 03:31:11, Geert Uytterhoeven wrote: Can't you store the loglevel in the kprint_block and check it in all successive kprint_*() macros? If gcc knows it's constant, it can optimize the non-wanted code away. As other fields

Re: [RFC] New kernel-message logging API (take 2)

2007-09-28 Thread Vegard Nossum
If-blocks spanning macros are really dangerous! E.g. an Ethernet driver may want to do: kprint_block(block, MAC ); for (i = 0; i 6; i++) { card-mac[i] = obtain_mac_byte_from_hw(i); kprint_block(block, %02x, card-mac[i]); } This

Re: [RFC] New kernel-message logging API (take 2)

2007-09-28 Thread Vegard Nossum
On 9/28/07, Rob Landley [EMAIL PROTECTED] wrote: On Friday 28 September 2007 7:11:03 am Vegard Nossum wrote: wrong. We can, however, use KBUILD_MODNAME as a default value for KPRINT_DRIVER, like: static const char *KPRINT_DRIVER = KBUILD_MODNAME; which would pre-process to something like

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-05 Thread Vegard Nossum
On 10/5/07, Rob Landley [EMAIL PROTECTED] wrote: On Thursday 04 October 2007 3:17:03 pm Randy Dunlap wrote: On Thu, 04 Oct 2007 22:04:07 +0200 Vegard Nossum wrote: Description: This patch largely implements the kprint API as previously posted to the LKML and described in Documentation

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-06 Thread Vegard Nossum
On 10/5/07, Rob Landley [EMAIL PROTECTED] wrote: The original idea (selectively compile out printk() instances based on log level to conserve space) is explicitly not addressed by this patch, and in fact this patch might actually make it harder to implement (by complicating the code). This is

Re: [RFC][PATCH] New message-logging API (kprint)

2007-10-08 Thread Vegard Nossum
On 10/8/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Sun, 7 Oct 2007 16:50:49 -0500 Rob Landley [EMAIL PROTECTED] wrote: On Saturday 06 October 2007 1:10:26 am Vegard Nossum wrote: On 10/5/07, Rob Landley [EMAIL PROTECTED] wrote: I made it about halfway through the patch

[RFC][PATCH] Escaping the arguments of kernel messages for sane user-space localisation

2007-10-08 Thread Vegard Nossum
Alan, I send here the simplified patch to emit log messages with markers for the message arguments, as per your suggestion. Do you still think this is over-kill? The rigour exists in order to preserve the generality of snprintf(), instead of changing it to include printk-specific code, which in

Re: [RFC][PATCH] Escaping the arguments of kernel messages for sane user-space localisation

2007-10-09 Thread Vegard Nossum
Hello again, On Mon, 2007-10-08 at 21:45 +0200, Vegard Nossum wrote: These functions make it quite easy to make snprintf() automatically escape certain characters in string arguments, for example. I think they are also well suited to printing to variable-sized buffers, though the last time I

[PATCH] init: Fix printk format strings

2007-10-11 Thread Vegard Nossum
This makes sure printk format strings are string literals containing no more than a single line. Signed-off-by: Vegard Nossum [EMAIL PROTECTED] --- init/calibrate.c|4 +++- init/do_mounts_initrd.c |5 - init/main.c |2 +- 3 files changed, 8 insertions(+), 3

[PATCH] Fix printk format strings

2007-10-11 Thread Vegard Nossum
This makes sure printk format strings contain no more than a single line. Signed-off-by: Vegard Nossum [EMAIL PROTECTED] --- kernel/time/timer_list.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c index fdb2e03

[PATCH] mm: Fix printk format strings

2007-10-11 Thread Vegard Nossum
This makes sure printk format strings contain no more than a single line. Signed-off-by: Vegard Nossum [EMAIL PROTECTED] --- mm/page_alloc.c | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 1a8c595..96f0b33

Re: [PATCH] mm: Fix printk format strings

2007-10-11 Thread Vegard Nossum
On 10/11/07, Andrew Morton [EMAIL PROTECTED] wrote: On Thu, 11 Oct 2007 08:47:01 +0200 Vegard Nossum [EMAIL PROTECTED] wrote: This makes sure printk format strings contain no more than a single line. Signed-off-by: Vegard Nossum [EMAIL PROTECTED] --- mm/page_alloc.c | 20

Re: [PATCH] mm: Fix printk format strings

2007-10-11 Thread Vegard Nossum
On 10/11/07, Andrew Morton [EMAIL PROTECTED] wrote: On Thu, 11 Oct 2007 09:04:57 +0200 Vegard Nossum [EMAIL PROTECTED] wrote: - printk(Active:%lu inactive:%lu dirty:%lu writeback:%lu unstable:%lu\n - free:%lu slab:%lu mapped:%lu pagetables:%lu bounce:%lu\n

[PATCH] FAT: Fix printk format strings.

2007-10-11 Thread Vegard Nossum
This makes sure printk format strings contain no more than a single line. Signed-off-by: Vegard Nossum [EMAIL PROTECTED] --- fs/fat/inode.c |3 ++- fs/fat/misc.c |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 4baa5f2..06a1bd9

Re: [PATCH] init: Fix printk format strings

2007-10-11 Thread Vegard Nossum
On 10/11/07, Randy Dunlap [EMAIL PROTECTED] wrote: On Thu, 11 Oct 2007 08:17:02 +0200 Vegard Nossum wrote: This makes sure printk format strings are string literals containing no more than a single line. Each patch needs justification (unless it is blatantly obvious). Signed-off

Re: [PATCH] init: Fix printk format strings

2007-10-11 Thread Vegard Nossum
On 10/11/07, Randy Dunlap [EMAIL PROTECTED] wrote: On Thu, 11 Oct 2007 17:55:16 +0200 Vegard Nossum wrote: On 10/11/07, Randy Dunlap [EMAIL PROTECTED] wrote: On Thu, 11 Oct 2007 08:17:02 +0200 Vegard Nossum wrote: This makes sure printk format strings are string literals containing

Re: [PATCH] init: Fix printk format strings

2007-10-11 Thread Vegard Nossum
On 10/11/07, Johannes Weiner [EMAIL PROTECTED] wrote: On Thu, Oct 11, 2007 at 08:17:02AM +0200, Vegard Nossum wrote: This makes sure printk format strings are string literals containing no more than a single line. Perhaps you should write _why_ one-line printk()s are even needed

Re: kmemcheck: Fatal error; system fails to boot when kmemcheck enabled

2012-07-13 Thread Vegard Nossum
Hi, On Fri, 13 Jul 2012 00:33:07 +0300, Sami Liedes sami.lie...@iki.fi wrote: Hi, Kernel 3.4.4 with kmemcheck enabled does not correctly boot on my system, which is a x86-64, Core i7 Sandy Bridge computer with Asus P8P67-EVO motherboard. The errors seem to be related to ACPI, but there may

Re: [PATCH] Add is_power_of_2 checking to log2.h.

2007-01-31 Thread Vegard Nossum
On Tue, January 30, 2007 3:12 pm, Jan Engelhardt wrote: Why the qualifier? Zero *is* not a power of 2, is it? No, it is not: In[1]:= Solve[2^n == 0, n] Out[1]= {} So says Mathematica5. As a side note, I would just like to point out that Mathematica does not deal with modular

Re: [PATCH 1/2] kmemcheck v3

2008-02-07 Thread Vegard Nossum
Hello, Thank you for taking the time to look at this patch! On Feb 7, 2008 10:53 PM, Christoph Lameter [EMAIL PROTECTED] wrote: On Thu, 7 Feb 2008, Vegard Nossum wrote: --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -28,6 +28,7 @@ #define SLAB_DESTROY_BY_RCU 0x0008UL

[PATCH 2/2] kmemcheck v3

2008-02-07 Thread Vegard Nossum
Applies on top of kmemcheck patch. Fixes/silences some reports of use of uninitialized memory. From: Ingo Molnar [EMAIL PROTECTED] Signed-off-by: Vegard Nossum [EMAIL PROTECTED] diff --git a/include/asm-generic/siginfo.h b/include/asm-generic/siginfo.h index 8786e01..b70cd97 100644

Re: [PATCH 1/2] kmemcheck v3

2008-02-07 Thread Vegard Nossum
approach, however, and more precise, as it gives you the exact location of the error. I hope this clears it up. Kind regards, Vegard Nossum -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 1/2] kmemcheck v3

2008-02-08 Thread Vegard Nossum
On 2/8/08, Andi Kleen [EMAIL PROTECTED] wrote: On Fri, Feb 08, 2008 at 01:18:37PM +0100, Vegard Nossum wrote: On 2/8/08, Andi Kleen [EMAIL PROTECTED] wrote: Your assumption that only the string instructions can take multiple page faults seems a little dangerous too. Yes, this is true

Re: [PATCH 1/2] kmemcheck v3

2008-02-08 Thread Vegard Nossum
, it will simply fault again and again, without making any progress. I mean, it won't go unnoticed for very long :-) This is also why we depend on M386 and !X86_GENERIC, to avoid those MMX, etc. instructions, as we have no support for those currently. Sincerely, Vegard Nossum -- To unsubscribe

Re: [BISECTED] Re: psmouse.c: GlidePoint at isa0060/serio1/input0 lost sync at byte 1

2008-01-15 Thread Vegard Nossum
Dmitry Torokhov wrote: echo 1 /sys/module/i8042/parameters/debug push and release left button push and release rigth button move finger on the touchpad a bit echo 0 /sys/module/i8042/parameters/debug dmesg dmesg.sync echo 1 /sys/module/i8042/parameters/debug push and release middle button

Re: [BISECTED] Re: psmouse.c: GlidePoint at isa0060/serio1/input0 lost sync at byte 1

2008-01-16 Thread Vegard Nossum
Hi, On Jan 16, 2008 4:42 PM, Dmitry Torokhov [EMAIL PROTECTED] wrote: Ok, how about this one to begin with? Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED] --- drivers/input/mouse/alps.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/drivers/input/mouse/alps.c

Re: [BISECTED] Re: psmouse.c: GlidePoint at isa0060/serio1/input0 lost sync at byte 1

2008-01-16 Thread Vegard Nossum
On Jan 16, 2008 8:33 PM, Dmitry Torokhov [EMAIL PROTECTED] wrote: On Wed, Jan 16, 2008 at 06:46:46PM +0100, Vegard Nossum wrote: I have now tried this patch. I don't see a sync error now, but the button still does not work as expected. Now the scroll down button acts like a middle button

lib/idr.c: initialize struct idr_layer

2008-01-27 Thread Vegard Nossum
Hi, I am testing my kmemcheck patches, and it has come up with a couple of uses of uninitialized memory in lib/idr.c. These are (the line numbers may differ slightly): line 135 (sub_alloc): bm = ~p-bitmap; p-bitmap is uninitialized line 171 (sub_alloc): if (!p-ary[m]) { p-ary is uninitialized

Re: lib/idr.c: initialize struct idr_layer

2008-01-27 Thread Vegard Nossum
On Jan 27, 2008 10:00 PM, Pekka Enberg [EMAIL PROTECTED] wrote: Hi Vegard, On Jan 27, 2008 10:07 PM, Vegard Nossum [EMAIL PROTECTED] wrote: I am testing my kmemcheck patches, and it has come up with a couple of uses of uninitialized memory in lib/idr.c. These are (the line numbers may

Re: lib/idr.c: initialize struct idr_layer

2008-01-27 Thread Vegard Nossum
On Jan 27, 2008 10:21 PM, Pekka J Enberg [EMAIL PROTECTED] wrote: On Sun, 27 Jan 2008, Vegard Nossum wrote: Though in this case, idr_pre_get() actually *is* called first. Hmm... I think there's a pretty big chance that kmemcheck is at fault :-( Depends on how you track object initialization

Re: lib/idr.c: initialize struct idr_layer

2008-01-27 Thread Vegard Nossum
On Jan 27, 2008 10:35 PM, Pekka Enberg [EMAIL PROTECTED] wrote: I think there's a pretty big chance I'm wrong (or misunderstanding something) here, so I'll just ask: setup_object() from mm/slub.c is what calls the ctor. Shouldn't this be called from slab_alloc() as well? (I'm marking the

Re: [PATCH 4/4] kmemcheck v4

2008-02-15 Thread Vegard Nossum
On Thu, Feb 14, 2008 at 10:49 PM, Andi Kleen [EMAIL PROTECTED] wrote: The ifdefs are quite ugly. I would recommend to define standard functions (kmemcheck_init_zero or similar and an own __GFP flag) that can be used without ifdef and easily nop'ed out on !KMEMCHECK kernels. Yes, they are.

make[3]: *** [sound/drivers/opl3/opl3_synth.o] Error 1

2008-02-22 Thread Vegard Nossum
Hi. make randconfig (v2.6.25-rc2 + unrelated patches) found this: CC [M] sound/drivers/opl3/opl3_synth.o sound/drivers/opl3/opl3_synth.c: In function ‘snd_opl3_find_patch’: sound/drivers/opl3/opl3_synth.c:308: error: ‘OPL3_PATCH_HASH_SIZE’ undeclared (first use in this function)

[PATCH] x86: don't save unreliable stack trace entries

2008-02-22 Thread Vegard Nossum
users of save_stack_trace() and all arches saving this information to change. Kind regards, Vegard Nossum From 5edfd896c5f0d728111df3d8cae729a375f29d3c Mon Sep 17 00:00:00 2001 From: Vegard Nossum [EMAIL PROTECTED] Date: Fri, 22 Feb 2008 19:23:58 +0100 Subject: [PATCH] x86: don't save unreliable

[PATCH] stacktrace: add reliability information to saved stack traces

2008-02-23 Thread Vegard Nossum
Hi again, This patch is different (probably better?), but touches all users and all architectures implementing stacktrace saving. If you want it, it's here... :-) Kind regards, Vegard Nossum From 98d928d337dca6326773d43da90a268e5ff0c098 Mon Sep 17 00:00:00 2001 From: Vegard Nossum [EMAIL

ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)

2008-02-23 Thread Vegard Nossum
fine. The problem also exists in 2.6.24-rc2. Kind regards, Vegard Nossum -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)

2008-02-23 Thread Vegard Nossum
On Sat, Feb 23, 2008 at 7:31 PM, Alan Cox [EMAIL PROTECTED] wrote: O I don't see the connection between (no-)smp and ata. Something with interrupt routing/IPI, missing irq ack? Booting another !SMP kernel works fine. The problem also exists in 2.6.24-rc2. Almost certainly interrupt

Re: ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4)

2008-02-23 Thread Vegard Nossum
On Sat, Feb 23, 2008 at 7:31 PM, Alan Cox [EMAIL PROTECTED] wrote: O I don't see the connection between (no-)smp and ata. Something with interrupt routing/IPI, missing irq ack? Booting another !SMP kernel works fine. The problem also exists in 2.6.24-rc2. Almost certainly interrupt

Re: compile problem in current x86.git

2008-02-25 Thread Vegard Nossum
Hello! On Mon, Feb 25, 2008 at 8:23 PM, Jeremy Fitzhardinge [EMAIL PROTECTED] wrote: CC arch/x86/kernel/traps_32.o /home/jeremy/hg/xen/paravirt/linux/arch/x86/kernel/traps_32.c:59:27: error: asm/kmemcheck.h: No such file or directory asm-x86/kmemcheck.h does seem to be completely

[PATCH] sprintf() to snprintf() and some style changes

2007-02-08 Thread Vegard Nossum
To: linux-kernel@vger.kernel.org Cc: [EMAIL PROTECTED] From: Vegard Nossum [EMAIL PROTECTED] Date: Thu Feb 8 19:57:16 2007 +0100 Subject: [PATCH] sprintf() to snprintf() and some style changes Change a few instances of sprintf() to the safer snprintf(). Nicely split lines that exceed 80 columns

Re: [PATCH] sprintf() to snprintf() and some style changes

2007-02-08 Thread Vegard Nossum
I thought my mailer wouldn't do that. :-( This one should be right. From: Vegard Nossum [EMAIL PROTECTED] Date: Thu Feb 8 19:57:16 2007 +0100 Subject: [PATCH] sprintf() to snprintf() and some style changes Change a few instances of sprintf() to the safer snprintf(). Nicely split lines

IRQ handler type mismatch for IRQ 7

2007-06-11 Thread Vegard Nossum
the two are unrelated. The full dmesg follows. Kind regards, Vegard Nossum Linux version 2.6.21-1.3194.fc7 ([EMAIL PROTECTED]) (gcc version 4.1.2 20070502 (Red Hat 4.1.2-12)) #1 SMP Wed May 23 22:47:07 EDT 2007 Command line: ro root=/dev/VolGroup00/LogVol00 rhgb quiet BIOS-provided physical RAM map

Re: IRQ handler type mismatch for IRQ 7

2007-06-11 Thread Vegard Nossum
On 6/11/07, Ingo Molnar [EMAIL PROTECTED] wrote: so both parport and serial is on the same IRQ: #7, but the parport one does not support shared interrupt lines (IRQF_SHARED). You can probably change the mapping in the BIOS (change the serial one to say IRQ#3 or IRQ#4). I suspect you dont have

Re: How to printk unsigned long long variable?

2007-06-15 Thread Vegard Nossum
On 6/15/07, jidong xiao [EMAIL PROTECTED] wrote: typedef unsigned long long u64; u64 *dma_mask; Then how to use printk() to print out a dma_mask variable? In regular printf(), this would be specified by the format %llu. Try that? Vegard - To unsubscribe from this list: send the

[PATCH] Optimize is_power_of_2().

2007-06-15 Thread Vegard Nossum
From: Vegard Nossum [EMAIL PROTECTED] Date: Fri, 15 Jun 2007 18:35:49 +0200 Subject: [PATCH] Optimize is_power_of_2(). Rationale: Removes one conditional branch and reduces icache footprint. Proof: If n is false, the product of n and any value is false. If n is true, the truth of (n * x

Re: [patch] CFS scheduler, -v18

2007-07-02 Thread Vegard Nossum
reproducible with -v18, so I suppose it must have been fixed already. Otherwise, I am satisfied with the performance of CFS. Especially the desktop is noticably smoother. Thanks! Kind regards, Vegard Nossum - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [patch] CFS scheduler, -v18

2007-07-02 Thread Vegard Nossum
On 7/2/07, Dmitry Adamushko [EMAIL PROTECTED] wrote: On 02/07/07, Vegard Nossum [EMAIL PROTECTED] wrote: I have been running cfs-v18 for a couple of days now, and today I stumbled upon a rather strange problem. Consider the following short program: while(1) printf(%ld\r, 1000

Re: [patch] CFS scheduler, -v18

2007-07-02 Thread Vegard Nossum
On 7/2/07, Ingo Molnar [EMAIL PROTECTED] wrote: thx. As an initial matter, could you double-check whether your v18 kernel source has the patch below applied already? Ingo Index: linux/kernel/sched_fair.c === ---

Re: [patch] CFS scheduler, -v18

2007-07-03 Thread Vegard Nossum
On 7/2/07, Ingo Molnar [EMAIL PROTECTED] wrote: ok. Does the xterm slowdown get any better if you do: echo 46 /proc/sys/kernel/sched_features ? The default on v18 is: echo 14 /proc/sys/kernel/sched_features No. The Ctrl-C still hangs between 1 and 3 seconds, again seemingly depending

Re: [patch] CFS scheduler, -v18

2007-07-03 Thread Vegard Nossum
On 7/3/07, Ingo Molnar [EMAIL PROTECTED] wrote: does it still get more CPU time than you'd expect it to get? A reniced or SCHED_IDLE task will 'fill in' any idle time that it senses, so in itself it's not an anomaly if a task gets 50% and FEH fills in the remaining 50%. Does it still get CPU

Re: Linux 2.6.21

2007-04-30 Thread Vegard Nossum
On Mon, April 30, 2007 8:57 pm, Adrian Bunk wrote: I never expected the reality to be come as white as my ideal or the washed things in washing powder ads. This reminds me very much of what the brilliant computing scientist Edsger W. Dijkstra more than once wrote: `Confusing love of perfection

Re: [patch] CFS scheduler, -v8

2007-05-02 Thread Vegard Nossum
On Tue, May 1, 2007 11:22 pm, Ingo Molnar wrote: As usual, any sort of feedback, bugreport, fix and suggestion is more than welcome, Hi, The sys_sched_yield_to() is not callable from userspace on i386 because it is not part of the syscall table (arch/i386/kernel/syscall_table.S). This causes

Re: kmemcheck: OS boot failed because NMI handlers access the memory tracked by kmemcheck

2014-03-17 Thread Vegard Nossum
On 03/17/2014 10:51 AM, Michal Hocko wrote: On Mon 17-03-14 17:19:33, Xishi Qiu wrote: OS boot failed when set cmdline kmemcheck=1. The reason is that NMI handlers will access the memory from kmalloc(), this will cause page fault, because memory from kmalloc() is tracked by kmemcheck.

Re: mm: OS boot failed when set command-line kmemcheck=1

2014-02-26 Thread Vegard Nossum
On 26 February 2014 09:43, Peter Zijlstra pet...@infradead.org wrote: On Wed, Feb 19, 2014 at 02:24:41PM -0800, David Rientjes wrote: On Wed, 19 Feb 2014, Xishi Qiu wrote: Here is a warning, I don't whether it is relative to my hardware. If set kmemcheck=1 nowatchdog, it can boot. code:

[PATCH] isdnloop: NUL-terminate strings from userspace

2014-03-07 Thread Vegard Nossum
(). Fixes: f9a23c84486ed35 (isdnloop: use strlcpy() instead of strcpy()) Cc: Dan Carpenter dan.carpen...@oracle.com Cc: David S. Miller da...@davemloft.net Cc: sta...@vger.kernel.org Signed-off-by: Vegard Nossum vegard.nos...@oracle.com --- drivers/isdn/isdnloop/isdnloop.c |8 1 file

Re: [PATCH] isdnloop: NUL-terminate strings from userspace

2014-03-07 Thread Vegard Nossum
On 03/07/2014 12:26 PM, Dan Carpenter wrote: On Fri, Mar 07, 2014 at 11:56:04AM +0100, Vegard Nossum wrote: Both the in-kernel and BSD strlcpy() require that the source string is NUL terminated. No. You're obviously wrong. What on earth? Well, from lib/string.c: size_t strlcpy(char *dest

Re: [PATCH] isdnloop: NUL-terminate strings from userspace

2014-03-07 Thread Vegard Nossum
On 03/07/2014 12:52 PM, Dan Carpenter wrote: On Fri, Mar 07, 2014 at 12:42:12PM +0100, Vegard Nossum wrote: On 03/07/2014 12:26 PM, Dan Carpenter wrote: On Fri, Mar 07, 2014 at 11:56:04AM +0100, Vegard Nossum wrote: Both the in-kernel and BSD strlcpy() require that the source string is NUL

Re: [PATCH] mm: add a new command-line kmemcheck value

2014-01-10 Thread Vegard Nossum
On 2 January 2014 02:34, Xishi Qiu qiuxi...@huawei.com wrote: On 2013/12/31 18:12, Vegard Nossum wrote: On 31 December 2013 09:32, Xishi Qiu qiuxi...@huawei.com wrote: Add a new command-line kmemcheck value: kmemcheck=3 (disable the feature), this is the same effect as CONFIG_KMEMCHECK

inotify cookie regression/info leak in latest mainline

2014-02-15 Thread Vegard Nossum
Hi, It would seem that commit 7053aee26a3548ebaba046ae2e52396ccf56ac6c Author: Jan Kara j...@suse.cz Date: Tue Jan 21 15:48:14 2014 -0800 fsnotify: do not share events between notification groups introduced a bug where the cookie field of struct inotify_event never gets initialised. In

ext4 info leak in creation times in latest mainline

2014-02-16 Thread Vegard Nossum
Hi, There seems to be a bug in ext4 where the i_crtime of struct ext4_inode_info is not initialised, so (some) creation times contain essentially random values. Here's a report from kmemcheck: [ 92.402035] WARNING: kmemcheck: Caught 64-bit read from uninitialized memory (8800168ab208)

[PATCH] sched: fix information leak in sys_sched_getattr()

2014-02-16 Thread vegard . nossum
From: Vegard Nossum vegard.nos...@oracle.com We're copying the on-stack structure to userspace, but forgot to give the right number of bytes to copy. This allows the calling process to obtain up to PAGE_SIZE bytes from the stack (and possibly adjacent kernel memory). This fix copies only as much

Re: inotify cookie regression/info leak in latest mainline

2014-02-17 Thread Vegard Nossum
On 02/17/2014 01:59 PM, Jan Kara wrote: Hello, On Sat 15-02-14 22:39:38, Vegard Nossum wrote: It would seem that commit 7053aee26a3548ebaba046ae2e52396ccf56ac6c Author: Jan Kara j...@suse.cz Date: Tue Jan 21 15:48:14 2014 -0800 fsnotify: do not share events between notification

Re: [PATCH V2] mm: add a new command-line kmemcheck value

2014-02-18 Thread Vegard Nossum
On 17 February 2014 03:34, Xishi Qiu qiuxi...@huawei.com wrote: If we want to debug the kernel memory, we should turn on CONFIG_KMEMCHECK and rebuild the kernel. This always takes a long time and sometimes impossible, e.g. users don't have the kernel source code or the code is different from

Re: kmemcheck: got WARNING when dynamicly adjust /proc/sys/kernel/kmemcheck to 0/1

2014-05-09 Thread Vegard Nossum
On 05/09/2014 11:52 AM, Xishi Qiu wrote: On 2014/5/9 15:57, Xishi Qiu wrote: OS boot with kmemcheck=0, then set 1, do something, set 0, do something, set 1... then I got the WARNING log. Does kmemcheck support dynamicly adjust? Thanks, Xishi Qiu [ 20.200305] igb: eth0 NIC Link is Up 1000

[PATCH 3/9] hfs: Known exploit detection for CVE-2011-4330

2013-12-12 Thread vegard . nossum
From: Vegard Nossum vegard.nos...@oracle.com See bc5b8a9003132ae44559edd63a1623b7b99dfb68. Cc: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Vegard Nossum vegard.nos...@oracle.com --- fs/hfs/trans.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/hfs

[PATCH 2/9] exploit: report to audit subsystem when available

2013-12-12 Thread vegard . nossum
From: Vegard Nossum vegard.nos...@oracle.com Signed-off-by: Vegard Nossum vegard.nos...@oracle.com --- include/uapi/linux/audit.h |1 + security/exploit.c | 16 2 files changed, 17 insertions(+) diff --git a/include/uapi/linux/audit.h b/include/uapi/linux/audit.h

[PATCH 8/9] userns: Known exploit detection for CVE-2013-1959

2013-12-12 Thread vegard . nossum
From: Vegard Nossum vegard.nos...@oracle.com See 6708075f104c3c9b04b23336bb0366ca30c3931b and e3211c120a85b792978bcb4be7b2886df18d27f0. Cc: Eric W. Biederman ebied...@xmission.com Cc: Andy Lutomirski l...@amacapital.net Signed-off-by: Vegard Nossum vegard.nos...@oracle.com --- kernel

[PATCH 6/9] x86: Known exploit detection for CVE-2013-0268

2013-12-12 Thread vegard . nossum
From: Vegard Nossum vegard.nos...@oracle.com See c903f0456bc69176912dee6dd25c6a66ee1aed00. Cc: Alan Cox a...@linux.intel.com Cc: Ingo Molnar mi...@kernel.org Signed-off-by: Vegard Nossum vegard.nos...@oracle.com --- arch/x86/kernel/msr.c |5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH 1/9] Known exploit detection

2013-12-12 Thread vegard . nossum
From: Vegard Nossum vegard.nos...@oracle.com The idea is simple -- since different kernel versions are vulnerable to different root exploits, hackers most likely try multiple exploits before they actually succeed. Fixing an exploitable kernel bug usually means adding a check to see if what

[PATCH 9/9] perf: Known exploit detection for CVE-2013-2094

2013-12-12 Thread vegard . nossum
From: Vegard Nossum vegard.nos...@oracle.com See 8176cced706b5e5d15887584150764894e94e02f. Cc: Tommi Rantala tt.rant...@gmail.com Cc: Ingo Molnar mi...@kernel.org Signed-off-by: Vegard Nossum vegard.nos...@oracle.com --- kernel/events/core.c |2 ++ 1 file changed, 2 insertions(+) diff

  1   2   3   4   5   6   7   8   >