Re: [PATCH] drm/sti: Remove select of CONFIG_FW_LOADER_USER_HELPER_FALLBACK

2015-10-29 Thread Vincent ABRIOU
Hi Takashi, Removing FW_LOADER_USER_HELPER_FALLBACK leads to a failure in our HQVDP firmware execution. Indeed, our firmware is not built-in. It is a proprietary firmware uploaded into the file system that's why we need the USER_HELPER_FALLBACK to be able to load it once file system is

Re: [PATCH] drm: sti: remove redundant sign extensions

2015-10-29 Thread Vincent ABRIOU
Hi Rasmus, Thanks for the patch. I will integrated it in the next pull request for the sti driver. BR Vincent On 10/16/2015 03:14 PM, Rasmus Villemoes wrote: > arg is long int, so arg = (arg << 22) >> 22 makes the upper 22 bits of > arg equal to bit 9 (or bit 41). But we then mask away all but

Re: [PATCH] MAINTAINERS: update DT binding doc locations

2015-11-12 Thread Vincent ABRIOU
Philipp Zabel <p.za...@pengutronix.de> > Cc: Mark Yao <mark@rock-chips.com> > Cc: Benjamin Gaignard <benjamin.gaign...@linaro.org> > Cc: Vincent Abriou <vincent.abr...@st.com> > Cc: Jean-Christophe Plagniol-Villard <plagn...@jcrosoft.com> > Cc: Tom

Re: [PATCH] drm/sti: Remove select of CONFIG_FW_LOADER_USER_HELPER_FALLBACK

2015-11-02 Thread Vincent ABRIOU
; Emil Velikov wrote: >> >> On 29 October 2015 at 14:21, Vincent ABRIOU <vincent.abr...@st.com> wrote: >>> Hi Takashi, >>> >>> Removing FW_LOADER_USER_HELPER_FALLBACK leads to a failure in our HQVDP >>> firmware execution. >>> Indeed, ou

Re: [PATCH 5/6] drm/sti: Build monolithic driver

2015-10-05 Thread Vincent ABRIOU
Hi Thierry, Ack-by: Vincent Abriou <vincent.abr...@st.com> BR Vicnent On 09/24/2015 07:02 PM, Thierry Reding wrote: > From: Thierry Reding <tred...@nvidia.com> > > There's no use building the individual drivers as separate modules > because they are all only useful if co

Re: [PATCH 6/6] drm/sti: Do not export symbols

2015-10-05 Thread Vincent ABRIOU
Hi Thierry, Ack-by: Vincent Abriou <vincent.abr...@st.com> BR Vincent On 09/24/2015 07:02 PM, Thierry Reding wrote: > From: Thierry Reding <tred...@nvidia.com> > > None of these exported symbols are used outside of the drm-sti driver, > so there is no reason to expor

Re: [PATCH v2 11/20] drm: sti: Rely on the default ->best_encoder() behavior

2016-06-08 Thread Vincent ABRIOU
Hi Boris, Thanks for the patch. Acked-by: Vincent Abriou <vincent.abr...@st.com> Vincent On 06/07/2016 01:48 PM, Boris Brezillon wrote: > All outputs have a 1:1 relationship between connectors and encoders > and the driver is relying on the atomic helpers: we can dro

Re: [PATCH, RESEND] drm/sti: use u32 to store DMA addresses

2016-02-26 Thread Vincent ABRIOU
Hi Arnd, Your patch will be part of the next pull request for the STI driver that will be done by the end of next week. Reviewed-by: Vincent Abriou <vincent.abr...@st.com> On 02/25/2016 10:11 PM, Arnd Bergmann wrote: > The STi drm driver correctly warns about invalid format strin

Re: [PATCH] drm/sti: restore mode_fixup callback

2016-03-18 Thread Vincent ABRIOU
Thank you Arnd for highlighting this. Acked-by: Vincent ABRIOU <vincent.abr...@st.com> On 03/17/2016 10:02 AM, Arnd Bergmann wrote: > Commit 8a2fa38fddd3 removed the mode_fixup because it was empty, > but 652353e6e561 modified it to call drm_mode_set_crtcinfo() > instead. &

Re: [Y2038] [PATCH] drm/sti: Use 64-bit timestamps

2016-04-18 Thread Vincent ABRIOU
On 04/17/2016 01:39 AM, Arnd Bergmann wrote: > On Wednesday 13 April 2016 02:28:02 Tina Ruchandani wrote: >> 'struct timespec' uses a 32-bit field for seconds, which >> will overflow in year 2038 and beyond. This patch is part >> of a larger attempt to remove instances of timeval, timespec >> and

RE: linux-next: build failure after merge of the drm tree

2017-01-25 Thread Vincent ABRIOU
Dave Airlie <airl...@linux.ie> > Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Vincent > ABRIOU <vincent.abr...@st.com>; Ville Syrjälä > <ville.syrj...@linux.intel.com> > Subject: linux-next: build failure after merge of the drm tree > > Hi Dave, >

Re: [PATCH] drm/sti: mark symbols static where possible

2016-09-15 Thread Vincent ABRIOU
Acked-by: Vincent Abriou <vincent.abr...@st.com> On 09/15/2016 01:39 PM, Baoyou Xie wrote: > We get 4 warnings when building kernel with W=1: > drivers/gpu/drm/sti/sti_gdp.c:476:5: warning: no previous prototype for > 'sti_gdp_field_cb' [-Wmissing-prototypes] > drivers/gpu/d

Re: [PATCH] drm/sti: mark symbols static where possible

2016-09-28 Thread Vincent ABRIOU
Yes true, patch from Ville https://lists.freedesktop.org/archives/dri-devel/2016-September/118631.html; already fix patches sent by Baoyou. Vincent On 09/27/2016 09:07 PM, Benjamin Gaignard wrote: > I think that create conflicts with what is already in Vincent pull > request where we have fix

Re: [v1] gpu: drm: sti: sti_vtac:- Handle return NULL error from devm_ioremap_nocache

2017-01-04 Thread Vincent ABRIOU
Hi Arvind, Thank for this patch. Since sti_vtac.c file is deprecated, I rather suppress the sti_vtac.c file. I just push a new patch to suppress it. Thank for pointing this out. Br Vincent On 12/21/2016 06:22 AM, Arvind Yadav wrote: > Here, If devm_ioremap_nocache will fail. It will return

Re: [v1] gpu: drm: sti: sti_vtg:- Handle return NULL error from devm_ioremap_nocache

2017-01-04 Thread Vincent ABRIOU
Thanks for the patch. Acked-by: Vincent Abriou <vincent.abr...@st.com> I will take it for pull request that should be issued by the end of the week. Vincent On 12/21/2016 06:30 AM, Arvind Yadav wrote: > Here, If devm_ioremap_nocache will fail. It will return NULL. > Kernel can run

Re: [PATCH] gpu: drm: sti: Adopt SPDX identifiers

2017-12-06 Thread Vincent ABRIOU
Benjamin, The patch is fine for me: Acked-by: Vincent Abriou <vincent.abr...@st.com> Vincent On 12/06/2017 12:29 PM, Benjamin Gaignard wrote: > Add SPDX identifiers to files under sti directory > > Signed-off-by: Benjamin Gaignard <benjamin.gaign...@st.com> > ---

Re: [PATCH] gpu: drm: stm: Adopt SPDX identifiers

2017-12-06 Thread Vincent ABRIOU
Benjamin, The patch is fine for me: Acked-by: Vincent Abriou <vincent.abr...@st.com> Vincent On 12/06/2017 12:29 PM, Benjamin Gaignard wrote: > Add SPDX identifiers to files under stm directory > > Signed-off-by: Benjamin Gaignard <benjamin.gaign...@st.com> > --- >

Re: [PATCH 1/4] drm/panel: otm8009a: fix backlight updates

2018-05-14 Thread Vincent ABRIOU
Hi Philippe, Reviewed-by: Vincent Abriou <vincent.abr...@st.com> BR Vincent On 04/23/2018 04:10 PM, Philippe Cornu wrote: > Backlight updates was not working anymore since the good > implementation of the dsi lpm mode in the dsi host driver. > After a longer analysis, the ba

Re: [PATCH 2/4] drm/panel: otm8009a: fix glitches by moving backlight enable to otm8009a_enable()

2018-05-14 Thread Vincent ABRIOU
Hi Philippe, Reviewed-by: Vincent Abriou <vincent.abr...@st.com> BR Vincent On 04/23/2018 04:10 PM, Philippe Cornu wrote: > The backlight 1st update was in the otm8009a_prepare() function > for a bad reason: backlight was not working in video mode and the > otm8009a_prepare() is

Re: [PATCH 3/4] drm/panel: otm8009a: no message if probe success

2018-05-14 Thread Vincent ABRIOU
Hi Philippe, Reviewed-by: Vincent Abriou <vincent.abr...@st.com> BR Vincent On 04/23/2018 04:10 PM, Philippe Cornu wrote: > Remove the message in case of probe success. This comes from > a suggestion followed in the recent integration of the > raydium rm68200 panel. > > Si

Re: [PATCH 4/4] drm/panel: otm8009a: use new backlight api

2018-05-14 Thread Vincent ABRIOU
Hi Philippe, Reviewed-by: Vincent Abriou <vincent.abr...@st.com> BR Vincent On 04/23/2018 04:10 PM, Philippe Cornu wrote: > Use the new backlight api. > > Signed-off-by: Philippe Cornu <philippe.co...@st.com> > --- > drivers/gpu/drm/panel/pane

Re: [PATCH] drm/stm: ltdc: add user update info in plane print state

2018-04-16 Thread Vincent ABRIOU
Hi Philippe, Reviewed-by: Vincent Abriou <vincent.abr...@st.com> On 04/07/2018 11:35 PM, Philippe Cornu wrote: > This patch adds the user update information in > frames-per-second into the drm debugfs plane state. > > Signed-off-by: Philippe Cornu <philippe.co...@st.com&g

Re: [PATCH] drm/stm: move enable/disable_vblank to crtc

2018-04-16 Thread Vincent ABRIOU
Hi Philippe, Patch looks good to me. Reviewed-by: Vincent Abriou <vincent.abr...@st.com> On 04/07/2018 11:29 PM, Philippe Cornu wrote: > enable/disable_vblank() functions at drm_driver level > are deprecated. Move them to the ltdc drm_crtc_funcs > structure. > > Signed-o

Re: [PATCH 1/4] drm/panel: otm8009a: fix backlight updates

2018-05-14 Thread Vincent ABRIOU
Hi Philippe, Reviewed-by: Vincent Abriou BR Vincent On 04/23/2018 04:10 PM, Philippe Cornu wrote: > Backlight updates was not working anymore since the good > implementation of the dsi lpm mode in the dsi host driver. > After a longer analysis, the backlight updates in dsi video >

Re: [PATCH 2/4] drm/panel: otm8009a: fix glitches by moving backlight enable to otm8009a_enable()

2018-05-14 Thread Vincent ABRIOU
Hi Philippe, Reviewed-by: Vincent Abriou BR Vincent On 04/23/2018 04:10 PM, Philippe Cornu wrote: > The backlight 1st update was in the otm8009a_prepare() function > for a bad reason: backlight was not working in video mode and the > otm8009a_prepare() is in command mode for the init

Re: [PATCH 3/4] drm/panel: otm8009a: no message if probe success

2018-05-14 Thread Vincent ABRIOU
Hi Philippe, Reviewed-by: Vincent Abriou BR Vincent On 04/23/2018 04:10 PM, Philippe Cornu wrote: > Remove the message in case of probe success. This comes from > a suggestion followed in the recent integration of the > raydium rm68200 panel. > > Signed-off-by:

Re: [PATCH 4/4] drm/panel: otm8009a: use new backlight api

2018-05-14 Thread Vincent ABRIOU
Hi Philippe, Reviewed-by: Vincent Abriou BR Vincent On 04/23/2018 04:10 PM, Philippe Cornu wrote: > Use the new backlight api. > > Signed-off-by: Philippe Cornu > --- > drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 26 > > 1 file changed

Re: [PATCH] gpu: drm: stm: Adopt SPDX identifiers

2017-12-06 Thread Vincent ABRIOU
Benjamin, The patch is fine for me: Acked-by: Vincent Abriou Vincent On 12/06/2017 12:29 PM, Benjamin Gaignard wrote: > Add SPDX identifiers to files under stm directory > > Signed-off-by: Benjamin Gaignard > --- > drivers/gpu/drm/stm/drv.c | 3 +-- > d

Re: [PATCH] gpu: drm: sti: Adopt SPDX identifiers

2017-12-06 Thread Vincent ABRIOU
Benjamin, The patch is fine for me: Acked-by: Vincent Abriou Vincent On 12/06/2017 12:29 PM, Benjamin Gaignard wrote: > Add SPDX identifiers to files under sti directory > > Signed-off-by: Benjamin Gaignard > --- > drivers/gpu/drm/sti/sti_awg_utils.c| 2 +- > d

Re: [PATCH] drm/stm: move enable/disable_vblank to crtc

2018-04-16 Thread Vincent ABRIOU
Hi Philippe, Patch looks good to me. Reviewed-by: Vincent Abriou On 04/07/2018 11:29 PM, Philippe Cornu wrote: > enable/disable_vblank() functions at drm_driver level > are deprecated. Move them to the ltdc drm_crtc_funcs > structure. > > Signed-off-by: Philippe Cornu > -

Re: [PATCH] drm/stm: ltdc: add user update info in plane print state

2018-04-16 Thread Vincent ABRIOU
Hi Philippe, Reviewed-by: Vincent Abriou On 04/07/2018 11:35 PM, Philippe Cornu wrote: > This patch adds the user update information in > frames-per-second into the drm debugfs plane state. > > Signed-off-by: Philippe Cornu > --- > drivers/gpu/d

Re: [v1] gpu: drm: sti: sti_vtac:- Handle return NULL error from devm_ioremap_nocache

2017-01-04 Thread Vincent ABRIOU
Hi Arvind, Thank for this patch. Since sti_vtac.c file is deprecated, I rather suppress the sti_vtac.c file. I just push a new patch to suppress it. Thank for pointing this out. Br Vincent On 12/21/2016 06:22 AM, Arvind Yadav wrote: > Here, If devm_ioremap_nocache will fail. It will return

Re: [v1] gpu: drm: sti: sti_vtg:- Handle return NULL error from devm_ioremap_nocache

2017-01-04 Thread Vincent ABRIOU
Thanks for the patch. Acked-by: Vincent Abriou I will take it for pull request that should be issued by the end of the week. Vincent On 12/21/2016 06:30 AM, Arvind Yadav wrote: > Here, If devm_ioremap_nocache will fail. It will return NULL. > Kernel can run into a NULL-pointer deref

Re: [PATCH] drm/sti: mark symbols static where possible

2016-09-15 Thread Vincent ABRIOU
Acked-by: Vincent Abriou On 09/15/2016 01:39 PM, Baoyou Xie wrote: > We get 4 warnings when building kernel with W=1: > drivers/gpu/drm/sti/sti_gdp.c:476:5: warning: no previous prototype for > 'sti_gdp_field_cb' [-Wmissing-prototypes] > drivers/gpu/drm/sti/sti_hqvdp.c:78

Re: [PATCH] drm/sti: mark symbols static where possible

2016-09-28 Thread Vincent ABRIOU
Yes true, patch from Ville https://lists.freedesktop.org/archives/dri-devel/2016-September/118631.html; already fix patches sent by Baoyou. Vincent On 09/27/2016 09:07 PM, Benjamin Gaignard wrote: > I think that create conflicts with what is already in Vincent pull > request where we have fix

RE: linux-next: build failure after merge of the drm tree

2017-01-25 Thread Vincent ABRIOU
Dave Airlie > Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Vincent > ABRIOU ; Ville Syrjälä > > Subject: linux-next: build failure after merge of the drm tree > > Hi Dave, > > After merging the drm tree, today's linux-next build (arm > multi_v7_defconfig)

Re: [PATCH 5/6] drm/sti: Build monolithic driver

2015-10-05 Thread Vincent ABRIOU
Hi Thierry, Ack-by: Vincent Abriou BR Vicnent On 09/24/2015 07:02 PM, Thierry Reding wrote: > From: Thierry Reding > > There's no use building the individual drivers as separate modules > because they are all only useful if combined into a single DRM/KMS > device. > >

Re: [PATCH 6/6] drm/sti: Do not export symbols

2015-10-05 Thread Vincent ABRIOU
Hi Thierry, Ack-by: Vincent Abriou BR Vincent On 09/24/2015 07:02 PM, Thierry Reding wrote: > From: Thierry Reding > > None of these exported symbols are used outside of the drm-sti driver, > so there is no reason to export them. > > Cc: Benjamin Gaignard > Cc: Vincent

Re: [PATCH] drm/sti: Remove select of CONFIG_FW_LOADER_USER_HELPER_FALLBACK

2015-10-29 Thread Vincent ABRIOU
Hi Takashi, Removing FW_LOADER_USER_HELPER_FALLBACK leads to a failure in our HQVDP firmware execution. Indeed, our firmware is not built-in. It is a proprietary firmware uploaded into the file system that's why we need the USER_HELPER_FALLBACK to be able to load it once file system is

Re: [PATCH] drm: sti: remove redundant sign extensions

2015-10-29 Thread Vincent ABRIOU
Hi Rasmus, Thanks for the patch. I will integrated it in the next pull request for the sti driver. BR Vincent On 10/16/2015 03:14 PM, Rasmus Villemoes wrote: > arg is long int, so arg = (arg << 22) >> 22 makes the upper 22 bits of > arg equal to bit 9 (or bit 41). But we then mask away all but

Re: [PATCH] MAINTAINERS: update DT binding doc locations

2015-11-12 Thread Vincent ABRIOU
all of bindings/display/. So I've > dropped them. > > Reported-by: Thierry Reding > Cc: Thierry Reding > Cc: Jianwei Wang > Cc: Alison Wang > Cc: Philipp Zabel > Cc: Mark Yao > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Cc: Jean-Christophe Plagniol-Villard >

Re: [Y2038] [PATCH] drm/sti: Use 64-bit timestamps

2016-04-18 Thread Vincent ABRIOU
On 04/17/2016 01:39 AM, Arnd Bergmann wrote: > On Wednesday 13 April 2016 02:28:02 Tina Ruchandani wrote: >> 'struct timespec' uses a 32-bit field for seconds, which >> will overflow in year 2038 and beyond. This patch is part >> of a larger attempt to remove instances of timeval, timespec >> and

Re: [PATCH] drm/sti: restore mode_fixup callback

2016-03-18 Thread Vincent ABRIOU
Thank you Arnd for highlighting this. Acked-by: Vincent ABRIOU On 03/17/2016 10:02 AM, Arnd Bergmann wrote: > Commit 8a2fa38fddd3 removed the mode_fixup because it was empty, > but 652353e6e561 modified it to call drm_mode_set_crtcinfo() > instead. > > Both commits are correct

Re: [PATCH, RESEND] drm/sti: use u32 to store DMA addresses

2016-02-26 Thread Vincent ABRIOU
Hi Arnd, Your patch will be part of the next pull request for the STI driver that will be done by the end of next week. Reviewed-by: Vincent Abriou On 02/25/2016 10:11 PM, Arnd Bergmann wrote: > The STi drm driver correctly warns about invalid format strings > when built with

Re: [PATCH v2 11/20] drm: sti: Rely on the default ->best_encoder() behavior

2016-06-08 Thread Vincent ABRIOU
Hi Boris, Thanks for the patch. Acked-by: Vincent Abriou Vincent On 06/07/2016 01:48 PM, Boris Brezillon wrote: > All outputs have a 1:1 relationship between connectors and encoders > and the driver is relying on the atomic helpers: we can drop the custom > ->best_encoder() imp

Re: [PATCH] drm/sti: Remove select of CONFIG_FW_LOADER_USER_HELPER_FALLBACK

2015-11-02 Thread Vincent ABRIOU
; Emil Velikov wrote: >> >> On 29 October 2015 at 14:21, Vincent ABRIOU wrote: >>> Hi Takashi, >>> >>> Removing FW_LOADER_USER_HELPER_FALLBACK leads to a failure in our HQVDP >>> firmware execution. >>> Indeed, our firmware is not built-in. It is