[PATCH -next] soc: fsl: qe: Remove unnessesary check in ucc_set_tdm_rxtx_clk

2020-08-04 Thread Wang Hai
Fix smatch warning: drivers/soc/fsl/qe/ucc.c:526 ucc_set_tdm_rxtx_clk() warn: unsigned 'tdm_num' is never less than zero. 'tdm_num' is u32 type, never less than zero. Signed-off-by: Wang Hai --- drivers/soc/fsl/qe/ucc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net] net: qcom/emac: add missed clk_disable_unprepare in error path of emac_clks_phase1_init

2020-08-09 Thread Wang Hai
Fix the missing clk_disable_unprepare() before return from emac_clks_phase1_init() in the error handling case. Fixes: b9b17debc69d ("net: emac: emac gigabit ethernet controller driver") Reported-by: Hulk Robot Signed-off-by: Wang Hai Acked-by: Timur Tabi --- drivers/net/ethernet/qua

[PATCH net-next] net: wimax: i2400m: fix 'msg_skb' kernel-doc warning in i2400m_msg_to_dev()

2020-09-08 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/wimax/i2400m/control.c:709: warning: Excess function parameter 'msg_skb' description in 'i2400m_msg_to_dev' This parameter is not in use. Remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/wimax/i2400m

[PATCH net-next] cipso: fix 'audit_secid' kernel-doc warning in cipso_ipv4.c

2020-09-08 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): net/ipv4/cipso_ipv4.c:510: warning: Excess function parameter 'audit_secid' description in 'cipso_v4_doi_remove' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/ipv4/cipso_ipv4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH net-next] netlabel: Fix some kernel-doc warnings

2020-09-08 Thread Wang Hai
-by: Hulk Robot Signed-off-by: Wang Hai --- net/netlabel/netlabel_calipso.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netlabel/netlabel_calipso.c b/net/netlabel/netlabel_calipso.c index 249da67d50a2..1a98247ab148 100644 --- a/net/netlabel/netlabel_calipso.c +++ b

[PATCH net-next] ath5k: fix 'mode' kernel-doc warning in ath5k_hw_pcu_init()

2020-09-09 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath5k/pcu.c:955: warning: Excess function parameter 'mode' description in 'ath5k_hw_pcu_init' This parameter is not in use. Remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/wireless/ath/ath5k

[PATCH net-next] net: cavium: Fix a bunch of kerneldoc parameter issues

2020-09-09 Thread Wang Hai
' drivers/net/ethernet/cavium/common/cavium_ptp.c:208: warning: Excess function parameter 'ptp' description in 'cavium_ptp_enable' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/cavium/common/cavium_ptp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions

[PATCH -next 3/4] ubifs: Fix some kernel-doc warnings in replay.c

2020-09-14 Thread Wang Hai
-by: Hulk Robot Signed-off-by: Wang Hai --- fs/ubifs/replay.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ubifs/replay.c b/fs/ubifs/replay.c index b69ffac7e415..2f8d8f4f411a 100644 --- a/fs/ubifs/replay.c +++ b/fs/ubifs/replay.c @@ -931,8 +931,6 @@ static int add_replay_bud(struct

[PATCH -next 1/4] ubifs: Fix 'hash' kernel-doc warning in auth.c

2020-09-14 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): fs/ubifs/auth.c:66: warning: Excess function parameter 'hash' description in 'ubifs_prepare_auth_node' Rename hash to inhash. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- fs/ubifs/auth.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH -next 4/4] ubifs: Fix some kernel-doc warnings in tnc.c

2020-09-14 Thread Wang Hai
it. @node in 'lnc_free' is not in use, Remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- fs/ubifs/tnc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ubifs/tnc.c b/fs/ubifs/tnc.c index f609f6cdde70..de21625804a9 100644 --- a/fs/ubifs/tnc.c +++ b/fs/ubifs

[PATCH -next 2/4] ubifs: Fix some kernel-doc warnings in gc.c

2020-09-14 Thread Wang Hai
' description in 'switch_gc_head' fs/ubifs/gc.c:70: warning: Excess function parameter 'offs' description in 'switch_gc_head' They're not in use. Remove them. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- fs/ubifs/gc.c | 4 1 file changed, 4 deletions(-) diff --git a/fs/ubifs/gc.c b/fs

[PATCH -next 0/4] ubifs: Fix some kernel-doc warnings for ubifs

2020-09-14 Thread Wang Hai
In the ubifs module, there are some kernel-doc warnings, this series of patches can fix these warnings. Wang Hai (4): ubifs: Fix 'hash' kernel-doc warning in auth.c ubifs: Fix some kernel-doc warnings in gc.c ubifs: Fix some kernel-doc warnings in replay.c ubifs: Fix some kernel-doc

[PATCH net-next 2/3] e1000e: Fix some kernel-doc warnings in netdev.c

2020-09-10 Thread Wang Hai
-off-by: Wang Hai --- drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c index 664e8ccc88d2..4c5c4e8a14ba 100644 --- a/drivers/net/ethernet/intel

[PATCH net-next 3/3] e1000: Fix a bunch of kerneldoc parameter issues in e1000_hw.c

2020-09-10 Thread Wang Hai
' drivers/net/ethernet/intel/e1000/e1000_hw.c:5079: warning: Excess function parameter 'downshift' description in 'e1000_check_downshift' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/intel/e1000/e1000_hw.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff

[PATCH net-next 0/3] Fix some kernel-doc warnings for e1000/e1000e

2020-09-10 Thread Wang Hai
Wang Hai (3): e1000e: Fix some kernel-doc warnings in ich8lan.c e1000e: Fix some kernel-doc warnings in netdev.c e1000: Fix a bunch of kerneldoc parameter issues in e1000_hw.c drivers/net/ethernet/intel/e1000/e1000_hw.c | 7 +-- drivers/net/ethernet/intel/e1000e/ich8lan.c | 4

[PATCH net-next 1/3] e1000e: Fix some kernel-doc warnings in ich8lan.c

2020-09-10 Thread Wang Hai
in '__e1000_access_emi_reg_locked' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c index

[PATCH net-next 3/3] i40e: Fix a kernel-doc warning in i40e_ptp.c

2020-09-10 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/intel/i40e/i40e_ptp.c:270: warning: Excess function parameter 'vsi' description in 'i40e_ptp_rx_hang' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/intel/i40e/i40e_ptp.c | 1 - 1 file changed, 1

[PATCH net-next 0/3] Fix some kernel-doc warnings for i40e

2020-09-10 Thread Wang Hai
Wang Hai (3): i40e: Fix some kernel-doc warnings in i40e_client.c i40e: Fix some kernel-doc warnings in i40e_common.c i40e: Fix a kernel-doc warning in i40e_ptp.c drivers/net/ethernet/intel/i40e/i40e_client.c | 2 -- drivers/net/ethernet/intel/i40e/i40e_common.c | 2 -- drivers/net

[PATCH net-next 1/3] i40e: Fix some kernel-doc warnings in i40e_client.c

2020-09-10 Thread Wang Hai
in 'i40e_client_add_instance' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/intel/i40e/i40e_client.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c index befd3018183f

[PATCH net-next 2/3] i40e: Fix some kernel-doc warnings in i40e_common.c

2020-09-10 Thread Wang Hai
in 'i40e_aq_start_lldp' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/intel/i40e/i40e_common.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c index 6ab52cbd697a

[PATCH net-next] igb: Fix some kernel-doc warnings in e1000_82575.c

2020-09-10 Thread Wang Hai
in 'igb_set_eee_i350' drivers/net/ethernet/intel/igb/e1000_82575.c:2655: warning: Excess function parameter 'adv100m' description in 'igb_set_eee_i354' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/intel/igb/e1000_82575.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH net-next] igb: Fix some kernel-doc warnings in e1000_82575.c

2020-09-10 Thread Wang Hai
in 'igb_set_eee_i350' drivers/net/ethernet/intel/igb/e1000_82575.c:2655: warning: Excess function parameter 'adv100m' description in 'igb_set_eee_i354' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/intel/igb/e1000_82575.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH net-next 3/6] net: hns: Fix some kernel-doc warnings in hns_dsaf_xgmac.c

2020-09-10 Thread Wang Hai
in 'hns_xgmac_get_regs' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c b/drivers/net/ethernet/hisilicon/hns

[PATCH net-next 4/6] net: hns: Fix some kernel-doc warnings in hns_enet.c

2020-09-10 Thread Wang Hai
in 'hns_set_multicast_list' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c index

[PATCH net-next 5/6] net: hns: Fix a kernel-doc warning in hinic_hw_api_cmd.c

2020-09-10 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c:382: warning: Excess function parameter 'size' description in 'api_cmd' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c | 2 +- 1

[PATCH net-next 2/6] net: hns: fix 'cdev' kernel-doc warning in hnae_ae_unregister()

2020-09-10 Thread Wang Hai
Rename cdev to hdev. Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/hisilicon/hns/hnae.c:444: warning: Excess function parameter 'cdev' description in 'hnae_ae_unregister' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/hisilicon/hns/hnae.c

[PATCH net-next 1/6] hinic: Fix some kernel-doc warnings in hinic_hw_io.c

2020-09-10 Thread Wang Hai
' description in 'hinic_io_create_qps' Rename these wrong names. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/huawei/hinic/hinic_hw_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_io.c b/drivers

[PATCH net-next 6/6] net: hns: Fix a kernel-doc warning in hinic_hw_eqs.c

2020-09-10 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:115: warning: Excess function parameter 'hw_handler' description in 'hinic_aeq_register_hw_cb' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/huawei/hinic

[PATCH net-next 0/6] Fix some kernel-doc warnings for hns

2020-09-10 Thread Wang Hai
Fix some kernel-doc warnings for hns. Wang Hai (6): hinic: Fix some kernel-doc warnings in hinic_hw_io.c net: hns: fix 'cdev' kernel-doc warning in hnae_ae_unregister() net: hns: Fix some kernel-doc warnings in hns_dsaf_xgmac.c net: hns: Fix some kernel-doc warnings in hns_enet.c net

[PATCH net-next] net: cxgb3: Fix some kernel-doc warnings

2020-09-10 Thread Wang Hai
in 't3_set_proto_sram' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/chelsio/cxgb3/t3_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c b/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c index 0a9f2c596624

[PATCH -next] ext2: Fix some kernel-doc warnings in balloc.c

2020-09-11 Thread Wang Hai
function parameter 'rsv' description in 'alloc_new_reservation' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- fs/ext2/balloc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c index fa9c951d3471..1f3f4326bf3c 100644 --- a/fs

[PATCH -next] fs: vboxsf: Fix a kernel-doc warning in vboxsf_wrappers.c

2020-09-11 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): fs/vboxsf/vboxsf_wrappers.c:132: warning: Excess function parameter 'param' description in 'vboxsf_create' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- fs/vboxsf/vboxsf_wrappers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH -next] fs_parser: Fix 'name' kernel-doc warning in validate_constant_table()

2020-09-11 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): fs/fs_parser.c:322: warning: Excess function parameter 'name' description in 'validate_constant_table' This parameter is not in use. Remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- fs/fs_parser.c | 1 - 1 file changed, 1

[PATCH -next] fs: Fix 'mnt' kernel-doc warning in namespace.c

2020-09-11 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): fs/namespace.c:1358: warning: Excess function parameter 'mnt' description in 'may_umount_tree' Rename mnt to m. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- fs/namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v2] net: bridge: Fix a warning when del bridge sysfs

2020-12-11 Thread Wang Hai
: bb900b27a2f4 ("bridge: allow creating bridge devices with netlink") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2: Fix this by check br_sysfs_addbr() return value as Nik's suggestion net/bridge/br.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ne

[PATCH v3 bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-11 Thread Wang Hai
progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, it should be closed. Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface") Signed-off-by: Wang Hai --- v2->v3: add 'err = 0' before successful return v1->v2: use cle

[PATCH net] devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill()

2020-11-11 Thread Wang Hai
If sb_occ_port_pool_get() failed in devlink_nl_sb_port_pool_fill(), msg should be canceled by genlmsg_cancel(). Fixes: df38dafd2559 ("devlink: implement shared buffer occupancy monitoring interface") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/core/devlink.c | 4 ++

[PATCH net] ipvs: fix possible memory leak in ip_vs_control_net_init

2020-11-19 Thread Wang Hai
VS: netns, ip_vs_stats and its procfs") Fixes: 61b1ab4583e2 ("IPVS: netns, add basic init per netns.") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/netfilter/ipvs/ip_vs_ctl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/ne

[PATCH net v2] ipvs: fix possible memory leak in ip_vs_control_net_init

2020-11-20 Thread Wang Hai
IG_PROC_FS' because proc_create_net* return NULL when PROC is not used. Fixes: b17fc9963f83 ("IPVS: netns, ip_vs_stats and its procfs") Fixes: 61b1ab4583e2 ("IPVS: netns, add basic init per netns.") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2: add some '#ifdef CO

[PATCH v2 net] devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill()

2020-11-13 Thread Wang Hai
If sb_occ_port_pool_get() failed in devlink_nl_sb_port_pool_fill(), msg should be canceled by genlmsg_cancel(). Fixes: df38dafd2559 ("devlink: implement shared buffer occupancy monitoring interface") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2: use goto instead of

[PATCH net] net: marvell: prestera: fix error return code in prestera_pci_probe()

2020-11-13 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 4c2703dfd7fa ("net: marvell: prestera: Add PCI interface support") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/marvell/prestera/pres

[PATCH v4 bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-13 Thread Wang Hai
progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, it should be closed. Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface") Signed-off-by: Wang Hai --- v3->v4: delete 'err = 0' v2->v3: add 'err = 0' before successful re

[PATCH net] Bluetooth: Fix potential null pointer dereference in create_le_conn_complete

2020-11-13 Thread Wang Hai
The pointer 'conn' may be null. Before being used by hci_connect_le_scan_cleanup(), The pointer 'conn' must be checked whether it is null. Fixes: 28a667c9c279 ("Bluetooth: advertisement handling in new connect procedure") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net

[PATCH net] net/mlx5: fix error return code in mlx5e_tc_nic_init()

2020-11-14 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: aedd133d17bc ("net/mlx5e: Support CT offload for tc nic flows") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/mellanox/mlx5/core/e

[PATCH net] qtnfmac: fix error return code in qtnf_pcie_probe()

2020-11-14 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: b7da53cd6cd1 ("qtnfmac_pcie: use single PCIe driver for all platforms") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/wireless/quantenna/qt

[PATCH net] inet_diag: Fix error path to cancel the meseage in inet_req_diag_fill()

2020-11-16 Thread Wang Hai
nlmsg_cancel() needs to be called in the error path of inet_req_diag_fill to cancel the message. Fixes: d545caca827b ("net: inet: diag: expose the socket mark to privileged processes.") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/ipv4/inet_diag.c | 4 +++- 1 file

[PATCH net] ipv6: addrlabel: fix possible memory leak in ip6addrlbl_net_init

2020-11-21 Thread Wang Hai
t;31a10c08>] do_syscall_64+0x33/0x40 [<99df30e7>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 We should free all rules when we catch an error in ip6addrlbl_net_init(). otherwise a memory leak will occur. Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Support RFC3484 configurable address sel

[PATCH] staging: mfd: hi6421-spmi-pmic: fix error return code in hi6421_spmi_pmic_probe()

2020-11-18 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 4524ac56cdca ("staging: mfd: add a PMIC driver for HiSilicon 6421 SPMI version") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/staging/hikey9xx/h

[PATCH] android/ion: fix error return code in opensocket()

2020-11-18 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 47a18c42d992 ("android/ion: userspace test utility for ion buffer sharing") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- tools/testing/selftests/a

[PATCH v2] android/ion: fix error return code in opensocket()

2020-11-18 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 47a18c42d992 ("android/ion: userspace test utility for ion buffer sharing") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2: add missing "

[PATCH v2 bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-09 Thread Wang Hai
progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, it should be closed. Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface") Signed-off-by: Wang Hai --- v1->v2: use cleanup tag instead of repeated closes tools/bpf/bpfto

[PATCH net] cosa: Add missing kfree in error path of cosa_write

2020-11-10 Thread Wang Hai
If memory allocation for 'kbuf' succeed, cosa_write() doesn't have a corresponding kfree() in exception handling. Thus add kfree() for this function implementation. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/wan/cosa.c | 1

[PATCH bpf] selftests/bpf: fix error return code in run_getsockopt_test()

2020-11-16 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 65b4414a05eb ("selftests/bpf: add sockopt test that exercises BPF_F_ALLOW_MULTI") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- tools/testing/sel

[PATCH] PCI: dwc: fix error return code in dw_pcie_host_init()

2020-11-16 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 07940c369a6b ("PCI: dwc: Fix MSI page leakage in suspend/resume") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/pci/controller/dwc/pcie-designware-

[PATCH v2] PCI: dwc: fix error return code in dw_pcie_host_init()

2020-11-16 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 07940c369a6b ("PCI: dwc: Fix MSI page leakage in suspend/resume") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2: just add 'ret = xxx' drivers/p

[PATCH net v2] ipv6: addrlabel: fix possible memory leak in ip6addrlbl_net_init

2020-11-23 Thread Wang Hai
t;31a10c08>] do_syscall_64+0x33/0x40 [<99df30e7>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 We should free all rules when we catch an error in ip6addrlbl_net_init(). otherwise a memory leak will occur. Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Support RFC3484 configurable address selec

[PATCH net v3] ipvs: fix possible memory leak in ip_vs_control_net_init

2020-11-24 Thread Wang Hai
erwise a memory leak will occur. Also, add some '#ifdef CONFIG_PROC_FS' because proc_create_net* return NULL when PROC is not used. Fixes: b17fc9963f83 ("IPVS: netns, ip_vs_stats and its procfs") Fixes: 61b1ab4583e2 ("IPVS: netns, add basic init per netns.") Reported-by: Hul

[PATCH] staging: greybus: audio: Add missing unlock in gbaudio_dapm_free_controls()

2020-12-03 Thread Wang Hai
Add the missing unlock before return from function gbaudio_dapm_free_controls() in the error handling case. Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic audio module") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/staging/greybus/audio_he

[PATCH net] openvswitch: fix error return code in validate_and_copy_dec_ttl()

2020-12-04 Thread Wang Hai
Hulk Robot Signed-off-by: Wang Hai --- net/openvswitch/flow_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c index ec0689ddc635..4c5c2331e764 100644 --- a/net/openvswitch/flow_netlink.c +++ b/net/o

[PATCH] staging: greybus: audio: Fix possible leak free widgets in gbaudio_dapm_free_controls

2020-12-05 Thread Wang Hai
aging: greybus: audio: Add helper APIs for dynamic audio module") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/staging/greybus/audio_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_helper.c b/drivers/stagi

[PATCH] dax: fix memory leak when rmmod dax.ko

2020-12-01 Thread Wang Hai
+0x9c/0xe0 [<3eb304e7>] do_syscall_64+0x33/0x40 [<51c5fd06>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 When rmmod dax is executed, dax_bus_exit() is missing. This patch can fix this bug. Fixes: 9567da0b408a ("device-dax: Introduce bus + driver model") Repor

[PATCH net] net: bridge: Fix a warning when del bridge sysfs

2020-12-01 Thread Wang Hai
n.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/bridge/br_sysfs_br.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c index 7db06e3f642a..1e9cbf31d904 100644 --- a/net/bridge/br_sysfs_br.c +++

[PATCH net] net: mvpp2: Fix error return code in mvpp2_open()

2020-12-03 Thread Wang Hai
Fix to return negative error code -ENOENT from invalid configuration error handling case instead of 0, as done elsewhere in this function. Fixes: 4bb043262878 ("net: mvpp2: phylink support") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/marvell/mvpp2/mvpp2_

[PATCH] tpm: ibmvtpm: fix error return code in tpm_ibmvtpm_probe()

2020-11-24 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/char/tpm/tpm_ibmvtpm.c | 1

[PATCH] block: fix error return code in mm_pci_probe()

2020-11-24 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/block/umem.c | 5 - 1 file changed, 4 insertions(+), 1 deletio

[PATCH bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-08 Thread Wang Hai
progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, it should be closed. Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface") Signed-off-by: Wang Hai --- tools/bpf/bpftool/net.c | 2 ++ 1 file changed, 2 insertions(+) diff --g

[PATCH net] tipc: fix memory leak in tipc_topsrv_start()

2020-11-09 Thread Wang Hai
5ca3c>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 'srv' is malloced in tipc_topsrv_start() but not free before leaving from the error handling cases. We need to free it. Fixes: 5c45ab24ac77 ("tipc: make struct tipc_server private for server.c") Reported-by: Hulk Robot Signed-off-by: Wang

[PATCH net-next] netfilter: ebt_stp: Remove unused macro BPDU_TYPE_TCN

2020-09-04 Thread Wang Hai
BPDU_TYPE_TCN is never used after it was introduced. So better to remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/bridge/netfilter/ebt_stp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/bridge/netfilter/ebt_stp.c b/net/bridge/netfilter/ebt_stp.c index 0d6d20c9105e

[PATCH net-next] caif: Remove duplicate macro SRVL_CTRL_PKT_SIZE

2020-09-04 Thread Wang Hai
Remove SRVL_CTRL_PKT_SIZE which is defined more than once. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/caif/cfsrvl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/caif/cfsrvl.c b/net/caif/cfsrvl.c index d0a4d0ac7045..9cef9496a707 100644 --- a/net/caif/cfsrvl.c +++ b/net

[PATCH net-next] NFC: digital: Remove two unused macroes

2020-09-04 Thread Wang Hai
DIGITAL_NFC_DEP_REQ_RES_TAILROOM is never used after it was introduced. DIGITAL_NFC_DEP_REQ_RES_HEADROOM is no more used after below commit e8e7f4217564 ("NFC: digital: Remove useless call to skb_reserve()") Remove them. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/nfc/dig

[PATCH net-next] net/packet: Remove unused macro BLOCK_PRIV

2020-09-04 Thread Wang Hai
BPDU_TYPE_TCN is never used after it was introduced. So better to remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/packet/af_packet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index da8254e680f9..c430672c6a67 100644

[PATCH net-next] rxrpc: Remove unused macro rxrpc_min_rtt_wlen

2020-09-04 Thread Wang Hai
rxrpc_min_rtt_wlen is never used after it was introduced. So better to remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/rxrpc/rtt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/rxrpc/rtt.c b/net/rxrpc/rtt.c index 928d8b34a3ee..a056c9bcf1d6 100644 --- a/net/rxrpc

[PATCH net-next] can: kvaser_pciefd: Remove unused macro KVASER_PCIEFD_KCAN_CTRL_EFRAME

2020-09-04 Thread Wang Hai
KVASER_PCIEFD_KCAN_CTRL_EFRAME is never used after it was introduced. So better to remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/can/kvaser_pciefd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c

[PATCH net-next] can: peak_canfd: Remove unused macros

2020-09-04 Thread Wang Hai
CANFD_CLK_SEL_DIV_MASK and CANFD_OPTIONS_SET are never used after they were introduced. Remove them. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/can/peak_canfd/peak_pciefd_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/can/peak_canfd

[PATCH net-next v2] net/packet: Remove unused macro BLOCK_PRIV

2020-09-05 Thread Wang Hai
BLOCK_PRIV is never used after it was introduced. So better to remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2: Corrected the wrong comment net/packet/af_packet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c in

[PATCH net v2] net: gemini: Fix missing free_netdev() in error path of gemini_ethernet_port_probe()

2020-08-18 Thread Wang Hai
Replace alloc_etherdev_mq with devm_alloc_etherdev_mqs. In this way, when probe fails, netdev can be freed automatically. Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->

[PATCH -next] bus: bt1-apb: remove duplicate include

2020-08-18 Thread Wang Hai
Remove linux/clk.h which is included more than once Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/bus/bt1-apb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/bus/bt1-apb.c b/drivers/bus/bt1-apb.c index b25ff941e7c7..74b1b712ef3a 100644 --- a/drivers/bus/bt1-apb.c

[PATCH net-next] net: ipa: remove duplicate include

2020-08-18 Thread Wang Hai
Remove linux/notifier.h which is included more than once Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ipa/ipa.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ipa/ipa.h b/drivers/net/ipa/ipa.h index 55115cfb2972..407fee841a9a 100644 --- a/drivers/net/ipa

[PATCH net-next] SUNRPC: remove duplicate include

2020-08-18 Thread Wang Hai
Remove linux/sunrpc/auth_gss.h which is included more than once Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/sunrpc/auth_gss/trace.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/sunrpc/auth_gss/trace.c b/net/sunrpc/auth_gss/trace.c index d26036a57443..76685abba60f 100644

[PATCH -next] ext2: remove duplicate include

2020-08-18 Thread Wang Hai
Remove linux/fiemap.h which is included more than once Reported-by: Hulk Robot Signed-off-by: Wang Hai --- fs/ext2/inode.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index 80662e1f7889..de6b97612410 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c

[PATCH -next] drm/mediatek: remove duplicate include

2020-08-18 Thread Wang Hai
Remove mtk_drm_ddp.h which is included more than once Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index

[PATCH -next] drm/nouveau/svm: remove duplicate include

2020-08-18 Thread Wang Hai
Remove nvif/if000c.h which is included more than once Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/gpu/drm/nouveau/nouveau_dmem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c b/drivers/gpu/drm/nouveau/nouveau_dmem.c index

[PATCH -next] drm/nouveau/nvenc: remove duplicate include

2020-08-18 Thread Wang Hai
Remove priv.h which is included more than once Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/nvenc

[PATCH -next] ARM: sa1100: remove duplicate include

2020-08-19 Thread Wang Hai
Remove linux/tty.h which is included more than once Reported-by: Hulk Robot Signed-off-by: Wang Hai --- arch/arm/mach-sa1100/hackkit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-sa1100/hackkit.c b/arch/arm/mach-sa1100/hackkit.c index 3085f1c2e586..3fe34ee7c0ab 100644

[PATCH -next] ARM: mm: remove duplicate include

2020-08-19 Thread Wang Hai
Remove asm/sections.h and asm/fixmap.h that are included more than once. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- arch/arm/mm/mmu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index c36f977b2ccb..21182eb534b0 100644 --- a/arch/arm/mm

[PATCH -next] sh: mach-sh03: remove duplicate include

2020-08-19 Thread Wang Hai
Remove linux/rtc.h which is included more than once Reported-by: Hulk Robot Signed-off-by: Wang Hai --- arch/sh/boards/mach-sh03/rtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/sh/boards/mach-sh03/rtc.c b/arch/sh/boards/mach-sh03/rtc.c index 8b23ed7c201c..165e2ccaab4d 100644

[PATCH -next] x86/mpparse: remove duplicate include

2020-08-19 Thread Wang Hai
Remove asm/io_apic.h which is included more than once Reported-by: Hulk Robot Signed-off-by: Wang Hai --- arch/x86/kernel/mpparse.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c index 411af4aa7b51..00e51626eeb0 100644 --- a/arch/x86

[PATCH -next] drm/amd/powerplay: remove duplicate include

2020-08-19 Thread Wang Hai
Remove asic_reg/nbio/nbio_6_1_offset.h which is included more than once Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/gpu/drm/amd/powerplay/hwmgr/vega12_inc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_inc.h b/drivers/gpu/drm

[PATCH net] net: gemini: Fix missing free_netdev() in error path of gemini_ethernet_port_probe()

2020-08-18 Thread Wang Hai
Fix the missing free_netdev() before return from gemini_ethernet_port_probe() in the error handling case. Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/cortina/gem

[PATCH net] net: qcom/emac: Fix missing clk_disable_unprepare() in error path of emac_probe

2020-08-06 Thread Wang Hai
gabit ethernet controller driver") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/qualcomm/emac/emac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c index 20

[PATCH -next] blktrace: make function blk_trace_bio_get_cgid() static

2020-09-07 Thread Wang Hai
The sparse tool complains as follows: kernel/trace/blktrace.c:796:5: warning: symbol 'blk_trace_bio_get_cgid' was not declared. Should it be static? This function is not used outside of blktrace.c, so this commit marks it static. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- kernel

[PATCH net-next] mt76: mt7615: Remove set but unused variable 'index'

2020-09-07 Thread Wang Hai
;mt76: mt7615: implement testmode support") involved this unused variable, remove it. Signed-off-by: Wang Hai --- drivers/net/wireless/mediatek/mt76/mt7615/testmode.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/testmode.c b/drivers/ne

[PATCH net-next] net: ethernet: dnet: Remove set but unused variable 'len'

2020-09-07 Thread Wang Hai
) involved this unused variable, remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/dnet.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/dnet.c b/drivers/net/ethernet/dnet.c index db98274501a0..3143df9a398c 100644 ---

[PATCH net-next] bnx2x: Fix some kernel-doc warnings

2020-09-08 Thread Wang Hai
in 'bnx2x_setup_tc' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c index

[PATCH -next] nilfs2: Fix some kernel-doc warnings for nilfs2

2020-09-18 Thread Wang Hai
: Excess function parameter 'stat' description in 'nilfs_cpfile_get_stat' fs/nilfs2/page.c:76: warning: Excess function parameter 'inode' description in 'nilfs_forget_buffer' fs/nilfs2/sufile.c:563: warning: Excess function parameter 'stat' description in 'nilfs_sufile_get_stat' Signed-off-by: Wang

[PATCH -next] fs/nsfs.c: Fix 'ns_common' kernel-doc warning in nsfs.c

2020-09-18 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): fs/nsfs.c:264: warning: Excess function parameter 'ns_common' description in 'ns_match' Rename ns_common to ns. Signed-off-by: Wang Hai --- fs/nsfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nsfs.c b/fs/nsfs.c

[PATCH -next] open: Fix some kernel-doc warnings in open.c

2020-09-18 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): fs/open.c:887: warning: Excess function parameter 'opened' description in 'finish_open' fs/open.c:929: warning: Excess function parameter 'cred' description in 'vfs_open' @opened and @cred are not in used, remove them. Signed-off-by: Wang Hai

[PATCH -next] fs/proc/vmcore: Fix 'sizez' kernel-doc warning in vmcore.c

2020-09-18 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): fs/proc/vmcore.c:458: warning: Excess function parameter 'sizez' description in 'vmcore_alloc_buf' Rename sizez to size. Signed-off-by: Wang Hai --- fs/proc/vmcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc

[PATCH net-next] net/appletalk: Supply missing net/Space.h include file

2020-09-18 Thread Wang Hai
for ‘cops_probe’ [-Wmissing-prototypes] drivers/net/appletalk/ltpc.c:1014:28: warning: no previous prototype for ‘ltpc_probe’ [-Wmissing-prototypes] Signed-off-by: Wang Hai --- drivers/net/appletalk/cops.c | 2 ++ drivers/net/appletalk/ltpc.c | 2 ++ 2 files changed, 4 insertions(+) diff --git

[PATCH net-next] liquidio: Fix -Wmissing-prototypes warnings for liquidio

2020-09-18 Thread Wang Hai
: no previous prototype for ‘octeon_read_device_mem32’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:194:6: warning: no previous prototype for ‘octeon_write_device_mem32’ [-Wmissing-prototypes] Signed-off-by: Wang Hai --- drivers/net/ethernet/cavium/liquidio/cn68xx_device.c

  1   2   >