Re: [PATCH v5] watchdog: introduce retu_wdt driver

2013-02-07 Thread Wim Van Sebroeck
Hi Aaro, > Introduce Retu watchdog driver. > > Cc: linux-watch...@vger.kernel.org > Acked-by: Felipe Balbi > Acked-by: Tony Lindgren > Signed-off-by: Aaro Koskinen > Cc: Wim Van Sebroeck Added tolinux-watchdog-next. Kind regards, Wim. -- To unsubscribe from thi

Re: [PATCH] watchdog: Convert BookE watchdog driver to watchdog infrastructure

2013-02-07 Thread Wim Van Sebroeck
Hi Guenter, > Signed-off-by: Guenter Roeck > --- > drivers/watchdog/Kconfig |1 + > drivers/watchdog/booke_wdt.c | 185 > +++--- > 2 files changed, 66 insertions(+), 120 deletions(-) > Added to linux-watchdog-next. Kind regards, Wim. -- To unsubs

Re: linux-next: manual merge of the watchdog tree with the mfd tree

2013-02-08 Thread Wim Van Sebroeck
Hi Stephen, > Today's linux-next merge of the watchdog tree got conflicts in > drivers/watchdog/Kconfig and drivers/watchdog/Makefile between commit > 699ff59052e7 ("watchdog: Add support for ux500_wdt watchdog") from the > mfd tree and commit 77b709cb6c9d ("watchdog: introduce retu_wdt driver") >

Re: [PATCH v2 3/4] watchdog: add support for ux500_wdt watchdog

2013-01-29 Thread Wim Van Sebroeck
Hi Fabio, Samuel, > This patch adds support for the ux500_wdt watchdog that is found in > ST-Ericsson Ux500 platform. The driver is based on PRCMU APIs. > > Acked-by: Linus Walleij > Acked-by: Lee Jones > Signed-off-by: Fabio Baltieri Acked-by: Wim Van Sebroeck Kind re

Re: [PATCH 1/2] sp5100_tco: Fix wrong indirect I/O access for getting value of reserved bits

2013-01-30 Thread Wim Van Sebroeck
Hi, > In case of SB800 or later chipset and re-programming MMIO address(*), > sp5100_tco module may read incorrect value of reserved bit, because the module > reads a value from an incorrect I/O address. However, this bug doesn't cause > a problem, because when re-programming MMIO address, by chan

Re: [PATCH 2/2] sp5100_tco: Write back the original value to reserved bits, instead of zero

2013-01-30 Thread Wim Van Sebroeck
Hi, > In case of SP5100 or SB7x0 chipsets, the sp5100_tco module writes zero to > reserved bits. The module, however, shouldn't depend on specific default > value, and should perform a read-merge-write operation for the reserved > bits. > > This patch makes the sp5100_tco module perform a read-me

Re: [PATCH] watchdog: da9055_wdt needs to select WATCHDOG_CORE

2013-01-30 Thread Wim Van Sebroeck
9f4b): undefined reference to > `watchdog_register_device' > > Signed-off-by: Randy Dunlap > Cc: David Dajun Chen > Cc: Wim Van Sebroeck > Cc: linux-watch...@vger.kernel.org > --- > drivers/watchdog/Kconfig |1 + > 1 file changed, 1 insertion(+) > > Fou

Re: [PATCH 10/19] watchdog: at91sam9: at91_wdt_dt_ids cannot be __init

2013-01-30 Thread Wim Van Sebroeck
(.data+0x28): Section mismatch in > reference from the variable at91wdt_driver to the (unknown reference) > .init.rodata:(unknown) > The variable at91wdt_driver references > the (unknown reference) __initconst (unknown) > > Signed-off-by: Arnd Bergmann > Cc: Wim Van Sebroeck

Re: [PATCH] orion_wdt: Add platform alias

2013-01-30 Thread Wim Van Sebroeck
Hi Lubomir, > ...so that it's automatically picked up on relevant platforms. > Tested on Kirkwood-based GuruPlug. > > Signed-off-by: Lubomir Rintel > --- > drivers/watchdog/orion_wdt.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/watchdog/orion_wdt.c b/

Re: [PATCH 3/4] watchdog: add support for ux500_wdt watchdog

2013-01-28 Thread Wim Van Sebroeck
Hi Fabio, > This patch adds support for the ux500_wdt watchdog that is found in > ST-Ericsson Ux500 platform. The driver is based on PRCMU APIs. > > Acked-by: Lee Jones > Signed-off-by: Fabio Baltieri > +static int timeout = WATCHDOG_TIMEOUT; > +module_param(timeout, int, 0); > +MODULE_PARM_D

Re: [next-20130227] kernel NULL pointer dereference [ watchdog | perf related ? ]

2013-02-27 Thread Wim Van Sebroeck
Hi Sedat, > I have reported this issue several times (first for next-20130223) to > LKML and Linux-Next MLs but got no answer. > I am unsure which is the root cause for all this trouble. > > Can someone have a look at this, please? > > [0.065787] smpboot: CPU0: Intel(R) Core(TM) i5-2467M CPU

Re: [wathdog] GitWeb service not available?

2013-02-27 Thread Wim Van Sebroeck
Hi Sedat, > while digging into a Linux-Next issue [0] I wanted to browse the > watchdog GitWeb, but it seems not to be available for me! Correct. I disabled it because the server has not enough memory... Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCH] Enhanced support for MPC8xx/8xxx watchdog

2013-02-27 Thread Wim Van Sebroeck
Hi Christophe, > This patch modifies the behaviour of the MPC8xx/8xxx watchdog. On the MPC8xx, > at 133Mhz, the maximum timeout of the watchdog timer is 1s, which means it > must > be pinged twice a second. This is not in line with the Linux watchdog concept > which is based on a default watchdog

Re: [PATCH V6 2/5] watchdog: sp805_wdt depends on ARM

2013-02-27 Thread Wim Van Sebroeck
; > Signed-off-by: Alessandro Rubini > Acked-by: Giancarlo Asnaghi > Signed-off-by: Davide Ciminaghi > Acked-by: Wim Van Sebroeck > Acked-by: Linus Walleij > Acked-by: Viresh Kumar > Signed-off-by: H. Peter Anvin Added to linux-watchdog-next. Kind regards, Wim. -- To un

Re: [PATCH] watchdog: omap_wdt: Add option nowayout

2013-02-18 Thread Wim Van Sebroeck
Hi Pali, > Like other watchdog drivers, this patch adds new option nowayout > which overwrite WATCHDOG_NOWAYOUT. Added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH V2] watchdog: davinci_wdt: update to devm_* API

2013-02-19 Thread Wim Van Sebroeck
Hi Kumar, > Update the code to use devm_* API so that driver > core will manage resources. > > Signed-off-by: Kumar, Anil Added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kern

[GIT PULL REQUEST] watchdog - v3.6-rc3 Fixes

2012-08-29 Thread Wim Van Sebroeck
delay.h header file was included twice. Signed-off-by: Sachin Kamat Signed-off-by: Wim Van Sebroeck commit 4b1c2f41c2dda158bb7a3dded70775a76b581995 Author: Randy Dunlap Date: Mon Jul 23 10:46:11 2012 -0700 watchdog: fix watchdog-test.c build warning Fix compiler

Re: [PATCH] watchdog: fix a compiler warning of test program

2012-08-30 Thread Wim Van Sebroeck
And the fix is in Linus his tree also now. Kind regards, Wim. > On 08/29/2012 06:39 AM, yan wrote: > > > This patch fixs the following compiler warning: > > > > > Hi, > This is already fixed in the watchdog git tree. > > Thanks. > > > Documentation/watchdog/src/watchdog-test.c:34:6: \ > > w

Re: [PATCH v2] watchdog/imx2+: add support for pretimeout interrupt functionality

2012-09-11 Thread Wim Van Sebroeck
Hi Oskar, > This watchdog device provides pretimeout facilities: > Set some timeout value and get informed about imminent > watchdog activity thru interrupt. > > Allow user to wait for this interrupt thru poll(2), > and to clear it thru read(2). > > Signed-off-by: Oskar

Re: [PATCH] wdt:clk: preparation for switch to common clock framework

2012-09-11 Thread Wim Van Sebroeck
Hi Karicheri, > >> -Original Message- > >> From: Karicheri, Muralidharan > >> Sent: Thursday, August 30, 2012 2:29 PM > >> To: linux-kernel@vger.kernel.org; mturque...@linaro.org; linux- > >> watch...@vger.kernel.org; w...@iguana.be > >> Cc: Karicheri, Muralidharan > >> Subject: [PATCH] wd

Re: kernel panic on 2.6.24/iTCO_wdt not rebooting machine

2008-02-02 Thread Wim Van Sebroeck
Hi Denys, > Probably someone can help me with this? Or it is hardware bug of chipset? > I will try to look more docs, maybe i will be able to find whats wrong there. I'll have a look at it next week. Greetings, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: [Patch v1 6/7] DA9055 Watchdog driver

2012-09-24 Thread Wim Van Sebroeck
Hi Ashish > Any update on this patch? > On Fri, 2012-09-14 at 19:03 +0530, Ashish Jangam wrote: > > This is the Watchdog patch for the DA9055 PMIC. This patch has got > > dependency on the DA9055 MFD core. > > > > This patch is functionally tested on SMDK6410 > > > > Signed-off-by: David Dajun C

Re: [PATCH] watchdog: softdog: remove replaceable ping operation

2013-07-09 Thread Wim Van Sebroeck
Hi Milo, > In watchdog_ping(), 'start' is called automatically when 'ping' function call > is not configured. > Softdog driver has same handling in both cases - start and ping, so 'ping' OPS > can be removed. > > Signed-off-by: Milo(Woogyom) Kim > --- > drivers/watchdog/softdog.c |1 - > 1

Re: [GIT PULL REQUEST] watchdog - v3.11-rc1

2013-07-13 Thread Wim Van Sebroeck
Hi Stephen, > On Thu, 11 Jul 2013 22:34:24 +0200 Wim Van Sebroeck wrote: > > > > Please pull from 'master' branch of > > git://www.linux-watchdog.org/linux-watchdog.git > > This was all rebased in the last day from what has been in linux-next for >

Re: linux-next: problem fetching the watchdog tree

2013-09-05 Thread Wim Van Sebroeck
Hi Stephen, > Fetching the wireless tree yesterday and today produced this error: > > fatal: unable to connect to www.linux-watchdog.org: > www.linux-watchdog.org[0: 83.149.101.17]: errno=Connection refused Strange. I had a git zombie process, got rid of it i2 days ago and restarted git but appa

[GIT PULL REQUEST] watchdog - v3.11-rc1 patches

2013-09-12 Thread Wim Van Sebroeck
return ret;\) } ... when != res + res = platform_get_resource(pdev, IORESOURCE_MEM, n); e = devm_ioremap_resource(e1, res); // Signed-off-by: Julia Lawall Reviewed-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck commit 8ecc7d2b2207ed9642e3d0140bfaa8c93a6ea47f Aut

[GIT PULL REQUEST] watchdog - v3.12-rc4 Fixes

2013-10-10 Thread Wim Van Sebroeck
main) iLO device. All auxilary iLO devices will have a subsystem device ID set to 0x1979 in order for hpwdt to differentiate between the two types. Signed-off-by: Thomas Mingarelli Tested-by: Lisa Mitchell Signed-off-by: Wim Van Sebroeck For completeness, I added the o

Re: [PATCH 0/7] Drop support for Renesys H8/300 architecture

2013-08-30 Thread Wim Van Sebroeck
Hi Guenter, > H8/300 has been dead for several years, the kernel for it has > not compiled for ages, and recent versions of gcc for it are broken. > It is time to drop support for it. > > Yes, I understand it is not that simple to drop an architecture, > and it may need some discussion, but someo

Re: [PATCH] hpwdt: Fix kdump issue in hpwdt

2012-09-10 Thread Wim Van Sebroeck
Hi Toshi, > kdump can be interrupted by watchdog timer when the timer is left > activated on the crash kernel. Changed the hpwdt driver to disable > watchdog timer at boot-time. This assures that watchdog timer is > disabled until /dev/watchdog is opened, and prevents watchdog timer > to be left r

[GIT PULL REQUEST] watchdog - v3.8-rc1 Fixes

2013-01-02 Thread Wim Van Sebroeck
03:37 2012 +0200 watchdog: twl4030_wdt: add DT support Add DT support for twl4030_wdt. This is needed to get twl4030_wdt to probe when booting with DT. Signed-off-by: Aaro Koskinen Signed-off-by: Wim Van Sebroeck commit 412b3729dd0234771c67452b8999191f1e8d8630 Au

Re: [PATCH v3] watchdog: Add hook for kicking in kdump path

2013-05-30 Thread Wim Van Sebroeck
Hi Guenter, > > Only when you set the .parent field in the watchdog_device data you will > > get the > > referal in the /sys/class/... tree. In iTCO_wdt.c you have the following > > code > > that does that: iTCO_wdt_watchdog_dev.parent = dev->dev.parent; > > > > From the watchdog-kernel-api doc

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

2013-05-30 Thread Wim Van Sebroeck
Hi Johannes, > On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote: > [...] > > > + watchdog_set_drvdata(&a21_wdt, drv); > > > > I am missing the initialisation of the watchdog's timeout value here... > > This watchdog only knows two time

Re: [PATCH v3] watchdog: Add hook for kicking in kdump path

2013-05-30 Thread Wim Van Sebroeck
Hi Guenter, > > Only when you set the .parent field in the watchdog_device data you will > > get the > > referal in the /sys/class/... tree. In iTCO_wdt.c you have the following > > code > > that does that: iTCO_wdt_watchdog_dev.parent = dev->dev.parent; > > > > From the watchdog-kernel-api doc

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

2013-05-30 Thread Wim Van Sebroeck
Hi Guenter, > On Tue, May 28, 2013 at 10:10:53AM +0200, Johannes Thumshirn wrote: > > On Mon, May 27, 2013 at 08:25:54PM +0200, Wim Van Sebroeck wrote: > > [...] > > > > + watchdog_set_drvdata(&a21_wdt, drv); > > > > > > I am missing the in

Re: [PATCH v4 2/2] watchdog: Add sysfs interface for MEN A21 watchdog

2013-05-30 Thread Wim Van Sebroeck
Hi Johannes, > Ok I'll do. Should I repost this as a change of this patch or the "add driver" > patch? the add driver patch. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 3/3] watchdog: xilinx: Add WDIOC_SETTIMEOUT ioctl function

2013-05-30 Thread Wim Van Sebroeck
Hi All, > > On Thu, May 30, 2013 at 05:12:24PM +0200, Michal Simek wrote: > > > On 05/30/2013 05:03 PM, Guenter Roeck wrote: > > > > On Thu, May 30, 2013 at 04:34:02PM +0200, Michal Simek wrote: > > > >> On 05/30/2013 04:21 PM, Guenter Roeck wrote: > > > >>> On Thu, May 30, 2013 at 04:15:45PM +020

Re: modalias char-major-10-130

2013-07-05 Thread Wim Van Sebroeck
Hi Jean, > All watchdog drivers include: > > MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR); > > which causes a modalias char-major-10-130 to be added to every watchdog > driver module. As a result, any access to /dev/watchdog on a system with > no watchdog driver loaded and working will result in an atte

Re: [PATCH RESEND v10 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

2013-07-05 Thread Wim Van Sebroeck
Hi Johannes, > This patch adds the driver for the watchdog devices found on MEN Mikro > Elektronik A21 VMEbus CPU Carrier Boards. It has DT-support and uses the > watchdog framework. > > Signed-off-by: Johannes Thumshirn > Reviewed-by: Guenter Roeck I added this patch to linux-watchdog-next. I

Re: [PATCH RESEND v10 2/2] watchdog: Sysfs interface for MEN A21 watchdog

2013-07-05 Thread Wim Van Sebroeck
Hi Johannes, > This patch adds a sysfs interface for the watchdog > device found on MEN A21 Boards. > > The newly generated files are: > * rebootcause: > Can be one of: > Power on Reset, > CPU Reset Request, > Push Button, > FPGA Reset Request, > Watchdog, > Local Power Bad, > Invalid or > BDI >

Re: [PATCH v2 0/2] Xilinx watchdog changes

2013-06-27 Thread Wim Van Sebroeck
Hi Michal, > The patchset fixes license header and add 1.00.a IP to compatible > list. > > Thanks for your review, > Michal > > Remove the 3rd patch from this series which incorrectly > tried to support set timeout feature. > > Changes in v2: > - Extend compatible list with 1.00.a instead of re

Re: [PATCH] [RFC]Watchdog:core: constant pinging until userspace timesout when delay very less

2013-06-27 Thread Wim Van Sebroeck
ess than or equal to 1 second(basically small values). > > As suggested by Wim Van Sebroeck & Guenter Roeck we should > add this functionality of individual watchdog drivers in the core > watchdog core. Have you considered the effect this change has on all watchdog drivers that do

Re: [PATCH v5] watchdog: Add Broadcom BCM2835 watchdog timer driver

2013-06-27 Thread Wim Van Sebroeck
Hi Lubomir, > This adds a driver for watchdog timer hardware present on Broadcom BCM2835 > SoC, > used in Raspberry Pi and Roku 2 devices. > > Signed-off-by: Lubomir Rintel > Tested-by: Stephen Warren > Cc: Stephen Warren > Cc: Wim Van Sebroeck > Cc: Guenter

Re: [PATCH v3 0/4] Kontron PLD drivers

2013-06-27 Thread Wim Van Sebroeck
s well, although the > respective maintainers can safely carry them as they all have a Kconfig > dependency on MFD_KEMPLD. So it's up to them. > If I have to take them, I'd need Wolfram's ACK for the i2c one and Wim's > for the watchdog one. Linus already ACKed th

Re: [PATCH v2 0/8] watchdog: w83627hf: Convert to watchdog infrastructure

2013-03-22 Thread Wim Van Sebroeck
Hi Guenter, > Convert to watchdog infrastructure, cleanup, add support for additional > chips, and merge with W83697HF and W83697UG watchdog drivers. > > Tested with W83627UHG, NCT6775, NCT6776. Additional test feedback > for other chips would be appreciated. > > Original idea was to prepare the

[RFC] winbond Super-I/O MFD driver

2013-03-22 Thread Wim Van Sebroeck
ommit dc8987180ad87da86740448f033b8cfe46ea90dd Author: Wim Van Sebroeck Date: Fri Mar 22 22:02:16 2013 +0100 Sample Winbond Super-I/O MFD device consisting out of a lowel-level driver that does the detection and creates the platform-data and a watchdog driver. diff --git a/driver

[GIT PULL REQUEST] watchdog - v3.9-rc4 Fixes

2013-03-22 Thread Wim Van Sebroeck
documented misused bit 2 seems to be zero. However, the sp5100_tco driver should use the correct bitmask value. [1] http://support.amd.com/us/Embedded_TechDocs/45482.pdf Signed-off-by: Takahisa Tanaka Signed-off-by: Paul Menzel Signed-off-by: Wim Van Sebroe

Re: [PATCH v2 0/8] watchdog: w83627hf: Convert to watchdog infrastructure

2013-03-23 Thread Wim Van Sebroeck
Hi Guenter, > > In 2011 I started something similar but then with the MFD approach in mind. > > Goal was also to clean-up the w836* watchdog drivers and get a clean driver > > that > > supports all Winbond super-I/O based watchdog drivers. > > > > I dug op the development code again. I'll post i

Re: [GIT PULL REQUEST] watchdog - v3.9-rc4 Fixes

2013-03-23 Thread Wim Van Sebroeck
Hi Linus, > > > > Please pull from 'master' branch of > > git://www.linux-watchdog.org/linux-watchdog.git > > That host seems to be a little sick right now. I'm not getting > anything from it, just a very long wait followed by "Connection reset > by peer". I restarted the git daemon. It

Re: [PATCH v10 04/12] watchdog: add Palmas Watchdog support

2013-08-20 Thread Wim Van Sebroeck
Hi Ian, > +static int palmas_wdt_set_timeout(struct watchdog_device *wdt, unsigned > timeout) > +{ > + struct palmas_wdt *driver_data = watchdog_get_drvdata(wdt); > + > + if (timeout < 1 || timeout > 128) { > + dev_warn(driver_data->dev, > + "Timeout can on

Re: linux-next: failure to fetch the watchdog tree

2013-03-05 Thread Wim Van Sebroeck
Hi Stephen, > Fetching the watchdog tree produces this message: > > fatal: unable to connect to www.linux-watchdog.org: > www.linux-watchdog.org[0: 83.149.101.17]: errno=Connection refused Thanks for pointing this out, I'll have a look at it. Kind regards, Wim. -- To unsubscribe from this list

Re: [RFC 36/42] drivers/watchdog: don't check resource with devm_ioremap_resource

2013-05-12 Thread Wim Van Sebroeck
Hi Wolfram, > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang Acked-by: Wim Van Sebroeck > --- > drivers/watchdog/imx2_wdt.c |5 - > 1 file changed, 5 deletions(-) >

Re: linux-next: comment on the watchdog tree

2013-05-13 Thread Wim Van Sebroeck
Hi Stephen, > Since the watchdog tree now consists only of merge commits (relative to > v3.10-rc1), you might as well just reset it to v3.10-rc1 and have a nice > clean tree to start from. Absolutely correct. I fixed it. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubs

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Wim Van Sebroeck
Hi Samuel, > > MFD core driver for various variants of Winbond/Nuvoton SuperIO chips. > > > > Signed-off-by: Guenter Roeck > > --- > > drivers/mfd/Kconfig | 22 +++ > > drivers/mfd/Makefile |1 + > > drivers/mfd/w83627hf-core.c | 324 > > +++

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Wim Van Sebroeck
Hi Guenter, > I was waiting for feedback from Wim, who submitted a similar driver, about his > thoughts. Key question is how to reserve access to the shared resource - > either > through an exported function in the mfd driver requesting a mutex, or through > request_muxed_region(). I am going bac

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Wim Van Sebroeck
Hi Guenter, > > > I was waiting for feedback from Wim, who submitted a similar driver, > > > about his > > > thoughts. Key question is how to reserve access to the shared resource - > > > either > > > through an exported function in the mfd driver requesting a mutex, or > > > through > > > requ

Re: mfd: Core driver for Winbond chips

2013-04-10 Thread Wim Van Sebroeck
Hi Guenter, > > I looked at commit 8b6d043b7ee2d1b819dc833d677ea2aead71a0c0 (which > > implements > > request_muxed_region). You indeed need some extra code for loading the > > lowl-level > > mfd driver. So I am also in favour of the exported function. > > > So which way should we go ? Take you

Re: linux-next: unable to fetch the watchdog tree

2013-05-07 Thread Wim Van Sebroeck
Hi Stephen, > Trying to fetch the watchdog tree > (git://www.linux-watchdog.org/linux-watchdog-next.git#master) > pauses for a long time, and then produces this error: > > fatal: read error: Connection reset by peer > > I will continue to use what I previously fetched. Thanks for pointing it ou

[GIT PULL REQUEST] watchdog - v3.10-rc1 patches

2013-05-08 Thread Wim Van Sebroeck
Seen with systemd trying to open /dev/watchdog immediately after it was created. Reported-by: Arkadiusz Miskiewicz Signed-off-by: Guenter Roeck Tested-by: Arkadiusz Miskiewicz Signed-off-by: Wim Van Sebroeck commit 6330c7070be6783b82025d2bc259db8413c00182 Author: Sa

[GIT PULL REQUEST] watchdog - v3.9-rc6 Fixes

2013-04-14 Thread Wim Van Sebroeck
200: add DT support) seems to be the good solution. Signed-off-by: Nicolas Ferre Acked-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck For completeness, I added the overal diff below. Greetings, Wim. ==

Re: [GIT PULL REQUEST] watchdog - v3.9-rc6 Fixes

2013-04-15 Thread Wim Van Sebroeck
Hi Guenter, > > Please pull from 'master' branch of > > git://www.linux-watchdog.org/linux-watchdog.git > > > > It will fix compile errors for teh at91rm9200_wdt driver. > > > > This will update the following files: > > > > Kconfig |2 +- > > 1 files changed, 1 insertion(+), 1 deletion

Re: [PATCH V2 1/7] watchdog: at32ap700x_wdt: use devm_*() functions

2013-05-25 Thread Wim Van Sebroeck
Hi Jingoo, > Use devm_*() functions to make cleanup paths simpler. > > Acked-by: Guenter Roeck > Signed-off-by: Jingoo Han Patch added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@v

Re: [PATCH V2 2/7] watchdog: bcm63xx_wdt: use devm_ioremap_nocache()

2013-05-25 Thread Wim Van Sebroeck
Hi Jingoo, > Use devm_ioremap_nocache() to make cleanup paths simpler. > > Reviewed-by: Guenter Roeck > Signed-off-by: Jingoo Han > --- > No changes since v1: > > drivers/watchdog/bcm63xx_wdt.c |9 - > 1 files changed, 4 insertions(+), 5 deletions(-) Patch added to linux-watchdog

Re: [PATCH V2 3/7] watchdog: mv64x60_wdt: use devm_ioremap()

2013-05-25 Thread Wim Van Sebroeck
Hi Jingoo, > Use devm_ioremap() to make cleanup paths simpler. > > Reviewed-by: Guenter Roeck > Signed-off-by: Jingoo Han > --- > No changes since v1: > > drivers/watchdog/mv64x60_wdt.c |4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > Patch added to linux-watchdog-next. Ki

Re: [PATCH V2 4/7] watchdog: nuc900_wdt: use devm_*() functions

2013-05-25 Thread Wim Van Sebroeck
Hi Jingoo, > Use devm_*() functions to make cleanup paths simpler. > > Signed-off-by: Jingoo Han > --- > Changes since v1: > - used sizeof(*nuc900_wdt) instead of sizeof(struct nuc900_wdt) > - declared 'nuc900_wdt->res' variable as logical variable > > drivers/watchdog/nuc900_wdt.c | 50 > +

Re: [PATCH V2 5/7] watchdog: rc32434_wdt: use devm_ioremap_nocache() functions

2013-05-25 Thread Wim Van Sebroeck
Hi Jingoo, > Use devm_ioremap_nocache() functions to make cleanup paths simpler. > > Reviewed-by: Guenter Roeck > Signed-off-by: Jingoo Han > --- > No changes since v1: > > drivers/watchdog/rc32434_wdt.c | 10 +++--- > 1 files changed, 3 insertions(+), 7 deletions(-) > Patch added to

Re: [PATCH V2 6/7] watchdog: riowd: use devm_kzalloc()

2013-05-25 Thread Wim Van Sebroeck
Hi Jingoo, > Use devm_kzalloc() to make cleanup paths simpler. > > Reviewed-by: Guenter Roeck > Signed-off-by: Jingoo Han > --- > No changes since v1: > > drivers/watchdog/riowd.c |8 ++-- > 1 files changed, 2 insertions(+), 6 deletions(-) > Patch added to linux-watchdog-next. Kind

Re: [PATCH 4/5] watchdog: riowd: use platform_{get,set}_drvdata()

2013-05-25 Thread Wim Van Sebroeck
Hi Jingoo, > Use the wrapper functions for getting and setting the driver data using > platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, > so we can directly pass a struct platform_device. > > Signed-off-by: Jingoo Han > --- > drivers/watchdog/riowd.c |4 ++-- > 1 fi

Re: [PATCH V3 7/7] watchdog: ts72xx_wdt: use devm_*() functions

2013-05-25 Thread Wim Van Sebroeck
Hi Jingoo, > Use devm_*() functions to make cleanup paths simpler. > > Signed-off-by: Jingoo Han > --- > Changes since v2: > - removed unnecessary platform_set_drvdata(pdev, NULL) > > drivers/watchdog/ts72xx_wdt.c | 67 ++-- > 1 files changed, 10 insertion

Re: [PATCH RESEND 1/5] watchdog: dw_wdt: use devm_clk_get()

2013-05-25 Thread Wim Van Sebroeck
Hi Jingoo, > Use devm_clk_get() to make cleanup paths more simple. > > Signed-off-by: Jingoo Han > --- > drivers/watchdog/dw_wdt.c |7 ++- > 1 files changed, 2 insertions(+), 5 deletions(-) > Patch added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: sen

Re: [PATCH RESEND 2/5] watchdog: imx2_wdt: use devm_clk_get()

2013-05-25 Thread Wim Van Sebroeck
Hi Jingoo, > Use devm_clk_get() to make cleanup paths more simple. > > Signed-off-by: Jingoo Han > --- > drivers/watchdog/imx2_wdt.c |6 ++ > 1 files changed, 2 insertions(+), 4 deletions(-) > Patch added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: s

Re: [PATCH RESEND 3/5] watchdog: pnx4008_wdt: use devm_clk_get()

2013-05-25 Thread Wim Van Sebroeck
Hi Jingoo, > Use devm_clk_get() to make cleanup paths more simple. > > Signed-off-by: Jingoo Han > --- > drivers/watchdog/pnx4008_wdt.c |7 ++- > 1 files changed, 2 insertions(+), 5 deletions(-) > Patch added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this lis

Re: [PATCH RESEND 4/5] watchdog: shwdt: use devm_clk_get()

2013-05-25 Thread Wim Van Sebroeck
Hi Jingoo, > Use devm_clk_get() to make cleanup paths more simple. > > Signed-off-by: Jingoo Han > --- > drivers/watchdog/shwdt.c | 16 > 1 files changed, 4 insertions(+), 12 deletions(-) > Patch added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this

Re: [PATCH RESEND 5/5] watchdog: sp805_wdt: use devm_clk_get()

2013-05-25 Thread Wim Van Sebroeck
Hi Jingoo, > Use devm_clk_get() to make cleanup paths more simple. > > Signed-off-by: Jingoo Han > --- > drivers/watchdog/sp805_wdt.c |7 ++- > 1 files changed, 2 insertions(+), 5 deletions(-) > Patch added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list:

Re: [PATCH RESEND 1/2] watchdog: mtx1-wdt: use devm_gpio_request_one()

2013-05-26 Thread Wim Van Sebroeck
Hi Jingoo, > Use devm_gpio_request_one() to make cleanup paths simpler. > > Signed-off-by: Jingoo Han > --- > drivers/watchdog/mtx-1_wdt.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > Patch added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list

Re: [PATCH 5/5] watchdog: wm831x: use platform_{get,set}_drvdata()

2013-05-26 Thread Wim Van Sebroeck
Hi Jingoo, > Use the wrapper functions for getting and setting the driver data using > platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, > so we can directly pass a struct platform_device. > > Signed-off-by: Jingoo Han > --- > drivers/watchdog/wm831x_wdt.c |4 ++-- >

Re: [PATCH RESEND 2/2] watchdog: wm831x_wdt: use devm_gpio_request_one()

2013-05-26 Thread Wim Van Sebroeck
Hi Jingoo, > Use devm_gpio_request_one() to make cleanup paths simpler. > Also, GPIOF_DIR_OUT | GPIOF_INIT_LOW is replaced with > GPIOF_OUT_INIT_LOW. > > Signed-off-by: Jingoo Han > --- > drivers/watchdog/wm831x_wdt.c | 17 ++--- > 1 files changed, 6 insertions(+), 11 deletions(-)

Re: [PATCH 1/5] watchdog: cpwd: use platform_{get,set}_drvdata()

2013-05-26 Thread Wim Van Sebroeck
Hi Jingoo, > Use the wrapper functions for getting and setting the driver data using > platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, > so we can directly pass a struct platform_device. > > Signed-off-by: Jingoo Han > --- > drivers/watchdog/cpwd.c |4 ++-- > 1 fil

Re: [PATCH 2/5] watchdog: da9052: use platform_{get,set}_drvdata()

2013-05-26 Thread Wim Van Sebroeck
Hi Jingoo, > Use the wrapper functions for getting and setting the driver data using > platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, > so we can directly pass a struct platform_device. > > Signed-off-by: Jingoo Han > --- > drivers/watchdog/da9052_wdt.c |4 ++-- >

Re: [PATCH 3/5] watchdog: da9055: use platform_{get,set}_drvdata()

2013-05-26 Thread Wim Van Sebroeck
Hi Jingoo, > Use the wrapper functions for getting and setting the driver data using > platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, > so we can directly pass a struct platform_device. > > Signed-off-by: Jingoo Han > --- > drivers/watchdog/da9055_wdt.c |4 ++-- >

Re: [PATCH v4] watchdog: Add Broadcom BCM2835 watchdog timer driver

2013-05-26 Thread Wim Van Sebroeck
nd/or commit > description. > > This current patch sees to be a slight hybrid of both approaches (you're > listed as the git author, but have included Dom's s-o-b line on a patch > I don't think he created, and wasn't directly derived from one he created). > &g

Re: [PATCH v3] watchdog: New watchdog driver for MEN A21 watchdogs

2013-05-26 Thread Wim Van Sebroeck
Hi Johannes, > +static int a21_wdt_notify_sys(struct notifier_block *notify, unsigned long > code, > + void *unused) > +{ > + if (code == SYS_DOWN || code == SYS_HALT) > + gpio_set_value(GPIO_WD_ENAB, 0); > + > + return NOTIFY_DONE; > +} > + > +static struc

Re: [PATCH 4/4] watchdog: Kontron PLD watchdog timer

2013-05-26 Thread Wim Van Sebroeck
Hi Kevin, > On Wed, Apr 10, 2013 at 09:47:17AM -0700, Guenter Roeck wrote: > > On Mon, Apr 08, 2013 at 10:15:21AM -0700, Kevin Strasser wrote: > > > From: Michael Brunner > > > > > > Add watchdog timer support for the on-board PLD found on some Kontron > > > embedded modules. > > > > > > Signed

Re: [PATCH] watchdog: jz4740: Pass device to clk_get

2013-05-26 Thread Wim Van Sebroeck
Hi Lars-Peter, > In preparation to switching the jz4740 clk driver to the common clk framework > make sure to pass the device to clk_get(). > > Signed-off-by: Lars-Peter Clausen > --- > drivers/watchdog/jz4740_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Patch added to linu

Re: [PATCH v3] watchdog: core: don't try to stop device if not running

2013-05-26 Thread Wim Van Sebroeck
Hi Hector, > A watchdog device may be stopped from userspace using WDIOC_SETOPTIONS > ioctl and flag WDIOS_DISABLECARD. If the device is closed after this > operation, watchdog_release() is called and status bits checked for > stopping it. Besides, if the device has not been unregistered a critica

Re: [PATCH] powerpc: Make Book E watchdog reset type configurable

2013-05-26 Thread Wim Van Sebroeck
Hi Dirk, > having a closer look, I realized booke_wdt is not device-tree based > yet. Migrating it would come close to a rewrite, breaking compatibility > for all current users. Sorry, this is way beyond the time I have for > this project. So I suggest merging the change the way it is, as it is

Re: [PATCH v3] watchdog: New watchdog driver for MEN A21 watchdogs

2013-05-27 Thread Wim Van Sebroeck
Hi Johannes, > Of cause I'll do, but unfortunately I probably won't be able to do it today, > mind if you get the patch tomorrow? I don't mind. There is no rush. Just take the time you need to change the code and do your testing. Kind regards, wim. -- To unsubscribe from this list: send the l

Re: [PATCH v4 1/2] watchdog: New watchdog driver for MEN A21 watchdogs

2013-05-27 Thread Wim Van Sebroeck
Hi Johannes, > This patch adds the driver for the watchdog devices found on MEN Mikro > Elektronik A21 VMEbus CPU Carrier Boards. It has DT-support and uses the > watchdog framework. > > Revision 2: > * Removed unneeded open flag in struct a21_wdt_drv > * Corrected 3bit reason code from gpio > *

Re: [PATCH v3] watchdog: Add hook for kicking in kdump path

2013-05-27 Thread Wim Van Sebroeck
Hi Guenter, > > Hi Guenter, > > > > Is there an easy way to determine which driver is loaded for each > > /dev/watchdogN device (from a script perspective). > > > > Basically, I wanted to determine the module that needs to be included in > > the kdump initrd image. > > > Sometimes. For example

Re: [PATCH v4 2/2] watchdog: Add sysfs interface for MEN A21 watchdog

2013-05-27 Thread Wim Van Sebroeck
Hi Johannes, > This patch adds a sysfs interface for the watchdog device found on MEN A21 > Boards. > > The newly generated files are: > * rebootcause: > Can be one of: > Power on Reset, > CPU Reset Request, > Push Button, > FPGA Reset Request, > Watchdog, > Local Power Bad, > Invalid or > BDI >

Re: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global

2012-08-22 Thread Wim Van Sebroeck
Hi andi, > From: Andi Kleen > > We cannot assume that the inline assembler code always ends up > in the same file as the original C file. So make any assembler labels > that are called with "extern" by C global > > Cc: w...@iguana.be > Signed-off-by: Andi Kleen You have my signed-off-by, but

Re: [PATCH] lpc_ich: Fix a 3.5 kernel regression for iTCO_wdt driver

2012-08-22 Thread Wim Van Sebroeck
ks for iTCO_wdt to keep the same behavior as > 3.4 kernel. > https://bugzilla.kernel.org/show_bug.cgi?id=44991 > > Actually the same check could be removed for the gpio-ich in lpc_ich.c, > but I'm not sure if it will cause problems. > > Signed-off-by: Feng Tang

Re: Build regressions/improvements in v3.6-rc3

2012-08-24 Thread Wim Van Sebroeck
Hi Randi, > > *** WARNINGS *** > > > > 6202 regressions: > > + Documentation/watchdog/src/watchdog-test.c: warning: no previous > > prototype for 'term' [-Wmissing-prototypes]: => 34:6 > > > patch posted by me... not merged anywhere AFAIK. is in linux-watchdog-next. Will go to Linus this w

[GIT PULL REQUEST] watchdog - v3.6-rc5 Fixes

2012-09-20 Thread Wim Van Sebroeck
a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun Signed-off-by: Wim Van Sebroeck commit 308b135e4fcc00c80c07e0e04e7afa8edf78583c Author: Toshi Kani Date: Mon Aug 27 12:52:24 2012 -0600 hpwdt: Fix kdump issue in hpwdt

[WATCHDOG] v2.5.25-rc patches

2008-02-19 Thread Wim Van Sebroeck
Random Access Memory (NVRAM). The logging of the event is performed using the HP ProLiant ROM via an Industry Standard access known as a BIOS Service Directory Entry. Signed-off-by: Thomas Mingarelli <[EMAIL PROTECTED]> Signed-off-by: Wim Van Sebroeck <[EMAIL PROTECTED]>

Re: DMI: add-type-41

2008-02-08 Thread Wim Van Sebroeck
Hi Matt, > > [PATCH] SMBIOS/DMI - add type 41 = Onboard Devices Extended Information > > Is there something in the kernel that will consume this data, or is it > being exported in /sys/class/dmi/id somehow? There will be one table > entry per device (Dell PowerEdge x9xx servers with recent B

[GIT PULL REQUEST] watchdog - v3.6 merge window

2012-07-23 Thread Wim Van Sebroeck
f-by: Axel Lin Tested-by: Andrew Lunn Signed-off-by: Wim Van Sebroeck commit 6b761b2902c56b468370e0ee1691c37e0dae042a Author: Sachin Kamat Date: Thu Jul 12 17:17:40 2012 +0530 watchdog: s3c2410_wdt: Use module_platform_driver() module_platform_driver() replaces module_

Re: [PATCH RFT] watchdog: Convert orion_wdt driver to watchdog core

2012-07-12 Thread Wim Van Sebroeck
Hi Axel, > 於 一,2012-06-18 於 16:01 +0200,Andrew Lunn 提到: > > On Fri, Jun 15, 2012 at 03:22:44PM +0800, Axel Lin wrote: > > > Convert the orion_wdt driver to the watchdog framework API. > > > > > > Signed-off-by: Axel Lin > > > > Hi Axel > > > > Tested-by: Andrew Lunn > > Hi Wim, > This patch

Re: [PATCH 3/4] watchdog: add support for ux500_wdt watchdog

2013-01-22 Thread Wim Van Sebroeck
Hi Samuel, > On Fri, Jan 18, 2013 at 12:40:13PM +0100, Fabio Baltieri wrote: > > This patch adds support for the ux500_wdt watchdog that is found in > > ST-Ericsson Ux500 platform. The driver is based on PRCMU APIs. > > > > Acked-by: Lee Jones > > Signed-off-by: Fabio Baltieri > > --- > > dri

Re: [PATCH v4 1/8] watchdog: add the function watchdog_is_open

2013-02-13 Thread Wim Van Sebroeck
Hi Wenyou, > Add the function watchdog_is_open to check whether or not > the /dev/watchdog? is opened > > Signed-off-by: Wenyou Yang > Cc: w...@iguana.be > Cc: linux-watch...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > include/linux/watchdog.h |8 > 1 file changed, 8

Re: [PATCH v4 2/8] watchdog/at91sam9_wdt: Remove at91wdt_private and add at91wdt_drvdata struct

2013-02-13 Thread Wim Van Sebroeck
Hi Wenyou, > Remove the global variable at91wdt_private, add the struct at91wdt_drvdata > as a substitute, and set it as the driver data of the at91wdt_wdd. I rather have this after the conversion of the watchdog to the new framework. Kind regards, Wim. -- To unsubscribe from this list: send th

  1   2   3   4   5   >