Re: [V5 PATCH 00/26] mm, memory-hotplug: dynamic configure movable memory and introduce movable node

2012-10-30 Thread Yasuaki Ishimatsu
of kernelcore_max_addr [PATCH 19 - 25] - Bug fix [PATCH 26] Why don't you separate the patch-set into each feature development? By separating the patch-set, many people can easily participate in your development. Thanks, Yasuaki Ishimatsu 2012/10/30 0:07, Lai Jiangshan wrote: Movable memory is a very important

Re: [PATCH v2] acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-10-31 Thread Yasuaki Ishimatsu
Hi Greg, 2012/10/27 0:25, Greg Kroah-Hartman wrote: On Fri, Oct 26, 2012 at 04:33:49PM +0900, Yasuaki Ishimatsu wrote: Hi Greg, Sorry for late reply. 2012/10/20 2:59, Greg Kroah-Hartman wrote: On Fri, Oct 19, 2012 at 06:29:52AM +0200, Rafael J. Wysocki wrote: On Thursday 11 of October 2012

Re: [PATCH v3 0/3] ACPI: container hot remove support.

2012-10-31 Thread Yasuaki Ishimatsu
, container_device_remove() keeps hot remove operation. Finally, the function sends _EJ0 to firmware. In this case, if the memory is accessed, kernel panic occurs. The example is as follows: https://lkml.org/lkml/2012/9/26/318 Thanks, Yasuaki Ishimatsu change log v2 - v3: 1. Add 1 patch(patch1

Re: [PATCH v4] create sun sysfs file

2012-09-23 Thread Yasuaki Ishimatsu
Hi Len, Ping... I want you to merge the patch into your tree for linux-3.7. Thanks, Yasuaki Ishimatsu 2012/08/30 10:34, Yasuaki Ishimatsu wrote: Hi Len, Three weeks passed after I post the patch. All comments have already been applied to it. And I think there is no comments about it. So I

Re: hot-added cpu is not asiggned to the correct node

2012-09-25 Thread Yasuaki Ishimatsu
Hi Dan, At first, thank you for your comment. 2012/09/24 18:33, Dan Carpenter wrote: On Wed, Sep 12, 2012 at 02:33:11PM +0900, Yasuaki Ishimatsu wrote: When I hot-added CPUs and memories simultaneously using container driver, all the hot-added CPUs were mistakenly assigned to node0

[PATCH] x86: rename mp_register_lapic in a comment

2012-09-25 Thread Yasuaki Ishimatsu
Molnar mi...@kernel.org CC: H. Peter Anvin h...@zytor.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- arch/x86/kernel/acpi/boot.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-3.6-rc5/arch/x86/kernel/acpi/boot.c

[PATCH] x86: use the correct macros

2012-09-25 Thread Yasuaki Ishimatsu
This patch fixes to use the correct macros. CC: Len Brown l...@kernel.org CC: Thomas Gleixner t...@linutronix.de CC: Ingo Molnar mi...@kernel.org CC: H. Peter Anvin h...@zytor.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- arch/x86/kernel/acpi/boot.c |2 +- drivers

Re: [PATCH 2/4] memory-hotplug: add node_device_release

2012-09-27 Thread Yasuaki Ishimatsu
Hi Kosaki-san, 2012/09/28 5:13, KOSAKI Motohiro wrote: On Thu, Sep 27, 2012 at 1:45 AM, we...@cn.fujitsu.com wrote: From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com When calling unregister_node(), the function shows following message at device_release(). This description doesn't have

Re: [PATCH 1/4] memory-hotplug: add memory_block_release

2012-09-27 Thread Yasuaki Ishimatsu
Hi Chen, 2012/09/27 19:20, Ni zhan Chen wrote: Hi Congyang, 2012/9/27 we...@cn.fujitsu.com From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com When calling remove_memory_block(), the function shows following message at device_release(). Device 'memory528' does not have a release

Re: [PATCH 2/4] memory-hotplug: add node_device_release

2012-09-27 Thread Yasuaki Ishimatsu
Hi Kosaki-san, 2012/09/28 10:13, KOSAKI Motohiro wrote: On Thu, Sep 27, 2012 at 8:07 PM, Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com wrote: Hi Kosaki-san, 2012/09/28 5:13, KOSAKI Motohiro wrote: On Thu, Sep 27, 2012 at 1:45 AM, we...@cn.fujitsu.com wrote: From: Yasuaki Ishimatsu

Re: [PATCH 1/4] memory-hotplug: add memory_block_release

2012-09-27 Thread Yasuaki Ishimatsu
Hi Kosaki-san, 2012/09/28 10:35, KOSAKI Motohiro wrote: On Thu, Sep 27, 2012 at 8:24 PM, Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com wrote: Hi Chen, 2012/09/27 19:20, Ni zhan Chen wrote: Hi Congyang, 2012/9/27 we...@cn.fujitsu.com From: Yasuaki Ishimatsu isimatu.yasu

Re: [RFC v9 PATCH 01/21] memory-hotplug: rename remove_memory() to offline_memory()/offline_pages()

2012-09-27 Thread Yasuaki Ishimatsu
Hi Chen, 2012/09/28 11:22, Ni zhan Chen wrote: On 09/05/2012 05:25 PM, we...@cn.fujitsu.com wrote: From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com remove_memory() only try to offline pages. It is called in two cases: 1. hot remove a memory device 2. echo offline /sys/devices/system

Re: [PATCH 1/4] memory-hotplug: add memory_block_release

2012-09-28 Thread Yasuaki Ishimatsu
Hi Chen, 2012/09/28 15:04, Ni zhan Chen wrote: On 09/28/2012 11:45 AM, Yasuaki Ishimatsu wrote: Hi Kosaki-san, 2012/09/28 10:35, KOSAKI Motohiro wrote: On Thu, Sep 27, 2012 at 8:24 PM, Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com wrote: Hi Chen, 2012/09/27 19:20, Ni zhan Chen wrote

[PATCH 0/4] acpi,memory-hotplug : implement framework for hot removing memory

2012-10-03 Thread Yasuaki Ishimatsu
We are trying to implement a physical memory hot removing function as following thread. https://lkml.org/lkml/2012/9/5/201 But there is not enough review to merge into linux kernel. I think there are following blockades. 1. no physical memory hot removable system 2. huge patch-set If you

Re: [PATCH v4] create sun sysfs file

2012-10-03 Thread Yasuaki Ishimatsu
Hi Len, Ping... Pleae merge the patch into your tree. Thanks, Yasuaki Ishimatsu 2012/09/24 11:31, Yasuaki Ishimatsu wrote: Hi Len, Ping... I want you to merge the patch into your tree for linux-3.7. Thanks, Yasuaki Ishimatsu 2012/08/30 10:34, Yasuaki Ishimatsu wrote: Hi Len

[PATCH 1/4] acpi,memory-hotplug : add memory offline code to acpi_memory_device_remove()

2012-10-03 Thread Yasuaki Ishimatsu
From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com The memory device can be removed by 2 ways: 1. send eject request by SCI 2. echo 1 /sys/bus/pci/devices/PNP0C80:XX/eject In the 1st case, acpi_memory_disable_device() will be called. In the 2nd case, acpi_memory_device_remove

[PATCH 2/4] acpi,memory-hotplug : rename remove_memory() to offline_memory()

2012-10-03 Thread Yasuaki Ishimatsu
From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com add_memory() hot adds a physical memory. But remove_memory does not hot remove a phsical memory. It only offlines memory. The name confuse us. So the patch renames remove_memory() to offline_memory(). We will use rename_memory() for hot

[PATCH 3/6] acpi,memory-hotplug : add physical memory hotplug code to acpi_memhotplug.c

2012-10-03 Thread Yasuaki Ishimatsu
From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com For hot removing physical memory, the patch adds remove_memory() into acpi_memory_remove_memory(). But we cannot support physical memory hot remove. So remove_memory() do nothinig. CC: David Rientjes rient...@google.com CC: Jiang Liu liu

[PATCH 4/4] acpi,memory-hotplug : store the node id in acpi_memory_device

2012-10-03 Thread Yasuaki Ishimatsu
: Benjamin Herrenschmidt b...@kernel.crashing.org CC: Paul Mackerras pau...@samba.org CC: Christoph Lameter c...@linux.com Cc: Minchan Kim minchan@gmail.com CC: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com CC: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com

[PATCH 0/2] acpi,memory-hotplug : remove memory device by acpi_bus_remove()

2012-10-03 Thread Yasuaki Ishimatsu
The patch-set was divided from following thread's patch-set. https://lkml.org/lkml/2012/9/5/201 If you want to know the reason, please read following thread. https://lkml.org/lkml/2012/10/2/83 The patch exports acpi_bus_remove() for removing a acpi device from a acpi bus at memory hot plug.

[PATCH 1/2] acpi,memory-hotplug : export the function acpi_bus_remove()

2012-10-03 Thread Yasuaki Ishimatsu
From: Wen Congyang we...@cn.fujitsu.com The function acpi_bus_remove() can remove a acpi device from acpi bus. When a acpi device is removed, we need to call this function to remove the acpi device from acpi bus. So export this function. CC: Len Brown len.br...@intel.com Reviewed-by: Yasuaki

[PATCH 2/2] acpi,memory-hotplug : call acpi_bus_remo() to remove memory device

2012-10-03 Thread Yasuaki Ishimatsu
From: Wen Congyang we...@cn.fujitsu.com The memory device has been ejected and powoffed, so we can call acpi_bus_remove() to remove the memory device from acpi bus. CC: Len Brown len.br...@intel.com Reviewed-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Signed-off-by: Wen Congyang we

Re: [RFC v9 PATCH 16/21] memory-hotplug: free memmap of sparse-vmemmap

2012-10-04 Thread Yasuaki Ishimatsu
Hi Chen, Sorry for late reply. 2012/10/02 13:21, Ni zhan Chen wrote: On 09/05/2012 05:25 PM, we...@cn.fujitsu.com wrote: From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com All pages of virtual mapping in removed memory cannot be freed, since some pages used as PGD/PUD includes not only

Re: [PATCH 2/4] memory-hotplug: add node_device_release

2012-10-04 Thread Yasuaki Ishimatsu
Hi Kosaki-san, 2012/10/02 3:12, KOSAKI Motohiro wrote: On Mon, Oct 1, 2012 at 2:54 AM, Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com wrote: Hi Kosaki-san, 2012/09/29 7:19, KOSAKI Motohiro wrote: I don't understand it. How can we get rid of the warning? See cpu_device_release

[PATCH 0/10] memory-hotplug: hot-remove physical memory

2012-10-04 Thread Yasuaki Ishimatsu
The patch-set was divided from following thread's patch-set. https://lkml.org/lkml/2012/9/5/201 If you want to know the reason, please read following thread. https://lkml.org/lkml/2012/10/2/83 The patch-set has only the function of kernel core side for physical memory hot remove. So if you use

[PATCH 1/10] memory-hotplug : check whether memory is offline or not when removing memory

2012-10-04 Thread Yasuaki Ishimatsu
: Christoph Lameter c...@linux.com Cc: Minchan Kim minchan@gmail.com CC: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- drivers/base/memory.c

[PATCH 2/10] memory-hotplug : remove /sys/firmware/memmap/X sysfs

2012-10-04 Thread Yasuaki Ishimatsu
Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- drivers/firmware/memmap.c| 98 ++- include/linux/firmware-map.h |6 ++ mm/memory_hotplug.c |7 ++- 3 files changed

[PATCH 3/10] memory-hotplug : introduce new function arch_remove_memory() for removing page table depends on architecture

2012-10-04 Thread Yasuaki Ishimatsu
@gmail.com CC: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com CC: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- arch/ia64/mm/init.c| 18 ++ arch/powerpc/mm/mem.c

[PATCH 4/10] memory-hotplug : unregister memory section on SPARSEMEM_VMEMMAP

2012-10-04 Thread Yasuaki Ishimatsu
len.br...@intel.com CC: Christoph Lameter c...@linux.com Cc: Minchan Kim minchan@gmail.com CC: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com CC: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- mm

[PATCH 5/10] memory-hotplug : memory-hotplug: check page type in get_page_bootmem

2012-10-04 Thread Yasuaki Ishimatsu
: Jiang Liu liu...@gmail.com CC: Len Brown len.br...@intel.com CC: Christoph Lameter c...@linux.com Cc: Minchan Kim minchan@gmail.com CC: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com CC: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yasuaki

[PATCH 6/10] memory-hotplug : implement register_page_bootmem_info_section of sparse-vmemmap

2012-10-04 Thread Yasuaki Ishimatsu
...@jp.fujitsu.com Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- arch/ia64/mm/discontig.c |6 arch/powerpc/mm/init_64.c |6 arch/s390/mm/vmem.c|6 arch/sparc/mm/init_64.c|6

[PATCH 7/10] memory-hotplug : remove memmap of sparse-vmemmap

2012-10-04 Thread Yasuaki Ishimatsu
@gmail.com CC: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com CC: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- arch/ia64/mm/discontig.c |8 +++ arch/powerpc/mm/init_64.c |8 +++ arch/s390

[PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture

2012-10-04 Thread Yasuaki Ishimatsu
...@intel.com CC: Christoph Lameter c...@linux.com Cc: Minchan Kim minchan@gmail.com CC: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com CC: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- arch/x86/include/asm

[PATCH 9/10] memory-hotplug : memory_hotplug: clear zone when removing the memory

2012-10-04 Thread Yasuaki Ishimatsu
: Len Brown len.br...@intel.com CC: Christoph Lameter c...@linux.com Cc: Minchan Kim minchan@gmail.com CC: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Signed-off-by: Wen Congyang we

[PATCH 10/10] memory-hotplug : remove sysfs file of node

2012-10-04 Thread Yasuaki Ishimatsu
CC: Jiang Liu liu...@gmail.com CC: Len Brown len.br...@intel.com CC: Christoph Lameter c...@linux.com Cc: Minchan Kim minchan@gmail.com CC: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com CC: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Signed-off

Re: [PATCH] CPU hotplug, debug: Detect imbalance between get_online_cpus() and put_online_cpus()

2012-10-04 Thread Yasuaki Ishimatsu
with a hotplug writer. So, add a WARN_ON() in put_online_cpus() to detect such cases where the refcount can go negative, and also attempt to fix it up, so that we can continue to run. Signed-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com --- Looks good to me. Reviewed-by: Yasuaki

Re: [PATCH 1/2] acpi : cpu hot-remove returns error when cpu_down() fails

2012-10-18 Thread Yasuaki Ishimatsu
Hi Rafael, 2012/10/19 10:06, Rafael J. Wysocki wrote: On Friday 28 of September 2012 19:36:02 Yasuaki Ishimatsu wrote: Even if cpu_down() fails, acpi_processor_remove() continues to remove the cpu. But in this case, it should return error number since some process may run on the cpu

Re: [PATCH v3 0/9] bugfix for memory hotplug

2012-10-19 Thread Yasuaki Ishimatsu
Hi Wen, Some bug fix patches have been merged into linux-next. So the patches confuse me. Why did you send same patches again? Thanks, Yasuaki Ishimatsu 2012/10/19 15:46, we...@cn.fujitsu.com wrote: From: Wen Congyang we...@cn.fujitsu.com Changes from v2 to v3: Merge the bug fix from

Re: [PATCH v3 0/9] bugfix for memory hotplug

2012-10-19 Thread Yasuaki Ishimatsu
2012/10/19 17:06, Yasuaki Ishimatsu wrote: Hi Wen, Some bug fix patches have been merged into linux-next. So the patches confuse me. The following patches have been already merged into linux-next and mm-tree as long as I know. Wen Congyang (6): clear the memory to store struct page

Re: [PATCH v3 0/9] bugfix for memory hotplug

2012-10-19 Thread Yasuaki Ishimatsu
2012/10/19 17:45, Wen Congyang wrote: At 10/19/2012 04:19 PM, Yasuaki Ishimatsu Wrote: 2012/10/19 17:06, Yasuaki Ishimatsu wrote: Hi Wen, Some bug fix patches have been merged into linux-next. So the patches confuse me. Sorry, I don't check linux-next tree. The following patches have

Re: [PATCH v2 0/3] acpi,memory-hotplug : implement framework for hot removing memory

2012-10-19 Thread Yasuaki Ishimatsu
CCing Rafael, because he become ACPI Maintainer. Hi Wen, If you update the patch-set, please CCing Rafael from the next time. Thanks, Yasuaki Ishimatsu 2012/10/19 19:03, we...@cn.fujitsu.com wrote: From: Wen Congyang we...@cn.fujitsu.com The patch-set implements a framework for hot

Re: [PATCH] mm: make zone_pcp_reset independ on MEMORY_HOTREMOVE

2012-10-23 Thread Yasuaki Ishimatsu
: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com Cc: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Looks goot to me. Reviewd-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Thanks, Yasuki Ishimatsu Cc: Dave Hansen d...@linux.vnet.ibm.com Cc: Mel Gorman m...@csn.ul.ie --- mm/page_alloc.c

Re: [PATCH v2 1/2] Use kacpi_hotplug_wq to handle container hotplug event.

2012-10-24 Thread Yasuaki Ishimatsu
parameter 0 makes the container_notify_cb() executed in kacpi_notify_wq or kacpid_wq. So, we need to put the real hotplug code into kacpi_hotplug_wq. I cannot understand the purpose of the patch. Is the patch a bug fix patch? If yes, what problem happens? Thanks, Yasuaki Ishimatsu Signed-off

Re: [PATCH v2 1/2] Use kacpi_hotplug_wq to handle container hotplug event.

2012-10-24 Thread Yasuaki Ishimatsu
Hi Tang, 2012/10/24 16:24, Tang Chen wrote: On 10/24/2012 02:54 PM, Yasuaki Ishimatsu wrote: Hi Tang, 2012/10/24 15:05, Tang Chen wrote: As the comments in __acpi_os_execute() said: We can't run hotplug code in keventd_wq/kacpid_wq/kacpid_notify_wq because the hotplug code may

Re: [PATCH v4] create sun sysfs file

2012-10-08 Thread Yasuaki Ishimatsu
Hi Len, What should I do to put this patch in your tree? Thanks, Yasuaki Ishimatsu 2012/10/03 18:54, Yasuaki Ishimatsu wrote: Hi Len, Ping... Pleae merge the patch into your tree. Thanks, Yasuaki Ishimatsu 2012/09/24 11:31, Yasuaki Ishimatsu wrote: Hi Len, Ping... I want you

Re: [PATCH v4] create sun sysfs file

2012-10-08 Thread Yasuaki Ishimatsu
Hi Len, 2012/10/09 14:05, Len Brown wrote: On 10/08/2012 07:57 PM, Yasuaki Ishimatsu wrote: Hi Len, What should I do to put this patch in your tree? Please add a description of the attribute in Documentation/ABI/testing/ A human needs to understand exactly what is in that file because

[PATCH v5] create sun sysfs file

2012-10-09 Thread Yasuaki Ishimatsu
printed on the physical slot whenever possible. So if we can know the value, we can identify the physical position of the slot in the system. The patch creates sun file in sysfs for identifying physical position of the slot. Reviewed-by: Toshi Kani toshi.k...@hp.com Signed-off-by: Yasuaki Ishimatsu

Re: [PATCH v3 3/3] acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-10-09 Thread Yasuaki Ishimatsu
Hi Wen, 2012/10/09 17:02, Wen Congyang wrote: Hi, ishimatsu: At 07/12/2012 07:28 PM, Yasuaki Ishimatsu Wrote: acpi_bus_trim() stops removing devices, when acpi_bus_remove() return error number. But acpi_bus_remove() cannot return error number correctly. acpi_bus_remove() only return -EINVAL

acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-10-09 Thread Yasuaki Ishimatsu
there is no impact with the exceptionof CPU and Memory hotplug path. Because other device also fails but the fail is an irregular case like device is NULL. Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- drivers/acpi/scan.c| 15 --- drivers/base/dd.c

Re: linux-next: build failure after merge of the origin tree

2012-10-09 Thread Yasuaki Ishimatsu
) return ret; } I believe the error to be fixed with this patch. Could you try it? Thanks, Yasuaki Ishimatsu and this patch never appeared in linux-next before being merged. :-( It was first sighted October 3. I have reverted that commit for today. If this patch truly was authored

Re: acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-10-09 Thread Yasuaki Ishimatsu
Hi Toshi, 2012/10/10 1:36, Toshi Kani wrote: On Tue, 2012-10-09 at 17:48 +0900, Yasuaki Ishimatsu wrote: acpi_bus_trim() stops removing devices, when acpi_bus_remove() return error number. But acpi_bus_remove() cannot return error number correctly. acpi_bus_remove() only return -EINVAL, when

Re: [PATCH] ACPI: dock: Remove redundant ACPI NS walk

2012-10-09 Thread Yasuaki Ishimatsu
-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Thanks, Yasuaki Ishimatsu drivers/acpi/dock.c | 26 +++--- 1 files changed, 7 insertions(+), 19 deletions(-) diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c index 88eb143..ae4ebf2 100644 --- a/drivers/acpi

Re: [PATCH v5] create sun sysfs file

2012-10-10 Thread Yasuaki Ishimatsu
Hi Len, How about v5 patch? Thanks, Yasuaki Ishimatsu 2012/10/09 15:49, Yasuaki Ishimatsu wrote: _SUN method provides the slot unique-ID in the ACPI namespace. And The value is written in Advanced Configuration and Power Interface Specification as follows: The _SUN value is required

[PATCH v2 0/2] Suppress Device device name does not have a release() function warning

2012-10-10 Thread Yasuaki Ishimatsu
This patch-set is patches to which [1] and [2] are updated [1] memory-hotplug: add memory_block_release [2] memory-hotplug: add node_device_release from following patch-set. https://lkml.org/lkml/2012/9/27/39 So the patch-set version is v2. v1 - v2 [PATCH 1/2] - change subject to Suppress

[PATCH 1/2]suppress Device memoryX does not have a release() function warning

2012-10-10 Thread Yasuaki Ishimatsu
...@gmail.com Cc: Minchan Kim minchan@gmail.com CC: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com CC: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- drivers/base/memory.c |9 - 1 file changed, 8

[PATCH 2/2]suppress Device nodeX does not have a release() function warning

2012-10-10 Thread Yasuaki Ishimatsu
, it has a garbage. CC: David Rientjes rient...@google.com CC: Jiang Liu liu...@gmail.com Cc: Minchan Kim minchan@gmail.com CC: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Signed-off-by: Wen

Re: acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-10-10 Thread Yasuaki Ishimatsu
Hi Toshi, 2012/10/10 22:01, Toshi Kani wrote: On Wed, 2012-10-10 at 10:07 +0900, Yasuaki Ishimatsu wrote: : if (acpi_drv) { if (acpi_drv-ops.notify) acpi_device_remove_notify_handler(acpi_dev); THIS CALL - if (acpi_drv

Re: [PATCH 2/10] memory-hotplug : remove /sys/firmware/memmap/X sysfs

2012-10-11 Thread Yasuaki Ishimatsu
2012/10/06 4:36, KOSAKI Motohiro wrote: On Thu, Oct 4, 2012 at 10:26 PM, Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com wrote: When (hot)adding memory into system, /sys/firmware/memmap/X/{end, start, type} sysfs files are created. But there is no code to remove these files. The patch

[PATCH v2] acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-10-11 Thread Yasuaki Ishimatsu
there is no impact with the exceptionof CPU and Memory hotplug path. Because other device also fails but the fail is an irregular case like device is NULL. v1-v2 - add a rollback for reinstalling a notify handler. Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- drivers/acpi

Re: [PATCH 2/2]suppress Device nodeX does not have a release() function warning

2012-10-11 Thread Yasuaki Ishimatsu
2012/10/12 5:31, David Rientjes wrote: On Thu, 11 Oct 2012, Yasuaki Ishimatsu wrote: When calling unregister_node(), the function shows following message at device_release(). Device 'node2' does not have a release() function, it is broken and must be fixed. The reason is node's device struct

Re: [PATCH v2] acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-10-11 Thread Yasuaki Ishimatsu
Hi Toshi, 2012/10/11 22:58, Toshi Kani wrote: On Thu, 2012-10-11 at 19:12 +0900, Yasuaki Ishimatsu wrote: acpi_bus_trim() stops removing devices, when acpi_bus_remove() return error number. But acpi_bus_remove() cannot return error number correctly. acpi_bus_remove() only return -EINVAL, when

[PATCH] mm: cleanup register_node()

2012-10-12 Thread Yasuaki Ishimatsu
register_node() is defined as extern in include/linux/node.h. But the function is only called from register_one_node() in driver/base/node.c. So the patch defines register_node() as static. CC: David Rientjes rient...@google.com CC: Andrew Morton a...@linux-foundation.org Signed-off-by: Yasuaki

Re: [PATCH] Fix a hard coding style when determining if a device is a container.

2012-10-12 Thread Yasuaki Ishimatsu
]) + goto end; How about prepare is_container_device() function and check whether the device is the container device or not as below? if (is_container_device()) goto end; Thanks, Yasuaki Ishimatsu switch (*action) { case

Re: [PATCH v2] acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-10-26 Thread Yasuaki Ishimatsu
Hi Greg, Sorry for late reply. 2012/10/20 2:59, Greg Kroah-Hartman wrote: On Fri, Oct 19, 2012 at 06:29:52AM +0200, Rafael J. Wysocki wrote: On Thursday 11 of October 2012 19:12:28 Yasuaki Ishimatsu wrote: acpi_bus_trim() stops removing devices, when acpi_bus_remove() return error number

[PATCH v2 1/2] acpi : cpu hot-remove returns error when cpu_down() fails

2012-10-26 Thread Yasuaki Ishimatsu
error number since some process may run on the cpu. If the cpu has a running process and the cpu is turned the power off, the system may not work well. Reviewed-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com Reviewed-by: Toshi Kani toshi.k...@hp.com Signed-off-by: Yasuaki Ishimatsu

Re: [PATCH 02/46] x86, mm: Split out split_mem_range from init_memory_mapping

2012-11-12 Thread Yasuaki Ishimatsu
, end - 1); + + memset(mr, 0, sizeof(mr)); + nr_range = 0; This is unnecessary since it is set in the below. + nr_range = split_mem_range(mr, nr_range, start, end); Thanks, Yasuaki Ishimatsu + /* * Find space for the kernel direct mapping tables

[PATCH v6] create sun sysfs file

2012-11-12 Thread Yasuaki Ishimatsu
. The patch creates sun file in sysfs for identifying physical position of the slot. Reviewed-by: Toshi Kani toshi.k...@hp.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- Documentation/ABI/testing/sysfs-devices-sun | 14 ++ drivers/acpi/scan.c

Re: [PATCH] [resend] ACPI: Fix memory leak in acpi_bind_one() (fwd)

2012-10-15 Thread Yasuaki Ishimatsu
Looks good to me. Reviewed-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com Thanks, Yasuaki Ishimatsu --- drivers/acpi/glue.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c index d1a2d74..0837308 100644 --- a/drivers/acpi

Re: [PATCH 1/2] ACPI: Fix stale pointer access to flags.lockable

2012-10-16 Thread Yasuaki Ishimatsu
whether or not this ACPI object implements _LCK method. Fix the stable pointer access by replacing it with acpi_get_handle() to check if _LCK is implemented. Signed-off-by: Toshi Kani toshi.k...@hp.com Looks good to me. Reviewed-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com

Re: [PATCH 2/2] ACPI: Remove unused lockable in acpi_device_flags

2012-10-16 Thread Yasuaki Ishimatsu
this lockable flag. Signed-off-by: Toshi Kani toshi.k...@hp.com Looks good to me. Reviewed-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- drivers/acpi/scan.c | 5 - include/acpi/acpi_bus.h | 3 +-- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/acpi

Re: [PATCH 1/4] acpi,memory-hotplug : add memory offline code to acpi_memory_device_remove()

2012-10-17 Thread Yasuaki Ishimatsu
, Yasuaki Ishimatsu Thanks Wen Congyang -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml

Re: [PATCH 5/10] memory-hotplug : memory-hotplug: check page type in get_page_bootmem

2012-10-18 Thread Yasuaki Ishimatsu
Hi Kosaki, Sorry for late reply. 2012/10/13 4:28, KOSAKI Motohiro wrote: On Thu, Oct 4, 2012 at 10:32 PM, Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com wrote: The function get_page_bootmem() may be called more than one time to the same page. There is no need to set page's type, private

Re: [RFC PATCH v3 3/13] memory-hotplug : unify argument of firmware_map_add_early/hotplug

2012-07-12 Thread Yasuaki Ishimatsu
Hi Dave, 2012/07/12 22:40, Dave Hansen wrote: On 07/11/2012 09:52 PM, Yasuaki Ishimatsu wrote: Does the following patch include your comment? If O.K., I will separate the patch from the series and send it for bug fix. Looks sane to me. It does now mean that the calling conventions

Re: [RFC PATCH v3 3/13] memory-hotplug : unify argument of firmware_map_add_early/hotplug

2012-07-12 Thread Yasuaki Ishimatsu
Hi Dave, 2012/07/12 22:40, Dave Hansen wrote: On 07/11/2012 09:52 PM, Yasuaki Ishimatsu wrote: Does the following patch include your comment? If O.K., I will separate the patch from the series and send it for bug fix. Looks sane to me. It does now mean that the calling conventions

Re: [PATCH v3 2/3 RESEND] acpi : prevent cpu from becoming online

2012-07-13 Thread Yasuaki Ishimatsu
2012/07/12 21:41, Srivatsa S. Bhat wrote: On 07/12/2012 05:10 PM, Yasuaki Ishimatsu wrote: Even if acpi_processor_handle_eject() offlines cpu, there is a chance to online the cpu after that. So the patch closes the window by using get/put_online_cpus(). Why does the patch change _cpu_up

Re: [PATCH v3 1/3] acpi : cpu hot-remove returns error when cpu_down() fails

2012-07-13 Thread Yasuaki Ishimatsu
Hi Toshi, 2012/07/13 1:48, Toshi Kani wrote: On Thu, 2012-07-12 at 20:22 +0900, Yasuaki Ishimatsu wrote: Even if cpu_down() fails, acpi_processor_remove() continues to remove the cpu. But in this case, it should return error number since some process may run on the cpu. If the cpu has

Re: [PATCH v3 2/3 RESEND] acpi : prevent cpu from becoming online

2012-07-13 Thread Yasuaki Ishimatsu
Hi Toshi, 2012/07/13 1:49, Toshi Kani wrote: On Thu, 2012-07-12 at 20:40 +0900, Yasuaki Ishimatsu wrote: Even if acpi_processor_handle_eject() offlines cpu, there is a chance to online the cpu after that. So the patch closes the window by using get/put_online_cpus(). Why does the patch change

Re: [PATCH v3 1/3] acpi : cpu hot-remove returns error when cpu_down() fails

2012-07-13 Thread Yasuaki Ishimatsu
Hi Srivatsa, 2012/07/12 21:32, Srivatsa S. Bhat wrote: On 07/12/2012 04:52 PM, Yasuaki Ishimatsu wrote: Even if cpu_down() fails, acpi_processor_remove() continues to remove the cpu. But in this case, it should return error number since some process may run on the cpu. If the cpu has

Re: [PATCH v3 3/3] acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-07-13 Thread Yasuaki Ishimatsu
2012/07/13 1:50, Toshi Kani wrote: On Thu, 2012-07-12 at 20:28 +0900, Yasuaki Ishimatsu wrote: acpi_bus_trim() stops removing devices, when acpi_bus_remove() return error number. But acpi_bus_remove() cannot return error number correctly. acpi_bus_remove() only return -EINVAL, when dev argument

[PATCH v4 1/3] acpi : cpu hot-remove returns error when cpu_down() fails

2012-07-13 Thread Yasuaki Ishimatsu
srivatsa.b...@linux.vnet.ibm.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- drivers/acpi/processor_driver.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) Index: linux-3.5-rc6/drivers/acpi/processor_driver.c

[PATCH v4 2/3] acpi : prevent cpu from becoming online

2012-07-13 Thread Yasuaki Ishimatsu
()| continue hot-remove the cpu| Reviewed-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- drivers/acpi/processor_driver.c | 14 ++ kernel/cpu.c|8 +--- 2 files changed, 19

[PATCH v4 3/3] acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-07-13 Thread Yasuaki Ishimatsu
of device_releae_driver(). Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- drivers/acpi/scan.c| 15 --- drivers/base/dd.c | 22 +- include/linux/device.h |2 +- 3 files changed, 30 insertions(+), 9 deletions(-) Index: linux-3.5-rc6/drivers/acpi

Re: [RFC PATCH v3 4/13] memory-hotplug : remove /sys/firmware/memmap/X sysfs

2012-07-16 Thread Yasuaki Ishimatsu
Hi Wen, 2012/07/13 18:10, Wen Congyang wrote: At 07/09/2012 06:26 PM, Yasuaki Ishimatsu Wrote: When (hot)adding memory into system, /sys/firmware/memmap/X/{end, start, type} sysfs files are created. But there is no code to remove these files. The patch implements the function to remove

Re: [RFC PATCH v3 4/13] memory-hotplug : remove /sys/firmware/memmap/X sysfs

2012-07-16 Thread Yasuaki Ishimatsu
Hi Wen, 2012/07/16 11:32, Wen Congyang wrote: At 07/09/2012 06:26 PM, Yasuaki Ishimatsu Wrote: When (hot)adding memory into system, /sys/firmware/memmap/X/{end, start, type} sysfs files are created. But there is no code to remove these files. The patch implements the function to remove

Re: [RFC PATCH v3 2/13] memory-hotplug : add physical memory hotplug code to acpi_memory_device_remove

2012-07-16 Thread Yasuaki Ishimatsu
Hi Wen, 2012/07/13 12:26, Wen Congyang wrote: At 07/09/2012 06:24 PM, Yasuaki Ishimatsu Wrote: acpi_memory_device_remove() has been prepared to remove physical memory. But, the function only frees acpi_memory_device currentlry. The patch adds following functions

Re: [RFC PATCH v3 2/13] memory-hotplug : add physical memory hotplug code to acpi_memory_device_remove

2012-07-16 Thread Yasuaki Ishimatsu
Hi Wen, 2012/07/13 19:40, Wen Congyang wrote: At 07/09/2012 06:24 PM, Yasuaki Ishimatsu Wrote: acpi_memory_device_remove() has been prepared to remove physical memory. But, the function only frees acpi_memory_device currentlry. The patch adds following functions

Re: [RFC PATCH v3 2/13] memory-hotplug : add physical memory hotplug code to acpi_memory_device_remove

2012-07-16 Thread Yasuaki Ishimatsu
Hi Wen, 2012/07/13 12:35, Wen Congyang wrote: At 07/09/2012 06:24 PM, Yasuaki Ishimatsu Wrote: acpi_memory_device_remove() has been prepared to remove physical memory. But, the function only frees acpi_memory_device currentlry. The patch adds following functions

Re: [RFC PATCH v3 2/13] memory-hotplug : add physical memory hotplug code to acpi_memory_device_remove

2012-07-16 Thread Yasuaki Ishimatsu
Hi Wen, 2012/07/17 10:44, Yasuaki Ishimatsu wrote: Hi Wen, 2012/07/13 12:35, Wen Congyang wrote: At 07/09/2012 06:24 PM, Yasuaki Ishimatsu Wrote: acpi_memory_device_remove() has been prepared to remove physical memory. But, the function only frees acpi_memory_device currentlry. The patch

[PATCH] firmware_map : unify argument of firmware_map_add_early/hotplug

2012-07-16 Thread Yasuaki Ishimatsu
: Thomas Gleixner t...@linutronix.de CC: Ingo Molnar mi...@kernel.org CC: H. Peter Anvin h...@zytor.com CC: Tejun Heo t...@kernel.org CC: Andrew Morton a...@linux-foundation.org Reviewed-by: Dave Hansen d...@linux.vnet.ibm.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- arch

Re: [RFC PATCH v3 2/13] memory-hotplug : add physical memory hotplug code to acpi_memory_device_remove

2012-07-16 Thread Yasuaki Ishimatsu
Hi Wen, 2012/07/17 11:32, Wen Congyang wrote: At 07/17/2012 09:54 AM, Yasuaki Ishimatsu Wrote: Hi Wen, 2012/07/17 10:44, Yasuaki Ishimatsu wrote: Hi Wen, 2012/07/13 12:35, Wen Congyang wrote: At 07/09/2012 06:24 PM, Yasuaki Ishimatsu Wrote: acpi_memory_device_remove() has been prepared

Re: [RFC PATCH v3 2/13] memory-hotplug : add physical memory hotplug code to acpi_memory_device_remove

2012-07-16 Thread Yasuaki Ishimatsu
Hi Wen, 2012/07/17 12:32, Wen Congyang wrote: At 07/17/2012 11:08 AM, Yasuaki Ishimatsu Wrote: Hi Wen, 2012/07/17 11:32, Wen Congyang wrote: At 07/17/2012 09:54 AM, Yasuaki Ishimatsu Wrote: Hi Wen, 2012/07/17 10:44, Yasuaki Ishimatsu wrote: Hi Wen, 2012/07/13 12:35, Wen Congyang wrote

Re: [RFC PATCH v3 2/13] memory-hotplug : add physical memory hotplug code to acpi_memory_device_remove

2012-07-16 Thread Yasuaki Ishimatsu
Hi Wen, 2012/07/17 14:17, Wen Congyang wrote: At 07/17/2012 12:51 PM, Yasuaki Ishimatsu Wrote: Hi Wen, 2012/07/17 12:32, Wen Congyang wrote: At 07/17/2012 11:08 AM, Yasuaki Ishimatsu Wrote: Hi Wen, 2012/07/17 11:32, Wen Congyang wrote: At 07/17/2012 09:54 AM, Yasuaki Ishimatsu Wrote: Hi

[RFC PATCH 0/13] firmware_map : unify argument of firmware_map_add_early/hotplug

2012-07-18 Thread Yasuaki Ishimatsu
: Thomas Gleixner t...@linutronix.de CC: Ingo Molnar mi...@kernel.org CC: H. Peter Anvin h...@zytor.com CC: Tejun Heo t...@kernel.org CC: Andrew Morton a...@linux-foundation.org Reviewed-by: Dave Hansen d...@linux.vnet.ibm.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- arch

[RFC PATCH v4 1/13] memory-hotplug : rename remove_memory to offline_memory

2012-07-18 Thread Yasuaki Ishimatsu
...@samba.org CC: Christoph Lameter c...@linux.com Cc: Minchan Kim minchan@gmail.com CC: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com CC: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- drivers

[RFC PATCH v4 2/13] memory-hotplug : add physical memory hotplug code to acpi_memory_device_remove

2012-07-18 Thread Yasuaki Ishimatsu
: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com CC: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- drivers/acpi/acpi_memhotplug.c | 27 ++- drivers/base/memory.c

[PATCH v4 3/13] memory-hotplug : check whether memory is present or not

2012-07-18 Thread Yasuaki Ishimatsu
...@kernel.crashing.org CC: Paul Mackerras pau...@samba.org CC: Christoph Lameter c...@linux.com Cc: Minchan Kim minchan@gmail.com CC: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com CC: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yasuaki Ishimatsu

[RFC PATCH v4 4/13] memory-hotplug : remove /sys/firmware/memmap/X sysfs

2012-07-18 Thread Yasuaki Ishimatsu
: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com CC: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- drivers/firmware/memmap.c| 78 ++- include/linux

[RFC PATCH v4 7/13] memory-hotplug : remove_memory calls __remove_pages

2012-07-18 Thread Yasuaki Ishimatsu
CC: Christoph Lameter c...@linux.com Cc: Minchan Kim minchan@gmail.com CC: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com CC: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- arch/powerpc

[RFC PATCH v4 5/13] memory-hotplug : does not release memory region in PAGES_PER_SECTION chunks

2012-07-18 Thread Yasuaki Ishimatsu
: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com CC: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- arch/powerpc/platforms/pseries/hotplug-memory.c | 13 + mm/memory_hotplug.c |4 ++-- 2 files

[RFC PATCH v4 6/13] memory-hotplug : add memory_block_release

2012-07-18 Thread Yasuaki Ishimatsu
: Andrew Morton a...@linux-foundation.org CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com CC: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com --- drivers/base/memory.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) Index: linux

  1   2   3   4   5   6   7   8   9   10   >