Re: [PATCH v2 1/4] xhci: Introduce xhci_init_driver()

2014-08-19 Thread Yoshihiro Shimoda
, this xhci_plat_hc_drver should be xhci_plat_hc_driver. After I modified it by myself, I could build the xhci-plat-hcd.ko in my environment. Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] usb: gadget: USB_RENESAS_USBHS_UDC should depend on HAS_DMA

2014-09-03 Thread Yoshihiro Shimoda
and peripheral controller chip that supports both full and high speed USB 2.0 data transfers. Acked-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH v2] usb: renesas_usbhs: fix driver dependencies

2014-09-03 Thread Yoshihiro Shimoda
+rene...@glider.be Acked-by: Simon Horman horms+rene...@verge.net.au Acked-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the line unsubscribe linux-sh in the body of a message to majord...@vger.kernel.org More

[PATCH] phy: phy-rcar-gen2: Fix USBHS_UGSTS_LOCK value

2015-04-02 Thread Yoshihiro Shimoda
According to the technical update (No. TN-RCS-B011A/E), the UGSTS LOCK bit location is bit 8, not bits 1 and 0. It also says that the register address offset of UGSTS is 0x88, not 0x90. So, this patch fixes the USBHS_UGSTS_LOCK value and some comments. Signed-off-by: Yoshihiro Shimoda

RE: [PATCH] phy: phy-rcar-gen2: Fix USBHS_UGSTS_LOCK value

2015-05-08 Thread Yoshihiro Shimoda
and some comments. Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com Would you apply this patch to your repository? I tried to apply this patch on the current fixes branch of linux-phy today, this patch could be applied without any error. Best regards, Yoshihiro Shimoda

RE: [PATCH] phy: phy-rcar-gen2: Fix USBHS_UGSTS_LOCK value

2015-05-08 Thread Yoshihiro Shimoda
Hi, On Friday 08 May 2015 12:54 PM, Yoshihiro Shimoda wrote: Hi Kishon, Sent: Thursday, April 02, 2015 5:01 PM According to the technical update (No. TN-RCS-B011A/E), the UGSTS LOCK bit location is bit 8, not bits 1 and 0. It also says that the register address offset of UGSTS

[PATCH] phy: rcar-gen2: Add support for R-Car E2

2015-05-18 Thread Yoshihiro Shimoda
This patch adds a compatible string to support for R-Car E2. Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com --- Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt | 1 + drivers/phy/phy-rcar-gen2.c | 1 + 2 files changed, 2 insertions(+) diff

RE: [PATCH v3] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-06 Thread Yoshihiro Shimoda
); return 0; Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: [PATCH v2] phy: rcar-gen2 usb: Add Host/Function switching for USB0

2015-07-06 Thread Yoshihiro Shimoda
. Best regards, Yoshihiro Shimoda + return 0; } -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[PATCH] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-08-20 Thread Yoshihiro Shimoda
. 2) detects id pin to select host or peripheral on the channel 0. For now, this driver only supports 1) above. Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com --- .../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 37 +++ drivers/phy/Kconfig

RE: [PATCH] serial: sh-sci: Fix length of scatterlist

2015-10-22 Thread Yoshihiro Shimoda
Hi Geert-san, > Sent: Tuesday, October 20, 2015 9:22 PM > > Hi Shimoda-san, > > On Tue, Oct 20, 2015 at 2:18 PM, Yoshihiro Shimoda > <yoshihiro.shimoda...@renesas.com> wrote: > > This patch fixes an issue that the "length" of scatterlist should be

[PATCH] serial: sh-sci: Fix length of scatterlist

2015-10-22 Thread Yoshihiro Shimoda
This patch fixes an issue that the "length" of scatterlist should be set using sg_dma_len(). Otherwise, a dmaengine driver cannot work correctly if CONFIG_NEED_SG_DMA_LENGTH=y. Fixes: 7b39d90184 (serial: sh-sci: Fix NULL pointer dereference if HIGHMEM is enabled) Signed-off-by: Yoshihi

RE: [PATCH v4 3/3] phy: rcar-gen3-usb2: add runtime ID/VBUS pin detection

2015-10-19 Thread Yoshihiro Shimoda
Hi, > Sent: Saturday, October 17, 2015 10:54 AM > > Hi, > > On Tuesday 13 October 2015 03:52 PM, Yoshihiro Shimoda wrote: > > This patch adds support for runtime ID/VBUS pin detection if > > the channel 0 of R-Car gen3 is used. So, we are able to use > > the ch

RE: [PATCH v4 2/3] phy: rcar-gen3-usb2: change the mode to OTG on the combined channel

2015-10-19 Thread Yoshihiro Shimoda
Hi, > Sent: Saturday, October 17, 2015 10:48 AM > > Hi, > > On Tuesday 13 October 2015 03:52 PM, Yoshihiro Shimoda wrote: > > To use the channel 0 of R-Car gen3 as periperal mode, This patch changes > > the mode to OTG instead of HOST. Then, this driver needs to set s

RE: [PATCH v4 1/3] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-10-19 Thread Yoshihiro Shimoda
Hi, > Sent: Saturday, October 17, 2015 10:44 AM > > Hi, > > On Tuesday 13 October 2015 03:52 PM, Yoshihiro Shimoda wrote: < snip > > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > > index 7eb5859d..45c6131 100644 > > --- a/drivers/ph

[PATCH v5 1/4] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-10-20 Thread Yoshihiro Shimoda
of SoC specific to use the {ehci,ohci}-platform driver. 2) detects id pin to select host or peripheral on the channel 0. For now, this driver only supports 1) above. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- .../devicetree/bindings/phy/rcar-gen3-phy-us

[PATCH v5 3/4] phy: rcar-gen3-usb2: add runtime ID/VBUS pin detection

2015-10-20 Thread Yoshihiro Shimoda
This patch adds support for runtime ID/VBUS pin detection if the channel 0 of R-Car gen3 is used. So, we are able to use the channel as both host and peripheral. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- .../devicetree/bindings/phy/rcar-gen3-phy-usb2.tx

[PATCH v5 2/4] phy: rcar-gen3-usb2: change the mode to OTG on the combined channel

2015-10-20 Thread Yoshihiro Shimoda
-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/phy/phy-rcar-gen3-usb2.c | 124 ++- 1 file changed, 122 insertions(+), 2 deletions(-) diff --git a/drivers/phy/phy-rcar-gen3-usb2.c b/drivers/phy/phy-rcar-gen3-usb2.c index 9d9cf26..cf91f9f

[PATCH v5 4/4] MAINTAINERS: add Renesas usb2 phy driver

2015-10-20 Thread Yoshihiro Shimoda
Add Renesas usb2 phy driver to maintainer entry. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index be0055c..ecff678 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -

[PATCH v5 0/4] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-10-20 Thread Yoshihiro Shimoda
isable the clocks. (In other words, this driver expects to enable/disable the clocks by Runtime PM API by the phy-core driver.) - Remove an unnecessary header file (asm/cmpxchg.h). Yoshihiro Shimoda (4): phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver phy: rcar-gen3-usb2: change the mode

[PATCH] serial: sh-sci: Fix length of scatterlist

2015-10-20 Thread Yoshihiro Shimoda
This patch fixes an issue that the "length" of scatterlist should be set using sh_dma_length(). Otherwise, a dmaengine driver cannot work correctly if CONFIG_NEED_SG_DMA_LENGTH=y. Fixes: 7b39d90184 (serial: sh-sci: Fix NULL pointer dereference if HIGHMEM is enabled) Signed-off-by:

[PATCH v4 3/3] phy: rcar-gen3-usb2: add runtime ID/VBUS pin detection

2015-10-13 Thread Yoshihiro Shimoda
This patch adds support for runtime ID/VBUS pin detection if the channel 0 of R-Car gen3 is used. So, we are able to use the channel as both host and peripheral. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- .../devicetree/bindings/phy/rcar-gen3-phy-usb2.tx

[PATCH v4 1/3] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-10-13 Thread Yoshihiro Shimoda
of SoC specific to use the {ehci,ohci}-platform driver. 2) detects id pin to select host or peripheral on the channel 0. For now, this driver only supports 1) above. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- .../devicetree/bindings/phy/rcar-gen3-phy-us

[PATCH v4 0/3] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-10-13 Thread Yoshihiro Shimoda
n unnecessary header file (asm/cmpxchg.h). Yoshihiro Shimoda (3): phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver phy: rcar-gen3-usb2: change the mode to OTG on the combined channel phy: rcar-gen3-usb2: add runtime ID/VBUS pin detection .../devicetree/bindings/phy/rcar-gen3-ph

RE: [PATCH v3] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-10-13 Thread Yoshihiro Shimoda
Hi, I sent v4 patch set today. So, please ignore this version. Best regards, Yoshihiro Shimoda > Sent: Thursday, October 01, 2015 7:11 PM > > This patch adds support for R-Car generation 3 USB2 PHY driver. > This SoC has 3 EHCI/OHCI channels, and the channel 0 is shared >

[PATCH v4 2/3] phy: rcar-gen3-usb2: change the mode to OTG on the combined channel

2015-10-13 Thread Yoshihiro Shimoda
-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/phy/phy-rcar-gen3-usb2.c | 126 ++- 1 file changed, 124 insertions(+), 2 deletions(-) diff --git a/drivers/phy/phy-rcar-gen3-usb2.c b/drivers/phy/phy-rcar-gen3-usb2.c index d90dfcf..03d7079

RE: [PATCH] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-08-24 Thread Yoshihiro Shimoda
Hi Geert-san, Sent: Monday, August 24, 2015 9:13 PM Hi Shimoda-san, On Thu, Aug 20, 2015 at 8:28 AM, Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com wrote: This patch adds support for R-Car generation 3 USB2 PHY driver. This SoC has 3 EHCI/OHCI channels, and the channel 0 is shared

[PATCH] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-08-25 Thread Yoshihiro Shimoda
. 2) detects id pin to select host or peripheral on the channel 0. For now, this driver only supports 1) above. Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com --- This patch is based on the latest linux-phy / next branch. (commit id = cfd093bbb5fe84ec8c7bb069fe618159a8b601f5

RE: [PATCH] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-09-17 Thread Yoshihiro Shimoda
gt; 1) initializes some registers of SoC specific to use the > {ehci,ohci}-platform driver. > > 2) detects id pin to select host or peripheral on the channel 0. > > For now, this driver only supports 1) above. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shim

[PATCH v3] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-10-01 Thread Yoshihiro Shimoda
of SoC specific to use the {ehci,ohci}-platform driver. 2) detects id pin to select host or peripheral on the channel 0. For now, this driver only supports 1) above. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- This patch is based on the latest linux-phy

RE: [PATCH] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-10-01 Thread Yoshihiro Shimoda
s "usb2" means the partial registers of USB 2.0 host block. That host registers can control the USB2.0 PHY. This "hsusb" means the partial registers of USB 2.0 peripheral block. That peripheral registers can control the selector (host or peripheral). So, thes

RE: [PATCH] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-09-25 Thread Yoshihiro Shimoda
Hi Kishon, Thank you for the review! And I'm sorry for the delayed response. > Sent: Friday, September 18, 2015 3:08 PM > > Hi, > > On Tuesday 25 August 2015 02:40 PM, Yoshihiro Shimoda wrote: > > This patch adds support for R-Car generation 3 USB2 PHY driver. > &g

RE: [PATCH] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-09-25 Thread Yoshihiro Shimoda
Hi Rob, Thank you for your comment! And, I'm sorry for the delayed response. > Sent: Monday, September 21, 2015 11:01 PM > > On 09/18/2015 01:08 AM, Kishon Vijay Abraham I wrote: > > Hi, > > > > On Tuesday 25 August 2015 02:40 PM, Yoshihiro Shimoda wrote: > >&g

[PATCH] phy: rcar-gen3-usb2: remove HSUSB registers handling

2016-01-07 Thread Yoshihiro Shimoda
Since the related driver (CPG/MSSR driver) only manages the first module clock, this driver should not handle the HSUSB registers. So, this patch removes the HSUSB registers handling. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- This patch is based on the lin

RE: [PATCH v5 1/4] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-11-26 Thread Yoshihiro Shimoda
Hi, Thank you for the review! > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Friday, November 27, 2015 2:21 PM > > Hi, > > On Tuesday 20 October 2015 02:27 PM, Yoshihiro Shimoda wrote: > > This patch adds support for R-Car generation 3 USB2 PHY driver.

[PATCH v6 0/4] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-11-29 Thread Yoshihiro Shimoda
from "usb2" to "usb2_host". Changes from v1: - Revise some typos. - Remove using clk API to enable/disable the clocks. (In other words, this driver expects to enable/disable the clocks by Runtime PM API by the phy-core driver.) - Remove an unnecessary header file (asm/c

[PATCH v6 4/4] MAINTAINERS: add Renesas usb2 phy driver

2015-11-29 Thread Yoshihiro Shimoda
Add Renesas usb2 phy driver to maintainer entry. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e9caa4b..ac1e301 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -

[PATCH v6 1/4] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-11-29 Thread Yoshihiro Shimoda
of SoC specific to use the {ehci,ohci}-platform driver. 2) detects id pin to select host or peripheral on the channel 0. For now, this driver only supports 1) above. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- .../devicetree/bindings/phy/rcar-gen3-phy-us

[PATCH v6 2/4] phy: rcar-gen3-usb2: change the mode to OTG on the combined channel

2015-11-29 Thread Yoshihiro Shimoda
-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/phy/phy-rcar-gen3-usb2.c | 124 ++- 1 file changed, 122 insertions(+), 2 deletions(-) diff --git a/drivers/phy/phy-rcar-gen3-usb2.c b/drivers/phy/phy-rcar-gen3-usb2.c index 2696152..2b5d890

[PATCH v6 3/4] phy: rcar-gen3-usb2: add runtime ID/VBUS pin detection

2015-11-29 Thread Yoshihiro Shimoda
This patch adds support for runtime ID/VBUS pin detection if the channel 0 of R-Car gen3 is used. So, we are able to use the channel as both host and peripheral. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- .../devicetree/bindings/phy/rcar-gen3-phy-usb2.tx

RE: [PATCH v5 0/4] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-11-23 Thread Yoshihiro Shimoda
Hi Kishon, > From: Yoshihiro Shimoda > Sent: Tuesday, October 20, 2015 5:58 PM > > This patch is based on the latest linux-phy / next branch. > (commit id = 0f8669e343982ac66f4420335777cb5456b8abb0) Would you review this patch set? I confirmed the patch set could apply the l

RE: [PATCH v9 00/14] USB OTG/dual-role framework

2016-06-09 Thread Yoshihiro Shimoda
gt; > >> Series is based on v4.7-rc1. > >> > > > > Roger, I will wait your dwc3 and TI patch set since one framework needs > > one user at least, thanks. > > Sure I will post the dwc3 patch. > > Yoshihiro, > > could you please post the platf

RE: [PATCH v9 13/14] usb: gadget: udc: adapt to OTG core

2016-06-09 Thread Yoshihiro Shimoda
i/usb.git/commit/?h=testing/next=a22b539c7082b6a3046b3a9cebb356a047a2d81d I guess this patch needs rebase for that. Best regards, Yoshihiro Shimoda

[PATCH] phy: rcar-gen3-usb2: fix unexpected repeat interrupts of VBUS change

2016-05-31 Thread Yoshihiro Shimoda
nly. Fixes: 1114e2d (phy: rcar-gen3-usb2: change the mode to OTG on the combined channel) Cc: <sta...@vger.kernel.org> # v4.5+ Reported-by: Simon Horman <ho...@verge.net.au> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/phy/phy-rcar-gen3-usb2.c

RE: [PATCH] phy: rcar-gen3-usb2: fix unexpected repeat interrupts of VBUS change

2016-06-16 Thread Yoshihiro Shimoda
Hi Kishon, Would you review this patch? Best regards, Yoshihiro Shimoda > -Original Message- > From: Yoshihiro Shimoda > Sent: Tuesday, May 31, 2016 9:47 PM > To: kis...@ti.com > Cc: linux-kernel@vger.kernel.org; linux-renesas-...@vger.kernel.org; > sta...@vger.ker

RE: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2016-06-23 Thread Yoshihiro Shimoda
XHCI. > > > > Let's talk about how non dwc3 based platforms can get it done. > > Yoshihiro-san, could you please share your platform requirements from > dual-role > perspective? My platform requirements about dual-role are: - Initial settings of all host, gadget and OTG

RE: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2016-06-23 Thread Yoshihiro Shimoda
ed that, our > > ->probe() went from 400ms down to about 50us. > > > > Coupled with that, the OTG chapter also became a lot clearer to the > > point that it states you just don't initialize anything other than the > > OTG block, and just wait for OTG interrupt to do whatever it is you need > > to do. > > > > This meant that we could actually afford to do full reinitialization of > > dwc3 on role swap (it's now only 50us anyway) and we knew how to swap > > roles properly. > > > > (The reason for needing soft-reset during role swap is kinda long. But > > in summary dwc3 shadows register writes to both host and peripheral > > sides) > > > > > just discuss if it is necessary for dual-role switch. > > > > fair. However, if we have a single user we don't have a Generic > > layer. There's not enough variance to come up with truly generic > > architecture for this. > > > > -- > > I have put some points in my last reply [1], I summery it here to > see if a generic framework is deserved or not? > > 1. If there are some parts we can use during the role switch > - The common start/stop host and peripheral operation > eg, when switch from host to peripheral, all drivers can use > usb_remove_hcd to finish it. > - A common workqueue to handle vbus and id event > - sysfs for role switch > > 2. Does a mux driver can do it well? Yoshihiro, here we need your > point. The main point is if we need to call USB API to change > roles (eg, usb_remove_hcd) during the role switch, thanks. In my platform, it doesn't need to call USB API (usb_remove_hcd) when "A-host" is changed to "A-peripheral". (Since this is a prototype local code, the code is not upstreaming yet though.) Best regards, Yoshihiro Shimoda > > [1] http://www.spinics.net/lists/linux-usb/msg142974.html > -- > > Best Regards, > Peter Chen

RE: [PATCH] usb: xhci: handle uPD720201 and uPD720202 w/o ROM

2016-06-21 Thread Yoshihiro Shimoda
gt; [ 32.340179] xhci_hcd :45:00.0: USB bus 2 deregistered > > [ 32.345587] xhci_hcd :45:00.0: init :45:00.0 fail, -110 > > [ 32.351496] xhci_hcd: probe of :45:00.0 failed with error -110 > > > > Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com&g

RE: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

2016-06-20 Thread Yoshihiro Shimoda
USB 2.0 peripheral controller (HS-USB). The OTG function is related to some PHY control registers, so I intend to add the OTG/Dual-role core support into the phy driver (drivers/phy/phy-rcar-gen3-usb2.c). Best regards, Yoshihiro Shimoda

[PATCH] phy: rcar-gen3-usb2: fix mutex_lock calling in interrupt

2016-06-27 Thread Yoshihiro Shimoda
9.837162] [] generic_handle_irq+0x24/0x38 [9.842900] [] __handle_domain_irq+0x5c/0xb8 [9.848727] [] gic_handle_irq+0x58/0xb0 Reported-by: Simon Horman <ho...@verge.net.au> Fixes: 2b38543c8db1 ("phy: rcar-gen3-usb2: add extcon support") Signed-off-by: Yoshihiro Shimoda <yos

RE: [PATCH] phy: rcar-gen3-usb2: remove HSUSB registers handling

2016-02-02 Thread Yoshihiro Shimoda
Hi Kishon, Would you review this patch? I checked the latest linux-phy.git / next branch today, and it is the same as the following. > > This patch is based on the linux-phy / next branch. > > (commit id = 9955a7835bf376e12482583958b2661f501b868b) Best regards, Yoshihiro Shimoda

RE: [PATCH] phy: rcar-gen3-usb2: remove HSUSB registers handling

2016-02-22 Thread Yoshihiro Shimoda
ip-usb: add handler for usb-uart functionality Best regards, Yoshihiro Shimoda > -Original Message- > From: Yoshihiro Shimoda > Sent: Tuesday, February 02, 2016 5:29 PM > To: kis...@ti.com > Cc: pawel.m...@arm.com; mark.rutl...@arm.com; ijc+devicet...@hellion.org.uk; &

RE: [PATCH] phy: rcar-gen3-usb2: remove HSUSB registers handling

2016-02-22 Thread Yoshihiro Shimoda
Hi, > Hi, > > On Tuesday 23 February 2016 11:54 AM, Yoshihiro Shimoda wrote: > > Hi Kishon, > > > > Would you review this patch? > > merged it now. Thanks for reminding. Thank you! Best regards, Yoshihiro Shimoda > -Kishon >

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-08 Thread Yoshihiro Shimoda
Hi, > From: Roger Quadros > Sent: Thursday, April 07, 2016 8:45 PM > > Hi, > > On 07/04/16 11:52, Yoshihiro Shimoda wrote: > > Hi, > > > >> From: Roger Quadros > >> Sent: Tuesday, April 05, 2016 11:05 PM < snip > > > diff --git a

RE: [PATCH 2/3] phy: rcar-gen3-usb2: Add vbus-supply to handle VBUS on/off

2016-04-05 Thread Yoshihiro Shimoda
Hi, > From: Kishon Vijay Abraham I > Sent: Tuesday, April 05, 2016 7:54 PM > > Hi, > > On Thursday 03 March 2016 03:39 PM, Yoshihiro Shimoda wrote: > > To handle the VBUS on/off by a regulator driver, this patch adds > > regulator APIs calling in the driver and

RE: [PATCH v6 12/12] usb: host: xhci-plat: Add otg device to platform data

2016-04-05 Thread Yoshihiro Shimoda
ev); > + > + if (pdata->otg_dev) Ditto. > + usb_otg_remove_hcd(xhci->shared_hcd); > + else > + usb_remove_hcd(xhci->shared_hcd); > > - usb_remove_hcd(xhci->shared_hcd); > usb_phy_shutdown(hcd->usb_phy); > > - usb_remove_hcd(h

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-07 Thread Yoshihiro Shimoda
HCI. For example of xHCI: - otg->hcds[0] = primary_hcd - otg->hcds[1] = shared_hcd For example of EHCI/OHCI: - otg->hcds[0] = primary_hcd of EHCI - otg->hcds[1] = primary_hcd of OHCI Best regards, Yoshihiro Shimoda

[PATCH 0/3] phy: rcar-gen3-usb2: add vbus-supply and extcon

2016-03-03 Thread Yoshihiro Shimoda
upply to handle VBUS on/off" has Rob's Acked-by as the followings: http://thread.gmane.org/gmane.linux.kernel.renesas-soc/1087/focus=1153 Yoshihiro Shimoda (3): phy: rcar-gen3-usb2: remove unnecesary struct rcar_gen3_data phy: rcar-gen3-usb2: Add vbus-supply to handle VBUS on/off phy: rcar

RE: [PATCH] phy: rcar-gen3-usb2, rcar-gen2: Use ARCH_RENESAS

2016-03-03 Thread Yoshihiro Shimoda
om ARCH_SHMOBILE to > > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more > > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. > > > > Signed-off-by: Simon Horman <horms+rene...@verge.net.au> > > Acked-by: G

RE: [PATCH v2 2/2] phy: rcar-gen3-usb2: add fallback binding

2016-03-03 Thread Yoshihiro Shimoda
ration fallback compatibility string scheme being adopted for > > drivers for Renesas SoCs. > > > > Signed-off-by: Simon Horman <horms+rene...@verge.net.au> > > Acked-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> Best regards, Yoshihiro Shimoda

[PATCH 3/3] phy: rcar-gen3-usb2: add extcon support

2016-03-03 Thread Yoshihiro Shimoda
This patch adds extcon support for otg related channel. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/phy/Kconfig | 1 + drivers/phy/phy-rcar-gen3-usb2.c | 26 ++ 2 files changed, 27 insertions(+) diff --git a/drive

[PATCH 2/3] phy: rcar-gen3-usb2: Add vbus-supply to handle VBUS on/off

2016-03-03 Thread Yoshihiro Shimoda
To handle the VBUS on/off by a regulator driver, this patch adds regulator APIs calling in the driver and description about vbus-supply in the rcar-gen3-phy-usb2.txt. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> Acked-by: Rob Herring <r...@kernel.org> --- ..

[PATCH 1/3] phy: rcar-gen3-usb2: remove unnecesary struct rcar_gen3_data

2016-03-03 Thread Yoshihiro Shimoda
Since this driver uses the struct rcar_gen3_data in struct rcar_gen3_chan only, we can remove the rcar_gen3_data. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/phy/phy-rcar-gen3-usb2.c | 33 ++--- 1 file changed, 14 insertions(

RE: [PATCH] usb: gadget: udc-core: remove manual dma configuration

2016-04-05 Thread Yoshihiro Shimoda
ce manually, because all DMA operation are performed > using parent/controller device. > > Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> > Signed-off-by: Grygorii Strashko <grygorii.stras...@ti.com> My environment could work correctly after I applied this patch.

RE: [PATCH 3/3] phy: rcar-gen3-usb2: add extcon support

2016-04-05 Thread Yoshihiro Shimoda
Hi Kishon, Would you review this patch set? As I said on the cover letter, this patch set is based on some patches. http://thread.gmane.org/gmane.linux.drivers.devicetree/158563 Hi Chanwoo, Thank you very much for the review about extcon usage! Best regards, Yoshihiro Shimoda > From: Chan

RE: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value

2016-03-28 Thread Yoshihiro Shimoda
Hi, > Sent: Monday, March 28, 2016 5:30 PM > > Hi, > > Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> writes: > >> > ps: there might be bugs there, but it's a holiday and I really shouldn't > >> > be spending time on this right now ;-) >

RE: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value

2016-03-28 Thread Yoshihiro Shimoda
Hi, > Sent: Saturday, March 26, 2016 6:11 PM < snip > > > ps: there might be bugs there, but it's a holiday and I really shouldn't > > be spending time on this right now ;-) > > I'm also off on holiday now until Sunday 10th April... yay :-) > > > > Anyway, have fun testing. Let me know if it

RE: [PATCH] usb: renesas_usbhs: fix signed-unsigned return

2016-04-14 Thread Yoshihiro Shimoda
p_pipecfg() prototype is changed like the following? static int usbhsp_setup_pipecfg(struct usbhs_pipe *pipe, int is_host, int dir_in, u16 *pipecfg); Best regards, Yoshihiro Shimoda > Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> >

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-14 Thread Yoshihiro Shimoda
Hi, > From: Roger Quadros > Sent: Thursday, April 14, 2016 8:00 PM > > On 14/04/16 11:36, Yoshihiro Shimoda wrote: > > Hi, > > < snip > > > diff --git a/drivers/usb/common/common.c b/drivers/usb/common/common.c > > index e3d0161..8b74715 100644 >

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-21 Thread Yoshihiro Shimoda
Hi, > From: Peter Chen > Sent: Friday, April 22, 2016 12:34 PM > > On Fri, Apr 22, 2016 at 09:26:46AM +0800, Peter Chen wrote: > > On Fri, Apr 15, 2016 at 10:03:16AM +, Yoshihiro Shimoda wrote: > > > Hi, > > > > > > > From: Yoshihiro Shim

RE: [PATCH v7 10/14] usb: otg: add hcd companion support

2016-05-11 Thread Yoshihiro Shimoda
uple of places. Search for > "companion" in core/hcd-pci.c and you'll see. Thank you for the information. I didn't know this code. If my understanding is correct, the core/hcd-pci.c code will not be used by non-PCI devices. In other words, nobody sets "hcd->self.hs_companion" if we use such a device. So, I will try to add such a code if needed. Best regards, Yoshihiro Shimoda > Alan Stern

RE: [PATCH v7 10/14] usb: otg: add hcd companion support

2016-05-12 Thread Yoshihiro Shimoda
Hi, > From: Roger Quadros > Sent: Thursday, May 12, 2016 6:32 PM > > Hi, > > On 12/05/16 11:34, Roger Quadros wrote: > > On 12/05/16 07:00, Yoshihiro Shimoda wrote: > >> Hi, > >> > >>> From: Alan Stern > >>> Sent: Wednesday, Ma

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-19 Thread Yoshihiro Shimoda
Hi, > From: Peter Chen > Sent: Tuesday, April 19, 2016 6:18 PM > > On Fri, Apr 15, 2016 at 10:03:16AM +0000, Yoshihiro Shimoda wrote: > > Hi, > > > > > From: Yoshihiro Shimoda > > > Sent: Friday, April 15, 2016 6:59 PM > > > > > >

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-14 Thread Yoshihiro Shimoda
Hi, > From: Roger Quadros > Sent: Monday, April 11, 2016 7:55 PM > > On 08/04/16 14:22, Yoshihiro Shimoda wrote: > > Hi, > > > >> From: Roger Quadros > >> Sent: Thursday, April 07, 2016 8:45 PM > >> > >> Hi, > >> > >>

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-15 Thread Yoshihiro Shimoda
Hi, > From: Roger Quadros > Sent: Thursday, April 14, 2016 8:32 PM > > On 14/04/16 14:15, Yoshihiro Shimoda wrote: > > Hi, > > < snip > > >>> @@ -865,7 +867,8 @@ int usb_otg_register_hcd(struct usb_hcd *hcd, > >>> unsigned int irq

RE: [PATCH v6 07/12] usb: otg: add OTG/dual-role core

2016-04-15 Thread Yoshihiro Shimoda
Hi, > From: Yoshihiro Shimoda > Sent: Friday, April 15, 2016 6:59 PM > > Hi, > > > From: Roger Quadros > > Sent: Thursday, April 14, 2016 8:32 PM > > > > On 14/04/16 14:15, Yoshihiro Shimoda wrote: > > > Hi, > > > > < snip > &

RE: [PATCH] phy: rcar-gen3-usb2: fix mutex_lock calling in interrupt

2016-06-29 Thread Yoshihiro Shimoda
Hi, > From: Kishon Vijay Abraham I > Sent: Wednesday, June 29, 2016 11:04 PM > > +Chanwoo > > Hi, > > On Monday 27 June 2016 12:06 PM, Yoshihiro Shimoda wrote: > > This patch fixes an issue that the extcon_set_cable_state_() is possible > > to cause &q

[PATCH] serial: sh-sci: Fix panic when serial console and DMA are enabled

2017-02-26 Thread Yoshihiro Shimoda
Fixes: 73a19e4c0301 ("serial: sh-sci: Add DMA support.") Signed-off-by: Takatoshi Akiyama <takatoshi.akiyama...@ps.hitachi-solutions.com> [Shimoda changes the commit log] Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- This patch is based on the followi

[PATCH 2/2] phy: rcar-gen3-usb2: Add a compatible string for r8a7796

2016-08-24 Thread Yoshihiro Shimoda
This driver can support for r8a7796 SoC. So, this patch adds it. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 ++ drivers/phy/phy-rcar-gen3-usb2.c | 1 + 2 files chan

[PATCH 0/2] phy: rcar-gen3-usb2: revise the dt doc and add support for r8a7796

2016-08-24 Thread Yoshihiro Shimoda
This patch set is based on the latest linux-phy.git / next branch. (commit id = d9a6e11e10d657df9af1d321c0eccdead184f72a) Yoshihiro Shimoda (2): phy: rcar-gen3-usb2: revise the example of device tree doc phy: rcar-gen3-usb2: Add a compatible string for r8a7796 Documentation/devicetree

[PATCH 1/2] phy: rcar-gen3-usb2: revise the example of device tree doc

2016-08-24 Thread Yoshihiro Shimoda
The clocks property should be set to , not _clks. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindin

RE: [PATCH v2 3/3] usb: renesas_usbhs: cleanup with list_first_entry_or_null()

2016-09-27 Thread Yoshihiro Shimoda
t; Thank you for the patch! Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> Best regards, Yoshihiro Shimoda

[PATCH v5] phy: rcar-gen3-usb2: add sysfs for usb role swap

2016-11-08 Thread Yoshihiro Shimoda
evice must input the following command if you want the board to act as a host again. (even if you disconnect the usb cable, since id state may be the same, the A-Device keeps to act as peripheral.) # echo host > /sys/devices/platform/soc/ee080200.usb-phy/role Signed-off-by: Yoshihiro Shimoda

RE: [PATCH v4] phy: rcar-gen3-usb2: add sysfs for usb role swap

2016-11-08 Thread Yoshihiro Shimoda
Hi Peter-san, > From: Peter Chen > Sent: Wednesday, November 09, 2016 10:39 AM > > On Tue, Nov 08, 2016 at 08:14:58PM +0900, Yoshihiro Shimoda wrote: > > This patch adds sysfs "role" for usb role swap. This parameter can be > > read and write. If you use this f

RE: [PATCH] usb: renesas_usbhs: simplify list handling

2016-11-07 Thread Yoshihiro Shimoda
nk you for the patch! However, such a patch is already merged in the Felipe's usb.git repository unfortunately... https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next=31faf878bd8c7e2c078a3b75f65efe64f23b0f18 So, the patch will appear in linux-next repository in the future. Best regards, Yoshihiro Shimoda

RE: [PATCH v3] phy: rcar-gen3-usb2: add sysfs for usb role swap

2016-11-08 Thread Yoshihiro Shimoda
Hi, > From: Peter Chen > Sent: Tuesday, November 08, 2016 6:25 PM > > On Wed, Nov 02, 2016 at 03:47:12PM +0900, Yoshihiro Shimoda wrote: < snip > > > + /* If current and new mode is the same, this returns the error */ > > + if (is_host == new_mode_is_host)

[PATCH v4] phy: rcar-gen3-usb2: add sysfs for usb role swap

2016-11-08 Thread Yoshihiro Shimoda
evice must input the following command if you want the board to act as a host again. (even if you disconnect the usb cable, since id state may be the same, the A-Device keeps to act as peripheral.) # echo host > /sys/devices/platform/soc/ee080200.usb-phy/role Signed-off-by: Yoshihiro Shimoda

[PATCH] phy: rcar-gen3-usb2: add sysfs for usb role swap

2016-10-17 Thread Yoshihiro Shimoda
/otg_inputs Also you can use the following command if you want the B-device board to act as a peripheral again. # echo b_bus_req/ > /sys/devices/platform/soc/ee080200.usb-phy/otg_inputs Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- This patch is based on the linux

RE: [PATCH v2 RESEND] drivers/usb: Skip auto handoff for TI and RENESAS usb controllers

2016-10-24 Thread Yoshihiro Shimoda
ontrollers? Is there some > documentation > about this, errata or anything? > > Adding Yoshihiro Shimoda, he might know about the Renesas controller. Thank you for adding me on this email. However, unfortunately I don't know the detail about Renesas PCIe xHCI controllers. (I know the xHCI controller of R-Car SoCs for now.) Best regards, Yoshihiro Shimoda

RE: [PATCH] phy: rcar-gen3-usb2: add sysfs for usb role swap

2016-10-18 Thread Yoshihiro Shimoda
Hi Geert-san, > From: geert.uytterhoe...@gmail.com > Sent: Monday, October 17, 2016 9:28 PM > > Hi Shimoda-san, > > On Mon, Oct 17, 2016 at 9:10 AM, Yoshihiro Shimoda > <yoshihiro.shimoda...@renesas.com> wrote: > > This patch adds sysfs "otg_inp

[PATCH v2] phy: rcar-gen3-usb2: add sysfs for usb role swap

2016-11-01 Thread Yoshihiro Shimoda
/otg_inputs Also you can use the following command if you want the B-device board to act as a peripheral again. # echo b_bus_req/ > /sys/devices/platform/soc/ee080200.usb-phy/otg_inputs Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- This patch is based on the latest

[PATCH v3] phy: rcar-gen3-usb2: add sysfs for usb role swap

2016-11-02 Thread Yoshihiro Shimoda
evice must input the following command if you want the board to act as a host again. (even if you disconnect the usb cable, since id state may be the same, the A-Device keeps to act as peripheral.) # echo host > /sys/devices/platform/soc/ee080200.usb-phy/role Signed-off-by: Yoshihiro Shimoda

RE: [PATCH v2] phy: rcar-gen3-usb2: add sysfs for usb role swap

2016-11-01 Thread Yoshihiro Shimoda
Hi Peter, > From: Peter Chen [mailto:hzpeterc...@gmail.com] > Sent: Tuesday, November 01, 2016 8:38 PM > > On Tue, Nov 01, 2016 at 04:01:58PM +0900, Yoshihiro Shimoda wrote: > > This patch adds sysfs "otg_inputs" for usb role swap. This parameter > >

RE: [PATCH 12/12] usb: renesas_usbhs: Replace the deprecated extcon API

2016-12-05 Thread Yoshihiro Shimoda
he patch! Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> Best regards, Yoshihiro Shimoda

RE: [PATCH 01/12] phy: rcar-gen3-usb2: Replace the deprecated extcon API

2016-12-05 Thread Yoshihiro Shimoda
he patch! Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> Best regards, Yoshihiro Shimoda

RE: [PATCH v3] phy: rcar-gen3-usb2: fix implementation for runtime PM

2017-04-04 Thread Yoshihiro Shimoda
Hi Kishon, > From: Yoshihiro Shimoda, Sent: Tuesday, March 14, 2017 8:38 AM > > This patch fixes an issue that this driver doesn't take care of the runtime > PM. This code assumed that devm_phy_create() called pm_runtime_enable(dev), > but it misunderstood the dev_phy_create()'

[PATCH] phy: rcar-gen3-usb2: fix implementation for runtime PM

2017-03-13 Thread Yoshihiro Shimoda
: f3b5a8d9b50d ("phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver") Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- drivers/phy/phy-rcar-gen3-usb2.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/drivers/phy/phy-

[PATCH v2] phy: rcar-gen3-usb2: fix implementation for runtime PM

2017-03-13 Thread Yoshihiro Shimoda
: f3b5a8d9b50d ("phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver") Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> --- Changes from v1: - revise the commit log (s/the own/its own/) - simplify return code in probe(). drivers/phy/phy-rcar-

RE: [PATCH] phy: rcar-gen3-usb2: fix implementation for runtime PM

2017-03-13 Thread Yoshihiro Shimoda
Hello! > -Original Message- > From: Sergei Shtylyov > Sent: Monday, March 13, 2017 6:04 PM > > Hello! > > On 3/13/2017 9:24 AM, Yoshihiro Shimoda wrote: > > > This patch fixes an issue that this driver doesn't take care of the runtime > > PM. Th

RE: [PATCH v2] phy: rcar-gen3-usb2: fix implementation for runtime PM

2017-03-13 Thread Yoshihiro Shimoda
Hi! > From: Sergei Shtylyov > Sent: Monday, March 13, 2017 8:57 PM > > On 03/13/2017 12:39 PM, Yoshihiro Shimoda wrote: > > > This patch fixes an issue that this driver doesn't take care of the runtime > > PM. This code assumed that devm_phy_create() c

  1   2   >