Hi David,
This is a nice patch set.
I just have found something should be fixed, which related to
your work. I'll send it following this mail.
Would you mind adding these patches as your patch series?
Thanks,
Yoshihiro YUNOMAE
(2012/10/02 12:31), David Sharp wrote:
In order to promote
/10/1/652), but this bug already exists in the
counter mode.
Thank you,
---
Yoshihiro YUNOMAE (2):
ftrace: Show raw time stamp on stats per cpu using counter or tsc mode
for trace_clock
ftrace: Change unsigned long type of ring_buffer_oldest_event_ts() to u64
include/linux
Show raw time stamp values for stats per cpu if you choose counter or tsc mode
for trace_clock. Although a unit of tracing time stamp is nsec in local or
global mode,
the units in counter and TSC mode are tracing counter and cycles respectively.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae
ring_buffer_oldest_event_ts() should return a value of u64 type, because
ring_buffer_per_cpu-buffer_page-buffer_data_page-time_stamp is u64 type.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Steven Rostedt rost...@goodmis.org
Cc: Frederic Weisbecker fweis...@gmail.com
Cc
printk() to output TSC offset value, but I think this is not the best
method. For example, defining as a tracepoint is one of the methods. In the
case, multiple buffers are needed to keep these data.
I need your comments, thanks!
---
Yoshihiro YUNOMAE (2):
kvm/vmx: Print TSC_OFFSET information
-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Avi Kivity a...@redhat.com
Cc: Marcelo Tosatti mtosa...@redhat.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc
[003] d...50550079286028: kvm_entry: [detail]
|
\guest/host
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
tools/scripts/trace-merge/trace-merge.pl | 109 ++
1 file changed, 109 insertions(+)
create mode 100755 tools/scripts/trace-merge/trace
Thank you for commenting on my patch set.
(2012/11/14 11:31), Steven Rostedt wrote:
On Tue, 2012-11-13 at 18:03 -0800, David Sharp wrote:
On Tue, Nov 13, 2012 at 6:00 PM, Steven Rostedt rost...@goodmis.org wrote:
On Wed, 2012-11-14 at 10:36 +0900, Yoshihiro YUNOMAE wrote:
To merge the data
extraction.
The source code of the output/input of saved_cmdlines data can be reused when
extract trace_clock, so we define general functions for outputting/inputting a
file on debugfs.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-input.c | 45
cpu number]
...
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
event-parse.c | 44 ++--
event-parse.h |3 +++
trace-cmd.h|1 +
trace-input.c | 16
trace-output.c |6 ++
trace-util.c | 26
this patch series for trace-cmd?
Thank you,
---
Yoshihiro YUNOMAE (2):
trace-cmd: Define general functions for outputting/inputting
saved_cmdlines
trace-cmd: Support trace_clock extraction
event-parse.c | 44
event-parse.h |3 ++
trace
Hi Steven,
Thank you for reviewing my patch set.
(2013/04/10 1:00), Steven Rostedt wrote:
On Fri, 2013-04-05 at 10:54 +0900, Yoshihiro YUNOMAE wrote:
In this patch, trace-cmd reads trace_clock on debugfs in the report/extract
modes and outputs the data to trace.dat file. Then, in the report
,
--
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: yoshihiro.yunomae...@hitachi.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
a patch series for this feature.
Thanks!
--
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: yoshihiro.yunomae...@hitachi.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
Hi Amit,
Thank you for commenting on our work.
(2012/07/26 20:35), Amit Shah wrote:
On (Tue) 24 Jul 2012 [11:36:57], Yoshihiro YUNOMAE wrote:
[...]
Therefore, we propose a new system virtio-trace, which uses enhanced
virtio-serial and existing ring-buffer of ftrace, for collecting guest
Hi Amit,
Sorry for the late reply.
(2012/07/27 18:43), Amit Shah wrote:
On (Fri) 27 Jul 2012 [17:55:11], Yoshihiro YUNOMAE wrote:
Hi Amit,
Thank you for commenting on our work.
(2012/07/26 20:35), Amit Shah wrote:
On (Tue) 24 Jul 2012 [11:36:57], Yoshihiro YUNOMAE wrote
pthread flag should not be -lpthread but -pthread using gcc. The -lpthread
links the external multithread library. On the other hand, the -pthread manages
both the gcc's preprocessor and linker to be able to compile with pthread.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
the port is ready on splice
virtio/console: Add a failback for unstealable pipe buffer
virtio/console: Add splice_write support
Yoshihiro YUNOMAE (1):
tools: Add guest trace agent as a user tool
drivers/char/virtio_console.c | 198 ++--
kernel/trace
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Enable to use splice_write from pipe to virtio-console port.
This steals pages from pipe and directly send it to host.
Note that this may accelerate only the guest to host path.
Changes in v2:
- Use GFP_KERNEL instead of GFP_ATOMIC in
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Add a failback memcpy path for unstealable pipe buffer.
If buf-ops-steal() fails, virtio-serial tries to
copy the page contents to an allocated page, instead
of just failing splice().
Signed-off-by: Masami Hiramatsu
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Wait if the port is not connected or full on splice
like as write is doing.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
---
drivers/char/virtio_console.c | 39 +++
1 files changed,
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Use generic steal operation on pipe buffer to allow stealing
ring buffer's read page from pipe buffer.
Note that this could reduce the performance of splice on the
splice_write side operation without affinity setting.
Since the ring buffer's
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Allocate scatterlist according to the current pipe size.
This allows splicing bigger buffer if the pipe size has
been changed by fcntl.
Changes in v2:
- Just a minor fix for avoiding a confliction with previous patch.
Signed-off-by: Masami
trace data to stdout by using -o option
- controlled by start/stop orders from a Host
Changes in v2:
- Cleanup (change fprintf() to pr_err() and an include guard)
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
tools/virtio/virtio-trace/Makefile | 14 +
tools
-blocking mode in QEMU
Thank you,
---
Masami Hiramatsu (2):
trace-cmd: Use tracing directory to count CPUs
trace-cmd: Use TRACE_DIR envrionment variable if defined
Yoshihiro YUNOMAE (3):
trace-cmd: Use polling function
trace-cmd: Add non-blocking option for open
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Use TRACE_DIR environment variable for setting
debugfs/tracing directory if defined. This is
for controlling guest(or remote) ftrace.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Signed-off-by: Yoshihiro YUNOMAE
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Count debugfs/tracing/per_cpu/cpu* to determine the
number of CPUs.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-record.c | 41
\
trace-cmd record -e sched:*
Here, AGENT_READ_DIR is the path for a reading directory of virtio-trace,
AGENT_CTL is a control path of trace-agent, and TRACING_DIR is a debugfs path
of a guest.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-cmd.h |1
Use poll() for avoiding a busy loop to read trace data of a guest from FIFO.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-recorder.c | 42 --
1 files changed, 36 insertions(+), 6 deletions(-)
diff --git a/trace-recorder.c
nonblock option to open() and splice_read().
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-recorder.c | 13 -
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/trace-recorder.c b/trace-recorder.c
index 3b750e9..6577fe8 100644
--- a/trace
Hi Steven,
(2012/08/22 22:51), Steven Rostedt wrote:
On Wed, 2012-08-22 at 17:43 +0900, Yoshihiro YUNOMAE wrote:
Add read path and control path to use trace-agent of virtio-trace.
When we use trace-agent, trace-cmd will be used as follows:
# AGENT_READ_DIR=/tmp/virtio-trace/tracing
splice_write support
Yoshihiro YUNOMAE (1):
tools: Add guest trace agent as a user tool
drivers/char/virtio_console.c | 198 ++--
kernel/trace/trace.c|8 -
tools/virtio/virtio-trace/Makefile | 14 +
tools/virtio/virtio
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Enable to use splice_write from pipe to virtio-console port.
This steals pages from pipe and directly send it to host.
Note that this may accelerate only the guest to host path.
Signed-off-by: Masami Hiramatsu
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Add a failback memcpy path for unstealable pipe buffer.
If buf-ops-steal() fails, virtio-serial tries to
copy the page contents to an allocated page, instead
of just failing splice().
Signed-off-by: Masami Hiramatsu
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Wait if the port is not connected or full on splice
like as write is doing.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Amit Shah amit.s...@redhat.com
Cc: Arnd Bergmann a...@arndb.de
Cc: Greg Kroah-Hartman
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Allocate scatterlist according to the current pipe size.
This allows splicing bigger buffer if the pipe size has
been changed by fcntl.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Amit Shah amit.s...@redhat.com
Cc:
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Use generic steal operation on pipe buffer to allow stealing
ring buffer's read page from pipe buffer.
Note that this could reduce the performance of splice on the
splice_write side operation without affinity setting.
Since the ring buffer's
trace data to stdout by using -o option
- controlled by start/stop orders from a Host
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
tools/virtio/virtio-trace/Makefile | 14 +
tools/virtio/virtio-trace/README| 118
tools/virtio/virtio
Hi Stefan,
Thank you for commenting on our patch set.
(2012/07/24 20:03), Masami Hiramatsu wrote:
(2012/07/24 19:02), Stefan Hajnoczi wrote:
On Tue, Jul 24, 2012 at 3:36 AM, Yoshihiro YUNOMAE
yoshihiro.yunomae...@hitachi.com wrote:
The performance of each method is compared as follows:
[1
Hi Stefan,
(2012/07/24 22:41), Stefan Hajnoczi wrote:
On Tue, Jul 24, 2012 at 12:19 PM, Yoshihiro YUNOMAE
yoshihiro.yunomae...@hitachi.com wrote:
Are you using text formatted ftrace?
No, currently using raw format, but　we'd like to reformat it in text.
Capturing the info necessary
Hi Marcelo,
Sorry for the late reply.
(2012/11/17 4:15), Marcelo Tosatti wrote:
On Wed, Nov 14, 2012 at 05:26:10PM +0900, Yoshihiro YUNOMAE wrote:
Thank you for commenting on my patch set.
(2012/11/14 11:31), Steven Rostedt wrote:
On Tue, 2012-11-13 at 18:03 -0800, David Sharp wrote
Hi Steven,
Sorry for the late reply.
(2012/11/17 0:05), Steven Rostedt wrote:
On Wed, 2012-11-14 at 17:26 +0900, Yoshihiro YUNOMAE wrote:
Thank you for commenting on my patch set.
(2012/11/14 11:31), Steven Rostedt wrote:
On Tue, 2012-11-13 at 18:03 -0800, David Sharp wrote:
On Tue, Nov 13
Hi Marcelo,
(2012/11/21 7:51), Marcelo Tosatti wrote:
On Tue, Nov 20, 2012 at 07:36:33PM +0900, Yoshihiro YUNOMAE wrote:
Hi Marcelo,
Sorry for the late reply.
(2012/11/17 4:15), Marcelo Tosatti wrote:
On Wed, Nov 14, 2012 at 05:26:10PM +0900, Yoshihiro YUNOMAE wrote:
Thank you
Hi Marcelo,
(2012/11/24 7:46), Marcelo Tosatti wrote:
On Thu, Nov 22, 2012 at 02:21:20PM +0900, Yoshihiro YUNOMAE wrote:
Hi Marcelo,
(2012/11/21 7:51), Marcelo Tosatti wrote:
On Tue, Nov 20, 2012 at 07:36:33PM +0900, Yoshihiro YUNOMAE wrote:
Hi Marcelo,
Sorry for the late reply.
(2012/11
Hi Marcelo,
(2012/11/27 8:16), Marcelo Tosatti wrote:
On Mon, Nov 26, 2012 at 08:05:10PM +0900, Yoshihiro YUNOMAE wrote:
500h. event tsc_write tsc_offset=-3000
Then a guest trace containing events with a TSC timestamp.
Which tsc_offset to use?
(that is the problem, which unless i am mistaken
Hi Marcelo,
Thank you for commenting on my patch set.
(2012/11/16 12:19), Marcelo Tosatti wrote:
On Wed, Nov 14, 2012 at 10:36:21AM +0900, Yoshihiro YUNOMAE wrote:
[...]
In this summary, I suggest the patch which TSC offset for each guest can be
output on the host.
The guest TSC can change
Hi Steven,
Thank you for reviewing my patches.
Sorry for the late reply.
(2013/08/21 1:00), Steven Rostedt wrote:
On Mon, 19 Aug 2013 18:46:20 +0900
Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote:
d) merge feature of trace data of multiple guests and a host in chronological
(2013/08/21 2:49), Steven Rostedt wrote:
On Mon, 19 Aug 2013 18:46:37 +0900
Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote:
Split out binding a port and fork reader from open_udp() for avoiding duplicate
codes between listen mode and virt-server mode.
Signed-off-by: Yoshihiro
(2013/08/21 2:56), Steven Rostedt wrote:
On Mon, 19 Aug 2013 18:46:39 +0900
Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote:
This message protocol is incompatible with the previous unstructured message
protocol. So, if an old(new)-version client tries to connect to an
new(old
Hi Don,
Sorry for the late reply.
(2013/08/22 22:11), Don Zickus wrote:
On Thu, Aug 22, 2013 at 05:38:07PM +0900, Yoshihiro YUNOMAE wrote:
So, I agree with Eric, let's remove the disable_IO_APIC() stuff and keep
the code simpler.
Thank you for commenting about my patch.
I didn't know you
Hi Steven,
(2013/08/26 23:22), Steven Rostedt wrote:
On Mon, 26 Aug 2013 10:46:38 +0900
Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote:
The --date option is used because the two machines are not in sync with
the trace time stamp. What the date option does, is to sync the
timestamp
(2013/08/26 23:37), Steven Rostedt wrote:
On Mon, 26 Aug 2013 10:48:15 +0900
Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote:
+static int open_udp(const char *node, const char *port, int *pid,
+ int cpu, int pagesize, int start_port)
+{
+ int sfd;
+ int
(2013/08/27 0:11), Steven Rostedt wrote:
On Mon, 26 Aug 2013 10:50:33 +0900
Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote:
Network
0. old server and old client
Old servers send tracecmd as the first message.
Old clients compare the first 8byte of the first message with tracecmd.
1
(2013/08/27 22:05), Steven Rostedt wrote:
On Tue, 27 Aug 2013 19:23:24 +0900
Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote:
OK, let me check that. Even if the old server will receive V2, the
server will send port numbers instead of V2 due to the old protocol.
In that time, the new
(2013/08/27 22:00), Steven Rostedt wrote:
On Tue, 27 Aug 2013 17:07:34 +0900
Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote:
et, but I'd like to
add such feature to fix host/guest clock difference in the next series.
TSC offset values can be gotten as write_tsc_offset trace event from
()-
clear_IO_APIC_pin()-ioapic_read_entry().
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: x...@kernel.org
Cc: Andrew Morton a...@linux-foundation.org
Cc: Andi Kleen
Split out the communication with listener from the setup_network() for avoiding
duplicate codes between listen mode and virt-server mode.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-record.c | 119 +---
1 file
) for collecting trace data of guests
Restrictions
- Use libvirt when we boot guests
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
Documentation/trace-cmd-virt-server.1.txt | 89 ++
trace-cmd.c |3
trace-cmd.h
(MSG_CLOSE).
This message protocol is incompatible with the previous unstructured message
protocol. So, if an old(new)-version client tries to connect to an
new(old)-version server, the operation should be stopped.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
Makefile
Split out the connect waiting loop from do_listen() for avoiding duplicate codes
between listen mode and virt-server mode.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-listen.c | 45 ++---
1 file changed, 26 insertions
*
Restriction
This feature can use from kernel-3.6 which supports splice_read for ftrace
and splice_write for virtio-serial.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
Documentation/trace-cmd-record.1.txt | 11 +-
trace-cmd.h |3 +-
trace
iface in trace-listen is not used any more, so it is deleted.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-listen.c |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/trace-listen.c b/trace-listen.c
index 8503b50..dec1c00 100644
--- a/trace
Split out the communication with client from process_client() for avoiding
duplicate codes between listen mode and virt-server mode.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-listen.c | 163
1 file
Split out binding a port and fork reader from open_udp() for avoiding duplicate
codes between listen mode and virt-server mode.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-listen.c | 34 ++
1 file changed, 26 insertions(+), 8
received the
inappropriate message tracecmd will die.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-msg.c | 50 ++
1 file changed, 42 insertions(+), 8 deletions(-)
diff --git a/trace-msg.c b/trace-msg.c
index 777ea1f
is not applied, splice(write) for virtio-serial induces kernel oops
when there are no data. This patch always avoids to do splice(write) in the
case, so this patch is needed.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-recorder.c |5 -
1 file changed, 4 insertions(+), 1
virtio-serial(splice)
client(fedora19)~2.9[%] ~1.7[%]
Future work
- Add an agent mode based on record --virt
- Add a merging feature of trace data of guests and host to report
I need your comments!
Thank you,
---
Yoshihiro YUNOMAE (11):
[TRIVIAL] trace-cmd: Delete the variable iface
if the parent process
cannot die at once due to any reasons.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-listen.c |1 +
1 file changed, 1 insertion(+)
diff --git a/trace-listen.c b/trace-listen.c
index dec1c00..6c1bcac 100644
--- a/trace-listen.c
+++ b/trace-listen.c
Hi Ingo,
Thank you for fixing typos!
OK, I'll fix them and rename to ioapic_zap_locks().
Thank you again!
Yoshihiro YUNOMAE
(2013/08/19 18:46), Ingo Molnar wrote:
* Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote:
Prevent crash_kexec() from deadlocking of ioapic_lock.
s
()-
clear_IO_APIC_pin()-ioapic_read_entry().
Changes in V2: Fix typos, change ioapic_lock_init() to ioapic_zap_locks(),
and change #if defined(CONFIG_X86_IO_APIC) to
#ifdef CONFIG_X86_IO_APIC.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Thomas Gleixner t
(2013/08/20 23:27), Don Zickus wrote:
On Tue, Aug 20, 2013 at 03:12:32AM -0700, Eric W. Biederman wrote:
Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com writes:
Hi Ingo,
Thank you for fixing typos!
OK, I'll fix them and rename to ioapic_zap_locks().
Thank you again!
The better fix
89 e6 4c 89 ff 41
RIP [811a6b5f] splice_from_pipe_feed+0x6f/0x130
RSP 88007b55fd78
CR2: 0018
---[ end trace 24572beb7764de59 ]---
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Amit Shah amit.s...@redhat.com
Cc: Arnd Bergmann a...@arndb.de
Cc
in splice_from_pipe_feed() by bug of any user
application.
These reports are written in each patch.
Thanks!
---
Yoshihiro YUNOMAE (2):
[BUGFIX] virtio/console: Quit from splice_write if pipe-nrbufs is 0
[BUGFIX] virtio/console: Add pipe_lock/unlock for splice_write
drivers/char
splice_write is executed in the virtio-console driver.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Amit Shah amit.s...@redhat.com
Cc: Arnd Bergmann a...@arndb.de
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/char/virtio_console.c |7 +++
1 file changed, 7
Hi Amit,
(2013/07/19 14:23), Amit Shah wrote:
On (Fri) 19 Jul 2013 [08:19:32], Yoshihiro YUNOMAE wrote:
Add pipe_lock/unlock for splice_write to avoid oops by following competition:
diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 8722656..4a28e4c 100644
(2013/07/19 14:23), Amit Shah wrote:
On (Fri) 19 Jul 2013 [08:19:27], Yoshihiro YUNOMAE wrote:
Hi,
This patch set fixes two bugs of splice_write in the virtio-console driver.
[BUG1] Although pipe-nrbufs is empty, the driver tries to do splice_write.
= This induces oops
splice_write is executed in the virtio-console driver.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Amit Shah amit.s...@redhat.com
Cc: Arnd Bergmann a...@arndb.de
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/char/virtio_console.c |7 +++
1 file changed, 7
in splice_from_pipe_feed() by bug of any user
application.
These reports are written in each patch.
Changes in V2:
- Fix a locking problem for error
Thanks!
---
Yoshihiro YUNOMAE (2):
[BUGFIX] virtio/console: Quit from splice_write if pipe-nrbufs is 0
[BUGFIX] virtio/console: Add pipe_lock
89 e6 4c 89 ff 41
RIP [811a6b5f] splice_from_pipe_feed+0x6f/0x130
RSP 88007b55fd78
CR2: 0018
---[ end trace 24572beb7764de59 ]---
V2: Fix a locking problem for error
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Amit Shah amit.s...@redhat.com
Split out binding a port and fork reader from open_udp() for avoiding duplicate
codes between listen mode and virt-server mode.
Changes in V2: Add a comment in open_udp()
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
trace-listen.c | 38
Changes in V2:
[1/5] Add a comment in open_udp()
[2/5] Regacy protocol support in order to keep backward compatibility
Thank you,
---
Yoshihiro YUNOMAE (5):
[CLEANUP] trace-cmd: Split out binding a port and fork reader from
open_udp()
trace-cmd: Apply the trace-msg protocol
-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
Documentation/trace-cmd-record.1.txt | 11 -
trace-cmd.h |3 +
trace-msg.c | 80 --
trace-msg.h |4 ++
trace-record.c
of virtio-serial for trace data paths
- Use UNIX domain socket for connecting clients on guests
- Use splice(2) for collecting trace data of guests
Restrictions
- Use libvirt when we boot guests
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
---
Documentation/trace-cmd-virt
the message \0 as port numbers. Then, the message which the client
receives is not V2 but \0, so the client will reconnect to the old server
as the v1 protocol.
Changes in V2: Regacy porotocol support in order to keep backward compatibility
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae
Use poll(2) to wait for a message. If a client/server cannot send a message for
any reasons, the current server/client will wait in a blocking read operation.
So, we use poll(2) for avoiding remaining in a blocking state.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
usage, and a
corruption of the output data.
To address these issues, make saved_cmdlines use seq_read.
Signed-off-by: Hidehiro Kawai hidehiro.kawai...@hitachi.com
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Steven Rostedt rost...@goodmis.org
Cc: Frederic Weisbecker fweis
will be
stored. And, if we read the I/F, we can get current maximum number of command
name. The default number is 128 which is current default number, so this patch
does not change the usage of memory for saved_cmdlines when we boot kernel.
Thanks!
---
Yoshihiro YUNOMAE (2):
ftrace: Make
-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Steven Rostedt rost...@goodmis.org
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Ingo Molnar mi...@redhat.com
Cc: linux-kernel@vger.kernel.org
---
kernel/trace/trace.c | 211 +-
1 file changed
Hi Steven,
(2013/10/15 6:26), Steven Rostedt wrote:
On Fri, 13 Sep 2013 11:06:27 +0900
Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote:
How to use
1. Run virt-server on a host
# trace-cmd virt-server
2. Make guest domain directory
# mkdir -p /tmp/trace-cmd/virt/domain
(2013/10/15 11:21), Steven Rostedt wrote:
On Fri, 13 Sep 2013 11:06:32 +0900
Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com wrote:
Apply trace-msg protocol for communication between a server and clients.
Currently, trace-listen(server) and trace-record -N(client) operate as follows
Hi,
Would you review this patch?
Thanks,
Yoshihiro YUNOMAE
(2013/11/11 17:18), Yoshihiro YUNOMAE wrote:
Add __sched to msleep() and msleep_interruptible() for avoiding to show
these functions in WCHAN. If a driver calls msleep() or msleep_interruptible()
in a lot of places, users cannot
this
patch, users can confirm the function calling msleep() or msleep_interruptible()
from WCHAN.
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: linux-kernel@vger.kernel.org
---
kernel/timer.c |4 ++--
1 file changed, 2 insertions
Hi,
Would you review this patch set?
Thanks,
Yoshihiro YUNOMAE
(2013/11/08 13:26), Yoshihiro YUNOMAE wrote:
Hi,
This patch set introduces the new I/F nr_saved_cmdlines for increasing
the number of saved cmdlines. Current saved_cmdlines can store just 128 command
names and PIDs, but process
(2) to sysfs(rx_int_trig)
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: Jiri Slaby jsl...@suse.cz
Cc: Heikki Krogerus heikki.kroge...@linux.intel.com
Cc: Jingoo Han jg1@samsung.com
Cc: Aaron Sierra asie...@xes-inc.com
Cc
Hi Heikki,
Thank you for your reply.
(2014/03/14 23:16), Heikki Krogerus wrote:
Hi,
On Fri, Mar 14, 2014 at 11:21:54AM +0900, Yoshihiro YUNOMAE wrote:
void serial8250_clear_and_reinit_fifos(struct uart_8250_port *p)
{
- unsigned char fcr;
-
serial8250_clear_fifos(p
think actually you just want
default:
return -EOPNOTSUPP;
OK, I'll use this.
Thank you,
Yoshihiro YUNOMAE
--
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: yoshihiro.yunomae...@hitachi.com
: [sdb] CDB: Read(10): 28 00 00 00 11 e0 00 01 00 00
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: James E.J. Bottomley jbottom...@parallels.com
Cc: Hannes Reinecke h...@suse.de
Cc: Kay Sievers k...@vrfy.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-s...@vger.kernel.org
Hi Hannes,
Although I sent you a message 6 days ago to ask your work which
is similar to my patch, I resend my patch because I'm considering
this problem should be fixed as soon as possible.
Thank you,
Yoshihiro YUNOMAE
(2014/02/27 13:17), Yoshihiro YUNOMAE wrote:
Output error messages using
of setserial command, we could set RX interrupt
trigger only for the Hayes ESP serial driver. However, current kernel
does not support Hayes ESP serial[1]. I couldn't find this feature for
current 8250/16X50 drivers.
[1] https://lkml.org/lkml/2009/12/11/500
Thanks,
Yoshihiro YUNOMAE
--
Yoshihiro YUNOMAE
| O_NONBLOCK);
ioctl(fd, TIOCSFIFOTRIG, rx_trig_byte);
read(fd, buf, size);
Support uart device
- 16550A (1, 4, 8, or 14 bytes)
Changed in V2:
- Use _IOW for TIOCSFIFORTRIG definition
- Pass the interrupt trigger value itself
Signed-off-by: Yoshihiro YUNOMAE yoshihiro.yunomae...@hitachi.com
Cc: Greg
1 - 100 of 494 matches
Mail list logo
