Re: [PATCH] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-04 Thread Yung-Ching LIN
Hi Andrew, Will provide the v2 for all the fixes. Thank you for the comments. On Sun, Feb 4, 2018 at 11:22 AM, Andrew Lunn wrote: > On Mon, Feb 05, 2018 at 02:45:14AM +0800, Ken Lin wrote: >> Add support for Advantech DMS-BA16 board, which use >> the Advantech BA-16 module. >>

Re: [v2] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-05 Thread Yung-Ching LIN
Hi Fabio, Thank you for your comments. Will provide the v3 for the fixes On Mon, Feb 5, 2018 at 4:13 PM, Fabio Estevam wrote: > Hi Ken, > > On Mon, Feb 5, 2018 at 10:05 PM, Ken Lin wrote: > >> diff --git a/arch/arm/boot/dts/Makefile

Re: [v3] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-08 Thread Yung-Ching LIN
Hi Shawn, Thanks for pointing out the issues. Please see my inline comments below. On Thu, Feb 8, 2018 at 1:03 AM, Shawn Guo wrote: > On Wed, Feb 07, 2018 at 03:17:04AM +0800, Ken Lin wrote: >> Add support for Advantech DMS-BA16 board, which uses >> the Advantech BA-16

Re: [PATCH] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-05 Thread Yung-Ching LIN
Hi Shawn, Will apply all the changes required to the v2. Thank you for your comments and detailed reviews. On Mon, Feb 5, 2018 at 6:12 AM, Shawn Guo wrote: > On Mon, Feb 05, 2018 at 02:45:14AM +0800, Ken Lin wrote: >> Add support for Advantech DMS-BA16 board, which use >>

Re: [PATCH] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-04 Thread Yung-Ching LIN
Hi Andrew, Will provide the v2 for all the fixes. Thank you for the comments. On Sun, Feb 4, 2018 at 11:22 AM, Andrew Lunn wrote: > On Mon, Feb 05, 2018 at 02:45:14AM +0800, Ken Lin wrote: >> Add support for Advantech DMS-BA16 board, which use >> the Advantech BA-16 module. >> >> Signed-off-by:

Re: [PATCH] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-05 Thread Yung-Ching LIN
Hi Shawn, Will apply all the changes required to the v2. Thank you for your comments and detailed reviews. On Mon, Feb 5, 2018 at 6:12 AM, Shawn Guo wrote: > On Mon, Feb 05, 2018 at 02:45:14AM +0800, Ken Lin wrote: >> Add support for Advantech DMS-BA16 board, which use >> the Advantech BA-16

Re: [v2] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-05 Thread Yung-Ching LIN
Hi Fabio, Thank you for your comments. Will provide the v3 for the fixes On Mon, Feb 5, 2018 at 4:13 PM, Fabio Estevam wrote: > Hi Ken, > > On Mon, Feb 5, 2018 at 10:05 PM, Ken Lin wrote: > >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index

Re: [v3] ARM: dts: imx: Add support for Advantech DMS-BA16

2018-02-08 Thread Yung-Ching LIN
Hi Shawn, Thanks for pointing out the issues. Please see my inline comments below. On Thu, Feb 8, 2018 at 1:03 AM, Shawn Guo wrote: > On Wed, Feb 07, 2018 at 03:17:04AM +0800, Ken Lin wrote: >> Add support for Advantech DMS-BA16 board, which uses >> the Advantech BA-16 module. >> >>