Re: [PATCH 0/2] spi-geni-qcom: Cleanup nitpicks and simplify probe function

2018-10-25 Thread alokc
On 2018-10-25 22:10, Alok Chauhan wrote: This patch series fixed the following: * nitpicks from the previous review (https://patchwork.kernel.org/patch/10624849/) * Cleanup probe function by re-arranging existing APIs to starting of function and hence avoiding one goto jump and remove few

Re: [PATCH V5 3/3] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP

2018-10-11 Thread alokc
+static irqreturn_t geni_spi_isr(int irq, void *data) +{ + struct spi_master *spi = data; + struct spi_geni_master *mas = spi_master_get_devdata(spi); + struct geni_se *se = >se; + u32 m_irq; + unsigned long flags; + irqreturn_t ret = IRQ_HANDLED; + + if

Re: [PATCH v3 2/3] i2c: i2c-qcom-geni: Simplify tx/rx functions

2018-10-04 Thread alokc
On 2018-09-25 05:22, Stephen Boyd wrote: We never really look at the 'ret' local variable in these functions, so let's remove it to make way for shorter and simpler code. Furthermore, we can shorten some lines by adding two local variables for the SE and the message length so that everything

Re: [PATCH v3 3/3] i2c: i2c-qcom-geni: Simplify irq handler

2018-10-04 Thread alokc
On 2018-09-26 03:19, Doug Anderson wrote: Hi, On Mon, Sep 24, 2018 at 4:52 PM Stephen Boyd wrote: We don't need to use goto here, we can just collapse the if statement and goto chain into multiple branches and then combine some duplicate completion calls into one big if statement. Let's do

Re: [PATCH 1/6] dt-bindings: soc: qcom: Add interconnect binding for GENI QUP

2019-01-30 Thread alokc
On 2019-01-23 17:10, Evan Green wrote: On Mon, Jan 21, 2019 at 10:34 PM Alok Chauhan wrote: Add documentation for the interconnect and interconnect-names bindings for the GENI QUP as detailed by bindings/interconnect/interconnect.txt. Signed-off-by: Alok Chauhan ---

Re: [PATCH 1/6] dt-bindings: soc: qcom: Add interconnect binding for GENI QUP

2019-01-30 Thread alokc
On 2019-01-23 10:35, Georgi Djakov wrote: Hi Alok, Thanks for the patches! On 1/22/19 08:33, Alok Chauhan wrote: Add documentation for the interconnect and interconnect-names bindings s/interconnect /interconnects / for the GENI QUP as detailed by bindings/interconnect/interconnect.txt.

Re: [PATCH 0/2] spi-geni-qcom: Cleanup nitpicks and simplify probe function

2018-10-25 Thread alokc
On 2018-10-25 22:10, Alok Chauhan wrote: This patch series fixed the following: * nitpicks from the previous review (https://patchwork.kernel.org/patch/10624849/) * Cleanup probe function by re-arranging existing APIs to starting of function and hence avoiding one goto jump and remove few

Re: [PATCH v3 2/3] i2c: i2c-qcom-geni: Simplify tx/rx functions

2018-10-04 Thread alokc
On 2018-09-25 05:22, Stephen Boyd wrote: We never really look at the 'ret' local variable in these functions, so let's remove it to make way for shorter and simpler code. Furthermore, we can shorten some lines by adding two local variables for the SE and the message length so that everything

Re: [PATCH v3 3/3] i2c: i2c-qcom-geni: Simplify irq handler

2018-10-04 Thread alokc
On 2018-09-26 03:19, Doug Anderson wrote: Hi, On Mon, Sep 24, 2018 at 4:52 PM Stephen Boyd wrote: We don't need to use goto here, we can just collapse the if statement and goto chain into multiple branches and then combine some duplicate completion calls into one big if statement. Let's do

Re: [PATCH 0/6] Add interconnect support for GENI QUPs

2019-01-22 Thread alokc
+Mark Brown On 2019-01-22 12:03, Alok Chauhan wrote: This patch series contains following: * Add wrapper framework to support interconnect path from GENI QUPs. This wrapper enabled and help individual SEs to put their BW request. Adding this wrapper make sense because we don't want

Re: [PATCH 1/6] dt-bindings: soc: qcom: Add interconnect binding for GENI QUP

2019-01-22 Thread alokc
+Mark Brown On 2019-01-22 12:03, Alok Chauhan wrote: Add documentation for the interconnect and interconnect-names bindings for the GENI QUP as detailed by bindings/interconnect/interconnect.txt. Signed-off-by: Alok Chauhan --- Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt | 10

Re: [PATCH 2/6] soc: qcom: Add wrapper to support for Interconnect path

2019-01-22 Thread alokc
+Mark Brown On 2019-01-22 12:03, Alok Chauhan wrote: Add the wrapper to support for interconnect path voting from GENI QUP. This wrapper provides the functionalities to individual Serial Engine device to get the interconnect path and to vote for bandwidth based on their need. This wrapper

Re: [PATCH 3/6] i2c: i2c-qcom-geni: Add interconnect support

2019-01-22 Thread alokc
On 2019-01-22 14:43, Peter Rosin wrote: On 2019-01-22 07:33, Alok Chauhan wrote: Get the interconnect paths for I2C based Serial Engine device and vote accordingly based on maximum supported I2C frequency. Signed-off-by: Alok Chauhan --- drivers/i2c/busses/i2c-qcom-geni.c | 13 +

Re: [PATCH 5/6] tty: serial: qcom_geni_serial: Add interconnect support

2019-01-22 Thread alokc
+Mark Brown On 2019-01-22 12:03, Alok Chauhan wrote: Get the interconnect paths for Uart based Serial Engine device and vote accordingly based on maximum supported Uart frequency. Signed-off-by: Alok Chauhan --- drivers/tty/serial/qcom_geni_serial.c | 27 ++- 1 file

Re: [PATCH 6/6] arm64: dts: sdm845: Add interconnect for GENI QUP

2019-01-22 Thread alokc
+Mark Brown On 2019-01-22 12:03, Alok Chauhan wrote: Add interconnect ports for GENI QUPs to set bus capabilities. Signed-off-by: Alok Chauhan --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi

Re: [PATCH 2/6] soc: qcom: Add wrapper to support for Interconnect path

2019-01-22 Thread alokc
+Mark Brown On 2019-01-22 12:03, Alok Chauhan wrote: Add the wrapper to support for interconnect path voting from GENI QUP. This wrapper provides the functionalities to individual Serial Engine device to get the interconnect path and to vote for bandwidth based on their need. This wrapper

Re: [PATCH 4/6] spi: spi-geni-qcom: Add interconnect support

2019-01-22 Thread alokc
On 2019-01-23 01:59, Mark Brown wrote: On Tue, Jan 22, 2019 at 12:03:34PM +0530, Alok Chauhan wrote: Get the interconnect paths for SPI based Serial Engine device and vote accordingly based on maximum supported SPI frequency. Still not seeing anything except this patch here in my inbox -

Re: [PATCH 4/6] spi: spi-geni-qcom: Add interconnect support

2019-01-21 Thread alokc
On 2019-01-21 18:13, Mark Brown wrote: On Mon, Jan 21, 2019 at 04:51:41PM +0530, Alok Chauhan wrote: Get the interconnect paths for SPI based Serial Engine device and vote accordingly based on maximum supported SPI frequency. I don't have any of the other patches in this series or a cover

Re: [PATCH 1/6] dt-bindings: soc: qcom: Add interconnect binding for GENI QUP

2019-01-21 Thread alokc
Please don't review this patch. I've resend patches after adding all the mailing list. Sorry for inconvenience. On 2019-01-21 16:51, Alok Chauhan wrote: Add documentation for the interconnect and interconnect-names bindings for the GENI QUP as detailed by

Re: [PATCH 2/6] soc: qcom: Add wrapper to support for Interconnect path

2019-01-21 Thread alokc
Please don't review this patch. I've resend patches after adding all the mailing list. Sorry for inconvenience. On 2019-01-21 16:51, Alok Chauhan wrote: Add the wrapper to support for interconnect path voting from GENI QUP. This wrapper provides the functionalities to individual Serial Engine

Re: [PATCH 3/6] i2c: i2c-qcom-geni: Add interconnect support

2019-01-21 Thread alokc
Please don't review this patch. I've resend patches after adding all the mailing list. Sorry for inconvenience. Please review patches with spi/i2c/uart/kernel mailing list added. On 2019-01-21 16:51, Alok Chauhan wrote: Get the interconnect paths for I2C based Serial Engine device and vote

Re: [PATCH V5 3/3] spi: spi-geni-qcom: Add SPI driver support for GENI based QUP

2018-10-11 Thread alokc
+static irqreturn_t geni_spi_isr(int irq, void *data) +{ + struct spi_master *spi = data; + struct spi_geni_master *mas = spi_master_get_devdata(spi); + struct geni_se *se = >se; + u32 m_irq; + unsigned long flags; + irqreturn_t ret = IRQ_HANDLED; + + if