Re: [PATCH] [media] mtk-mdp: Fix g_/s_selection capture/compose logic

2017-04-27 Thread houlong wei
On Thu, 2017-04-13 at 14:50 +0800, Wu-Cheng Li (李務誠) wrote: > Reviewed-by: Wu-Cheng Li > > On Thu, Apr 13, 2017 at 12:18 PM, Minghsiu Tsai > wrote: > > From: Daniel Kurtz > > > > Experiments show that the: > > (1)

[PATCH v22 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-06-27 Thread Houlong Wei
supports display related hardwares, but we expect it can be extended to other hardwares for future requirements. Signed-off-by: Houlong Wei Signed-off-by: HS Liao Signed-off-by: CK Hu --- drivers/mailbox/Kconfig | 10 + drivers/mailbox/Makefile |2

[PATCH v22 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-06-27 Thread Houlong Wei
Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- drivers/soc/mediatek/Kconfig | 12 ++ drivers/soc/mediatek/Makefile |1 + drivers/soc/mediatek/mtk-cmdq-helper.c | 258

[PATCH v22 3/4] arm64: dts: mt8173: Add GCE node

2018-06-27 Thread Houlong Wei
This patch adds the device node of the GCE hardware for CMDQ module. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts

[PATCH v22 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit

2018-06-27 Thread Houlong Wei
This adds documentation for the MediaTek Global Command Engine (GCE) unit found in MT8173 SoCs. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- Hi Rob, I don't add your ACK in this version since the dt-binding description has been changed. Thanks. --- .../devicetree/bindings/mailbox

[PATCH v22 0/4] MediaTek MT8173 CMDQ support

2018-06-27 Thread Houlong Wei
on v4.18-rc1 -remove subsys code and event id definition from mtk-cmdq-helper.c -add mt8173-gce.h to define the subsys code and envent id Changes since v20: -rebase on v4.15-rc1 -move dma_map_single outside of spinlock Changes since v19: - rebase to v4.10-rc2 Houlong Wei (4): dt-bindings: soc

Re: [PATCH v21 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-06-27 Thread houlong wei
et and assemble GCE op code. > > > > Signed-off-by: Houlong Wei > > Signed-off-by: HS Liao > > --- > > drivers/soc/mediatek/Kconfig | 12 ++ > > drivers/soc/mediatek/Makefile |1 + > > drivers/soc/mediatek/mtk-cmdq-helper.c |

Re: [PATCH v21 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-06-27 Thread houlong wei
create CMDQ packet and assemble GCE op code. > > > > Signed-off-by: Houlong Wei > > Signed-off-by: HS Liao > > --- > > drivers/soc/mediatek/Kconfig | 12 ++ > > drivers/soc/mediatek/Makefile |1 + > > drivers/soc/mediatek/mtk-cmdq-helper.c |

Re: [PATCH v21 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-06-27 Thread houlong wei
rts display related hardwares, but we expect > > it can be extended to other hardwares for future requirements. > > > > Signed-off-by: Houlong Wei > > Signed-off-by: HS Liao > > Signed-off-by: CK Hu > > --- > > drivers/mailbox/Kconfig

Re: [PATCH v22 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-07-03 Thread houlong wei
On Fri, 2018-06-29 at 17:22 +0800, CK Hu wrote: > Hi, Houlong: > > On Fri, 2018-06-29 at 07:32 +0800, houlong wei wrote: > > On Thu, 2018-06-28 at 18:41 +0800, CK Hu wrote: > > > Hi, Houlong: > > > > > > Some inline comment. > > > > &g

Re: [PATCH v22 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-07-03 Thread houlong wei
On Fri, 2018-06-29 at 15:08 +0800, CK Hu wrote: > Hi, Houlong: > > Some inline comment. > > On Wed, 2018-06-27 at 19:16 +0800, Houlong Wei wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help write registers wi

Re: [PATCH v22 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit

2018-07-03 Thread houlong wei
On Tue, 2018-07-03 at 10:30 +0800, Rob Herring wrote: > On Wed, Jun 27, 2018 at 07:16:09PM +0800, Houlong Wei wrote: > > This adds documentation for the MediaTek Global Command Engine (GCE) unit > > found in MT8173 SoCs. > > > > Signed-off-by: Houlong Wei

Re: FW: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-08 Thread houlong wei
.s...@mediatek.com>; Daoyuan > Huang (黃道原) <daoyuan.hu...@mediatek.com>; Damon Chu (朱峻賢) > <damon@mediatek.com>; Josh-YC Liu (劉育誠) <josh-yc@mediatek.com>; Glory > Hung (洪智瑋) <glory.h...@mediatek.com>; Jiaguang Zhang (张加广) > <jiaguang.zh...@m

Re: FW: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-18 Thread houlong wei
Hi Jassi, There is one request for one GCE h/w buffer which contains a list of registers operation. I will resubmit a version and please review again. Thanks, Houlong On Thu, 2018-01-18 at 16:01 +0800, Jassi Brar wrote: > On Mon, Jan 8, 2018 at 2:08 PM, houlong wei <houlong@mediat

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-17 Thread houlong wei
Hi Jassi, We prefer to use method (1) to move dma_map_single() outside of spin_lock. Do you have any comment about this? Thanks, Houlong On Mon, 2018-01-08 at 16:38 +0800, houlong wei wrote: > Hi Jassi, > > Sorry for reply so late. > According to previous discussion, there are

Re: FW: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-17 Thread houlong wei
Sorry to send the mail again because I missed some mail lists by mistake. Hi Jassi, We prefer to use method (1) to move dma_map_single() outside of spin_lock. Do you have any comment about this? Thanks, Houlong On Mon, 2018-01-08 at 16:38 +0800, houlong wei wrote: > Hi Jassi, > &

Re: [PATCH v21 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-02-08 Thread houlong wei
helper to create CMDQ packet and assemble GCE op code. > > > > Signed-off-by: Houlong Wei <houlong@mediatek.com> > > Signed-off-by: HS Liao <hs.l...@mediatek.com> > > --- > > drivers/soc/mediatek/Kconfig | 12 ++ > > d

Re: [PATCH v23 3/4] arm64: dts: mt8173: Add GCE node

2018-08-14 Thread houlong wei
On Wed, 2018-07-25 at 09:26 +0800, Houlong Wei wrote: > This patch adds the device node of the GCE hardware for CMDQ module. > > Signed-off-by: Houlong Wei > Signed-off-by: HS Liao > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++ > 1 file changed, 10 in

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-08-14 Thread houlong wei
On Wed, 2018-07-25 at 09:26 +0800, Houlong Wei wrote: > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > > Signed-off-by: Houlong Wei > Signed-off-by: HS Liao > --- > drivers/soc/mediatek/Kconfig | 12 ++ > drivers/soc/mediatek/Mak

[PATCH] mailbox: mediatek: Add check for possible failure of kzalloc

2018-08-21 Thread Houlong Wei
: mediatek: Add Mediatek CMDQ driver") Reported-by: Dan Carpenter Signed-off-by: Houlong Wei --- drivers/mailbox/mtk-cmdq-mailbox.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index aec46d5..f7cc29c 100644 -

[PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-07-24 Thread Houlong Wei
Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- drivers/soc/mediatek/Kconfig | 12 ++ drivers/soc/mediatek/Makefile |1 + drivers/soc/mediatek/mtk-cmdq-helper.c | 291

[PATCH v23 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit

2018-07-24 Thread Houlong Wei
This adds documentation for the MediaTek Global Command Engine (GCE) unit found in MT8173 SoCs. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- .../devicetree/bindings/mailbox/mtk-gce.txt| 57 include/dt-bindings/gce/mt8173-gce.h | 44

[PATCH v23 0/4] MediaTek MT8173 CMDQ support

2018-07-24 Thread Houlong Wei
Changes since v21: -rebase on v4.18-rc1 -remove subsys code and event id definition from mtk-cmdq-helper.c -add mt8173-gce.h to define the subsys code and envent id Changes since v20: -rebase on v4.15-rc1 -move dma_map_single outside of spinlock Changes since v19: - rebase to v4.10-rc2 Houlong

[PATCH v23 3/4] arm64: dts: mt8173: Add GCE node

2018-07-24 Thread Houlong Wei
This patch adds the device node of the GCE hardware for CMDQ module. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts

[PATCH v23 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-07-24 Thread Houlong Wei
supports display related hardwares, but we expect it can be extended to other hardwares for future requirements. Signed-off-by: Houlong Wei Signed-off-by: HS Liao Signed-off-by: CK Hu --- drivers/mailbox/Kconfig | 10 + drivers/mailbox/Makefile |2

Re: [PATCH v23 3/4] arm64: dts: mt8173: Add GCE node

2018-09-09 Thread houlong wei
On Wed, 2018-08-15 at 09:48 +0800, houlong wei wrote: > On Wed, 2018-07-25 at 09:26 +0800, Houlong Wei wrote: > > This patch adds the device node of the GCE hardware for CMDQ module. > > [...] Hello Matthias, Sorry to disturb you. Are you availabe to review this patch and gi

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-09 Thread houlong wei
On Wed, 2018-08-15 at 09:46 +0800, houlong wei wrote: > On Wed, 2018-07-25 at 09:26 +0800, Houlong Wei wrote: > > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > >[...] Hello Matthias, Sorry to disturb you. Could you please review this patch and gi

Re: [PATCH v22 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-07-05 Thread houlong wei
On Wed, 2018-07-04 at 17:03 +0800, CK Hu wrote: > Hi, Houlong: > > On Wed, 2018-07-04 at 08:10 +0800, houlong wei wrote: > > On Fri, 2018-06-29 at 15:08 +0800, CK Hu wrote: > > > Hi, Houlong: > > > > > > Some inline comment. > > > > &g

Re: [PATCH v22 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-07-05 Thread houlong wei
On Wed, 2018-07-04 at 10:39 +0800, CK Hu wrote: > Hi, Houlong: > > On Wed, 2018-07-04 at 08:47 +0800, houlong wei wrote: > > On Fri, 2018-06-29 at 17:22 +0800, CK Hu wrote: > > > Hi, Houlong: > > > > > > On Fri, 2018-06-29 at 07:32 +0800, houlong wei

Re: [PATCH v22 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit

2018-07-05 Thread houlong wei
On Fri, 2018-07-06 at 04:08 +0800, Rob Herring wrote: > On Tue, Jul 3, 2018 at 5:39 PM houlong wei wrote: > > > > On Tue, 2018-07-03 at 10:30 +0800, Rob Herring wrote: > > > On Wed, Jun 27, 2018 at 07:16:09PM +0800, Houlong Wei wrote: > > > > This adds d

Re: [PATCH v22 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-06-28 Thread houlong wei
On Thu, 2018-06-28 at 18:41 +0800, CK Hu wrote: > Hi, Houlong: > > Some inline comment. > > On Wed, 2018-06-27 at 19:16 +0800, Houlong Wei wrote: > > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > > > > Signed-off-by: Houlon

Re: [PATCH v21 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-06-28 Thread houlong wei
On Thu, 2018-06-28 at 09:57 +0800, CK Hu wrote: > Hi, Houlong: > > On Wed, 2018-06-27 at 19:53 +0800, houlong wei wrote: > > On Wed, 2018-02-21 at 11:53 +0800, CK Hu wrote: > > > Hi, Houlong: > > > > > > I've one inline comment. > > >

[PATCH v26 2/2] soc: mediatek: Add Mediatek CMDQ helper

2018-10-07 Thread Houlong Wei
Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- drivers/soc/mediatek/Kconfig | 12 ++ drivers/soc/mediatek/Makefile |1 + drivers/soc/mediatek/mtk-cmdq-helper.c | 292

[PATCH v26 1/2] arm64: dts: mt8173: Add GCE node

2018-10-07 Thread Houlong Wei
This patch adds the device node of the GCE hardware for CMDQ module. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts

[PATCH v26 0/2] MediaTek MT8173 CMDQ support

2018-10-07 Thread Houlong Wei
of spinlock Changes since v19: -rebase to v4.10-rc2 Houlong Wei (2): arm64: dts: mt8173: Add GCE node soc: mediatek: Add Mediatek CMDQ helper arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 + drivers/soc/mediatek/Kconfig | 12 ++ drivers/soc/mediatek/Makefile|1

Re: [PATCH v25 2/2] soc: mediatek: Add Mediatek CMDQ helper

2018-10-07 Thread houlong wei
On Sat, 2018-09-29 at 20:50 +0800, Matthias Brugger wrote: > > On 29/09/2018 11:21, Houlong Wei wrote: > [...] > > > +static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code > > code, > > + u32 arg_a, u32 arg_

Re: [PATCH v26 2/2] soc: mediatek: Add Mediatek CMDQ helper

2018-10-24 Thread houlong wei
On Mon, 2018-10-08 at 11:43 +0800, Houlong Wei wrote: > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > > Signed-off-by: Houlong Wei > Signed-off-by: HS Liao > --- > drivers/soc/mediatek/Kconfig | 12 ++ > drivers/soc/mediatek/Mak

[PATCH v25 1/2] arm64: dts: mt8173: Add GCE node

2018-09-29 Thread Houlong Wei
This patch adds the device node of the GCE hardware for CMDQ module. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts

[PATCH v25 2/2] soc: mediatek: Add Mediatek CMDQ helper

2018-09-29 Thread Houlong Wei
Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- drivers/soc/mediatek/Kconfig | 12 ++ drivers/soc/mediatek/Makefile |1 + drivers/soc/mediatek/mtk-cmdq-helper.c | 291

MediaTek MT8173 CMDQ support

2018-09-29 Thread Houlong Wei
: -rebase on v4.18-rc1 -remove subsys code and event id definition from mtk-cmdq-helper.c -add mt8173-gce.h to define the subsys code and envent id Changes since v20: -rebase on v4.15-rc1 -move dma_map_single outside of spinlock Changes since v19: -rebase to v4.10-rc2 Houlong Wei (2): arm64: dts

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-26 Thread houlong wei
On Wed, 2018-09-26 at 23:53 +0800, Matthias Brugger wrote: > > On 25/07/2018 03:26, Houlong Wei wrote: > > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > > > > Signed-off-by: Houlong Wei > > Signed-off-by: HS Liao > > -

[PATCH v24 0/2] MediaTek MT8173 CMDQ support

2018-09-27 Thread Houlong Wei
-helper.c -add mt8173-gce.h to define the subsys code and envent id Changes since v20: -rebase on v4.15-rc1 -move dma_map_single outside of spinlock Changes since v19: -rebase to v4.10-rc2 Houlong Wei (2): arm64: dts: mt8173: Add GCE node soc: mediatek: Add Mediatek CMDQ helper arch/arm64/boot

[PATCH v24 2/2] soc: mediatek: Add Mediatek CMDQ helper

2018-09-27 Thread Houlong Wei
Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- drivers/soc/mediatek/Kconfig | 12 ++ drivers/soc/mediatek/Makefile |1 + drivers/soc/mediatek/mtk-cmdq-helper.c | 292

[PATCH v24 1/2] arm64: dts: mt8173: Add GCE node

2018-09-27 Thread Houlong Wei
This patch adds the device node of the GCE hardware for CMDQ module. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-27 Thread houlong wei
On Thu, 2018-09-27 at 15:50 +0800, Matthias Brugger wrote: > > On 27/09/2018 03:57, houlong wei wrote: [...] > >>> + > >>> +static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code > >>> code, > >>> +

[PATCH v27 0/2] MediaTek MT8173 CMDQ support

2018-11-28 Thread Houlong Wei
-helper.c -add mt8173-gce.h to define the subsys code and envent id Changes since v20: -rebase on v4.15-rc1 -move dma_map_single outside of spinlock Changes since v19: -rebase to v4.10-rc2 Houlong Wei (2): arm64: dts: mt8173: Add GCE node soc: mediatek: Add Mediatek CMDQ helper arch/arm64/boot

[PATCH v27 1/2] arm64: dts: mt8173: Add GCE node

2018-11-28 Thread Houlong Wei
This patch adds the device node of the GCE hardware for CMDQ module. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts

[PATCH v27 2/2] soc: mediatek: Add Mediatek CMDQ helper

2018-11-28 Thread Houlong Wei
Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- drivers/soc/mediatek/Kconfig | 12 ++ drivers/soc/mediatek/Makefile |1 + drivers/soc/mediatek/mtk-cmdq-helper.c | 300

Re: FW: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-08 Thread houlong wei
ead.org; > srv_heupstream ; Sascha Hauer > ; Philipp Zabel ; Nicolas > Boichat ; CK Hu (胡俊光) ; Cawa Cheng > (鄭曄禧) ; Bibby Hsieh (謝濟遠) > ; YT Shen (沈岳霆) ; Daoyuan > Huang (黃道原) ; Damon Chu (朱峻賢) > ; Josh-YC Liu (劉育誠) ; Glory > Hung (洪智瑋) ; Jiaguang Zhang (张加广) &g

[PATCH] soc: mediatek: cmdq: fixup possible timeout issue

2020-10-22 Thread Houlong Wei
_cnt. 2.Optimize the time to start the timer. Signed-off-by: Houlong Wei --- drivers/soc/mediatek/mtk-cmdq-helper.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c in

Re: [PATCH v12 09/12] soc: mediatek: cmdq: define the instruction struct

2019-08-19 Thread houlong wei
On Mon, 2019-08-19 at 10:53 +0800, Bibby Hsieh wrote: > Define an instruction structure for gce driver to append command. > This structure can make the client's code more readability. > > Signed-off-by: Bibby Hsieh > Reviewed-by: CK Hu > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 105

Re: [PATCH v12 11/12] soc: mediatek: cmdq: add cmdq_dev_get_client_reg function

2019-08-19 Thread houlong wei
On Mon, 2019-08-19 at 10:53 +0800, Bibby Hsieh wrote: > GCE cannot know the register base address, this function > can help cmdq client to get the cmdq_client_reg structure. > > Signed-off-by: Bibby Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 29 ++ >

Re: [RESEND, PATCH v13 09/12] soc: mediatek: cmdq: define the instruction struct

2019-08-20 Thread houlong wei
Reviewed-by: Houlong Wei On Tue, 2019-08-20 at 16:49 +0800, Bibby Hsieh wrote: > Define an instruction structure for gce driver to append command. > This structure can make the client's code more readability. > > Signed-off-by: Bibby Hsieh > Reviewed-by: CK Hu > --- >

Re: [RESEND, PATCH v13 11/12] soc: mediatek: cmdq: add cmdq_dev_get_client_reg function

2019-08-20 Thread houlong wei
Reviewed-by: Houlong Wei

Re: [RESEND, PATCH v13 11/12] soc: mediatek: cmdq: add cmdq_dev_get_client_reg function

2019-08-20 Thread houlong wei
e node of CMDQ client. > + */ > +int cmdq_dev_get_client_reg(struct device *dev, > + struct cmdq_client_reg *client_reg, int idx); > + > /** > * cmdq_mbox_create() - create CMDQ mailbox client and channel > * @dev: device of CMDQ mailbox client Reviewed-by: Houlong Wei

Re: [RESEND, PATCH v13 10/12] soc: mediatek: cmdq: add polling function

2019-08-20 Thread houlong wei
> + */ > +int cmdq_pkt_poll(struct cmdq_pkt *pkt, u8 subsys, > + u16 offset, u32 value, u32 mask); > /** > * cmdq_pkt_flush_async() - trigger CMDQ to asynchronously execute the CMDQ > * packet and call back at the end of done packet Reviewed-by: Houlong Wei

Re: [PATCH v21 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-02-08 Thread houlong wei
et and assemble GCE op code. > > > > Signed-off-by: Houlong Wei > > Signed-off-by: HS Liao > > --- > > drivers/soc/mediatek/Kconfig | 12 ++ > > drivers/soc/mediatek/Makefile |1 + > > drivers/soc/mediatek/mtk-cmdq-helper.c |

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-17 Thread houlong wei
Hi Jassi, We prefer to use method (1) to move dma_map_single() outside of spin_lock. Do you have any comment about this? Thanks, Houlong On Mon, 2018-01-08 at 16:38 +0800, houlong wei wrote: > Hi Jassi, > > Sorry for reply so late. > According to previous discussion, there are

Re: FW: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-17 Thread houlong wei
Sorry to send the mail again because I missed some mail lists by mistake. Hi Jassi, We prefer to use method (1) to move dma_map_single() outside of spin_lock. Do you have any comment about this? Thanks, Houlong On Mon, 2018-01-08 at 16:38 +0800, houlong wei wrote: > Hi Jassi, > &

Re: FW: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-01-18 Thread houlong wei
Hi Jassi, There is one request for one GCE h/w buffer which contains a list of registers operation. I will resubmit a version and please review again. Thanks, Houlong On Thu, 2018-01-18 at 16:01 +0800, Jassi Brar wrote: > On Mon, Jan 8, 2018 at 2:08 PM, houlong wei wrote: > >

Re: [PATCH] [media] media: mtk-mdp: fix reference count on old device tree

2019-07-12 Thread houlong wei
new DTB. > > > > Fixes: ba1f1f70c2c0 ("[media] media: mtk-mdp: Fix mdp device tree") > > Signed-off-by: Matthias Brugger > > Any comments on that? > Hi Matthias, Thanks for fixing the bug. Sorry to reply late~ Acked-by: Houlong Wei > > --- > > driv

Re: [PATCH v14 07/10] soc: mediatek: cmdq: define the instruction struct

2019-08-29 Thread houlong wei
On Thu, 2019-08-29 at 09:48 +0800, Bibby Hsieh wrote: > Define an instruction structure for gce driver to append command. > This structure can make the client's code more readability. > > Signed-off-by: Bibby Hsieh > Reviewed-by: CK Hu > Reviewed-by: Houlong Wei > --- &g

Re: [PATCH v11 09/12] soc: mediatek: cmdq: define the instruction struct

2019-08-10 Thread houlong wei
Hi Bibby, I have inline comment in function cmdq_pkt_write_mask(). On Mon, 2019-07-29 at 15:01 +0800, Bibby Hsieh wrote: > Define an instruction structure for gce driver to append command. > This structure can make the client's code more readability. > > Signed-off-by: Bibby Hsieh >

Re: [PATCH v11 11/12] soc: mediatek: cmdq: add cmdq_dev_get_client_reg function

2019-08-10 Thread houlong wei
On Mon, 2019-07-29 at 15:01 +0800, Bibby Hsieh wrote: > GCE cannot know the register base address, this function > can help cmdq client to get the cmdq_client_reg structure. > > Signed-off-by: Bibby Hsieh > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 29 ++ >

Re: [PATCH v11 12/12] arm64: dts: add gce node for mt8183

2019-08-10 Thread houlong wei
On Mon, 2019-07-29 at 15:01 +0800, Bibby Hsieh wrote: > add gce device node for mt8183 > > Signed-off-by: Bibby Hsieh > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi >

Re: [PATCH v11 09/12] soc: mediatek: cmdq: define the instruction struct

2019-08-10 Thread houlong wei
On Sun, 2019-08-11 at 00:12 +0800, houlong wei wrote: > Hi Bibby, I have inline comment in function cmdq_pkt_write_mask(). > > On Mon, 2019-07-29 at 15:01 +0800, Bibby Hsieh wrote: > > Define an instruction structure for gce driver to append command. > > This structure can m

[PATCH v22 0/4] MediaTek MT8173 CMDQ support

2018-06-27 Thread Houlong Wei
on v4.18-rc1 -remove subsys code and event id definition from mtk-cmdq-helper.c -add mt8173-gce.h to define the subsys code and envent id Changes since v20: -rebase on v4.15-rc1 -move dma_map_single outside of spinlock Changes since v19: - rebase to v4.10-rc2 Houlong Wei (4): dt-bindings: soc

[PATCH v22 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit

2018-06-27 Thread Houlong Wei
This adds documentation for the MediaTek Global Command Engine (GCE) unit found in MT8173 SoCs. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- Hi Rob, I don't add your ACK in this version since the dt-binding description has been changed. Thanks. --- .../devicetree/bindings/mailbox

[PATCH v22 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-06-27 Thread Houlong Wei
supports display related hardwares, but we expect it can be extended to other hardwares for future requirements. Signed-off-by: Houlong Wei Signed-off-by: HS Liao Signed-off-by: CK Hu --- drivers/mailbox/Kconfig | 10 + drivers/mailbox/Makefile |2

[PATCH v22 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-06-27 Thread Houlong Wei
Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- drivers/soc/mediatek/Kconfig | 12 ++ drivers/soc/mediatek/Makefile |1 + drivers/soc/mediatek/mtk-cmdq-helper.c | 258

[PATCH v22 3/4] arm64: dts: mt8173: Add GCE node

2018-06-27 Thread Houlong Wei
This patch adds the device node of the GCE hardware for CMDQ module. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts

Re: [PATCH v21 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-06-27 Thread houlong wei
et and assemble GCE op code. > > > > Signed-off-by: Houlong Wei > > Signed-off-by: HS Liao > > --- > > drivers/soc/mediatek/Kconfig | 12 ++ > > drivers/soc/mediatek/Makefile |1 + > > drivers/soc/mediatek/mtk-cmdq-helper.c |

Re: [PATCH v21 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-06-27 Thread houlong wei
create CMDQ packet and assemble GCE op code. > > > > Signed-off-by: Houlong Wei > > Signed-off-by: HS Liao > > --- > > drivers/soc/mediatek/Kconfig | 12 ++ > > drivers/soc/mediatek/Makefile |1 + > > drivers/soc/mediatek/mtk-cmdq-helper.c |

Re: [PATCH v21 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-06-27 Thread houlong wei
rts display related hardwares, but we expect > > it can be extended to other hardwares for future requirements. > > > > Signed-off-by: Houlong Wei > > Signed-off-by: HS Liao > > Signed-off-by: CK Hu > > --- > > drivers/mailbox/Kconfig

Re: [PATCH v21 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-06-28 Thread houlong wei
On Thu, 2018-06-28 at 09:57 +0800, CK Hu wrote: > Hi, Houlong: > > On Wed, 2018-06-27 at 19:53 +0800, houlong wei wrote: > > On Wed, 2018-02-21 at 11:53 +0800, CK Hu wrote: > > > Hi, Houlong: > > > > > > I've one inline comment. > > >

Re: [PATCH v22 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-06-28 Thread houlong wei
On Thu, 2018-06-28 at 18:41 +0800, CK Hu wrote: > Hi, Houlong: > > Some inline comment. > > On Wed, 2018-06-27 at 19:16 +0800, Houlong Wei wrote: > > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > > > > Signed-off-by: Houlon

[PATCH v27 0/2] MediaTek MT8173 CMDQ support

2018-11-28 Thread Houlong Wei
-helper.c -add mt8173-gce.h to define the subsys code and envent id Changes since v20: -rebase on v4.15-rc1 -move dma_map_single outside of spinlock Changes since v19: -rebase to v4.10-rc2 Houlong Wei (2): arm64: dts: mt8173: Add GCE node soc: mediatek: Add Mediatek CMDQ helper arch/arm64/boot

[PATCH v27 1/2] arm64: dts: mt8173: Add GCE node

2018-11-28 Thread Houlong Wei
This patch adds the device node of the GCE hardware for CMDQ module. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts

[PATCH v27 2/2] soc: mediatek: Add Mediatek CMDQ helper

2018-11-28 Thread Houlong Wei
Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- drivers/soc/mediatek/Kconfig | 12 ++ drivers/soc/mediatek/Makefile |1 + drivers/soc/mediatek/mtk-cmdq-helper.c | 300

[PATCH] mailbox: mediatek: Add check for possible failure of kzalloc

2018-08-21 Thread Houlong Wei
: mediatek: Add Mediatek CMDQ driver") Reported-by: Dan Carpenter Signed-off-by: Houlong Wei --- drivers/mailbox/mtk-cmdq-mailbox.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index aec46d5..f7cc29c 100644 -

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-08-14 Thread houlong wei
On Wed, 2018-07-25 at 09:26 +0800, Houlong Wei wrote: > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > > Signed-off-by: Houlong Wei > Signed-off-by: HS Liao > --- > drivers/soc/mediatek/Kconfig | 12 ++ > drivers/soc/mediatek/Mak

Re: [PATCH v23 3/4] arm64: dts: mt8173: Add GCE node

2018-08-14 Thread houlong wei
On Wed, 2018-07-25 at 09:26 +0800, Houlong Wei wrote: > This patch adds the device node of the GCE hardware for CMDQ module. > > Signed-off-by: Houlong Wei > Signed-off-by: HS Liao > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++ > 1 file changed, 10 in

MediaTek MT8173 CMDQ support

2018-09-29 Thread Houlong Wei
: -rebase on v4.18-rc1 -remove subsys code and event id definition from mtk-cmdq-helper.c -add mt8173-gce.h to define the subsys code and envent id Changes since v20: -rebase on v4.15-rc1 -move dma_map_single outside of spinlock Changes since v19: -rebase to v4.10-rc2 Houlong Wei (2): arm64: dts

[PATCH v25 1/2] arm64: dts: mt8173: Add GCE node

2018-09-29 Thread Houlong Wei
This patch adds the device node of the GCE hardware for CMDQ module. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts

[PATCH v25 2/2] soc: mediatek: Add Mediatek CMDQ helper

2018-09-29 Thread Houlong Wei
Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- drivers/soc/mediatek/Kconfig | 12 ++ drivers/soc/mediatek/Makefile |1 + drivers/soc/mediatek/mtk-cmdq-helper.c | 291

Re: [PATCH] arm64: dts: add gce node for mt8183

2019-03-06 Thread houlong wei
On Thu, 2019-03-07 at 09:24 +0800, CK Hu wrote: > Hi, Bibby: > > On Wed, 2019-03-06 at 18:10 +0800, Bibby Hsieh wrote: > > This patch need based on v5.0-rc1 and these series > > http://lists.infradead.org/pipermail/linux-mediatek/2019-February/017570.html > >

Re: [PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-09-09 Thread houlong wei
On Wed, 2018-08-15 at 09:46 +0800, houlong wei wrote: > On Wed, 2018-07-25 at 09:26 +0800, Houlong Wei wrote: > > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > >[...] Hello Matthias, Sorry to disturb you. Could you please review this patch and gi

Re: [PATCH v23 3/4] arm64: dts: mt8173: Add GCE node

2018-09-09 Thread houlong wei
On Wed, 2018-08-15 at 09:48 +0800, houlong wei wrote: > On Wed, 2018-07-25 at 09:26 +0800, Houlong Wei wrote: > > This patch adds the device node of the GCE hardware for CMDQ module. > > [...] Hello Matthias, Sorry to disturb you. Are you availabe to review this patch and gi

[PATCH v23 0/4] MediaTek MT8173 CMDQ support

2018-07-24 Thread Houlong Wei
Changes since v21: -rebase on v4.18-rc1 -remove subsys code and event id definition from mtk-cmdq-helper.c -add mt8173-gce.h to define the subsys code and envent id Changes since v20: -rebase on v4.15-rc1 -move dma_map_single outside of spinlock Changes since v19: - rebase to v4.10-rc2 Houlong

[PATCH v23 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit

2018-07-24 Thread Houlong Wei
This adds documentation for the MediaTek Global Command Engine (GCE) unit found in MT8173 SoCs. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- .../devicetree/bindings/mailbox/mtk-gce.txt| 57 include/dt-bindings/gce/mt8173-gce.h | 44

[PATCH v23 3/4] arm64: dts: mt8173: Add GCE node

2018-07-24 Thread Houlong Wei
This patch adds the device node of the GCE hardware for CMDQ module. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts

[PATCH v23 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-07-24 Thread Houlong Wei
supports display related hardwares, but we expect it can be extended to other hardwares for future requirements. Signed-off-by: Houlong Wei Signed-off-by: HS Liao Signed-off-by: CK Hu --- drivers/mailbox/Kconfig | 10 + drivers/mailbox/Makefile |2

[PATCH v23 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-07-24 Thread Houlong Wei
Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. Signed-off-by: Houlong Wei Signed-off-by: HS Liao --- drivers/soc/mediatek/Kconfig | 12 ++ drivers/soc/mediatek/Makefile |1 + drivers/soc/mediatek/mtk-cmdq-helper.c | 291

Re: [PATCH v22 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit

2018-07-03 Thread houlong wei
On Tue, 2018-07-03 at 10:30 +0800, Rob Herring wrote: > On Wed, Jun 27, 2018 at 07:16:09PM +0800, Houlong Wei wrote: > > This adds documentation for the MediaTek Global Command Engine (GCE) unit > > found in MT8173 SoCs. > > > > Signed-off-by: Houlong Wei

Re: [PATCH v22 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-07-03 Thread houlong wei
On Fri, 2018-06-29 at 15:08 +0800, CK Hu wrote: > Hi, Houlong: > > Some inline comment. > > On Wed, 2018-06-27 at 19:16 +0800, Houlong Wei wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help write registers wi

Re: [PATCH v22 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-07-03 Thread houlong wei
On Fri, 2018-06-29 at 17:22 +0800, CK Hu wrote: > Hi, Houlong: > > On Fri, 2018-06-29 at 07:32 +0800, houlong wei wrote: > > On Thu, 2018-06-28 at 18:41 +0800, CK Hu wrote: > > > Hi, Houlong: > > > > > > Some inline comment. > > > > &g

Re: [PATCH v22 4/4] soc: mediatek: Add Mediatek CMDQ helper

2018-07-05 Thread houlong wei
On Wed, 2018-07-04 at 10:39 +0800, CK Hu wrote: > Hi, Houlong: > > On Wed, 2018-07-04 at 08:47 +0800, houlong wei wrote: > > On Fri, 2018-06-29 at 17:22 +0800, CK Hu wrote: > > > Hi, Houlong: > > > > > > On Fri, 2018-06-29 at 07:32 +0800, houlong wei

Re: [PATCH v22 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

2018-07-05 Thread houlong wei
On Wed, 2018-07-04 at 17:03 +0800, CK Hu wrote: > Hi, Houlong: > > On Wed, 2018-07-04 at 08:10 +0800, houlong wei wrote: > > On Fri, 2018-06-29 at 15:08 +0800, CK Hu wrote: > > > Hi, Houlong: > > > > > > Some inline comment. > > > > &g

Re: [PATCH v22 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit

2018-07-05 Thread houlong wei
On Fri, 2018-07-06 at 04:08 +0800, Rob Herring wrote: > On Tue, Jul 3, 2018 at 5:39 PM houlong wei wrote: > > > > On Tue, 2018-07-03 at 10:30 +0800, Rob Herring wrote: > > > On Wed, Jun 27, 2018 at 07:16:09PM +0800, Houlong Wei wrote: > > > > This adds d

Re: [PATCH v26 2/2] soc: mediatek: Add Mediatek CMDQ helper

2018-10-24 Thread houlong wei
On Mon, 2018-10-08 at 11:43 +0800, Houlong Wei wrote: > Add Mediatek CMDQ helper to create CMDQ packet and assemble GCE op code. > > Signed-off-by: Houlong Wei > Signed-off-by: HS Liao > --- > drivers/soc/mediatek/Kconfig | 12 ++ > drivers/soc/mediatek/Mak

  1   2   >